Hi Gustaf
thanks for the explanation of the cause of the issue.
I have forked the docker image from oupfiz5, and changed it to run 4.99.27,
which was how I discovered the issue. That Dockerfile relies on the existence
of the official naviserver-"${NS_VERSION}".tar.gz and
naviserver-"${NS_MODULES_VERSION}"-modules.tar.gz files, so I can't just easily
patch in this fix.
We have no deadline for a new release. For now, we can continue to use 4.99.24
in our testing, but obviously we would like to explain to clients why we're not
running the latest version. If we can tell them e.g. there will soon be a new
official release which includes the ns_set bugfix, that will keep them happy.
cheers
Brian
________________________________
From: Gustaf Neumann <[email protected]>
Sent: Friday 18 August 2023 7:51 pm
To: [email protected]
<[email protected]>
Subject: Re: [naviserver-devel] Crashing on all versions >4.99.24 on Ubuntu
> FYI, also the "ns_set put" crashes the server e.g. if I run this in /ds/shell:
it is clear. The problem were not the "ns_set update" or the "ns_set put"
commands itself, but the fact, that the key "content-type" was in lower-case
and the normalization of the output headers was causing the crash. Some ages
ago, it was possible to set two different header values with upper and lower
case keys, leading to some unspecified behaviors in browsers.
On 18.08.23 15:55, Brian Fenton wrote:
Hi again Gustaf
Great news, this seems to have worked according to all my tests. I am assuming
that I built this correctly with the "version_ns=GIT" parameter:
version_ns=GIT ns_modules="nsconf nsstats" with_postgres=0
with_postgres_driver=0 bash install-ns.sh build
by your parameter list, you will get the newest version from git.... which is
the unreleased version of NaviServer 5. If one specifies the branch as well,
different versions can be installed from git. E.g.,
... version_ns=GIT git_branch_ns=release/4.99 ....
installs the newest version from the release/4.99 branch, what you probably
want.
But one can use as well arbitrary tags. For example
... version_ns=GIT git_branch_ns=naviserver-4.99.16 ....
will checkout the released version of NaviServer 4.99.16 via git.
Do you have an idea when this will be included in an official Naviserver
release? Our Docker build relies on the official releases, so it would be good
to have a timeframe on that.
When you use the docker image from oupfiz5, these are still based on 4.99.24
(released on 2022-06-14, a year ago).
Anyhow, when do you need a release?
all the best
-g
thanks again for the amazing support,
Brian
________________________________
From: Gustaf Neumann <[email protected]><mailto:[email protected]>
Sent: Friday 18 August 2023 12:30 pm
To:
[email protected]<mailto:[email protected]>
<[email protected]><mailto:[email protected]>
Subject: Re: [naviserver-devel] Crashing on all versions >4.99.24 on Ubuntu
Hi Brian,
With your input, I could locate the source of the problem and fix this
in the repository. It was an ns_set but, that could only happen with the
output headers, when the code normalized the capitalization of the
header fields. There is now a test for this in the regression test suite
of NaviServer.
Many thanks for your patience and input!
-g
https://bitbucket.org/naviserver/naviserver/commits/4f8cf8a548bc60f88756a30f33f6a5b589fc6997
_______________________________________________
naviserver-devel mailing list
[email protected]<mailto:[email protected]>
https://lists.sourceforge.net/lists/listinfo/naviserver-devel
_______________________________________________
naviserver-devel mailing list
[email protected]<mailto:[email protected]>
https://lists.sourceforge.net/lists/listinfo/naviserver-devel
--
Univ.Prof. Dr. Gustaf Neumann
Head of the Institute of Information Systems and New Media
of Vienna University of Economics and Business
Program Director of MSc "Information Systems"
_______________________________________________
naviserver-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/naviserver-devel
