> On Saturday, January 28, 2012, Julie S wrote:
>
>> Sounds like we are all on the same page then.  I was just concerned
>> because
>> earlier version of the code had a hard coded if (channel == 10) then
>> "don't do magic" line in it.
>
> I see what you mean, although I think we just about still have to reserve
> channel 10 for use by percussion, and not allow it to be allocated freely
> like
> any other channel.  Otherwise, if Rosegarden wanted to use channel 10 for
> a
> piano or something, it would have to know how to turn percussion off on
> that
> channel.

That's exactly how it is right now in the branch.  I would have made it
more flexible, but of the two things it would be useful for, neither was
available to me.  That is, flexible devices and pooling identical devices.

> This seems to imply Rosegarden needing to know more about the
> characteristics
> of a device than what is currently defined in a device definition;
> specifically, how to turn percussion mode off and on per channel.  There
> isn't
> just one way to do this, and it definitely doesn't seem worth it to me to
> get
> into all that.

Ah.  I was wondering about exactly that.

If it varies by device characteristics, that's more than I'm up for.  I
check percussion-ness via MidiDevice::isPercussionNumber (no more "== 9"s
scattered around), so if someone works on that, making isPercussionNumber
smarter should make it all work (I hope.  No way to test that theory now)

> I'm not sure what the implications are for somebody who uses some other
> means
> to set up percussion mode on channel 16, say.  That's probably where being
> able to fix the channel to the instrument number (#16 to 16) will come
> into
> play, and that will _probably_ be sufficient.

I think so too.  It satisfies every case I can think of.

        Tom Breton (Tehom)



------------------------------------------------------------------------------
Try before you buy = See our experts in action!
The most comprehensive online learning library for Microsoft developers
is just $99.99! Visual Studio, SharePoint, SQL - plus HTML5, CSS3, MVC3,
Metro Style Apps, more. Free future releases when you subscribe now!
http://p.sf.net/sfu/learndevnow-dev2
_______________________________________________
Rosegarden-devel mailing list
[email protected] - use the link below to unsubscribe
https://lists.sourceforge.net/lists/listinfo/rosegarden-devel

Reply via email to