Re: [concordance-devel] website not generating config blobs?
On 1/8/20 9:18 AM, Scott Talbert wrote: It's working fine for me with a 700 and Firefox on Linux today. It worked for me fine also with a 900 over the weekend. There were some issues with the networking for the 900 though, so I ended up having to use the Windows software. :( I'll have to sort that out. Thanks. It always seems to not work over the holidays when I'm trying to update my parents' remote, but then starts working again a few days later. *sigh* - Phil ___ concordance-devel mailing list concordance-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/concordance-devel
[concordance-devel] website not generating config blobs?
Anyone else having issues with the website generating config blobs? I can go through the "Communication test", then when you get to the page where it's "queueing your request", it stays there for a second and redirects to a page that says: ``` Unable to display content. Click Next to continue. ``` And has a "next" button which takes you back to the Home... so I never get a config blob to pass to congruity/concordance. What's interesting is that the URL is this: http://members.harmonyremote.com/EasyZapper/Error.asp?ErrorType=VB%20Error%20%2891%29%28Object%20variable%20or%20With%20block%20variable%20not%20set%29%28PrUpdate%29=%2FEasyZapper%2FNew%2FMain%2Easp= Not the error there: Object variable or with block variable not set. I wonder if there's somethign new we need to pass back in the connectivity test response? I'm on an 880 in Firefox on Linux. Chrome won't even load the site for me. Anyone else? -- Phil Dibowitz p...@ipom.com Open Source software and tech docsInsanity Palace of Metallica http://www.phildev.net/ http://www.ipom.com/ "Be who you are and say what you feel, because those who mind don't matter and those who matter don't mind." - Dr. Seuss signature.asc Description: PGP signature ___ concordance-devel mailing list concordance-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/concordance-devel
Re: [concordance-devel] Version 1.4 released
On 11/10/19 5:32 PM, Scott Talbert wrote: > On Fri, 8 Nov 2019, Scott Talbert wrote: > >>> Version 1.4 has been released. >>> >>> Hey Scott, >>> >>> I think you built the Windows binaries last time... you had access to a >>> Fedora box with mingw32-zlib and friends. If I build on Debian I have >>> to >>> go grab a binary dll from http://www.winimage.com/ which I don't love. >> >> Yeah, I can do it, but probably not until Sunday. > > Here is the 1.4 Windows build: > https://www.techie.net/~talbert/concordance-1.4-installer.exe > > BTW, I commented on GitHub but there is another place in the Windows > installer configuration that you have to bump the DLL version - the > Uninstall section. It's probably not a big enough deal to cut another > release though. I think this was broken in the previous release too. :) Thanks! I know how to collapse most of those... most of them can include a header file... except the MSI one, no idea how to get that one to reference an external file. Windows installer uploaded to GH release. -- Phil Dibowitz p...@ipom.com Open Source software and tech docsInsanity Palace of Metallica http://www.phildev.net/ http://www.ipom.com/ "Be who you are and say what you feel, because those who mind don't matter and those who matter don't mind." - Dr. Seuss signature.asc Description: OpenPGP digital signature ___ concordance-devel mailing list concordance-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/concordance-devel
[concordance-devel] Version 1.4 released
Version 1.4 has been released. Hey Scott, I think you built the Windows binaries last time... you had access to a Fedora box with mingw32-zlib and friends. If I build on Debian I have to go grab a binary dll from http://www.winimage.com/ which I don't love. :( -- Phil Dibowitz p...@ipom.com Open Source software and tech docsInsanity Palace of Metallica http://www.phildev.net/ http://www.ipom.com/ "Be who you are and say what you feel, because those who mind don't matter and those who matter don't mind." - Dr. Seuss signature.asc Description: OpenPGP digital signature ___ concordance-devel mailing list concordance-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/concordance-devel
Re: [concordance-devel] Harmony website broken?
On 06/08/2018 06:48 PM, Scott Talbert wrote: > Windows build: > https://www.techie.net/~talbert/concordance-1.3-installer.exe > > It seems to have increased in size considerably over last build. I'm > guessing bloat in our dependencies? Oops, I replied to the wrong thread, lol. Anyway - uploaded to GH. Thanks! -- Phil Dibowitz p...@ipom.com Open Source software and tech docsInsanity Palace of Metallica http://www.phildev.net/ http://www.ipom.com/ "Be who you are and say what you feel, because those who mind don't matter and those who matter don't mind." - Dr. Seuss signature.asc Description: OpenPGP digital signature -- Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot___ concordance-devel mailing list concordance-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/concordance-devel
Re: [concordance-devel] Harmony website broken?
On 06/02/2018 02:34 AM, Phil Dibowitz wrote: > On 01/12/2018 02:20 PM, Scott Talbert wrote: >> On Tue, 9 Jan 2018, Phil Dibowitz wrote: >> >>> Has anyone tried to do an update lately? >>> >>> I get past connectivity test, and then when it starts trying to build >>> the config, I get an error from the website... >>> >>> I think they may have finally broken it for good. :( >> >> I just tried. It worked fine for me. > > BTW this started working again for me as well. Done. We need to build windows binaries though. I seem to recall that the mingw stuff on Debian built binaries that didn't work for some people... Scott, if you wanna build binaries I'll post them. If not I can build them myself and we'll see if it works now. :) -- Phil Dibowitz p...@ipom.com Open Source software and tech docsInsanity Palace of Metallica http://www.phildev.net/ http://www.ipom.com/ "Be who you are and say what you feel, because those who mind don't matter and those who matter don't mind." - Dr. Seuss signature.asc Description: OpenPGP digital signature -- Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot___ concordance-devel mailing list concordance-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/concordance-devel
[concordance-devel] [announce] Concordance 1.3 Released!
Concordance 1.3 has been released. This release fixes support for IR learning on the Touch, Ultimate and similar devices. It fixes several small bugs, implements python3 support in the libraries and fixes some documentation bugs. All users are encouraged to upgrade. https://github.com/jaymzh/concordance/releases/tag/v1.3 -- Phil Dibowitz p...@ipom.com Open Source software and tech docsInsanity Palace of Metallica http://www.phildev.net/ http://www.ipom.com/ "Be who you are and say what you feel, because those who mind don't matter and those who matter don't mind." - Dr. Seuss signature.asc Description: OpenPGP digital signature -- Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot___ concordance-devel mailing list concordance-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/concordance-devel
Re: [concordance-devel] Harmony website broken?
On 01/12/2018 02:20 PM, Scott Talbert wrote: > On Tue, 9 Jan 2018, Phil Dibowitz wrote: > >> Has anyone tried to do an update lately? >> >> I get past connectivity test, and then when it starts trying to build >> the config, I get an error from the website... >> >> I think they may have finally broken it for good. :( > > I just tried. It worked fine for me. BTW this started working again for me as well. -- Phil Dibowitz p...@ipom.com Open Source software and tech docsInsanity Palace of Metallica http://www.phildev.net/ http://www.ipom.com/ "Be who you are and say what you feel, because those who mind don't matter and those who matter don't mind." - Dr. Seuss signature.asc Description: OpenPGP digital signature -- Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot___ concordance-devel mailing list concordance-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/concordance-devel
Re: [concordance-devel] New Concordance Release?
On 05/16/2018 07:40 PM, Scott Talbert wrote: > Phil, > > Any chance you could do a new Concordance release? I know there haven't > been many changes, but it would be useful to get the Python 3 fixes out > there. I'm planning to do a new Congruity release soon with Python 3 > support. Yup, long over due. I'll try and knock that out either this weekend or next. -- Phil Dibowitz p...@ipom.com Open Source software and tech docsInsanity Palace of Metallica http://www.phildev.net/ http://www.ipom.com/ "Be who you are and say what you feel, because those who mind don't matter and those who matter don't mind." - Dr. Seuss signature.asc Description: OpenPGP digital signature -- Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot___ concordance-devel mailing list concordance-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/concordance-devel
[concordance-devel] Harmony website broken?
Has anyone tried to do an update lately? I get past connectivity test, and then when it starts trying to build the config, I get an error from the website... I think they may have finally broken it for good. :( -- Phil Dibowitz p...@ipom.com Open Source software and tech docsInsanity Palace of Metallica http://www.phildev.net/ http://www.ipom.com/ "Be who you are and say what you feel, because those who mind don't matter and those who matter don't mind." - Dr. Seuss signature.asc Description: OpenPGP digital signature -- Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot___ concordance-devel mailing list concordance-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/concordance-devel
Re: [concordance-devel] concordance fails to identify Harmony Remote 650
What version of libconcord/concordance are you on? -- Phil Dibowitz p...@ipom.com Open Source software and tech docsInsanity Palace of Metallica http://www.phildev.net/ http://www.ipom.com/ "Be who you are and say what you feel, because those who mind don't matter and those who matter don't mind." - Dr. Seuss signature.asc Description: PGP signature -- What NetFlow Analyzer can do for you? Monitors network bandwidth and traffic patterns at an interface-level. Reveals which users, apps, and protocols are consuming the most bandwidth. Provides multi-vendor support for NetFlow, J-Flow, sFlow and other flows. Make informed decisions using capacity planning reports. https://ad.doubleclick.net/ddm/clk/305295220;132659582;e___ concordance-devel mailing list concordance-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/concordance-devel
Re: [concordance-devel] Please help with my concordance/ congruity
On 08/17/2015 04:08 PM, Scott Talbert wrote: On Mon, 17 Aug 2015, brotherred wrote: -BEGIN PGP MESSAGE- Charset: utf-8 Version: GnuPG v1 Send an unencrypted message, please. Or at least encrypt it to one of the developers. :) -- Phil Dibowitz p...@ipom.com Open Source software and tech docsInsanity Palace of Metallica http://www.phildev.net/ http://www.ipom.com/ Be who you are and say what you feel, because those who mind don't matter and those who matter don't mind. - Dr. Seuss signature.asc Description: OpenPGP digital signature -- ___ concordance-devel mailing list concordance-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/concordance-devel
Re: [concordance-devel] Moved to github!
On Mon, Jul 27, 2015 at 07:49:49PM -0400, Scott Talbert wrote: On Sun, 26 Jul 2015, Phil Dibowitz wrote: After all the crap with Sourceforge highjacking windows installer binaries, I decided to move Moving to Github higher up my priority list. The code, the issues and the latest release have been moved; https://github.com/jaymzh/concordance/ I intend to keep the mailing list on SF for now. I'll remove the code from SF soon. So are pull requests now your preferred mechanism for patch submission? Yes, please. Should make code reviews much more sane. I'd love to spend some time writing some unittests and getting them into Travis too ... but that's been on my list forever. -- Phil Dibowitz p...@ipom.com Open Source software and tech docsInsanity Palace of Metallica http://www.phildev.net/ http://www.ipom.com/ Be who you are and say what you feel, because those who mind don't matter and those who matter don't mind. - Dr. Seuss signature.asc Description: Digital signature -- ___ concordance-devel mailing list concordance-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/concordance-devel
Re: [concordance-devel] [PATCH] Include libwinpthread unconditionally and ensure it is uninstalled
Applied, thanks. -- Phil Dibowitz p...@ipom.com Open Source software and tech docsInsanity Palace of Metallica http://www.phildev.net/ http://www.ipom.com/ Be who you are and say what you feel, because those who mind don't matter and those who matter don't mind. - Dr. Seuss signature.asc Description: OpenPGP digital signature -- ___ concordance-devel mailing list concordance-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/concordance-devel
Re: [concordance-devel] Harmony 900 disabled
On 06/04/2015 05:11 AM, Jay email wrote: I have brought a Harmony 900 that I have since found out is disabled by Logitech. Is there a way to bypass the connectivity.ezhex check to be able to get the config.exhex file? I do have a working harmony 900 can you use this remote to get the config file or does the config require the same ID to be present to program the remote? No, there's not, unfortunately. It has to be the same remote. -- Phil Dibowitz p...@ipom.com Open Source software and tech docsInsanity Palace of Metallica http://www.phildev.net/ http://www.ipom.com/ Be who you are and say what you feel, because those who mind don't matter and those who matter don't mind. - Dr. Seuss signature.asc Description: OpenPGP digital signature -- ___ concordance-devel mailing list concordance-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/concordance-devel
[concordance-devel] Moved to github!
After all the crap with Sourceforge highjacking windows installer binaries, I decided to move Moving to Github higher up my priority list. The code, the issues and the latest release have been moved; https://github.com/jaymzh/concordance/ I intend to keep the mailing list on SF for now. I'll remove the code from SF soon. -- Phil Dibowitz p...@ipom.com Open Source software and tech docsInsanity Palace of Metallica http://www.phildev.net/ http://www.ipom.com/ Be who you are and say what you feel, because those who mind don't matter and those who matter don't mind. - Dr. Seuss signature.asc Description: OpenPGP digital signature -- ___ concordance-devel mailing list concordance-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/concordance-devel
Re: [concordance-devel] Potential bug with Concordance windows installer on 8.1
On 05/21/2015 07:02 PM, Scott Talbert wrote: Great. Phil, can you please put this updated Windows build on Sourceforge? Done. I'll submit another patch for the installer script. Awesome. -- Phil Dibowitz p...@ipom.com Open Source software and tech docsInsanity Palace of Metallica http://www.phildev.net/ http://www.ipom.com/ Be who you are and say what you feel, because those who mind don't matter and those who matter don't mind. - Dr. Seuss signature.asc Description: OpenPGP digital signature -- One dashboard for servers and applications across Physical-Virtual-Cloud Widest out-of-the-box monitoring support with 50+ applications Performance metrics, stats and reports that give you Actionable Insights Deep dive visibility with transaction tracing using APM Insight. http://ad.doubleclick.net/ddm/clk/290420510;117567292;y___ concordance-devel mailing list concordance-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/concordance-devel
Re: [concordance-devel] [PATCH] Bump libconcord version in Windows installer script and add reminder
On 04/19/2015 01:00 PM, Scott Talbert wrote: Signed-off-by: Scott Talbert s...@techie.net Merged, thanks. -- Phil Dibowitz p...@ipom.com Open Source software and tech docsInsanity Palace of Metallica http://www.phildev.net/ http://www.ipom.com/ Be who you are and say what you feel, because those who mind don't matter and those who matter don't mind. - Dr. Seuss signature.asc Description: OpenPGP digital signature -- BPM Camp - Free Virtual Workshop May 6th at 10am PDT/1PM EDT Develop your own process in accordance with the BPMN 2 standard Learn Process modeling best practices with Bonita BPM through live exercises http://www.bonitasoft.com/be-part-of-it/events/bpm-camp-virtual- event?utm_ source=Sourceforge_BPM_Camp_5_6_15utm_medium=emailutm_campaign=VA_SF___ concordance-devel mailing list concordance-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/concordance-devel
Re: [concordance-devel] Announce: Concordance 1.2
On 04/10/2015 08:04 AM, Ivo Clarysse wrote: On 04/08/2015 05:59 AM, Phil Dibowitz wrote: /tmp/buildroot/lib/libzdll.a: error adding symbols: File in wrong format I went back to version 1.2.7 of zlib and that didn't change anything, 'file' reports both as 'current ar archive'. I also, for giggles tried 11.1 of libzip. Try to extract the contents of libzdll.a using 'ar x libzdll.a' and then perform 'file' on the extracted archive members. It looks like a 32 vs 64 bit mismatch though. When I do that I get: [phil@rider lib]$ file zlib1.dll zlib1.dll: data which isn't very enlightening. -- Phil Dibowitz p...@ipom.com Open Source software and tech docsInsanity Palace of Metallica http://www.phildev.net/ http://www.ipom.com/ Be who you are and say what you feel, because those who mind don't matter and those who matter don't mind. - Dr. Seuss signature.asc Description: OpenPGP digital signature -- BPM Camp - Free Virtual Workshop May 6th at 10am PDT/1PM EDT Develop your own process in accordance with the BPMN 2 standard Learn Process modeling best practices with Bonita BPM through live exercises http://www.bonitasoft.com/be-part-of-it/events/bpm-camp-virtual- event?utm_ source=Sourceforge_BPM_Camp_5_6_15utm_medium=emailutm_campaign=VA_SF___ concordance-devel mailing list concordance-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/concordance-devel
Re: [concordance-devel] Announce: Concordance 1.2
On 04/13/2015 08:44 PM, Scott Talbert wrote: On Tue, 7 Apr 2015, Phil Dibowitz wrote: As always, thanks for the great software! I can't crosscompile libzip because it doesn't like the zlib static library from the DLL download. It compiles file, but the linking step fails: /tmp/buildroot/lib/libzdll.a: error adding symbols: File in wrong format I went back to version 1.2.7 of zlib and that didn't change anything, 'file' reports both as 'current ar archive'. I also, for giggles tried 11.1 of libzip. I give up for the night. Scott if you wanna throw a windows binary my way I'll throw it in SF. If you have ideas on wtf is going on, I'm all ears. Here's a Windows binary: http://www.techie.net/~talbert/concordance-1.2-installer.exe Uploaded to sourceforge. Sorry for the delay, was out of town. -- Phil Dibowitz p...@ipom.com Open Source software and tech docsInsanity Palace of Metallica http://www.phildev.net/ http://www.ipom.com/ Be who you are and say what you feel, because those who mind don't matter and those who matter don't mind. - Dr. Seuss signature.asc Description: OpenPGP digital signature -- BPM Camp - Free Virtual Workshop May 6th at 10am PDT/1PM EDT Develop your own process in accordance with the BPMN 2 standard Learn Process modeling best practices with Bonita BPM through live exercises http://www.bonitasoft.com/be-part-of-it/events/bpm-camp-virtual- event?utm_ source=Sourceforge_BPM_Camp_5_6_15utm_medium=emailutm_campaign=VA_SF___ concordance-devel mailing list concordance-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/concordance-devel
Re: [concordance-devel] Announce: Concordance 1.2
On 04/07/2015 03:22 AM, Parker Reed wrote: As always, thanks for the great software! I can't crosscompile libzip because it doesn't like the zlib static library from the DLL download. It compiles file, but the linking step fails: /tmp/buildroot/lib/libzdll.a: error adding symbols: File in wrong format I went back to version 1.2.7 of zlib and that didn't change anything, 'file' reports both as 'current ar archive'. I also, for giggles tried 11.1 of libzip. I give up for the night. Scott if you wanna throw a windows binary my way I'll throw it in SF. If you have ideas on wtf is going on, I'm all ears. -- Phil Dibowitz p...@ipom.com Open Source software and tech docsInsanity Palace of Metallica http://www.phildev.net/ http://www.ipom.com/ Be who you are and say what you feel, because those who mind don't matter and those who matter don't mind. - Dr. Seuss signature.asc Description: OpenPGP digital signature -- BPM Camp - Free Virtual Workshop May 6th at 10am PDT/1PM EDT Develop your own process in accordance with the BPMN 2 standard Learn Process modeling best practices with Bonita BPM through live exercises http://www.bonitasoft.com/be-part-of-it/events/bpm-camp-virtual- event?utm_ source=Sourceforge_BPM_Camp_5_6_15utm_medium=emailutm_campaign=VA_SF___ concordance-devel mailing list concordance-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/concordance-devel
[concordance-devel] Announce: Concordance 1.2
Concordance 1.2 has been released. This version includes support for the Ultimate One, 350, Touch, and Home Hub, and fixes a crash some users experienced in Concordance's website communications. All users are encouraged to upgrade. Source is available on the website. Windows binaries will come tomorrow... currently I'm struggling with mingw not liking the file format of the zlib DLL from the zlib website... -- Phil Dibowitz p...@ipom.com Open Source software and tech docsInsanity Palace of Metallica http://www.phildev.net/ http://www.ipom.com/ Be who you are and say what you feel, because those who mind don't matter and those who matter don't mind. - Dr. Seuss signature.asc Description: OpenPGP digital signature -- BPM Camp - Free Virtual Workshop May 6th at 10am PDT/1PM EDT Develop your own process in accordance with the BPMN 2 standard Learn Process modeling best practices with Bonita BPM through live exercises http://www.bonitasoft.com/be-part-of-it/events/bpm-camp-virtual- event?utm_ source=Sourceforge_BPM_Camp_5_6_15utm_medium=emailutm_campaign=VA_SF___ concordance-devel mailing list concordance-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/concordance-devel
Re: [concordance-devel] [PATCH] Add Ultimate One, 350, and Home Hub to remote_info struct
On 04/06/2015 06:39 PM, Scott Talbert wrote: On Mon, 6 Apr 2015, Phil Dibowitz wrote: Merged, thanks. So, the other patch I was considering is for some cleanup to reduce some duplication in the MH code. It has no user-facing impact, so it really doesn't need to be done now. Thus, I'd be fine with a release at this point. SGTM. I should be able to get one out the door tomorrow. Yesterday didn't go as planned. It's on my list for this week, hopefully tonight. I also need to release PIUS this week, there's a crashing bug in it as well. So both will go out this week for sure. Looking at the patches that Debian is carrying currently, we probably should pick these up, too: https://sources.debian.net/src/concordance/1.1-3/debian/patches/conditionally_run_iptables.patch/ https://sources.debian.net/src/concordance/1.1-3/debian/patches/handle_kfreebsd_hurd.patch/ There is this one, too, but I don't quite understand why this didn't work on Debian: https://sources.debian.net/src/concordance/1.1-3/debian/patches/libzip_configure.patch/ I'll write a diff. I hate it when maintainers do this and don't send those patches upstream. Pet. Fucking. Peeve. If you click on 'download' you can get the actual patch files. Every piece of documentation I can find for autoconf says the first argument should be in square brackets. And I remember having problems without it... so I'm only merging the first two. :/ -- Phil Dibowitz p...@ipom.com Open Source software and tech docsInsanity Palace of Metallica http://www.phildev.net/ http://www.ipom.com/ Be who you are and say what you feel, because those who mind don't matter and those who matter don't mind. - Dr. Seuss signature.asc Description: OpenPGP digital signature -- BPM Camp - Free Virtual Workshop May 6th at 10am PDT/1PM EDT Develop your own process in accordance with the BPMN 2 standard Learn Process modeling best practices with Bonita BPM through live exercises http://www.bonitasoft.com/be-part-of-it/events/bpm-camp-virtual- event?utm_ source=Sourceforge_BPM_Camp_5_6_15utm_medium=emailutm_campaign=VA_SF___ concordance-devel mailing list concordance-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/concordance-devel
Re: [concordance-devel] [PATCH] Add Ultimate One, 350, and Home Hub to remote_info struct
On 04/06/2015 06:01 PM, Scott Talbert wrote: On Mon, 6 Apr 2015, Phil Dibowitz wrote: Merged, thanks. So, the other patch I was considering is for some cleanup to reduce some duplication in the MH code. It has no user-facing impact, so it really doesn't need to be done now. Thus, I'd be fine with a release at this point. SGTM. I should be able to get one out the door tomorrow. Yesterday didn't go as planned. It's on my list for this week, hopefully tonight. I also need to release PIUS this week, there's a crashing bug in it as well. So both will go out this week for sure. Looking at the patches that Debian is carrying currently, we probably should pick these up, too: https://sources.debian.net/src/concordance/1.1-3/debian/patches/conditionally_run_iptables.patch/ https://sources.debian.net/src/concordance/1.1-3/debian/patches/handle_kfreebsd_hurd.patch/ There is this one, too, but I don't quite understand why this didn't work on Debian: https://sources.debian.net/src/concordance/1.1-3/debian/patches/libzip_configure.patch/ I'll write a diff. I hate it when maintainers do this and don't send those patches upstream. Pet. Fucking. Peeve. -- Phil Dibowitz p...@ipom.com Open Source software and tech docsInsanity Palace of Metallica http://www.phildev.net/ http://www.ipom.com/ Be who you are and say what you feel, because those who mind don't matter and those who matter don't mind. - Dr. Seuss signature.asc Description: OpenPGP digital signature -- BPM Camp - Free Virtual Workshop May 6th at 10am PDT/1PM EDT Develop your own process in accordance with the BPMN 2 standard Learn Process modeling best practices with Bonita BPM through live exercises http://www.bonitasoft.com/be-part-of-it/events/bpm-camp-virtual- event?utm_ source=Sourceforge_BPM_Camp_5_6_15utm_medium=emailutm_campaign=VA_SF___ concordance-devel mailing list concordance-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/concordance-devel
Re: [concordance-devel] windows installer
On Wed, Feb 04, 2015 at 05:52:02PM -0600, David Rainer wrote: I have installed 1.1 on Windows 7/64 and Windows Vista 32 machines. Each time I try to open the program, it gives an error message about initializing but the cmd screen disappears before I can read the whole message. It's a console utility, you must run it from a cmd window. If you would like a GUI you may also install Congruity. -- Phil Dibowitz p...@ipom.com Open Source software and tech docsInsanity Palace of Metallica http://www.phildev.net/ http://www.ipom.com/ Be who you are and say what you feel, because those who mind don't matter and those who matter don't mind. - Dr. Seuss signature.asc Description: Digital signature -- Dive into the World of Parallel Programming. The Go Parallel Website, sponsored by Intel and developed in partnership with Slashdot Media, is your hub for all things parallel software development, from weekly thought leadership blogs to news, videos, case studies, tutorials and more. Take a look and join the conversation now. http://goparallel.sourceforge.net/___ concordance-devel mailing list concordance-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/concordance-devel
Re: [concordance-devel] [concordance:bugs] #40 abort in post_connect_test_success()
-bug in question +devel list On 11/16/2014 07:43 PM, Scott Talbert wrote: Surprisingly, C++ still doesn't have any built-in string formatting mechanisms. There are a few libraries out there, but it seems like overkill to add something like that. I was thinking about something like this (not yet tested) to replace our sprintf's: Shouldn't simply moving to snprintf() solve the problem? I've been replacing sprintf() with snprintf() as I hit them, but clearly there's more. [disclaimer, I haven't dug through the stacktrace, I'm purely replying to your comment about sprintf] -- Phil Dibowitz p...@ipom.com Open Source software and tech docsInsanity Palace of Metallica http://www.phildev.net/ http://www.ipom.com/ Be who you are and say what you feel, because those who mind don't matter and those who matter don't mind. - Dr. Seuss signature.asc Description: OpenPGP digital signature -- Download BIRT iHub F-Type - The Free Enterprise-Grade BIRT Server from Actuate! Instantly Supercharge Your Business Reports and Dashboards with Interactivity, Sharing, Native Excel Exports, App Integration more Get technology previously reserved for billion-dollar corporations, FREE http://pubads.g.doubleclick.net/gampad/clk?id=157005751iu=/4140/ostg.clktrk___ concordance-devel mailing list concordance-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/concordance-devel
Re: [concordance-devel] [concordance:bugs] #40 abort in post_connect_test_success()
On 11/17/2014 10:17 AM, Scott Talbert wrote: On Mon, 17 Nov 2014, Phil Dibowitz wrote: Surprisingly, C++ still doesn't have any built-in string formatting mechanisms. There are a few libraries out there, but it seems like overkill to add something like that. I was thinking about something like this (not yet tested) to replace our sprintf's: Shouldn't simply moving to snprintf() solve the problem? I've been replacing sprintf() with snprintf() as I hit them, but clearly there's more. [disclaimer, I haven't dug through the stacktrace, I'm purely replying to your comment about sprintf] Yes, technically it would - but we'd still have to pick some arbitrary size for a buffer that we hope is large enough. Then we'd have to check the return value of snprintf and if we ran out of space, we'd probably have to exit abnormally anyway. That's really what I was trying to work around with my proposed format_string function - figure out the buffer size automatically and handle it. That's fair. I'm cool with that. Not terribly efficient, but that's not exactly our goal either. :) I wonder how often do we not know the size of the string. Only in the HTTP handling, right? -- Phil Dibowitz p...@ipom.com Open Source software and tech docsInsanity Palace of Metallica http://www.phildev.net/ http://www.ipom.com/ Be who you are and say what you feel, because those who mind don't matter and those who matter don't mind. - Dr. Seuss signature.asc Description: OpenPGP digital signature -- Download BIRT iHub F-Type - The Free Enterprise-Grade BIRT Server from Actuate! Instantly Supercharge Your Business Reports and Dashboards with Interactivity, Sharing, Native Excel Exports, App Integration more Get technology previously reserved for billion-dollar corporations, FREE http://pubads.g.doubleclick.net/gampad/clk?id=157005751iu=/4140/ostg.clktrk___ concordance-devel mailing list concordance-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/concordance-devel
Re: [concordance-devel] [PATCH 1/2] BUG/MINOR: Use concordance mailing list as the bugreport contact
Applied, thanks. -- Phil Dibowitz p...@ipom.com Open Source software and tech docsInsanity Palace of Metallica http://www.phildev.net/ http://www.ipom.com/ Be who you are and say what you feel, because those who mind don't matter and those who matter don't mind. - Dr. Seuss signature.asc Description: OpenPGP digital signature -- Slashdot TV. Video for Nerds. Stuff that matters. http://tv.slashdot.org/___ concordance-devel mailing list concordance-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/concordance-devel
Re: [concordance-devel] [PATCH] Remove -ansi and -pedantic-errors from concordance compile flags
Applied, thanks. -- Phil Dibowitz p...@ipom.com Open Source software and tech docsInsanity Palace of Metallica http://www.phildev.net/ http://www.ipom.com/ Be who you are and say what you feel, because those who mind don't matter and those who matter don't mind. - Dr. Seuss signature.asc Description: OpenPGP digital signature -- Slashdot TV. Video for Nerds. Stuff that matters. http://tv.slashdot.org/___ concordance-devel mailing list concordance-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/concordance-devel
Re: [concordance-devel] [PATCH 2/2] MINOR: Ignore binding generated files
Applied, thanks. -- Phil Dibowitz p...@ipom.com Open Source software and tech docsInsanity Palace of Metallica http://www.phildev.net/ http://www.ipom.com/ Be who you are and say what you feel, because those who mind don't matter and those who matter don't mind. - Dr. Seuss signature.asc Description: OpenPGP digital signature -- Slashdot TV. Video for Nerds. Stuff that matters. http://tv.slashdot.org/___ concordance-devel mailing list concordance-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/concordance-devel
Re: [concordance-devel] [PATCH] Windows install/documentation fixes
Applied, thanks. -- Phil Dibowitz p...@ipom.com Open Source software and tech docsInsanity Palace of Metallica http://www.phildev.net/ http://www.ipom.com/ Be who you are and say what you feel, because those who mind don't matter and those who matter don't mind. - Dr. Seuss signature.asc Description: OpenPGP digital signature -- Slashdot TV. Video for Nerds. Stuff that matters. http://tv.slashdot.org/___ concordance-devel mailing list concordance-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/concordance-devel
Re: [concordance-devel] Tickets to close
On 04/03/2014 06:28 AM, Scott Talbert wrote: Phil, I think the following tickets can be closed: Bugs: 37, 38 Feature Requests: 7, 12, 24 Done. Thanks! -- Phil Dibowitz p...@ipom.com Open Source software and tech docsInsanity Palace of Metallica http://www.phildev.net/ http://www.ipom.com/ Be who you are and say what you feel, because those who mind don't matter and those who matter don't mind. - Dr. Seuss signature.asc Description: OpenPGP digital signature -- Slashdot TV. Video for Nerds. Stuff that matters. http://tv.slashdot.org/___ concordance-devel mailing list concordance-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/concordance-devel
[concordance-devel] Windows binaries
So I got a question from a windows user that they kept trying to run Concordance and it popped up a console window too fast to see the error. I explained it was a console app and he could run it from cmd or use Congruity. He thanked me and pointed out that he couldn't find documentation... and then I realized... the README only ships with the source. My bad. Next release I need to bundle a README with the Windows binary. :) -- Phil Dibowitz p...@ipom.com Open Source software and tech docsInsanity Palace of Metallica http://www.phildev.net/ http://www.ipom.com/ Be who you are and say what you feel, because those who mind don't matter and those who matter don't mind. - Dr. Seuss signature.asc Description: OpenPGP digital signature -- Want fast and easy access to all the code in your enterprise? Index and search up to 200,000 lines of code with a free copy of Black Duck Code Sight - the same software that powers the world's largest code search on Ohloh, the Black Duck Open Hub! Try it now. http://p.sf.net/sfu/bds___ concordance-devel mailing list concordance-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/concordance-devel
Re: [concordance-devel] Harmony Smart Control
On Thu, Jul 17, 2014 at 08:20:56PM -0400, Scott Talbert wrote: On Thu, 17 Jul 2014, Adam Williamson wrote: BTW, here's a mystery: in theory, shouldn't it be possible to trigger a wifi config sync from a computer on the same network as the hub? This doesn't seem to be possible with the MyHarmony software, but I can't for the life of me think why not. Why can the smartphone app tell the hub (Link or...Hub) to do a wifi-based sync, but an app running on a computer not do it? It seems weird. Have you thought of trying to figure out how the wifi sync process is initiated, and have a button in mhgui to trigger a wifi sync? Yeah, that should certainly be possible, although I never thought about that before. We would need to capture the network traffic from the app somehow, possibly on a rooted phone or something like that. Sadly Android doesn't let you run tcpdump out of the box. :-) This I might be able to do - my Android phone is rooted. So try getting tcpdump running on the phone and capture the traffic when I run a sync job? I'll try that. Yup, that should be enough. Hopefully they aren't encrypting the network traffic. BTW, thanks for breathing some life into this mailing list. :-) Hopefully Phil will wake up and merge my latest patches to concordance. I'm back from 7 weeks in Europe... but have houseguests through the end of the month. I didn't realize stuff was waiting on me, sorry, Ill go back and check soon. -- Phil Dibowitz p...@ipom.com Open Source software and tech docsInsanity Palace of Metallica http://www.phildev.net/ http://www.ipom.com/ Be who you are and say what you feel, because those who mind don't matter and those who matter don't mind. - Dr. Seuss signature.asc Description: Digital signature -- Want fast and easy access to all the code in your enterprise? Index and search up to 200,000 lines of code with a free copy of Black Duck Code Sight - the same software that powers the world's largest code search on Ohloh, the Black Duck Open Hub! Try it now. http://p.sf.net/sfu/bds___ concordance-devel mailing list concordance-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/concordance-devel
Re: [concordance-devel] Changelog
On 03/29/2014 08:31 AM, Scott Talbert wrote: On Sat, 29 Mar 2014, Phil Dibowitz wrote: Release is out. Windows binaries are up. I tweaked a few things about the windows binary instructions after the release (I was copy-pasting this time and found a few minor bugs/typos). Version numbers have been set to '1.1+git' on master. Cool, I see you updated the website to indicate support for the Link as well. Yes, I also added the note about arch 15 not being supported on Mac. When I get some time I'm going to figure out what the official software does for dhcp/etc. and if we can do something with dnsmasq like we did on linux or if there's a better option. You should also add the 900 and 1100 to the Arch 15 list. Good call, done. -- Phil Dibowitz p...@ipom.com Open Source software and tech docsInsanity Palace of Metallica http://www.phildev.net/ http://www.ipom.com/ Be who you are and say what you feel, because those who mind don't matter and those who matter don't mind. - Dr. Seuss signature.asc Description: OpenPGP digital signature -- ___ concordance-devel mailing list concordance-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/concordance-devel
Re: [concordance-devel] Changelog
On 03/29/2014 05:18 PM, Scott Talbert wrote: On Sat, 29 Mar 2014, Phil Dibowitz wrote: Release is out. Windows binaries are up. I tweaked a few things about the windows binary instructions after the release (I was copy-pasting this time and found a few minor bugs/typos). Version numbers have been set to '1.1+git' on master. Cool, I see you updated the website to indicate support for the Link as well. Yes, I also added the note about arch 15 not being supported on Mac. When I get some time I'm going to figure out what the official software does for dhcp/etc. and if we can do something with dnsmasq like we did on linux or if there's a better option. DHCP is one thing (dnsmasq would probably work or not take very much effort to get working), but the harder part would be getting a USBNet driver. I imagine there already is once, since the official software works... -- Phil Dibowitz p...@ipom.com Open Source software and tech docsInsanity Palace of Metallica http://www.phildev.net/ http://www.ipom.com/ Be who you are and say what you feel, because those who mind don't matter and those who matter don't mind. - Dr. Seuss signature.asc Description: OpenPGP digital signature -- ___ concordance-devel mailing list concordance-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/concordance-devel
Re: [concordance-devel] Changelog
On 03/26/2014 06:17 AM, Scott Talbert wrote:
I didn't see anything related to the installer in this most recent patch.
Did you send an older one instead?
Whoops!
New patch attached...
The other patch is committed, with your tweak of course. This is on top of
that, and not yet committed.
--
Phil Dibowitz p...@ipom.com
Open Source software and tech docsInsanity Palace of Metallica
http://www.phildev.net/ http://www.ipom.com/
Be who you are and say what you feel, because those who mind don't matter
and those who matter don't mind.
- Dr. Seuss
commit 9496699d26fdd208f70b347e83eeab1840a81b58
Author: Phil Dibowitz p...@ipom.com
Date: Wed Mar 26 06:46:57 2014 -0700
Further Windows Instruction Improvements
diff --git a/concordance/INSTALL.windows b/concordance/INSTALL.windows
index 669974e..bc5ace8 100644
--- a/concordance/INSTALL.windows
+++ b/concordance/INSTALL.windows
@@ -18,11 +18,23 @@ install it to the MinGW sysroot):
To build a Win32 installer, you will need to have NSIS installed.
Additionally, you will need to set some environment variables.
+
+Assuming you were following the Fedora instructions in
+../libconcord/INSTALL.windows:
export MINGW_SYSROOT_BIN=/usr/i686-w64-mingw32/sys-root/mingw/bin
(the path where the MinGW DLL files can be found)
+ export ZLIB_LIB_PATH=$MINGW_SYSROOT_BIN
+ export LIBZIP_LIB_PATH=$MINGW_SYSROOT_BIN
export HIDAPI_LIB_PATH=/path/to/hidapi/lib
-To build the installer:
- mingw32-make win32-installer
+Or if you used the non-Fedora instructions:
+ export MINGW_SYSROOT_BIN=/usr/i686-w64-mingw32/lib
+ (the path where the MinGW DLL files can be found)
+ export ZLIB_LIB_PATH=/tmp/root/lib
+ export LIBZIP_LIB_PATH=/tmp/root/bin
+ export HIDAPI_LIB_PATH=/tmp/root/bin
+
+Then, build the installer:
+ make win32-installer
vim:textwidth=78:
diff --git a/concordance/win/concordance.nsi b/concordance/win/concordance.nsi
index 1805e31..a42cd50 100644
--- a/concordance/win/concordance.nsi
+++ b/concordance/win/concordance.nsi
@@ -38,10 +38,10 @@ Section Concordance
SectionIn RO
SetOutPath $INSTDIR
- File $%MINGW_SYSROOT_BIN%/libgcc_s_sjlj-1.dll
- File $%MINGW_SYSROOT_BIN%/libstdc++-6.dll
- File $%MINGW_SYSROOT_BIN%/libzip-2.dll
- File $%MINGW_SYSROOT_BIN%/zlib1.dll
+ #File $%MINGW_SYSROOT_BIN%/libgcc_s_sjlj-1.dll
+ #File $%MINGW_SYSROOT_BIN%/libstdc++-6.dll
+ File $%LIBZIP_LIB_PATH%/libzip-2.dll
+ File $%ZLIB_LIB_PATH%/zlib1.dll
File $%HIDAPI_LIB_PATH%/libhidapi-0.dll
File ../../libconcord/.libs/libconcord-3.dll
File ../.libs/concordance.exe
diff --git a/libconcord/INSTALL.windows b/libconcord/INSTALL.windows
index 7cd22d6..5fb4fda 100644
--- a/libconcord/INSTALL.windows
+++ b/libconcord/INSTALL.windows
@@ -17,6 +17,7 @@ For other distributions, including building on Windows directly, grab the
pre-built DLL from zlib.net. In the unzip'd directory do:
mkdir -p /tmp/buildroot/{include,lib}
cp lib/zdll.lib lib/libzdll.a # See USAGE.txt in zlib for details
+ cp zlib1.dll lib
cp -r lib/* /tmp/buildroot/lib/
cp -r include/* /tmp/buildroot/include/
signature.asc
Description: OpenPGP digital signature
--
Learn Graph Databases - Download FREE O'Reilly Book
Graph Databases is the definitive new guide to graph databases and their
applications. Written by three acclaimed leaders in the field,
this first edition is now available. Download your free book today!
http://p.sf.net/sfu/13534_NeoTech___
concordance-devel mailing list
concordance-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/concordance-devel
Re: [concordance-devel] Changelog
On Wed, Mar 26, 2014 at 08:19:17PM -0400, Scott Talbert wrote: On Wed, 26 Mar 2014, Scott Talbert wrote: I didn't see anything related to the installer in this most recent patch. Did you send an older one instead? Whoops! New patch attached... The other patch is committed, with your tweak of course. This is on top of that, and not yet committed. Confirmed, we definitely need those DLL's that are commented out. Oh figured it out... debian puts things in weird places. Attached is a new diff and a new installer. Still no dice. It is now wanting libwinpthread-1.dll, which is odd because it didn't need that on Fedora. It looks like that's coming from libgcc_s_sjlj-1.dll and libstdc++-6.dll. Must have to do with the way Debian compiled them. That's in there, I can grab that. -- Phil Dibowitz p...@ipom.com Open Source software and tech docsInsanity Palace of Metallica http://www.phildev.net/ http://www.ipom.com/ Be who you are and say what you feel, because those who mind don't matter and those who matter don't mind. - Dr. Seuss signature.asc Description: Digital signature -- ___ concordance-devel mailing list concordance-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/concordance-devel
[concordance-devel] Changelog
Scott, Here's what I got for a Changelog after going through the git logs... seem good? 1.1 Released: p...@ipom.com: - libconcord: fix firmware dump file generation so we can read files we create. - libconcord: bindings: perl bindings work again - libconcord: mac: revamp instructions, include homebrew option - libconcord: mac: tons of compile and runtime fixes - libconcord: move to HIDAPI for Linux and Mac - libconcord: detect a new type of firmware file - move to four-space indentation, massive style cleanup s...@techie.net: - libconcord: windows: check sequence numbers - libconcord: windows: code cleanup - fixed all compiler warnings - libconcord: fix serial number handling for Harmony 650 - libconcord: fix startup of USBNet DHCP server by udev - libconcord: fix USBNET remote detection on Windows. - windows: move to mingw for building, drop all visual c++ support files - libconcord: move to HIDAPI for Windows, drop all WinHID code - libconcord: Harmony Link support - libconcord: MH remote support - libconcord: split codepath for IR learning for zwave-hid vs zwave-usbnet - libconcord: fix serial number handling for ZWave-HID remotes - libconcord: incorporate MIME type patch from Fedora. Fixes bug #7 - libconcord: incorporate long-standing Debian patches to man page - libconcord: various windows fixes -- Phil Dibowitz p...@ipom.com Open Source software and tech docsInsanity Palace of Metallica http://www.phildev.net/ http://www.ipom.com/ Be who you are and say what you feel, because those who mind don't matter and those who matter don't mind. - Dr. Seuss signature.asc Description: OpenPGP digital signature -- Learn Graph Databases - Download FREE O'Reilly Book Graph Databases is the definitive new guide to graph databases and their applications. Written by three acclaimed leaders in the field, this first edition is now available. Download your free book today! http://p.sf.net/sfu/13534_NeoTech___ concordance-devel mailing list concordance-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/concordance-devel
Re: [concordance-devel] Changelog
On 03/23/2014 02:35 PM, Scott Talbert wrote: On March 23, 2014 5:16:38 PM EDT, Phil Dibowitz p...@ipom.com wrote: On 03/23/2014 02:07 PM, Scott Talbert wrote: Yep, that sounds about right. I think the biggies, from a user perspective, are, fixing the Mac/Windows builds and the Harmony Link support. And MH support in general, right? I was going to ask you what all remotes we can list in the release notes that we've added. Actually we had MH support in 1.0. What was added later was MH config dumping. I believe the Harmony Link is the only new device supported in this release. OK, I checked in that Changelog, and the version number bump to start preping for release. I was looking into MinGW... and uh, I think I'm missing something. I installed mingw32, mingw64, mingw64-tools and ... well every other mingw package I could find but there's nothing resembling a mingw32-configure binary anywhere in my path... I have i686-w64-mingw32-c++ and x86_64-w64-mingw32-c++ and gcc equivalents and linkers and fortran and dlltool, and cpp but no configure... and the docs I read on compiling windows binaries didn't mention it either. Am I missing something? -- Phil Dibowitz p...@ipom.com Open Source software and tech docsInsanity Palace of Metallica http://www.phildev.net/ http://www.ipom.com/ Be who you are and say what you feel, because those who mind don't matter and those who matter don't mind. - Dr. Seuss signature.asc Description: OpenPGP digital signature -- Learn Graph Databases - Download FREE O'Reilly Book Graph Databases is the definitive new guide to graph databases and their applications. Written by three acclaimed leaders in the field, this first edition is now available. Download your free book today! http://p.sf.net/sfu/13534_NeoTech___ concordance-devel mailing list concordance-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/concordance-devel
Re: [concordance-devel] Changelog
On 03/23/2014 07:36 PM, Scott Talbert wrote: On Sun, 23 Mar 2014, Scott Talbert wrote: OK, I checked in that Changelog, and the version number bump to start preping for release. I was looking into MinGW... and uh, I think I'm missing something. I installed mingw32, mingw64, mingw64-tools and ... well every other mingw package I could find but there's nothing resembling a mingw32-configure binary anywhere in my path... I have i686-w64-mingw32-c++ and x86_64-w64-mingw32-c++ and gcc equivalents and linkers and fortran and dlltool, and cpp but no configure... and the docs I read on compiling windows binaries didn't mention it either. Am I missing something? So, on Fedora, mingw32-configure is provided by a package called mingw-filesystem. Looking at it, it appears to be just a script that probably invokes the real configure with some parameters. It looks like it might be a Fedora concoction, though, so it probably isn't available on Debian? I think you can probably just do this instead: ./configure --host=i686-pc-mingw32 That works. What does mingw32-make do in Fedora? :) -- Phil Dibowitz p...@ipom.com Open Source software and tech docsInsanity Palace of Metallica http://www.phildev.net/ http://www.ipom.com/ Be who you are and say what you feel, because those who mind don't matter and those who matter don't mind. - Dr. Seuss signature.asc Description: OpenPGP digital signature -- Learn Graph Databases - Download FREE O'Reilly Book Graph Databases is the definitive new guide to graph databases and their applications. Written by three acclaimed leaders in the field, this first edition is now available. Download your free book today! http://p.sf.net/sfu/13534_NeoTech___ concordance-devel mailing list concordance-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/concordance-devel
Re: [concordance-devel] Changelog
On 03/23/2014 09:21 PM, Phil Dibowitz wrote: I think you can probably just do this instead: ./configure --host=i686-pc-mingw32 That works. What does mingw32-make do in Fedora? :) Actually, that's a dumb question, it's probably just: make CC=i586-mingw32msvc-gcc LD=i586-mingw32msvc-ld or similar... but when I do that, it can't find setupapi, whatever that is: /usr/bin/ld: cannot find -lsetupapi Though it shouldn't be calling /usr/bin/ld with LD set... :/ Also, I have three lot options of compiler: i586-mingw32msvc-gcc i686-w64-mingw32-gcc x86_64-w64-mingw32-gcc And for linker I have four: amd64-mingw32msvc-ld i686-w64-mingw32-ld i586-mingw32msvc-ld x86_64-w64-mingw32-ld Wtf. -- Phil Dibowitz p...@ipom.com Open Source software and tech docsInsanity Palace of Metallica http://www.phildev.net/ http://www.ipom.com/ Be who you are and say what you feel, because those who mind don't matter and those who matter don't mind. - Dr. Seuss signature.asc Description: OpenPGP digital signature -- Learn Graph Databases - Download FREE O'Reilly Book Graph Databases is the definitive new guide to graph databases and their applications. Written by three acclaimed leaders in the field, this first edition is now available. Download your free book today! http://p.sf.net/sfu/13534_NeoTech___ concordance-devel mailing list concordance-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/concordance-devel
Re: [concordance-devel] Changelog
On 03/23/2014 09:28 PM, Scott Talbert wrote: ./configure --host=i686-pc-mingw32 That works. What does mingw32-make do in Fedora? :) Probably just try 'make'? 'make' can't find windows.h. Make with the right vars defined got me further. And in case it wasn't clear, I do understand the linker error in my last email... but I also cannot find setupapi library in the debian repo... I'm assuming it's a Windows thing? -- Phil Dibowitz p...@ipom.com Open Source software and tech docsInsanity Palace of Metallica http://www.phildev.net/ http://www.ipom.com/ Be who you are and say what you feel, because those who mind don't matter and those who matter don't mind. - Dr. Seuss signature.asc Description: OpenPGP digital signature -- Learn Graph Databases - Download FREE O'Reilly Book Graph Databases is the definitive new guide to graph databases and their applications. Written by three acclaimed leaders in the field, this first edition is now available. Download your free book today! http://p.sf.net/sfu/13534_NeoTech___ concordance-devel mailing list concordance-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/concordance-devel
Re: [concordance-devel] Changelog
Nevermind, I figured it out. Changing the configure to ./configure --host=i686-w64-mingw32 worked. -- Phil Dibowitz p...@ipom.com Open Source software and tech docsInsanity Palace of Metallica http://www.phildev.net/ http://www.ipom.com/ Be who you are and say what you feel, because those who mind don't matter and those who matter don't mind. - Dr. Seuss signature.asc Description: OpenPGP digital signature -- Learn Graph Databases - Download FREE O'Reilly Book Graph Databases is the definitive new guide to graph databases and their applications. Written by three acclaimed leaders in the field, this first edition is now available. Download your free book today! http://p.sf.net/sfu/13534_NeoTech___ concordance-devel mailing list concordance-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/concordance-devel
Re: [concordance-devel] Changelog
On 03/23/2014 09:35 PM, Scott Talbert wrote: On Sun, 23 Mar 2014, Phil Dibowitz wrote: ./configure --host=i686-pc-mingw32 That works. What does mingw32-make do in Fedora? :) Probably just try 'make'? 'make' can't find windows.h. Make with the right vars defined got me further. And in case it wasn't clear, I do understand the linker error in my last email... but I also cannot find setupapi library in the debian repo... I'm assuming it's a Windows thing? OK, see attached for exactly what mingw32-configure and mingw32-make are doing. It's a little more complicated than I originally thought. :) It's not so bad, if you get the right host string, it finds everything. However, it seems like Fedora's mingw has a bit more setup for it. In particular, when I build libconcord it can't find libzip, and while fedora has a mingw32-libzip package, Debian does not... and so I went to build it, but it can't find zlib. I went to build that in mingw, but it doesn't used autotools, and so there's no --host option to ./configure. I tried just defining CC and LD and CPP, but that didn't work. Then I noticed he makes a pre-built DLL available, score, that solves that problem. A few minor -I and -L flags later, we were cooking... until libzip failed to compile with: .libs/zip_error_strerror.o: In function `zip_error_strerror': /home/phil/build/git/libzip-0.11.2/lib/zip_error_strerror.c:67: undefined reference to `zError' .libs/zip_error_to_str.o: In function `zip_error_to_str': /home/phil/build/git/libzip-0.11.2/lib/zip_error_to_str.c:61: undefined reference to `zError' .. there were more undefined symbols, but I just gave you the first one. I've already been updating the INSTALL.windows file as I go, and when I get it working, I'll send off a diff... in the meantime I'm exhausted, so I'll pick up dependency chasing tomorrow. -- Phil Dibowitz p...@ipom.com Open Source software and tech docsInsanity Palace of Metallica http://www.phildev.net/ http://www.ipom.com/ Be who you are and say what you feel, because those who mind don't matter and those who matter don't mind. - Dr. Seuss signature.asc Description: OpenPGP digital signature -- Learn Graph Databases - Download FREE O'Reilly Book Graph Databases is the definitive new guide to graph databases and their applications. Written by three acclaimed leaders in the field, this first edition is now available. Download your free book today! http://p.sf.net/sfu/13534_NeoTech___ concordance-devel mailing list concordance-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/concordance-devel
Re: [concordance-devel] [PATCH] Fix firmware dumps and restores
On 03/20/2014 08:28 PM, Scott Talbert wrote: So, on the Windows issues. All my remotes pass (200, 300, 688) except for the 890 (zwave-hid). With the 890, I'm having issues with both config dumping and with config writing. With config dumping, I think I'm running into more packet loss issues. I'm looking at a fix to throttle back how often we write out status in the callback function - I think Windows seems to take a bit of time to write out to the console, so it is causing us to lose packets. On the config writing, I'm not quite sure what the issue is - could be packet loss also but not sure yet. You said you're on some ancient pentium, right? If you have a beefy primary machine you may get better performance with a VM -- Phil Dibowitz p...@ipom.com Open Source software and tech docsInsanity Palace of Metallica http://www.phildev.net/ http://www.ipom.com/ Be who you are and say what you feel, because those who mind don't matter and those who matter don't mind. - Dr. Seuss signature.asc Description: OpenPGP digital signature -- Learn Graph Databases - Download FREE O'Reilly Book Graph Databases is the definitive new guide to graph databases and their applications. Written by three acclaimed leaders in the field, this first edition is now available. Download your free book today! http://p.sf.net/sfu/13534_NeoTech___ concordance-devel mailing list concordance-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/concordance-devel
Re: [concordance-devel] [PATCH] Fix firmware dumps and restores
On 03/21/2014 06:11 AM, Scott Talbert wrote: On Fri, 21 Mar 2014, Phil Dibowitz wrote: So, on the Windows issues. All my remotes pass (200, 300, 688) except for the 890 (zwave-hid). With the 890, I'm having issues with both config dumping and with config writing. With config dumping, I think I'm running into more packet loss issues. I'm looking at a fix to throttle back how often we write out status in the callback function - I think Windows seems to take a bit of time to write out to the console, so it is causing us to lose packets. On the config writing, I'm not quite sure what the issue is - could be packet loss also but not sure yet. You said you're on some ancient pentium, right? If you have a beefy primary machine you may get better performance with a VM Actually, this is a newer (but definitely not brand new) Windows 7 machine. That other machine (that I had much worse problems with) was running XP which will be officially unsupported in a few weeks so I'm not bothering to test with that one anymore. Yeah, I think we can stop worrying about XP. Cool, I was just worried about you running into the problem I ran into with some ancient buggy stack/hardware. If it's relatively recent - say 5 years - then I think we're probably fine. My mac is 11 years old. It's still powerpc. I guess I can try in a VM, too. I seem to recall having problems with certain remotes when running under a VM, though. It might have even been the same zwave-hid in that case before. I'd have to say that that's the most finicky protocol. :-) Yeah. But like.. we're not even seeing issues at the zwave-hid level, it's always at the USB level - packet loss. I don't understand why we only see it on zwave-hid remotes. It'd certainly be nice to fix it, but I'm willing to cut a release if you can't find anything, and see if reports from users help us narrow down a pattern... our Windows support is already 100 times better than last release. -- Phil Dibowitz p...@ipom.com Open Source software and tech docsInsanity Palace of Metallica http://www.phildev.net/ http://www.ipom.com/ Be who you are and say what you feel, because those who mind don't matter and those who matter don't mind. - Dr. Seuss signature.asc Description: OpenPGP digital signature -- Learn Graph Databases - Download FREE O'Reilly Book Graph Databases is the definitive new guide to graph databases and their applications. Written by three acclaimed leaders in the field, this first edition is now available. Download your free book today! http://p.sf.net/sfu/13534_NeoTech___ concordance-devel mailing list concordance-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/concordance-devel
Re: [concordance-devel] [PATCH] Fix firmware dumps and restores
On 03/21/2014 10:26 AM, Scott Talbert wrote: On Fri, 21 Mar 2014, Phil Dibowitz wrote: I guess I can try in a VM, too. I seem to recall having problems with certain remotes when running under a VM, though. It might have even been the same zwave-hid in that case before. I'd have to say that that's the most finicky protocol. :-) Yeah. But like.. we're not even seeing issues at the zwave-hid level, it's always at the USB level - packet loss. I don't understand why we only see it on zwave-hid remotes. Well, I did have problems initially on Windows with MH remotes, too. Increasing the input buffer size helped with that. I suppose I could try increasing that even further and see if that helps with the zwave-hid issues. It'd certainly be nice to fix it, but I'm willing to cut a release if you can't find anything, and see if reports from users help us narrow down a pattern... our Windows support is already 100 times better than last release. True, I don't think the last release even compiled on Windows so that's quite an improvement. Let me spend a little more time looking at it and if there's not an obvious fix, we can just move forward. Cool. BTW, I'm going to compile some Windows binaries after the release now that I can do that from linux and post them too... make our windows users feel special. :) -- Phil Dibowitz p...@ipom.com Open Source software and tech docsInsanity Palace of Metallica http://www.phildev.net/ http://www.ipom.com/ Be who you are and say what you feel, because those who mind don't matter and those who matter don't mind. - Dr. Seuss signature.asc Description: OpenPGP digital signature -- Learn Graph Databases - Download FREE O'Reilly Book Graph Databases is the definitive new guide to graph databases and their applications. Written by three acclaimed leaders in the field, this first edition is now available. Download your free book today! http://p.sf.net/sfu/13534_NeoTech___ concordance-devel mailing list concordance-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/concordance-devel
Re: [concordance-devel] [PATCH] Fix firmware dumps and restores
OK here we go...
We generate a more complete FW dump file now... INFORMATION, PHASE, TYPE,
DATAS, and DATA tags are all there.
I reverted all of the reading/detection changes now.
And this still reverts the int - uint32_t change.
I think this should work for pretty much everything.
--
Phil Dibowitz p...@ipom.com
Open Source software and tech docsInsanity Palace of Metallica
http://www.phildev.net/ http://www.ipom.com/
Be who you are and say what you feel, because those who mind don't matter
and those who matter don't mind.
- Dr. Seuss
commit 78208d4d3b26a7a4685fc4154f41e3e17c7b7228
Author: Phil Dibowitz p...@ipom.com
Date: Tue Mar 18 23:18:17 2014 -0700
Revert lenient file loading and operationfile API change
libconcord/bindings/perl/concord.i
* Support int* as return-value parameters
* Cleanup compile warnings
libconcord/bindings/perl/test.pl
* Cleanup perl warning
libconcord/libconcord.cpp
libconcord/libconcord.h
* revert read_and_parse_file API change from int* - uint32_t*
* write out firmware files with the proper XML tags
libconcord/operationfile.cpp
libconcord/operationfile.h
* revert ReadAndParseFile API change from int* - uint32_t*
* revert accepting files without enclosing INFORMATION/PHASE tags
* revert accepting DATA tags as evidence of FW files, MH config files
also have these
Signed-off-by: Phil Dibowitz p...@ipom.com
diff --git a/libconcord/bindings/perl/concord.i b/libconcord/bindings/perl/concord.i
index fcbd5a6..1c640a9 100644
--- a/libconcord/bindings/perl/concord.i
+++ b/libconcord/bindings/perl/concord.i
@@ -31,7 +31,6 @@ void lc_cb_wrapper(uint32_t stage_id, uint32_t count, uint32_t curr,
{
AV *args = (AV*)arg;
SV *cb;
-SV *cbdata;
int i;
/* get a copy of the stack pointer into SP */
@@ -74,7 +73,7 @@ void lc_cb_wrapper(uint32_t stage_id, uint32_t count, uint32_t curr,
XPUSHs(*av_fetch(args, i, 0));
}
-XPUSHs(sv_2mortal(newSViv(stages)));
+XPUSHs(sv_2mortal(newSVpv((const char *)stages, sizeof(stages;
/*
* Tell it we're done pushing things onto the stack, so it should
@@ -113,7 +112,6 @@ void lc_cb_wrapper(uint32_t stage_id, uint32_t count, uint32_t curr,
*/
%typemap(in) lc_callback %{
AV* args;
-SV *tmp;
/*
* create a new array, store our perl callback in it. We also
@@ -152,6 +150,7 @@ void lc_cb_wrapper(uint32_t stage_id, uint32_t count, uint32_t curr,
* add the arg to our array. See the typemap for lc_callback
* for more details
*/
+SvREFCNT_inc($input);
av_store(args, 1, $input);
/* The array is our callback's argument */
$1 = (void *)args;
@@ -184,6 +183,10 @@ void lc_cb_wrapper(uint32_t stage_id, uint32_t count, uint32_t curr,
$1 = num;
}
+%typemap(in, numinputs=0) int* (int num) {
+$1 = num;
+}
+
/*
* Special case for ir_signal - this is an array of ints.
*/
@@ -242,7 +245,7 @@ void lc_cb_wrapper(uint32_t stage_id, uint32_t count, uint32_t curr,
* outputs, we have to list these individually... ignore only works in input.
*/
%typemap(argout) uint32_t *size,
- uint32_t *type,
+ int *type,
uint32_t *binary_size,
uint32_t *key_names_length,
uint32_t *ir_signal_length,
diff --git a/libconcord/bindings/perl/test.pl b/libconcord/bindings/perl/test.pl
index 1c12ba3..7ac94f2 100755
--- a/libconcord/bindings/perl/test.pl
+++ b/libconcord/bindings/perl/test.pl
@@ -142,7 +142,6 @@ sub learn_ir_commands
my ($err, $type);
print Reading IR file ;
-my $type;
($err, $type) = concord::read_and_parse_file(IR_FILE);
print done\n;
diff --git a/libconcord/libconcord.cpp b/libconcord/libconcord.cpp
index 0c4c344..be54ab5 100644
--- a/libconcord/libconcord.cpp
+++ b/libconcord/libconcord.cpp
@@ -441,7 +441,7 @@ const char *lc_cb_stage_str(int stage)
/*
* Wrapper around the OperationFile class.
*/
-int read_and_parse_file(char *filename, uint32_t *type)
+int read_and_parse_file(char *filename, int *type)
{
of = new OperationFile;
return of-ReadAndParseOpFile(filename, type);
@@ -1512,6 +1512,9 @@ int write_firmware_to_file(uint8_t *in, uint32_t size, char *file_name,
uint8_t *pf = in;
const uint8_t *fwend = in + size;
of.write(INFORMATION\n);
+of.write(\tPHASE\n);
+of.write(\t\tTYPEFirmware_Main/TYPE\n);
+of.write(\t\tDATAS\n);
do {
of.write(\t\t\tDATA);
char hex[16];
@@ -1527,6 +1530,8 @@ int write_firmware_to_file(uint8_t *in, uint32_t size, char *file_name,
}
of.write(/DATA\n);
} while (pf fwend);
+of.write(\t\t/DATAS\n);
+of.write(\t/PHASE\n);
of.write(/INFORMATION\n);
}
diff --git a/libconcord/libconcord.h b/libconcord/libconcord.h
index 8dbd0bd
Re: [concordance-devel] [PATCH] Fix firmware dumps and restores
On 03/20/2014 12:16 AM, Phil Dibowitz wrote:
OK here we go...
We generate a more complete FW dump file now... INFORMATION, PHASE, TYPE,
DATAS, and DATA tags are all there.
I reverted all of the reading/detection changes now.
And this still reverts the int - uint32_t change.
I think this should work for pretty much everything.
Whoops, forgot to revert the python bindings too. This does that.
--
Phil Dibowitz p...@ipom.com
Open Source software and tech docsInsanity Palace of Metallica
http://www.phildev.net/ http://www.ipom.com/
Be who you are and say what you feel, because those who mind don't matter
and those who matter don't mind.
- Dr. Seuss
commit c1876fd992d7e2c8bf52e54f4b82d8996f20748f
Author: Phil Dibowitz p...@ipom.com
Date: Tue Mar 18 23:18:17 2014 -0700
Revert lenient file loading and operationfile API change
libconcord/bindings/perl/concord.i
* Support int* as return-value parameters
* Cleanup compile warnings
libconcord/bindings/perl/test.pl
* Cleanup perl warning
libconcord/libconcord.cpp
libconcord/libconcord.h
* revert read_and_parse_file API change from int* - uint32_t*
* write out firmware files with the proper XML tags
libconcord/operationfile.cpp
libconcord/operationfile.h
* revert ReadAndParseFile API change from int* - uint32_t*
* revert accepting files without enclosing INFORMATION/PHASE tags
* revert accepting DATA tags as evidence of FW files, MH config files
also have these
bindings/python/libconcord.py
* revert read_and_parse_file API change from int* - uint32_t*
Signed-off-by: Phil Dibowitz p...@ipom.com
diff --git a/libconcord/bindings/perl/concord.i b/libconcord/bindings/perl/concord.i
index fcbd5a6..1c640a9 100644
--- a/libconcord/bindings/perl/concord.i
+++ b/libconcord/bindings/perl/concord.i
@@ -31,7 +31,6 @@ void lc_cb_wrapper(uint32_t stage_id, uint32_t count, uint32_t curr,
{
AV *args = (AV*)arg;
SV *cb;
-SV *cbdata;
int i;
/* get a copy of the stack pointer into SP */
@@ -74,7 +73,7 @@ void lc_cb_wrapper(uint32_t stage_id, uint32_t count, uint32_t curr,
XPUSHs(*av_fetch(args, i, 0));
}
-XPUSHs(sv_2mortal(newSViv(stages)));
+XPUSHs(sv_2mortal(newSVpv((const char *)stages, sizeof(stages;
/*
* Tell it we're done pushing things onto the stack, so it should
@@ -113,7 +112,6 @@ void lc_cb_wrapper(uint32_t stage_id, uint32_t count, uint32_t curr,
*/
%typemap(in) lc_callback %{
AV* args;
-SV *tmp;
/*
* create a new array, store our perl callback in it. We also
@@ -152,6 +150,7 @@ void lc_cb_wrapper(uint32_t stage_id, uint32_t count, uint32_t curr,
* add the arg to our array. See the typemap for lc_callback
* for more details
*/
+SvREFCNT_inc($input);
av_store(args, 1, $input);
/* The array is our callback's argument */
$1 = (void *)args;
@@ -184,6 +183,10 @@ void lc_cb_wrapper(uint32_t stage_id, uint32_t count, uint32_t curr,
$1 = num;
}
+%typemap(in, numinputs=0) int* (int num) {
+$1 = num;
+}
+
/*
* Special case for ir_signal - this is an array of ints.
*/
@@ -242,7 +245,7 @@ void lc_cb_wrapper(uint32_t stage_id, uint32_t count, uint32_t curr,
* outputs, we have to list these individually... ignore only works in input.
*/
%typemap(argout) uint32_t *size,
- uint32_t *type,
+ int *type,
uint32_t *binary_size,
uint32_t *key_names_length,
uint32_t *ir_signal_length,
diff --git a/libconcord/bindings/perl/test.pl b/libconcord/bindings/perl/test.pl
index 1c12ba3..7ac94f2 100755
--- a/libconcord/bindings/perl/test.pl
+++ b/libconcord/bindings/perl/test.pl
@@ -142,7 +142,6 @@ sub learn_ir_commands
my ($err, $type);
print Reading IR file ;
-my $type;
($err, $type) = concord::read_and_parse_file(IR_FILE);
print done\n;
diff --git a/libconcord/bindings/python/libconcord.py b/libconcord/bindings/python/libconcord.py
index a2dd4e6..6d475de 100644
--- a/libconcord/bindings/python/libconcord.py
+++ b/libconcord/bindings/python/libconcord.py
@@ -563,7 +563,7 @@ read_and_parse_file = _create_func(
'read_and_parse_file',
_ret_lc_concord(),
_in('filename', c_char_p),
-_out('type', c_uint)
+_out('type', c_int)
)
# void delete_opfile_obj();
diff --git a/libconcord/libconcord.cpp b/libconcord/libconcord.cpp
index 0c4c344..be54ab5 100644
--- a/libconcord/libconcord.cpp
+++ b/libconcord/libconcord.cpp
@@ -441,7 +441,7 @@ const char *lc_cb_stage_str(int stage)
/*
* Wrapper around the OperationFile class.
*/
-int read_and_parse_file(char *filename, uint32_t *type)
+int read_and_parse_file(char *filename, int *type)
{
of = new OperationFile;
return of-ReadAndParseOpFile(filename, type);
@@ -1512,6 +1512,9 @@ int write_firmware_to_file(uint8_t
Re: [concordance-devel] [PATCH] Fix firmware dumps and restores
Here's a patch to revert the uint32_t/int API change (and adds the perl
changes needed to support it) and the lenient file-loading change.
I'm 99.9% sure the latter change won't help you, you'll need to change that
code to handle the MH files better. And if so, I see no reason not to leave
the lenient file-handling as-is (if there's no INFORMATION tags, taking the
whole block is the right thing to do).
LMK.
--
Phil Dibowitz p...@ipom.com
Open Source software and tech docsInsanity Palace of Metallica
http://www.phildev.net/ http://www.ipom.com/
Be who you are and say what you feel, because those who mind don't matter
and those who matter don't mind.
- Dr. Seuss
commit aaed2addb2a0e7a154cadb647997e551af87ce40
Author: Phil Dibowitz p...@ipom.com
Date: Tue Mar 18 23:18:17 2014 -0700
Revert lenient file loading and operationfile API change
libconcord/bindings/perl/concord.i
* Support int* as return-value parameters
* Cleanup compile warnings
libconcord/bindings/perl/test.pl
* Cleanup perl warning
libconcord/libconcord.cpp
libconcord/libconcord.h
* revert read_and_parse_file API change from uint32 - int
libconcord/operationfile.cpp
libconcord/operationfile.h
* revert ReadAndParseFile API change from uint32 - int
* revert accepting files without enclosing INFORMATION tags
Signed-off-by: Phil Dibowitz p...@ipom.com
diff --git a/libconcord/bindings/perl/concord.i b/libconcord/bindings/perl/concord.i
index fcbd5a6..f2199ab 100644
--- a/libconcord/bindings/perl/concord.i
+++ b/libconcord/bindings/perl/concord.i
@@ -31,7 +31,6 @@ void lc_cb_wrapper(uint32_t stage_id, uint32_t count, uint32_t curr,
{
AV *args = (AV*)arg;
SV *cb;
-SV *cbdata;
int i;
/* get a copy of the stack pointer into SP */
@@ -74,7 +73,7 @@ void lc_cb_wrapper(uint32_t stage_id, uint32_t count, uint32_t curr,
XPUSHs(*av_fetch(args, i, 0));
}
-XPUSHs(sv_2mortal(newSViv(stages)));
+XPUSHs(sv_2mortal(newSVpv((const char *)stages, sizeof(stages;
/*
* Tell it we're done pushing things onto the stack, so it should
@@ -184,6 +183,10 @@ void lc_cb_wrapper(uint32_t stage_id, uint32_t count, uint32_t curr,
$1 = num;
}
+%typemap(in, numinputs=0) int* (int num) {
+$1 = num;
+}
+
/*
* Special case for ir_signal - this is an array of ints.
*/
@@ -242,7 +245,7 @@ void lc_cb_wrapper(uint32_t stage_id, uint32_t count, uint32_t curr,
* outputs, we have to list these individually... ignore only works in input.
*/
%typemap(argout) uint32_t *size,
- uint32_t *type,
+ int *type,
uint32_t *binary_size,
uint32_t *key_names_length,
uint32_t *ir_signal_length,
diff --git a/libconcord/bindings/perl/test.pl b/libconcord/bindings/perl/test.pl
index 1c12ba3..7ac94f2 100755
--- a/libconcord/bindings/perl/test.pl
+++ b/libconcord/bindings/perl/test.pl
@@ -142,7 +142,6 @@ sub learn_ir_commands
my ($err, $type);
print Reading IR file ;
-my $type;
($err, $type) = concord::read_and_parse_file(IR_FILE);
print done\n;
diff --git a/libconcord/libconcord.cpp b/libconcord/libconcord.cpp
index 0c4c344..bebe22c 100644
--- a/libconcord/libconcord.cpp
+++ b/libconcord/libconcord.cpp
@@ -441,7 +441,7 @@ const char *lc_cb_stage_str(int stage)
/*
* Wrapper around the OperationFile class.
*/
-int read_and_parse_file(char *filename, uint32_t *type)
+int read_and_parse_file(char *filename, int *type)
{
of = new OperationFile;
return of-ReadAndParseOpFile(filename, type);
diff --git a/libconcord/libconcord.h b/libconcord/libconcord.h
index 8dbd0bd..8e6f7ec 100644
--- a/libconcord/libconcord.h
+++ b/libconcord/libconcord.h
@@ -194,7 +194,7 @@ void delete_blob(uint8_t *ptr);
* Read an operations file from the website, parse it, and return a mode
* of operations.
*/
-int read_and_parse_file(char *filename, uint32_t *type);
+int read_and_parse_file(char *filename, int *type);
/*
* Free the memory used by the file as allocated in read_and_parse_file.
*/
diff --git a/libconcord/operationfile.cpp b/libconcord/operationfile.cpp
index 39807f3..9bab04c 100644
--- a/libconcord/operationfile.cpp
+++ b/libconcord/operationfile.cpp
@@ -229,7 +229,7 @@ int OperationFile::_ExtractFirmwareBinary()
return 0;
}
-int OperationFile::ReadAndParseOpFile(char *file_name, uint32_t *type)
+int OperationFile::ReadAndParseOpFile(char *file_name, int *type)
{
debug(In RAPOF);
int err;
@@ -269,23 +269,13 @@ int OperationFile::ReadAndParseOpFile(char *file_name, uint32_t *type)
err = GetTag(INFORMATION, xml, xml_size, start_info_ptr);
debug(err is %d, err);
if (err == -1) {
-/*
- * In theory, we should always have an INFORMATION section
- * so we used to return LC_ERROR here. However, for a long time
Re: [concordance-devel] [PATCH] Fix firmware dumps and restores
On 03/18/2014 11:22 PM, Phil Dibowitz wrote:
Here's a patch to revert the uint32_t/int API change (and adds the perl
changes needed to support it) and the lenient file-loading change.
I'm 99.9% sure the latter change won't help you, you'll need to change that
code to handle the MH files better. And if so, I see no reason not to leave
the lenient file-handling as-is (if there's no INFORMATION tags, taking the
whole block is the right thing to do).
LMK.
Found another bug in the perl bindings, adds a fix for that.
--
Phil Dibowitz p...@ipom.com
Open Source software and tech docsInsanity Palace of Metallica
http://www.phildev.net/ http://www.ipom.com/
Be who you are and say what you feel, because those who mind don't matter
and those who matter don't mind.
- Dr. Seuss
commit c71d4f432538c773043b2f0fbd836ba7799c13bd
Author: Phil Dibowitz p...@ipom.com
Date: Tue Mar 18 23:18:17 2014 -0700
Revert lenient file loading and operationfile API change
libconcord/bindings/perl/concord.i
* Support int* as return-value parameters
* Cleanup compile warnings
libconcord/bindings/perl/test.pl
* Cleanup perl warning
libconcord/libconcord.cpp
libconcord/libconcord.h
* revert read_and_parse_file API change from uint32 - int
libconcord/operationfile.cpp
libconcord/operationfile.h
* revert ReadAndParseFile API change from uint32 - int
* revert accepting files without enclosing INFORMATION tags
Signed-off-by: Phil Dibowitz p...@ipom.com
diff --git a/libconcord/bindings/perl/concord.i b/libconcord/bindings/perl/concord.i
index fcbd5a6..1c640a9 100644
--- a/libconcord/bindings/perl/concord.i
+++ b/libconcord/bindings/perl/concord.i
@@ -31,7 +31,6 @@ void lc_cb_wrapper(uint32_t stage_id, uint32_t count, uint32_t curr,
{
AV *args = (AV*)arg;
SV *cb;
-SV *cbdata;
int i;
/* get a copy of the stack pointer into SP */
@@ -74,7 +73,7 @@ void lc_cb_wrapper(uint32_t stage_id, uint32_t count, uint32_t curr,
XPUSHs(*av_fetch(args, i, 0));
}
-XPUSHs(sv_2mortal(newSViv(stages)));
+XPUSHs(sv_2mortal(newSVpv((const char *)stages, sizeof(stages;
/*
* Tell it we're done pushing things onto the stack, so it should
@@ -113,7 +112,6 @@ void lc_cb_wrapper(uint32_t stage_id, uint32_t count, uint32_t curr,
*/
%typemap(in) lc_callback %{
AV* args;
-SV *tmp;
/*
* create a new array, store our perl callback in it. We also
@@ -152,6 +150,7 @@ void lc_cb_wrapper(uint32_t stage_id, uint32_t count, uint32_t curr,
* add the arg to our array. See the typemap for lc_callback
* for more details
*/
+SvREFCNT_inc($input);
av_store(args, 1, $input);
/* The array is our callback's argument */
$1 = (void *)args;
@@ -184,6 +183,10 @@ void lc_cb_wrapper(uint32_t stage_id, uint32_t count, uint32_t curr,
$1 = num;
}
+%typemap(in, numinputs=0) int* (int num) {
+$1 = num;
+}
+
/*
* Special case for ir_signal - this is an array of ints.
*/
@@ -242,7 +245,7 @@ void lc_cb_wrapper(uint32_t stage_id, uint32_t count, uint32_t curr,
* outputs, we have to list these individually... ignore only works in input.
*/
%typemap(argout) uint32_t *size,
- uint32_t *type,
+ int *type,
uint32_t *binary_size,
uint32_t *key_names_length,
uint32_t *ir_signal_length,
diff --git a/libconcord/bindings/perl/test.pl b/libconcord/bindings/perl/test.pl
index 1c12ba3..7ac94f2 100755
--- a/libconcord/bindings/perl/test.pl
+++ b/libconcord/bindings/perl/test.pl
@@ -142,7 +142,6 @@ sub learn_ir_commands
my ($err, $type);
print Reading IR file ;
-my $type;
($err, $type) = concord::read_and_parse_file(IR_FILE);
print done\n;
diff --git a/libconcord/libconcord.cpp b/libconcord/libconcord.cpp
index 0c4c344..bebe22c 100644
--- a/libconcord/libconcord.cpp
+++ b/libconcord/libconcord.cpp
@@ -441,7 +441,7 @@ const char *lc_cb_stage_str(int stage)
/*
* Wrapper around the OperationFile class.
*/
-int read_and_parse_file(char *filename, uint32_t *type)
+int read_and_parse_file(char *filename, int *type)
{
of = new OperationFile;
return of-ReadAndParseOpFile(filename, type);
diff --git a/libconcord/libconcord.h b/libconcord/libconcord.h
index 8dbd0bd..8e6f7ec 100644
--- a/libconcord/libconcord.h
+++ b/libconcord/libconcord.h
@@ -194,7 +194,7 @@ void delete_blob(uint8_t *ptr);
* Read an operations file from the website, parse it, and return a mode
* of operations.
*/
-int read_and_parse_file(char *filename, uint32_t *type);
+int read_and_parse_file(char *filename, int *type);
/*
* Free the memory used by the file as allocated in read_and_parse_file.
*/
diff --git a/libconcord/operationfile.cpp b/libconcord/operationfile.cpp
index 39807f3..9bab04c 100644
--- a/libconcord/operationfile.cpp
+++ b/libconcord
Re: [concordance-devel] [PATCH] Fix firmware dumps and restores
On 03/19/2014 07:16 AM, Scott Talbert wrote: On Wed, 19 Mar 2014, Scott Talbert wrote: Crap, that wasn't the most recent version. This adds a minor code cleanup and a lot more comments. This seems fine too, although I don't know how many people have previously dumped firmware lying around that they want to load, so who knows how long that has been broken, if it ever worked. :) I can't say I have ever tried that. It can't have been broken long, it's something I try to test on every release. Merging. Thanks. Final tests? Ooops. concordance doesn't compile due to the API change to read_and_parse_file(). Sigh. This API change is causing yet more pain. It's going to force an otherwise unnecessary lockstep update to congruity. In my opinion, it's not worth it for a cleanup type fix, so I'd suggest rolling it back. Next problem: your firmware file detection change has broken MH config updates - it thinks they are firmware: DEBUG (FindRemote): Testing: 046D, C124 DEBUG (FindRemote): Found a Harmony! DEBUG (ReadAndParseOpFile): In RAPOF DEBUG (ReadZipFile): Internal file is Description.xml DEBUG (ReadZipFile): Size is 345 DEBUG (ReadZipFile): xml is 0xa71080, and xmlsize is 345 DEBUG (ReadZipFile): data_size is 21249 DEBUG (ReadAndParseOpFile): Is zip DEBUG (ReadAndParseOpFile): Has binary! DEBUG (ReadAndParseOpFile): determining type... DEBUG (ReadAndParseOpFile): start/end pointers populated DEBUG (ReadAndParseOpFile): not a connectivity test file DEBUG (ReadAndParseOpFile): Looking for TYPE tag... DEBUG (ReadAndParseOpFile): Looking for PATH tag... DEBUG (ReadAndParseOpFile): Looking for DATA tag... DEBUG (ReadAndParseOpFile): Looks like a firmware file we made Do we really need to support reading the legacy firmware dumps? I'd vote for just pulling that out too. I'll go ahead and revert the fact we don't require INFORMATION tags, but in this case, I'm pretty sure that won't help the addition of accepting a DATA tag will likely trigger this. Yep, MH configs have DATA tags. This is what the MH XML looks like: DATAFILESFILE NAME=Result.EzHex SIZE=21249 PATH=/cfg/usercfg VERSION=1 FW_VERSION=9.5 OPERATIONTYPE=userconfigurationCHECKSUM SEED=0x4321 OFFSET=0x0 LENGTH=0x52fb EXPECTEDVALUE=0xa902 TYPE=XOR//FILE/FILESINTENDEDSKIN78/SKIN/INTENDEDORDERORDER_ELEMENT NAME=Result.EzHex RESET=true//ORDER/DATA Why not add a TYPEFirmware_Main/TYPE to the concordance dumped firmware to just make it clear that it is a firmware file? Hm. Yeah, we can do that. I didn't think of that because only some FW files have that in them, others have URLs we match on, and it feels weird to create something with tags the original file would never have, but I guess that's still cleaner. I'll whip up that change tonight, add it to the patch, test it and post it. -- Phil Dibowitz p...@ipom.com Open Source software and tech docsInsanity Palace of Metallica http://www.phildev.net/ http://www.ipom.com/ Be who you are and say what you feel, because those who mind don't matter and those who matter don't mind. - Dr. Seuss signature.asc Description: OpenPGP digital signature -- Learn Graph Databases - Download FREE O'Reilly Book Graph Databases is the definitive new guide to graph databases and their applications. Written by three acclaimed leaders in the field, this first edition is now available. Download your free book today! http://p.sf.net/sfu/13534_NeoTech___ concordance-devel mailing list concordance-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/concordance-devel
[concordance-devel] [PATCH] Fix firmware dumps and restores
This patch fixes our handling of firmware dump files we create. Previously, we
just wouldn't recognize the file at all.
This also updates the generation code to write out a more recognizable file.
--
Phil Dibowitz p...@ipom.com
Open Source software and tech docsInsanity Palace of Metallica
http://www.phildev.net/ http://www.ipom.com/
Be who you are and say what you feel, because those who mind don't matter
and those who matter don't mind.
- Dr. Seuss
commit 52592d886f6d4aebd182af84572218e2400bbb2b
Author: Phil Dibowitz p...@ipom.com
Date: Mon Mar 17 22:42:12 2014 -0700
Fix firmware file detection and creation
libconcord/operationfile.cpp
* Handle firmware files we created ourselves
libconcord/libconcord.cpp
* Write out more complete XML headers for FW dumps
Signed-off-by: Phil Dibowitz p...@ipom.com
diff --git a/libconcord/libconcord.cpp b/libconcord/libconcord.cpp
index fc1ca7d..fe8b2f4 100644
--- a/libconcord/libconcord.cpp
+++ b/libconcord/libconcord.cpp
@@ -1510,6 +1510,7 @@ int write_firmware_to_file(uint8_t *in, uint32_t size, char *file_name,
uint8_t *pf = in;
const uint8_t *fwend = in + size;
+of.write(INFORMATION\n);
do {
of.write(\t\t\tDATA);
char hex[16];
@@ -1525,6 +1526,7 @@ int write_firmware_to_file(uint8_t *in, uint32_t size, char *file_name,
}
of.write(/DATA\n);
} while (pf fwend);
+of.write(/INFORMATION\n);
}
if (of.close() != 0) {
diff --git a/libconcord/operationfile.cpp b/libconcord/operationfile.cpp
index f20ab72..c260208 100644
--- a/libconcord/operationfile.cpp
+++ b/libconcord/operationfile.cpp
@@ -269,12 +269,23 @@ int OperationFile::ReadAndParseOpFile(char *file_name, int *type)
err = GetTag(INFORMATION, xml, xml_size, start_info_ptr);
debug(err is %d, err);
if (err == -1) {
-return LC_ERROR;
-}
-
-err = GetTag(/INFORMATION, xml, xml_size, end_info_ptr);
-if (err == -1) {
-return LC_ERROR;
+/*
+ * In theory, we should always have an INFORMATION section
+ * so we used to return LC_ERROR here. However, for a long time
+ * when we generated firmware dump files, we didn't surround the
+ * data in INFORMATION tags. However, since that entire file is
+ * XML, we assume that's what we have and set the start/end
+ * of the XML section to the whole file.
+ */
+debug(Unable to find INFORMATION tag, using whole file);
+start_info_ptr = xml;
+end_info_ptr = xml + xml_size;
+} else {
+err = GetTag(/INFORMATION, xml, xml_size, end_info_ptr);
+if (err == -1) {
+debug(Unable to find /INFORMATION tag);
+return LC_ERROR;
+}
}
}
debug(start/end pointers populated);
@@ -310,12 +321,22 @@ int OperationFile::ReadAndParseOpFile(char *file_name, int *type)
while (1) {
uint8_t *tag_ptr;
string tag_s;
+debug(Looking for TYPE tag...\n);
err = GetTag(TYPE, tmp_data, tmp_size, tag_ptr, tag_s);
if (err == -1) {
+debug(Looking for PATH tag...\n);
err = GetTag(PATH, tmp_data, tmp_size, tag_ptr, tag_s);
if (err == -1) {
-debug(not a firmware file);
-break;
+debug(Looking for DATA tag...\n);
+err = GetTag(DATA, tmp_data, tmp_size, tag_ptr, tag_s);
+if (err == -1) {
+debug(not a firmware file);
+break;
+} else {
+debug(Looks like a firmware file we made);
+found_firmware = true;
+break;
+}
}
}
if (!stricmp(tag_s.c_str(), Firmware_Main)) {
signature.asc
Description: OpenPGP digital signature
--
Learn Graph Databases - Download FREE O'Reilly Book
Graph Databases is the definitive new guide to graph databases and their
applications. Written by three acclaimed leaders in the field,
this first edition is now available. Download your free book today!
http://p.sf.net/sfu/13534_NeoTech___
concordance-devel mailing list
concordance-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/concordance-devel
Re: [concordance-devel] [PATCH] Fix firmware dumps and restores
Crap, that wasn't the most recent version. This adds a minor code cleanup and
a lot more comments.
--
Phil Dibowitz p...@ipom.com
Open Source software and tech docsInsanity Palace of Metallica
http://www.phildev.net/ http://www.ipom.com/
Be who you are and say what you feel, because those who mind don't matter
and those who matter don't mind.
- Dr. Seuss
commit f0293677fb0cfc8424e242e87e72bb3b711bed6d
Author: Phil Dibowitz p...@ipom.com
Date: Mon Mar 17 22:42:12 2014 -0700
Fix firmware file detection and creation
libconcord/operationfile.cpp
* Handle firmware files we created ourselves
libconcord/libconcord.cpp
* Write out more complete XML headers for FW dumps
* Minor style cleanups
Signed-off-by: Phil Dibowitz p...@ipom.com
diff --git a/libconcord/libconcord.cpp b/libconcord/libconcord.cpp
index fc1ca7d..fe8b2f4 100644
--- a/libconcord/libconcord.cpp
+++ b/libconcord/libconcord.cpp
@@ -1510,6 +1510,7 @@ int write_firmware_to_file(uint8_t *in, uint32_t size, char *file_name,
uint8_t *pf = in;
const uint8_t *fwend = in + size;
+of.write(INFORMATION\n);
do {
of.write(\t\t\tDATA);
char hex[16];
@@ -1525,6 +1526,7 @@ int write_firmware_to_file(uint8_t *in, uint32_t size, char *file_name,
}
of.write(/DATA\n);
} while (pf fwend);
+of.write(/INFORMATION\n);
}
if (of.close() != 0) {
diff --git a/libconcord/operationfile.cpp b/libconcord/operationfile.cpp
index f20ab72..5311204 100644
--- a/libconcord/operationfile.cpp
+++ b/libconcord/operationfile.cpp
@@ -269,12 +269,23 @@ int OperationFile::ReadAndParseOpFile(char *file_name, int *type)
err = GetTag(INFORMATION, xml, xml_size, start_info_ptr);
debug(err is %d, err);
if (err == -1) {
-return LC_ERROR;
-}
-
-err = GetTag(/INFORMATION, xml, xml_size, end_info_ptr);
-if (err == -1) {
-return LC_ERROR;
+/*
+ * In theory, we should always have an INFORMATION section
+ * so we used to return LC_ERROR here. However, for a long time
+ * when we generated firmware dump files, we didn't surround the
+ * data in INFORMATION tags. However, since that entire file is
+ * XML, we assume that's what we have and set the start/end
+ * of the XML section to the whole file.
+ */
+debug(Unable to find INFORMATION tag, using whole file);
+start_info_ptr = xml;
+end_info_ptr = xml + xml_size;
+} else {
+err = GetTag(/INFORMATION, xml, xml_size, end_info_ptr);
+if (err == -1) {
+debug(Unable to find /INFORMATION tag);
+return LC_ERROR;
+}
}
}
debug(start/end pointers populated);
@@ -310,11 +321,32 @@ int OperationFile::ReadAndParseOpFile(char *file_name, int *type)
while (1) {
uint8_t *tag_ptr;
string tag_s;
+/*
+ * Firmware files will have either a TYPE or a PATH tag with
+ * either a URL or a Firmware_Main string in them.
+ *
+ * Unless we created them, which is what the DATA check
+ * is for.
+ */
+debug(Looking for TYPE tag...\n);
err = GetTag(TYPE, tmp_data, tmp_size, tag_ptr, tag_s);
if (err == -1) {
+debug(Looking for PATH tag...\n);
err = GetTag(PATH, tmp_data, tmp_size, tag_ptr, tag_s);
if (err == -1) {
-debug(not a firmware file);
+debug(Looking for DATA tag...\n);
+err = GetTag(DATA, tmp_data, tmp_size, tag_ptr, tag_s);
+if (err == -1) {
+debug(not a firmware file);
+break;
+}
+/*
+ * If all we have is DATA tags, we made the the file, and
+ * we won't have any of the special strings below, so just
+ * bo ahead and break the loop, we know it's a firmware file.
+ */
+debug(Looks like a firmware file we made);
+found_firmware = true;
break;
}
}
@@ -365,8 +397,7 @@ int OperationFile::ReadAndParseOpFile(char *file_name, int *type)
*type = LC_FILE_TYPE_FIRMWARE;
return 0;
}
-if (!found_get_zaps_only !found_firmware
-found_learn_ir) {
+if (!found_get_zaps_only !found_firmware found_learn_ir) {
debug(returning IR file);
*type = LC_FILE_TYPE_LEARN_IR;
return 0;
@@ -378,4 +409,3 @@ int OperationFile::ReadAndParseOpFile(char *file_name, int *type)
*/
return LC_ERROR;
}
-
signature.asc
Description: OpenPGP digital signature
Re: [concordance-devel] [PATCH] Fix perl bindings
On 03/18/2014 06:21 AM, Scott Talbert wrote: On Mon, 17 Mar 2014, Phil Dibowitz wrote: This patch fixes the perl bindings and the perl test script. All extraneous stuff that made it into previous versions of this patch have been pulled out into separate patches. I don't really know Perl very well, so I can't speak to those changes. But the other changes in this one seem fine to me. Merged, thanks. Thoughts on the operationfile changes? We are both making better files now as well as accepting any old ones. -- Phil Dibowitz p...@ipom.com Open Source software and tech docsInsanity Palace of Metallica http://www.phildev.net/ http://www.ipom.com/ Be who you are and say what you feel, because those who mind don't matter and those who matter don't mind. - Dr. Seuss signature.asc Description: OpenPGP digital signature -- Learn Graph Databases - Download FREE O'Reilly Book Graph Databases is the definitive new guide to graph databases and their applications. Written by three acclaimed leaders in the field, this first edition is now available. Download your free book today! http://p.sf.net/sfu/13534_NeoTech___ concordance-devel mailing list concordance-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/concordance-devel
Re: [concordance-devel] [PATCH] Fix firmware dumps and restores
On 03/18/2014 09:11 AM, Scott Talbert wrote: On Mon, 17 Mar 2014, Phil Dibowitz wrote: Crap, that wasn't the most recent version. This adds a minor code cleanup and a lot more comments. This seems fine too, although I don't know how many people have previously dumped firmware lying around that they want to load, so who knows how long that has been broken, if it ever worked. :) I can't say I have ever tried that. It can't have been broken long, it's something I try to test on every release. Merging. Thanks. Final tests? -- Phil Dibowitz p...@ipom.com Open Source software and tech docsInsanity Palace of Metallica http://www.phildev.net/ http://www.ipom.com/ Be who you are and say what you feel, because those who mind don't matter and those who matter don't mind. - Dr. Seuss signature.asc Description: OpenPGP digital signature -- Learn Graph Databases - Download FREE O'Reilly Book Graph Databases is the definitive new guide to graph databases and their applications. Written by three acclaimed leaders in the field, this first edition is now available. Download your free book today! http://p.sf.net/sfu/13534_NeoTech___ concordance-devel mailing list concordance-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/concordance-devel
Re: [concordance-devel] [PATCH] Fix firmware dumps and restores
On 03/18/2014 08:13 PM, Scott Talbert wrote: On Tue, 18 Mar 2014, Scott Talbert wrote: Crap, that wasn't the most recent version. This adds a minor code cleanup and a lot more comments. This seems fine too, although I don't know how many people have previously dumped firmware lying around that they want to load, so who knows how long that has been broken, if it ever worked. :) I can't say I have ever tried that. It can't have been broken long, it's something I try to test on every release. Merging. Thanks. Final tests? Ooops. concordance doesn't compile due to the API change to read_and_parse_file(). Sigh. This API change is causing yet more pain. It's going to force an otherwise unnecessary lockstep update to congruity. In my opinion, it's not worth it for a cleanup type fix, so I'd suggest rolling it back. Next problem: your firmware file detection change has broken MH config updates - it thinks they are firmware: DEBUG (FindRemote): Testing: 046D, C124 DEBUG (FindRemote): Found a Harmony! DEBUG (ReadAndParseOpFile): In RAPOF DEBUG (ReadZipFile): Internal file is Description.xml DEBUG (ReadZipFile): Size is 345 DEBUG (ReadZipFile): xml is 0xa71080, and xmlsize is 345 DEBUG (ReadZipFile): data_size is 21249 DEBUG (ReadAndParseOpFile): Is zip DEBUG (ReadAndParseOpFile): Has binary! DEBUG (ReadAndParseOpFile): determining type... DEBUG (ReadAndParseOpFile): start/end pointers populated DEBUG (ReadAndParseOpFile): not a connectivity test file DEBUG (ReadAndParseOpFile): Looking for TYPE tag... DEBUG (ReadAndParseOpFile): Looking for PATH tag... DEBUG (ReadAndParseOpFile): Looking for DATA tag... DEBUG (ReadAndParseOpFile): Looks like a firmware file we made Do we really need to support reading the legacy firmware dumps? I'd vote for just pulling that out too. I'll go ahead and revert the fact we don't require INFORMATION tags, but in this case, I'm pretty sure that won't help the addition of accepting a DATA tag will likely trigger this. -- Phil Dibowitz p...@ipom.com Open Source software and tech docsInsanity Palace of Metallica http://www.phildev.net/ http://www.ipom.com/ Be who you are and say what you feel, because those who mind don't matter and those who matter don't mind. - Dr. Seuss signature.asc Description: OpenPGP digital signature -- Learn Graph Databases - Download FREE O'Reilly Book Graph Databases is the definitive new guide to graph databases and their applications. Written by three acclaimed leaders in the field, this first edition is now available. Download your free book today! http://p.sf.net/sfu/13534_NeoTech___ concordance-devel mailing list concordance-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/concordance-devel
Re: [concordance-devel] [PATCH] Fix firmware dumps and restores
On 03/18/2014 04:31 PM, Scott Talbert wrote: On Tue, 18 Mar 2014, Scott Talbert wrote: Crap, that wasn't the most recent version. This adds a minor code cleanup and a lot more comments. This seems fine too, although I don't know how many people have previously dumped firmware lying around that they want to load, so who knows how long that has been broken, if it ever worked. :) I can't say I have ever tried that. It can't have been broken long, it's something I try to test on every release. Merging. Thanks. Final tests? Ooops. concordance doesn't compile due to the API change to read_and_parse_file(). Sigh. This API change is causing yet more pain. It's going to force an otherwise unnecessary lockstep update to congruity. In my opinion, it's not worth it for a cleanup type fix, so I'd suggest rolling it back. It's a bugfix... but I'll see if I can make the perl bindings work without it. -- Phil Dibowitz p...@ipom.com Open Source software and tech docsInsanity Palace of Metallica http://www.phildev.net/ http://www.ipom.com/ Be who you are and say what you feel, because those who mind don't matter and those who matter don't mind. - Dr. Seuss signature.asc Description: OpenPGP digital signature -- Learn Graph Databases - Download FREE O'Reilly Book Graph Databases is the definitive new guide to graph databases and their applications. Written by three acclaimed leaders in the field, this first edition is now available. Download your free book today! http://p.sf.net/sfu/13534_NeoTech___ concordance-devel mailing list concordance-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/concordance-devel
Re: [concordance-devel] [PATCH] Fix Perl Bindings
On 03/16/2014 08:20 PM, Scott Talbert wrote: On Sun, 16 Mar 2014, Phil Dibowitz wrote: Attached patch fixes the perl bindings... But it also fixes a bug in operationfile that couldn't handle firmware dump files we created. BTW, any objections on the operationfile changes? If not, I'll merge. My only question about that is about the API change for read_and_parse_file (int* to uint32_t*). Was there a reason for doing that? If so, then we need to update the Python bindings, too. It making more minimal changes to the perl bindings. It already understood that uint32_t* args were really return values. I could teach it about int* as well, but it seems like uint32_t was more consistent anyway, so i went with that. I actually meant the part where you (I think you) had checked for an INFORMATION tag to sanity check - and now I fall through that if we don't find that tag... because otherwise we never recognize our own FW dump files. Alternatively, I could modify our FW dump code to add INFORMATION tags around the file... -- Phil Dibowitz p...@ipom.com Open Source software and tech docsInsanity Palace of Metallica http://www.phildev.net/ http://www.ipom.com/ Be who you are and say what you feel, because those who mind don't matter and those who matter don't mind. - Dr. Seuss signature.asc Description: OpenPGP digital signature -- Learn Graph Databases - Download FREE O'Reilly Book Graph Databases is the definitive new guide to graph databases and their applications. Written by three acclaimed leaders in the field, this first edition is now available. Download your free book today! http://p.sf.net/sfu/13534_NeoTech___ concordance-devel mailing list concordance-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/concordance-devel
Re: [concordance-devel] [PATCH] Fix Perl Bindings
On 03/17/2014 12:33 AM, Phil Dibowitz wrote:
On 03/16/2014 08:20 PM, Scott Talbert wrote:
On Sun, 16 Mar 2014, Phil Dibowitz wrote:
Attached patch fixes the perl bindings...
But it also fixes a bug in operationfile that couldn't handle firmware dump
files we created.
BTW, any objections on the operationfile changes? If not, I'll merge.
My only question about that is about the API change for
read_and_parse_file (int* to uint32_t*). Was there a reason for doing
that? If so, then we need to update the Python bindings, too.
It making more minimal changes to the perl bindings. It already understood
that uint32_t* args were really return values. I could teach it about int*
as well, but it seems like uint32_t was more consistent anyway, so i went with
that.
I actually meant the part where you (I think you) had checked for an
INFORMATION tag to sanity check - and now I fall through that if we don't
find that tag... because otherwise we never recognize our own FW dump files.
Alternatively, I could modify our FW dump code to add INFORMATION tags around
the file...
BTW, here's a version that updates the py bindings too.
--
Phil Dibowitz p...@ipom.com
Open Source software and tech docsInsanity Palace of Metallica
http://www.phildev.net/ http://www.ipom.com/
Be who you are and say what you feel, because those who mind don't matter
and those who matter don't mind.
- Dr. Seuss
commit 19ed9e5c2c5b5b2f530f4678bfda7f32cd5a6e2b
Author: Phil Dibowitz p...@ipom.com
Date: Sat Mar 15 21:22:22 2014 -0700
Fix Perl Bindings
libconcord/bindings/perl/concord.i
* Fix for chnages in callback API
* Fix for changes in read_and_parse_file
libconcord/bindings/perl/test.pl
* Port to new API
libconcord/libconcord.h
libconcord/libconcord.cpp
* Take a uint32_t for type instead of 'int'
libconcord/operationfile.h
libconcord/operationfile.cpp
* Take a unint32_t for type instead of 'int'
* Handle firmware files we created ourselves
libconcord/web.cpp
* Document GetTag()
libconcord/bindings/python/libconcord.py
* Update bindings for int - uint32_t change
Signed-off-by: Phil Dibowitz p...@ipom.com
diff --git a/libconcord/bindings/perl/concord.i b/libconcord/bindings/perl/concord.i
index 6d183f2..fcbd5a6 100644
--- a/libconcord/bindings/perl/concord.i
+++ b/libconcord/bindings/perl/concord.i
@@ -25,7 +25,9 @@
* This is the C callback that will wrap our perl callback and call
* perl for us. SWIG can't handle this directly, we must do it.
*/
-void lc_cb_wrapper(uint32_t count, uint32_t curr, uint32_t total, void *arg)
+void lc_cb_wrapper(uint32_t stage_id, uint32_t count, uint32_t curr,
+uint32_t total, uint32_t counter_type, void *arg,
+const uint32_t *stages)
{
AV *args = (AV*)arg;
SV *cb;
@@ -47,12 +49,14 @@ void lc_cb_wrapper(uint32_t count, uint32_t curr, uint32_t total, void *arg)
PUSHMARK(SP);
/*
- * Push the first three variables into the stack and mortalize
+ * Push the first 5 variables into the stack and mortalize
* them so that perl will clean them up after the call to cb.
*/
+XPUSHs(sv_2mortal(newSViv(stage_id)));
XPUSHs(sv_2mortal(newSViv(count)));
XPUSHs(sv_2mortal(newSViv(curr)));
XPUSHs(sv_2mortal(newSViv(total)));
+XPUSHs(sv_2mortal(newSViv(counter_type)));
/*
* Next up, we recurse through the array in void *arg and pull
@@ -70,6 +74,8 @@ void lc_cb_wrapper(uint32_t count, uint32_t curr, uint32_t total, void *arg)
XPUSHs(*av_fetch(args, i, 0));
}
+XPUSHs(sv_2mortal(newSViv(stages)));
+
/*
* Tell it we're done pushing things onto the stack, so it should
* now know how big @_ is.
@@ -236,6 +242,7 @@ void lc_cb_wrapper(uint32_t count, uint32_t curr, uint32_t total, void *arg)
* outputs, we have to list these individually... ignore only works in input.
*/
%typemap(argout) uint32_t *size,
+ uint32_t *type,
uint32_t *binary_size,
uint32_t *key_names_length,
uint32_t *ir_signal_length,
diff --git a/libconcord/bindings/perl/test.pl b/libconcord/bindings/perl/test.pl
index 1da009e..1c12ba3 100755
--- a/libconcord/bindings/perl/test.pl
+++ b/libconcord/bindings/perl/test.pl
@@ -35,12 +35,12 @@ use Getopt::Long qw(:config bundling);
use concord;
use constant FW_FILE = '/tmp/perl_fw';
-use constant CONFIG_FILE = '/tmp/perl_fw';
+use constant CONFIG_FILE = '/tmp/perl_cf';
use constant IR_FILE = '/tmp/LearnIr.EZTut';
sub cb
{
-my ($count, $curr, $total, $data) = @_;
+my ($stage_id, $count, $curr, $total, $type, $data, $stages) = @_;
print '*';
#print CALLBACK: count: $count, curr: $curr, total $total, data:
@@ -72,7 +72,6 @@ sub dump_config
sub dump_firmware
{
-
my ($blob, $size);
my $err;
@@ -95,144 +94,61 @@ sub dump_firmware
Re: [concordance-devel] [PATCH] Windows fixes and cleanup
On 03/16/2014 06:43 AM, Scott Talbert wrote: On Sat, 15 Mar 2014, Scott Talbert wrote: Ugh... I'll find some time to do more digging. Ok, sick of waiting for crap to compile/run/etc. on my hold G4, I borrowed a macbook pro. And all of the things just worked without any crazy hidapi hackery, or ignoring certain ACKs. So I'm going to merge the attached patch... it's far more simple than previous ones, and works on both OSX and Linux. I commented on the PR for hidapi - it's unclear to me of the problems are bad hardware, old OSX, old USB, or what... but it works on modern stuff, so I'm going to stop wasting time. :) Yep, I saw your comment on the PR. Yeah I think a lot of the windows oddities I was dealing with were due to having an ancient machine (Pentium M era). Anyway, sounds good to me. Just one question, do you still need libusb-0.1-compat on Mac? I thought hidapi only needed libusb 1.0. Actually, on Mac, you shouldn't even need libusb at all anymore, right? That's true. I'll nuke those two. -- Phil Dibowitz p...@ipom.com Open Source software and tech docsInsanity Palace of Metallica http://www.phildev.net/ http://www.ipom.com/ Be who you are and say what you feel, because those who mind don't matter and those who matter don't mind. - Dr. Seuss signature.asc Description: OpenPGP digital signature -- Learn Graph Databases - Download FREE O'Reilly Book Graph Databases is the definitive new guide to graph databases and their applications. Written by three acclaimed leaders in the field, this first edition is now available. Download your free book today! http://p.sf.net/sfu/13534_NeoTech___ concordance-devel mailing list concordance-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/concordance-devel
Re: [concordance-devel] [PATCH] Fix Perl Bindings
On 03/15/2014 09:27 PM, Phil Dibowitz wrote: Attached patch fixes the perl bindings... But it also fixes a bug in operationfile that couldn't handle firmware dump files we created. BTW, any objections on the operationfile changes? If not, I'll merge. -- Phil Dibowitz p...@ipom.com Open Source software and tech docsInsanity Palace of Metallica http://www.phildev.net/ http://www.ipom.com/ Be who you are and say what you feel, because those who mind don't matter and those who matter don't mind. - Dr. Seuss signature.asc Description: OpenPGP digital signature -- Learn Graph Databases - Download FREE O'Reilly Book Graph Databases is the definitive new guide to graph databases and their applications. Written by three acclaimed leaders in the field, this first edition is now available. Download your free book today! http://p.sf.net/sfu/13534_NeoTech___ concordance-devel mailing list concordance-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/concordance-devel
Re: [concordance-devel] [PATCH] Windows fixes and cleanup
On 03/04/2014 10:37 PM, Phil Dibowitz wrote: On 03/04/2014 12:11 PM, Scott Talbert wrote: On Tue, 4 Mar 2014, Phil Dibowitz wrote: Just for kicks, have you tried running with debug turned off? Yup... on this thing I've done most of my work wiht debug turned off and then verified with debug on to get more info (to avoid these sorts of race-condition issues). Maybe try commenting out the printf's we're doing during config reads and writes (in the callback)? Yeah, I did removed all those to ensure that the PRI change was actually working for the 885 dump. Ugh... I'll find some time to do more digging. Ok, sick of waiting for crap to compile/run/etc. on my hold G4, I borrowed a macbook pro. And all of the things just worked without any crazy hidapi hackery, or ignoring certain ACKs. So I'm going to merge the attached patch... it's far more simple than previous ones, and works on both OSX and Linux. I commented on the PR for hidapi - it's unclear to me of the problems are bad hardware, old OSX, old USB, or what... but it works on modern stuff, so I'm going to stop wasting time. :) -- Phil Dibowitz p...@ipom.com Open Source software and tech docsInsanity Palace of Metallica http://www.phildev.net/ http://www.ipom.com/ Be who you are and say what you feel, because those who mind don't matter and those who matter don't mind. - Dr. Seuss commit 522238e78aeb0ae42dc3533c3412bd79a8746290 Author: Phil Dibowitz p...@ipom.com Date: Sun Dec 1 23:10:48 2013 -0800 Various MacOSX fixes libconcord/configure.ac libconcord/Makefile.am * Start using pkg-config to find zlib - on OSX, some header files are in strange places libconcord/INSTALL.mac * Added homebrew version of instructions * Tweaked instructions for pkg-config change libconcord/libhidapi.cpp * Do not call hid_exit() in ShutdownUSB() or we can never re-grab the remote after a reset - instead use atexit() from InitUSB libconcord/hid.h * Update the default read timeout to 1s - required on my old mac, but probably not a mac issue in general. Signed-off-by: Phil Dibowitz p...@ipom.com diff --git a/libconcord/INSTALL.mac b/libconcord/INSTALL.mac index 10d215a..3010ed7 100644 --- a/libconcord/INSTALL.mac +++ b/libconcord/INSTALL.mac @@ -4,18 +4,31 @@ You'll need the Xcode tools installed before you can do anything. -You'll need to install pkgconfig. I used the Mac package here: +From there, there's two different ways to get the requirements: (1) homebrew +or (2) a combination of macpkg + compiling software yourself. Using homebrew +is highly recommended. + +OPTION 1: HOMEBREW + +Install Homebrew from: http://brew.sh/ + +Tell Homebrew to install all the requirements: + + brew install libusb libusb-compat pkgconfig autoconf automake libtool libzip + +OPTION 2: MANUAL PACKAGE INSTALLATION + +First, install pkgconfig. The Mac package here is pre-built and tested: http://macpkg.sourceforge.net/ You will then need to set the following in your environment for everything else to go smoothly: - export PATH=$PATH:/opt/pkgconfig/bin export PKG_CONFIG=/opt/pkgconfig/bin/pkg-config export PKG_CONFIG_PATH=/usr/lib/pkgconfig:/usr/local/lib/pkgconfig:/usr/X11/lib/pkgconfig -You must install libusb-1.0. It's fairly straight forward to install, it should +Next, install libusb-1.0. It's fairly straight forward to install, it should be: ./configure --prefix=/usr make @@ -24,39 +37,57 @@ be: If you get errors about -System while building libusb, upgrade your version of Xcode. -You must install libusb-0.1-compat as well. It requires libusb-1.0, so install -that first. It is also straight forward: +You must install libusb-0.1-compat as well. This requires libusb-1.0 (it's not +an alternative). It is also straight forward: ./configure --prefix=/usr make sudo make install -You must install hidapi (there's a few similarly named projects, you want: -https://github.com/signal11/hidapi). Grab the source from git (NOT a release), -and do: - ./bootstrap +Finally, you will need to install libzip, which again is straight forward: ./configure --prefix=/usr make sudo make install -Finally, you will need to install libzip, which again is straight forward: +1. INSTALL HIDAPI (an additional pre-req) + +This has to be installed manually, so even if you are using homebrew, you +still have to do this one from scratch (since you need fixes from 'git' that +are not yet in a release). There's a few similarly named projects, you want: + https://github.com/signal11/hidapi + +Grab the source from git (NOT a release), and do: + ./bootstrap ./configure --prefix=/usr make sudo make install - -1. BUILD THE LIBRARY +2. BUILD LIBCONCORD As a normal user... - A. ***IF You are building from CVS, run autoreconf --install + A. IF You
Re: [concordance-devel] [PATCH] Windows fixes and cleanup
On 03/04/2014 06:08 AM, Scott Talbert wrote: Just for kicks, have you tried running with debug turned off? Yup... on this thing I've done most of my work wiht debug turned off and then verified with debug on to get more info (to avoid these sorts of race-condition issues). -- Phil Dibowitz p...@ipom.com Open Source software and tech docsInsanity Palace of Metallica http://www.phildev.net/ http://www.ipom.com/ Be who you are and say what you feel, because those who mind don't matter and those who matter don't mind. - Dr. Seuss signature.asc Description: OpenPGP digital signature -- Subversion Kills Productivity. Get off Subversion Make the Move to Perforce. With Perforce, you get hassle-free workflows. Merge that actually works. Faster operations. Version large binaries. Built-in WAN optimization and the freedom to use Git, Perforce or both. Make the move to Perforce. http://pubads.g.doubleclick.net/gampad/clk?id=122218951iu=/4140/ostg.clktrk___ concordance-devel mailing list concordance-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/concordance-devel
Re: [concordance-devel] [PATCH] Windows fixes and cleanup
On 02/19/2014 06:14 AM, Scott Talbert wrote: On Wed, 19 Feb 2014, Phil Dibowitz wrote: OK with this, and my mac patch, I think we're ready to start preping a release. I'm willing to just say that config-dumping works on mac modulo a pending upstream patch. :) I tested my remotes with the hid_exit() removed, but I'd like a bit of wider testing. Also, I can guard the hid_exit() in an #indef __APPLE, but it's not clear to me that the hid_exit() is something we should be doing between reboots of the remote _anyway_. Hmm. Awesome! I'm glad we got the Mac issue figured out finally. Now, I'm curious, though - I wonder if your double-ack change is really needed in remote_z.cpp, or whether that was just a case of consistently dropping a packet. Do you want to try that again with the patched hidapi? Ugh, so NOW when I write a config to the 890, instead of it failing to read that 2nd ACK, instead it fails a few steps earlier when reading the ACK from GET_CHECKSUM... DEBUG (UpdateConfig): FUNKY-ACK DEBUG (TCP_Ack): Writing packet: 03 40 E5 FD DEBUG (TCP_Read): Reading packet: 03 40 FD E5 33% PHIL 4 DEBUG (UpdateConfig): GET_CHECKSUM DEBUG (TCP_Write): Writing packet: 08 40 E5 FD 00 45 FF FF 04 DEBUG (HID_ReadReport): USB read timed out, 3 ms DEBUG (TCPSendAndCheck): Failed to read from remote Failed to upload config: Error while writing to the remote Failed with error 4 and to make matters worse, disabling the thread pri change maintains this behavior. :( I'll have to debug more later... but this is strange... *sigh* -- Phil Dibowitz p...@ipom.com Open Source software and tech docsInsanity Palace of Metallica http://www.phildev.net/ http://www.ipom.com/ Be who you are and say what you feel, because those who mind don't matter and those who matter don't mind. - Dr. Seuss signature.asc Description: OpenPGP digital signature -- Subversion Kills Productivity. Get off Subversion Make the Move to Perforce. With Perforce, you get hassle-free workflows. Merge that actually works. Faster operations. Version large binaries. Built-in WAN optimization and the freedom to use Git, Perforce or both. Make the move to Perforce. http://pubads.g.doubleclick.net/gampad/clk?id=122218951iu=/4140/ostg.clktrk___ concordance-devel mailing list concordance-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/concordance-devel
Re: [concordance-devel] Fedora and Debian Packages for HIDAPI
On 02/26/2014 08:33 PM, Scott Talbert wrote: On Thu, 7 Nov 2013, Phil Dibowitz wrote: On the Debian front, not much has happened. I've tried approaching a few people, but no progress as of yet. Once we do a release it'll help drive it. Of course, if all else fails, they can drop the C file in, update the Makefile, and go. :) And at long last, hidapi has finally made it into Debian: http://packages.qa.debian.org/h/hidapi.html I'm excited to see this was pulled from git and not a release since that's necessary for us. Yay! Note that hidapi doesn't currently work on kFreeBSD or Hurd, so we'll have to continue using the libconcord implementation of HID for those architectures if we want to keep supporting them on Debian. FreeBSD I can buy... Hurd doesn't really exist. :) -- Phil Dibowitz p...@ipom.com Open Source software and tech docsInsanity Palace of Metallica http://www.phildev.net/ http://www.ipom.com/ Be who you are and say what you feel, because those who mind don't matter and those who matter don't mind. - Dr. Seuss signature.asc Description: OpenPGP digital signature -- Flow-based real-time traffic analytics software. Cisco certified tool. Monitor traffic, SLAs, QoS, Medianet, WAAS etc. with NetFlow Analyzer Customize your own dashboards, set traffic alerts and generate reports. Network behavioral analysis security monitoring. All-in-one tool. http://pubads.g.doubleclick.net/gampad/clk?id=126839071iu=/4140/ostg.clktrk___ concordance-devel mailing list concordance-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/concordance-devel
Re: [concordance-devel] [PATCH] Windows fixes and cleanup
OK with this, and my mac patch, I think we're ready to start preping a release. I'm willing to just say that config-dumping works on mac modulo a pending upstream patch. :) I tested my remotes with the hid_exit() removed, but I'd like a bit of wider testing. Also, I can guard the hid_exit() in an #indef __APPLE, but it's not clear to me that the hid_exit() is something we should be doing between reboots of the remote _anyway_. Hmm. -- Phil Dibowitz p...@ipom.com Open Source software and tech docsInsanity Palace of Metallica http://www.phildev.net/ http://www.ipom.com/ Be who you are and say what you feel, because those who mind don't matter and those who matter don't mind. - Dr. Seuss signature.asc Description: OpenPGP digital signature -- Managing the Performance of Cloud-Based Applications Take advantage of what the Cloud has to offer - Avoid Common Pitfalls. Read the Whitepaper. http://pubads.g.doubleclick.net/gampad/clk?id=121054471iu=/4140/ostg.clktrk___ concordance-devel mailing list concordance-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/concordance-devel
Re: [concordance-devel] [PATCH] Windows fixes and cleanup
On 02/19/2014 06:14 AM, Scott Talbert wrote: On Wed, 19 Feb 2014, Phil Dibowitz wrote: OK with this, and my mac patch, I think we're ready to start preping a release. I'm willing to just say that config-dumping works on mac modulo a pending upstream patch. :) I tested my remotes with the hid_exit() removed, but I'd like a bit of wider testing. Also, I can guard the hid_exit() in an #indef __APPLE, but it's not clear to me that the hid_exit() is something we should be doing between reboots of the remote _anyway_. Hmm. Awesome! I'm glad we got the Mac issue figured out finally. Now, I'm curious, though - I wonder if your double-ack change is really needed in remote_z.cpp, or whether that was just a case of consistently dropping a packet. Do you want to try that again with the patched hidapi? That's a fair question. Seems a little too coincidental, but it's worth a shot. I'll try to test tonight, and if not, when I get back from SCALE. I'm also curious about the timeout change in hid.h, but that might not have been a packet loss thing. I'll try that too. -- Phil Dibowitz p...@ipom.com Open Source software and tech docsInsanity Palace of Metallica http://www.phildev.net/ http://www.ipom.com/ Be who you are and say what you feel, because those who mind don't matter and those who matter don't mind. - Dr. Seuss signature.asc Description: OpenPGP digital signature -- Managing the Performance of Cloud-Based Applications Take advantage of what the Cloud has to offer - Avoid Common Pitfalls. Read the Whitepaper. http://pubads.g.doubleclick.net/gampad/clk?id=121054471iu=/4140/ostg.clktrk___ concordance-devel mailing list concordance-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/concordance-devel
Re: [concordance-devel] [PATCH] Windows fixes and cleanup
On 02/19/2014 07:05 AM, Scott Talbert wrote: On Wed, 19 Feb 2014, Phil Dibowitz wrote: I tested my remotes with the hid_exit() removed, but I'd like a bit of wider testing. Also, I can guard the hid_exit() in an #indef __APPLE, but it's not clear to me that the hid_exit() is something we should be doing between reboots of the remote _anyway_. Hmm. I looked at what libusb-compat does (since libusb 0.1 API doesn't have an exit type call). It uses atexit() to call libusb_exit() in the 1.0 API. So I'm thinking we should probably use atexit() to call hid_exit()? I think that should work. Oh good call! I'll do that. -- Phil Dibowitz p...@ipom.com Open Source software and tech docsInsanity Palace of Metallica http://www.phildev.net/ http://www.ipom.com/ Be who you are and say what you feel, because those who mind don't matter and those who matter don't mind. - Dr. Seuss signature.asc Description: OpenPGP digital signature -- Managing the Performance of Cloud-Based Applications Take advantage of what the Cloud has to offer - Avoid Common Pitfalls. Read the Whitepaper. http://pubads.g.doubleclick.net/gampad/clk?id=121054471iu=/4140/ostg.clktrk___ concordance-devel mailing list concordance-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/concordance-devel
Re: [concordance-devel] [PATCH] Windows fixes and cleanup
On 02/17/2014 07:18 AM, Scott Talbert wrote: On Mon, 17 Feb 2014, Scott Talbert wrote: It's kind of weird that it is always the EF packet that is being dropped, though. I think you've shown dumps where other packets got dropped, though right? I have a hard time believing this just blatanly doesn't work in Mac though... as I said the official software manages to work. The official software doesn't do config dumping, though. Maybe we could try increasing the priority of the read_thread? Not sure if it will help, but it might? I haven't spent much time looking at the internals of hidapi - does it have a separate read thread? I leave for SCALE Thursday, so I won't be around for a bit... not sure when I'll have time to dig into this. -- Phil Dibowitz p...@ipom.com Open Source software and tech docsInsanity Palace of Metallica http://www.phildev.net/ http://www.ipom.com/ Be who you are and say what you feel, because those who mind don't matter and those who matter don't mind. - Dr. Seuss signature.asc Description: OpenPGP digital signature -- Managing the Performance of Cloud-Based Applications Take advantage of what the Cloud has to offer - Avoid Common Pitfalls. Read the Whitepaper. http://pubads.g.doubleclick.net/gampad/clk?id=121054471iu=/4140/ostg.clktrk___ concordance-devel mailing list concordance-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/concordance-devel
Re: [concordance-devel] [PATCH] Various OSX fixes
On 02/16/2014 10:26 AM, Scott Talbert wrote: Yeah, I guess it seems OK. The things that are timing related are kind of worrisome, but not sure what to do about them. I could wrap the hid_exit() in an #ifndef __APPLE or whatever the define is, I guess. Have you tested without hid_exit() on Linux? On Windows, it doesn't look hid_exit() actually does anything. On Linux, it calls libusb_exit() - I'm not sure what the consequences of not calling that would be. We probably ought to be calling hid_exit() when concordance exits, though. Which probably would mean adding a function to libconcord so that concordance can call it when it is about to exit. I have tried it with and without on Linux and it doesn't make a difference. That said, I imagine when the process exits all your libusb handles get cleaned up anyway, and the refcounts in the kernel go back down. -- Phil Dibowitz p...@ipom.com Open Source software and tech docsInsanity Palace of Metallica http://www.phildev.net/ http://www.ipom.com/ Be who you are and say what you feel, because those who mind don't matter and those who matter don't mind. - Dr. Seuss signature.asc Description: OpenPGP digital signature -- Managing the Performance of Cloud-Based Applications Take advantage of what the Cloud has to offer - Avoid Common Pitfalls. Read the Whitepaper. http://pubads.g.doubleclick.net/gampad/clk?id=121054471iu=/4140/ostg.clktrk___ concordance-devel mailing list concordance-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/concordance-devel
Re: [concordance-devel] [PATCH] Windows fixes and cleanup
On 02/17/2014 06:12 AM, Scott Talbert wrote: It's kind of weird that it is always the EF packet that is being dropped, though. I think you've shown dumps where other packets got dropped, though right? Yeah, definitely. Weird coincident this time, I think. I have a hard time believing this just blatanly doesn't work in Mac though... as I said the official software manages to work. The official software doesn't do config dumping, though. True. But even still, it works on every other platform, I have a hard time imagining Mac's HID stack is just that bad. And also, they write that many packets during config-writing... it's odd to me it would be so reliable one way and so unreliable the other way. What's *also* odd to me is that the other day when I was first playing with a larger queue I had quite a while where it was working fine, but the entire time I was debugging for the above output it wasn't working. WTF. Also, I have a pretty old mac (silver powerpc tower thing), I'm tempted to try it on something more modern... -- Phil Dibowitz p...@ipom.com Open Source software and tech docsInsanity Palace of Metallica http://www.phildev.net/ http://www.ipom.com/ Be who you are and say what you feel, because those who mind don't matter and those who matter don't mind. - Dr. Seuss signature.asc Description: OpenPGP digital signature -- Managing the Performance of Cloud-Based Applications Take advantage of what the Cloud has to offer - Avoid Common Pitfalls. Read the Whitepaper. http://pubads.g.doubleclick.net/gampad/clk?id=121054471iu=/4140/ostg.clktrk___ concordance-devel mailing list concordance-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/concordance-devel
Re: [concordance-devel] [PATCH] Windows fixes and cleanup
On 02/18/2014 10:04 AM, Scott Talbert wrote: On Tue, 18 Feb 2014, Phil Dibowitz wrote: It's kind of weird that it is always the EF packet that is being dropped, though. I think you've shown dumps where other packets got dropped, though right? I have a hard time believing this just blatanly doesn't work in Mac though... as I said the official software manages to work. The official software doesn't do config dumping, though. Maybe we could try increasing the priority of the read_thread? Not sure if it will help, but it might? I haven't spent much time looking at the internals of hidapi - does it have a separate read thread? I leave for SCALE Thursday, so I won't be around for a bit... not sure when I'll have time to dig into this. Yep, see read_thread(). It looks like it hooks itself up as the run loop for the HID device, so that's the thread that calls hid_report_callback() when data comes in. Setting the priority to SCHED_RR and 99 helps a bit, we typically get a lot further than 18%. We then mostly die in timeouts, but still occasionally have a missing packet for some reason or another. I bumped the timeout all the way up to 15 seconds, and even still we hit timeouts most of the time now. Which again, I don't buy I... don't get it. -- Phil Dibowitz p...@ipom.com Open Source software and tech docsInsanity Palace of Metallica http://www.phildev.net/ http://www.ipom.com/ Be who you are and say what you feel, because those who mind don't matter and those who matter don't mind. - Dr. Seuss signature.asc Description: OpenPGP digital signature -- Managing the Performance of Cloud-Based Applications Take advantage of what the Cloud has to offer - Avoid Common Pitfalls. Read the Whitepaper. http://pubads.g.doubleclick.net/gampad/clk?id=121054471iu=/4140/ostg.clktrk___ concordance-devel mailing list concordance-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/concordance-devel
Re: [concordance-devel] [PATCH] Windows fixes and cleanup
On 02/18/2014 09:39 PM, Phil Dibowitz wrote: Setting the priority to SCHED_RR and 99 helps a bit, we typically get a lot further than 18%. We then mostly die in timeouts, but still occasionally have a missing packet for some reason or another. I bumped the timeout all the way up to 15 seconds, and even still we hit timeouts most of the time now. Which again, I don't buy I... don't get it. Hmm. Once I dropped all the debug logging, setting the priority actually seems to solve the problem quite well. I've dropped the queue back down to 30, rebooted a few times, done several tests. I'll do more tests, but this seems to make a big difference. In fact, if I take that code back it out, it fails reliably, and if I put it back in, it succeeds reliably. So I think we have a winner! Now to see if hidapi will accept such a crazy patch. :) -- Phil Dibowitz p...@ipom.com Open Source software and tech docsInsanity Palace of Metallica http://www.phildev.net/ http://www.ipom.com/ Be who you are and say what you feel, because those who mind don't matter and those who matter don't mind. - Dr. Seuss signature.asc Description: OpenPGP digital signature -- Managing the Performance of Cloud-Based Applications Take advantage of what the Cloud has to offer - Avoid Common Pitfalls. Read the Whitepaper. http://pubads.g.doubleclick.net/gampad/clk?id=121054471iu=/4140/ostg.clktrk___ concordance-devel mailing list concordance-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/concordance-devel
Re: [concordance-devel] [PATCH] Windows fixes and cleanup
On 02/18/2014 10:20 PM, Phil Dibowitz wrote: On 02/18/2014 09:39 PM, Phil Dibowitz wrote: Setting the priority to SCHED_RR and 99 helps a bit, we typically get a lot further than 18%. We then mostly die in timeouts, but still occasionally have a missing packet for some reason or another. I bumped the timeout all the way up to 15 seconds, and even still we hit timeouts most of the time now. Which again, I don't buy I... don't get it. Hmm. Once I dropped all the debug logging, setting the priority actually seems to solve the problem quite well. I've dropped the queue back down to 30, rebooted a few times, done several tests. I'll do more tests, but this seems to make a big difference. In fact, if I take that code back it out, it fails reliably, and if I put it back in, it succeeds reliably. So I think we have a winner! Now to see if hidapi will accept such a crazy patch. :) https://github.com/signal11/hidapi/pull/161 -- Phil Dibowitz p...@ipom.com Open Source software and tech docsInsanity Palace of Metallica http://www.phildev.net/ http://www.ipom.com/ Be who you are and say what you feel, because those who mind don't matter and those who matter don't mind. - Dr. Seuss signature.asc Description: OpenPGP digital signature -- Managing the Performance of Cloud-Based Applications Take advantage of what the Cloud has to offer - Avoid Common Pitfalls. Read the Whitepaper. http://pubads.g.doubleclick.net/gampad/clk?id=121054471iu=/4140/ostg.clktrk___ concordance-devel mailing list concordance-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/concordance-devel
Re: [concordance-devel] [PATCH] Windows fixes and cleanup
time believing this just blatanly doesn't work in Mac though... as I said the official software manages to work. Not USB, just HID. I would think that this is a bit of a weird case for HID. I would think most HID devices are probably sending things like mouse coordinates periodically. Transferring a file (sending a long stream of packets continuously) is probably not something that happens very often with HID devices? I wouldn't think? That seems true in theory, but in practice, it seems like anything that you want to control in userspace people just throw behind HID, so I get the feeling it's more common than you'd think. -- Phil Dibowitz p...@ipom.com Open Source software and tech docsInsanity Palace of Metallica http://www.phildev.net/ http://www.ipom.com/ Be who you are and say what you feel, because those who mind don't matter and those who matter don't mind. - Dr. Seuss signature.asc Description: OpenPGP digital signature -- Android apps run on BlackBerry 10 Introducing the new BlackBerry 10.2.1 Runtime for Android apps. Now with support for Jelly Bean, Bluetooth, Mapview and more. Get your Android app in front of a whole new audience. Start now. http://pubads.g.doubleclick.net/gampad/clk?id=124407151iu=/4140/ostg.clktrk___ concordance-devel mailing list concordance-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/concordance-devel
Re: [concordance-devel] [PATCH] Fix all current warnings
On 02/16/2014 09:44 AM, Scott Talbert wrote: On Sat, 15 Feb 2014, Phil Dibowitz wrote: Also, enable -Wall for libconcord so we notice them sooner. Signed-off-by: Scott Talbert s...@techie.net Applied, thanks. What about my Windows fixes patch and my dir-locals patch? The Major cleanup for Windows patch? v5 was applied a long time ago. Missed the dir-locals, I'll get that now. -- Phil Dibowitz p...@ipom.com Open Source software and tech docsInsanity Palace of Metallica http://www.phildev.net/ http://www.ipom.com/ Be who you are and say what you feel, because those who mind don't matter and those who matter don't mind. - Dr. Seuss signature.asc Description: OpenPGP digital signature -- Android apps run on BlackBerry 10 Introducing the new BlackBerry 10.2.1 Runtime for Android apps. Now with support for Jelly Bean, Bluetooth, Mapview and more. Get your Android app in front of a whole new audience. Start now. http://pubads.g.doubleclick.net/gampad/clk?id=124407151iu=/4140/ostg.clktrk___ concordance-devel mailing list concordance-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/concordance-devel
Re: [concordance-devel] [PATCH] Needed to add c++-mode to .dir-locals also.
Applied, thanks. -- Phil Dibowitz p...@ipom.com Open Source software and tech docsInsanity Palace of Metallica http://www.phildev.net/ http://www.ipom.com/ Be who you are and say what you feel, because those who mind don't matter and those who matter don't mind. - Dr. Seuss signature.asc Description: OpenPGP digital signature -- Android apps run on BlackBerry 10 Introducing the new BlackBerry 10.2.1 Runtime for Android apps. Now with support for Jelly Bean, Bluetooth, Mapview and more. Get your Android app in front of a whole new audience. Start now. http://pubads.g.doubleclick.net/gampad/clk?id=124407151iu=/4140/ostg.clktrk___ concordance-devel mailing list concordance-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/concordance-devel
Re: [concordance-devel] [PATCHv2] Windows fixes and cleanup
On 02/16/2014 07:27 PM, Scott Talbert wrote: Remove unneeded code includes. On Windows, when performing config dumps, found that packets were being lost but we were not detecting this. Added code to check the sequence numbers of the incoming packets. Additionally, added a check after the loop to ensure that the read did not time out. Applied, thanks! -- Phil Dibowitz p...@ipom.com Open Source software and tech docsInsanity Palace of Metallica http://www.phildev.net/ http://www.ipom.com/ Be who you are and say what you feel, because those who mind don't matter and those who matter don't mind. - Dr. Seuss signature.asc Description: OpenPGP digital signature -- Android apps run on BlackBerry 10 Introducing the new BlackBerry 10.2.1 Runtime for Android apps. Now with support for Jelly Bean, Bluetooth, Mapview and more. Get your Android app in front of a whole new audience. Start now. http://pubads.g.doubleclick.net/gampad/clk?id=124407151iu=/4140/ostg.clktrk___ concordance-devel mailing list concordance-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/concordance-devel
Re: [concordance-devel] [PATCH] Windows fixes and cleanup
On 02/16/2014 05:30 PM, Scott Talbert wrote: On Sun, 16 Feb 2014, Phil Dibowitz wrote: I don't think that is strange. I think what happened in this case was - we got busy and queued up five packets. Then we read all of them and got caught up. So, at that point we're caught up and now blocking, waiting on the read thread to wake us up. The next few packets are received while we're waiting for them. But for some reason we still lost some. How did we pop a 6th packet off of the queue if we never queued one? I don't know exactly where all your debug statements are to be able to tell exactly what is going on. My assumption was that, after the 5th packet, we were in the situation where the the thread doing hid_read_timeout() was waiting on the one reading the packets, so the queue never got bigger than one. Yeah, but even if we were in hid_read_timeout() when the packet comes in, we'd still get an interrupt, jump into hid_report_callback(), pop it on the queue, and then return so hid_read_timeout() could then return. Or at least that's how I parse the code. It's unclear to me what the solution here is... it seems like they're saying have another thread that just constantly reads, i.e., be faster ? It wasn't clear to me that there actually *is* a solution. I don't know what else the Run Loop is doing besides calling hid_report_callback when it needs to. I feel like we're missing something. There's a solution *somewhere* or USB would just fail miserably on Macs... -- Phil Dibowitz p...@ipom.com Open Source software and tech docsInsanity Palace of Metallica http://www.phildev.net/ http://www.ipom.com/ Be who you are and say what you feel, because those who mind don't matter and those who matter don't mind. - Dr. Seuss signature.asc Description: OpenPGP digital signature -- Android apps run on BlackBerry 10 Introducing the new BlackBerry 10.2.1 Runtime for Android apps. Now with support for Jelly Bean, Bluetooth, Mapview and more. Get your Android app in front of a whole new audience. Start now. http://pubads.g.doubleclick.net/gampad/clk?id=124407151iu=/4140/ostg.clktrk___ concordance-devel mailing list concordance-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/concordance-devel
Re: [concordance-devel] Concordance Debian Package
On 02/01/2014 07:22 AM, Scott Talbert wrote: Probably the easiest thing to do in order to get things working quickly is to just remove iptables and dnsmasq from the concordance dependencies. The number of remotes that require dnsmasq is very small, so this is not likely to affect a lot of users. Those users will just have to ensure they have dnsmasq/iptables installed - which is probably likely anyway, especially for iptables. That idea scares me. It leaves the package broken for Linux users with those remotes (which is a growing number, almost all their newer remotes seem to be full zwave type). -- Phil Dibowitz p...@ipom.com Open Source software and tech docsInsanity Palace of Metallica http://www.phildev.net/ http://www.ipom.com/ Be who you are and say what you feel, because those who mind don't matter and those who matter don't mind. - Dr. Seuss signature.asc Description: OpenPGP digital signature -- Android apps run on BlackBerry 10 Introducing the new BlackBerry 10.2.1 Runtime for Android apps. Now with support for Jelly Bean, Bluetooth, Mapview and more. Get your Android app in front of a whole new audience. Start now. http://pubads.g.doubleclick.net/gampad/clk?id=124407151iu=/4140/ostg.clktrk___ concordance-devel mailing list concordance-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/concordance-devel
Re: [concordance-devel] [PATCH] Fix all current warnings
On 02/08/2014 09:52 AM, Scott Talbert wrote: const char *mh_config_header = DATAFILESFILE NAME=\Result.EzHex\ SIZE=\%i\ PATH=\/cfg/usercfg\ VERSION=\1\ FW_VERSION=\9.5\ OPERATIONTYPE=\userconfiguration\CHECKSUM SEED=\0x4321\ OFFSET=\0x0\ LENGTH=\0x%04x\ EXPECTEDVALUE=\0x%04x\ TYPE=\XOR\//FILE/FILESINTENDEDSKIN%i/SKIN/INTENDEDORDERORDER_ELEMENT NAME=\Result.EzHex\ RESET=\true\//ORDER/DATA; -//User-Agent: HarmonyBrowser/7.7.0 (Build 0; UpdatedFrom 7.3.0.15; Skin logitech; Windows Vista 6.1; x86; en; rv: 1.8.0.2) Gecko/20060125\r\n\ - const char *post_header=\ Does this cause an actual warning? I have a feeling one of these days we'll have to update our UA to not get blocked... I was saving it there for that day. :) -- Phil Dibowitz p...@ipom.com Open Source software and tech docsInsanity Palace of Metallica http://www.phildev.net/ http://www.ipom.com/ Be who you are and say what you feel, because those who mind don't matter and those who matter don't mind. - Dr. Seuss signature.asc Description: OpenPGP digital signature -- Android apps run on BlackBerry 10 Introducing the new BlackBerry 10.2.1 Runtime for Android apps. Now with support for Jelly Bean, Bluetooth, Mapview and more. Get your Android app in front of a whole new audience. Start now. http://pubads.g.doubleclick.net/gampad/clk?id=124407151iu=/4140/ostg.clktrk___ concordance-devel mailing list concordance-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/concordance-devel
Re: [concordance-devel] [PATCH] Windows fixes and cleanup
On 01/28/2014 06:14 AM, Scott Talbert wrote: In your situation, in which case are you seeing dropped packets? Config update? Config dump? Or both? And with which remote(s)? config dump, 885. -- Phil Dibowitz p...@ipom.com Open Source software and tech docsInsanity Palace of Metallica http://www.phildev.net/ http://www.ipom.com/ Be who you are and say what you feel, because those who mind don't matter and those who matter don't mind. - Dr. Seuss signature.asc Description: OpenPGP digital signature -- Android apps run on BlackBerry 10 Introducing the new BlackBerry 10.2.1 Runtime for Android apps. Now with support for Jelly Bean, Bluetooth, Mapview and more. Get your Android app in front of a whole new audience. Start now. http://pubads.g.doubleclick.net/gampad/clk?id=124407151iu=/4140/ostg.clktrk___ concordance-devel mailing list concordance-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/concordance-devel
Re: [concordance-devel] [PATCH] Windows fixes and cleanup
On 02/15/2014 06:12 PM, Scott Talbert wrote: Hmm. Maybe try adding a printf() in hidapi when it drops a packet to ensure that that's the problem we're really seeing? That should help narrow it down. We're not dropping packets there... and in fact, with some extra instrumentation we seem to have more than one distinct problem. So here's a missing sequence number... all messages starring with PHIL are from hidapi: DEBUG (ReadFlash): Expected seq BC DEBUG (ReadFlash): Next expected seq CD PHIL: hid_read_timeout: calling return_data(). PHIL: hid_read_timeout: unlocking... PHIL: hid_read_timeout: returning 64 DEBUG (ReadFlash): Expected seq CD DEBUG (ReadFlash): Next expected seq DE PHIL: hid_read_timeout: calling return_data(). PHIL: hid_read_timeout: unlocking... PHIL: hid_read_timeout: returning 64 DEBUG (ReadFlash): Expected seq DE DEBUG (ReadFlash): Next expected seq EF PHIL: hid_read_timeout: calling return_data(). PHIL: hid_read_timeout: unlocking... PHIL: hid_read_timeout: returning 64 DEBUG (ReadFlash): Expected seq EF DEBUG (ReadFlash): Invalid sequence want: EF got: 11 Failed to dump config: Error while reading from the remote Failed with error 3 Scrolling up, you can see that hid_report_callback never queued more than 3 packets: PHIL: hid_report_callback: 3th pckt PHIL: hid_report_callback: sending pthread signal PHIL: hid_report_callback: unlocking PHIL: hid_report_callback: returning PHIL: hid_read_timeout: calling return_data(). PHIL: hid_read_timeout: unlocking... PHIL: hid_read_timeout: returning 64 DEBUG (ReadFlash): Expected seq BC Now, if I run a bunch more times, eventually I get: DEBUG (ReadFlash): Expected seq EF DEBUG (ReadFlash): Next expected seq 00 PHIL: hid_read_timeout: no data. PHIL: hid_read_timeout: non-blocking 60 PHIL: hid_read_timeout: unlocking... PHIL: hid_read_timeout: returning 0 DEBUG (HID_ReadReport): USB read timed out Failed to dump config: Error while reading from the remote Failed with error 3 Note the USB timeout! That's with the timeout bumped to 1s, from 500ms. Hmmm. If I bring it up to 5s it's VERY rare (I can sometimes trigger it, but only after lots of times in a loop). Either way, the next time: PHIL: hid_report_callback: 5th pckt PHIL: hid_report_callback: sending pthread signal PHIL: hid_report_callback: unlocking PHIL: hid_report_callback: returning ... DEBUG (ReadFlash): Expected seq 89 DEBUG (ReadFlash): Next expected seq 9A PHIL: hid_read_timeout: calling return_data(). PHIL: hid_read_timeout: unlocking... PHIL: hid_read_timeout: returning 64 DEBUG (ReadFlash): Expected seq 9A DEBUG (ReadFlash): Invalid sequence want: 9A got: bc Failed to dump config: Error while reading from the remote Failed with error 3 What's really strange is, in theory we queue 5 packets, and then read 6 packets when we hit the missing ones: PHIL: hid_report_callback: 5th pckt PHIL: hid_report_callback: sending pthread signal PHIL: hid_report_callback: unlocking PHIL: hid_report_callback: returning PHIL: hid_read_timeout: calling return_data(). PHIL: hid_read_timeout: unlocking... PHIL: hid_read_timeout: returning 64 DEBUG (ReadFlash): Expected seq 34 DEBUG (ReadFlash): Next expected seq 45 PHIL: hid_read_timeout: calling return_data(). PHIL: hid_read_timeout: unlocking... PHIL: hid_read_timeout: returning 64 DEBUG (ReadFlash): Expected seq 45 DEBUG (ReadFlash): Next expected seq 56 PHIL: hid_read_timeout: calling return_data(). PHIL: hid_read_timeout: unlocking... PHIL: hid_read_timeout: returning 64 DEBUG (ReadFlash): Expected seq 56 DEBUG (ReadFlash): Next expected seq 67 PHIL: hid_read_timeout: calling return_data(). PHIL: hid_read_timeout: unlocking... PHIL: hid_read_timeout: returning 64 DEBUG (ReadFlash): Expected seq 67 DEBUG (ReadFlash): Next expected seq 78 PHIL: hid_read_timeout: calling return_data(). PHIL: hid_read_timeout: unlocking... PHIL: hid_read_timeout: returning 64 DEBUG (ReadFlash): Expected seq 78 DEBUG (ReadFlash): Next expected seq 89 PHIL: hid_read_timeout: calling return_data(). PHIL: hid_read_timeout: unlocking... PHIL: hid_read_timeout: returning 64 DEBUG (ReadFlash): Expected seq 89 DEBUG (ReadFlash): Next expected seq 9A PHIL: hid_read_timeout: calling return_data(). PHIL: hid_read_timeout: unlocking... PHIL: hid_read_timeout: returning 64 DEBUG (ReadFlash): Expected seq 9A DEBUG (ReadFlash): Invalid sequence want: 9A got: cd Failed to dump config: Error while reading from the remote Failed with error 3 I'm lost. -- Phil Dibowitz p...@ipom.com Open Source software and tech docsInsanity Palace of Metallica http://www.phildev.net/ http://www.ipom.com/ Be who you are and say what you feel, because those who mind don't matter and those who matter don't mind. - Dr. Seuss signature.asc Description: OpenPGP digital signature -- Android apps run on BlackBerry 10 Introducing the new BlackBerry 10.2.1
Re: [concordance-devel] [PATCH] Various OSX fixes
On 02/15/2014 06:09 PM, Scott Talbert wrote:
On Sat, 15 Feb 2014, Phil Dibowitz wrote:
This fixes building on OSX as well as config-updates for 89x on OSX.
Scott,
Does this seem reasonable to you? Even though some things still don't work on
OSX, this fixes a TON of them. The only potentially scary part here is the
removal of the hid_exit() call...
Does what seem reasonable? Did you intend to send another version of the
patch? :-) Because the one you sent back in Dec didn't have hid_exit
removed.
Oh, sorry, I thought the last one I sent was the most recent... but here.
--
Phil Dibowitz p...@ipom.com
Open Source software and tech docsInsanity Palace of Metallica
http://www.phildev.net/ http://www.ipom.com/
Be who you are and say what you feel, because those who mind don't matter
and those who matter don't mind.
- Dr. Seuss
commit 2d9ee2fb8d49bed6e3406cf463a9887c6681a767
Author: Phil Dibowitz p...@ipom.com
Date: Sun Dec 1 23:10:48 2013 -0800
Various MacOSX fixes
libconcord/configure.ac
libconcord/Makefile.am
libconcord/INSTALL
* Start using pkg-config to find zlib - on OSX, some header files
are in strange places
libconcord/remote_z.cpp
* For some reason the double-ack-read doesn't work in one instance
on OSX. This is remote behavior, not host behavior, so I don't
see how this is possible, but this is the only way I can make
config updates on 890s work on OSX.
libconcord/libhidapi.cpp
* Do not call hid_exit() in ShutdownUSB() or we can never re-grab
the remote after a reset.
libconcord/hid.h
* Update the default read timeout to 1s - required for Mac, and probably
anything on USB1.
Signed-off-by: Phil Dibowitz p...@ipom.com
diff --git a/libconcord/INSTALL.mac b/libconcord/INSTALL.mac
index 10d215a..d94e159 100644
--- a/libconcord/INSTALL.mac
+++ b/libconcord/INSTALL.mac
@@ -47,7 +47,13 @@ Finally, you will need to install libzip, which again is straight forward:
1. BUILD THE LIBRARY
As a normal user...
- A. ***IF You are building from CVS, run autoreconf --install
+ A. IF You are building from git, run autoreconf --install
+Note that if you're doing this on OSX, depending on your setup,
+you may instead have to run:
+ aclocal -I /opt/pkgconfig/share/aclocal
+ autoheader
+ automake
+ autoconf
B. Run ./configure
C. Run make
diff --git a/libconcord/Makefile.am b/libconcord/Makefile.am
index de6ae23..eda90d9 100644
--- a/libconcord/Makefile.am
+++ b/libconcord/Makefile.am
@@ -7,6 +7,7 @@ libconcord_la_SOURCES = remote.cpp remote_z.cpp libconcord.cpp binaryfile.cpp \
operationfile.cpp remote_mh.cpp libusbhid.cpp libhidapi.cpp
include_HEADERS = libconcord.h
libconcord_la_LDFLAGS = -version-info 3:0:0 $(LIBCONCORD_LDFLAGS) -lzip
+libconcord_la_CXXFLAGS = $(ZIP_CFLAGS)
UDEVROOT ?= /
UDEVLIBDIR ?= $(UDEVROOT)/lib
diff --git a/libconcord/configure.ac b/libconcord/configure.ac
index 48a453f..cc5898b 100644
--- a/libconcord/configure.ac
+++ b/libconcord/configure.ac
@@ -74,12 +74,7 @@ then
fi
AC_MSG_ERROR([$errorstr])
fi
-AC_CHECK_HEADER(zip.h, [], [a=0])
-AC_CHECK_LIB(zip, zip_open, [], [a=0])
-if test $a == 0
-then
-AC_MSG_ERROR([Error, libzip is missing!])
-fi
+PKG_CHECK_MODULES([ZIP], [libzip])
AC_CONFIG_FILES([
Makefile
])
diff --git a/libconcord/hid.h b/libconcord/hid.h
index 62bb369..a499d94 100644
--- a/libconcord/hid.h
+++ b/libconcord/hid.h
@@ -38,6 +38,6 @@ void ShutdownUSB();
int FindRemote(THIDINFO hid_info);
int HID_WriteReport(const uint8_t *data);
-int HID_ReadReport(uint8_t *data, unsigned int timeout = 500);
+int HID_ReadReport(uint8_t *data, unsigned int timeout = 1000);
#endif
diff --git a/libconcord/libhidapi.cpp b/libconcord/libhidapi.cpp
index 9acdbc7..f80bbf1 100644
--- a/libconcord/libhidapi.cpp
+++ b/libconcord/libhidapi.cpp
@@ -59,7 +59,11 @@ void ShutdownUSB()
if (h_dev) {
hid_close(h_dev);
}
-hid_exit();
+/*
+ * Note we do NOT call hid_exit() here, because you can
+ * never reinitialize libhidapi - and on a reset, we need
+ * to come back and do more stuff.
+ */
}
bool is_harmony(struct hid_device_info *dev)
diff --git a/libconcord/remote_z.cpp b/libconcord/remote_z.cpp
index 2c4ddc2..4e1fa45 100644
--- a/libconcord/remote_z.cpp
+++ b/libconcord/remote_z.cpp
@@ -1437,6 +1437,13 @@ int CRemoteZ_HID::UpdateConfig(const uint32_t len, const uint8_t *wr,
return LC_ERROR;
}
+/*
+ * For some strange reason on OSX, the second ACK read fails, but
+ * the second one is the only one that actually claims to be
+ * from COMMAND_FINISH_UPDATE, so we just don't do that read
+ * or that verify, and move on, and things seem to work.
+ */
+#ifndef __APPLE__
/* And then we should have the response we want. */
if ((err
Re: [concordance-devel] [PATCH] Fix all current warnings
On 02/08/2014 09:52 AM, Scott Talbert wrote: Also, enable -Wall for libconcord so we notice them sooner. Signed-off-by: Scott Talbert s...@techie.net Applied, thanks. -- Phil Dibowitz p...@ipom.com Open Source software and tech docsInsanity Palace of Metallica http://www.phildev.net/ http://www.ipom.com/ Be who you are and say what you feel, because those who mind don't matter and those who matter don't mind. - Dr. Seuss signature.asc Description: OpenPGP digital signature -- Android apps run on BlackBerry 10 Introducing the new BlackBerry 10.2.1 Runtime for Android apps. Now with support for Jelly Bean, Bluetooth, Mapview and more. Get your Android app in front of a whole new audience. Start now. http://pubads.g.doubleclick.net/gampad/clk?id=124407151iu=/4140/ostg.clktrk___ concordance-devel mailing list concordance-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/concordance-devel
Re: [concordance-devel] [PATCH] Windows fixes and cleanup
On 01/27/2014 04:57 PM, Scott Talbert wrote: Remove unneeded code includes. On Windows, when performing config dumps, found that packets were being lost but we were not detecting this. Added code to check the sequence numbers of the incoming packets. Additionally, added a check after the loop to ensure that the read did not time out. We don't need the win32api stuff anymore because we compile with mingw? Doesn't it still run as a windows console app though? And if we don't need that stuff, does that mean we don't need conio.h? Also, any idea on the missing packets? It's exactly what happens on MacOSX too. Since we use hidapi-raw on both mac and windows I'm very suspicious it's something in there, or the way we're using it.. but I haven't had time to recompile my kernel and test the behavior of hidapi-raw on linux -- Phil Dibowitz p...@ipom.com Open Source software and tech docsInsanity Palace of Metallica http://www.phildev.net/ http://www.ipom.com/ Be who you are and say what you feel, because those who mind don't matter and those who matter don't mind. - Dr. Seuss signature.asc Description: OpenPGP digital signature -- WatchGuard Dimension instantly turns raw network data into actionable security intelligence. It gives you real-time visual feedback on key security issues and trends. Skip the complicated setup - simply import a virtual appliance and go from zero to informed in seconds. http://pubads.g.doubleclick.net/gampad/clk?id=123612991iu=/4140/ostg.clktrk___ concordance-devel mailing list concordance-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/concordance-devel
Re: [concordance-devel] [PATCH] Provide status while performing config dumps for MH remotes
On 12/29/2013 07:00 PM, Scott Talbert wrote: On Sat, 28 Dec 2013, Phil Dibowitz wrote: OK, patch for config-updates on 89x sent. 880 still can't config-dump, it fails in random places - I imagine this is likley similar to the problems you're seeing on Windows - any luck with that? It also can't config-update, because it gets a bus-error when rebooting: ... Verifying config: 100% 686 KiB done Rebooting remote: 8% Bus error I haven't have time to debug this one yet, but it's on my list. I figured this out. We were calling hid_exit() inside ShutdownUSB() which you cannot do - once you call that you can't do anything with libhidapi again. I've added a fix and comment to my patch. Gonna see if I can figure out the config dumping issues. Interesting. It's weird that it seems to be OK on the other platforms. I'm curious to see your patch. Are you taking out the hid_exit on all platforms? That's true - I had been thinking mac was the only place we were using libhidapi, but then I realized we're using it on Linux too - perhaps it's specific to hidraw? I also found a bug that had people getting similar errors during enumerate_devs() on Mac but a fix was merged a while ago... -- Phil Dibowitz p...@ipom.com Open Source software and tech docsInsanity Palace of Metallica http://www.phildev.net/ http://www.ipom.com/ Be who you are and say what you feel, because those who mind don't matter and those who matter don't mind. - Dr. Seuss signature.asc Description: OpenPGP digital signature -- Rapidly troubleshoot problems before they affect your business. Most IT organizations don't have a clear picture of how application performance affects their revenue. With AppDynamics, you get 100% visibility into your Java,.NET, PHP application. Start your 15-day FREE TRIAL of AppDynamics Pro! http://pubads.g.doubleclick.net/gampad/clk?id=84349831iu=/4140/ostg.clktrk___ concordance-devel mailing list concordance-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/concordance-devel
Re: [concordance-devel] [PATCH] Provide status while performing config dumps for MH remotes
On 12/29/2013 07:24 PM, Scott Talbert wrote: I have been doing some more debugging on the Windows issue with config dumps. On Windows, what I've found is that we're losing packets from the remote. In the MH config dump code, I wasn't actually checking the sequence numbers coming from the remote, but I added some code to do that, and sure enough, I'm seeing a gap in sequence numbers. So, the packets are getting lost somewhere, which sounds *very* similar to what you're seeing on Mac. I'm still not sure how to fix the problem though. At first, I thought it might be because we were spending too much CPU time in the callback function (writing status to the screen) and missing packets, but that didn't seem to be the problem. Then, I tried increasing the packet buffer size - this required a changed to HIDAPI - but that didn't seem to help either. It is weird, though. For some reason, the remote seems to send packets to us much faster to us on Windows that on Linux. According to the info I've found, it seems that the Windows HID driver continuously requests reports from the interrupt IN endpoint and stores them in a buffer. If the buffer is full, it will drop the oldest packet. I think this is how we're losing packets on Windows but I'm still not sure how to fix it yet. Well - so on Windows and Mac we're using hidapi-raw, and on Linux we're suing hidapi-lubusb. It'd be interesting to see if we have the same problem if we can make hidapi-raw work on Linux. It may be something that libusb is doing that slows things down or works differently. -- Phil Dibowitz p...@ipom.com Open Source software and tech docsInsanity Palace of Metallica http://www.phildev.net/ http://www.ipom.com/ Be who you are and say what you feel, because those who mind don't matter and those who matter don't mind. - Dr. Seuss signature.asc Description: OpenPGP digital signature -- Rapidly troubleshoot problems before they affect your business. Most IT organizations don't have a clear picture of how application performance affects their revenue. With AppDynamics, you get 100% visibility into your Java,.NET, PHP application. Start your 15-day FREE TRIAL of AppDynamics Pro! http://pubads.g.doubleclick.net/gampad/clk?id=84349831iu=/4140/ostg.clktrk___ concordance-devel mailing list concordance-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/concordance-devel
Re: [concordance-devel] [PATCH] Provide status while performing config dumps for MH remotes
On 12/01/2013 11:17 PM, Phil Dibowitz wrote: OK, patch for config-updates on 89x sent. 880 still can't config-dump, it fails in random places - I imagine this is likley similar to the problems you're seeing on Windows - any luck with that? It also can't config-update, because it gets a bus-error when rebooting: ... Verifying config: 100% 686 KiB done Rebooting remote: 8% Bus error I haven't have time to debug this one yet, but it's on my list. I figured this out. We were calling hid_exit() inside ShutdownUSB() which you cannot do - once you call that you can't do anything with libhidapi again. I've added a fix and comment to my patch. Gonna see if I can figure out the config dumping issues. -- Phil Dibowitz p...@ipom.com Open Source software and tech docsInsanity Palace of Metallica http://www.phildev.net/ http://www.ipom.com/ Be who you are and say what you feel, because those who mind don't matter and those who matter don't mind. - Dr. Seuss signature.asc Description: OpenPGP digital signature -- Rapidly troubleshoot problems before they affect your business. Most IT organizations don't have a clear picture of how application performance affects their revenue. With AppDynamics, you get 100% visibility into your Java,.NET, PHP application. Start your 15-day FREE TRIAL of AppDynamics Pro! http://pubads.g.doubleclick.net/gampad/clk?id=84349831iu=/4140/ostg.clktrk___ concordance-devel mailing list concordance-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/concordance-devel
Re: [concordance-devel] [PATCH] Provide status while performing config dumps for MH remotes
OK, on the failed reads, I got further, but I haven't yet fixed it. The first problem is that I was running into USB read timeouts - so I bumped the default from 500ms to 1000ms. Then I started getting Invalid Sequence errors from CRemote::ReadFlash(). We expect the sequence number to increase by 0x11 each time, and it does, until it doesn't. One example, it goes: 89, 9a, ab, bc, ef (we expect cd here) Tried several times and I see: bc, cd, 00 (we expect de) 89, 9a, cd (we expect ab) cd, de, 11 (we expect ef) ab, bc, ef (we expect cd) 89, 9a, cd (we expect ab) cd, de, 11 (we expect ef) There's a pattern here - they are always either one or two sequence numbers ahead... (+ 0x11 or + 0x22) I don't really know what that means though. :( -- Phil Dibowitz p...@ipom.com Open Source software and tech docsInsanity Palace of Metallica http://www.phildev.net/ http://www.ipom.com/ Be who you are and say what you feel, because those who mind don't matter and those who matter don't mind. - Dr. Seuss signature.asc Description: OpenPGP digital signature -- Rapidly troubleshoot problems before they affect your business. Most IT organizations don't have a clear picture of how application performance affects their revenue. With AppDynamics, you get 100% visibility into your Java,.NET, PHP application. Start your 15-day FREE TRIAL of AppDynamics Pro! http://pubads.g.doubleclick.net/gampad/clk?id=84349831iu=/4140/ostg.clktrk___ concordance-devel mailing list concordance-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/concordance-devel
Re: [concordance-devel] [PATCH] Provide status while performing config dumps for MH remotes
On 12/02/2013 06:41 AM, Scott Talbert wrote: No, no luck yet unfortunately. I think the Windows problems are a bit different - the config dump is actually succeeding (ie, the correct file is dumped to the filesystem) but the status stops updating. For example, the display will stop at say 27%. It will eventually print Succeeded and file is dumped, but the percentage never updates. As best I can tell, it appears to be some sort of interaction between the printf's we're doing and the USB stuff, but I need to keep investigating. Ohhh, yeah, that's not the same at all. I haven't have time to debug this one yet, but it's on my list. Does just a regular old 'reset' work on its own? No idea, as I said, I hadn't even started to debug that one yet. The mac I have at home is an old G4, so config updates take a REALLY LONG TIME (usb 1), so the work in general just takes forever. -- Phil Dibowitz p...@ipom.com Open Source software and tech docsInsanity Palace of Metallica http://www.phildev.net/ http://www.ipom.com/ Be who you are and say what you feel, because those who mind don't matter and those who matter don't mind. - Dr. Seuss signature.asc Description: OpenPGP digital signature -- Rapidly troubleshoot problems before they affect your business. Most IT organizations don't have a clear picture of how application performance affects their revenue. With AppDynamics, you get 100% visibility into your Java,.NET, PHP application. Start your 15-day FREE TRIAL of AppDynamics Pro! http://pubads.g.doubleclick.net/gampad/clk?id=84349351iu=/4140/ostg.clktrk___ concordance-devel mailing list concordance-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/concordance-devel
Re: [concordance-devel] [PATCH] Provide status while performing config dumps for MH remotes
On 11/30/2013 07:12 PM, Scott Talbert wrote: Everything worked, except: I'm seeing a weird issue with config dumping on 890 and 200. On the 200, config dumping sometimes works, but other times, it stops short. On the 890, it never quite completes. I think this is related to the status printing on Windows. Someone reported an issue with this previously, but it seemed to only occur when debug was turned on. Now, it seems to be occurring all the time. Hmm. Getting it to compile with libzip took a small patch I'll send later. I'm having a similar problem on OSX, but on my 885, not my 890. It just crashes at some random point: [phil@foobar libconcord]$ sudo concordance -c/tmp/880.dump Concordance 1.0 Copyright 2007 Kevin Timmerman and Phil Dibowitz This software is distributed under the GPLv3. Requesting identity: 100% done Reading config:18% 126 KiBFailed to dump config: Error while reading from the remote Failed with error 3 The 890 config dumps, but fails in the 'finalize' stage of the write: Requesting identity: 100% done Initializing update: 100% done Writing config: 100% 389 KiB done Finalizing update: 66% Failed to upload config: Error while writing to the remote Failed with error 4 And the 1100 isn't found - I expect we need to figure out the whole dhcp bla bla stuff. I haven't had a chance to debug any of those or test writes on the 885, I'll do that later. -- Phil Dibowitz p...@ipom.com Open Source software and tech docsInsanity Palace of Metallica http://www.phildev.net/ http://www.ipom.com/ Be who you are and say what you feel, because those who mind don't matter and those who matter don't mind. - Dr. Seuss signature.asc Description: OpenPGP digital signature -- Rapidly troubleshoot problems before they affect your business. Most IT organizations don't have a clear picture of how application performance affects their revenue. With AppDynamics, you get 100% visibility into your Java,.NET, PHP application. Start your 15-day FREE TRIAL of AppDynamics Pro! http://pubads.g.doubleclick.net/gampad/clk?id=84349351iu=/4140/ostg.clktrk___ concordance-devel mailing list concordance-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/concordance-devel
[concordance-devel] [PATCH] Various OSX fixes
This fixes building on OSX as well as config-updates for 89x on OSX.
--
Phil Dibowitz p...@ipom.com
Open Source software and tech docsInsanity Palace of Metallica
http://www.phildev.net/ http://www.ipom.com/
Be who you are and say what you feel, because those who mind don't matter
and those who matter don't mind.
- Dr. Seuss
commit 87ea1e5dc93f1ef90029c3837fd954263457a11f
Author: Phil Dibowitz p...@ipom.com
Date: Sun Dec 1 23:10:48 2013 -0800
Various MacOSX fixes
libconcord/configure.ac
libconcord/Makefile.am
libconcord/INSTALL
* Start using pkg-config to find zlib - on OSX, some header files
are in strange places
libconcord/remote_z.cpp
* For some reason the double-ack-read doesn't work in one instance
on OSX. This is remote behavior, not host behavior, so I don't
see how this is possible, but this is the only way I can make
config updates on 890s work on OSX.
Signed-off-by: Phil Dibowitz p...@ipom.com
diff --git a/libconcord/INSTALL.mac b/libconcord/INSTALL.mac
index 10d215a..d94e159 100644
--- a/libconcord/INSTALL.mac
+++ b/libconcord/INSTALL.mac
@@ -47,7 +47,13 @@ Finally, you will need to install libzip, which again is straight forward:
1. BUILD THE LIBRARY
As a normal user...
- A. ***IF You are building from CVS, run autoreconf --install
+ A. IF You are building from git, run autoreconf --install
+Note that if you're doing this on OSX, depending on your setup,
+you may instead have to run:
+ aclocal -I /opt/pkgconfig/share/aclocal
+ autoheader
+ automake
+ autoconf
B. Run ./configure
C. Run make
diff --git a/libconcord/Makefile.am b/libconcord/Makefile.am
index de6ae23..eda90d9 100644
--- a/libconcord/Makefile.am
+++ b/libconcord/Makefile.am
@@ -7,6 +7,7 @@ libconcord_la_SOURCES = remote.cpp remote_z.cpp libconcord.cpp binaryfile.cpp \
operationfile.cpp remote_mh.cpp libusbhid.cpp libhidapi.cpp
include_HEADERS = libconcord.h
libconcord_la_LDFLAGS = -version-info 3:0:0 $(LIBCONCORD_LDFLAGS) -lzip
+libconcord_la_CXXFLAGS = $(ZIP_CFLAGS)
UDEVROOT ?= /
UDEVLIBDIR ?= $(UDEVROOT)/lib
diff --git a/libconcord/configure.ac b/libconcord/configure.ac
index 48a453f..cc5898b 100644
--- a/libconcord/configure.ac
+++ b/libconcord/configure.ac
@@ -74,12 +74,7 @@ then
fi
AC_MSG_ERROR([$errorstr])
fi
-AC_CHECK_HEADER(zip.h, [], [a=0])
-AC_CHECK_LIB(zip, zip_open, [], [a=0])
-if test $a == 0
-then
-AC_MSG_ERROR([Error, libzip is missing!])
-fi
+PKG_CHECK_MODULES([ZIP], [libzip])
AC_CONFIG_FILES([
Makefile
])
diff --git a/libconcord/remote_z.cpp b/libconcord/remote_z.cpp
index 2c4ddc2..4e1fa45 100644
--- a/libconcord/remote_z.cpp
+++ b/libconcord/remote_z.cpp
@@ -1437,6 +1437,13 @@ int CRemoteZ_HID::UpdateConfig(const uint32_t len, const uint8_t *wr,
return LC_ERROR;
}
+/*
+ * For some strange reason on OSX, the second ACK read fails, but
+ * the second one is the only one that actually claims to be
+ * from COMMAND_FINISH_UPDATE, so we just don't do that read
+ * or that verify, and move on, and things seem to work.
+ */
+#ifndef __APPLE__
/* And then we should have the response we want. */
if ((err = TCP_Read(status, rlen, rsp))) {
debug(Failed to read from remote);
@@ -1449,6 +1456,7 @@ int CRemoteZ_HID::UpdateConfig(const uint32_t len, const uint8_t *wr,
debug(Failed to read finish-update ack);
return LC_ERROR;
}
+#endif
cb(LC_CB_STAGE_FINALIZE_UPDATE, cb_count++, 5, 6, LC_CB_COUNTER_TYPE_STEPS,
cb_arg, NULL);
signature.asc
Description: OpenPGP digital signature
--
Rapidly troubleshoot problems before they affect your business. Most IT
organizations don't have a clear picture of how application performance
affects their revenue. With AppDynamics, you get 100% visibility into your
Java,.NET, PHP application. Start your 15-day FREE TRIAL of AppDynamics Pro!
http://pubads.g.doubleclick.net/gampad/clk?id=84349351iu=/4140/ostg.clktrk___
concordance-devel mailing list
concordance-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/concordance-devel
Re: [concordance-devel] [PATCH] Provide status while performing config dumps for MH remotes
OK, patch for config-updates on 89x sent. 880 still can't config-dump, it fails in random places - I imagine this is likley similar to the problems you're seeing on Windows - any luck with that? It also can't config-update, because it gets a bus-error when rebooting: ... Verifying config: 100% 686 KiB done Rebooting remote: 8% Bus error I haven't have time to debug this one yet, but it's on my list. -- Phil Dibowitz p...@ipom.com Open Source software and tech docsInsanity Palace of Metallica http://www.phildev.net/ http://www.ipom.com/ Be who you are and say what you feel, because those who mind don't matter and those who matter don't mind. - Dr. Seuss signature.asc Description: OpenPGP digital signature -- Rapidly troubleshoot problems before they affect your business. Most IT organizations don't have a clear picture of how application performance affects their revenue. With AppDynamics, you get 100% visibility into your Java,.NET, PHP application. Start your 15-day FREE TRIAL of AppDynamics Pro! http://pubads.g.doubleclick.net/gampad/clk?id=84349351iu=/4140/ostg.clktrk___ concordance-devel mailing list concordance-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/concordance-devel
Re: [concordance-devel] [PATCH] Provide status while performing config dumps for MH remotes
On 11/29/2013 05:37 PM, Scott Talbert wrote: Pass in the callback parameters to ReadFile() and add calls to the callbacks as is done for the other remote types. Otherwise, the user doesn't know what is doing on while a config dump is in progress. Applied, thanks. Anything else we're waiting on for a release? -- Phil Dibowitz p...@ipom.com Open Source software and tech docsInsanity Palace of Metallica http://www.phildev.net/ http://www.ipom.com/ Be who you are and say what you feel, because those who mind don't matter and those who matter don't mind. - Dr. Seuss signature.asc Description: OpenPGP digital signature -- Rapidly troubleshoot problems before they affect your business. Most IT organizations don't have a clear picture of how application performance affects their revenue. With AppDynamics, you get 100% visibility into your Java,.NET, PHP application. Start your 15-day FREE TRIAL of AppDynamics Pro! http://pubads.g.doubleclick.net/gampad/clk?id=84349351iu=/4140/ostg.clktrk___ concordance-devel mailing list concordance-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/concordance-devel
Re: [concordance-devel] [PATCH] Provide status while performing config dumps for MH remotes
On 11/30/2013 08:40 AM, Scott Talbert wrote: On Sat, 30 Nov 2013, Phil Dibowitz wrote: Pass in the callback parameters to ReadFile() and add calls to the callbacks as is done for the other remote types. Otherwise, the user doesn't know what is doing on while a config dump is in progress. Applied, thanks. Anything else we're waiting on for a release? I was going to test my remotes on Windows, too. I'll do that today. Did you test on Mac? Good call. I'll try to do that this weekend. I'll also go through git diffs and come up with an update to the Changelog. -- Phil Dibowitz p...@ipom.com Open Source software and tech docsInsanity Palace of Metallica http://www.phildev.net/ http://www.ipom.com/ Be who you are and say what you feel, because those who mind don't matter and those who matter don't mind. - Dr. Seuss signature.asc Description: OpenPGP digital signature -- Rapidly troubleshoot problems before they affect your business. Most IT organizations don't have a clear picture of how application performance affects their revenue. With AppDynamics, you get 100% visibility into your Java,.NET, PHP application. Start your 15-day FREE TRIAL of AppDynamics Pro! http://pubads.g.doubleclick.net/gampad/clk?id=84349351iu=/4140/ostg.clktrk___ concordance-devel mailing list concordance-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/concordance-devel
Re: [concordance-devel] [PATCH] Disable config verifiction on HID remotes
On 11/28/2013 07:38 PM, Scott Talbert wrote: On Thu, 28 Nov 2013, Phil Dibowitz wrote: Anyone object to this patch? We've never done anything useful with this, might as well stop wasiting users' time. Uh, it looks like we actually do verify the config. See ReadFlash() in remote.cpp when you pass in a 'true' for the verify parameter. Oh - you're right. We didn't used to do this, I don't remember this getting in there. Neat. I'll drop that patch, thanks. -- Phil Dibowitz p...@ipom.com Open Source software and tech docsInsanity Palace of Metallica http://www.phildev.net/ http://www.ipom.com/ Be who you are and say what you feel, because those who mind don't matter and those who matter don't mind. - Dr. Seuss signature.asc Description: OpenPGP digital signature -- Rapidly troubleshoot problems before they affect your business. Most IT organizations don't have a clear picture of how application performance affects their revenue. With AppDynamics, you get 100% visibility into your Java,.NET, PHP application. Start your 15-day FREE TRIAL of AppDynamics Pro! http://pubads.g.doubleclick.net/gampad/clk?id=84349351iu=/4140/ostg.clktrk___ concordance-devel mailing list concordance-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/concordance-devel
[concordance-devel] [PATCH] Disable config verifiction on HID remotes
Anyone object to this patch? We've never done anything useful with this, might
as well stop wasiting users' time.
--
Phil Dibowitz p...@ipom.com
Open Source software and tech docsInsanity Palace of Metallica
http://www.phildev.net/ http://www.ipom.com/
Be who you are and say what you feel, because those who mind don't matter
and those who matter don't mind.
- Dr. Seuss
commit 866e4095b2876e0ec0f8561e641cbbcfe5fc
Author: Phil Dibowitz p...@ipom.com
Date: Thu Nov 28 15:07:37 2013 -0800
Disable config verifiction on HID remotes
Since the beginning we've re-read the config under the guise that
one day we'd actually compare what we were reading back to the actual
file - but we don't do this and it takes a long time to read that data
back. So I'm commenting this out and if anyone ever wants to implement
proper verification we can put it back.
Signed-off-by: Phil Dibowitz p...@ipom.com
diff --git a/libconcord/libconcord.cpp b/libconcord/libconcord.cpp
index ee66b23..6e00ff9 100644
--- a/libconcord/libconcord.cpp
+++ b/libconcord/libconcord.cpp
@@ -616,9 +616,10 @@ static const uint32_t update_configuration_hid_stages[]={
LC_CB_STAGE_INVALIDATE_FLASH,
LC_CB_STAGE_ERASE_FLASH,
LC_CB_STAGE_WRITE_CONFIG,
-LC_CB_STAGE_VERIFY_CONFIG,
+// See comment in _update_configuration_hid()
+//LC_CB_STAGE_VERIFY_CONFIG,
};
-static const int update_configuration_hid_num_stages = 5;
+static const int update_configuration_hid_num_stages = 4;
static const uint32_t update_configuration_zwave_mh_stages[]={
LC_CB_STAGE_INITIALIZE_UPDATE,
@@ -1295,9 +1296,14 @@ int _update_configuration_hid(lc_callback cb, void *cb_arg) {
return err;
}
+// This has never actually done anything, so lets stop
+// wasting users time re-reading the config until we are
+// ready to actually do verification.
+/*
if ((err = verify_remote_config(cb, cb_arg))) {
return err;
}
+*/
if ((err = finish_config(cb, cb_arg))) {
return err;
signature.asc
Description: OpenPGP digital signature
--
Rapidly troubleshoot problems before they affect your business. Most IT
organizations don't have a clear picture of how application performance
affects their revenue. With AppDynamics, you get 100% visibility into your
Java,.NET, PHP application. Start your 15-day FREE TRIAL of AppDynamics Pro!
http://pubads.g.doubleclick.net/gampad/clk?id=84349351iu=/4140/ostg.clktrk___
concordance-devel mailing list
concordance-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/concordance-devel
