[jira] Commented: (MYFACES-1146) Impossible to hide footer in dataTable
[ http://issues.apache.org/jira/browse/MYFACES-1146?page=comments#action_12367158 ] Guy Bashan commented on MYFACES-1146: - This is exactly what I did (well . . . in one of my tryings . . . .). MyFaces still creates an empty row (footer row). This row has no values, so it is not shown in explorer, but fire fox treats empty rows differently and still shows the empty row. Impossible to hide footer in dataTable -- Key: MYFACES-1146 URL: http://issues.apache.org/jira/browse/MYFACES-1146 Project: MyFaces Core Type: Bug Components: Tomahawk Versions: 1.1.1 Reporter: Guy Bashan Priority: Trivial It is impossible to hide the footer in a dataTable. There are cases in which the same table should sometimes show the footer and in other cases do not show it. For example: t:dataTable id=results value=#{analyze.rows} var=row width=100% cellpadding=0 cellspacing=0 border=0 styleClass=reportTable headerClass=reportTitle footerClass=reportTableTotal rowClasses=reportRowLight,reportRowDark rowOnMouseOver=selectedRow = this.className; this.className='reportRowOver' rowOnMouseOut=this.className = selectedRow t:columns value=#{analyze.columnHeaders} var=column styleClass=#{analyze.styleClass} style=text-align:#{column.alignment} f:facet name=header t:htmlTag value=nobrh:outputText value=#{column.title} escape=false//t:htmlTag /f:facet h:outputText value=#{analyze.columnValue} escape=false / f:facet name=footer h:outputText value=#{analyze.colFooter.title} escape=false/ t:htmlTag value=b h:outputText value=#{analyze.colFooter.total}/ /t:htmlTag /f:facet /t:columns /t:dataTable I tried hiding the footer with: f:subview wrapping the footer and as a footer child, but both seems to be not working. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MYFACES-1146) Impossible to hide footer in dataTable
[ http://issues.apache.org/jira/browse/MYFACES-1146?page=comments#action_12367159 ] Mario Ivankovits commented on MYFACES-1146: --- You could also try to do: footerClass=#{analyze.footerClass} where you return the footer class or a class which will display:hide it. But ok, this is only a workaround. The question is still valid, should we add a renderFooter=true|false renderHeader=true|false attribute? Impossible to hide footer in dataTable -- Key: MYFACES-1146 URL: http://issues.apache.org/jira/browse/MYFACES-1146 Project: MyFaces Core Type: Bug Components: Tomahawk Versions: 1.1.1 Reporter: Guy Bashan Priority: Trivial It is impossible to hide the footer in a dataTable. There are cases in which the same table should sometimes show the footer and in other cases do not show it. For example: t:dataTable id=results value=#{analyze.rows} var=row width=100% cellpadding=0 cellspacing=0 border=0 styleClass=reportTable headerClass=reportTitle footerClass=reportTableTotal rowClasses=reportRowLight,reportRowDark rowOnMouseOver=selectedRow = this.className; this.className='reportRowOver' rowOnMouseOut=this.className = selectedRow t:columns value=#{analyze.columnHeaders} var=column styleClass=#{analyze.styleClass} style=text-align:#{column.alignment} f:facet name=header t:htmlTag value=nobrh:outputText value=#{column.title} escape=false//t:htmlTag /f:facet h:outputText value=#{analyze.columnValue} escape=false / f:facet name=footer h:outputText value=#{analyze.colFooter.title} escape=false/ t:htmlTag value=b h:outputText value=#{analyze.colFooter.total}/ /t:htmlTag /f:facet /t:columns /t:dataTable I tried hiding the footer with: f:subview wrapping the footer and as a footer child, but both seems to be not working. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MYFACES-1146) Impossible to hide footer in dataTable
[ http://issues.apache.org/jira/browse/MYFACES-1146?page=comments#action_12367160 ] Guy Bashan commented on MYFACES-1146: - I have alreay done this workaround, but it seems to me not a neat solution. I can leave with this solution, but I think that in the long term it is preferable solving this problem with a property as you suggested. Impossible to hide footer in dataTable -- Key: MYFACES-1146 URL: http://issues.apache.org/jira/browse/MYFACES-1146 Project: MyFaces Core Type: Bug Components: Tomahawk Versions: 1.1.1 Reporter: Guy Bashan Priority: Trivial It is impossible to hide the footer in a dataTable. There are cases in which the same table should sometimes show the footer and in other cases do not show it. For example: t:dataTable id=results value=#{analyze.rows} var=row width=100% cellpadding=0 cellspacing=0 border=0 styleClass=reportTable headerClass=reportTitle footerClass=reportTableTotal rowClasses=reportRowLight,reportRowDark rowOnMouseOver=selectedRow = this.className; this.className='reportRowOver' rowOnMouseOut=this.className = selectedRow t:columns value=#{analyze.columnHeaders} var=column styleClass=#{analyze.styleClass} style=text-align:#{column.alignment} f:facet name=header t:htmlTag value=nobrh:outputText value=#{column.title} escape=false//t:htmlTag /f:facet h:outputText value=#{analyze.columnValue} escape=false / f:facet name=footer h:outputText value=#{analyze.colFooter.title} escape=false/ t:htmlTag value=b h:outputText value=#{analyze.colFooter.total}/ /t:htmlTag /f:facet /t:columns /t:dataTable I tried hiding the footer with: f:subview wrapping the footer and as a footer child, but both seems to be not working. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MYFACES-1146) Impossible to hide footer in dataTable
[ http://issues.apache.org/jira/browse/MYFACES-1146?page=comments#action_12367162 ] Guy Bashan commented on MYFACES-1146: - leave -- live ;-) Impossible to hide footer in dataTable -- Key: MYFACES-1146 URL: http://issues.apache.org/jira/browse/MYFACES-1146 Project: MyFaces Core Type: Bug Components: Tomahawk Versions: 1.1.1 Reporter: Guy Bashan Priority: Trivial It is impossible to hide the footer in a dataTable. There are cases in which the same table should sometimes show the footer and in other cases do not show it. For example: t:dataTable id=results value=#{analyze.rows} var=row width=100% cellpadding=0 cellspacing=0 border=0 styleClass=reportTable headerClass=reportTitle footerClass=reportTableTotal rowClasses=reportRowLight,reportRowDark rowOnMouseOver=selectedRow = this.className; this.className='reportRowOver' rowOnMouseOut=this.className = selectedRow t:columns value=#{analyze.columnHeaders} var=column styleClass=#{analyze.styleClass} style=text-align:#{column.alignment} f:facet name=header t:htmlTag value=nobrh:outputText value=#{column.title} escape=false//t:htmlTag /f:facet h:outputText value=#{analyze.columnValue} escape=false / f:facet name=footer h:outputText value=#{analyze.colFooter.title} escape=false/ t:htmlTag value=b h:outputText value=#{analyze.colFooter.total}/ /t:htmlTag /f:facet /t:columns /t:dataTable I tried hiding the footer with: f:subview wrapping the footer and as a footer child, but both seems to be not working. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
Re: svn commit: r378805 - /myfaces/core/trunk/impl/src/main/java/org/apache/myfaces/application/ApplicationFactoryImpl.java
On Mon, 2006-02-20 at 21:47 -0800, Craig McClanahan wrote: No, I was not aware of that change ... but does it actually work? Declaring something Serializable is not by itself sufficient if there are transient variables inside the implementation. (On a separate thread on commons-dev, I recommended that there be unit tests to validate this behavior: use a Log instance, serialize it, deserialize it, and use it some more). I believe Serializable is correctly implemented for all standard adapters except possibly AvalonLog [will follow that up on commons-dev]. The deserialized objects correctly locate a fresh underlying log object to forward calls to. Yes there need to be unit tests for this; I'll look for them and add some if not already present. The 1.0.4 release occurred around June 2004 so perhaps there are a few containers out there capable of running MyFaces but which are still on JCL 1.0.3. In addition there might be a few custom Log adapters around which *might* not implement Serializable. However in view of the complicated/ugly workaround for non-serializable Log implementations, it seems ok to me for MyFaces to just declare a dependency on JCL 1.0.4. If people don't comply then there is a very obvious NotSerializableException: logAdapterClassName message generated. The fix is then to upgrade to 1.0.4 (which is binary compatible with earlier releases) or a later release. Comments/Opinions? +1 on declaring a dependency on Commons Logging 1.0.4 ... anything prior to that is just asking for trouble. I use 1.0.4 exclusively for eveything that has a C-L dependency ... works fine, lasts a long time :-). So the conclusion seems to be that if/when using commons-logging in MyFaces, use: private Log foo = LogFactory.getLog(foo); everywhere except in short-lived and frequently-created objects. In those cases, either call LogFactory.getLog as needed or have some longer-lived object store the Log object. For StateHolder classes, things just work; the logger isn't saved in saveState; it gets recreated in the new component and that works. For Serializable classes, the Log object handles its own serialization correctly. No need for transient, no need for any other special hacks. MyFaces does need to declare a dependency on commons-logging 1.0.4 (not earlier versions) in order for things to work this simply. Release 1.0.4 was in June 2004. Do NOT use static Log anywhere. Is this all ok? Cheers, Simon
[jira] Reopened: (MYFACES-1146) Impossible to hide footer in dataTable
[ http://issues.apache.org/jira/browse/MYFACES-1146?page=all ] Mario Ivankovits reopened MYFACES-1146: --- Add the attributes renderHeader and renderFooter Impossible to hide footer in dataTable -- Key: MYFACES-1146 URL: http://issues.apache.org/jira/browse/MYFACES-1146 Project: MyFaces Core Type: Bug Components: Tomahawk Versions: 1.1.1 Reporter: Guy Bashan Priority: Trivial It is impossible to hide the footer in a dataTable. There are cases in which the same table should sometimes show the footer and in other cases do not show it. For example: t:dataTable id=results value=#{analyze.rows} var=row width=100% cellpadding=0 cellspacing=0 border=0 styleClass=reportTable headerClass=reportTitle footerClass=reportTableTotal rowClasses=reportRowLight,reportRowDark rowOnMouseOver=selectedRow = this.className; this.className='reportRowOver' rowOnMouseOut=this.className = selectedRow t:columns value=#{analyze.columnHeaders} var=column styleClass=#{analyze.styleClass} style=text-align:#{column.alignment} f:facet name=header t:htmlTag value=nobrh:outputText value=#{column.title} escape=false//t:htmlTag /f:facet h:outputText value=#{analyze.columnValue} escape=false / f:facet name=footer h:outputText value=#{analyze.colFooter.title} escape=false/ t:htmlTag value=b h:outputText value=#{analyze.colFooter.total}/ /t:htmlTag /f:facet /t:columns /t:dataTable I tried hiding the footer with: f:subview wrapping the footer and as a footer child, but both seems to be not working. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MYFACES-1146) Impossible to hide footer in dataTable
[ http://issues.apache.org/jira/browse/MYFACES-1146?page=comments#action_12367167 ] Volker Weber commented on MYFACES-1146: --- I prefer to check the rendered attribute of footer/header component over adding extra attributes to datatable. Impossible to hide footer in dataTable -- Key: MYFACES-1146 URL: http://issues.apache.org/jira/browse/MYFACES-1146 Project: MyFaces Core Type: Bug Components: Tomahawk Versions: 1.1.1 Reporter: Guy Bashan Assignee: Mario Ivankovits Priority: Trivial It is impossible to hide the footer in a dataTable. There are cases in which the same table should sometimes show the footer and in other cases do not show it. For example: t:dataTable id=results value=#{analyze.rows} var=row width=100% cellpadding=0 cellspacing=0 border=0 styleClass=reportTable headerClass=reportTitle footerClass=reportTableTotal rowClasses=reportRowLight,reportRowDark rowOnMouseOver=selectedRow = this.className; this.className='reportRowOver' rowOnMouseOut=this.className = selectedRow t:columns value=#{analyze.columnHeaders} var=column styleClass=#{analyze.styleClass} style=text-align:#{column.alignment} f:facet name=header t:htmlTag value=nobrh:outputText value=#{column.title} escape=false//t:htmlTag /f:facet h:outputText value=#{analyze.columnValue} escape=false / f:facet name=footer h:outputText value=#{analyze.colFooter.title} escape=false/ t:htmlTag value=b h:outputText value=#{analyze.colFooter.total}/ /t:htmlTag /f:facet /t:columns /t:dataTable I tried hiding the footer with: f:subview wrapping the footer and as a footer child, but both seems to be not working. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
Re: Maven2 build failure with current trunk?
Dennis Byrne schrieb: Most of the encryption tests have really strong cipher configurations. These levels of encryption have to be enabled for a standard JDK. There is a brief explanation in the javadocs of the tests themselves, although this does not explain why they worked for you in the past. Either enabled, or simply a different crypto provider has to be used. I settled in the past for the second option (bouncycastle) sorry, just wanted to give my 2c here, because the whole issue has been a huge annoyance once for me in the past.
RE: New MyFaces Committer: Craig McClanahan
Welcome Craig! Stan Silvert JBoss, Inc. [EMAIL PROTECTED] callto://stansilvert -Original Message- From: Sean Schofield [mailto:[EMAIL PROTECTED] Sent: Monday, February 20, 2006 3:30 PM To: MyFaces Development Subject: New MyFaces Committer: Craig McClanahan Please welcome Craig McClanahan as our newest MyFaces committer. Most of you are probably familiar with Craig's work as the original author of Struts. Craig was also heavily involved in the original JSF specification. No matter where you live, chances are he will be coming to a conference in your city/country soon to promote JSF! Craig is also the lead architect on Sun's Java Studio Creator 2 and is leading the effort on Struts Shale which leverages JSF. He has been a valuable contributor on our mailing list for well over a year now and as an ASF member, has agreed to be the mentor for the ADF incubator project. He has also stated an interest in making the Tomahawk components compatible with Studio Creator. Welcome aboard Craig. We're glad to officially have you on the team now. Sean
Re: [jira] Commented: (MYFACES-1146) Impossible to hide footer in dataTable
Hi Volker! [ http://issues.apache.org/jira/browse/MYFACES-1146?page=comments#action_12367167 ] Volker Weber commented on MYFACES-1146: --- I prefer to check the rendered attribute of footer/header component over adding extra attributes to datatable. This might be complicated, if not impossible to do. I have to check all children of all footer facets to see if the row should be renderer or not. Think of the following (for sure untypical, just to get the point): f:facet name=footer h:panelGroup h:outputLabel for=input h:outputText value=abc rendered=false/ /h:outputLabel h:inputText id=input rendered=false/ /h:panelGroup /f:facet We can say we take the rendered state of the first/root child of the facet tag, but this is not very intuitive, is it? Ciao, Mario
Re: New MyFaces Committer: Craig McClanahan
Hi Craig! Welcome to the pleasuredome! ;-) Ciao, Mario Please welcome Craig McClanahan as our newest MyFaces committer. Most of you are probably familiar with Craig's work as the original author of Struts. Craig was also heavily involved in the original JSF specification. No matter where you live, chances are he will be coming to a conference in your city/country soon to promote JSF! Craig is also the lead architect on Sun's Java Studio Creator 2 and is leading the effort on Struts Shale which leverages JSF. He has been a valuable contributor on our mailing list for well over a year now and as an ASF member, has agreed to be the mentor for the ADF incubator project. He has also stated an interest in making the Tomahawk components compatible with Studio Creator. Welcome aboard Craig. We're glad to officially have you on the team now. Sean -- mfg Mario Ivankovits - OPS EDV Vertriebsges.m.b.H. Software Engineering Michael-Bernhard-Gasse 10, A-1120 Wien Tel.: +43-1-8938810 Fax: +43-1-8938810/3700 E-Mail: [EMAIL PROTECTED] Skype: mario_ivankovits
Re: [PROPOSAL] ADF-Faces as a new Podling
On 2/21/06, Martin Marinschek [EMAIL PROTECTED] wrote: Hmmm ok - I just have seen many proposals coming in via general. Never mind! Have you got any feedback on the proposal so far? Njet. -Manfred regards, Martin On 2/20/06, Manfred Geiler [EMAIL PROTECTED] wrote: Martin, http://incubator.apache.org/incubation/Incubation_Policy.html#Acceptance+of+Proposal+by+Sponsor http://incubator.apache.org/incubation/Process_Description.html ;-) Regards, Manfred On 2/19/06, Martin Marinschek [EMAIL PROTECTED] wrote: Manfred, I think you have to send this to [EMAIL PROTECTED] regards, Martin On 2/19/06, Manfred Geiler [EMAIL PROTECTED] wrote: Dear Incubator PMC, We, the sponsoring members listed below, ask that you accept the following proposal for a new project at Apache, an effort centered on providing web application developers with a rich set of user interface components based on the JavaServer Faces specification. * You can find the proposal here: http://wiki.apache.org/myfaces/adfproposal A snapshot of the proposal is attached to this mail for your convenience. * Here is a reference to the candidate acceptance vote by the MyFaces PMC: http://mail-archives.apache.org/mod_mbox/myfaces-dev/200602.mbox/[EMAIL PROTECTED] * Mentor, nominated by the Sponsor: Craig McClanahan Regards, Manfred Geiler (MyFaces PMC Chair) Proposal for ADF Faces, a MyFaces subproject 6 February 2006, The ADF Faces Team (contributions by: Adam Winer, awiner at gmail dot com; john dot r dot fallows at gmail dot com) (0) rationale Apache MyFaces strives to provide an environment where open source developers can create new components and contribute them back to the community. The goal of ADF Faces is to provide web application developers with a rich set of user interface components based on the JavaServer Faces specification. ADF Faces comes with very high quality components, a dialog framework, as well as personalization and skinning capabilities. ADF Faces features include: file upload support, client-side validation, partial rendering of a page (AJAX-style), data tables, hierarchical tables, color/date pickers, progress indicators, menu tabs/buttons, wizards, internationalization and accessibility. A complete list of the ADF Faces components is available (here.) This project starts with more than 100 components which have already been documented and thoroughly tested. ADF Faces is a temporary name for this project, what it will be called in the future is yet to be determined by the Apache MyFaces community. ADF Faces development started in 2001. Initial development took place outside the Apache Software Foundation, therefore the ADF Faces team and MyFaces are applying for incubation. (0.1) criteria Meritocracy: The ADF Faces project will be consensus-based using the mailing lists and completely transparent. Developers will employ Apache conventions, such as +1, when coming to decisions and if necessary voting will establish the final 'will' of the community. Community: The MyFaces project and the ?JavaServer Faces standard hold great promise. A rich set of UI components will significantly accelerate their adoption. We strongly believe that ADF Faces will gather significant momentum and enough developers to build a vibrant community of users and contributors. We look forward to seeing more components blossom as part of the Apache MyFaces project. Core Developers: ADF Faces was developed by five Oracle employees including Adam Winer (active member of the ?JavaServer Faces expert group since day one) and John Fallows co-author of Pro JSF and Ajax. Developers have filed the Contribution License Agreement. Oracle has also filed the Corporate Contribution License Agreement. Three PMC members from the MyFaces project are currently planning to become active ADF Faces developers, others will hopefully follow: * Matthias Wessendorf * Martin Marinschek * Bruno Aranda Alignment: ADF Faces aligns perfectly with MyFaces and other ASF projects utilizing J2EE infrastructure such as Tomcat. Of particular relevance are projects such as Geronimo, Apache libraries like Jakarta Taglibs and Apache Maven. (0.2) warning signs Orphaned products: Most of the active developers would like to become ADF Faces Committers or PMC Members and plan to remain active in the project. Inexperience with open source: Most ADF Faces developers have been consuming open source projects extensively and
[jira] Commented: (MYFACES-1148) Weblogic Classloader problems during development (FactoryFinder)
[ http://issues.apache.org/jira/browse/MYFACES-1148?page=comments#action_12367170 ] Alexander Jesse commented on MYFACES-1148: -- Seems as if the hibernate-link points to another problem. The other MF-jira issue also seems to point in a different direction. Having to deal with WLS on a daily base... I think the description by Adam is quite accurate (WLS dropping the classloader for a class-redeploy). That the factories disappear in that moment seems also quite logic. I just wonder how Tomcat is handling this class-redeploy issue and whether it works when using the RI... Weblogic Classloader problems during development (FactoryFinder) Key: MYFACES-1148 URL: http://issues.apache.org/jira/browse/MYFACES-1148 Project: MyFaces Core Type: Bug Components: Implementation Versions: 1.1.1 Environment: Weblogic 9.0, 8.1, etc. Windows XP Pro sp2. Reporter: Adam Brod Like most weblogic users, our team develops using the exploded war format. That means that each time we deploy a new version of a class, weblogic automatically picks it up. The way Weblogic implements this is that when it detects a new class, it drops the classloader for that class, as well as the Servlet and all helper classes that are loaded by the Servlet. That means FacesServlet is dropped and reloaded. The problem is that FactoryFinder stores the Factory classes in a Map where the key is the current classloader. That works fine until I deploy a new class to my webapp. At that point, weblogic drops the classloader and creates a new one with the new class definition. Now when FacesServlet.init() calls FactoryFinder.getFactory() (in the new classloader), an IllegalStateException is generated (see below) because the current classloader is not a valid key for the _registeredFactoryNames Map. One possible solution that I can see to this is to change the key for the Factory map to use the ServletContext's getServletContextName() as the key. I am 95% sure this same problem exists in Weblogic 7.0, 8.1 and 9.1 since they all use almost the same Servlet redeployment mechanism. I have only tried this on Weblogic 9.0. Feb 20, 2006 5:38:07 PM EST Error HTTP BEA-101017 [EMAIL PROTECTED] - name: 'ma-web-1.0-SNAPSHOT ', context-path: '/ma'] Root cause of ServletException. java.lang.IllegalStateException: No Factories configured for this Application - typically this is because a context listener is not setup in yo ur web.xml. A typical config looks like this; listener listener-classorg.apache.myfaces.webapp.StartupServletContextListener/listener-class /listener at javax.faces.FactoryFinder.getFactory(FactoryFinder.java:84) at javax.faces.webapp.FacesServlet.init(FacesServlet.java:84) at weblogic.servlet.internal.StubSecurityHelper$ServletInitAction.run(StubSecurityHelper.java:265) at weblogic.security.acl.internal.AuthenticatedSubject.doAs(AuthenticatedSubject.java:321) at weblogic.security.service.SecurityManager.runAs(SecurityManager.java:121) at weblogic.servlet.internal.StubSecurityHelper.createServlet(StubSecurityHelper.java:61) at weblogic.servlet.internal.StubLifecycleHelper.createOneInstance(StubLifecycleHelper.java:58) at weblogic.servlet.internal.StubLifecycleHelper.init(StubLifecycleHelper.java:48) at weblogic.servlet.internal.ServletStubImpl.prepareServlet(ServletStubImpl.java:502) at weblogic.servlet.internal.ServletStubImpl.checkForReload(ServletStubImpl.java:429) at weblogic.servlet.internal.ServletStubImpl.execute(ServletStubImpl.java:221) at weblogic.servlet.internal.TailFilter.doFilter(TailFilter.java:26) at weblogic.servlet.internal.FilterChainImpl.doFilter(FilterChainImpl.java:42) at oracle.adfinternal.view.faces.webapp.AdfFacesFilterImpl._invokeDoFilter(AdfFacesFilterImpl.java:367) at oracle.adfinternal.view.faces.webapp.AdfFacesFilterImpl._doFilterImpl(AdfFacesFilterImpl.java:336) at oracle.adfinternal.view.faces.webapp.AdfFacesFilterImpl.doFilter(AdfFacesFilterImpl.java:196) at oracle.adf.view.faces.webapp.AdfFacesFilter.doFilter(AdfFacesFilter.java:87) at weblogic.servlet.internal.FilterChainImpl.doFilter(FilterChainImpl.java:42) at org.apache.myfaces.component.html.util.ExtensionsFilter.doFilter(ExtensionsFilter.java:122) at weblogic.servlet.internal.FilterChainImpl.doFilter(FilterChainImpl.java:42) at weblogic.servlet.internal.WebAppServletContext$ServletInvocationAction.run(WebAppServletContext.java:3020) at weblogic.security.acl.internal.AuthenticatedSubject.doAs(AuthenticatedSubject.java:321) at
Re: New MyFaces Committer: Craig McClanahan
Craig, good to have you aboard! On 2/21/06, Mario Ivankovits [EMAIL PROTECTED] wrote: Hi Craig! Welcome to the pleasuredome! ;-) Ciao, Mario Please welcome Craig McClanahan as our newest MyFaces committer. Most of you are probably familiar with Craig's work as the original author of Struts. Craig was also heavily involved in the original JSF specification. No matter where you live, chances are he will be coming to a conference in your city/country soon to promote JSF! Craig is also the lead architect on Sun's Java Studio Creator 2 and is leading the effort on Struts Shale which leverages JSF. He has been a valuable contributor on our mailing list for well over a year now and as an ASF member, has agreed to be the mentor for the ADF incubator project. He has also stated an interest in making the Tomahawk components compatible with Studio Creator. Welcome aboard Craig. We're glad to officially have you on the team now. Sean -- mfg Mario Ivankovits - OPS EDV Vertriebsges.m.b.H. Software Engineering Michael-Bernhard-Gasse 10, A-1120 Wien Tel.: +43-1-8938810 Fax: +43-1-8938810/3700 E-Mail: [EMAIL PROTECTED] Skype: mario_ivankovits -- http://www.irian.at Your JSF powerhouse - JSF Consulting, Development and Courses in English and German Professional Support for Apache MyFaces
[jira] Commented: (MYFACES-1148) Weblogic Classloader problems during development (FactoryFinder)
[ http://issues.apache.org/jira/browse/MYFACES-1148?page=comments#action_12367172 ] Alexander Jesse commented on MYFACES-1148: -- Well the Sun-RI should have the same problem... This is an excerpt from their FactoryFinder: /** * pKeys are web application class loaders. Values are factory * maps for each web application./p * * pFor the nested map, the keys are the factoryName, which must * be one of the code*_FACTORY/code constants above. Values are * one of: /p * * ol * * lipthe actual factory class, if [EMAIL PROTECTED] getFactory} has been * called before on this factoryName/p/li * * lipAn codeArrayList/code of codeStrings/code * representing the configured implementations of for the * factoryName./p/li * * /ol */ private static HashMap applicationMaps = new HashMap(); Weblogic Classloader problems during development (FactoryFinder) Key: MYFACES-1148 URL: http://issues.apache.org/jira/browse/MYFACES-1148 Project: MyFaces Core Type: Bug Components: Implementation Versions: 1.1.1 Environment: Weblogic 9.0, 8.1, etc. Windows XP Pro sp2. Reporter: Adam Brod Like most weblogic users, our team develops using the exploded war format. That means that each time we deploy a new version of a class, weblogic automatically picks it up. The way Weblogic implements this is that when it detects a new class, it drops the classloader for that class, as well as the Servlet and all helper classes that are loaded by the Servlet. That means FacesServlet is dropped and reloaded. The problem is that FactoryFinder stores the Factory classes in a Map where the key is the current classloader. That works fine until I deploy a new class to my webapp. At that point, weblogic drops the classloader and creates a new one with the new class definition. Now when FacesServlet.init() calls FactoryFinder.getFactory() (in the new classloader), an IllegalStateException is generated (see below) because the current classloader is not a valid key for the _registeredFactoryNames Map. One possible solution that I can see to this is to change the key for the Factory map to use the ServletContext's getServletContextName() as the key. I am 95% sure this same problem exists in Weblogic 7.0, 8.1 and 9.1 since they all use almost the same Servlet redeployment mechanism. I have only tried this on Weblogic 9.0. Feb 20, 2006 5:38:07 PM EST Error HTTP BEA-101017 [EMAIL PROTECTED] - name: 'ma-web-1.0-SNAPSHOT ', context-path: '/ma'] Root cause of ServletException. java.lang.IllegalStateException: No Factories configured for this Application - typically this is because a context listener is not setup in yo ur web.xml. A typical config looks like this; listener listener-classorg.apache.myfaces.webapp.StartupServletContextListener/listener-class /listener at javax.faces.FactoryFinder.getFactory(FactoryFinder.java:84) at javax.faces.webapp.FacesServlet.init(FacesServlet.java:84) at weblogic.servlet.internal.StubSecurityHelper$ServletInitAction.run(StubSecurityHelper.java:265) at weblogic.security.acl.internal.AuthenticatedSubject.doAs(AuthenticatedSubject.java:321) at weblogic.security.service.SecurityManager.runAs(SecurityManager.java:121) at weblogic.servlet.internal.StubSecurityHelper.createServlet(StubSecurityHelper.java:61) at weblogic.servlet.internal.StubLifecycleHelper.createOneInstance(StubLifecycleHelper.java:58) at weblogic.servlet.internal.StubLifecycleHelper.init(StubLifecycleHelper.java:48) at weblogic.servlet.internal.ServletStubImpl.prepareServlet(ServletStubImpl.java:502) at weblogic.servlet.internal.ServletStubImpl.checkForReload(ServletStubImpl.java:429) at weblogic.servlet.internal.ServletStubImpl.execute(ServletStubImpl.java:221) at weblogic.servlet.internal.TailFilter.doFilter(TailFilter.java:26) at weblogic.servlet.internal.FilterChainImpl.doFilter(FilterChainImpl.java:42) at oracle.adfinternal.view.faces.webapp.AdfFacesFilterImpl._invokeDoFilter(AdfFacesFilterImpl.java:367) at oracle.adfinternal.view.faces.webapp.AdfFacesFilterImpl._doFilterImpl(AdfFacesFilterImpl.java:336) at oracle.adfinternal.view.faces.webapp.AdfFacesFilterImpl.doFilter(AdfFacesFilterImpl.java:196) at oracle.adf.view.faces.webapp.AdfFacesFilter.doFilter(AdfFacesFilter.java:87) at weblogic.servlet.internal.FilterChainImpl.doFilter(FilterChainImpl.java:42) at org.apache.myfaces.component.html.util.ExtensionsFilter.doFilter(ExtensionsFilter.java:122) at weblogic.servlet.internal.FilterChainImpl.doFilter(FilterChainImpl.java:42)
Re: [jira] Commented: (MYFACES-1146) Impossible to hide footer in dataTable
Hi Mario, why not render a empty panelGroup, if so declared in the jsf source? IMO it is intuitive that there *is* a empty panel rendered in your example. Regards, Volker Mario Ivankovits wrote: Hi Volker! [ http://issues.apache.org/jira/browse/MYFACES-1146?page=comments#action_12367167 ] Volker Weber commented on MYFACES-1146: --- I prefer to check the rendered attribute of footer/header component over adding extra attributes to datatable. This might be complicated, if not impossible to do. I have to check all children of all footer facets to see if the row should be renderer or not. Think of the following (for sure untypical, just to get the point): f:facet name=footer h:panelGroup h:outputLabel for=input h:outputText value=abc rendered=false/ /h:outputLabel h:inputText id=input rendered=false/ /h:panelGroup /f:facet We can say we take the rendered state of the first/root child of the facet tag, but this is not very intuitive, is it? Ciao, Mario -- Don't answer to From: address! Mail to this account are droped if not recieved via mailinglist. To contact me direct create the mail address by concatenating my forename to my senders domain.
Re: svn commit: r378805 - /myfaces/core/trunk/impl/src/main/java/org/apache/myfaces/application/ApplicationFactoryImpl.java
+1 for dependency on commons-logging 1.0.4 BTW, Stan (Silvert), how do you solve these logging issues in JBoss? AFAIK, JBoss has only one central log4j configuration. However, is there a way to config logging per eapp or webapp? If yes, how does JBoss address those issues with shared classes? Thanks, Manfred On 2/21/06, Simon Kitching [EMAIL PROTECTED] wrote: On Mon, 2006-02-20 at 21:47 -0800, Craig McClanahan wrote: No, I was not aware of that change ... but does it actually work? Declaring something Serializable is not by itself sufficient if there are transient variables inside the implementation. (On a separate thread on commons-dev, I recommended that there be unit tests to validate this behavior: use a Log instance, serialize it, deserialize it, and use it some more). I believe Serializable is correctly implemented for all standard adapters except possibly AvalonLog [will follow that up on commons-dev]. The deserialized objects correctly locate a fresh underlying log object to forward calls to. Yes there need to be unit tests for this; I'll look for them and add some if not already present. The 1.0.4 release occurred around June 2004 so perhaps there are a few containers out there capable of running MyFaces but which are still on JCL 1.0.3. In addition there might be a few custom Log adapters around which *might* not implement Serializable. However in view of the complicated/ugly workaround for non-serializable Log implementations, it seems ok to me for MyFaces to just declare a dependency on JCL 1.0.4. If people don't comply then there is a very obvious NotSerializableException: logAdapterClassName message generated. The fix is then to upgrade to 1.0.4 (which is binary compatible with earlier releases) or a later release. Comments/Opinions? +1 on declaring a dependency on Commons Logging 1.0.4 ... anything prior to that is just asking for trouble. I use 1.0.4 exclusively for eveything that has a C-L dependency ... works fine, lasts a long time :-). So the conclusion seems to be that if/when using commons-logging in MyFaces, use: private Log foo = LogFactory.getLog(foo); everywhere except in short-lived and frequently-created objects. In those cases, either call LogFactory.getLog as needed or have some longer-lived object store the Log object. For StateHolder classes, things just work; the logger isn't saved in saveState; it gets recreated in the new component and that works. For Serializable classes, the Log object handles its own serialization correctly. No need for transient, no need for any other special hacks. MyFaces does need to declare a dependency on commons-logging 1.0.4 (not earlier versions) in order for things to work this simply. Release 1.0.4 was in June 2004. Do NOT use static Log anywhere. Is this all ok? Cheers, Simon
Re: [jira] Commented: (MYFACES-1146) Impossible to hide footer in dataTable
Hi! why not render a empty panelGroup, if so declared in the jsf source? IMO it is intuitive that there *is* a empty panel rendered in your example. So I'll check the rendered attribute of the facet child and if none of the facets are going to be rendered I'll suppress the footer (header) at all. --- Mario This might be complicated, if not impossible to do. I have to check all children of all footer facets to see if the row should be renderer or not. Think of the following (for sure untypical, just to get the point): f:facet name=footer h:panelGroup h:outputLabel for=input h:outputText value=abc rendered=false/ /h:outputLabel h:inputText id=input rendered=false/ /h:panelGroup /f:facet We can say we take the rendered state of the first/root child of the facet tag, but this is not very intuitive, is it?
Re: [jira] Commented: (MYFACES-1146) Impossible to hide footer in dataTable
Of course, this leads to additional evaluations of the rendered attribute. Well, sounds good. regards, Martin On 2/21/06, Mario Ivankovits [EMAIL PROTECTED] wrote: Hi! why not render a empty panelGroup, if so declared in the jsf source? IMO it is intuitive that there *is* a empty panel rendered in your example. So I'll check the rendered attribute of the facet child and if none of the facets are going to be rendered I'll suppress the footer (header) at all. --- Mario This might be complicated, if not impossible to do. I have to check all children of all footer facets to see if the row should be renderer or not. Think of the following (for sure untypical, just to get the point): f:facet name=footer h:panelGroup h:outputLabel for=input h:outputText value=abc rendered=false/ /h:outputLabel h:inputText id=input rendered=false/ /h:panelGroup /f:facet We can say we take the rendered state of the first/root child of the facet tag, but this is not very intuitive, is it? -- http://www.irian.at Your JSF powerhouse - JSF Consulting, Development and Courses in English and German Professional Support for Apache MyFaces
Re: Refactor Commons to org.apache.myfaces.commons ?
On 2/20/06, Sean Schofield [EMAIL PROTECTED] wrote: Wow that seems really complicated. I have serious concerns about last minute search and replace on the source code. There's got to be a easier solution. Until we started down the maven path we were fine with the way it is. Lets re-examine why we are considering this in the first place. Manfred's scenario ... Scenario: 1. We release commons-1.1.2 + core 1.1.2 (core 1.1.2 depends on commons-1.1.2) 2. days go by... 3. We release commons-1.1.3 (because there where significant changes) + tomahawk 1.1.3 (which depends on commons-1.1.3) So, there are now the following official releases out there: commons-1.1.2 commons-1.1.3 core-1.1.2 tomahawk-1.1.3 User happy starts his brandnew Maven project unlucky, decides to use the latest stable releases of everything and defines the following dependencies: XY depends on myfaces-api 1.1.2 (scope compile) XY depends on myfaces-impl 1.1.2 (scope runtime) XY depends on tomahawk 1.1.3 (scope compile) Now he builds the WAR. Guess what he ends up with? WEB-INF/lib/myfaces-api-1.1.2.jar WEB-INF/lib/myfaces-commons-1.1.2.jar WEB-INF/lib/myfaces-commons-1.1.3.jar WEB-INF/lib/myfaces-impl-1.1.2.jar WEB-INF/lib/myfaces-tomahawk-1.1.3.jar I think we can solve this usecase without resorting to last minute code refactoring by maven, or even worse, changing bytecode around. I just don't think those solutions are necessary. One solution could be is that we make the scope of the commons dependency in core and tomahawk to be provided. That way its not transitive and you don't end up with two versions of the commons jar in your WAR. What that means is that you need to declare explicitly a commons dependency in your project as well as core and/or tomahawk. Yes, this sounds reasonable. If we decide against this auto-repackage thingy, this is probably the right setting for our dependencies. Manfred In this case you would just say your project depends on commons version 1.1.3. Everything will be fine as long as 1.1.3 does not break backwards compatability with an earlier version of the core. We can easily test this when we release tomahawk and if it does break backwards compatability, we can release a newer version of the core as well. Its not ideal but its much better then the other alternatives we are considering. I think we carefully document and explain this on the website and include instructions and considerations for those building with maven or using myfaces implementation in their J2EE containers. Sean On 2/18/06, Manfred Geiler [EMAIL PROTECTED] wrote: As Martin already has mentioned, I'm more and more convinced too, that repackaging commons for impl is the only solution that will make as carefree in the long run. Though, I do not agree that it is necessary or advantageous to repackage commons for all component libs (tomahawk, tobago, adffaces). This would bring commons far away from the original idea of having a Jakarta commons like JSF library with goodies and convenient base classes for custom components. Yes, people will probably have conflicts. But the release cycles of our component libs should be fast enough and commons should become stable enough, so that this is no longer a problem. MyFaces-Core (ie. impl) is different insofar as * we want to keep release cycles at a minimum * it will become integrated part of containers (already shipped with JBoss 4.x), or * people make them part of their containers by sharing myfaces-api.jar and myfaces-impl.jar in the containers common/lib or shared/lib dir. The last two points also will have influence on how people will configure their own Maven projects: provided dependency on myfaces-api.jar and myfaces-impl.jar of the version that was shipped with (or is integrated in) the container. People will behave conservative in changing their container environment and behave liberal when using the newest component lib. However, as soon as we have a repackaging solution, it is easy enough to use it not only for impl. So, let's discuss repackaging in general first and postpone the question of using repackaged commons lib for tomahawk et al. for a while, ok? Here is my idea for a (not-so-high-sophisticated but) easy repackaging solution: 1. First of all we refactor Commons to org.apache.myfaces.commons.* (we already have an agreement on this) 2. Next we create a sub-project in commons. Working title intermediate-commons-impl. = This project's outcome will be the intermediate-commons-impl.jar file with all commons classes auto-repackaged to org.apache.myfaces.commons.impl.* (like proposed by Simon). = This jar file will not be shipped or included in any assembly (therefore intermediate). It only serves as the Maven-way medium to transport the repackaged commons classes to the impl module. The repackaged class files will
Re: Don't disable unit tests before a checkin
+1 In fact, make sure you are running mvn clean install before checkin so you are not just relying on your IDE compile. On 2/21/06, Bernd Bohmann [EMAIL PROTECTED] wrote: Hello, don't call mvn with -Dmaven.test.skip=true if you are going to checkin something, please. Regards Bernd -- Dipl.-Ing. Bernd Bohmann - Atanion GmbH - Software Development Bismarckstr. 13, 26122 Oldenburg, http://www.atanion.com phone: +49 441 4082312, mobile: +49 173 8839471, fax: +49 441 4082333
Re: Refactor Commons to org.apache.myfaces.commons ?
Yes I think this is unecessarily complicated. I've certainly never contemplated anything like this before. If you think about it this must be a fairly common problem. How many projects out there rely on different versions of commons-collections? My guess is that if you use maven to build something with two different projects which each have a different transitive dependency on commons-collections, you will end up with two commons-collections in your WAR or whatever. We should ask John Fallows about this. He seems to know all the maven details. What I mean by last minute is that the java files will have one package name during development and IDE testing and then just before you do a maven build you will switch it all around. I agree that this is better then tampering with byte code but it still seems like an extreme solution to something that must be a relatively common problem. Ideally maven would have a feature that would include the newest version of a dependency in the case of multiple conflicting versions of a transitive dependency. If it doesn't perhaps we could put our energies into helping them resolve this. In the meantime, I think my proposed workaround would be better. Sean On 2/21/06, Manfred Geiler [EMAIL PROTECTED] wrote: On 2/20/06, Sean Schofield [EMAIL PROTECTED] wrote: Wow that seems really complicated. I have serious concerns about last minute search and replace on the source code. There's got to be a easier solution. Do you really think this is complicated? I wanted to be as precise as possible - therefore the length of my email. Please reconsider, there is no really complex part in my proposal. I think a textual search-and-replace *is* a simple solution - in contrast to byte code manipulation or the like. What do you mean by last minute? This sounds like hasty or dangerous. On a normal build (with SNAPSHOT versions) the intermediate transport lib will automatically be built and impl will be compiled against it. So, if there ever be a problem with the search-and-replace or for whatever reason the search-and-replace does not go far enough, you will immediately get a compile error. And under normal circumstances a developer won't commit changes in commons that lead to such an error. So, I cannot see any danger here. Manfred Until we started down the maven path we were fine with the way it is. Lets re-examine why we are considering this in the first place. Manfred's scenario ... Scenario: 1. We release commons-1.1.2 + core 1.1.2 (core 1.1.2 depends on commons-1.1.2) 2. days go by... 3. We release commons-1.1.3 (because there where significant changes) + tomahawk 1.1.3 (which depends on commons-1.1.3) So, there are now the following official releases out there: commons-1.1.2 commons-1.1.3 core-1.1.2 tomahawk-1.1.3 User happy starts his brandnew Maven project unlucky, decides to use the latest stable releases of everything and defines the following dependencies: XY depends on myfaces-api 1.1.2 (scope compile) XY depends on myfaces-impl 1.1.2 (scope runtime) XY depends on tomahawk 1.1.3 (scope compile) Now he builds the WAR. Guess what he ends up with? WEB-INF/lib/myfaces-api-1.1.2.jar WEB-INF/lib/myfaces-commons-1.1.2.jar WEB-INF/lib/myfaces-commons-1.1.3.jar WEB-INF/lib/myfaces-impl-1.1.2.jar WEB-INF/lib/myfaces-tomahawk-1.1.3.jar I think we can solve this usecase without resorting to last minute code refactoring by maven, or even worse, changing bytecode around. I just don't think those solutions are necessary. One solution could be is that we make the scope of the commons dependency in core and tomahawk to be provided. That way its not transitive and you don't end up with two versions of the commons jar in your WAR. What that means is that you need to declare explicitly a commons dependency in your project as well as core and/or tomahawk. In this case you would just say your project depends on commons version 1.1.3. Everything will be fine as long as 1.1.3 does not break backwards compatability with an earlier version of the core. We can easily test this when we release tomahawk and if it does break backwards compatability, we can release a newer version of the core as well. Its not ideal but its much better then the other alternatives we are considering. I think we carefully document and explain this on the website and include instructions and considerations for those building with maven or using myfaces implementation in their J2EE containers. Sean On 2/18/06, Manfred Geiler [EMAIL PROTECTED] wrote: As Martin already has mentioned, I'm more and more convinced too, that repackaging commons for impl is the only solution that will make as carefree in the long run. Though, I do not agree that it is necessary or advantageous to repackage commons for all component libs (tomahawk, tobago, adffaces).
Re: Maven2 build failure with current trunk?
Craig, You should be ok now. Let us know if you still have problems. Sean On 2/21/06, Werner Punz [EMAIL PROTECTED] wrote: Dennis Byrne schrieb: Most of the encryption tests have really strong cipher configurations. These levels of encryption have to be enabled for a standard JDK. There is a brief explanation in the javadocs of the tests themselves, although this does not explain why they worked for you in the past. Either enabled, or simply a different crypto provider has to be used. I settled in the past for the second option (bouncycastle) sorry, just wanted to give my 2c here, because the whole issue has been a huge annoyance once for me in the past.
Re: svn commit: r378805 - /myfaces/core/trunk/impl/src/main/java/org/apache/myfaces/application/ApplicationFactoryImpl.java
Yes +1 for 1.0.4. Thanks for explaining all of this. On 2/21/06, Manfred Geiler [EMAIL PROTECTED] wrote: +1 for dependency on commons-logging 1.0.4 BTW, Stan (Silvert), how do you solve these logging issues in JBoss? AFAIK, JBoss has only one central log4j configuration. However, is there a way to config logging per eapp or webapp? If yes, how does JBoss address those issues with shared classes? Thanks, Manfred On 2/21/06, Simon Kitching [EMAIL PROTECTED] wrote: On Mon, 2006-02-20 at 21:47 -0800, Craig McClanahan wrote: No, I was not aware of that change ... but does it actually work? Declaring something Serializable is not by itself sufficient if there are transient variables inside the implementation. (On a separate thread on commons-dev, I recommended that there be unit tests to validate this behavior: use a Log instance, serialize it, deserialize it, and use it some more). I believe Serializable is correctly implemented for all standard adapters except possibly AvalonLog [will follow that up on commons-dev]. The deserialized objects correctly locate a fresh underlying log object to forward calls to. Yes there need to be unit tests for this; I'll look for them and add some if not already present. The 1.0.4 release occurred around June 2004 so perhaps there are a few containers out there capable of running MyFaces but which are still on JCL 1.0.3. In addition there might be a few custom Log adapters around which *might* not implement Serializable. However in view of the complicated/ugly workaround for non-serializable Log implementations, it seems ok to me for MyFaces to just declare a dependency on JCL 1.0.4. If people don't comply then there is a very obvious NotSerializableException: logAdapterClassName message generated. The fix is then to upgrade to 1.0.4 (which is binary compatible with earlier releases) or a later release. Comments/Opinions? +1 on declaring a dependency on Commons Logging 1.0.4 ... anything prior to that is just asking for trouble. I use 1.0.4 exclusively for eveything that has a C-L dependency ... works fine, lasts a long time :-). So the conclusion seems to be that if/when using commons-logging in MyFaces, use: private Log foo = LogFactory.getLog(foo); everywhere except in short-lived and frequently-created objects. In those cases, either call LogFactory.getLog as needed or have some longer-lived object store the Log object. For StateHolder classes, things just work; the logger isn't saved in saveState; it gets recreated in the new component and that works. For Serializable classes, the Log object handles its own serialization correctly. No need for transient, no need for any other special hacks. MyFaces does need to declare a dependency on commons-logging 1.0.4 (not earlier versions) in order for things to work this simply. Release 1.0.4 was in June 2004. Do NOT use static Log anywhere. Is this all ok? Cheers, Simon
Re: Refactor Commons to org.apache.myfaces.commons ?
On 2/21/06, Sean Schofield [EMAIL PROTECTED] wrote: Yes I think this is unecessarily complicated. I've certainly never contemplated anything like this before. If you think about it this must be a fairly common problem. How many projects out there rely on different versions of commons-collections? My guess is that if you use maven to build something with two different projects which each have a different transitive dependency on commons-collections, you will end up with two commons-collections in your WAR or whatever. We should ask John Fallows about this. He seems to know all the maven details. What I mean by last minute is that the java files will have one package name during development and IDE testing and then just before you do a maven build you will switch it all around. I agree that this is better then tampering with byte code but it still seems like an extreme solution to something that must be a relatively common problem. No, that's not exactly what I have proposed. Sorry if my description was misleading. The key point is this: * We do a one-time refactoring for impl classes where we switch the impl classes to org.apache.myfaces.commons.impl.* That means, impl classes would not know anything of the original o.a.m.commons.* classes any more. They would always be linked with the already repackaged o.a.m.commons.impl.* classes. So, testing and development of core is always against the repackaged commons classes. And if we do not auto-repackage for tomahawk, those tests would always be against the original o.a.m.commons.* classes. So, I don' t see a real problem here. Manfred Ideally maven would have a feature that would include the newest version of a dependency in the case of multiple conflicting versions of a transitive dependency. If it doesn't perhaps we could put our energies into helping them resolve this. In the meantime, I think my proposed workaround would be better. Sean On 2/21/06, Manfred Geiler [EMAIL PROTECTED] wrote: On 2/20/06, Sean Schofield [EMAIL PROTECTED] wrote: Wow that seems really complicated. I have serious concerns about last minute search and replace on the source code. There's got to be a easier solution. Do you really think this is complicated? I wanted to be as precise as possible - therefore the length of my email. Please reconsider, there is no really complex part in my proposal. I think a textual search-and-replace *is* a simple solution - in contrast to byte code manipulation or the like. What do you mean by last minute? This sounds like hasty or dangerous. On a normal build (with SNAPSHOT versions) the intermediate transport lib will automatically be built and impl will be compiled against it. So, if there ever be a problem with the search-and-replace or for whatever reason the search-and-replace does not go far enough, you will immediately get a compile error. And under normal circumstances a developer won't commit changes in commons that lead to such an error. So, I cannot see any danger here. Manfred Until we started down the maven path we were fine with the way it is. Lets re-examine why we are considering this in the first place. Manfred's scenario ... Scenario: 1. We release commons-1.1.2 + core 1.1.2 (core 1.1.2 depends on commons-1.1.2) 2. days go by... 3. We release commons-1.1.3 (because there where significant changes) + tomahawk 1.1.3 (which depends on commons-1.1.3) So, there are now the following official releases out there: commons-1.1.2 commons-1.1.3 core-1.1.2 tomahawk-1.1.3 User happy starts his brandnew Maven project unlucky, decides to use the latest stable releases of everything and defines the following dependencies: XY depends on myfaces-api 1.1.2 (scope compile) XY depends on myfaces-impl 1.1.2 (scope runtime) XY depends on tomahawk 1.1.3 (scope compile) Now he builds the WAR. Guess what he ends up with? WEB-INF/lib/myfaces-api-1.1.2.jar WEB-INF/lib/myfaces-commons-1.1.2.jar WEB-INF/lib/myfaces-commons-1.1.3.jar WEB-INF/lib/myfaces-impl-1.1.2.jar WEB-INF/lib/myfaces-tomahawk-1.1.3.jar I think we can solve this usecase without resorting to last minute code refactoring by maven, or even worse, changing bytecode around. I just don't think those solutions are necessary. One solution could be is that we make the scope of the commons dependency in core and tomahawk to be provided. That way its not transitive and you don't end up with two versions of the commons jar in your WAR. What that means is that you need to declare explicitly a commons dependency in your project as well as core and/or tomahawk. In this case you would just say your project depends on commons version 1.1.3. Everything will be fine as long as 1.1.3 does not break backwards compatability with an earlier version of the core. We
[jira] Created: (TOMAHAWK-1) Unusefull code
Unusefull code -- Key: TOMAHAWK-1 URL: http://issues.apache.org/jira/browse/TOMAHAWK-1 Project: MyFaces Tomahawk Type: Improvement Components: Tree Reporter: Guillaume Doumenc Priority: Trivial Not sure this code is usefull in HtmlTreeRenderer line 489 List componentChildren = null; if (null != component) { componentChildren = component.getChildren(); } -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
Re: FactoryFinder.releaseFactories() - was [continuum] BUILD FAILURE: API
On 2/20/06, Craig McClanahan [EMAIL PROTECTED] wrote: I did indeed see that (thanks for the fix) ... and Sean has already checked that change in (I see it in the trunk sources for Shale that I just checked out), so it will be in the 20060221 nightly build. That doesn't necessarily translate to it being visible in the 1.0.1 snapshots, though ... Wendy, could you refresh the snapshots Done. (and/or tell me how to do so when significant changes happen)? Notes on configuration and the command to deploy a snapshot: http://svn.apache.org/repos/asf/struts/shale/trunk/build/maven2/README.txt And here's the script I'm using to update all of the snapshots: http://wiki.wsmoak.net/cgi-bin/wiki.pl?ShaleMaven2/Script If 38627 is fixed, the script can be made generic. Or, I wonder if Ant has Maven tasks yet... -- Wendy
[jira] Commented: (MYFACES-1148) Weblogic Classloader problems during development (FactoryFinder)
[ http://issues.apache.org/jira/browse/MYFACES-1148?page=comments#action_12367193 ] Adam Brod commented on MYFACES-1148: Dennis- Neither of those issues is related, as far as I can tell. Adam Weblogic Classloader problems during development (FactoryFinder) Key: MYFACES-1148 URL: http://issues.apache.org/jira/browse/MYFACES-1148 Project: MyFaces Core Type: Bug Components: Implementation Versions: 1.1.1 Environment: Weblogic 9.0, 8.1, etc. Windows XP Pro sp2. Reporter: Adam Brod Like most weblogic users, our team develops using the exploded war format. That means that each time we deploy a new version of a class, weblogic automatically picks it up. The way Weblogic implements this is that when it detects a new class, it drops the classloader for that class, as well as the Servlet and all helper classes that are loaded by the Servlet. That means FacesServlet is dropped and reloaded. The problem is that FactoryFinder stores the Factory classes in a Map where the key is the current classloader. That works fine until I deploy a new class to my webapp. At that point, weblogic drops the classloader and creates a new one with the new class definition. Now when FacesServlet.init() calls FactoryFinder.getFactory() (in the new classloader), an IllegalStateException is generated (see below) because the current classloader is not a valid key for the _registeredFactoryNames Map. One possible solution that I can see to this is to change the key for the Factory map to use the ServletContext's getServletContextName() as the key. I am 95% sure this same problem exists in Weblogic 7.0, 8.1 and 9.1 since they all use almost the same Servlet redeployment mechanism. I have only tried this on Weblogic 9.0. Feb 20, 2006 5:38:07 PM EST Error HTTP BEA-101017 [EMAIL PROTECTED] - name: 'ma-web-1.0-SNAPSHOT ', context-path: '/ma'] Root cause of ServletException. java.lang.IllegalStateException: No Factories configured for this Application - typically this is because a context listener is not setup in yo ur web.xml. A typical config looks like this; listener listener-classorg.apache.myfaces.webapp.StartupServletContextListener/listener-class /listener at javax.faces.FactoryFinder.getFactory(FactoryFinder.java:84) at javax.faces.webapp.FacesServlet.init(FacesServlet.java:84) at weblogic.servlet.internal.StubSecurityHelper$ServletInitAction.run(StubSecurityHelper.java:265) at weblogic.security.acl.internal.AuthenticatedSubject.doAs(AuthenticatedSubject.java:321) at weblogic.security.service.SecurityManager.runAs(SecurityManager.java:121) at weblogic.servlet.internal.StubSecurityHelper.createServlet(StubSecurityHelper.java:61) at weblogic.servlet.internal.StubLifecycleHelper.createOneInstance(StubLifecycleHelper.java:58) at weblogic.servlet.internal.StubLifecycleHelper.init(StubLifecycleHelper.java:48) at weblogic.servlet.internal.ServletStubImpl.prepareServlet(ServletStubImpl.java:502) at weblogic.servlet.internal.ServletStubImpl.checkForReload(ServletStubImpl.java:429) at weblogic.servlet.internal.ServletStubImpl.execute(ServletStubImpl.java:221) at weblogic.servlet.internal.TailFilter.doFilter(TailFilter.java:26) at weblogic.servlet.internal.FilterChainImpl.doFilter(FilterChainImpl.java:42) at oracle.adfinternal.view.faces.webapp.AdfFacesFilterImpl._invokeDoFilter(AdfFacesFilterImpl.java:367) at oracle.adfinternal.view.faces.webapp.AdfFacesFilterImpl._doFilterImpl(AdfFacesFilterImpl.java:336) at oracle.adfinternal.view.faces.webapp.AdfFacesFilterImpl.doFilter(AdfFacesFilterImpl.java:196) at oracle.adf.view.faces.webapp.AdfFacesFilter.doFilter(AdfFacesFilter.java:87) at weblogic.servlet.internal.FilterChainImpl.doFilter(FilterChainImpl.java:42) at org.apache.myfaces.component.html.util.ExtensionsFilter.doFilter(ExtensionsFilter.java:122) at weblogic.servlet.internal.FilterChainImpl.doFilter(FilterChainImpl.java:42) at weblogic.servlet.internal.WebAppServletContext$ServletInvocationAction.run(WebAppServletContext.java:3020) at weblogic.security.acl.internal.AuthenticatedSubject.doAs(AuthenticatedSubject.java:321) at weblogic.security.service.SecurityManager.runAs(SecurityManager.java:121) at weblogic.servlet.internal.WebAppServletContext.securedExecute(WebAppServletContext.java:1925) at weblogic.servlet.internal.WebAppServletContext.execute(WebAppServletContext.java:1848) at weblogic.servlet.internal.ServletRequestImpl.run(ServletRequestImpl.java:1288) at weblogic.work.ExecuteThread.execute(ExecuteThread.java:207) at
[jira] Commented: (MYFACES-1148) Weblogic Classloader problems during development (FactoryFinder)
[ http://issues.apache.org/jira/browse/MYFACES-1148?page=comments#action_12367194 ] Adam Brod commented on MYFACES-1148: I gave up on the JSF-RI quite a while ago; however, I did experience the same problem with the FactoryFinder not finding the Factories. Weblogic Classloader problems during development (FactoryFinder) Key: MYFACES-1148 URL: http://issues.apache.org/jira/browse/MYFACES-1148 Project: MyFaces Core Type: Bug Components: Implementation Versions: 1.1.1 Environment: Weblogic 9.0, 8.1, etc. Windows XP Pro sp2. Reporter: Adam Brod Like most weblogic users, our team develops using the exploded war format. That means that each time we deploy a new version of a class, weblogic automatically picks it up. The way Weblogic implements this is that when it detects a new class, it drops the classloader for that class, as well as the Servlet and all helper classes that are loaded by the Servlet. That means FacesServlet is dropped and reloaded. The problem is that FactoryFinder stores the Factory classes in a Map where the key is the current classloader. That works fine until I deploy a new class to my webapp. At that point, weblogic drops the classloader and creates a new one with the new class definition. Now when FacesServlet.init() calls FactoryFinder.getFactory() (in the new classloader), an IllegalStateException is generated (see below) because the current classloader is not a valid key for the _registeredFactoryNames Map. One possible solution that I can see to this is to change the key for the Factory map to use the ServletContext's getServletContextName() as the key. I am 95% sure this same problem exists in Weblogic 7.0, 8.1 and 9.1 since they all use almost the same Servlet redeployment mechanism. I have only tried this on Weblogic 9.0. Feb 20, 2006 5:38:07 PM EST Error HTTP BEA-101017 [EMAIL PROTECTED] - name: 'ma-web-1.0-SNAPSHOT ', context-path: '/ma'] Root cause of ServletException. java.lang.IllegalStateException: No Factories configured for this Application - typically this is because a context listener is not setup in yo ur web.xml. A typical config looks like this; listener listener-classorg.apache.myfaces.webapp.StartupServletContextListener/listener-class /listener at javax.faces.FactoryFinder.getFactory(FactoryFinder.java:84) at javax.faces.webapp.FacesServlet.init(FacesServlet.java:84) at weblogic.servlet.internal.StubSecurityHelper$ServletInitAction.run(StubSecurityHelper.java:265) at weblogic.security.acl.internal.AuthenticatedSubject.doAs(AuthenticatedSubject.java:321) at weblogic.security.service.SecurityManager.runAs(SecurityManager.java:121) at weblogic.servlet.internal.StubSecurityHelper.createServlet(StubSecurityHelper.java:61) at weblogic.servlet.internal.StubLifecycleHelper.createOneInstance(StubLifecycleHelper.java:58) at weblogic.servlet.internal.StubLifecycleHelper.init(StubLifecycleHelper.java:48) at weblogic.servlet.internal.ServletStubImpl.prepareServlet(ServletStubImpl.java:502) at weblogic.servlet.internal.ServletStubImpl.checkForReload(ServletStubImpl.java:429) at weblogic.servlet.internal.ServletStubImpl.execute(ServletStubImpl.java:221) at weblogic.servlet.internal.TailFilter.doFilter(TailFilter.java:26) at weblogic.servlet.internal.FilterChainImpl.doFilter(FilterChainImpl.java:42) at oracle.adfinternal.view.faces.webapp.AdfFacesFilterImpl._invokeDoFilter(AdfFacesFilterImpl.java:367) at oracle.adfinternal.view.faces.webapp.AdfFacesFilterImpl._doFilterImpl(AdfFacesFilterImpl.java:336) at oracle.adfinternal.view.faces.webapp.AdfFacesFilterImpl.doFilter(AdfFacesFilterImpl.java:196) at oracle.adf.view.faces.webapp.AdfFacesFilter.doFilter(AdfFacesFilter.java:87) at weblogic.servlet.internal.FilterChainImpl.doFilter(FilterChainImpl.java:42) at org.apache.myfaces.component.html.util.ExtensionsFilter.doFilter(ExtensionsFilter.java:122) at weblogic.servlet.internal.FilterChainImpl.doFilter(FilterChainImpl.java:42) at weblogic.servlet.internal.WebAppServletContext$ServletInvocationAction.run(WebAppServletContext.java:3020) at weblogic.security.acl.internal.AuthenticatedSubject.doAs(AuthenticatedSubject.java:321) at weblogic.security.service.SecurityManager.runAs(SecurityManager.java:121) at weblogic.servlet.internal.WebAppServletContext.securedExecute(WebAppServletContext.java:1925) at weblogic.servlet.internal.WebAppServletContext.execute(WebAppServletContext.java:1848) at weblogic.servlet.internal.ServletRequestImpl.run(ServletRequestImpl.java:1288) at
[jira] Commented: (TOMAHAWK-1) Unusefull code
[ http://issues.apache.org/jira/browse/TOMAHAWK-1?page=comments#action_12367186 ] Guillaume Doumenc commented on TOMAHAWK-1: -- Can you cancel it.. Sorry misunderstanding the calling context.. Unusefull code -- Key: TOMAHAWK-1 URL: http://issues.apache.org/jira/browse/TOMAHAWK-1 Project: MyFaces Tomahawk Type: Improvement Components: Tree Reporter: Guillaume Doumenc Priority: Trivial Not sure this code is usefull in HtmlTreeRenderer line 489 List componentChildren = null; if (null != component) { componentChildren = component.getChildren(); } -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Resolved: (TOMAHAWK-1) Unusefull code
[ http://issues.apache.org/jira/browse/TOMAHAWK-1?page=all ] Mario Ivankovits resolved TOMAHAWK-1: - Resolution: Invalid Unusefull code -- Key: TOMAHAWK-1 URL: http://issues.apache.org/jira/browse/TOMAHAWK-1 Project: MyFaces Tomahawk Type: Improvement Components: Tree Reporter: Guillaume Doumenc Priority: Trivial Not sure this code is usefull in HtmlTreeRenderer line 489 List componentChildren = null; if (null != component) { componentChildren = component.getChildren(); } -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Closed: (TOMAHAWK-1) Unusefull code
[ http://issues.apache.org/jira/browse/TOMAHAWK-1?page=all ] Mario Ivankovits closed TOMAHAWK-1: --- Unusefull code -- Key: TOMAHAWK-1 URL: http://issues.apache.org/jira/browse/TOMAHAWK-1 Project: MyFaces Tomahawk Type: Improvement Components: Tree Reporter: Guillaume Doumenc Priority: Trivial Not sure this code is usefull in HtmlTreeRenderer line 489 List componentChildren = null; if (null != component) { componentChildren = component.getChildren(); } -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Closed: (MYFACES-1143) InputSuggestAjax does not handle and correctly
[ http://issues.apache.org/jira/browse/MYFACES-1143?page=all ] Werner Punz closed MYFACES-1143: Fix Version: Nightly Resolution: Fixed Ok I am closing it now, the dojo people have solved this one for us... Thanks Gerald for checking it and commenting on it. InputSuggestAjax does not handle and correctly -- Key: MYFACES-1143 URL: http://issues.apache.org/jira/browse/MYFACES-1143 Project: MyFaces Core Type: Bug Components: Sandbox Reporter: Jean-Claude Pace Fix For: Nightly When using InputSuggestAjax, if the list of suggestions contains the characters and , the string is not shown correctly in the popup. For example, if the component wants to suggest something like Name [EMAIL PROTECTED] the popup will only show Name. Leaving out either the or the will result in correct behaviour. My guess is that the characters are confusing the XML encoding used by Ajax. Substituting the characters with something like lt; or gt; results in an ugly display in the popup but at least the text in the input box is displayed correctly. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
JIRA Changes
I have succesfully created a MyFaces Tomahawk project in JIRA. Issues will have an id of TOMAHAWK-[issue number]. I also renamed the existing JIRA project to MyFaces Core. The issues for that project remain MYFACES-[issue number]. I believe we will need infra to officially group them together in the same MyFaces category but we can wait until we are done for that. I have replicated the versions from our current JIRA project with one change. There is no longer a NIGHTLY version. From now on we will be using the SNAPSHOT versions. This means that at the moment, when you fix something in TOMAHAWK you will fix it against version 1.1.2-SNAPSHOT. When we release we will rename that version to 1.1.2. MyFaces core still has a NIGHTLY version. We will change this eventually but its a little trickier (trust me.) I have copied everything that was marked as Tomahawk in the original JIRA and moved it over. I have not retroactively assigned a component to all of the issues but going we should probably assign components to all open issues and certainly all new issues going forward. I have moved all of the tomahawk issues (at least the ones marked tomahawk in the original jira) to the new JIRA project. JIRA is also smart enough to map the old issue numbers with new issue numbers. So if you try to navigate to MYFACES-975[1], JIRA knows enough to redirect you to TOMAHAWK-96. I have not moved the sandbox stuff yet. My thinking is that sandbox components should be part of the Tomahawk JIRA since they are part of the same maven subproject and they will eventually be promoted to Tomahawk. They will also always have the same versions as Tomahawk. If I get some +1's I will move these also. I haven't changed the permissions or notification at all. We can talk about that at a future point once we get everything into the right spot. Take a look and let me know what you think. Sean [1] https://issues.apache.org/jira/browse/MYFACES-975
[jira] Deleted: (TOMAHAWK-7) fileupload
[ http://issues.apache.org/jira/browse/TOMAHAWK-7?page=all ] sean schofield deleted TOMAHAWK-7: -- fileupload -- Key: TOMAHAWK-7 URL: http://issues.apache.org/jira/browse/TOMAHAWK-7 Project: MyFaces Tomahawk Type: Sub-task Environment: jboss4, windows xp sp1, Reporter: Seshireddy G Hi, I am facing a problem with fileupload. I am using (t:inputFileUpload id=fileupload ... when the user select some file, the selected file path will be copied to the text . then if the user adds some blank space in front of the path and submits it is not submitting. so is it a bug in file upload implementation?? i check with my faces examples source code . I want readonly property for the text field. so we can restrict the user to enter the data. if i use readonly=true the inputFileUpload is not at all working. please help me . Sesh -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (TOMAHAWK-30) [tree2] Navigation icons should have @immediate=true
[ http://issues.apache.org/jira/browse/TOMAHAWK-30?page=all ] sean schofield updated TOMAHAWK-30: --- Component: Tree2 (was: Other) [tree2] Navigation icons should have @immediate=true Key: TOMAHAWK-30 URL: http://issues.apache.org/jira/browse/TOMAHAWK-30 Project: MyFaces Tomahawk Type: Bug Components: Tree2 Reporter: sean schofield Assignee: sean schofield If you are using tree2 (server side toggle) on a JSF page that requires validation, clicking on the nav icon triggers validation. The immediate attribute on these commandLinks should be true so that no validation is performed. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (TOMAHAWK-118) Tree2 needs the pass-through html attributes
[ http://issues.apache.org/jira/browse/TOMAHAWK-118?page=all ] sean schofield updated TOMAHAWK-118: Component: Tree2 (was: Other) Tree2 needs the pass-through html attributes Key: TOMAHAWK-118 URL: http://issues.apache.org/jira/browse/TOMAHAWK-118 Project: MyFaces Tomahawk Type: Bug Components: Tree2 Environment: All Reporter: Rob Decker Assignee: sean schofield Attachments: passthrough.patch Tree2 doesn't currently allow the pass-through html attributes. It uses a table and being able to set a border, set it's width, and set style, styleClass (as well as the other pass-throughs supported by table) is needed to allow page designers to tweak the look and feel (or in my case coders designing pages). This is minor in terms of coding and I can provide it if someone can merge it into the source. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (TOMAHAWK-35) Tree2 setLeaf(false) error
[ http://issues.apache.org/jira/browse/TOMAHAWK-35?page=all ] sean schofield updated TOMAHAWK-35: --- Component: Tree2 (was: Other) Tree2 setLeaf(false) error -- Key: TOMAHAWK-35 URL: http://issues.apache.org/jira/browse/TOMAHAWK-35 Project: MyFaces Tomahawk Type: Bug Components: Tree2 Environment: Tested in JBoss 4.0.3 with Seam Reporter: Andrew Efremov Assignee: sean schofield when trying to add nodes to tree2 TreeNodeBase tree = new TreeNodeBase(document, node.getName(), node.getId().toString(), false); result node have tree.isLeaf() == true; the same is when you trying explicitly set Leaf tree.setLeaf(false); result node have tree.isLeaf() == true; -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
Re: [jira] Deleted: (TOMAHAWK-7) fileupload
I didn't mean to delete this one. At some point I will readd it. On 2/21/06, sean schofield (JIRA) [EMAIL PROTECTED] wrote: [ http://issues.apache.org/jira/browse/TOMAHAWK-7?page=all ] sean schofield deleted TOMAHAWK-7: -- fileupload -- Key: TOMAHAWK-7 URL: http://issues.apache.org/jira/browse/TOMAHAWK-7 Project: MyFaces Tomahawk Type: Sub-task Environment: jboss4, windows xp sp1, Reporter: Seshireddy G Hi, I am facing a problem with fileupload. I am using (t:inputFileUpload id=fileupload ... when the user select some file, the selected file path will be copied to the text . then if the user adds some blank space in front of the path and submits it is not submitting. so is it a bug in file upload implementation?? i check with my faces examples source code . I want readonly property for the text field. so we can restrict the user to enter the data. if i use readonly=true the inputFileUpload is not at all working. please help me . Sesh -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Resolved: (MYFACES-750) Need synchronization in LifecycleImpl
[ http://issues.apache.org/jira/browse/MYFACES-750?page=all ] Manfred Geiler resolved MYFACES-750: Fix Version: Nightly Resolution: Fixed Actually implemented a slightly different solution than was suggested. But synchronized is the right solution here, Thanks! Need synchronization in LifecycleImpl - Key: MYFACES-750 URL: http://issues.apache.org/jira/browse/MYFACES-750 Project: MyFaces Core Type: Bug Components: Implementation Versions: 1.1.0 Environment: Weblogic 8.1, AIX Reporter: Sam Schneider Assignee: Manfred Geiler Fix For: Nightly Getting this exception when removing a bean as a listener: java.util.ConcurrentModificationException at java.util.AbstractList$Itr.checkForComodification(AbstractList.java:462) at java.util.AbstractList$Itr.next(AbstractList.java:433) at java.util.AbstractCollection.remove(AbstractCollection.java:268) at org.apache.myfaces.lifecycle.LifecycleImpl.removePhaseListener(LifecycleImpl.java:411) at com.erac.riskmgmt.ice.web.AbstractPageBean.afterPhase(AbstractPageBean.java:128) The method call at AbstractPageBean:128 is getLifecycle().removePhaseListener(this); protected Lifecycle getLifecycle() { String lifecycleId = getExternalContext().getInitParameter(javax.faces.LIFECYCLE_ID); if ((lifecycleId == null) || (lifecycleId.length() == 0)) { lifecycleId = LifecycleFactory.DEFAULT_LIFECYCLE; } LifecycleFactory lifecycleFactory = (LifecycleFactory) FactoryFinder.getFactory( FactoryFinder.LIFECYCLE_FACTORY); return lifecycleFactory.getLifecycle(lifecycleId); } Basically what's happening from a request perspective is that we have a custom ViewHandler that creates the backing bean that's registered for a given view id (custom registry using a HashMap that's created as a managed bean and maintained manually in faces-config). When the backing bean is created it adds itself as a listener and when the AFTER RENDER_RESPONSE is executed the bean removes itself as a listener (as above at line 128 in AbstractPageBean). No problems are observed in low-load situations, but when we sent the application to benchmarking simulating ~200 concurrent users we noticed this problem. It looks like easiest fix is to synchronize the array list on adding and removing listeners (currently we've worked around this by using an external lock to synchronize add/remove calls from our AbstractPageBean). However, It looks like there is also a potential problem with the call to getPhaseListeners() in that it creates a cached array that's later copied back into a *new* ArrayList in addPhaseListener(...) and removePhaseListener(...). Since there is no synchronization if someone called getPhaseListeners() and then two/N different threads tried to add listeners 1..N listeners could be lost (all would check for a null _phaseListenerList and multiple threads could potentially attempt to create a new _phaseListenerList and add/remove the PhaseListener) -- of course the converse problem would be that two/N different threads tried to remove phase listeners and the 1..N listeners would not be removed (they would be recopied in on another thread). What would simplify this whole business greatly would be to remove the cached list and simply synchronize on the ArrayList on the add/remove/getListeners: public void addPhaseListener(PhaseListener phaseListener) { if(phaseListener == null) { throw new NullPointerException(PhaseListener must not be null.); } // create _phaseListenerList at class scope -- so no more null-checks for it synchronized(_phaseListenerList) { _phaseListenerList.add(phaseListener); } } public void removePhaseListener(PhaseListener phaseListener) { synchronized(_phaseListenerList) { _phaseListenerList.remove(phaseListener); } } public PhaseListener[] getPhaseListeners() { synchronized(_phaseListenerList) { return (PhaseListener[])_phaseListenerList.toArray(new PhaseListener[_phaseListenerList.size()]); } } -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MYFACES-1148) Weblogic Classloader problems during development (FactoryFinder)
[ http://issues.apache.org/jira/browse/MYFACES-1148?page=comments#action_12367216 ] Adam Brod commented on MYFACES-1148: Ok, I did some additional debugging into the Weblogic ClassLoader. The root of the problem stems from the weblogic Weblogic drops the classloader and then reinitiales the webapp. 1) Weblogic calls destroy() on FacesServlet (old classloader) 2) Weblogic takes all of the variables in the ServletContext. serializes them and then deserializes them into the new classloader 3) Weblogic calls init() on FacesServlet (new classloader) Since none of the JSF objects that are stored in the ServletContext are serializable, weblogic just silently deletes them. That's why FacesServlet.init() throws the IllegalStateException - it can't find any of the variables that were set up by the StartupServletContextListener since they didn't make the transition to the new classloader. From what I know, I only see a few options: 1) Make all of the objects stored in the ServletContext serializable 2) Put in a hook in FacesServlet.init() such that if the factories aren't there, it reloads them 3) Put some other ServletContextListener or ServletContextAttributeListener(s) to listen for events and reload the factories 4) Put some ServletFilter in that before any Faces request is processed checks to ensure everything is initialized. If it is initialized, then it does nothing. Otherwise, it initializes the required objects. I have a hacked together version of this working so-so in my local dev env now. I'm not sure of the best way is to move forward on this issue. It is obviously very tricky and could get very messy with all of this Weblogic-Servlet-specific initialization code. However, since Weblogic is a major appserver, I really hope the issue won't be dropped. Weblogic Classloader problems during development (FactoryFinder) Key: MYFACES-1148 URL: http://issues.apache.org/jira/browse/MYFACES-1148 Project: MyFaces Core Type: Bug Components: Implementation Versions: 1.1.1 Environment: Weblogic 9.0, 8.1, etc. Windows XP Pro sp2. Reporter: Adam Brod Like most weblogic users, our team develops using the exploded war format. That means that each time we deploy a new version of a class, weblogic automatically picks it up. The way Weblogic implements this is that when it detects a new class, it drops the classloader for that class, as well as the Servlet and all helper classes that are loaded by the Servlet. That means FacesServlet is dropped and reloaded. The problem is that FactoryFinder stores the Factory classes in a Map where the key is the current classloader. That works fine until I deploy a new class to my webapp. At that point, weblogic drops the classloader and creates a new one with the new class definition. Now when FacesServlet.init() calls FactoryFinder.getFactory() (in the new classloader), an IllegalStateException is generated (see below) because the current classloader is not a valid key for the _registeredFactoryNames Map. One possible solution that I can see to this is to change the key for the Factory map to use the ServletContext's getServletContextName() as the key. I am 95% sure this same problem exists in Weblogic 7.0, 8.1 and 9.1 since they all use almost the same Servlet redeployment mechanism. I have only tried this on Weblogic 9.0. Feb 20, 2006 5:38:07 PM EST Error HTTP BEA-101017 [EMAIL PROTECTED] - name: 'ma-web-1.0-SNAPSHOT ', context-path: '/ma'] Root cause of ServletException. java.lang.IllegalStateException: No Factories configured for this Application - typically this is because a context listener is not setup in yo ur web.xml. A typical config looks like this; listener listener-classorg.apache.myfaces.webapp.StartupServletContextListener/listener-class /listener at javax.faces.FactoryFinder.getFactory(FactoryFinder.java:84) at javax.faces.webapp.FacesServlet.init(FacesServlet.java:84) at weblogic.servlet.internal.StubSecurityHelper$ServletInitAction.run(StubSecurityHelper.java:265) at weblogic.security.acl.internal.AuthenticatedSubject.doAs(AuthenticatedSubject.java:321) at weblogic.security.service.SecurityManager.runAs(SecurityManager.java:121) at weblogic.servlet.internal.StubSecurityHelper.createServlet(StubSecurityHelper.java:61) at weblogic.servlet.internal.StubLifecycleHelper.createOneInstance(StubLifecycleHelper.java:58) at weblogic.servlet.internal.StubLifecycleHelper.init(StubLifecycleHelper.java:48) at weblogic.servlet.internal.ServletStubImpl.prepareServlet(ServletStubImpl.java:502) at weblogic.servlet.internal.ServletStubImpl.checkForReload(ServletStubImpl.java:429) at
Re: New JIRA: Tobago
Wow, cool! Thank you! I'm going to update the issue tracker URL in our POM as soon as I am home. Regards, Arvid Sean Schofield wrote: I also added a new JIRA instance for Tobago. I moved all of the Tobago issues over from the original JIRA. I believe committers can change the versions and add components so the Tobago team should have everything they need to manage this. Let me or Manfred know if you need JIRA admin help. Sean
Re: JIRA Changes
Thanks Sean! I have moved all of the tomahawk issues (at least the ones marked tomahawk in the original jira) to the new JIRA project. JIRA is also smart enough to map the old issue numbers with new issue numbers. So if you try to navigate to MYFACES-975[1], JIRA knows enough to redirect you to TOMAHAWK-96. this is cool :-) I have not moved the sandbox stuff yet. My thinking is that sandbox components should be part of the Tomahawk JIRA since they are part of the same maven subproject and they will eventually be promoted to Tomahawk. They will also always have the same versions as Tomahawk. If I get some +1's I will move these also. I am +1 on having sandox stuff under tomahawk. for the reasons you pointed out -maven subproject -promotion Sounds reasonable to me -Matthias I haven't changed the permissions or notification at all. We can talk about that at a future point once we get everything into the right spot. Take a look and let me know what you think. Sean [1] https://issues.apache.org/jira/browse/MYFACES-975 -- Matthias Wessendorf Zülpicher Wall 12, 239 50674 Köln http://www.wessendorf.net mwessendorf-at-gmail-dot-com
Re: Maven2 build failure with current trunk?
On 2/21/06, Sean Schofield [EMAIL PROTECTED] wrote: Craig,You should be ok now.Let us know if you still have problems.Still have problems :-(. But now at least it is in more familiar territory. The first failure I see is in HtmlDataTableTest ... in the setUp() method, it is calling RenderKitFactory.addRenderKit() to add the HTML_BASIC renderkit ... this causes IllegalArgumentException because that RenderKit is already registered. Shale's test framework sets up that registration for you when you instantiate MockRenderKitFactory, so this kind of thing would need to be pulled (or we could consider NOT registering the initial renderkit by default, and do that manually in AbstractJsfTestCase). SeanCraig
Re: Don't disable unit tests before a checkin
-Dmaven.test.failure.ignore=true is another that should be avoided. Dennis Byrne -Original Message- From: Bernd Bohmann [mailto:[EMAIL PROTECTED] Sent: Tuesday, February 21, 2006 02:45 AM To: 'MyFaces Development' Subject: Don't disable unit tests before a checkin Hello, don't call mvn with -Dmaven.test.skip=true if you are going to checkin something, please. Regards Bernd -- Dipl.-Ing. Bernd Bohmann - Atanion GmbH - Software Development Bismarckstr. 13, 26122 Oldenburg, http://www.atanion.com phone: +49 441 4082312, mobile: +49 173 8839471, fax: +49 441 4082333
Re: JIRA Changes
Thanks Sean for the hard work, +1 from me to put sandox under tomahawk. Regards, Bruno On 2/21/06, Matthias Wessendorf [EMAIL PROTECTED] wrote: Thanks Sean! I have moved all of the tomahawk issues (at least the ones marked tomahawk in the original jira) to the new JIRA project. JIRA is also smart enough to map the old issue numbers with new issue numbers. So if you try to navigate to MYFACES-975[1], JIRA knows enough to redirect you to TOMAHAWK-96. this is cool :-) I have not moved the sandbox stuff yet. My thinking is that sandbox components should be part of the Tomahawk JIRA since they are part of the same maven subproject and they will eventually be promoted to Tomahawk. They will also always have the same versions as Tomahawk. If I get some +1's I will move these also. I am +1 on having sandox stuff under tomahawk. for the reasons you pointed out -maven subproject -promotion Sounds reasonable to me -Matthias I haven't changed the permissions or notification at all. We can talk about that at a future point once we get everything into the right spot. Take a look and let me know what you think. Sean [1] https://issues.apache.org/jira/browse/MYFACES-975 -- Matthias Wessendorf Zülpicher Wall 12, 239 50674 Köln http://www.wessendorf.net mwessendorf-at-gmail-dot-com
Re: JIRA Changes
may be a silly question, but how to change / move a bug to a special component e.g. from other - tree2 Thanks, Matthias On 2/21/06, Bruno Aranda [EMAIL PROTECTED] wrote: Thanks Sean for the hard work, +1 from me to put sandox under tomahawk. Regards, Bruno On 2/21/06, Matthias Wessendorf [EMAIL PROTECTED] wrote: Thanks Sean! I have moved all of the tomahawk issues (at least the ones marked tomahawk in the original jira) to the new JIRA project. JIRA is also smart enough to map the old issue numbers with new issue numbers. So if you try to navigate to MYFACES-975[1], JIRA knows enough to redirect you to TOMAHAWK-96. this is cool :-) I have not moved the sandbox stuff yet. My thinking is that sandbox components should be part of the Tomahawk JIRA since they are part of the same maven subproject and they will eventually be promoted to Tomahawk. They will also always have the same versions as Tomahawk. If I get some +1's I will move these also. I am +1 on having sandox stuff under tomahawk. for the reasons you pointed out -maven subproject -promotion Sounds reasonable to me -Matthias I haven't changed the permissions or notification at all. We can talk about that at a future point once we get everything into the right spot. Take a look and let me know what you think. Sean [1] https://issues.apache.org/jira/browse/MYFACES-975 -- Matthias Wessendorf Zülpicher Wall 12, 239 50674 Köln http://www.wessendorf.net mwessendorf-at-gmail-dot-com -- Matthias Wessendorf Zülpicher Wall 12, 239 50674 Köln http://www.wessendorf.net mwessendorf-at-gmail-dot-com
Re: JIRA Changes
Just click on Edit this issue in the sidebar under Operations and assign a new component. Regards, Arvid Matthias Wessendorf wrote: may be a silly question, but how to change / move a bug to a special component e.g. from other - tree2 Thanks, Matthias On 2/21/06, Bruno Aranda [EMAIL PROTECTED] wrote: Thanks Sean for the hard work, +1 from me to put sandox under tomahawk. Regards, Bruno On 2/21/06, Matthias Wessendorf [EMAIL PROTECTED] wrote: Thanks Sean! I have moved all of the tomahawk issues (at least the ones marked tomahawk in the original jira) to the new JIRA project. JIRA is also smart enough to map the old issue numbers with new issue numbers. So if you try to navigate to MYFACES-975[1], JIRA knows enough to redirect you to TOMAHAWK-96. this is cool :-) I have not moved the sandbox stuff yet. My thinking is that sandbox components should be part of the Tomahawk JIRA since they are part of the same maven subproject and they will eventually be promoted to Tomahawk. They will also always have the same versions as Tomahawk. If I get some +1's I will move these also. I am +1 on having sandox stuff under tomahawk. for the reasons you pointed out -maven subproject -promotion Sounds reasonable to me -Matthias I haven't changed the permissions or notification at all. We can talk about that at a future point once we get everything into the right spot. Take a look and let me know what you think. Sean [1] https://issues.apache.org/jira/browse/MYFACES-975 -- Matthias Wessendorf Zülpicher Wall 12, 239 50674 Köln http://www.wessendorf.net mwessendorf-at-gmail-dot-com -- Matthias Wessendorf Zülpicher Wall 12, 239 50674 Köln http://www.wessendorf.net mwessendorf-at-gmail-dot-com
Re: JIRA Changes
thanks On 2/21/06, Arvid Hülsebus [EMAIL PROTECTED] wrote: Just click on Edit this issue in the sidebar under Operations and assign a new component. Regards, Arvid Matthias Wessendorf wrote: may be a silly question, but how to change / move a bug to a special component e.g. from other - tree2 Thanks, Matthias On 2/21/06, Bruno Aranda [EMAIL PROTECTED] wrote: Thanks Sean for the hard work, +1 from me to put sandox under tomahawk. Regards, Bruno On 2/21/06, Matthias Wessendorf [EMAIL PROTECTED] wrote: Thanks Sean! I have moved all of the tomahawk issues (at least the ones marked tomahawk in the original jira) to the new JIRA project. JIRA is also smart enough to map the old issue numbers with new issue numbers. So if you try to navigate to MYFACES-975[1], JIRA knows enough to redirect you to TOMAHAWK-96. this is cool :-) I have not moved the sandbox stuff yet. My thinking is that sandbox components should be part of the Tomahawk JIRA since they are part of the same maven subproject and they will eventually be promoted to Tomahawk. They will also always have the same versions as Tomahawk. If I get some +1's I will move these also. I am +1 on having sandox stuff under tomahawk. for the reasons you pointed out -maven subproject -promotion Sounds reasonable to me -Matthias I haven't changed the permissions or notification at all. We can talk about that at a future point once we get everything into the right spot. Take a look and let me know what you think. Sean [1] https://issues.apache.org/jira/browse/MYFACES-975 -- Matthias Wessendorf Zülpicher Wall 12, 239 50674 Köln http://www.wessendorf.net mwessendorf-at-gmail-dot-com -- Matthias Wessendorf Zülpicher Wall 12, 239 50674 Köln http://www.wessendorf.net mwessendorf-at-gmail-dot-com -- Matthias Wessendorf Zülpicher Wall 12, 239 50674 Köln http://www.wessendorf.net mwessendorf-at-gmail-dot-com
Re: Don't disable unit tests before a checkin
Is that valid for right now? As the tree-tests are failing? regards, Martin On 2/21/06, Dennis Byrne [EMAIL PROTECTED] wrote: -Dmaven.test.failure.ignore=true is another that should be avoided. Dennis Byrne -Original Message- From: Bernd Bohmann [mailto:[EMAIL PROTECTED] Sent: Tuesday, February 21, 2006 02:45 AM To: 'MyFaces Development' Subject: Don't disable unit tests before a checkin Hello, don't call mvn with -Dmaven.test.skip=true if you are going to checkin something, please. Regards Bernd -- Dipl.-Ing. Bernd Bohmann - Atanion GmbH - Software Development Bismarckstr. 13, 26122 Oldenburg, http://www.atanion.com phone: +49 441 4082312, mobile: +49 173 8839471, fax: +49 441 4082333 -- http://www.irian.at Your JSF powerhouse - JSF Consulting, Development and Courses in English and German Professional Support for Apache MyFaces
Re: JIRA Changes
FYI we disabled email notification to the list when you edit an issue (change the name, description, version or component.) This will cut down on some our JIRA traffic. Also, no emails to the list when moving an issue between projects. The issue reporter, the assignee and watchers will still be notified. Sean On 2/21/06, Matthias Wessendorf [EMAIL PROTECTED] wrote: thanks On 2/21/06, Arvid Hülsebus [EMAIL PROTECTED] wrote: Just click on Edit this issue in the sidebar under Operations and assign a new component. Regards, Arvid Matthias Wessendorf wrote: may be a silly question, but how to change / move a bug to a special component e.g. from other - tree2 Thanks, Matthias On 2/21/06, Bruno Aranda [EMAIL PROTECTED] wrote: Thanks Sean for the hard work, +1 from me to put sandox under tomahawk. Regards, Bruno On 2/21/06, Matthias Wessendorf [EMAIL PROTECTED] wrote: Thanks Sean! I have moved all of the tomahawk issues (at least the ones marked tomahawk in the original jira) to the new JIRA project. JIRA is also smart enough to map the old issue numbers with new issue numbers. So if you try to navigate to MYFACES-975[1], JIRA knows enough to redirect you to TOMAHAWK-96. this is cool :-) I have not moved the sandbox stuff yet. My thinking is that sandbox components should be part of the Tomahawk JIRA since they are part of the same maven subproject and they will eventually be promoted to Tomahawk. They will also always have the same versions as Tomahawk. If I get some +1's I will move these also. I am +1 on having sandox stuff under tomahawk. for the reasons you pointed out -maven subproject -promotion Sounds reasonable to me -Matthias I haven't changed the permissions or notification at all. We can talk about that at a future point once we get everything into the right spot. Take a look and let me know what you think. Sean [1] https://issues.apache.org/jira/browse/MYFACES-975 -- Matthias Wessendorf Zülpicher Wall 12, 239 50674 Köln http://www.wessendorf.net mwessendorf-at-gmail-dot-com -- Matthias Wessendorf Zülpicher Wall 12, 239 50674 Köln http://www.wessendorf.net mwessendorf-at-gmail-dot-com -- Matthias Wessendorf Zülpicher Wall 12, 239 50674 Köln http://www.wessendorf.net mwessendorf-at-gmail-dot-com
Re: Maven2 build failure with current trunk?
Sounds like issue #38294 in bugzilla that Dennis was talking about. He has a proposed solution but I didn't commit it yet because I cannot reproduce. It would seem to be JDK specific b/c I can build just fine and so can our continuum server. Sean On 2/21/06, Craig McClanahan [EMAIL PROTECTED] wrote: On 2/21/06, Sean Schofield [EMAIL PROTECTED] wrote: Craig, You should be ok now. Let us know if you still have problems. Still have problems :-(. But now at least it is in more familiar territory. The first failure I see is in HtmlDataTableTest ... in the setUp() method, it is calling RenderKitFactory.addRenderKit() to add the HTML_BASIC renderkit ... this causes IllegalArgumentException because that RenderKit is already registered. Shale's test framework sets up that registration for you when you instantiate MockRenderKitFactory, so this kind of thing would need to be pulled (or we could consider NOT registering the initial renderkit by default, and do that manually in AbstractJsfTestCase). Sean Craig
Re: Don't disable unit tests before a checkin
Tree tests should not be failing. Try removing the shale snapshot from your local maven repos and try again. This worked for Dennis (and suggests a problem with either maven or these snapshots.) Sean On 2/21/06, Martin Marinschek [EMAIL PROTECTED] wrote: Is that valid for right now? As the tree-tests are failing? regards, Martin On 2/21/06, Dennis Byrne [EMAIL PROTECTED] wrote: -Dmaven.test.failure.ignore=true is another that should be avoided. Dennis Byrne -Original Message- From: Bernd Bohmann [mailto:[EMAIL PROTECTED] Sent: Tuesday, February 21, 2006 02:45 AM To: 'MyFaces Development' Subject: Don't disable unit tests before a checkin Hello, don't call mvn with -Dmaven.test.skip=true if you are going to checkin something, please. Regards Bernd -- Dipl.-Ing. Bernd Bohmann - Atanion GmbH - Software Development Bismarckstr. 13, 26122 Oldenburg, http://www.atanion.com phone: +49 441 4082312, mobile: +49 173 8839471, fax: +49 441 4082333 -- http://www.irian.at Your JSF powerhouse - JSF Consulting, Development and Courses in English and German Professional Support for Apache MyFaces
Re: Don't disable unit tests before a checkin
Thanks Sean! regards, Martin On 2/21/06, Sean Schofield [EMAIL PROTECTED] wrote: Tree tests should not be failing. Try removing the shale snapshot from your local maven repos and try again. This worked for Dennis (and suggests a problem with either maven or these snapshots.) Sean On 2/21/06, Martin Marinschek [EMAIL PROTECTED] wrote: Is that valid for right now? As the tree-tests are failing? regards, Martin On 2/21/06, Dennis Byrne [EMAIL PROTECTED] wrote: -Dmaven.test.failure.ignore=true is another that should be avoided. Dennis Byrne -Original Message- From: Bernd Bohmann [mailto:[EMAIL PROTECTED] Sent: Tuesday, February 21, 2006 02:45 AM To: 'MyFaces Development' Subject: Don't disable unit tests before a checkin Hello, don't call mvn with -Dmaven.test.skip=true if you are going to checkin something, please. Regards Bernd -- Dipl.-Ing. Bernd Bohmann - Atanion GmbH - Software Development Bismarckstr. 13, 26122 Oldenburg, http://www.atanion.com phone: +49 441 4082312, mobile: +49 173 8839471, fax: +49 441 4082333 -- http://www.irian.at Your JSF powerhouse - JSF Consulting, Development and Courses in English and German Professional Support for Apache MyFaces -- http://www.irian.at Your JSF powerhouse - JSF Consulting, Development and Courses in English and German Professional Support for Apache MyFaces
Re: Don't disable unit tests before a checkin
I had the same problem last night. Y0u are getting a classcastexception ? If so, try deleting the shale-test dir in your local repo and doing mvn install. @sean - see, I'm not crazy. Dennis Byrne -Original Message- From: Martin Marinschek [mailto:[EMAIL PROTECTED] Sent: Tuesday, February 21, 2006 12:14 PM To: 'MyFaces Development' Subject: Re: Don't disable unit tests before a checkin Is that valid for right now? As the tree-tests are failing? regards, Martin On 2/21/06, Dennis Byrne [EMAIL PROTECTED] wrote: -Dmaven.test.failure.ignore=true is another that should be avoided. Dennis Byrne -Original Message- From: Bernd Bohmann [mailto:[EMAIL PROTECTED] Sent: Tuesday, February 21, 2006 02:45 AM To: 'MyFaces Development' Subject: Don't disable unit tests before a checkin Hello, don't call mvn with -Dmaven.test.skip=true if you are going to checkin something, please. Regards Bernd -- Dipl.-Ing. Bernd Bohmann - Atanion GmbH - Software Development Bismarckstr. 13, 26122 Oldenburg, http://www.atanion.com phone: +49 441 4082312, mobile: +49 173 8839471, fax: +49 441 4082333 -- http://www.irian.at Your JSF powerhouse - JSF Consulting, Development and Courses in English and German Professional Support for Apache MyFaces
Re: JIRA Changes
Ah, I see. Thanks for the informations. I'll help to *edit* some issues. So for sandbox, we just create a *component* inside of TOMAHAWK and *store* all issue under this label, right ? -Matthias On 2/21/06, Sean Schofield [EMAIL PROTECTED] wrote: FYI we disabled email notification to the list when you edit an issue (change the name, description, version or component.) This will cut down on some our JIRA traffic. Also, no emails to the list when moving an issue between projects. The issue reporter, the assignee and watchers will still be notified. Sean On 2/21/06, Matthias Wessendorf [EMAIL PROTECTED] wrote: thanks On 2/21/06, Arvid Hülsebus [EMAIL PROTECTED] wrote: Just click on Edit this issue in the sidebar under Operations and assign a new component. Regards, Arvid Matthias Wessendorf wrote: may be a silly question, but how to change / move a bug to a special component e.g. from other - tree2 Thanks, Matthias On 2/21/06, Bruno Aranda [EMAIL PROTECTED] wrote: Thanks Sean for the hard work, +1 from me to put sandox under tomahawk. Regards, Bruno On 2/21/06, Matthias Wessendorf [EMAIL PROTECTED] wrote: Thanks Sean! I have moved all of the tomahawk issues (at least the ones marked tomahawk in the original jira) to the new JIRA project. JIRA is also smart enough to map the old issue numbers with new issue numbers. So if you try to navigate to MYFACES-975[1], JIRA knows enough to redirect you to TOMAHAWK-96. this is cool :-) I have not moved the sandbox stuff yet. My thinking is that sandbox components should be part of the Tomahawk JIRA since they are part of the same maven subproject and they will eventually be promoted to Tomahawk. They will also always have the same versions as Tomahawk. If I get some +1's I will move these also. I am +1 on having sandox stuff under tomahawk. for the reasons you pointed out -maven subproject -promotion Sounds reasonable to me -Matthias I haven't changed the permissions or notification at all. We can talk about that at a future point once we get everything into the right spot. Take a look and let me know what you think. Sean [1] https://issues.apache.org/jira/browse/MYFACES-975 -- Matthias Wessendorf Zülpicher Wall 12, 239 50674 Köln http://www.wessendorf.net mwessendorf-at-gmail-dot-com -- Matthias Wessendorf Zülpicher Wall 12, 239 50674 Köln http://www.wessendorf.net mwessendorf-at-gmail-dot-com -- Matthias Wessendorf Zülpicher Wall 12, 239 50674 Köln http://www.wessendorf.net mwessendorf-at-gmail-dot-com -- Matthias Wessendorf Zülpicher Wall 12, 239 50674 Köln http://www.wessendorf.net mwessendorf-at-gmail-dot-com
Re: Don't disable unit tests before a checkin
I suspect this is a maven 1 or struts snapshot issue and not a bug in maven2. On 2/21/06, Martin Marinschek [EMAIL PROTECTED] wrote: Thanks Sean! regards, Martin On 2/21/06, Sean Schofield [EMAIL PROTECTED] wrote: Tree tests should not be failing. Try removing the shale snapshot from your local maven repos and try again. This worked for Dennis (and suggests a problem with either maven or these snapshots.) Sean On 2/21/06, Martin Marinschek [EMAIL PROTECTED] wrote: Is that valid for right now? As the tree-tests are failing? regards, Martin On 2/21/06, Dennis Byrne [EMAIL PROTECTED] wrote: -Dmaven.test.failure.ignore=true is another that should be avoided. Dennis Byrne -Original Message- From: Bernd Bohmann [mailto:[EMAIL PROTECTED] Sent: Tuesday, February 21, 2006 02:45 AM To: 'MyFaces Development' Subject: Don't disable unit tests before a checkin Hello, don't call mvn with -Dmaven.test.skip=true if you are going to checkin something, please. Regards Bernd -- Dipl.-Ing. Bernd Bohmann - Atanion GmbH - Software Development Bismarckstr. 13, 26122 Oldenburg, http://www.atanion.com phone: +49 441 4082312, mobile: +49 173 8839471, fax: +49 441 4082333 -- http://www.irian.at Your JSF powerhouse - JSF Consulting, Development and Courses in English and German Professional Support for Apache MyFaces -- http://www.irian.at Your JSF powerhouse - JSF Consulting, Development and Courses in English and German Professional Support for Apache MyFaces
Re: JIRA Changes
I was thinking of creating one component for each sandbox. So people who are interested in a particular component can easily see (and maybe fix) those issues. Perhaps a * character at the end of the component name to remind us this is sandbox? Sean On 2/21/06, Matthias Wessendorf [EMAIL PROTECTED] wrote: Ah, I see. Thanks for the informations. I'll help to *edit* some issues. So for sandbox, we just create a *component* inside of TOMAHAWK and *store* all issue under this label, right ? -Matthias On 2/21/06, Sean Schofield [EMAIL PROTECTED] wrote: FYI we disabled email notification to the list when you edit an issue (change the name, description, version or component.) This will cut down on some our JIRA traffic. Also, no emails to the list when moving an issue between projects. The issue reporter, the assignee and watchers will still be notified. Sean On 2/21/06, Matthias Wessendorf [EMAIL PROTECTED] wrote: thanks On 2/21/06, Arvid Hülsebus [EMAIL PROTECTED] wrote: Just click on Edit this issue in the sidebar under Operations and assign a new component. Regards, Arvid Matthias Wessendorf wrote: may be a silly question, but how to change / move a bug to a special component e.g. from other - tree2 Thanks, Matthias On 2/21/06, Bruno Aranda [EMAIL PROTECTED] wrote: Thanks Sean for the hard work, +1 from me to put sandox under tomahawk. Regards, Bruno On 2/21/06, Matthias Wessendorf [EMAIL PROTECTED] wrote: Thanks Sean! I have moved all of the tomahawk issues (at least the ones marked tomahawk in the original jira) to the new JIRA project. JIRA is also smart enough to map the old issue numbers with new issue numbers. So if you try to navigate to MYFACES-975[1], JIRA knows enough to redirect you to TOMAHAWK-96. this is cool :-) I have not moved the sandbox stuff yet. My thinking is that sandbox components should be part of the Tomahawk JIRA since they are part of the same maven subproject and they will eventually be promoted to Tomahawk. They will also always have the same versions as Tomahawk. If I get some +1's I will move these also. I am +1 on having sandox stuff under tomahawk. for the reasons you pointed out -maven subproject -promotion Sounds reasonable to me -Matthias I haven't changed the permissions or notification at all. We can talk about that at a future point once we get everything into the right spot. Take a look and let me know what you think. Sean [1] https://issues.apache.org/jira/browse/MYFACES-975 -- Matthias Wessendorf Zülpicher Wall 12, 239 50674 Köln http://www.wessendorf.net mwessendorf-at-gmail-dot-com -- Matthias Wessendorf Zülpicher Wall 12, 239 50674 Köln http://www.wessendorf.net mwessendorf-at-gmail-dot-com -- Matthias Wessendorf Zülpicher Wall 12, 239 50674 Köln http://www.wessendorf.net mwessendorf-at-gmail-dot-com -- Matthias Wessendorf Zülpicher Wall 12, 239 50674 Köln http://www.wessendorf.net mwessendorf-at-gmail-dot-com
Re: Refactor Commons to org.apache.myfaces.commons ?
Maven2 is even smarter that you might realize. :-)(see below)On 2/20/06, Sean Schofield [EMAIL PROTECTED] wrote:Wow that seems really complicated.I have serious concerns about last minute search and replace on the source code.There's got to be aeasier solution.Until we started down the maven path we were finewith the way it is.Lets re-examine why we are considering this inthe first place. Manfred's scenario ...Scenario:1. We release commons-1.1.2 + core 1.1.2 (core 1.1.2 depends on commons-1.1.2)2. days go by...3. We release commons-1.1.3 (because there where significant changes) + tomahawk 1.1.3 (which depends on commons-1.1.3)So, there are now the following official releases out there:commons-1.1.2commons-1.1.3core-1.1.2tomahawk-1.1.3User happy starts his brandnew Maven project unlucky, decides to use the latest stable releases of everything and defines the followingdependencies:XY depends on myfaces-api 1.1.2 (scope compile)XY depends on myfaces-impl 1.1.2 (scope runtime)XY depends on tomahawk 1.1.3 (scope compile)Now he builds the WAR. Guess what he ends up with?WEB-INF/lib/myfaces-api-1.1.2.jarWEB-INF/lib/myfaces-commons-1.1.2.jarWEB-INF/lib/myfaces-commons-1.1.3.jarWEB-INF/lib/myfaces- impl-1.1.2.jarWEB-INF/lib/myfaces-tomahawk-1.1.3.jarOnly one version of commons will be selected, so either commons-1.1.2 or commons-1.1.3 but not both, as long as both versions have the same groupId and artifactId in the Maven2 repository. I'm not totally certain of the exact selection algorithm used by Maven2 to choose the winning version, but I believe selecting the latest version makes the most sense. Kind Regards,John Fallows.I think we can solve this usecase without resorting to last minute code refactoring by maven, or even worse, changing bytecode around.Ijust don't think those solutions are necessary.One solution could be is that we make the scope of the commonsdependency in core and tomahawk to be provided.That way its not transitive and you don't end up with two versions of the commons jarin your WAR.What that means is that you need to declare explicitly acommons dependency in your project as well as core and/or tomahawk. In this case you would just say your project depends on commonsversion 1.1.3.Everything will be fine as long as 1.1.3 does notbreak backwards compatability with an earlier version of the core.Wecan easily test this when we release tomahawk and if it does break backwards compatability, we can release a newer version of the core aswell.Its not ideal but its much better then the other alternatives we areconsidering.I think we carefully document and explain this on the website and include instructions and considerations for those buildingwith maven or using myfaces implementation in their J2EE containers.SeanOn 2/18/06, Manfred Geiler [EMAIL PROTECTED] wrote: As Martin already has mentioned, I'm more and more convinced too, that repackaging commons for impl is the only solution that will make as carefree in the long run. Though, I do not agree that it is necessary or advantageous to repackage commons for all component libs (tomahawk, tobago, adffaces). This would bring commons far away from the original idea of having a Jakarta commons like JSF library with goodies and convenient base classes for custom components. Yes, people will probably have conflicts. But the release cycles of our component libs should be fast enough and commons should become stable enough, so that this is no longer a problem. MyFaces-Core (ie. impl) is different insofar as* we want to keep release cycles at a minimum * it will become integrated part of containers (already shipped with JBoss 4.x), or* people make them part of their containers by sharing myfaces-api.jar and myfaces-impl.jar in the containers common/lib or shared/lib dir. The last two points also will have influence on how people will configure their own Maven projects: provided dependency on myfaces-api.jar and myfaces-impl.jar of the version that was shipped with (or is integrated in) the container. People will behave conservative in changing their container environment and behave liberal when using the newest component lib. However, as soon as we have a repackaging solution, it is easy enough to use it not only for impl. So, let's discuss repackaging in general first and postpone the question of using repackaged commons lib for tomahawk et al. for a while, ok? Here is my idea for a (not-so-high-sophisticated but) easy repackaging solution: 1. First of all we refactor Commons to org.apache.myfaces.commons.* (we already have an agreement on this) 2. Next we create a sub-project in commons. Working title intermediate-commons-impl. = This project's outcome will be the intermediate-commons-impl.jar file with all commons classes auto-repackaged to org.apache.myfaces.commons.impl.* (like proposed by Simon). = This jar file will not be shipped or included in any assembly (therefore intermediate). It only serves as the Maven-way medium to
Re: JIRA Changes
On 2/21/06, Sean Schofield [EMAIL PROTECTED] wrote: I was thinking of creating one component for each sandbox. So people who are interested in a particular component can easily see (and maybe makes sense fix) those issues. Perhaps a * character at the end of the component name to remind us this is sandbox? +1 Sean On 2/21/06, Matthias Wessendorf [EMAIL PROTECTED] wrote: Ah, I see. Thanks for the informations. I'll help to *edit* some issues. So for sandbox, we just create a *component* inside of TOMAHAWK and *store* all issue under this label, right ? -Matthias On 2/21/06, Sean Schofield [EMAIL PROTECTED] wrote: FYI we disabled email notification to the list when you edit an issue (change the name, description, version or component.) This will cut down on some our JIRA traffic. Also, no emails to the list when moving an issue between projects. The issue reporter, the assignee and watchers will still be notified. Sean On 2/21/06, Matthias Wessendorf [EMAIL PROTECTED] wrote: thanks On 2/21/06, Arvid Hülsebus [EMAIL PROTECTED] wrote: Just click on Edit this issue in the sidebar under Operations and assign a new component. Regards, Arvid Matthias Wessendorf wrote: may be a silly question, but how to change / move a bug to a special component e.g. from other - tree2 Thanks, Matthias On 2/21/06, Bruno Aranda [EMAIL PROTECTED] wrote: Thanks Sean for the hard work, +1 from me to put sandox under tomahawk. Regards, Bruno On 2/21/06, Matthias Wessendorf [EMAIL PROTECTED] wrote: Thanks Sean! I have moved all of the tomahawk issues (at least the ones marked tomahawk in the original jira) to the new JIRA project. JIRA is also smart enough to map the old issue numbers with new issue numbers. So if you try to navigate to MYFACES-975[1], JIRA knows enough to redirect you to TOMAHAWK-96. this is cool :-) I have not moved the sandbox stuff yet. My thinking is that sandbox components should be part of the Tomahawk JIRA since they are part of the same maven subproject and they will eventually be promoted to Tomahawk. They will also always have the same versions as Tomahawk. If I get some +1's I will move these also. I am +1 on having sandox stuff under tomahawk. for the reasons you pointed out -maven subproject -promotion Sounds reasonable to me -Matthias I haven't changed the permissions or notification at all. We can talk about that at a future point once we get everything into the right spot. Take a look and let me know what you think. Sean [1] https://issues.apache.org/jira/browse/MYFACES-975 -- Matthias Wessendorf Zülpicher Wall 12, 239 50674 Köln http://www.wessendorf.net mwessendorf-at-gmail-dot-com -- Matthias Wessendorf Zülpicher Wall 12, 239 50674 Köln http://www.wessendorf.net mwessendorf-at-gmail-dot-com -- Matthias Wessendorf Zülpicher Wall 12, 239 50674 Köln http://www.wessendorf.net mwessendorf-at-gmail-dot-com -- Matthias Wessendorf Zülpicher Wall 12, 239 50674 Köln http://www.wessendorf.net mwessendorf-at-gmail-dot-com -- Matthias Wessendorf Zülpicher Wall 12, 239 50674 Köln http://www.wessendorf.net mwessendorf-at-gmail-dot-com
Re: Don't disable unit tests before a checkin
@sean - see, I'm not crazy. Nobody said you were ;-) So why is the shale snapshot dependency not updating? Maybe it has something to do with the hack to get it to work with maven2? Dennis Byrne Sean
Re: JIRA Changes
The only thing I worry about is searching on a * char. Maybe a (sbx) or something? On 2/21/06, Matthias Wessendorf [EMAIL PROTECTED] wrote: On 2/21/06, Sean Schofield [EMAIL PROTECTED] wrote: I was thinking of creating one component for each sandbox. So people who are interested in a particular component can easily see (and maybe makes sense fix) those issues. Perhaps a * character at the end of the component name to remind us this is sandbox? +1 Sean On 2/21/06, Matthias Wessendorf [EMAIL PROTECTED] wrote: Ah, I see. Thanks for the informations. I'll help to *edit* some issues. So for sandbox, we just create a *component* inside of TOMAHAWK and *store* all issue under this label, right ? -Matthias On 2/21/06, Sean Schofield [EMAIL PROTECTED] wrote: FYI we disabled email notification to the list when you edit an issue (change the name, description, version or component.) This will cut down on some our JIRA traffic. Also, no emails to the list when moving an issue between projects. The issue reporter, the assignee and watchers will still be notified. Sean On 2/21/06, Matthias Wessendorf [EMAIL PROTECTED] wrote: thanks On 2/21/06, Arvid Hülsebus [EMAIL PROTECTED] wrote: Just click on Edit this issue in the sidebar under Operations and assign a new component. Regards, Arvid Matthias Wessendorf wrote: may be a silly question, but how to change / move a bug to a special component e.g. from other - tree2 Thanks, Matthias On 2/21/06, Bruno Aranda [EMAIL PROTECTED] wrote: Thanks Sean for the hard work, +1 from me to put sandox under tomahawk. Regards, Bruno On 2/21/06, Matthias Wessendorf [EMAIL PROTECTED] wrote: Thanks Sean! I have moved all of the tomahawk issues (at least the ones marked tomahawk in the original jira) to the new JIRA project. JIRA is also smart enough to map the old issue numbers with new issue numbers. So if you try to navigate to MYFACES-975[1], JIRA knows enough to redirect you to TOMAHAWK-96. this is cool :-) I have not moved the sandbox stuff yet. My thinking is that sandbox components should be part of the Tomahawk JIRA since they are part of the same maven subproject and they will eventually be promoted to Tomahawk. They will also always have the same versions as Tomahawk. If I get some +1's I will move these also. I am +1 on having sandox stuff under tomahawk. for the reasons you pointed out -maven subproject -promotion Sounds reasonable to me -Matthias I haven't changed the permissions or notification at all. We can talk about that at a future point once we get everything into the right spot. Take a look and let me know what you think. Sean [1] https://issues.apache.org/jira/browse/MYFACES-975 -- Matthias Wessendorf Zülpicher Wall 12, 239 50674 Köln http://www.wessendorf.net mwessendorf-at-gmail-dot-com -- Matthias Wessendorf Zülpicher Wall 12, 239 50674 Köln http://www.wessendorf.net mwessendorf-at-gmail-dot-com -- Matthias Wessendorf Zülpicher Wall 12, 239 50674 Köln http://www.wessendorf.net mwessendorf-at-gmail-dot-com -- Matthias Wessendorf Zülpicher Wall 12, 239 50674 Köln http://www.wessendorf.net mwessendorf-at-gmail-dot-com -- Matthias Wessendorf Zülpicher Wall 12, 239 50674 Köln http://www.wessendorf.net mwessendorf-at-gmail-dot-com
Re: Don't disable unit tests before a checkin
Nobody said you were ;-) So why is the shale snapshot dependency not updating? Maybe it has something to do with the hack to get it to work with maven2? Interesting, at work we are using Maven1 and also, sometimes it looks like maven does not update all jars... If I have build problems, that might come from using wrong versions of a lib or even other strange stuff, I am going to delete my local repo. -Matthias
[jira] Closed: (TOMAHAWK-122) Add colspan attribute to t:column
[ http://issues.apache.org/jira/browse/TOMAHAWK-122?page=all ] sean schofield closed TOMAHAWK-122: --- Resolution: Duplicate Add colspan attribute to t:column --- Key: TOMAHAWK-122 URL: http://issues.apache.org/jira/browse/TOMAHAWK-122 Project: MyFaces Tomahawk Type: Bug Components: Columns, Column Versions: 1.1.1 Environment: Any Reporter: Brendan Conner Priority: Minor Attachments: colspan.zip I may be oversimplifying, but it appears that one could relatively easily add the ability to render a colspan attribute in the rendered td HTML tag by specifying a colspan attribute in t:column. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
Re: Maven2 build failure with current trunk?
On 2/21/06, Sean Schofield [EMAIL PROTECTED] wrote: Sounds like issue #38294 in bugzilla that Dennis was talking about.He has a proposed solution but I didn't commit it yet because I cannotreproduce.It would seem to be JDK specific b/c I can build just fineand so can our continuum server. Wierd. On Linux I get the same results with either 1.5.0 or 1.4.2. SeanCraig On 2/21/06, Craig McClanahan [EMAIL PROTECTED] wrote: On 2/21/06, Sean Schofield [EMAIL PROTECTED] wrote: Craig, You should be ok now.Let us know if you still have problems. Still have problems :-(.But now at least it is in more familiar territory.The first failure I see is in HtmlDataTableTest ... in the setUp() method, it is calling RenderKitFactory.addRenderKit () to add the HTML_BASIC renderkit ... this causes IllegalArgumentException because that RenderKit is already registered.Shale's test framework sets up that registration for you when you instantiate MockRenderKitFactory, so this kind of thing would need to be pulled (or we could consider NOT registering the initial renderkit by default, and do that manually in AbstractJsfTestCase). Sean Craig
Re: Maven2 build failure with current trunk?
Can you get up and running with Dennis' suggested change to shale? On 2/21/06, Craig McClanahan [EMAIL PROTECTED] wrote: On 2/21/06, Sean Schofield [EMAIL PROTECTED] wrote: Sounds like issue #38294 in bugzilla that Dennis was talking about. He has a proposed solution but I didn't commit it yet because I cannot reproduce. It would seem to be JDK specific b/c I can build just fine and so can our continuum server. Wierd. On Linux I get the same results with either 1.5.0 or 1.4.2. Sean Craig On 2/21/06, Craig McClanahan [EMAIL PROTECTED] wrote: On 2/21/06, Sean Schofield [EMAIL PROTECTED] wrote: Craig, You should be ok now. Let us know if you still have problems. Still have problems :-(. But now at least it is in more familiar territory. The first failure I see is in HtmlDataTableTest ... in the setUp() method, it is calling RenderKitFactory.addRenderKit () to add the HTML_BASIC renderkit ... this causes IllegalArgumentException because that RenderKit is already registered. Shale's test framework sets up that registration for you when you instantiate MockRenderKitFactory, so this kind of thing would need to be pulled (or we could consider NOT registering the initial renderkit by default, and do that manually in AbstractJsfTestCase). Sean Craig
[t:column] Tomahawk 122 - Patch ready needs committer attention
The author of this issue reminded me of the outstanding patch. I haven't worked with this area of the code lately and I'm kind of busy with the JIRA reorg and upcoming release. Does anyone want to review this. He has submitted a detailed set of patches and test pages. I suggest we incorporate some of the test pages into the simple examples if we accept this. Sean
Re: Don't disable unit tests before a checkin
On 2/21/06, Sean Schofield [EMAIL PROTECTED] wrote: So why is the shale snapshot dependency not updating? By default, Maven 2 only checks for new snapshots once a day. Try using -U on the command line to force an update if you know there's a new snapshot available. Maybe it has something to do with the hack to get it to work with maven2? What hack? -- Wendy
Re: Don't disable unit tests before a checkin
By default, Maven 2 only checks for new snapshots once a day. Try using -U on the command line to force an update if you know there's a new snapshot available. Its been more then one day since the change was made. I believe the snapshot from one or two days ago incorporated this fix already so it should have been downloaded. What hack? Didn't you need to inject some extra pom information or something into the final product so maven2 could read it? Wendy Sean
Re: JIRA Changes
I moved the sandbox stuff but I did not create the components yet. I'll wait to see what people think about * or (sbx) or whatever. Also, I deleted the 'other' component so most issues are now unassigned to a component. If there is no issue that makes sense to assign them to they can stay there. Otherwise we should gradually assign them over time. (Defnitely before we resolve them.) Sean On 2/21/06, Sean Schofield [EMAIL PROTECTED] wrote: The only thing I worry about is searching on a * char. Maybe a (sbx) or something? On 2/21/06, Matthias Wessendorf [EMAIL PROTECTED] wrote: On 2/21/06, Sean Schofield [EMAIL PROTECTED] wrote: I was thinking of creating one component for each sandbox. So people who are interested in a particular component can easily see (and maybe makes sense fix) those issues. Perhaps a * character at the end of the component name to remind us this is sandbox? +1 Sean On 2/21/06, Matthias Wessendorf [EMAIL PROTECTED] wrote: Ah, I see. Thanks for the informations. I'll help to *edit* some issues. So for sandbox, we just create a *component* inside of TOMAHAWK and *store* all issue under this label, right ? -Matthias On 2/21/06, Sean Schofield [EMAIL PROTECTED] wrote: FYI we disabled email notification to the list when you edit an issue (change the name, description, version or component.) This will cut down on some our JIRA traffic. Also, no emails to the list when moving an issue between projects. The issue reporter, the assignee and watchers will still be notified. Sean On 2/21/06, Matthias Wessendorf [EMAIL PROTECTED] wrote: thanks On 2/21/06, Arvid Hülsebus [EMAIL PROTECTED] wrote: Just click on Edit this issue in the sidebar under Operations and assign a new component. Regards, Arvid Matthias Wessendorf wrote: may be a silly question, but how to change / move a bug to a special component e.g. from other - tree2 Thanks, Matthias On 2/21/06, Bruno Aranda [EMAIL PROTECTED] wrote: Thanks Sean for the hard work, +1 from me to put sandox under tomahawk. Regards, Bruno On 2/21/06, Matthias Wessendorf [EMAIL PROTECTED] wrote: Thanks Sean! I have moved all of the tomahawk issues (at least the ones marked tomahawk in the original jira) to the new JIRA project. JIRA is also smart enough to map the old issue numbers with new issue numbers. So if you try to navigate to MYFACES-975[1], JIRA knows enough to redirect you to TOMAHAWK-96. this is cool :-) I have not moved the sandbox stuff yet. My thinking is that sandbox components should be part of the Tomahawk JIRA since they are part of the same maven subproject and they will eventually be promoted to Tomahawk. They will also always have the same versions as Tomahawk. If I get some +1's I will move these also. I am +1 on having sandox stuff under tomahawk. for the reasons you pointed out -maven subproject -promotion Sounds reasonable to me -Matthias I haven't changed the permissions or notification at all. We can talk about that at a future point once we get everything into the right spot. Take a look and let me know what you think. Sean [1] https://issues.apache.org/jira/browse/MYFACES-975 -- Matthias Wessendorf Zülpicher Wall 12, 239 50674 Köln http://www.wessendorf.net mwessendorf-at-gmail-dot-com -- Matthias Wessendorf Zülpicher Wall 12, 239 50674 Köln http://www.wessendorf.net mwessendorf-at-gmail-dot-com -- Matthias Wessendorf Zülpicher Wall 12, 239 50674 Köln http://www.wessendorf.net mwessendorf-at-gmail-dot-com -- Matthias Wessendorf Zülpicher Wall 12, 239 50674 Köln http://www.wessendorf.net mwessendorf-at-gmail-dot-com -- Matthias Wessendorf Zülpicher Wall 12, 239 50674 Köln http://www.wessendorf.net mwessendorf-at-gmail-dot-com
Re: Don't disable unit tests before a checkin
On 2/21/06, Sean Schofield [EMAIL PROTECTED] wrote: I suspect this is a maven 1 or struts snapshot issue and not a bug in maven2.It does indeed seem to be a snapshot issue ... deleting the old shale-test directory makes the build work for me.Craig
future vision for MyFaces commons
Folks,There seems to be increasing discussion lately regarding MyFaces Commons and how it relates to both MyFaces Core and MyFaces Tomahawk. Adding Tobago and ADF Faces to the discussion makes it even more critical that we come up with a useful way to share reusable code between the various projects. So, I thought it might be helpful to the current discussion if I shared my thoughts about this for the future. Right now, we tend to think of MyFaces Commons as a dumping ground for common utility code that is reused between the Core and Tomahawk, and AFAIK, none of this code has been vetted for its suitability as a consistently backwards-compatible public API. In future, we'll need to provide common code to all component libraries developed as part of the MyFaces effort (and outside MyFaces too), and due to the independent upgrade requirements for individual component libraries, that common codebase will need to provide a guarantee of backwards compatiblilty. One example of such shared code for the future might be a common strategy for the FileUpload feature. It would be a real shame if all of the internal implementation code for this FileUpload feature became part of a public API just because it was added to Commons. So, I propose a split in Commons between public API and private implementation. In fact, I think it shouldn't be called Commons either. :-) [groupId = org.apache.myfaces]myfaces-api-x.y.z.jarmyfaces-impl-x.y.z.jarDependent projects should be free to create compile-time dependencies against myfaces-api, but not myfaces-impl. The code currently in Commons will need an overhaul to prepare it for such backwards compatibility strictness. We should take a hard look at the codebase in there and decide how best to trim it to a managable size that can realisticly be kept compatible across releases. Now, this raises the point about the naming for the current API and implementation for the specification. How about the following?[groupId = org.apache.myfaces] jsf-api-a.b.c.jarjsf-impl-a.b.c.jarI think this makes two things very clear.MyFaces spec api and impl do not contain any non-spec related code (i.e. no non-portable extensions to the spec) MyFaces spec api and impl are equivalents of the reference api and impl from Sun In addition, we might need to break the dependency between jsf-impl-x.y.z.jar and myfaces-api-x.y.z.jar/my-faces-impl.x.y.z.jar above. This may still involve inlining commons into the jsf-impl JAR to avoid potential problems with JavaEE containers vs. webapp ClassLoaders. It certainly feels better to have a directed dependency from the MyFaces API / Impl - standard JSF API / Impl rather than the reverse. :-)Btw, do JavaEE containers, e.g. Tomcat, properly isolate the Webapp ClassLoader from the container's own ClassLoader, preventing visibility of jsf-impl and only exposing jsf-api to the Webapp ClassLoader? This should be perfectly possible using appropriate ClassLoader parentage, but I'm not certain if it is commonly done or mentioned in the JavaEE specification. For Tomahawk, Tobago and ADF Faces, we can have the following.[groupId = org.apache.myfaces]tomahawk-api-d.e.f.jartomahawk-impl-d.e.f.jar tobago-api-g.h.i.jartobago-impl-g.h.i.jaradf-faces-api-j.k.l.jar*adf-faces-impl-j.k.l.jar* where each has a compile time dependeny on both jsf-api and myfaces-api but only a runtime dependency on the internal implementation details of jsf-impl and myfaces-impl.*adf-faces to be renamed during incubation. When any of these projects need to be upgraded, and it depends on a newer version of myfaces-api / myfaces-impl, the upgrade can proceed with confidence because the newer version guarantees backwards compatibilty at compile-time for myfaces-api and at runtime for myfaces-impl. Thoughts?Kind Regards,John Fallows.-- http://apress.com/book/bookDisplay.html?bID=10044Author: Pro JSF and Ajax: Building Rich Internet Components, Apress
Re: Maven2 build failure with current trunk?
On 2/21/06, Sean Schofield [EMAIL PROTECTED] wrote: Can you get up and running with Dennis' suggested change to shale?I was all set to try that, but didn't need it ... deleting a stale Shale Test Framework snapshot did the trick.Craig
Re: Maven2 build failure with current trunk?
Now that is weird. That was only supposed to help with the tree tests. I was only expecting the ClassCastException we fixed several days ago to go away. I was not expecting the render kit stuff to go away. I guess this would explain why I cannot reproduce Dennis' error. Dennis can you try forcing a new snapshot? Sean On 2/21/06, Craig McClanahan [EMAIL PROTECTED] wrote: On 2/21/06, Sean Schofield [EMAIL PROTECTED] wrote: Can you get up and running with Dennis' suggested change to shale? I was all set to try that, but didn't need it ... deleting a stale Shale Test Framework snapshot did the trick. Craig
Re: Refactor Commons to org.apache.myfaces.commons ?
Is it safe to say we are going to stick with commons the way it is for the upcoming core and tomahawk release? If so, I think we should go ahead and create the JIRA project. I'd like to do that and then issue some announcements and documentation on our new JIRA strategy. Sean On 2/21/06, John Fallows [EMAIL PROTECTED] wrote: Maven2 is even smarter that you might realize. :-) (see below) On 2/20/06, Sean Schofield [EMAIL PROTECTED] wrote: Wow that seems really complicated. I have serious concerns about last minute search and replace on the source code. There's got to be a easier solution. Until we started down the maven path we were fine with the way it is. Lets re-examine why we are considering this in the first place. Manfred's scenario ... Scenario: 1. We release commons-1.1.2 + core 1.1.2 (core 1.1.2 depends on commons-1.1.2) 2. days go by... 3. We release commons-1.1.3 (because there where significant changes) + tomahawk 1.1.3 (which depends on commons-1.1.3) So, there are now the following official releases out there: commons-1.1.2 commons-1.1.3 core-1.1.2 tomahawk-1.1.3 User happy starts his brandnew Maven project unlucky, decides to use the latest stable releases of everything and defines the following dependencies: XY depends on myfaces-api 1.1.2 (scope compile) XY depends on myfaces-impl 1.1.2 (scope runtime) XY depends on tomahawk 1.1.3 (scope compile) Now he builds the WAR. Guess what he ends up with? WEB-INF/lib/myfaces-api-1.1.2.jar WEB-INF/lib/myfaces-commons-1.1.2.jar WEB-INF/lib/myfaces-commons-1.1.3.jar WEB-INF/lib/myfaces- impl-1.1.2.jar WEB-INF/lib/myfaces-tomahawk-1.1.3.jar Only one version of commons will be selected, so either commons-1.1.2 or commons-1.1.3 but not both, as long as both versions have the same groupId and artifactId in the Maven2 repository. I'm not totally certain of the exact selection algorithm used by Maven2 to choose the winning version, but I believe selecting the latest version makes the most sense. Kind Regards, John Fallows. I think we can solve this usecase without resorting to last minute code refactoring by maven, or even worse, changing bytecode around. I just don't think those solutions are necessary. One solution could be is that we make the scope of the commons dependency in core and tomahawk to be provided. That way its not transitive and you don't end up with two versions of the commons jar in your WAR. What that means is that you need to declare explicitly a commons dependency in your project as well as core and/or tomahawk. In this case you would just say your project depends on commons version 1.1.3. Everything will be fine as long as 1.1.3 does not break backwards compatability with an earlier version of the core. We can easily test this when we release tomahawk and if it does break backwards compatability, we can release a newer version of the core as well. Its not ideal but its much better then the other alternatives we are considering. I think we carefully document and explain this on the website and include instructions and considerations for those building with maven or using myfaces implementation in their J2EE containers. Sean On 2/18/06, Manfred Geiler [EMAIL PROTECTED] wrote: As Martin already has mentioned, I'm more and more convinced too, that repackaging commons for impl is the only solution that will make as carefree in the long run. Though, I do not agree that it is necessary or advantageous to repackage commons for all component libs (tomahawk, tobago, adffaces). This would bring commons far away from the original idea of having a Jakarta commons like JSF library with goodies and convenient base classes for custom components. Yes, people will probably have conflicts. But the release cycles of our component libs should be fast enough and commons should become stable enough, so that this is no longer a problem. MyFaces-Core (ie. impl) is different insofar as * we want to keep release cycles at a minimum * it will become integrated part of containers (already shipped with JBoss 4.x), or * people make them part of their containers by sharing myfaces-api.jar and myfaces-impl.jar in the containers common/lib or shared/lib dir. The last two points also will have influence on how people will configure their own Maven projects: provided dependency on myfaces-api.jar and myfaces-impl.jar of the version that was shipped with (or is integrated in) the container. People will behave conservative in changing their container environment and behave liberal when using the newest component lib. However, as soon as we have a repackaging solution, it is easy enough to use it not only for impl. So, let's discuss repackaging in general first and postpone the question of using repackaged commons lib for
Re: Maven2 build failure with current trunk?
I guess this would explain why I cannot reproduce Dennis' error. Dennis can you try forcing a new snapshot? I way too busy w/ my day job (behind a firewall) to get this done ;) I'll try tonight. Dennis Byrne
[jira] Commented: (TOMAHAWK-75) ExtensionsFilter results in empty response on Jetty 6
[ http://issues.apache.org/jira/browse/TOMAHAWK-75?page=comments#action_12367256 ] Jurgen Lust commented on TOMAHAWK-75: - This appears to be an issue with Jetty 6, and not with MyFaces. It has been fixed in the latest snapshot of the Jetty6 plugin ExtensionsFilter results in empty response on Jetty 6 - Key: TOMAHAWK-75 URL: http://issues.apache.org/jira/browse/TOMAHAWK-75 Project: MyFaces Tomahawk Type: Bug Environment: Windows XP SP2, Jetty 6 as part of the Jetty6 plugin for maven2 Reporter: Jurgen Lust When deploying a MyFaces webapp that uses the ExtensionsFilter in Jetty6, the response is always empty. You can verify this by adding this to the tomahawk/examples/simple/pom.xml: plugins plugin groupIdorg.mortbay.jetty/groupId artifactIdmaven-jetty6-plugin/artifactId version6.0.0beta9/version configuration scanIntervalSeconds10/scanIntervalSeconds /configuration /plugin /plugins And then typing mvn jetty6:run in the same folder. Now you can access the simple example at http://localhost:8080/myfaces-example-simple/ Normally you will now see a completely empty page... -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Closed: (TOMAHAWK-75) ExtensionsFilter results in empty response on Jetty 6
[ http://issues.apache.org/jira/browse/TOMAHAWK-75?page=all ] sean schofield closed TOMAHAWK-75: -- Resolution: Won't Fix Closing at Jurgen's suggestion. ExtensionsFilter results in empty response on Jetty 6 - Key: TOMAHAWK-75 URL: http://issues.apache.org/jira/browse/TOMAHAWK-75 Project: MyFaces Tomahawk Type: Bug Environment: Windows XP SP2, Jetty 6 as part of the Jetty6 plugin for maven2 Reporter: Jurgen Lust When deploying a MyFaces webapp that uses the ExtensionsFilter in Jetty6, the response is always empty. You can verify this by adding this to the tomahawk/examples/simple/pom.xml: plugins plugin groupIdorg.mortbay.jetty/groupId artifactIdmaven-jetty6-plugin/artifactId version6.0.0beta9/version configuration scanIntervalSeconds10/scanIntervalSeconds /configuration /plugin /plugins And then typing mvn jetty6:run in the same folder. Now you can access the simple example at http://localhost:8080/myfaces-example-simple/ Normally you will now see a completely empty page... -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Created: (TOMAHAWK-152) t:selectOneRadio and t:radio should do the same when check the selected item
t:selectOneRadio and t:radio should do the same when check the selected item Key: TOMAHAWK-152 URL: http://issues.apache.org/jira/browse/TOMAHAWK-152 Project: MyFaces Tomahawk Type: Bug Versions: 1.1.2-SNAPSHOT Reporter: Volker Weber Assigned to: Volker Weber Priority: Minor Fix For: 1.1.2-SNAPSHOT The check for selected is difference between layout=spread and other: On pageDirection and lineDirection layout the stringvalues are checked and on spread layout the real value objects are checked. This results in different behavior when using f:selectItem itemValue=true itemLabel=True / -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
Re: MyFaces Core (Upcoming Release Needs Testing)
I just hear from a maven guy that xslt plugin as been voted out and they are releasing tonight. This means we are getting much closer to a core release. Sean On 2/14/06, Sean Schofield [EMAIL PROTECTED] wrote: Obviously we will need to do TCK testing also but we might as well wait until everyone has a chance to test an apply last minute patches. Sean On 2/13/06, Sean Schofield [EMAIL PROTECTED] wrote: Patch has been applied. This patch potentially affects a great deal so it wouldn't hurt if someone else reviewed it (and if we all tested it.) Sean On 2/13/06, Bruno Aranda [EMAIL PROTECTED] wrote: Martin assigned it to me, but I still haven't got the time to take a look at it. If anybody is able to do that, please feel free to reassign the bug, Bruno On 2/14/06, Abrams, Howard A [EMAIL PROTECTED] wrote: I'd appreciate it if one of the committers could look at MYFACES-1027 (It is currently assigned to Bruno). I submitted a patch a few weeks back and I would be very grateful if someone could verify that it is correct and check it in before 1.1.2 is released. -Original Message- From: Sean Schofield [mailto:[EMAIL PROTECTED] Sent: Monday, February 13, 2006 4:09 PM To: MyFaces Development Subject: MyFaces Core (Upcoming Release Needs Testing) We have created a branch in SVN to test the upcoming core release. Recall that is same as the MyFaces JSF implementation (no Tomahawk). You can checkout the latest branch code from SVN[1] and compile the proposed release code. You should test with the latest commons release which is now available on ibiblio[2]. You can also build the commons release from the source[3]. At a minimum someone should test all of the examples. Be sure you build them with maven though. We want to test that the right dependencies make it into the WAR. I will try to lend a hand with the testing but the maven stuff has taken up most of my open source time. The end result is *definitely* worth it though. No voting yet. This is just to get the kinks worked out. We're going to try and get more rapid releases of MyFaces going so if there is a bug that isn't fixed - there's always the next version. Feel free to scratch your own itch and provide a fix if you want it resolved by the next release. If you do, make sure it is checked in on the branch *only. We'll merge it down to the trunk later. Sean [1] https://svn.apache.org/repos/asf/myfaces/core/branches/1_1_2 [2] http://www.ibiblio.org/maven2/org/apache/myfaces/commons/ [3] https://svn.apache.org/repos/asf/myfaces/commons/tags/1_1_2
[jira] Created: (TOBAGO-39) This is a test issue - Testing New JIRA workflow
This is a test issue - Testing New JIRA workflow Key: TOBAGO-39 URL: http://issues.apache.org/jira/browse/TOBAGO-39 Project: MyFaces Tobago Type: Task Versions: 1.0.7-SNAPSHOT Reporter: sean schofield Assigned to: sean schofield This is a test issue. It should be deleted when the test is done. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
More JIRA Changes
I made another improvement to our JIRA setup. I added a Patch Available state. There is now an operation called Provide Patch that users can click once they have attached a patch. It will then place the issue in the Patch Available state. This way we can keep track of issues where patches have been provided. I think this will be a good way to stay on top of the growing number of issues and give priority to the users who have taken the time to submit patches. Up until now they have been lost in the swamp of issues and they have to resort to nagging to get us to look at them. I changed the Tobago project only so far as a test. Since that project only had 22 issues if I screwed things up totally at least it wouldn't be a complete disaster. Everything looks good so after a few +1 I will change the workflow of the other projects. After we get commons JIRA project setup (hopefully tomorrow also) I will send an email to the user and dev lists detailing the changes and asking them to mark their issues with provide patch so we can get started on them. Sean
[jira] Commented: (TOMAHAWK-152) t:selectOneRadio and t:radio should do the same when check the selected item
[ http://issues.apache.org/jira/browse/TOMAHAWK-152?page=comments#action_12367282 ] Colin Sharples commented on TOMAHAWK-152: - This has caused me problems, so I would definitely like to see this fixed. I managed to get round this by fiddling with my converter, but I'd rather see the renderer fixed. t:selectOneRadio and t:radio should do the same when check the selected item Key: TOMAHAWK-152 URL: http://issues.apache.org/jira/browse/TOMAHAWK-152 Project: MyFaces Tomahawk Type: Bug Components: selectOneRadio / radio Versions: 1.1.2-SNAPSHOT Reporter: Volker Weber Assignee: Volker Weber Priority: Minor Fix For: 1.1.2-SNAPSHOT Attachments: HtmlRadioRenderer.diff The check for selected is difference between layout=spread and other: On pageDirection and lineDirection layout the stringvalues are checked and on spread layout the real value objects are checked. This results in different behavior when using f:selectItem itemValue=true itemLabel=True / -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (TOMAHAWK-152) t:selectOneRadio and t:radio should do the same when check the selected item
[ http://issues.apache.org/jira/browse/TOMAHAWK-152?page=comments#action_12367291 ] sean schofield commented on TOMAHAWK-152: - Can you help us by testing Volker's patch? t:selectOneRadio and t:radio should do the same when check the selected item Key: TOMAHAWK-152 URL: http://issues.apache.org/jira/browse/TOMAHAWK-152 Project: MyFaces Tomahawk Type: Bug Components: selectOneRadio / radio Versions: 1.1.2-SNAPSHOT Reporter: Volker Weber Assignee: Volker Weber Priority: Minor Fix For: 1.1.2-SNAPSHOT Attachments: HtmlRadioRenderer.diff The check for selected is difference between layout=spread and other: On pageDirection and lineDirection layout the stringvalues are checked and on spread layout the real value objects are checked. This results in different behavior when using f:selectItem itemValue=true itemLabel=True / -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
Re: JSF 1.2 now !?!
It was developed last spring, it's been used as the foundation for EL within the JSF RI and Glassfish's JSP impl, as far as I know, there haven't been any bug fixes or issues and was already through the EL verification process. What's not stable at the moment is the JSP 2.1 implementation (yet another thing on my plate :-P) -- Jacob Martin Marinschek wrote: But Jacob has already implemented the EL. and donated it. Alexander, you'd need to ask him how stable it is? regards, Martin On 2/14/06, Matthias Wessendorf [EMAIL PROTECTED] wrote: Maybe the Jakarta Commons EL project can take care of this impl. On 2/14/06, Jesse Alexander (KBSA 21) [EMAIL PROTECTED] wrote: Somebody knows how stable the EL already is? Alexander -Original Message- From: Remy Maucherat [mailto:[EMAIL PROTECTED] Sent: Tuesday, January 31, 2006 11:11 PM To: MyFaces Development Subject: Re: JSF 1.2 now !?! Jesse Alexander (KBSA 21) wrote: Now that the first versions of JSF 1.2 are really available http://weblogs.java.net/blog/edburns/archive/2006/01/jsf_12_j ars_now.ht ml Shouldn't we think about a MyFaces 1.2? I was thinking lately about a model similar to Linux: Have a small group managing the JSF 1.1 Branch and a bigger group giving it all for JSf 1.2. After all Craig spoke about MyFaces' need to deliver a 1.2 implementation some days/weeks ago on the user-list... In case you're interested, Tomcat has started developing its JSP 2.1 implementation, starting with the unified EL. https://svn.apache.org/repos/asf/tomcat/jasper/tc6.0.x Rémy -- Matthias Wessendorf Zülpicher Wall 12, 239 50674 Köln http://www.wessendorf.net mwessendorf-at-gmail-dot-com -- http://www.irian.at Your JSF powerhouse - JSF Consulting, Development and Courses in English and German Professional Support for Apache MyFaces -- Jacob Hookom - Minneapolis JSF-EG, JSF-RI, EL, Facelets
[jira] Commented: (MYFACES-1148) Weblogic Classloader problems during development (FactoryFinder)
[ http://issues.apache.org/jira/browse/MYFACES-1148?page=comments#action_12367297 ] Dennis Byrne commented on MYFACES-1148: --- FactoryFinder behavior is defined pretty clearly by the spec, and you'll get this w/ any implementation. I don't know what else to say ;( Weblogic Classloader problems during development (FactoryFinder) Key: MYFACES-1148 URL: http://issues.apache.org/jira/browse/MYFACES-1148 Project: MyFaces Core Type: Bug Components: General Versions: 1.1.1 Environment: Weblogic 9.0, 8.1, etc. Windows XP Pro sp2. Reporter: Adam Brod Like most weblogic users, our team develops using the exploded war format. That means that each time we deploy a new version of a class, weblogic automatically picks it up. The way Weblogic implements this is that when it detects a new class, it drops the classloader for that class, as well as the Servlet and all helper classes that are loaded by the Servlet. That means FacesServlet is dropped and reloaded. The problem is that FactoryFinder stores the Factory classes in a Map where the key is the current classloader. That works fine until I deploy a new class to my webapp. At that point, weblogic drops the classloader and creates a new one with the new class definition. Now when FacesServlet.init() calls FactoryFinder.getFactory() (in the new classloader), an IllegalStateException is generated (see below) because the current classloader is not a valid key for the _registeredFactoryNames Map. One possible solution that I can see to this is to change the key for the Factory map to use the ServletContext's getServletContextName() as the key. I am 95% sure this same problem exists in Weblogic 7.0, 8.1 and 9.1 since they all use almost the same Servlet redeployment mechanism. I have only tried this on Weblogic 9.0. Feb 20, 2006 5:38:07 PM EST Error HTTP BEA-101017 [EMAIL PROTECTED] - name: 'ma-web-1.0-SNAPSHOT ', context-path: '/ma'] Root cause of ServletException. java.lang.IllegalStateException: No Factories configured for this Application - typically this is because a context listener is not setup in yo ur web.xml. A typical config looks like this; listener listener-classorg.apache.myfaces.webapp.StartupServletContextListener/listener-class /listener at javax.faces.FactoryFinder.getFactory(FactoryFinder.java:84) at javax.faces.webapp.FacesServlet.init(FacesServlet.java:84) at weblogic.servlet.internal.StubSecurityHelper$ServletInitAction.run(StubSecurityHelper.java:265) at weblogic.security.acl.internal.AuthenticatedSubject.doAs(AuthenticatedSubject.java:321) at weblogic.security.service.SecurityManager.runAs(SecurityManager.java:121) at weblogic.servlet.internal.StubSecurityHelper.createServlet(StubSecurityHelper.java:61) at weblogic.servlet.internal.StubLifecycleHelper.createOneInstance(StubLifecycleHelper.java:58) at weblogic.servlet.internal.StubLifecycleHelper.init(StubLifecycleHelper.java:48) at weblogic.servlet.internal.ServletStubImpl.prepareServlet(ServletStubImpl.java:502) at weblogic.servlet.internal.ServletStubImpl.checkForReload(ServletStubImpl.java:429) at weblogic.servlet.internal.ServletStubImpl.execute(ServletStubImpl.java:221) at weblogic.servlet.internal.TailFilter.doFilter(TailFilter.java:26) at weblogic.servlet.internal.FilterChainImpl.doFilter(FilterChainImpl.java:42) at oracle.adfinternal.view.faces.webapp.AdfFacesFilterImpl._invokeDoFilter(AdfFacesFilterImpl.java:367) at oracle.adfinternal.view.faces.webapp.AdfFacesFilterImpl._doFilterImpl(AdfFacesFilterImpl.java:336) at oracle.adfinternal.view.faces.webapp.AdfFacesFilterImpl.doFilter(AdfFacesFilterImpl.java:196) at oracle.adf.view.faces.webapp.AdfFacesFilter.doFilter(AdfFacesFilter.java:87) at weblogic.servlet.internal.FilterChainImpl.doFilter(FilterChainImpl.java:42) at org.apache.myfaces.component.html.util.ExtensionsFilter.doFilter(ExtensionsFilter.java:122) at weblogic.servlet.internal.FilterChainImpl.doFilter(FilterChainImpl.java:42) at weblogic.servlet.internal.WebAppServletContext$ServletInvocationAction.run(WebAppServletContext.java:3020) at weblogic.security.acl.internal.AuthenticatedSubject.doAs(AuthenticatedSubject.java:321) at weblogic.security.service.SecurityManager.runAs(SecurityManager.java:121) at weblogic.servlet.internal.WebAppServletContext.securedExecute(WebAppServletContext.java:1925) at weblogic.servlet.internal.WebAppServletContext.execute(WebAppServletContext.java:1848) at weblogic.servlet.internal.ServletRequestImpl.run(ServletRequestImpl.java:1288) at
[maven] Unable to run core assembly
I am unable to run the core assembly on my machine. This time I get the following error: [ERROR] BUILD ERROR [INFO] - --- [INFO] 'taglibdocjar' was specified in an execution, but not found in the plugin [INFO] - --- [INFO] For more information, run Maven with the -e switch [INFO] - Any ideas? It seems to be running on continuum. I'm trying to run this on the branch btw (in anticipation of the release.) Sean @ Bernd: I changed my mind and you are right. The assembly should include the transitive deps. Can you change this back (on the branch)?
Re: JSF 1.2 in a Maven 1 Repo
On 2/20/06, Martin Marinschek [EMAIL PROTECTED] wrote: one / zero = infinity ;-)you talk about the configuration of the ExtensionsFilter there, right?;)no line - no mailsone line - infinite amount of mailsPrecisely. ;-) regards,MartinOn 2/21/06, John Fallows [EMAIL PROTECTED] wrote: On 2/18/06, Ed Burns [EMAIL PROTECTED] wrote: On Fri, 17 Feb 2006 21:05:40 -0800, John Fallows [EMAIL PROTECTED] said: JF Wendy is exactly right.Of course, it would be much more convenient JF if the JSF 1.2 jars were on ibiblio.org to avoid the extra JF configuration to pick up the java.netrepository. much, I don't know about that.How hard is one line? one / zero = infinity ;-) I agree though, at least there is only one line in the pom.xml shared by all users as opposed to one line of extra configuration *per user* as originally posted. JF I believe there is work already underway to establish an automatic JF sync for some of the java.net artifacts to ibiblio.org. There are legal issues that must be resolved to make this happen. Believe me, I had to work with lawyers just to enable getting the jars out on java.net. Yep, guessed as much - that's why I was wondering if any additional progress had been made on this front at the same time. Kind Regards, John Fallows. -- http://apress.com/book/bookDisplay.html?bID=10044 Author: Pro JSF and Ajax: Building Rich Internet Components, Apress-- http://www.irian.atYour JSF powerhouse -JSF Consulting, Development andCourses in English and GermanProfessional Support for Apache MyFaces-- http://apress.com/book/bookDisplay.html?bID=10044Author: Pro JSF and Ajax: Building Rich Internet Components, Apress
ADF Faces javascript rendering
The Tomahawk components 'inject' Javascript file references into the head section of the response by using a filter to buffer and post-process the response. I'm assuming ADF Faces has some mechanism for injecting Javascript too, but I can't seem to track it down... I've found the code that handles serving static resources, just not the code responsible for injecting references to Javascript files. The reason I'm looking for it is so I can make a component library I'm working on use it. Can anyone give me a pointer to the right area in the ADF Faces code, or even better a quick explanation of how to use it to do what I want? Thanks, L.
Re: future vision for MyFaces commons
Why should anything in commons be regarded as a public API? I think javadoc could be added to commons to simply state that *all* classes in that library are subject to API changes in any release [1]. These are helper classes. People who are writing portable JSF components will not be using these APIs anyway as they only exist for MyFaces. The only people this will bother are those who subclass existing components. Yes this is a reasonable thing to do (I've done it myself) and maybe in the future effort could be put into separating stable from unstable APIs in commons to help this but I think it's premature to do this. The pain of determining what the public apis are, then of maintaining binary compatibility with them is not worth the gain right now. I think maintaining compatibility for the component APIs *is* important; JSP tags (or facelets tags) should not suddenly change their attributes, and component properties should not disappear or change meaning. However none of this is defined in commons classes. [1] Actually, I've proposed not ever releasing commons at all; when a component (core/tomahawk/tobago/etc) is tagged/branched, just tag/branch commons at the same time and then use a tool to rename the classes into the core/tomahawk/etc packages. Cheers, Simon On Tue, 2006-02-21 at 11:35 -0800, John Fallows wrote: Folks, There seems to be increasing discussion lately regarding MyFaces Commons and how it relates to both MyFaces Core and MyFaces Tomahawk. Adding Tobago and ADF Faces to the discussion makes it even more critical that we come up with a useful way to share reusable code between the various projects. So, I thought it might be helpful to the current discussion if I shared my thoughts about this for the future. Right now, we tend to think of MyFaces Commons as a dumping ground for common utility code that is reused between the Core and Tomahawk, and AFAIK, none of this code has been vetted for its suitability as a consistently backwards-compatible public API. In future, we'll need to provide common code to all component libraries developed as part of the MyFaces effort (and outside MyFaces too), and due to the independent upgrade requirements for individual component libraries, that common codebase will need to provide a guarantee of backwards compatiblilty. One example of such shared code for the future might be a common strategy for the FileUpload feature. It would be a real shame if all of the internal implementation code for this FileUpload feature became part of a public API just because it was added to Commons. So, I propose a split in Commons between public API and private implementation. In fact, I think it shouldn't be called Commons either. :-) [groupId = org.apache.myfaces] myfaces-api-x.y.z.jar myfaces-impl-x.y.z.jar Dependent projects should be free to create compile-time dependencies against myfaces-api, but not myfaces-impl. The code currently in Commons will need an overhaul to prepare it for such backwards compatibility strictness. We should take a hard look at the codebase in there and decide how best to trim it to a managable size that can realisticly be kept compatible across releases. Now, this raises the point about the naming for the current API and implementation for the specification. How about the following? [groupId = org.apache.myfaces] jsf-api-a.b.c.jar jsf-impl-a.b.c.jar I think this makes two things very clear. 1. MyFaces spec api and impl do not contain any non-spec related code (i.e. no non-portable extensions to the spec) 2. MyFaces spec api and impl are equivalents of the reference api and impl from Sun In addition, we might need to break the dependency between jsf-impl-x.y.z.jar and myfaces-api-x.y.z.jar/my-faces-impl.x.y.z.jar above. This may still involve inlining commons into the jsf-impl JAR to avoid potential problems with JavaEE containers vs. webapp ClassLoaders. It certainly feels better to have a directed dependency from the MyFaces API / Impl - standard JSF API / Impl rather than the reverse. :-) Btw, do JavaEE containers, e.g. Tomcat, properly isolate the Webapp ClassLoader from the container's own ClassLoader, preventing visibility of jsf-impl and only exposing jsf-api to the Webapp ClassLoader? This should be perfectly possible using appropriate ClassLoader parentage, but I'm not certain if it is commonly done or mentioned in the JavaEE specification. For Tomahawk, Tobago and ADF Faces, we can have the following. [groupId = org.apache.myfaces] tomahawk-api-d.e.f.jar tomahawk-impl-d.e.f.jar tobago-api-g.h.i.jar tobago-impl-g.h.i.jar adf-faces-api-j.k.l.jar* adf-faces-impl-j.k.l.jar* where each has a compile time dependeny on both jsf-api and myfaces-api but only a runtime dependency on the internal implementation details of jsf-impl and myfaces-impl. *adf-faces to be renamed during
Re: [maven] Unable to run core assembly
On 2/22/06, Sean Schofield [EMAIL PROTECTED] wrote: Weird, I reran with -U and it downloaded a whole bunch of new stuff. Then it ran fine. I haven't run maven in 24 hours so its not like there are brand new snapshots out there that it failed to pick up. have you told this to the maven list? maven1 has something equal, so you have to kill you local repo ... :-( @Bernd: Can you still reverse the change you made last month where we took the deps out of assembly? Sean On 2/21/06, Sean Schofield [EMAIL PROTECTED] wrote: I am unable to run the core assembly on my machine. This time I get the following error: [ERROR] BUILD ERROR [INFO] - --- [INFO] 'taglibdocjar' was specified in an execution, but not found in the plugin [INFO] - --- [INFO] For more information, run Maven with the -e switch [INFO] - Any ideas? It seems to be running on continuum. I'm trying to run this on the branch btw (in anticipation of the release.) Sean @ Bernd: I changed my mind and you are right. The assembly should include the transitive deps. Can you change this back (on the branch)? -- Matthias Wessendorf Zülpicher Wall 12, 239 50674 Köln http://www.wessendorf.net mwessendorf-at-gmail-dot-com
Re: [maven] Unable to run core assembly
Sean Schofield schrieb: @Bernd: Can you still reverse the change you made last month where we took the deps out of assembly? On the trunk and 1_1_2 branch or on the trunk only? Bernd Sean On 2/21/06, Sean Schofield [EMAIL PROTECTED] wrote: I am unable to run the core assembly on my machine. This time I get the following error: [ERROR] BUILD ERROR [INFO] - --- [INFO] 'taglibdocjar' was specified in an execution, but not found in the plugin [INFO] - --- [INFO] For more information, run Maven with the -e switch [INFO] - Any ideas? It seems to be running on continuum. I'm trying to run this on the branch btw (in anticipation of the release.) Sean @ Bernd: I changed my mind and you are right. The assembly should include the transitive deps. Can you change this back (on the branch)? -- Dipl.-Ing. Bernd Bohmann - Atanion GmbH - Software Development Bismarckstr. 13, 26122 Oldenburg, http://www.atanion.com phone: +49 441 4082312, mobile: +49 173 8839471, fax: +49 441 4082333