Re: tabular dialog

[Juergen Vigna]

On 03-Dec-2001 Andre Poenitz wrote:

 Come on... user interface stuff used to be no-go-teritory for me and I did
 not follow discussions there too closely (if at all). I would not even know
 where to start with this kind of things.

Well then let me sum for you. We agreed that we should change to a
Apply/Ok policy also for the tabular-dialog, but this would involve
a major rewrite of the TabularFeatures and the dialog so we decided to
leave this for 1.3.0.

   Jug

--
-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._
Dr. Jürgen VignaE-Mail:  [EMAIL PROTECTED]
Italienallee 13/N   Tel/Fax: +39-0471-450260 / +39-0471-450253
I-39100 Bozen   Web: http://www.sad.it/~jug
-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._

He who spends a storm beneath a tree, takes life with a grain of TNT.

Re: style

[Allan Rae]

On Tue, 4 Dec 2001, Andre Poenitz wrote:

 On Tue, Dec 04, 2001 at 03:57:34PM +1000, Allan Rae wrote:
  preferred.  Like this one instead of above?
 
  if (any length a  any length b  any length c) {
  }

 If it fits on a line, it should be ok. But then, why don't you put the test
 in some function with some meaningful name and write

  if (someFancyConditionFulfilled()) {
  }

Because by any length I also meant really simple stuff like for
example:

if (p
 !p-empty()) {
}

Although that is probably the extreme of simple examples.

Allan. (ARRae)

Re: lyxlength.C does not compile!

[Andre Poenitz]

On Tue, Dec 04, 2001 at 05:59:13PM +1000, Allan Rae wrote:
  Well, Lars started ripping it apart and renaming it, so I guess he would
  like to get it done? ;-)
 
 Okay then maybe Lars would like to use a:
   pairint, int

I think we should indeed use 'int' and put the percentage stuff somewhere
else...

Andre'

-- 
André Pönitz .. [EMAIL PROTECTED]

Re: [PATCH] two fixes, broken (iterator questions)

[Juergen Vigna]

On 04-Dec-2001 John Levon wrote:

 text-fullRebreak(this);

 Can someone explain to me why a full rebreak is performed after each 
 error is removed?
 (The old code did this too... and also when the errors are inserted.) I 
 would have thought that could wait until all the errors had been processed.
 
 /me shrugs

I would say have a look at the fullRebreak() function ;) It actually
breaks only if need_break_row is set. Maybe the function name is misleading
but actually it can perform only the fullRebreak of one paragraph starting
at the need_break_row! So you HAVE to call it every time otherwise the
next time need_break_row will be overwritten with the next row we should
break and so we won't never break the first one!

   Jug

--
-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._
Dr. Jürgen VignaE-Mail:  [EMAIL PROTECTED]
Italienallee 13/N   Tel/Fax: +39-0471-450260 / +39-0471-450253
I-39100 Bozen   Web: http://www.sad.it/~jug
-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._

I haven't been married in over six years, but we had sexual counseling
every day from Oral Roberts!!

Re: tabular dialog

[Andre Poenitz]

On Tue, Dec 04, 2001 at 09:01:21AM +0100, Juergen Vigna wrote:
 Well then let me sum for you. We agreed that we should change to a
 Apply/Ok policy also for the tabular-dialog, but this would involve
 a major rewrite of the TabularFeatures and the dialog so we decided to
 leave this for 1.3.0.

Very kind of you.

Andre'

-- 
André Pönitz .. [EMAIL PROTECTED]

Re: style

[Andre Poenitz]

On Tue, Dec 04, 2001 at 06:03:52PM +1000, Allan Rae wrote:
 Because by any length I also meant really simple stuff like for
 example:
 
   if (p
!p-empty()) {
   }

I find this much more disruptive to read than

if (p  !p-empty()) {
}

Actually, this is strange, since I usually favour linear code, i.e.
something that basically goes top down. But I probably look at a
condition as something atomic, a single idea...

Andre'

-- 
André Pönitz .. [EMAIL PROTECTED]

Re: [PATCH] fix some inset-in-inset update problems

[Juergen Vigna]

On 04-Dec-2001 Allan Rae wrote:

 So you are saying that setUpdateStatus(NONE) indicates that no update
 has been done so a FULL update is needed?

Nope! NONE just gives the minimal amount of Update I envise for this
call. Then setUpdateStatus has to decide if we need more than this minimal
amount. So if the change in LyXText was minimal we probably will have only
a CURSOR_PAR, if the change was mayor (a break in a row) then we would have
FULL, but if we didn't have ANY change then the update would be NONE.

Obviously we could put the code if lt-status() == NEED_VERY_LITTLE_REFRESH
then setUpdateStatus(CURSOR_PAR) else if lt-status() == NEED_MORE_REFRESH
then setUpdateStatus(FULL) else setUpdateStatus(myminimal_status) everywhere
we call that function but I really don't see the point of enlarging the
code with duplicates.

 Jug

--
-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._
Dr. Jürgen VignaE-Mail:  [EMAIL PROTECTED]
Italienallee 13/N   Tel/Fax: +39-0471-450260 / +39-0471-450253
I-39100 Bozen   Web: http://www.sad.it/~jug
-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._

Play Rogue, visit exotic locations, meet strange creatures and kill them.

Re: [PATCH] fix some inset-in-inset update problems

[Juergen Vigna]

On 04-Dec-2001 Allan Rae wrote:

 Or are you just thinking of insettabular and the no-mans-land between
 the cells?  Then an insettabular::iterator should handle those more
 obtuse actions.  If you have two cursors with one set to the first pos
 of an inset and the second set to the end of the same inset haven't
 you just selected the whole inset?  So why do you need a no-mans-land
 to mark a whole inset?

It seems to me you all hide your head in the sand ;)

What about this:

blah blah |[inset1] blah blah blah
blah [inset2] blah blah blah.

Now an insetgraphics inside [inset2] is requesing an update because
it finished rendering. I don't see any cursor near [inset2], do you?

  Jug

--
-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._
Dr. Jürgen VignaE-Mail:  [EMAIL PROTECTED]
Italienallee 13/N   Tel/Fax: +39-0471-450260 / +39-0471-450253
I-39100 Bozen   Web: http://www.sad.it/~jug
-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._

Is death legally binding?

Re: [PATCH] fix some inset-in-inset update problems

[Juergen Vigna]

On 04-Dec-2001 Andre Poenitz wrote:

 Honour to whom honour is true: The concept is from the math cursor first
 implemented by Alejandro. And even after the rework, the math cursor does
 exactly this: Hold two stacks of cursor positions (one for the cursor,
 one for the selection anchor), each position is a triplet of values:
 (pointer to an inset, cell number of the inset, offset in that cell)

Well honor whoever you want, but I would say that a text with a 1000's of
lines and I don't know how much insets is a bit more complicated than
a single line math inset, don't you?

Anyway I already pointed out that maybe we can do without the owner_
of an inset, but we have to rewrite just some code which right now IS
working. So you surely won't have 1.2.0 out in 2004 would you?

   Jug

P.S.: maybe means that I may see an option but I'm not at all sure it will
  work!

--
-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._
Dr. Jürgen VignaE-Mail:  [EMAIL PROTECTED]
Italienallee 13/N   Tel/Fax: +39-0471-450260 / +39-0471-450253
I-39100 Bozen   Web: http://www.sad.it/~jug
-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._

The time is right to make new friends.

Re: [PATCH] fix some inset-in-inset update problems

[Juergen Vigna]

On 04-Dec-2001 Allan Rae wrote:

 Then we should only need to use the same two cursors to do anything.
 The second one only needed for selections.

We don't the stuff is a bit more complicated when updates and redraws
are involved. But I would say if you know all of it why don't you start
coding and so you can proove us that you're right. I would surely be
happy about that!

Jug

--
-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._
Dr. Jürgen VignaE-Mail:  [EMAIL PROTECTED]
Italienallee 13/N   Tel/Fax: +39-0471-450260 / +39-0471-450253
I-39100 Bozen   Web: http://www.sad.it/~jug
-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._

The human race is a race of cowards; and I am not only marching in that
procession but carrying a banner.
-- Mark Twain

Re: [PATCH] fix some inset-in-inset update problems

[Andre Poenitz]

On Tue, Dec 04, 2001 at 09:38:02AM +0100, Juergen Vigna wrote:
 Now an insetgraphics inside [inset2] is requesing an update because
 it finished rendering. I don't see any cursor near [inset2], do you?

Inset rendering is a bit special, it's the only case of asynchronous
operation, isn't it?

What about giving the I am done call back of the inset rendering a
snapshot copy of the cursor from the moment where the inset is created
and rendering started?

Anre'

-- 
André Pönitz .. [EMAIL PROTECTED]

Re: [PATCH] fix some inset-in-inset update problems

[Andre Poenitz]

On Tue, Dec 04, 2001 at 09:42:52AM +0100, Juergen Vigna wrote:
 Well honor whoever you want, but I would say that a text with a 1000's of
 lines and I don't know how much insets is a bit more complicated than
 a single line math inset, don't you?

No.

What is the problem with the concept of a list of paragraphs, each holding
a list of rows, each with some characters or nested insets? The only
problem I see is some implementation that makes things complicated.  Hand
wired paragraph lists etc. No need to feel offended I am not blaming
anybody here, most of the stuff seems to be in from the very beginning. 

I see quite a few parallels between math cells and paragraph rows
and math inset and paragraph.

 Anyway I already pointed out that maybe we can do without the owner_
 of an inset, but we have to rewrite just some code which right now IS
 working. So you surely won't have 1.2.0 out in 2004 would you?

I am not talking about 1.2.

Andre'

-- 
André Pönitz .. [EMAIL PROTECTED]

Re: [PATCH] fix some inset-in-inset update problems

[Juergen Vigna]

On 04-Dec-2001 Andre Poenitz wrote:

 Inset rendering is a bit special, it's the only case of asynchronous
 operation, isn't it?

Well, ...

 What about giving the I am done call back of the inset rendering a
 snapshot copy of the cursor from the moment where the inset is created
 and rendering started?

And what if the inset-pointer changed in the meantime (Undo/Redo)?

Jug

--
-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._
Dr. Jürgen VignaE-Mail:  [EMAIL PROTECTED]
Italienallee 13/N   Tel/Fax: +39-0471-450260 / +39-0471-450253
I-39100 Bozen   Web: http://www.sad.it/~jug
-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._

Whoever dies with the most toys wins.

Re: [PATCH] fix some inset-in-inset update problems

[Juergen Vigna]

On 04-Dec-2001 Andre Poenitz wrote:

 I am not talking about 1.2.

Well let's say that we agree that we could change something in the
logic in the future (and I'm not sure it will be in 1.3 as I really
would like to have the main-view GUIIfied in 1.3, some added features
but nothing which redoes a lot of code. We HAVE to finish GUII as fast
as possible IMO.

 Jug

--
-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._
Dr. Jürgen VignaE-Mail:  [EMAIL PROTECTED]
Italienallee 13/N   Tel/Fax: +39-0471-450260 / +39-0471-450253
I-39100 Bozen   Web: http://www.sad.it/~jug
-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._

That's life.
What's life?
A magazine.
How much does it cost?
Two-fifty.
I only have a dollar.
That's life.

Re: [PATCH] fix some inset-in-inset update problems

[Juergen Vigna]

On 04-Dec-2001 Juergen Vigna wrote:

 And what if the inset-pointer changed in the meantime (Undo/Redo)?

No IMO that theLockingInset() stuff is pretty good and easy. It only
goes one direction and is only there if we really enter an inset. We
could do it with the cursor, but IMO we would add complex handling not
remove it.

While the above update has nothing to do with neighter cursor nor
theLockingInset() we just have to have a good iterator and we'll find
the inset which want's to be updated quite fast!

Anyway the update/redraw process has do go from the outermost inset to
the innermost inset and back again and we have this more or less already
BufferView::updateInset(inset-to-update), the theLockingInset mechanism
is IMO only a shortcut as 98% of the update stuff (or more) most probably
will occur in the spot where we're actually editing.

So IMO we won't need any complicated cursor as we don't have to know
the outer inset if we access the whole stuff from the right direction.
Much of the code there was written long time ago and build up on each
other. The whole Inset hierarchy has to be rethought, as I already pointed
out with my mail about the need of a ContainerInset.

But as I also said before I don't see this done neighter in 1.2 nor in 1.3
as I see other priorities. I think that this should be done after we have
GUII finished as then we also have a cleaner base to build on and redo
this old code.

I hope we agree all that GUII should have precedence in 1.3 and that we
shouldn't wait another 3 year for the 1.3 release, but it should go out
quite fast.

Jug

--
-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._
Dr. Jürgen VignaE-Mail:  [EMAIL PROTECTED]
Italienallee 13/N   Tel/Fax: +39-0471-450260 / +39-0471-450253
I-39100 Bozen   Web: http://www.sad.it/~jug
-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._

I'd never join any club that would have the likes of me as a member.
-- Groucho Marx

Re: [PATCH] fix some inset-in-inset update problems

[Andre Poenitz]

On Tue, Dec 04, 2001 at 10:35:23AM +0100, Juergen Vigna wrote:
 
 On 04-Dec-2001 Andre Poenitz wrote:
 
  Inset rendering is a bit special, it's the only case of asynchronous
  operation, isn't it?
 
 Well, ...
 
  What about giving the I am done call back of the inset rendering a
  snapshot copy of the cursor from the moment where the inset is created
  and rendering started?
 
 And what if the inset-pointer changed in the meantime (Undo/Redo)?

If the paragraph is still there, the pointer should not have changed, since
it is still the same thing, should it? But since you are asking I suppose
the pointer may change indeed.

Well, there are other solutions: We will need a method to create a cursor
stack from (x,y) coordinates anyway, since people want to put the cursor
somewhere by clicking with the mouse. So we could recreate the cursor from
some cached inset position. If that has changed, we could redraw
everything on screen - I doubt that one has more that a few graphic insets
on one _screen_. 

Or we could ignore the matter altogether and force a complete redraw of the
full screen every second or so...

How expensive is a full screen redraw anyway? Does is justify all the code
used to figure out whether we need very little or just a little redraw? 

If a complete redraw takes less than 0.05 second, we could scrap the
complicated parts of the redrawing entirely and nobody will notice.

Andre'

-- 
André Pönitz .. [EMAIL PROTECTED]

Re: [PATCH] fix some inset-in-inset update problems

[Andre Poenitz]

On Tue, Dec 04, 2001 at 10:38:14AM +0100, Juergen Vigna wrote:
 Well let's say that we agree that we could change something in the
 logic in the future (and I'm not sure it will be in 1.3 as I really
 would like to have the main-view GUIIfied in 1.3, some added features
 but nothing which redoes a lot of code. We HAVE to finish GUII as fast
 as possible IMO.

Depends on the cycle length. If it takes several years again... ;-}

Andre'

-- 
André Pönitz .. [EMAIL PROTECTED]

Re: [PATCH] fix some inset-in-inset update problems

[Juergen Vigna]

On 04-Dec-2001 Andre Poenitz wrote:
 On Tue, Dec 04, 2001 at 10:38:14AM +0100, Juergen Vigna wrote:
 Well let's say that we agree that we could change something in the
 logic in the future (and I'm not sure it will be in 1.3 as I really
 would like to have the main-view GUIIfied in 1.3, some added features
 but nothing which redoes a lot of code. We HAVE to finish GUII as fast
 as possible IMO.
 
 Depends on the cycle length. If it takes several years again... ;-}

Well it took several years BECAUSE we changed some important stuff in
the core. If we refrain from doing that in the 1.3 cycle and concentrate
ONLY on the points we want to realize then IMO we could do it quite fast!

  Jug

--
-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._
Dr. Jürgen VignaE-Mail:  [EMAIL PROTECTED]
Italienallee 13/N   Tel/Fax: +39-0471-450260 / +39-0471-450253
I-39100 Bozen   Web: http://www.sad.it/~jug
-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._

You look tired.

Re: CVS: Compile problem on Solaris

[Stephan Witt]

Lars Gullik Bjønnes wrote:
 
 Kayvan A. Sylvan [EMAIL PROTECTED] writes:
 
 | On Tue, Dec 04, 2001 at 12:00:46AM +0100, Lars Gullik Bjønnes wrote:
  Ok, what is munmap's prototype on your box?
 
 | #ifdef  __STDC__
 | #if (_POSIX_C_SOURCE  2)
 | [...]
 | extern int munmap(void *, size_t);
 | [...]
 | #else
 | [...]
 | extern int munmap(caddr_t, size_t);
 
 and what is caddr_t? my guess is char*

Yes, it is.

/usr/include/sys/types.h:typedef char *caddr_t; /* ?core address type */

Stephan


[EMAIL PROTECTED] | beusen Solutions GmbH
fon: +49 30 549932-62| Landsberger Allee 366
fax: +49 30 549932-21| 12681 Berlin, Germany

Re: hard coded key bindings

[Jean-Marc Lasgouttes]

 Lars == Lars Gullik Bjønnes [EMAIL PROTECTED] writes:

Lars Andre Poenitz [EMAIL PROTECTED] writes: | Why are the hard coded
Lars key bindings in LyX::defaultKeyBindings needed? | Can't we do
Lars without?

Lars It is so that something will work even without a bind file.
Lars (albeit not much)

why would we want that? If there is no bind file, then probably all
support files (layouts are missing too), so LyX will be unusable.

JMarc

Re: lyxlength.C does not compile!

[Andre Poenitz]

On Tue, Dec 04, 2001 at 01:26:29PM +0100, Lars Gullik Bjønnes wrote:
 how can we do that?

Cleanly?  I really don't know...

Probably by having four classes (Length, Glue, ExtendedLength,
ExtendedGlue)

Hackish? Maybe we should just keep the percentage stuff in and interpret
the integer as multiple of 1/10 percent or so.  So 1PW is just
0.001\columnwidth on export/import. Really not nice, but not worse than
we have now with the benefit of getting it Right for the real units...

 - move the val_ back to int, alwasy measure in sp
 - have a conversion factory to use when a specific unit is asked for
 
 takers?

Not today. I got real work to do...

Andre'

-- 
André Pönitz .. [EMAIL PROTECTED]

Re: hard coded key bindings

[Andre Poenitz]

On Tue, Dec 04, 2001 at 01:38:06PM +0100, Jean-Marc Lasgouttes wrote:
 Lars It is so that something will work even without a bind file.
 Lars (albeit not much)
 
 why would we want that? If there is no bind file, then probably all
 support files (layouts are missing too), so LyX will be unusable.

At least I don't see a need for the num pad keybindings in a minimalistic
setting...

Andre'

-- 
André Pönitz .. [EMAIL PROTECTED]

Re: lyx over ssh tunneling X

[Dekel Tsur]

On Tue, Dec 04, 2001 at 01:14:37AM -0600, Jay Edwards wrote:
 -BEGIN PGP SIGNED MESSAGE-
 Hash: SHA1
 
 I've just installed LyX on a FreeBSD server running the latest version of 
 XFree-4.  The client is Redhat 7.2 running the latest version of XFree with 
 blackbox as a window manager.  LyX coredumps if I attempt to tunnel it 
 through an SSH session.  All other X applications run fine.  (The 
 /usr/ports/lyx/.../lyx application is not stripped -- however, my kernel is).

Does other XForms applications (e.g. fdesign) run correctly?
Do you have the correct version of XForms for your system ?

RE: [PATCH][RFC] cursor trails on inset insert

[Juergen Vigna]

On 04-Dec-2001 John Levon wrote:
 
 this removes the trail left when inserting a note into an empty
 minipage.
 
 Assuming this is wrong, what is the right fix (Juergen ?)

Well I don't see if it shouldn't be wrong, so if it fixes the behaviour
I'll plug it in ;)

 Jürgen

--
-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._
Dr. Jürgen VignaE-Mail:  [EMAIL PROTECTED]
Italienallee 13/N   Tel/Fax: +39-0471-450260 / +39-0471-450253
I-39100 Bozen   Web: http://www.sad.it/~jug
-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._

Azh nazg durbatal^_uk, azh nazg gimbatul,
Azh nazg thrakatal^_uk agh burzum ishi krimpatul!
-- J. R. R. Tolkien

Annoying LyX bugs

[Ronald Holzloehner]

Hi guys,

 Thanks to everybody who contributed to LyX! In particular, the ongoing
efforts to crank out -fix versions of LyX 1.1.6 are well appreciated.
However, in browsing the changes lists I cannot help to feel that many
bugs that got fixed are highly special, while a number of the most
annoying things never got dealt with. Here is my personal bug list of
LyX 1.1.6fix3-1:

(1)  Removing equation lines is broken as the manual points out (keys
M-e k). Will this get fixed? I currently edit the .lyx file (!) to get
rid of equation lines. Very annoying.

(2)  If I assign a label to an equation and then change my mind and
don't want the equation number to appear anymore (and remove the label),
the label would still sit in the lyx file. When I export it to latex,
latex complains about duplicate labels. This happens often when I decide
to break an equation line and want the equation number on the last line.
It would be great if Lyx could do this automatically!

(3)  BibTeX: When will LyX be able to tell that there are errors in
BibTeX's result? In particular, am I supposed to check every reference
in my document if a [?] appeared, instead of the citation number?
Highly unsatisfactory.

(4)  How can I force a rerun of BibTeX? In particular, if I remove a
citation, it won't be removed from the references list until I restart
LyX. Guys, this is a serious bug.

(5)  The citation insert dialog window is broken somehow: If you leave
the window open (i.e. just use Apply rather than OK) and edit
different citation, sometimes the Apply and OK buttons become gray
even when there are valid citations in the left field. One then either
has to reopen the dialog or remove a citation from the left window and
then reenter it.

(6)  I just installed Lyx1.1.6fix3-1 (the binary rpm) on my RedHat 7.2
box and now the rendering of eps figures in LyX is broken: It still says
rendering, but nothing appears. The same file works correctly under
older RedHat versions.

Thanks.
Ron

--
Ronald Holzloehner

Re: Annoying LyX bugs

[Jean-Marc Lasgouttes]

 Ronald == Ronald Holzloehner [EMAIL PROTECTED] writes:

Ronald Hi guys,

Hi, 

I'll just reply to a few ones.

Ronald  Thanks to everybody who contributed to LyX! In particular,
Ronald the ongoing efforts to crank out -fix versions of LyX 1.1.6
Ronald are well appreciated. However, in browsing the changes lists I
Ronald cannot help to feel that many bugs that got fixed are highly
Ronald special, while a number of the most annoying things never got
Ronald dealt with. 

The fixes which go in 1.1.6fix series are the easy ones. The goal is
to avoid to spend too much time on it (there are not enough
developpers to do that) and to make sure that each new fix version
will work flawlessly. The alternative to that is to have _no_ fix
version :(

However, lots of things are happening to 1.2.0cvs in the meantime.
This is where the real features are coming. 1.1.6fixX is only a
mintenance release, which a few new features added when I am confident
that they will not cause problems.

Ronald Here is my personal bug list of LyX 1.1.6fix3-1:

Ronald (1) Removing equation lines is broken as the manual points
Ronald out (keys M-e k). Will this get fixed? I currently edit the
Ronald .lyx file (!) to get rid of equation lines. Very annoying.

Try C-k.

Ronald (2) If I assign a label to an equation and then change my mind
Ronald and don't want the equation number to appear anymore (and
Ronald remove the label), the label would still sit in the lyx file.
Ronald When I export it to latex, latex complains about duplicate
Ronald labels. This happens often when I decide to break an equation
Ronald line and want the equation number on the last line. It would
Ronald be great if Lyx could do this automatically!

Don't know about that.

Ronald (3) BibTeX: When will LyX be able to tell that there are
Ronald errors in BibTeX's result? In particular, am I supposed to
Ronald check every reference in my document if a [?] appeared,
Ronald instead of the citation number? Highly unsatisfactory.

There is a patch floating around for such things (at least for cross
refs), it may appear in 1.2.0.


Ronald (6) I just installed Lyx1.1.6fix3-1 (the binary rpm) on my
Ronald RedHat 7.2 box and now the rendering of eps figures in LyX is
Ronald broken: It still says rendering, but nothing appears. The
Ronald same file works correctly under older RedHat versions.

Which version of ghostscript do you have installed? I think versions
6.00-6.52 are buggy wrt what LyX needs.

JMarc

bug report: inserting label in math display doesn't work

[Tuukka Toivonen]

1. Load the attached file buglabel.lyx
2. Move the cursor inside the display math, on the line which reads
   TryInsertingLabelHere.
3. Select from menu Insert/Label..., type a label and press ok.
   The label should be displayed in the math number position,
   but it is not.

Notes:
- Lyx versions 1.1.6fix2 and fix3 tested, both buggy
- I didn't try what TeX output looks like... don't now if ok
- I'm not subscribed here (but on -users), so cc would be
  nice--althought the bug is not a problem, workaround is easy


#LyX 1.1 created this file. For more info see http://www.lyx.org/
\lyxformat 218
\textclass article
\language english
\inputencoding auto
\fontscheme default
\graphics default
\paperfontsize default
\spacing single 
\papersize Default
\paperpackage a4
\use_geometry 0
\use_amsmath 0
\paperorientation portrait
\secnumdepth 3
\tocdepth 3
\paragraph_separation indent
\defskip medskip
\quotes_language english
\quotes_times 2
\papercolumns 1
\papersides 1
\paperpagestyle default

\layout Standard


\begin_inset Formula \begin{eqnarray}
\phi _{\textrm{min}}\left( a\right)   =  \left\{ \begin{array}{ll}
0,  a=0\\
ad+1,  a0
\end{array}\right. \label{cbmemin} \\
\phi _{\textrm{max}}\left( a\right)   =  \left\{ \begin{array}{ll}
d-1,  a=0\\
TryInsertingLabelHere  a0\label{xxx} 
\end{array}\right. .
\end{eqnarray}

\end_inset 


\the_end

bug report: can write in math boxes with read-only documents

[Tuukka Toivonen]

Since I'm in the mood of sending bug reports, here's another.

1. Select Help/User's Guide (or something). This loads a new
   documents, which is set to read-only.
2. Move the cursor inside a pre-existing math box and type
   something.

   The text appears, althought it shouldn't since
   the document is read only. It is not possible to _create_
   a math box, it must already exist.

Version 1.1.6fix3 tested.

Re: CVS: Linux compile problem

[Kayvan A. Sylvan]

On Tue, Dec 04, 2001 at 01:16:58PM +0100, Lars Gullik Bjønnes wrote:
 | it to a lib.
 | A fix went in today adding an include for cmath in lyxlength.C
 | Maybe it is not right for all cases.
 | Garst
 
 try to add a std::abs on that abs if not already done.

This fixed my compile problem:

Index: lyxlength.C
===
RCS file: /cvs/lyx/lyx-devel/src/lyxlength.C,v
retrieving revision 1.2
diff -u -r1.2 lyxlength.C
--- lyxlength.C 2001/12/03 13:17:01 1.2
+++ lyxlength.C 2001/12/04 16:42:08
@@ -19,6 +19,7 @@
 #include Lsstream.h
 
 #include cmath
+#include stdlib.h
 
 namespace {
 // this is now here and in lyxgluelength.C

-- 
Kayvan A. Sylvan  | Proud husband of   | Father to my kids:
Sylvan Associates, Inc.   | Laura Isabella Sylvan  | Katherine Yelena (8/8/89)
http://sylvan.com/~kayvan | crown of her husband | Robin Gregory (2/28/92)

Re: patches 4 lyx persian support based on isiri

[Jean-Marc Lasgouttes]

 Lars == Lars Gullik Bjønnes [EMAIL PROTECTED] writes:

Lars [EMAIL PROTECTED] writes: | hi | thanks 4 your patiance .
Lars | please see attachment. file patch.txt describe changes. | it
Lars works with both 1.1.6fix3  1.1.6fix2. | i add isiri encoding to
Lars it. | keymap file is attached too (persian3342.kmap). | with
Lars best regards | Mehdi Adibi | [EMAIL PROTECTED]

Lars Ok, I am pretty sure that Jean-Marc will not want this to into
Lars the 1.1.6 branch.

Indeed.

Lars Would it be possible for you to create patches for this against
Lars current CVS instead?

More precisely, we would like patch created with diff -u, not
textual dscriptions of what you have done. Note that I am not
competent to judge those patch, I am just trying to get something ton
which competent people (for example Dekel Tsur) will be able to comment.

Thanks,
JMarc

Re: CVS: Linux compile problem

[Kayvan A. Sylvan]

On Tue, Dec 04, 2001 at 05:49:19PM +0100, Lars Gullik Bjønnes wrote:
 Kayvan A. Sylvan [EMAIL PROTECTED] writes:
 
 | On Tue, Dec 04, 2001 at 01:16:58PM +0100, Lars Gullik Bjønnes wrote:
  | it to a lib.
  | A fix went in today adding an include for cmath in lyxlength.C
  | Maybe it is not right for all cases.
  | Garst
  
  try to add a std::abs on that abs if not already done.
 
 | This fixed my compile problem:
 
 Hmm can you try to remove cmath as well?

Yes, that works as well.

-- 
Kayvan A. Sylvan  | Proud husband of   | Father to my kids:
Sylvan Associates, Inc.   | Laura Isabella Sylvan  | Katherine Yelena (8/8/89)
http://sylvan.com/~kayvan | crown of her husband | Robin Gregory (2/28/92)

Re: bug report: inserting label in math display doesn't work

[Dekel Tsur]

On Tue, Dec 04, 2001 at 06:39:18PM +0200, Tuukka Toivonen wrote:
 1. Load the attached file buglabel.lyx
 2. Move the cursor inside the display math, on the line which reads
TryInsertingLabelHere.
 3. Select from menu Insert/Label..., type a label and press ok.
The label should be displayed in the math number position,
but it is not.
 
 Notes:
 - Lyx versions 1.1.6fix2 and fix3 tested, both buggy
 - I didn't try what TeX output looks like... don't now if ok
 - I'm not subscribed here (but on -users), so cc would be
   nice--althought the bug is not a problem, workaround is easy

Fixed in 1.2.0

Re: bug report: can write in math boxes with read-only documents

[Dekel Tsur]

On Tue, Dec 04, 2001 at 06:43:34PM +0200, Tuukka Toivonen wrote:
 Since I'm in the mood of sending bug reports, here's another.
 
 1. Select Help/User's Guide (or something). This loads a new
documents, which is set to read-only.
 2. Move the cursor inside a pre-existing math box and type
something.
 
The text appears, althought it shouldn't since
the document is read only. It is not possible to _create_
a math box, it must already exist.
 
 Version 1.1.6fix3 tested.
 

Fixed in 1.2.0

Re: Annoying LyX bugs

[Dekel Tsur]

On Tue, Dec 04, 2001 at 11:24:54AM -0500, Ronald Holzloehner wrote:

 (1)  Removing equation lines is broken as the manual points out (keys
 M-e k). Will this get fixed? I currently edit the .lyx file (!) to get
 rid of equation lines. Very annoying.

This is already fixed in lyx 1.2.0

 (2)  If I assign a label to an equation and then change my mind and
 don't want the equation number to appear anymore (and remove the label),
 the label would still sit in the lyx file. When I export it to latex,
 latex complains about duplicate labels. This happens often when I decide
 to break an equation line and want the equation number on the last line.
 It would be great if Lyx could do this automatically!

Fixed in 1.2.0

 (3)  BibTeX: When will LyX be able to tell that there are errors in
 BibTeX's result? In particular, am I supposed to check every reference
 in my document if a [?] appeared, instead of the citation number?

No. You can just check the output of bibtex which is printed to the shell.

 Highly unsatisfactory.
 
 (4)  How can I force a rerun of BibTeX? In particular, if I remove a
 citation, it won't be removed from the references list until I restart
 LyX. Guys, this is a serious bug.

Lyx 1.1.6fix3 should detect removing of citations and run bibtex
automatically.
If this doesn't happen for you, then please create a minimal example file
and send it here.

 (5)  The citation insert dialog window is broken somehow: If you leave
 the window open (i.e. just use Apply rather than OK) and edit
 different citation, sometimes the Apply and OK buttons become gray
 even when there are valid citations in the left field. One then either
 has to reopen the dialog or remove a citation from the left window and
 then reenter it.

I think this was fixed in 1.2.0 (though there are still some cases where the
apply/ok buttons become disable when they shouldn't).

Re: hard coded key bindings

[John Weiss]

On Tue, Dec 04, 2001 at 01:53:22PM +0100, Lars Gullik Bjønnes wrote:
 Andre Poenitz [EMAIL PROTECTED] writes:
 
 | On Tue, Dec 04, 2001 at 01:38:06PM +0100, Jean-Marc Lasgouttes wrote:
  Lars It is so that something will work even without a bind file.
  Lars (albeit not much)
  
  why would we want that? If there is no bind file, then probably all
  support files (layouts are missing too), so LyX will be unusable.

I would recommend limiting the default, built-in bindings to ones for
the Help menu, ones for OK, Cancel, Yes, and No buttons (if
these aren't built into GUITKs already) and one for Quit LyX.  This
way, a user with a broken installation can at least get help and quit.

-- 
John Weiss

/dev/i/kali  'rm -rf /bin/laden'

Re: Some bug fixes

[John Levon]

On Tue, Dec 04, 2001 at 02:46:10PM +1000, Allan Rae wrote:

  Who the hell is Jerry Springer! #:O)
 
 Yet another American talk show host (YAATSH) who relies on the 5 C's
 of communication:
   Confrontation,
   Cursing,
   Confusion,
   Conceit,
   Corruption
 

heh :)

of course, as usual, the best satire of it would be the simpson's one ;)

john


-- 
Faced with the prospect of rereading this book, I would rather have 
 my brains ripped out by a plastic fork.
- Charles Cooper on Business at the Speed of Thought 

Re: [PATCH][RFC] cursor trails on inset insert

[John Levon]

On Tue, Dec 04, 2001 at 05:11:34PM +0100, Juergen Vigna wrote:

  
  this removes the trail left when inserting a note into an empty
  minipage.
  
  Assuming this is wrong, what is the right fix (Juergen ?)
 
 Well I don't see if it shouldn't be wrong, so if it fixes the behaviour
 I'll plug it in ;)
 
  Jürgen

another success for random walk patching ;)

you can also do showInsetCursor(bv, false) to fix it too. I don't know
which is better - you do ... so please apply :)

john

-- 
Faced with the prospect of rereading this book, I would rather have 
 my brains ripped out by a plastic fork.
- Charles Cooper on Business at the Speed of Thought 

Re: tabular dialog

[John Levon]

On Tue, Dec 04, 2001 at 09:15:34AM +0100, Andre Poenitz wrote:

 On Tue, Dec 04, 2001 at 09:01:21AM +0100, Juergen Vigna wrote:
  Well then let me sum for you. We agreed that we should change to a
  Apply/Ok policy also for the tabular-dialog, but this would involve
  a major rewrite of the TabularFeatures and the dialog so we decided to
  leave this for 1.3.0.
 
 Very kind of you.

can we add a dialog on pressing close if the text has been changed since
opening the dialog to ask if it should be applied ?

would be a useful workaround

john

-- 
Faced with the prospect of rereading this book, I would rather have 
 my brains ripped out by a plastic fork.
- Charles Cooper on Business at the Speed of Thought 

Re: [PATCH] fix some inset-in-inset update problems

[John Levon]

On Tue, Dec 04, 2001 at 10:38:14AM +0100, Juergen Vigna wrote:

 Well let's say that we agree that we could change something in the
 logic in the future (and I'm not sure it will be in 1.3 as I really
 would like to have the main-view GUIIfied in 1.3, some added features
 but nothing which redoes a lot of code. We HAVE to finish GUII as fast
 as possible IMO.

violently agree here, as do the utilitarianists ;)

john

-- 
Faced with the prospect of rereading this book, I would rather have 
 my brains ripped out by a plastic fork.
- Charles Cooper on Business at the Speed of Thought 

Re: Annoying LyX bugs

[John Levon]

On Tue, Dec 04, 2001 at 11:24:54AM -0500, Ronald Holzloehner wrote:

 (6)  I just installed Lyx1.1.6fix3-1 (the binary rpm) on my RedHat 7.2
 box and now the rendering of eps figures in LyX is broken: It still says
 rendering, but nothing appears. The same file works correctly under
 older RedHat versions.

If you want to see something done about this, please complain to RedHat.
The bug is here :

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=55772

regards
john

-- 
Faced with the prospect of rereading this book, I would rather have 
 my brains ripped out by a plastic fork.
- Charles Cooper on Business at the Speed of Thought 

Re: layout-Paragraph and stippled lines

[John Levon]

On Tue, Dec 04, 2001 at 08:32:08PM +0100, Lars Gullik Bjønnes wrote:

 I see from a paragraph with stippled lines in UserGuide.lyx that it
 writes the lines even if the space type is NONE and the lenght is set.

What does it mean for this to happen ? How can length be set when
the type is none ? Also, look at text.C - I check explicitly against ::LENGTH
so I'm not sure how this happens.

john

-- 
Faced with the prospect of rereading this book, I would rather have 
 my brains ripped out by a plastic fork.
- Charles Cooper on Business at the Speed of Thought 

Bugs for 1.2.0pre1 ?

[John Levon]

Well, loads of things just got fixed. This leaves before a pre1 IMHO :

1) the inseterror stuff (some of the way there ...)

2) can't set cursor to inside an inset (nagivate to figure) - there's
some chitchat in the source but it's still broke ...

3) what else ?

It doesn't look like anything is going to happen soon with regards
to insetgraphics. We can live with this for a prerelease, but /somebody/
needs to fix it before 1.2.0 - it's just too annoying having synchronous
rendering.

regards
john

-- 
Faced with the prospect of rereading this book, I would rather have 
 my brains ripped out by a plastic fork.
- Charles Cooper on Business at the Speed of Thought 

New redo update bug

[John Levon]

insert a tabular in a tabular in a tabular in a new document. undo undo undo, redo,
redo - drawn wrongly.

I suppose some update is missing from the redo stuff Juergen ?

thanks
john

-- 
Faced with the prospect of rereading this book, I would rather have 
 my brains ripped out by a plastic fork.
- Charles Cooper on Business at the Speed of Thought 

Re: Bugs for 1.2.0pre1 ?

[John Levon]

On Tue, Dec 04, 2001 at 08:47:26PM +0100, Lars Gullik Bjønnes wrote:

 Is InsetGraphics turned on by default now?

don't think so. I'd really rather not punt it though, figinset sucks
...

 (if that is the case it has severe bugs... none of my graphics
 renders.

if you could send me small example files ... I'll look

 are there any compability code in? or must the change to
 insetgraphcis be done manually?)

I see compat reading code, but I don't know if it works.

john

-- 
Faced with the prospect of rereading this book, I would rather have 
 my brains ripped out by a plastic fork.
- Charles Cooper on Business at the Speed of Thought 

Re: cut/paste in tabular; append row missing

[John Levon]

On Tue, Dec 04, 2001 at 02:57:11PM -0500, Richard E. Hawkins wrote:

 It does not appear to be possible any longer to add a row to an 
 existing tabular save at the end.  What happened to append row?

works fine for me. Can you do :

control-x tabular-feature append-row

?

(btw, everyone, what is tab-insert for ?)

 Also, it is very difficult to select a group of cells in a 
 tabular--once the little red box appears, I seem to need to click 
 elsewhere to move it, and then position *very* carefully in order not 
 to reactivate it.  Otherwise, even though the large multi-cell regions 
 shows as selected, and is all deleted in a cut, the contents of the 
 clipboard apparently do not change.

Please give an example file and detailed method (cell nr's etc.)

thanks
john

-- 
Faced with the prospect of rereading this book, I would rather have 
 my brains ripped out by a plastic fork.
- Charles Cooper on Business at the Speed of Thought 

InsetError code crash also elsewhere

[John Levon]

playing with insettabular (can't reproduce :() I get again :

#6  Row::par (this=0x0) at lyxrow.h:92
#7  0x80ec756 in LyXText::init (this=0x83bf720, bview=0x836cd30, reinit=false) at 
text2.C:97
#8  0x80ef18e in LyXText::fullRebreak (this=0x83bf720, bview=0x836cd30) at text2.C:937
#9  0x81482b6 in InsetText::updateLocal (this=0x83b4f00, bv=0x836cd30, what=1, 
mark_dirty=false) at insettext.C:633
#10 0x81485f8 in InsetText::edit (this=0x83b4f00, bv=0x836cd30, x=12, y=-2, button=1) 
at insettext.C:685
#11 0x814358e in InsetTabular::activateCellInset (this=0x83b0598, bv=0x836cd30, x=12, 
y=-2, button=1, behind=false) at insettabular.C:1977
#12 0x814364c in InsetTabular::activateCellInsetAbs (this=0x83b0598, bv=0x836cd30, 
x=115, y=90, button=1) at insettabular.C:1991
#13 0x813ef21 in InsetTabular::insetButtonPress (this=0x83b0598, bv=0x836cd30, x=115, 
y=90, button=1) at insettabular.C:751
#14 0x805fd64 in BufferView::Pimpl::workAreaButtonPress (this=0x836e368, xpos=115, 
ypos=90, button=1) at BufferView_pimpl.C:600

I think this was the same trace I got from the inseterror patch.

I guess this counts as a serious crash :)

Juergen - I had previously been doing some cuts from cell selects in a table,
at time of crash I was hitting an insettext in another cell.

john


-- 
Faced with the prospect of rereading this book, I would rather have 
 my brains ripped out by a plastic fork.
- Charles Cooper on Business at the Speed of Thought 

Re: Bugs for 1.2.0pre1 ?

[John Levon]

On Tue, Dec 04, 2001 at 09:04:32PM +0100, Lars Gullik Bjønnes wrote:

  (if that is the case it has severe bugs... none of my graphics
  renders.
 
 | if you could send me small example files ... I'll look
 
 I see it with UserGuide.lyx, probably my gs version. (6.51-16)

yep.

I'll see what happens when I enable the compat code !

john
-- 
Faced with the prospect of rereading this book, I would rather have 
 my brains ripped out by a plastic fork.
- Charles Cooper on Business at the Speed of Thought 

Re: InsetError code crash also elsewhere

[John Levon]

On Tue, Dec 04, 2001 at 08:08:32PM +, John Levon wrote:

 I think this was the same trace I got from the inseterror patch.

I tell a lie - row was still 0 though ;)

john

-- 
Faced with the prospect of rereading this book, I would rather have 
 my brains ripped out by a plastic fork.
- Charles Cooper on Business at the Speed of Thought 

Minor cursor trail in tabular

[John Levon]

select an set of cells in an empty table and press a key.

the text will be inserted in the last cell after the selection
is cleared (good). but there will be a blue-background cursor
trail, e.g. two cells above. I've also seen it appear below
the tabular, inside the grey murk at the end of a document .

does the update of the child text ensure that the selection gets
cleared ? If so, I assume there needs to be a hideInsetCursor or
so somewhere ? but where ?

thanks
john

-- 
Faced with the prospect of rereading this book, I would rather have 
 my brains ripped out by a plastic fork.
- Charles Cooper on Business at the Speed of Thought 

\epsilon bug

[Chris Eliasmith]

Hi,

Thanks so much for a great package everyone. One little
annoyance: typing \epsilon in math mode doesn't give you
the epsilon sign. All the other greek characters seem to
work fine.

version: 1.1.6 fix 2

Thanks,
Chris.

Re: Bug list - another major update

[Michael Schmitt]

John Levon wrote:

- Menu items Layout = XXX Style are not updated for mathed
 
 do you want them disabled or what ?


This is one possibility. But doesn't math modus provide 
equivalent/similar attributes?

Michael

Re: \epsilon bug

[Dekel Tsur]

On Tue, Dec 04, 2001 at 04:16:23PM -0500, Chris Eliasmith wrote:
 Thanks so much for a great package everyone. One little
 annoyance: typing \epsilon in math mode doesn't give you
 the epsilon sign. All the other greek characters seem to
 work fine.
 
 version: 1.1.6 fix 2

This is deliberate: the X symbol font contains a glyph for \varepsilon and
not for \epsilon.
LyX 1.2.0 will be able to use the type1 Postscript font that are distributed
with latex, so it will be able to display \epsilon (and most of the symbols).

Re: decimal percent

[Dekel Tsur]

On Tue, Dec 04, 2001 at 10:26:01PM +0100, Lars Gullik Bjønnes wrote:
 
 Do we really need to be able keep 0.1% and the like? Isn't interger
 percentages good enough?
 (lyxlength if you didn't understand it)

Why do you want to limit the users ?
Does this limitation greatly simplifies the code?

Re: Bug list - another major update

[John Levon]

On Tue, Dec 04, 2001 at 11:07:36PM +0100, Michael Schmitt wrote:

 Either blank - or it proposes the content of the caption (might be a 
 little bit too advanced?).

where would this come from exactly ?

 I works now. However, if the inlined ERT is not empty, you cannot click 
 into its right half. Look like a known problem...

indeed. Juergen has fixed it - try again

 - Load file scary_eqns.lyx and try to click at the last subscript 0 in 
 a formula called philinear
- the cursor is positioned past the formula 
 
 actually, this looks suspiciously like the RHS of insets bug, which is 
 fixed. Let me look at this one ...
 
 
 No, it's still there...

I know, I meant let me look as I might be able to fix this unless it's
in mathed where the problem is.

 
 ? Remove all error boxes does not remove error boxes from within 
 minipages
 
 I have fixed this ... still no review ...
 
 No time to check this so far (I lost the original example). The '?' 
 indicates that I know about your fix..

oops missed ?.

 - Clicking into the right half of a footnote does not work (wrong cursor 
  placement) if there is some plain text after the footnote in the _same_ 
  paragraph (#451276)
 fixed !
 
 Partially. The error still occurs if there is footnote after the footnote.

argh. So we need to move the cursor not just one back, but to the right position
I guess.

regards
john

-- 
Faced with the prospect of rereading this book, I would rather have 
 my brains ripped out by a plastic fork.
- Charles Cooper on Business at the Speed of Thought 

Re: Bug list - another major update

[John Levon]

On Tue, Dec 04, 2001 at 11:29:49PM +0100, Michael Schmitt wrote:

 - Append a column after the _last_ column in a table:
 
 I don't get this one. Are you sure you had Juergen's /most/ recent changes 
 in ?
 
 It's still there.

can anyone else see it ? can you reproduce every time ?

 msg2=@0xbfffdbec, msg3=@0xbfffdbdc) at lyx_cb.C:122
 how odd. can you create a smaller example file ?
 
 Not now. Next weekend.

thanks.

  have at minimum vertical space (on screen) such that the message is fully 
  printed.
 
 Well I totally disagree. Not a bug !
 
 Why not? If you convince me, I will remove it from my list :-)

I lost the argument on this one ...

regards
john

-- 
Faced with the prospect of rereading this book, I would rather have 
 my brains ripped out by a plastic fork.
- Charles Cooper on Business at the Speed of Thought 

Re: lyxlength.C does not compile!

[Allan Rae]

On Tue, 4 Dec 2001, Lars Gullik Bjønnes wrote:

 Allan Rae [EMAIL PROTECTED] writes:

 | On Mon, 3 Dec 2001, Lars Gullik Bjønnes wrote:
 
  Juergen Vigna [EMAIL PROTECTED] writes:
 
  | c++ -DHAVE_CONFIG_H -I. -I. -I. -I.. -I.. -I../boost -I/usr/include   -isystem
  | /usr/X11R6/include  -g  -fno-exceptions -W -Wall -c lyxlength.C
  | lyxlength.C: In method `const string LyXLength::asLatexString ()
  | const':
  | lyxlength.C:80: `abs' undeclared (first use this function)
  | lyxlength.C:80: (Each undeclared identifier is reported only once for
  | each function it appears in.)
  
  | Any fast fix?
 
  Including cmath?
 
 | Who wrote this code from lyxlength.C:82:
 
 | buffer  abs(static_castint(val_/100))  .
 |  abs(static_castint(val_)%100)
 |  \\columnwidth;
 
 | gcc-2.95.3 doesn't like this at all because there is no abs(int)
 | function.  There are a few other cases like that in that file.

 abs is an overloaded function, surely there are an int version.

 it really is the compiler/lib that is wrong not the code.

Well I've just committed what should hopefully select the right header
so abs(int) is found.  That will at least get it compiling again for
more people (I hope).

It seems there is now some uncertainty about how to handle the
percentage lengths although it seems everyone wants to go back to an
int.

Would you accept the pairint, int proposal?  Or would you prefer to
have a:
union {
int sp_length;
float percentage;
} val_;

and decide how to read it based on the unit (a bool could cache the
result of the unit test).  The pairint, int proposal would make it
heaps easier to control the number of significant digits after the
decimal point.  Then again do we really need to do any limiting of the
percentage other than range limiting of 0 - 100 percent? (actually we
need a range of 0 - 1 for the output)

 | In addition it seems that what you were trying to write was:
 
 | buffer  abs(floor(val_/100))  .
 |  abs(floor(val_%100))
 |  \\columnwidth;
 
 | So why not write it in the first place?  Because you were trying to be
 | tricky and cheat?

 because floor is a fairly seldom used function by many... so instead
 of snide remarks, provide a patch with the cleanup.
 (all todays are not fridays)

So we shouldn't use language standard functions and features that are
not used regularly by the majority of the LyX developers?  Is that in
the Code_Rules too?

;-)
Allan. (ARRae)

Re: decimal percent

[Allan Rae]

On Tue, 4 Dec 2001, Lars Gullik Bjønnes wrote:


 Do we really need to be able keep 0.1% and the like? Isn't interger
 percentages good enough?
 (lyxlength if you didn't understand it)

Actually if you look at the code in lyxlength.C we are already
limiting users to integer percentages.

We store 0-100 (range limited by the GUI) and when written out we get
the range:
0.00 - 1.00

And that's with all the significant digits visible too.

So we should in fact be able to get rid of the call to abs() if we can
ensure that lengths that should be unsigned are unsigned (ie.
positive).  That would be a frontend range checking thing -- figure
sizes should only be positive for example likewise table column
widths.

Allan. (ARRae)

Re: [PATCH] fix some inset-in-inset update problems

[Allan Rae]

On Tue, 4 Dec 2001, Juergen Vigna wrote:

 On 04-Dec-2001 Allan Rae wrote:

  Then we should only need to use the same two cursors to do anything.
  The second one only needed for selections.

 We don't the stuff is a bit more complicated when updates and redraws
 are involved. But I would say if you know all of it why don't you start
 coding and so you can proove us that you're right. I would surely be
 happy about that!

I guess from this you are referring to the need to know which parts of
the document are visible -- that is, which _rows_ are visible.  Do we
need a cursor for that?  Maybe I'm just being pedantic but while we
could use the Cursor class needed to make selections to mark the
limits of visible rows they aren't user-visible or user-interactive
cursors.

Anyway, it seems we might need perhaps 5 cursors in total.  The two
user-visible I mentioned originally, the two for marking visible
boundaries and another for iterating through the visible area for
updating.

These are document global (stored in BufferView or should it be
LyXText?) and passed down the inset hierarchy as needed.  There
shouldn't really be any need for an inset to maintain its own cursor
-- there will certainly need to be an iterator added to the cursor
stack when an inset-in-an-inset is encountered but that is the
document-global cursor.

So does this sound more complete or do you see a need yet another
cursor somewhere?

Allan. (ARRae)

Re: [PATCH] fix some inset-in-inset update problems

[Allan Rae]

On Tue, 4 Dec 2001, Juergen Vigna wrote:

 On 04-Dec-2001 Juergen Vigna wrote:

  And what if the inset-pointer changed in the meantime (Undo/Redo)?

The insets allocated memory is at the same place isn't it?  Wouldn't a
signal connection be sufficient?  Or a table of waiting-insets and the
process they are waiting for a (UNIX) signal from?

 No IMO that theLockingInset() stuff is pretty good and easy. It only
 goes one direction and is only there if we really enter an inset. We
 could do it with the cursor, but IMO we would add complex handling not
 remove it.

 While the above update has nothing to do with neighter cursor nor
 theLockingInset() we just have to have a good iterator and we'll find
 the inset which want's to be updated quite fast!

I wrote the fastest inset finder/iterator in the universe a few years
ago based on a signal.  But that was overkill.

 Anyway the update/redraw process has do go from the outermost inset to
 the innermost inset and back again and we have this more or less already
 BufferView::updateInset(inset-to-update), the theLockingInset mechanism
 is IMO only a shortcut as 98% of the update stuff (or more) most probably
 will occur in the spot where we're actually editing.

98%, so you agree that most stuff happens at the cursor.  It seems
that InsetGraphics is the only example anyone has offered

 So IMO we won't need any complicated cursor as we don't have to know
 the outer inset if we access the whole stuff from the right direction.
 Much of the code there was written long time ago and build up on each
 other. The whole Inset hierarchy has to be rethought, as I already pointed
 out with my mail about the need of a ContainerInset.

Sure and we are influencing how that Inset hierarchy rethink might go
by discussing new ways of maintaining positions (cursors).

 But as I also said before I don't see this done neighter in 1.2 nor in 1.3
 as I see other priorities. I think that this should be done after we have
 GUII finished as then we also have a cleaner base to build on and redo
 this old code.

 I hope we agree all that GUII should have precedence in 1.3 and that we
 shouldn't wait another 3 year for the 1.3 release, but it should go out
 quite fast.

I don't think anyone will have a problem with this.

There is no need to rush to switch to stacked cursors.  The current
code is sufficient for the time being.  But as the inset heirarchy is
rethought yet further the possibility of revising cursor operation
should not be overlooked.

Allan. (ARRae)I love stacks.

Re: decimal percent

[Allan Rae]

On Wed, 5 Dec 2001, Lars Gullik Bjønnes wrote:

 Allan Rae [EMAIL PROTECTED] writes:

 | On Tue, 4 Dec 2001, Lars Gullik Bjønnes wrote:
 
 
  Do we really need to be able keep 0.1% and the like? Isn't interger
  percentages good enough?
  (lyxlength if you didn't understand it)
 
 | Actually if you look at the code in lyxlength.C we are already
 | limiting users to integer percentages.

 Does lyxlength impose this restriction?

By implication of the fact that we only write out two decimal places
for percentages in lyxlength.C:
1.00 = 100%

we have just limited ourselves to integer percentages.   That's the
effect of the val_%100

lyxlength doesn't impose any range limits though.  It would be nice to
setup a range checking function for lyxlengths to assist the frontends
so that they make sure we don't exceed (2^30 - 1)sp since as The TeX
Book states: ...the maximum legal dimension is slightly less than
16384pt.

Or about 5758.3mm.

The frontends need to ensure a user doesn't try entering anything
bigger.

 | We store 0-100 (range limited by the GUI) and when written out we get
 | the range:
 | 0.00 - 1.00

 that range otoh is a severe limitation since then 1.666\columnwidth is
 not possible. and it really should be.

Actually it seems the range limiting function isn't used for the
figure inset anymore.  As a result you can set the size to -200.5% of
column width which naturally enough causes the figure rendering to
fail.

So we don't have the range limiting we used to but we also don't
ensure that dumb entries like negative sizes for figures can't be
entered.

Note that we still write:
-2.005\columnwidth

for the length in the figure inset because it doesn't use lyxlengths.
It just does a tostr(f/100) where f is the size as a float.

 | And that's with all the significant digits visible too.
 
 | So we should in fact be able to get rid of the call to abs() if we can
 | ensure that lengths that should be unsigned are unsigned (ie.
 | positive).

 and actually we should support negative values as well, I belive that
 latex supports them:

  -0.2\columnwidth

I didn't say we shouldn't support them. I'm saying we should make sure
negative values are only entered where they are valid -- or that only
positive values are entered where only positive values are valid.

 |  That would be a frontend range checking thing -- figure
 | sizes should only be positive for example likewise table column
 | widths.

See like I said here.

Allan. (ARRae)

Inserting in ERT

[John Levon]

I can insert a footnote with copy/paste into an insetERT.

Looking, I see insettext::insetAllowed() basically always returns yes.

What's going on ?

john

-- 
Faced with the prospect of rereading this book, I would rather have 
 my brains ripped out by a plastic fork.
- Charles Cooper on Business at the Speed of Thought 

[BUG] Row == 0 crash, example file

[John Levon]

The attached file crashes lyx.

thanks
john

-- 
Faced with the prospect of rereading this book, I would rather have 
 my brains ripped out by a plastic fork.
- Charles Cooper on Business at the Speed of Thought 


#LyX 1.1 created this file. For more info see http://www.lyx.org/
\lyxformat 218
\textclass article
\language ngerman
\inputencoding latin1
\fontscheme pslatex
\graphics default
\paperfontsize 10
\spacing single 
\papersize a4paper
\paperpackage a4
\use_geometry 1
\use_amsmath 0
\paperorientation portrait
\leftmargin 0.9cm
\topmargin 0.6cm
\rightmargin 1.5cm
\bottommargin 0.9cm
\headheight 0.3cm
\headsep 0.4cm
\footskip 0.7cm
\secnumdepth 3
\tocdepth 3
\paragraph_separation indent
\defskip medskip
\quotes_language polish
\quotes_times 2
\papercolumns 2
\papersides 2
\paperpagestyle default

\layout Section*

Minipages
\layout Standard
\pextra_type 2 \pextra_alignment 0 \pextra_hfill 1 \pextra_start_minipage 1 
\pextra_widthp 45

Dies soll jetzt an einem will\SpecialChar \-
kür\SpecialChar \-
lichen Bei\SpecialChar \-
spiel ge\SpecialChar \-
zeigt werden, bei dem
 dieser Text wiederholt in der Minipage erscheint, wobei eine Breite von
 45% für die linke und 40% für die rechte Minipage vorgesehen wurden.
 Auch das Einfügen von Formeln ist kein Problem: Und Fußnoten sind auch
 möglich!
\layout Standard
\pextra_type 2 \pextra_alignment 0 \pextra_hfill 1 \pextra_start_minipage 1 
\pextra_widthp 40

Dies soll jetzt an einem will\SpecialChar \-
kür\SpecialChar \-
lichen Bei\SpecialChar \-
spiel ge\SpecialChar \-
zeigt werden, bei dem
 dieser Text wiederholt in der Minipage erscheint, wobei eine Breite von
 45% für die linke und 40% für die rechte Minipage vorgesehen wurden.
 Auch das Einfügen von Formeln ist kein Problem:Und Fußnoten sind auch möglich!
\the_end

[PATCH] fix formpara a bit

[John Levon]

fixed 

 479849minipage in figure float properties

(allan's bug)

please apply

thanks
john


-- 
Faced with the prospect of rereading this book, I would rather have 
 my brains ripped out by a plastic fork.
- Charles Cooper on Business at the Speed of Thought 


Index: src/frontends/xforms/ChangeLog
===
RCS file: /usr/local/lyx/cvsroot/lyx-devel/src/frontends/xforms/ChangeLog,v
retrieving revision 1.203
diff -u -r1.203 ChangeLog
--- src/frontends/xforms/ChangeLog  2001/11/29 11:20:56 1.203
+++ src/frontends/xforms/ChangeLog  2001/12/05 04:12:59
@@ -1,3 +1,7 @@
+2001-12-05  John Levon  [EMAIL PROTECTED]
+
+   * FormParagraph.C: get the right LyXText !
+ 
 2001-11-29  John Levon  [EMAIL PROTECTED]
 
* FormParagraph.C: disallow page breaks in insets
Index: src/frontends/xforms/FormParagraph.C
===
RCS file: /usr/local/lyx/cvsroot/lyx-devel/src/frontends/xforms/FormParagraph.C,v
retrieving revision 1.42
diff -u -r1.42 FormParagraph.C
--- src/frontends/xforms/FormParagraph.C2001/11/29 11:20:56 1.42
+++ src/frontends/xforms/FormParagraph.C2001/12/05 04:12:59
@@ -65,10 +65,7 @@
 {
LyXText * text = 0;
 
-   if (lv_-view()-theLockingInset())
-   text = lv_-view()-theLockingInset()-getLyXText(lv_-view());
-   if (!text)
-   text = lv_-view()-text;
+   text = lv_-view()-getLyXText();
return text-cursor.par();
 }
 
@@ -278,11 +275,7 @@
 }
 
 Spacing const spacing(linespacing, other_linespacing);
-LyXText * text = 0;
-if (lv_-view()-theLockingInset())
-   text = lv_-view()-theLockingInset()-getLyXText(lv_-view());
-if (!text)
-   text = lv_-view()-text;
+LyXText * text(lv_-view()-getLyXText());
 text-setParagraph(lv_-view(), line_top, line_bottom, pagebreak_top,
   pagebreak_bottom, space_top, space_bottom, spacing,
align, labelwidthstring, noindent);

[PATCH] added space

[John Levon]

as Lars + others requested ...

please apply

thanks
john

-- 
Faced with the prospect of rereading this book, I would rather have 
 my brains ripped out by a plastic fork.
- Charles Cooper on Business at the Speed of Thought 


Index: src/ChangeLog
===
RCS file: /usr/local/lyx/cvsroot/lyx-devel/src/ChangeLog,v
retrieving revision 1.432
diff -u -r1.432 ChangeLog
--- src/ChangeLog   2001/12/04 16:35:38 1.432
+++ src/ChangeLog   2001/12/05 04:15:27
@@ -1,3 +1,8 @@
+2001-12-05  John Levon  [EMAIL PROTECTED]
+
+   * lyxtext.h:
+   * text.C: better added space drawing
+ 
 2001-12-04  John Levon  [EMAIL PROTECTED]
 
* text.C: fix chapter label offset !
Index: src/lyxtext.h
===
RCS file: /usr/local/lyx/cvsroot/lyx-devel/src/lyxtext.h,v
retrieving revision 1.100
diff -u -r1.100 lyxtext.h
--- src/lyxtext.h   2001/12/04 16:32:14 1.100
+++ src/lyxtext.h   2001/12/05 04:15:29
@@ -590,6 +590,13 @@
/// paint env depth bar 
void paintRowDepthBar(DrawRowParams  p);
  
+   /// get the on-screen size of the length marker
+   int getLengthMarkerHeight(BufferView * bv, VSpace const  vsp) const;
+ 
+   /// paint an added space marker
+   int drawLengthMarker(DrawRowParams  p, string const  str,
+   VSpace const  vsp, int start); 
+ 
/// paint a first row in a paragraph
void paintFirstRow(DrawRowParams  p);
  
Index: src/text.C
===
RCS file: /usr/local/lyx/cvsroot/lyx-devel/src/text.C,v
retrieving revision 1.208
diff -u -r1.208 text.C
--- src/text.C  2001/12/04 16:35:38 1.208
+++ src/text.C  2001/12/05 04:15:38
@@ -1342,9 +1342,8 @@
maxasc += LYX_PAPER_MARGIN;
   
// add the vertical spaces, that the user added
-   if (firstpar-params().spaceTop().kind() != VSpace::NONE)
-   maxasc += int(firstpar-params().spaceTop().inPixels(bview));
-  
+   maxasc += getLengthMarkerHeight(bview, firstpar-params().spaceTop());
+ 
// do not forget the DTP-lines!
// there height depends on the font of the nearest character
if (firstpar-params().lineTop())
@@ -1456,8 +1455,7 @@
maxdesc += LYX_PAPER_MARGIN;
  
// add the vertical spaces, that the user added
-   if (firstpar-params().spaceBottom().kind() != VSpace::NONE)
-   maxdesc += 
int(firstpar-params().spaceBottom().inPixels(bview));
+   maxdesc += getLengthMarkerHeight(bview, 
+firstpar-params().spaceBottom());
  
// do not forget the DTP-lines!
// there height depends on the font of the nearest character
@@ -3158,7 +3156,81 @@
}
 }
 
+
+int LyXText::getLengthMarkerHeight(BufferView * bv, VSpace const  vsp) const
+{
+   if (vsp.kind() != VSpace::LENGTH) {
+   return int(vsp.inPixels(bv));
+   }
+
+   int const space_size = int(vsp.inPixels(bv));
+   int const arrow_size = 10;
+ 
+   LyXFont font;
+   font.decSize();
+   int const min_size = 2 * arrow_size + 10
+   + lyxfont::maxAscent(font)
+   + lyxfont::maxDescent(font);
+
+   return std::max(min_size, space_size);
+}
+
+ 
+int LyXText::drawLengthMarker(DrawRowParams  p, string const  prefix,
+   VSpace const  vsp, int start)
+{
+   string const str(prefix
+   +  ( + vsp.asLyXCommand() + ));
+ 
+   int const arrow_size = 10;
+ 
+   int const size = getLengthMarkerHeight(p.bv, vsp);
+ 
+   // first the string
+   int w = 0;
+   int a = 0;
+   int d = 0;
+ 
+   LyXFont font;
+   font.setColor(LColor::added_space).decSize();
+   lyxfont::rectText(str, font, w, a, d);
+ 
+   int const end = start + size;
+
+   p.pain-rectText(p.xo + 2 * arrow_size + 5, 
+   start + ((end - start) / 2) + d,
+   str, font,
+   backgroundColor(),
+   backgroundColor());
+ 
+   // adding or removing space
+   bool const added = !(vsp.length().len().value()  0.0);
+
+   int const leftx = p.xo;
+   int const midx = leftx + arrow_size;
+   int const rightx = midx + arrow_size;
+ 
+   // top arrow
+   int const ty1 = added ? (start + arrow_size) : start;
+   int const ty2 = added ? start : (start + arrow_size);
+
+   p.pain-line(leftx, ty1, midx, ty2, LColor::added_space);
+   p.pain-line(midx, ty2, rightx, ty1, LColor::added_space);
+
+   // bottom arrow
+   int const by1 = added ? (end - arrow_size) : end;
+   int const by2 = added ? end : (end - arrow_size);
+ 
+   p.pain-line(leftx, by1, midx, by2, LColor::added_space);
+   p.pain-line(midx, by2, 

Another crasher !

[John Levon]

open the attached, and follow the instructions.

regards
john

-- 
Faced with the prospect of rereading this book, I would rather have 
 my brains ripped out by a plastic fork.
- Charles Cooper on Business at the Speed of Thought 


#LyX 1.2 created this file. For more info see http://www.lyx.org/
\lyxformat 220
\textclass amsart
\language english
\inputencoding auto
\fontscheme default
\graphics default
\paperfontsize default
\spacing single 
\papersize Default
\paperpackage a4
\use_geometry 0
\use_amsmath 0
\use_natbib 0
\use_numerical_citations 0
\paperorientation portrait
\secnumdepth 3
\tocdepth 3
\paragraph_separation skip
\defskip medskip
\quotes_language english
\quotes_times 2
\papercolumns 1
\papersides 1
\paperpagestyle default

\layout Standard


\begin_inset Minipage
position 1
inner_position 0
height 
width 100%
collapsed false

\layout Standard

cscasc
\layout Conjecture

sacsac
\end_inset 


\layout Standard

Delete 
\begin_inset Quotes eld
\end_inset 

cscasc
\begin_inset Quotes erd
\end_inset 

 to leave the cursor on an empty line.
 then press down - crash.
\the_end

Another crasher !!

[John Levon]

Juergen, bug #451283 is definitely not fixed. Just follow
the instructions in the attached file.

Can you ask people to verify before actually closing a bug at sourceforge
please ?

thanks
john

-- 
Faced with the prospect of rereading this book, I would rather have 
 my brains ripped out by a plastic fork.
- Charles Cooper on Business at the Speed of Thought 


#LyX 1.2 created this file. For more info see http://www.lyx.org/
\lyxformat 220
\textclass article
\language german
\inputencoding latin1
\fontscheme default
\graphics default
\paperfontsize 10
\spacing single 
\papersize a4paper
\paperpackage a4
\use_geometry 0
\use_amsmath 0
\use_natbib 0
\use_numerical_citations 0
\paperorientation portrait
\leftmargin 1.7cm
\topmargin 1.4cm
\rightmargin 1.2cm
\bottommargin 1.4cm
\secnumdepth 3
\tocdepth 3
\paragraph_separation indent
\defskip medskip
\quotes_language german
\quotes_times 2
\papercolumns 1
\papersides 1
\paperpagestyle default

\layout Standard

Enough messing around opening/inlining these ERTs easily causes drawing
 problems, and eventually crashes.
 Bug #451283
\layout Standard


\begin_inset Float figure
placement htbp
wide false
collapsed false

\layout Standard


\begin_inset ERT
status Collapsed

\layout Standard

\backslash 
fbox{I'm a minipage}
\end_inset 


\layout Standard
\added_space_bottom 0.3cm 

\begin_inset ERT
status Collapsed

\layout Standard

\backslash 
fbox{me too}
\end_inset 


\layout Caption

a test
\end_inset 


\layout Standard

Here's herbert's method :
\layout Standard

Position cursor before the second ERT inset.
 (close the inset if it opens again).
\layout Standard

press backspace.
 open the second inset.
\the_end

Re: Bug list - Update

[John Levon]

On Fri, Nov 30, 2001 at 06:03:55PM +1000, Allan Rae wrote:

 SO far it looks like BufferView::Pimpl::workAreaButtonPress doesn't
 always see that a selection is set in:
 
   if (button == 2
bv_-text-selection.set()) {
   owner_-getLyXFunc()-dispatch(LFUN_COPY);
   paste_internally = true;
   }
 
 as a result paste_internally isn't being set and as a result of that
 we call LFUN_PASTESELECTION insetad of LFUN_PASTE when the selection
 is inside an inset.

That looks wrong.

using bv_-text means only a selection in the top-level is found. There might
be an inset whose -getLyXText() has a selection, but we won't find it like above.

I don't see an alternative to iterating over every inset's lyxtext to look
for a selection.

What do people think (this is not the first code where an InsetIterator
would come in useful) ?

 What sets up the cursors/selection when a LMB is released?

nothing, it is done lazily. So the MotionNotify modifies the selection
if the button is held. And a ButtonPress clears the current soft selection.

regards
john

-- 
Faced with the prospect of rereading this book, I would rather have 
 my brains ripped out by a plastic fork.
- Charles Cooper on Business at the Speed of Thought 

Re: Bug list - Update

[John Levon]

On Wed, Dec 05, 2001 at 04:56:38AM +, John Levon wrote:

 using bv_-text means only a selection in the top-level is found. There might
 be an inset whose -getLyXText() has a selection, but we won't find it like above.

erk.

insert file as ascii lines won't insert into an inset either.

We need an audit of every single line that bv-text instead of bv-getLyXText
and assert its correctness. Making bv-text private is definitely the way to go ...

john

-- 
Faced with the prospect of rereading this book, I would rather have 
 my brains ripped out by a plastic fork.
- Charles Cooper on Business at the Speed of Thought 

Re: [PATCH] fix formpara a bit

[Allan Rae]

On Wed, 5 Dec 2001, John Levon wrote:


 fixed

  479849minipage in figure float properties

 (allan's bug)

Looks good.

 please apply

Committing in a slightly modified form now.

Allan. (ARRae)

Re: patches 4 lyx persian support based on isiri

[lyxteam]

hi and thanks a lot for your care.
i sent u the changed files .please see file patch.txt i attached.
with best regards
Mehdi Adibi


On Tue, 4 Dec 2001, David C. Brown N2RJT wrote:

 [EMAIL PROTECTED] writes:
 
 | hi
 | thanks 4 your patiance .
 |  please see attachment. file patch.txt describe changes.
 |  it works with both 1.1.6fix3  1.1.6fix2.
 |  i add isiri encoding to it.
 |  keymap file is attached too (persian3342.kmap).
 | with best regards
 | Mehdi Adibi
 | [EMAIL PROTECTED]
 
 I encourage you to please send patches against the current CVS to the
 group.  I am interested in having persian support in LyX, and am looking
 forward to seeing your work incorporated into the project.  If you need
 help creating a patch file which they will accept, please send me your
 changes from a specific version and I can help.
 Thanks for contributing to the project.
 --
 Dave Brown [EMAIL PROTECTED]
 



lyxpatch.tar.gz
Description: GNU Zip compressed data

Re: [PATCH] fix formpara a bit

[Allan Rae]

Hmmm...  I'm not sure but should FormParagraph.C:282

// Actually apply these settings
lv_-view()-update(lv_-view()-text,
BufferView::SELECT | BufferView::FITCUR | BufferView::CHANGE);

be changed also?

The screen is updated okay at present and I'm guessing that update()
only redraws the minipage inset after figuring out that that is all
that's changed.  Converting this call also results in working code...

Well I changed it anyway and it still works so I committed it along
with the corresponding changes for qt2.  Now to wait for someone to
tell me this is wrong.

Allan. (ARRae)

Re: Bug list - Update

[Allan Rae]

On Wed, 5 Dec 2001, John Levon wrote:

 On Wed, Dec 05, 2001 at 04:56:38AM +, John Levon wrote:

  using bv_-text means only a selection in the top-level is found. There might
  be an inset whose -getLyXText() has a selection, but we won't find it like above.

 erk.

 insert file as ascii lines won't insert into an inset either.

 We need an audit of every single line that bv-text instead of bv-getLyXText
 and assert its correctness. Making bv-text private is definitely the way to go ...

Okay so there are currently 241 matches to 'text[, ;-)]' in 27 files
(146 of which are in BufferView_pimpl.C).  Unfortunately only a
handful are false positives -- like the two hits in
frontends/xforms/FormSpellchecker.C.

The hits in frontends/gnome/ and frontends/kde/ can be ignored because
they are either commented out or the code has been abandoned (kde).
So that just leaves:

buffer.C:3
bufferview_funcs.C:2
BufferView_pimpl.C:146
figureForm.C:12
insets/inset.C:3
insets/insetert.C:1
insets/insetgraphics.C:1
insets/insetlabel.C:2
insets/insettabular.C:16
insets/insettext.C:3
insets/insetcollapsable.C:2
lyx_cb.C:5
lyxfind.C:1
lyxfunc.C:2
LyXView.C:1
mathed/formulamacro.C:1
paragraph_pimpl.C:1
screen.C:7
text2.C:5
text.C:2
undo_funcs.C:14
vspace.C:1

Of course there are also a swag of places in BufferView2.C that access
text directly but they should all be okay (hopefully).

Allan. (ARRae)

Re: Bug list - Update

[John Levon]

On Wed, Dec 05, 2001 at 04:27:09PM +1000, Allan Rae wrote:

 Okay so there are currently 241 matches to 'text[, ;-)]' in 27 files
 (146 of which are in BufferView_pimpl.C).  Unfortunately only a
 handful are false positives -- like the two hits in
 frontends/xforms/FormSpellchecker.C.

I've prepared a shorter better list - see my other email.

thanks
john

-- 
Faced with the prospect of rereading this book, I would rather have 
 my brains ripped out by a plastic fork.
- Charles Cooper on Business at the Speed of Thought 

Re: Annoying LyX bugs

[Andre Poenitz]

On Tue, Dec 04, 2001 at 11:24:54AM -0500, Ronald Holzloehner wrote:
 (1)  Removing equation lines is broken as the manual points out (keys
 M-e k). Will this get fixed?

In 1.2. Nobody will touch math for 1.1.6.

Andre'

-- 
André Pönitz .. [EMAIL PROTECTED]

Re: Bug list - Update

[Allan Rae]

On Wed, 5 Dec 2001, John Levon wrote:
[...]
 using bv_-text means only a selection in the top-level is found. There might
 be an inset whose -getLyXText() has a selection, but we won't find it like above.

 I don't see an alternative to iterating over every inset's lyxtext to look
 for a selection.

Can someone (Jürgen?) remind me why it is a Good Thing to have every
inset have its own LyXText?  Why can't we just use the same LyXText
for everything in a given buffer?

Allan. (ARRae)

Re: Bug list - Update

[John Levon]

On Wed, Dec 05, 2001 at 04:38:09PM +1000, Allan Rae wrote:

 Can someone (Jürgen?) remind me why it is a Good Thing to have every
 inset have its own LyXText?  Why can't we just use the same LyXText
 for everything in a given buffer?

how would that work ? An inset exists on one row only, but may have any number
of rows contained within it !

john

-- 
Faced with the prospect of rereading this book, I would rather have 
 my brains ripped out by a plastic fork.
- Charles Cooper on Business at the Speed of Thought 

Re: bug report: inserting label in math display doesn't work

[Andre Poenitz]

On Tue, Dec 04, 2001 at 06:39:18PM +0200, Tuukka Toivonen wrote:
 1. Load the attached file buglabel.lyx
 2. Move the cursor inside the display math, on the line which reads
TryInsertingLabelHere.
 3. Select from menu Insert/Label..., type a label and press ok.
The label should be displayed in the math number position,
but it is not.

Could you check with current CVS? I thought stuff like that was fixed...

Note that there is about zero chance that anybody will do anything to
math stuff in the 1.1.6fix series, even if the problem happened to be fixed
in CVS.

Andre'

-- 
André Pönitz .. [EMAIL PROTECTED]

Re: bug report: inserting label in math display doesn't work

[John Levon]

On Wed, Dec 05, 2001 at 07:42:01AM +0100, Andre Poenitz wrote:

 On Tue, Dec 04, 2001 at 06:39:18PM +0200, Tuukka Toivonen wrote:
  1. Load the attached file buglabel.lyx
  2. Move the cursor inside the display math, on the line which reads
 TryInsertingLabelHere.
  3. Select from menu Insert/Label..., type a label and press ok.
 The label should be displayed in the math number position,
 but it is not.
 
 Could you check with current CVS? I thought stuff like that was fixed...

Actually, MenuLabelInsert is one of the suspect bv_-text'ers ...

john

-- 
Faced with the prospect of rereading this book, I would rather have 
 my brains ripped out by a plastic fork.
- Charles Cooper on Business at the Speed of Thought 

[PATCH] fix formpara combo

[John Levon]

Lars, this is the bug you were seeing

please apply

thanks
john

-- 
Faced with the prospect of rereading this book, I would rather have 
 my brains ripped out by a plastic fork.
- Charles Cooper on Business at the Speed of Thought 


Index: src/frontends/xforms/ChangeLog
===
RCS file: /usr/local/lyx/cvsroot/lyx-devel/src/frontends/xforms/ChangeLog,v
retrieving revision 1.205
diff -u -r1.205 ChangeLog
--- src/frontends/xforms/ChangeLog  2001/12/05 05:53:01 1.205
+++ src/frontends/xforms/ChangeLog  2001/12/05 06:40:50
@@ -1,3 +1,7 @@
+2001-12-05  John Levon  [EMAIL PROTECTED]
+
+   * FormParagraph.C: set combo box correctly for VSpace::LENGTH 
+ 
 2001-12-05  Allan Rae  [EMAIL PROTECTED]
 
* FormParagraph.C (apply): One other LyXText fix.
Index: src/frontends/xforms/FormParagraph.C
===
RCS file: /usr/local/lyx/cvsroot/lyx-devel/src/frontends/xforms/FormParagraph.C,v
retrieving revision 1.44
diff -u -r1.44 FormParagraph.C
--- src/frontends/xforms/FormParagraph.C2001/12/05 05:53:01 1.44
+++ src/frontends/xforms/FormParagraph.C2001/12/05 06:40:51
@@ -399,6 +399,7 @@
break;
 case VSpace::LENGTH:
 {
+   fl_set_choice (dialog_-choice_space_above, 7);
setEnabled(dialog_-input_space_above, true);
setEnabled(dialog_-choice_value_space_above, true);
string const default_unit = cm;
@@ -437,6 +438,7 @@
break;
 case VSpace::LENGTH:
 {
+   fl_set_choice (dialog_-choice_space_below, 7);
setEnabled(dialog_-input_space_below, true);
setEnabled(dialog_-choice_value_space_below, true);
string const default_unit = cm;

Re: before 1.2.0pre1

[Andre Poenitz]

On Tue, Dec 04, 2001 at 08:49:45PM +0100, Lars Gullik Bjønnes wrote:
 Ok, what severe bugs do we have now that renders LyX unusable or
 crashing?

The only hard crash in mathed that I am aware of happens when one tries to
define a recursive macros due to the infinite nesting when drawing the
expanded version. Since there is not yet a possibility to check which
macros are already used in some expression, there in no easy workaround
yet. It is solvable, though...

The rest is unintuitive behaviour, slight mis-drawings (super and
subscripts are too far above/below the baseline compared to TeX) etc.,
and open feature requests...

Andre' 

-- 
André Pönitz .. [EMAIL PROTECTED]

Re: \epsilon bug

[Andre Poenitz]

On Tue, Dec 04, 2001 at 04:16:23PM -0500, Chris Eliasmith wrote:
 Thanks so much for a great package everyone. One little
 annoyance: typing \epsilon in math mode doesn't give you
 the epsilon sign. All the other greek characters seem to
 work fine.

There is no glyph in the font for \epsilon, so we can't display it.
You might try \varepsilon, which has a glyph and is duly displayed.

Andre'

-- 
André Pönitz .. [EMAIL PROTECTED]

Re: decimal percent

[Andre Poenitz]

On Tue, Dec 04, 2001 at 10:26:01PM +0100, Lars Gullik Bjønnes wrote:
 Do we really need to be able keep 0.1% and the like? Isn't interger
 percentages good enough?
 (lyxlength if you didn't understand it)

I think one digit after the point should be possible. 1% of \textwidth is
about 2 mm which is pretty crude when one needs to tune things.  I
know it makes code more messy...

Andre'

-- 
André Pönitz .. [EMAIL PROTECTED]

Re: lyxlength.C does not compile!

[Andre Poenitz]

On Wed, Dec 05, 2001 at 11:25:14AM +1000, Allan Rae wrote:
 It seems there is now some uncertainty about how to handle the
 percentage lengths although it seems everyone wants to go back to an
 int.
 
 Would you accept the pairint, int proposal?

What makes this better as a single int?

 have a:
   union {
   int sp_length;
   float percentage;
   } val_;

LyX is not a device driver. No need for unions ;-}

 decimal point.  Then again do we really need to do any limiting of the
 percentage other than range limiting of 0 - 100 percent? (actually we
 need a range of 0 - 1 for the output)

Why this limitation? What's wrong with 120% of \columnwidth?

Andre'

-- 
André Pönitz .. [EMAIL PROTECTED]

Re: [PATCH] fix some inset-in-inset update problems

[Andre Poenitz]

On Wed, Dec 05, 2001 at 12:24:53PM +1000, Allan Rae wrote:
 I guess from this you are referring to the need to know which parts of
 the document are visible -- that is, which _rows_ are visible.  Do we
 need a cursor for that?

No. A full redraw could start searching the cursor path towards the
root of the inset tree (and the full document should be an inset, too,
btw.) until it find an inset that claim to cover all of the user visible
screen. This could be the big document inset, but this could be a large
figure or table cell, too. This inset is asked to redraw the region (and
this process recursively descends into contained insets etc).

And if needed, this drawing is the second stage in a two stage process,
with the first stage building caches of size information of the insets.

Andre'

-- 
André Pönitz .. [EMAIL PROTECTED]

Re: decimal percent

[Andre Poenitz]

On Wed, Dec 05, 2001 at 01:06:33PM +1000, Allan Rae wrote:
 So we don't have the range limiting we used to but we also don't
 ensure that dumb entries like negative sizes for figures can't be
 entered.

If the users wants to enter -200%, he might have a reason for doing so. 
If not, he explicitly asked for trouble by pressing '-'.

I am not a big fan of restricting things to some range that looks sensible
to me _now_, especially if that means extra code.

  latex supports them:
 
   -0.2\columnwidth
 
 I didn't say we shouldn't support them. I'm saying we should make sure
 negative values are only entered where they are valid -- or that only
 positive values are entered where only positive values are valid.

How do you know? Everything LaTeX accepts is valid per definition.

Andre'

-- 
André Pönitz .. [EMAIL PROTECTED]

Re: Bug list - Update

[Andre Poenitz]

On Wed, Dec 05, 2001 at 08:25:08AM +0100, Lars Gullik Bjønnes wrote:
 Oh, we will probably make it even worse later: one LyXText for each
 paragraph.

Yes, yes, yes!

Andre'

-- 
André Pönitz .. [EMAIL PROTECTED]

Re: lyxlength.C does not compile!

[Allan Rae]

On Wed, 5 Dec 2001, Andre Poenitz wrote:

 On Wed, Dec 05, 2001 at 11:25:14AM +1000, Allan Rae wrote:
  It seems there is now some uncertainty about how to handle the
  percentage lengths although it seems everyone wants to go back to an
  int.
 
  Would you accept the pairint, int proposal?

 What makes this better as a single int?

It's one way to handle floating point without a float: fixed point but
with two ints.  One for the integral amount and one for the fractional
amount.

It seems now that people are happy to stick to integral percentages
(which is what we had before) but if not we need to decide what fixed
point we use -- how many decimal places -- and how to keep that in an
int.

It's just an idea thrown in to get people thinking.

  decimal point.  Then again do we really need to do any limiting of the
  percentage other than range limiting of 0 - 100 percent? (actually we
  need a range of 0 - 1 for the output)

 Why this limitation? What's wrong with 120% of \columnwidth?

I misremembered how the limiting was done (by the frontend not the
core code).  There is nothing wrong with 1.2\columnwidth provided TeX
can make it fit on the paper to your satisfaction.

Do you want to be able to set 120.5%?
Why?  Freedom of choice isn't sufficient answer.

Allan. (ARRae)

Re: decimal percent

[Allan Rae]

On Wed, 5 Dec 2001, Andre Poenitz wrote:

 On Wed, Dec 05, 2001 at 01:06:33PM +1000, Allan Rae wrote:
  So we don't have the range limiting we used to but we also don't
  ensure that dumb entries like negative sizes for figures can't be
  entered.

 If the users wants to enter -200%, he might have a reason for doing so.
 If not, he explicitly asked for trouble by pressing '-'.

This is one of those frontend issues, André.

 I am not a big fan of restricting things to some range that looks sensible
 to me _now_, especially if that means extra code.

_now_ being before 1.2.0?  Sure I have no problem with that.

   latex supports them:
  
-0.2\columnwidth
 
  I didn't say we shouldn't support them. I'm saying we should make sure
  negative values are only entered where they are valid -- or that only
  positive values are entered where only positive values are valid.

 How do you know? Everything LaTeX accepts is valid per definition.

And if LaTeX doesn't produce a sensible document because a -200%
scaled picture is requested don't you think it would be reasonable of
us to ensure the user can't enter such an amount?

It would be invalid for LaTeX therefore we shouldn't allow it.  Your
valid above is the same as my use of valid in the previous email!

gs certainly can't render a picture with a -200% scaling it dies with
an error!

Allan. (ARRae)

Re: lyxlength.C does not compile!

[Andre Poenitz]

On Wed, Dec 05, 2001 at 05:34:56PM +1000, Allan Rae wrote:
 Do you want to be able to set 120.5%?
 Why?  Freedom of choice isn't sufficient answer.

\columnwidth in two column text is small enough to fit something
with 1.205\columnwidth on the page.

Andre'

-- 
André Pönitz .. [EMAIL PROTECTED]

Re: decimal percent

[Allan Rae]

On Wed, 5 Dec 2001, Lars Gullik Bjønnes wrote:

 Allan Rae [EMAIL PROTECTED] writes:
[...]
 | By implication of the fact that we only write out two decimal places
 | for percentages in lyxlength.C:
 | 1.00 = 100%

   buffer  abs(static_castint(val_/100))  .
   abs(static_castint(val_)%100)  \\columnwidth;
   break;

 one number before the decimal point and one after...

The one after the decimal point will be in the range 0-99 giving the
integer percentages.  You cannot write 0.005 with the above function
because val_ would have to represent 0.5% to start with.  Likewise,
you cannot write any number with three decimal places (.123).

Do you understand me this time?

 | Actually it seems the range limiting function isn't used for the
 | figure inset anymore.  As a result you can set the size to -200.5% of
 | column width which naturally enough causes the figure rendering to
 | fail.

 Seems that we have several places that needs better checks (and a
 bette length class)

Indeed.

Allan. (ARRae)

Re: decimal percent

[Andre Poenitz]

On Wed, Dec 05, 2001 at 05:42:48PM +1000, Allan Rae wrote:
 And if LaTeX doesn't produce a sensible document because a -200%
 scaled picture is requested don't you think it would be reasonable of
 us to ensure the user can't enter such an amount?

The picture could be serve other purposes unknown to me. Even LaTeX proper
is full of strange hacks that simply happen to work.  
 
 It would be invalid for LaTeX therefore we shouldn't allow it.

Have you checked? 

Andre'

-- 
André Pönitz .. [EMAIL PROTECTED]

Re: lyxlength.C does not compile!

[Allan Rae]

On Wed, 5 Dec 2001, Andre Poenitz wrote:

 On Wed, Dec 05, 2001 at 05:34:56PM +1000, Allan Rae wrote:
  Do you want to be able to set 120.5%?
  Why?  Freedom of choice isn't sufficient answer.

 \columnwidth in two column text is small enough to fit something
 with 1.205\columnwidth on the page.

So how many decimal places do you want to be able to represent by the
int?  You need to choose how many bits there should be before and
after the decimal point in order to determine what fixed-point we
will use.

Percentages are only used with columnwidth, textwidth, pagelength and
one other I think.

Allan. (ARRae)

Re: tabular dialog

[Juergen Vigna]

On 03-Dec-2001 Andre Poenitz wrote:

> Come on... user interface stuff used to be no-go-teritory for me and I did
> not follow discussions there too closely (if at all). I would not even know
> where to start with this kind of things.

Well then let me sum for you. We agreed that we should change to a
Apply/Ok policy also for the tabular-dialog, but this would involve
a major rewrite of the TabularFeatures and the dialog so we decided to
leave this for 1.3.0.

   Jug

--
-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._
Dr. Jürgen VignaE-Mail:  [EMAIL PROTECTED]
Italienallee 13/N   Tel/Fax: +39-0471-450260 / +39-0471-450253
I-39100 Bozen   Web: http://www.sad.it/~jug
-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._

He who spends a storm beneath a tree, takes life with a grain of TNT.

Re: style

[Allan Rae]

On Tue, 4 Dec 2001, Andre Poenitz wrote:

> On Tue, Dec 04, 2001 at 03:57:34PM +1000, Allan Rae wrote:
> > preferred.  Like this one instead of above?
> >
> > if (any length a && any length b && any length c) {
> > }
>
> If it fits on a line, it should be ok. But then, why don't you put the test
> in some function with some meaningful name and write
>
>  if (someFancyConditionFulfilled()) {
>  }

Because by "any length" I also meant really simple stuff like for
example:

if (p
&& !p->empty()) {
}

Although that is probably the extreme of simple examples.

Allan. (ARRae)

Re: lyxlength.C does not compile!

[Andre Poenitz]

On Tue, Dec 04, 2001 at 05:59:13PM +1000, Allan Rae wrote:
> > Well, Lars started ripping it apart and renaming it, so I guess he would
> > like to get it done? ;-)
> 
> Okay then maybe Lars would like to use a:
>   pair

I think we should indeed use 'int' and put the percentage stuff somewhere
else...

Andre'

-- 
André Pönitz .. [EMAIL PROTECTED]

Re: [PATCH] two fixes, broken (iterator questions)

[Juergen Vigna]

On 04-Dec-2001 John Levon wrote:

>> >text->fullRebreak(this);

>> Can someone explain to me why a full rebreak is performed after each 
>> error is removed?
>> (The old code did this too... and also when the errors are inserted.) I 
>> would have thought that could wait until all the errors had been processed.
> 
> /me shrugs

I would say have a look at the fullRebreak() function ;) It actually
breaks only if need_break_row is set. Maybe the function name is misleading
but actually it can perform only the fullRebreak of one paragraph starting
at the need_break_row! So you HAVE to call it every time otherwise the
next time need_break_row will be overwritten with the next row we should
break and so we won't never break the first one!

   Jug

--
-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._
Dr. Jürgen VignaE-Mail:  [EMAIL PROTECTED]
Italienallee 13/N   Tel/Fax: +39-0471-450260 / +39-0471-450253
I-39100 Bozen   Web: http://www.sad.it/~jug
-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._

I haven't been married in over six years, but we had sexual counseling
every day from Oral Roberts!!

Re: tabular dialog

[Andre Poenitz]

On Tue, Dec 04, 2001 at 09:01:21AM +0100, Juergen Vigna wrote:
> Well then let me sum for you. We agreed that we should change to a
> Apply/Ok policy also for the tabular-dialog, but this would involve
> a major rewrite of the TabularFeatures and the dialog so we decided to
> leave this for 1.3.0.

Very kind of you.

Andre'

-- 
André Pönitz .. [EMAIL PROTECTED]

Re: style

[Andre Poenitz]

On Tue, Dec 04, 2001 at 06:03:52PM +1000, Allan Rae wrote:
> Because by "any length" I also meant really simple stuff like for
> example:
> 
>   if (p
>   && !p->empty()) {
>   }

I find this much more disruptive to read than

if (p && !p->empty()) {
}

Actually, this is strange, since I usually favour "linear" code, i.e.
something that basically goes top down. But I probably look at a
condition as something "atomic", a single idea...

Andre'

-- 
André Pönitz .. [EMAIL PROTECTED]

Re: [PATCH] fix some inset-in-inset update problems

[Juergen Vigna]

On 04-Dec-2001 Allan Rae wrote:

> So you are saying that setUpdateStatus(NONE) indicates that no update
> has been done so a FULL update is needed?

Nope! NONE just gives the minimal amount of Update I envise for this
call. Then setUpdateStatus has to decide if we need more than this minimal
amount. So if the change in LyXText was minimal we probably will have only
a CURSOR_PAR, if the change was mayor (a break in a row) then we would have
FULL, but if we didn't have ANY change then the update would be NONE.

Obviously we could put the code if lt->status() == NEED_VERY_LITTLE_REFRESH
then setUpdateStatus(CURSOR_PAR) else if lt->status() == NEED_MORE_REFRESH
then setUpdateStatus(FULL) else setUpdateStatus(myminimal_status) everywhere
we call that function but I really don't see the point of enlarging the
code with duplicates.

 Jug

--
-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._
Dr. Jürgen VignaE-Mail:  [EMAIL PROTECTED]
Italienallee 13/N   Tel/Fax: +39-0471-450260 / +39-0471-450253
I-39100 Bozen   Web: http://www.sad.it/~jug
-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._

Play Rogue, visit exotic locations, meet strange creatures and kill them.

Re: [PATCH] fix some inset-in-inset update problems

[Juergen Vigna]

On 04-Dec-2001 Allan Rae wrote:

> Or are you just thinking of insettabular and the no-mans-land between
> the cells?  Then an insettabular::iterator should handle those more
> obtuse actions.  If you have two cursors with one set to the first pos
> of an inset and the second set to the end of the same inset haven't
> you just selected the whole inset?  So why do you need a no-mans-land
> to mark a whole inset?

It seems to me you all hide your head in the sand ;)

What about this:

blah blah |[inset1] blah blah blah
blah [inset2] blah blah blah.

Now an insetgraphics inside [inset2] is requesing an update because
it finished rendering. I don't see any cursor near [inset2], do you?

  Jug

--
-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._
Dr. Jürgen VignaE-Mail:  [EMAIL PROTECTED]
Italienallee 13/N   Tel/Fax: +39-0471-450260 / +39-0471-450253
I-39100 Bozen   Web: http://www.sad.it/~jug
-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._

Is death legally binding?