Re: [Openocd-development] jtag_add_scan_check Assertion Error
Commenting out this assert everything seems to be OK. Indeed: http://openocd.zylin.com/297 -- Øyvind Harboe - Can Zylin Consulting help on your project? US toll free 1-866-980-3434 http://www.zylin.com/ ___ Openocd-development mailing list Openocd-development@lists.berlios.de https://lists.berlios.de/mailman/listinfo/openocd-development
Re: [Openocd-development] jtag_add_scan_check Assertion Error
Please run this in gdb and do a bt(backtrace). On Wed, Dec 21, 2011 at 3:52 PM, Drasko DRASKOVIC drasko.drasko...@gmail.com wrote: Hi all, with new git repo clone of OpenOCD I have been hitting this assert during the scan chain init : openocd: core.c:421: jtag_add_scan_check: Assertion `(field-check_value == ((void *)0)) || (field-in_value != ((void *)0))' failed. Commenting out this assert everything seems to be OK. I am using libftdi-0.19, and have seen same issue on both ARM946 and MIPS targets. BR, Drasko ___ Openocd-development mailing list Openocd-development@lists.berlios.de https://lists.berlios.de/mailman/listinfo/openocd-development -- Øyvind Harboe - Can Zylin Consulting help on your project? US toll free 1-866-980-3434 http://www.zylin.com/ ___ Openocd-development mailing list Openocd-development@lists.berlios.de https://lists.berlios.de/mailman/listinfo/openocd-development
Re: [Openocd-development] jtag_add_scan_check Assertion Error
Commenting out this assert everything seems to be OK. This will eventually cause a crash and must be fixed. The fix is easy: just provide a storage for in_value when using callbacks or checking against value/mask. -- Øyvind Harboe - Can Zylin Consulting help on your project? US toll free 1-866-980-3434 http://www.zylin.com/ ___ Openocd-development mailing list Openocd-development@lists.berlios.de https://lists.berlios.de/mailman/listinfo/openocd-development
Re: [Openocd-development] Slow NAND flashing
On Fri, Dec 16, 2011 at 1:53 PM, Erik Ahlén erik.ah...@avaloninnovation.com wrote: Am I doing something wrong or is NAND flashing always slow? I'm using a Amontec JTAGkey-2 to flash a boot loader on an i.MX35. The erasing takes ~21s and the writing takes ~35s. Erasing 0x0-0x30 and the boot loader is 130K. What's the maximum theoretical performance according to the datasheets? -- Øyvind Harboe - Can Zylin Consulting help on your project? US toll free 1-866-980-3434 http://www.zylin.com/ ___ Openocd-development mailing list Openocd-development@lists.berlios.de https://lists.berlios.de/mailman/listinfo/openocd-development
Re: [Openocd-development] Slow NAND flashing
Block Erase Time according to the data sheet for the flash memory is 1.5-2ms and for 24 (0x30/0x2) blocks that makes max 48ms. And page program time is 200-700 us, 64 * 700us = 44800us for a block. And Amontec specifies that the baudrate for JTAGkey is 6Mbits/s The turnaround time for USB is 1ms, whereas it can be in the us range for e.g. ZY1000. You may be able to find out where you're loosing performance due to USB latency and then optimize it to use larger read/writes. -- Øyvind Harboe - Can Zylin Consulting help on your project? US toll free 1-866-980-3434 http://www.zylin.com/ ___ Openocd-development mailing list Openocd-development@lists.berlios.de https://lists.berlios.de/mailman/listinfo/openocd-development
Re: [Openocd-development] JimTCL and Fedora RPMs
Please read latest HACKING and push to gerrit for review. Thanks! -- Øyvind Harboe - Can Zylin Consulting help on your project? US toll free 1-866-980-3434 http://www.zylin.com/ ___ Openocd-development mailing list Openocd-development@lists.berlios.de https://lists.berlios.de/mailman/listinfo/openocd-development
[Openocd-development] Google presentation on OpenOCD Gerrit experience
Comments welcome! https://docs.google.com/present/view?id=dhftn35p_14s2xxcbt3 -- Øyvind Harboe - Can Zylin Consulting help on your project? US toll free 1-866-980-3434 http://www.zylin.com/ ___ Openocd-development mailing list Openocd-development@lists.berlios.de https://lists.berlios.de/mailman/listinfo/openocd-development
Re: [Openocd-development] Google presentation on OpenOCD Gerrit experience
On Thu, Nov 24, 2011 at 4:41 PM, Laurent Gauch laurent.ga...@amontec.com wrote: good read ! Thanks. What do you mean by Senior developers ? Developers bestowes us with their great acumen. What do you really interpret At the sharp rise, Gerrit was introduced ? # of commits rose from 3 to 30 a week. -- Øyvind Harboe - Can Zylin Consulting help on your project? US toll free 1-866-980-3434 http://www.zylin.com/ ___ Openocd-development mailing list Openocd-development@lists.berlios.de https://lists.berlios.de/mailman/listinfo/openocd-development
Re: [Openocd-development] openocd patch: 09b1704 dsp5680xx: add missing and broken error propagation
We're switching to checkpatch's coding standard and gerrit will automatically do all the checks now, so a whitespace fix snuck into this patch. We plan to do a wholesale reformatting after next release, meanwhile we require all new patches to be checkpatch clean. The plan is to get the entire OpenOCD to build clean of clang warnings, but it will be some time until we're there. At that point we will probably make 0 clang warnings a requirement for new patches. -- Øyvind Harboe - Can Zylin Consulting help on your project? US toll free 1-866-980-3434 http://www.zylin.com/ ___ Openocd-development mailing list Openocd-development@lists.berlios.de https://lists.berlios.de/mailman/listinfo/openocd-development
[Openocd-development] Gerrit with http only
Setting up the commit-msg hook isn't possible using http only: scp -p -P 29418 usern...@openocd.zylin.com:hooks/commit-msg .git/hooks/ http://repo.or.cz/w/openocd.git/blame?f=HACKING Any suggestions? -- Øyvind Harboe - Can Zylin Consulting help on your project? US toll free 1-866-980-3434 http://www.zylin.com/ ___ Openocd-development mailing list Openocd-development@lists.berlios.de https://lists.berlios.de/mailman/listinfo/openocd-development
[Openocd-development] include linux/scripts in OpenOCD project?
Should we? -- Øyvind Harboe - Can Zylin Consulting help on your project? US toll free 1-866-980-3434 http://www.zylin.com/ ___ Openocd-development mailing list Openocd-development@lists.berlios.de https://lists.berlios.de/mailman/listinfo/openocd-development
Re: [Openocd-development] include linux/scripts in OpenOCD project?
On Wed, Nov 2, 2011 at 9:06 PM, Tomek CEDRO tomek.ce...@gmail.com wrote: On Wed, Nov 2, 2011 at 8:03 PM, Øyvind Harboe oyvind.har...@zylin.com wrote: Should we? What does these scripts do? Will they work on FreeBSD? :-P :-) They allow you to check patches for coding style, remove whitespace, automatically indent, etc. Don't know about FreeBSD... -- Øyvind Harboe - Can Zylin Consulting help on your project? US toll free 1-866-980-3434 http://www.zylin.com/ ___ Openocd-development mailing list Openocd-development@lists.berlios.de https://lists.berlios.de/mailman/listinfo/openocd-development
Re: [Openocd-development] [PATCH] tx27stk5: add board init support for KaRo TX27 CPU module
Please post to Gerrit for review. See latest HACKING doc for details. Thanks! -- Øyvind Harboe - Can Zylin Consulting help on your project? US toll free 1-866-980-3434 http://www.zylin.com/ ___ Openocd-development mailing list Openocd-development@lists.berlios.de https://lists.berlios.de/mailman/listinfo/openocd-development
Re: [Openocd-development] scan-build and gerrit rant
There are a couple of topics mixed into this thread: 1. clang sometimes gives false positives. Here the code is usually so complex that I can understand that clang and programmers have trouble following the code. The best way would be to refactor the code to be simpler, in one case I split a long and complicated fn instead of using an assert. I'm not saying that clang can't give silly false positives, but when it does give false positives, it's oftentimes in too-long functions. So far I have yet to see clang give silly warnings on highly readable code. 2. the gerrit review process and build system is new, so I've been using simple warning fixes to take it for a spin. 3. w.r.t. the review process, I was thinking if we should have a rule like: a patch can be submitted if a week has gone without feedback and it looks good, or a second reviewer approves it. -- Øyvind Harboe - Can Zylin Consulting help on your project? US toll free 1-866-980-3434 http://www.zylin.com/ ___ Openocd-development mailing list Openocd-development@lists.berlios.de https://lists.berlios.de/mailman/listinfo/openocd-development
Re: [Openocd-development] scan-build and gerrit rant (Was: Re: openocd patch: 620ba7e clang: fix warning by adding assert that shows that a variable is used)
In this case, the warning is probably bogus (I'll have to check the scan-build output but having problems logging in to jenkins). Unfortunately, the fix is, too. There's no point in adding an assert to check for the value of a variable when that value has no possible bearing on the program (the variable is never used after the assert, which, incidentally, was exactly what scan-build complained about). I think the correct fix here is to split the fn. The assert() I added amounts to a post-condition of the fn I want to split out. To split out the fn, I need a bigger monitor than I have now, or a re-factoring tool. assert()'s are designed to be used for pre and post conditions. OpenOCD certainly does not suffer from over-usage of asserts. If we ignore what clang is complaining about, then I think we can agree that clang found a function that is too big and complex. Once this fn has been split in two, then copy and paste code can be avoided more easily for ir/drscan versions of the same command. clang is new to me, so I'm still learning to interpret it's warnings into sensible refactorings. -- Øyvind Harboe - Can Zylin Consulting help on your project? US toll free 1-866-980-3434 http://www.zylin.com/ ___ Openocd-development mailing list Openocd-development@lists.berlios.de https://lists.berlios.de/mailman/listinfo/openocd-development
Re: [Openocd-development] checkpatch enabled
On Sat, Oct 29, 2011 at 1:38 PM, Antonio Borneo borneo.anto...@gmail.com wrote: Hi Spen, I would like to view the parameters passed by jenkins to configure during the build. Are the scripts used by jenkins for OpenOCD available somewhere? Our intention is not for everybody to be *required* to have all these tools that we run on the server locally. Part of the genius with Gerrit is that the patches are not marked verified before all the checker tools we can dream of have given the patch an all clear. Just amend the commit and push to the server again for a new test build on the server. checkpatch is run without any options. (I'm sure Spencer will post more details on how we run the tests...) -- Øyvind Harboe - Can Zylin Consulting help on your project? US toll free 1-866-980-3434 http://www.zylin.com/ ___ Openocd-development mailing list Openocd-development@lists.berlios.de https://lists.berlios.de/mailman/listinfo/openocd-development
[Openocd-development] clang warnings
Hi, Spencer has gotten clang up and running again on the server! :-) Please take a moment to fix a warning or two that you can find in the latest warning list for clang builds. You'll notice that there is a nice graph that we can use to track our progress in terms of warnings. When reviewing, I'd like us not to increase # of warnings with new patches, but that check is not enforced yet via Gerrit verification flag. http://openocd.zylin.com/jenkins/job/openocd-clang/2/warningsResult/ -- Øyvind Harboe - Can Zylin Consulting help on your project? US toll free 1-866-980-3434 http://www.zylin.com/ ___ Openocd-development mailing list Openocd-development@lists.berlios.de https://lists.berlios.de/mailman/listinfo/openocd-development
Re: [Openocd-development] New patch to review for openocd: e043913 bugfixes: numerous bugs in error propagation found by clang
2011/10/28 Peter Stuge pe...@stuge.se: ger...@openocd.zylin.com wrote: -DumpTargets: +DumpTargets:; Hm? Syntactically a declaration can't follow a label, so add an empty statement. -- Øyvind Harboe - Can Zylin Consulting help on your project? US toll free 1-866-980-3434 http://www.zylin.com/ ___ Openocd-development mailing list Openocd-development@lists.berlios.de https://lists.berlios.de/mailman/listinfo/openocd-development
Re: [Openocd-development] New patch to review for openocd: e043913 bugfixes: numerous bugs in error propagation found by clang
On Fri, Oct 28, 2011 at 12:23 AM, Peter Stuge pe...@stuge.se wrote: Øyvind Harboe wrote: 2011/10/28 Peter Stuge pe...@stuge.se: ger...@openocd.zylin.com wrote: -DumpTargets: +DumpTargets:; Hm? Syntactically a declaration can't follow a label, so add an empty statement. I don't like the change so much. It ends up declaring the exact same variable twice, and other odd noise, to silence a warning. Is there no better way? Reusing the 'target' variable name here is bad. They are really two very distinct variable lifetimes. The scope of the variables are now reduced. The code is now more easily re-factored as multiple functions because the same variable isn't being reused over and over for difference purposes. -- Øyvind Harboe - Can Zylin Consulting help on your project? US toll free 1-866-980-3434 http://www.zylin.com/ ___ Openocd-development mailing list Openocd-development@lists.berlios.de https://lists.berlios.de/mailman/listinfo/openocd-development
Re: [Openocd-development] New patch to review for openocd: e043913 bugfixes: numerous bugs in error propagation found by clang
On Fri, Oct 28, 2011 at 12:59 AM, Peter Stuge pe...@stuge.se wrote: Øyvind Harboe wrote: I don't like the change so much. It ends up declaring the exact same variable twice, and other odd noise, to silence a warning. Is there no better way? Reusing the 'target' variable name here is bad. .. The code is now more easily re-factored as multiple functions Ok, can we please do that then, instead of working around static analysis? In this case, I disagree that it is working around static analysis. I'll see about having a peek at the code again for cleaning it up. -- Øyvind Harboe - Can Zylin Consulting help on your project? US toll free 1-866-980-3434 http://www.zylin.com/ ___ Openocd-development mailing list Openocd-development@lists.berlios.de https://lists.berlios.de/mailman/listinfo/openocd-development
Re: [Openocd-development] git gui
Hi Pete, thanks for the corrections about my prejudice against Tortoise. I guess my main problem has been that that I've found that those that use Tortoise have no patience for the complexities and necessity of interactive rebase, rather than Tortoise lack of support for this feature. Gerrit is a piece to the GUI puzzle that is completely independent of what Tortoise covers. Both are needed. I know some Windows users who might be willing and interested in trying out Tortoise. Much of the support I provide for git happens via email. Documenting procedures and explaining what to do is much easier with command line, than to try to explain how to use a web interface. I don't use Windows myself, so from that point of view TortoiseGit is a non-starter. I see that there is a tortoisehg for Linux. -- Øyvind Harboe - Can Zylin Consulting help on your project? US toll free 1-866-980-3434 http://www.zylin.com/ ___ Openocd-development mailing list Openocd-development@lists.berlios.de https://lists.berlios.de/mailman/listinfo/openocd-development
Re: [Openocd-development] gerrit comments as mail?
How about going to openocd.zylin.com and checking which patches are still outstanding every few days? -- Øyvind Harboe - Can Zylin Consulting help on your project? US toll free 1-866-980-3434 http://www.zylin.com/ ___ Openocd-development mailing list Openocd-development@lists.berlios.de https://lists.berlios.de/mailman/listinfo/openocd-development
Re: [Openocd-development] Another git question....
On Wed, Oct 26, 2011 at 3:09 PM, jim norris u17...@att.net wrote: Assuming I've done my commits. How do I see what the patch will look like before I do the 'git push review'? git format-patch origin/master = produces patch files -- Øyvind Harboe - Can Zylin Consulting help on your project? US toll free 1-866-980-3434 http://www.zylin.com/ ___ Openocd-development mailing list Openocd-development@lists.berlios.de https://lists.berlios.de/mailman/listinfo/openocd-development
Re: [Openocd-development] git and gerrit questions
On Wed, Oct 26, 2011 at 3:14 PM, jim norris u17...@att.net wrote: How does gerrit determine whether a patch is a subsequent patch for a file? You update the commit and keep the change-id in the commit comment and do a git push review. I don't know if that's what you're asking. git rebase interative allows you to edit a commit if you will. -- Øyvind Harboe - Can Zylin Consulting help on your project? US toll free 1-866-980-3434 http://www.zylin.com/ ___ Openocd-development mailing list Openocd-development@lists.berlios.de https://lists.berlios.de/mailman/listinfo/openocd-development
Re: [Openocd-development] git gui
I have a problems with a GUI that makes git easy to use at the cost of not enabling and teaching the user to use the more advanced concepts. Interactive rebasing is an absolute must when working with git. Anything that leaves the user with the impression that he doesn't have to get his head around interactive rebase is oversimplifying git(and DVCS in general). -- Øyvind Harboe - Can Zylin Consulting help on your project? US toll free 1-866-980-3434 http://www.zylin.com/ ___ Openocd-development mailing list Openocd-development@lists.berlios.de https://lists.berlios.de/mailman/listinfo/openocd-development
[Openocd-development] adding checkpatch to code review on jenkins
Could someone take checkpatch for a spin and report back to the list on if/how we should use in w/Gerrit+Jenkins review? -- Øyvind Harboe - Can Zylin Consulting help on your project? US toll free 1-866-980-3434 http://www.zylin.com/ ___ Openocd-development mailing list Openocd-development@lists.berlios.de https://lists.berlios.de/mailman/listinfo/openocd-development
Re: [Openocd-development] adding checkpatch to code review on jenkins
On Tue, Oct 25, 2011 at 9:48 AM, Spencer Oliver s...@spen-soft.co.uk wrote: On Oct 25, 2011 8:34 AM, Øyvind Harboe oyvind.har...@zylin.com wrote: Could someone take checkpatch for a spin and reporter back to the list on if/how we should use in w/Gerrit+Jenkins review? I think it is used client side. It certainly can be used on the client side, but I think we should run it on the server so as to automate the please fix whitespace nits. -- Øyvind Harboe - Can Zylin Consulting help on your project? US toll free 1-866-980-3434 http://www.zylin.com/ ___ Openocd-development mailing list Openocd-development@lists.berlios.de https://lists.berlios.de/mailman/listinfo/openocd-development
[Openocd-development] Gerrit + Jenkins is up
We're still working on tweaking a few things, but it is up and running now. -- Øyvind Harboe - Can Zylin Consulting help on your project? US toll free 1-866-980-3434 http://www.zylin.com/ ___ Openocd-development mailing list Openocd-development@lists.berlios.de https://lists.berlios.de/mailman/listinfo/openocd-development
Re: [Openocd-development] git gui
On Wed, Oct 26, 2011 at 2:12 AM, Peter Stuge pe...@stuge.se wrote: jim norris wrote: For those using a git gui, what are you using? On which system? For Windows, there is Git Extensions and TortoiseGit. The Git Extensions looked less slick than TortoiseGit last time I looked, but TortoisGit on the other hand lacked fundamental functionality. I recommend Gerrit. Gerrit makes a lot of the nastier concepts, like interactive rebasing and communication easier. From my experience TortoiseGit is a step down the wrong path. It makes things easier than possible, i.e. it tosses hard concepts out of the window. Where is the interactive rebase functionality? I find that Eclipse EGit is starting to become useful and there is a lot of development push on EGit. -- Øyvind Harboe - Can Zylin Consulting help on your project? US toll free 1-866-980-3434 http://www.zylin.com/ ___ Openocd-development mailing list Openocd-development@lists.berlios.de https://lists.berlios.de/mailman/listinfo/openocd-development
Re: [Openocd-development] git question.....
Use interactive rebasing: git rebase --help When you're done rebasing, just type git push review and all the updated patches will be updated in gerrit. -- Øyvind Harboe - Can Zylin Consulting help on your project? US toll free 1-866-980-3434 http://www.zylin.com/ ___ Openocd-development mailing list Openocd-development@lists.berlios.de https://lists.berlios.de/mailman/listinfo/openocd-development
[Openocd-development] Very cool output
Nice? Unused code and bugs... For instance, not used retval means missing check and error propagation = real bug. http://openocd.zylin.com/jenkins/job/openocd-gerrit/70/warningsResult/? -- Øyvind Harboe - Can Zylin Consulting help on your project? US toll free 1-866-980-3434 http://www.zylin.com/ ___ Openocd-development mailing list Openocd-development@lists.berlios.de https://lists.berlios.de/mailman/listinfo/openocd-development
Re: [Openocd-development] patch overlap
There is probably something to tune in the automatic merge from gerrit to git. Weird, obscure, correct and innocuous :-) Many thanks for helping out w/cleaning up the code btw! I'd like to get the code to a state where it compiles clean of scan-build warnings and we can switch to requiring clean scan-build for verification flag to be set. -- Øyvind Harboe - Can Zylin Consulting help on your project? US toll free 1-866-980-3434 http://www.zylin.com/ ___ Openocd-development mailing list Openocd-development@lists.berlios.de https://lists.berlios.de/mailman/listinfo/openocd-development
[Openocd-development] Problems with new Gerrit+Jenkins server
We're having problems with the new server. More info tomorrow. -- Øyvind Harboe - Can Zylin Consulting help on your project? US toll free 1-866-980-3434 http://www.zylin.com/ ___ Openocd-development mailing list Openocd-development@lists.berlios.de https://lists.berlios.de/mailman/listinfo/openocd-development
Re: [Openocd-development] Command-line paths problem in Windows
I have to agree with you here. Make things work first, nice to have but not essential things can come later. It's a policy to reduce the # of unnecessary changes to OpenOCD. The # of willy-nilly changes in itself drives the quality down. We don't understand this problem yet, so we're likely to knock something else over by being impatient here. If it takes a week or two before all the information arrives, then it's a bargain for the improved quality to OpenOCD that we receive from this policy. We just implemented an automated system to track the progress and development of such patches. -- Øyvind Harboe - Can Zylin Consulting help on your project? US toll free 1-866-980-3434 http://www.zylin.com/ ___ Openocd-development mailing list Openocd-development@lists.berlios.de https://lists.berlios.de/mailman/listinfo/openocd-development
[Openocd-development] Jenkins changes
I'd like to drive the OpenOCD code towards zero scan-build (clang static analysis) warnings and I'd very much appreciate patches to that effect! I've added a scan-build (clang static analysis) that is run when a patch is submitted (openocd-gerrit). If scan-build fails, then the patch is still marked as verified. For now. You can look at the build output to find the warnings that scan-build shows, so you don't need clang installed on your machine to fix these warnings, just look at the jenkins build output. When a patch is submitted to the main repository, scan-build warnings *will* cause a failure. Hopefully this will drive us towards zero scan-build warnings. Also, -O3 is added, which can yield an occasional extra warning compared to -O2(default). -- Øyvind Harboe - Can Zylin Consulting help on your project? US toll free 1-866-980-3434 http://www.zylin.com/ ___ Openocd-development mailing list Openocd-development@lists.berlios.de https://lists.berlios.de/mailman/listinfo/openocd-development
Re: [Openocd-development] Jenkins changes
On Sat, Oct 22, 2011 at 10:03 AM, Freddie Chopin freddie_cho...@op.pl wrote: So that's normal that all patchsets now are marked as not verified (X) because the build fails at a file completely unaffected by that patch and unchanged for a long time (buspirate.c for example)? I'm still picking out the nits of the system. I need to retrigger some builds before you see the status quo. -- Øyvind Harboe - Can Zylin Consulting help on your project? US toll free 1-866-980-3434 http://www.zylin.com/ ___ Openocd-development mailing list Openocd-development@lists.berlios.de https://lists.berlios.de/mailman/listinfo/openocd-development
Re: [Openocd-development] Jenkins changes
On Sat, Oct 22, 2011 at 10:03 AM, Freddie Chopin freddie_cho...@op.pl wrote: So that's normal that all patchsets now are marked as not verified (X) because the build fails at a file completely unaffected by that patch and unchanged for a long time (buspirate.c for example)? all you have to do, is to rebase your fix on top of the other fix that's in the queue and push. Then your patch will go green. # Copy this from the patchset w/buspirate fix: $ git fetch http://openocd.zylin.com/p/openocd refs/changes/43/43/3 git checkout FETCH_HEAD From http://openocd.zylin.com/p/openocd * branchrefs/changes/43/43/3 - FETCH_HEAD Previous HEAD position was ae675e5... Fix Evaluate 'script' in the global scope HEAD is now at 593c8de... buspirate: ignore return value and fix warning # checkout your path fix git checkout ae675e5 Previous HEAD position was 593c8de... buspirate: ignore return value and fix warning HEAD is now at ae675e5... Fix Evaluate 'script' in the global scope # rebase your patch on top of the buspirate warning fix $ git rebase 593c8de First, rewinding head to replay your work on top of it... Applying: Fix Evaluate 'script' in the global scope # Push updated patch! oyvind@titan:~/workspace/openocd$ git push review Stand back... and your patch should go green... -- Øyvind Harboe - Can Zylin Consulting help on your project? US toll free 1-866-980-3434 http://www.zylin.com/ ___ Openocd-development mailing list Openocd-development@lists.berlios.de https://lists.berlios.de/mailman/listinfo/openocd-development
[Openocd-development] cleaning up unused includes
Could someone try this on OpenOCD and report back? I'd like to see this run on the Jenkins server so that we can be sure that we run with the minimum # of includes. Reducing the # of includes is good from an architectural point of view to reduce cohesion between parts of the system. -- Øyvind Harboe - Can Zylin Consulting help on your project? US toll free 1-866-980-3434 http://www.zylin.com/ ___ Openocd-development mailing list Openocd-development@lists.berlios.de https://lists.berlios.de/mailman/listinfo/openocd-development
Re: [Openocd-development] Jenkins changes
$ git fetch http://openocd.zylin.com/p/openocd refs/changes/43/43/3 git checkout FETCH_HEAD error: RPC failed; result=22, HTTP code = 503 fatal: The remote end hung up unexpectedly Anyway - I see that my patch depends now on buspirate fix, so I guess that is't done. I did it this time. Next time it's up to you ;-) -- Øyvind Harboe - Can Zylin Consulting help on your project? US toll free 1-866-980-3434 http://www.zylin.com/ ___ Openocd-development mailing list Openocd-development@lists.berlios.de https://lists.berlios.de/mailman/listinfo/openocd-development
[Openocd-development] Help wanted to clean out warnings
Hi guys, I'd like to thank everybody that has helped make the new patch procedure a success so far. I would like to make a clean scan-build a requirement for verified on all submitted patches and we have ca. 30 or so minor nits fix before this is the case. Procedure: - Search for warning below in the output of the latest build. - Make a fix - Commit - git push review http://openocd.zylin.com/jenkins/job/openocd/lastBuild/console -- Øyvind Harboe - Can Zylin Consulting help on your project? US toll free 1-866-980-3434 http://www.zylin.com/ ___ Openocd-development mailing list Openocd-development@lists.berlios.de https://lists.berlios.de/mailman/listinfo/openocd-development
Re: [Openocd-development] commit - jim-nvp is moving from jimtcl to openocd
On Fri, Oct 21, 2011 at 10:13 AM, Spencer Oliver s...@spen-soft.co.uk wrote: with ref to subject commit ef885d3b2a3001325f525df250dadd570e5d743e the files jim-nvp.[ch] have no copyright info. They are FreeBSD, but when combined with OpenOCD source, they have to be distributed under GPL of course. The header can say FreeBSD though. Copy header from Jim project. -- Øyvind Harboe - Can Zylin Consulting help on your project? US toll free 1-866-980-3434 http://www.zylin.com/ ___ Openocd-development mailing list Openocd-development@lists.berlios.de https://lists.berlios.de/mailman/listinfo/openocd-development
Re: [Openocd-development] clang static analyzer
Hmm It doesn't work here. Any tips? Where does the output go? scan-build ./configure --enable-maintainer-mode --enable-dummy --disable-werror scan-build make ... make[2]: Leaving directory `/home/oyvind/openocd' make[1]: Leaving directory `/home/oyvind/openocd' scan-build: Removing directory '/tmp/scan-build-2011-10-21-1' because it contains no reports. This is with Ubuntu. -- Øyvind Harboe - Can Zylin Consulting help on your project? US toll free 1-866-980-3434 http://www.zylin.com/ ___ Openocd-development mailing list Openocd-development@lists.berlios.de https://lists.berlios.de/mailman/listinfo/openocd-development
Re: [Openocd-development] clang static analyzer
I upgraded to Ubuntu 11.10 from Ubuntu 11.04 and now it works :-) Looks like this is bleeding edge stuff... -- Øyvind Harboe - Can Zylin Consulting help on your project? US toll free 1-866-980-3434 http://www.zylin.com/ ___ Openocd-development mailing list Openocd-development@lists.berlios.de https://lists.berlios.de/mailman/listinfo/openocd-development
Re: [Openocd-development] commit a62d8f22 causes double evaluation of $filename in src/helper/startup.tcl proc script
Hi Freddie, as a policy we wait for all information that we expect to arrive on a bug so that we can hopefully fix the problem once and for all. This is slower, but ultimately means higher quality because we make more informed changes to OpenOCD. It isn't going to make a difference if we wait for a week on this one and there is a known workaround. It's speeding things along nicely that you're helping to fill in the information. -- Øyvind Harboe - Can Zylin Consulting help on your project? US toll free 1-866-980-3434 http://www.zylin.com/ ___ Openocd-development mailing list Openocd-development@lists.berlios.de https://lists.berlios.de/mailman/listinfo/openocd-development
Re: [Openocd-development] [PATCH] Unused variables
On Thu, Oct 20, 2011 at 7:35 AM, Peter Stuge pe...@stuge.se wrote: Øyvind Harboe wrote: I'm thinking a bit about how I can draw up some graphs on this... Graphing number of commits is easy, but graphing the review is difficult. Before we got Gerrit going I decided that I could no longer spend time submitting patches to the official repository, much as I wanted to. Some graphing I've been thinking about: - plot a number that shows the redundancy in maintainers. I.e. are we relying on a single maintainer or are there multiple maintainers who commit/submit patches? Plot standard deviation of % of commits grouped into maintainers. Do this per week to show how the project develops. - plot # of lines of code / time committed. -- Øyvind Harboe - Can Zylin Consulting help on your project? US toll free 1-866-980-3434 http://www.zylin.com/ ___ Openocd-development mailing list Openocd-development@lists.berlios.de https://lists.berlios.de/mailman/listinfo/openocd-development
Re: [Openocd-development] [PATCH] Unused variables
On Thu, Oct 20, 2011 at 8:38 AM, Peter Stuge pe...@stuge.se wrote: Øyvind Harboe wrote: Some graphing I've been thinking about: - plot a number that shows the redundancy in maintainers. I.e. are we relying on a single maintainer or are there multiple maintainers I've so far taken infinitely many more commits from Gerrit into openocd.git than before. Much more effort to deal with patch files. Ca. 2 weeks ago, I decided I could no longer commit patches and stopped doing so. Nobody else stepped up. This is why Gerrit forced itself forward as the only viable solution. Don't think that I didn't notice that you have pushed infinitely many more patches to the repository than before! :-) -- Øyvind Harboe - Can Zylin Consulting help on your project? US toll free 1-866-980-3434 http://www.zylin.com/ ___ Openocd-development mailing list Openocd-development@lists.berlios.de https://lists.berlios.de/mailman/listinfo/openocd-development
Re: [Openocd-development] [PATCH] Unused variables
Actually, in some ways nothing has changed when we switched to Gerrit. Before Gerrit, OpenOCD maintainers had stopped lifting patches into git and now we don't lift them into Gerrit. Same thing, except with Gerrit contributors (or anyone) have the option of lifting patches into Gerrit themselves. That's great if it ends up being a good thing for the project when hindsight becomes available. I hope it does. We decided to switch to Gerrit only after catastrophic failure of the existing process. I stopped submitting patches for two weeks and nobody else submitted. Clearly the process was broken. Things have improved infinitely after we introduced Gerrit. Patches are now being submitted again. -- Øyvind Harboe - Can Zylin Consulting help on your project? US toll free 1-866-980-3434 http://www.zylin.com/ ___ Openocd-development mailing list Openocd-development@lists.berlios.de https://lists.berlios.de/mailman/listinfo/openocd-development
[Openocd-development] Gerrit background
First of all, I'd like everybody to stand up and give a big hand to Spencer who's through his efforts has saved OpenOCD from a slow torturous demise! Why was Gerrit introduced? In some ways nothing has changed when we switched to Gerrit. Before Gerrit, OpenOCD maintainers had stopped lifting patches into git. I've tried to recruit new maintainers, that too. The existing process had failed catastrophically. This is not a matter of policy or opinion, it's a fact. What's changed with Gerrit? OpenOCD maintainers still don't lift patches into Gerrit. Same thing, except with Gerrit contributors (or anyone) have the option of lifting patches into Gerrit themselves. Things have improved infinitely after we introduced Gerrit. Patches are now being submitted again. However, the maintainers won't stop there. We've introduced a build server(Jenkins) that builds all patches and checks for warnings, etc. automatically so contributors can weed out all those nits before anyone look at their patches. Who knows what percentage of fixes to OpenOCD that ever make it into the repository. 10%? 5%? 50%? With Gerrit we've raised it from 0% to n%. Again! I'd like everybody to give a big round of applause to Spencer who's spent the time fixing the OpenOCD process by reading up on and setting up the Gerrit+Jenkins server -- Øyvind Harboe - Can Zylin Consulting help on your project? US toll free 1-866-980-3434 http://www.zylin.com/ ___ Openocd-development mailing list Openocd-development@lists.berlios.de https://lists.berlios.de/mailman/listinfo/openocd-development
Re: [Openocd-development] Gerrit background
I agree, this is great work. I am not a programmer myself and I can only contribute by testing or provide some suggestions based on my experiences with testing of other projects (libusb, libusb-win32, libftdi, etc). So I am kind of an outsider of this git/gerrit stuff (I admit I know very little of git, even less about gerrit), but from what I see so far, I think this is a good move. Still you can get a Gerrit account to read over patches and give comments! All you need is a web browser, you can do it on the train using your cell phone if you're a commuter :-) If you give a patch your approval, then that input will be very much appreciated and result in real improvements to code and patches being committed more rapidly. -- Øyvind Harboe - Can Zylin Consulting help on your project? US toll free 1-866-980-3434 http://www.zylin.com/ ___ Openocd-development mailing list Openocd-development@lists.berlios.de https://lists.berlios.de/mailman/listinfo/openocd-development
Re: [Openocd-development] [PATCH] Unused variables
What exactly is checked by jenkins currently? I suggest at least one build with the default ./configure (no options) and one with as many ./configure options enabled as is possible on the build host. It's very early days still and we're still sorting out problems. We have ambitions to do lots of testing automatically, including everything you mentioned. Definitely we want -Werror and we already do. We're also considering adding clang static analysis, but that's some ways off still. -- Øyvind Harboe - Can Zylin Consulting help on your project? US toll free 1-866-980-3434 http://www.zylin.com/ ___ Openocd-development mailing list Openocd-development@lists.berlios.de https://lists.berlios.de/mailman/listinfo/openocd-development
Re: [Openocd-development] Gerrit background
That is of course right. But that does not answer my question. I think it is good to change the wording of -1 to something like some changes are necessary before this patch can be accepted. I think most people will understand that this is a textstring within Gerrit. Perhaps you can talk to the developers upstream? OpenOCD just uses Gerrit. What you've find may be a beauty spot depending on who you ask. -- Øyvind Harboe - Can Zylin Consulting help on your project? US toll free 1-866-980-3434 http://www.zylin.com/ ___ Openocd-development mailing list Openocd-development@lists.berlios.de https://lists.berlios.de/mailman/listinfo/openocd-development
Re: [Openocd-development] clang static analyzer
Patches pushed Gerrit most welcome! :-) -- Øyvind Harboe - Can Zylin Consulting help on your project? US toll free 1-866-980-3434 http://www.zylin.com/ ___ Openocd-development mailing list Openocd-development@lists.berlios.de https://lists.berlios.de/mailman/listinfo/openocd-development
[Openocd-development] uploading patches without ssh to Gerrit
Is there a way to upload patches to Gerrit w/o ssh? -- Øyvind Harboe - Can Zylin Consulting help on your project? US toll free 1-866-980-3434 http://www.zylin.com/ ___ Openocd-development mailing list Openocd-development@lists.berlios.de https://lists.berlios.de/mailman/listinfo/openocd-development
Re: [Openocd-development] [PATCH] Unused variables
Please read HACKING and post to Gerrit. Thanks! -- Øyvind Harboe - Can Zylin Consulting help on your project? US toll free 1-866-980-3434 http://www.zylin.com/ ___ Openocd-development mailing list Openocd-development@lists.berlios.de https://lists.berlios.de/mailman/listinfo/openocd-development
Re: [Openocd-development] [PATCH] Unused variables
If you don't have time to work on OpenOCD, then I don't have any problems with that. The world is full of smart people who could have, but don't have time to, contribute to OpenOCD. If you do want to spend some time on OpenOCD, then I urge you to have a look at what Gerrit+Jenkins does for the community. Some of the things that Gerrit+Jenkins does for us: - Contributors, rather than maintainers will do all the work of formulating patches and serving them on a silver platter to the maintainers. - Jenkins will build and check your patch for warnings. If you generate warnings in some of the configurations that Jenkins checks for, you will get an email w/info about that. No other humans will waste time on your patch before it is ready and clean of all nits(warnings, whitespace errors, etc.). - It makes it possible for us to organise the patches, keep track of improved version of patches, etc. and decide when to submit them to the repository with a click of a button. I don't think the maintainers will be accepting or reviewing patches that are not submitted to Gerrit anymore. If this means that we loose those contributors who can't or won't take time time to learn Git and how to configure and us Gerrit, then that's really a non-issue, because maintainers are not going to spend their time to save the contributors this effort. -- Øyvind Harboe - Can Zylin Consulting help on your project? US toll free 1-866-980-3434 http://www.zylin.com/ ___ Openocd-development mailing list Openocd-development@lists.berlios.de https://lists.berlios.de/mailman/listinfo/openocd-development
Re: [Openocd-development] clang static analyzer
http://clang-analyzer.llvm.org/index.html In short, it's very slow (took over an hour to get through with OpenOCD on my machine), and it's susceptible to false positives. An hour is not the biggest problem if it saves a bunch of maintainer time. Can we choose some minimum threshold for what we'll accept in terms of errors like we do for gcc(-Werror -Wall is minimum acceptable for patches now). -- Øyvind Harboe - Can Zylin Consulting help on your project? US toll free 1-866-980-3434 http://www.zylin.com/ ___ Openocd-development mailing list Openocd-development@lists.berlios.de https://lists.berlios.de/mailman/listinfo/openocd-development
Re: [Openocd-development] [PATCH] Unused variables
If you want to spend the time taking other people's patches and pushing them to Gerrit so they don't have to, go right ahead. You do not have to be an OpenOCD maintainer to do this, anyone can push anyones patches to Gerrit for review. I don't expect you to step up to take such a role, nor do I expect anyone else. Really this is the sort of work that you have to pay someone to do or you have to do it yourself. We're starting to gather data that we're getting *more* and *better* patches submitted to the Git repository. We also see that the less active maintainers are now reviewing and submitting to the repository. I'm thinking a bit about how I can draw up some graphs on this... -- Øyvind Harboe - Can Zylin Consulting help on your project? US toll free 1-866-980-3434 http://www.zylin.com/ ___ Openocd-development mailing list Openocd-development@lists.berlios.de https://lists.berlios.de/mailman/listinfo/openocd-development
[Openocd-development] clang static analyzer
Does anyone want to take clang static analyzer for a spin on openocd? http://clang-analyzer.llvm.org/scan-build.html -- Øyvind Harboe - Can Zylin Consulting help on your project? US toll free 1-866-980-3434 http://www.zylin.com/ ___ Openocd-development mailing list Openocd-development@lists.berlios.de https://lists.berlios.de/mailman/listinfo/openocd-development
Re: [Openocd-development] clang static analyzer
On Tue, Oct 18, 2011 at 9:46 PM, Spencer Oliver s...@spen-soft.co.uk wrote: On 18/10/2011 18:18, Øyvind Harboe wrote: Does anyone want to take clang static analyzer for a spin on openocd? http://clang-analyzer.llvm.org/scan-build.html seems jenkins already has a plugin for that :) https://wiki.jenkins-ci.org/display/JENKINS/Clang+Scan-Build+Plugin Can we have it? :-) Perhaps we can add that as an additional lint/analysis check step so that we can weed out more. -- Øyvind Harboe - Can Zylin Consulting help on your project? US toll free 1-866-980-3434 http://www.zylin.com/ ___ Openocd-development mailing list Openocd-development@lists.berlios.de https://lists.berlios.de/mailman/listinfo/openocd-development
Re: [Openocd-development] clang static analyzer
Cool! Could I ask you to work through and fix some of the bugs and submit them to Gerrit? I'd like to see patches having to pass clang static analyzer unscathed before they're ready for review :-) -- Øyvind Harboe - Can Zylin Consulting help on your project? US toll free 1-866-980-3434 http://www.zylin.com/ ___ Openocd-development mailing list Openocd-development@lists.berlios.de https://lists.berlios.de/mailman/listinfo/openocd-development
[Openocd-development] Reviewing in Gerrit
Even if you're not a maintainer, your help to review and comment on patches in Gerrit will be very much appreciated. -- Øyvind Harboe - Can Zylin Consulting help on your project? US toll free 1-866-980-3434 http://www.zylin.com/ ___ Openocd-development mailing list Openocd-development@lists.berlios.de https://lists.berlios.de/mailman/listinfo/openocd-development
[Openocd-development] Improved DCC performance
If someone wants to test out the DCC performance before and after this patch, it would be much appreciated! http://openocd.zylin.com/27 -- Øyvind Harboe - Can Zylin Consulting help on your project? US toll free 1-866-980-3434 http://www.zylin.com/ ___ Openocd-development mailing list Openocd-development@lists.berlios.de https://lists.berlios.de/mailman/listinfo/openocd-development
[Openocd-development] Gerrit - how do I check if I addressed all the comments?
What's a good way to check that I've addressed all the comments to a patch series? Going over it manually? -- Øyvind Harboe - Can Zylin Consulting help on your project? US toll free 1-866-980-3434 http://www.zylin.com/ ___ Openocd-development mailing list Openocd-development@lists.berlios.de https://lists.berlios.de/mailman/listinfo/openocd-development
Re: [Openocd-development] OpenOCD Gerrit Review
Hi Jean-Christophe, the whole point of Gerrit is that the contributors can manage patches instead of the maintainers. We even want/plan to have automated checks on checkpatch.pl and building the patch checking for warnings so maintainers can ignore patches that don't pass those tests. The maintainers role is then to comment and say yay or nay. No software required to be installed locally, which allows maintainers to help out without their development system at hand. Very important -- Øyvind Harboe - Can Zylin Consulting help on your project? US toll free 1-866-980-3434 http://www.zylin.com/ ___ Openocd-development mailing list Openocd-development@lists.berlios.de https://lists.berlios.de/mailman/listinfo/openocd-development
Re: [Openocd-development] Info about RTOS support
There is some in the OpenOCD manual, but we would very much welcome patches for more! Did you check out the documentation you could find in the OpenOCD manual? -- Øyvind Harboe - Can Zylin Consulting help on your project? US toll free 1-866-980-3434 http://www.zylin.com/ ___ Openocd-development mailing list Openocd-development@lists.berlios.de https://lists.berlios.de/mailman/listinfo/openocd-development
Re: [Openocd-development] Info about RTOS support
I checked on the http://openocd.sourceforge.net/doc//pdf/openocd.pdf. I did a find on rtos keyword, and find nothing about this. Perhaps that pdf is old, try openocd.texi from HEAD of master. -- Øyvind Harboe - Can Zylin Consulting help on your project? US toll free 1-866-980-3434 http://www.zylin.com/ ___ Openocd-development mailing list Openocd-development@lists.berlios.de https://lists.berlios.de/mailman/listinfo/openocd-development
[Openocd-development] outstanding patches?
Please submit all outstanding patch series to Gerrit. Read latest HACKING docs for tips on how to get started. By doing this you will be helping to save maintainers time so that we can focus on reviewing and commenting. -- Øyvind Harboe - Can Zylin Consulting help on your project? US toll free 1-866-980-3434 http://www.zylin.com/ ___ Openocd-development mailing list Openocd-development@lists.berlios.de https://lists.berlios.de/mailman/listinfo/openocd-development
Re: [Openocd-development] OpenOCD Gerrit Review
On Tue, Oct 11, 2011 at 5:59 PM, Tormod Volden lists.tor...@gmail.com wrote: On Tue, Oct 11, 2011 at 4:14 PM, Laurent Gauch wrote: Why using a commercial server and a commercial url for an open source project? heh, like sourceforge.net, code.google.com, github.com or launchpad.net? So that the open-source crowd can spend their valuable time on producing free and open-source software instead of boring tasks like web hosting, I believe. I thought it was easier to recall than a.b1-d72-df-sd2-eapps.com -- Øyvind Harboe - Can Zylin Consulting help on your project? US toll free 1-866-980-3434 http://www.zylin.com/ ___ Openocd-development mailing list Openocd-development@lists.berlios.de https://lists.berlios.de/mailman/listinfo/openocd-development
[Openocd-development] Documentation for gerrit usage
If someone wants to contribute a patch with documentation on how to use gerrit, that would be most welcome! -- Øyvind Harboe - Can Zylin Consulting help on your project? US toll free 1-866-980-3434 http://www.zylin.com/ ___ Openocd-development mailing list Openocd-development@lists.berlios.de https://lists.berlios.de/mailman/listinfo/openocd-development
[Openocd-development] how to push patch series to gerrit?
How do I push a patch series to gerrit? Does gerrit have a concept of patch series or are all patches islands? -- Øyvind Harboe - Can Zylin Consulting help on your project? US toll free 1-866-980-3434 http://www.zylin.com/ ___ Openocd-development mailing list Openocd-development@lists.berlios.de https://lists.berlios.de/mailman/listinfo/openocd-development
Re: [Openocd-development] OpenOCD Gerrit Review
Hi Jason, I do share your concern that we're loosing something when we're not using the mailing list to discuss patches. However, I certainly still welcome discussion of patches in the mailing list prior to pushing them to Gerrit. In fact I think that if the entire discussion was in the mailing list and all we used gerrit for was to queue up ready patches to be submitted in due time, then that would be a perfectly acceptable state of affairs. Similarly I think that it's great to clear a lot of the noisy discussions from the mailing list(fix whitespace, remove useless comment, etc.). What I as a maintainer is trying to do is to enable contributors to do more and for the contributors and community to be less dependent on maintainers. We're also looking into getting some verifiers installed on Gerrit so that the computer can take care of checking that whitespace problems are fixed, etc. -- Øyvind Harboe - Can Zylin Consulting help on your project? US toll free 1-866-980-3434 http://www.zylin.com/ ___ Openocd-development mailing list Openocd-development@lists.berlios.de https://lists.berlios.de/mailman/listinfo/openocd-development
Re: [Openocd-development] how to push patch series to gerrit?
Does gerrit have a concept of patch series or are all patches islands? If you push a series of commits to gerrit as per above then gerrit will record dependency between the commits. I did git am -s on two patches and tried using Spencer's config: git push review Counting objects: 16, done. Delta compression using up to 2 threads. Compressing objects: 100% (11/11), done. Writing objects: 100% (11/11), 1.44 KiB, done. Total 11 (delta 9), reused 0 (delta 0) remote: Resolving deltas: 0% (0/9) remote: ERROR: missing Change-Id in commit message remote: Suggestion for commit message: remote: breakpoint : indentation remote: remote: Signed-off-by: Øyvind Harboe oyvind.har...@zylin.com remote: remote: Change-Id: Icdb8f72dbb516cd0dfc612c3d61b6801f6382be6 -- Øyvind Harboe - Can Zylin Consulting help on your project? US toll free 1-866-980-3434 http://www.zylin.com/ ___ Openocd-development mailing list Openocd-development@lists.berlios.de https://lists.berlios.de/mailman/listinfo/openocd-development
Re: [Openocd-development] how to push patch series to gerrit?
Ah gotit. I need a unique id per patch, I thought the id had to be unique per series. I thought that patches would be displayed as series within the same patch id rather than this depends on scheme. -- Øyvind Harboe - Can Zylin Consulting help on your project? US toll free 1-866-980-3434 http://www.zylin.com/ ___ Openocd-development mailing list Openocd-development@lists.berlios.de https://lists.berlios.de/mailman/listinfo/openocd-development
Re: [Openocd-development] gerrit hosting
Anyway you can check this site to find any hoster with a code review ability: http://en.wikipedia.org/wiki/Comparison_of_open_source_software_hosting_facilities No gerrit listed. I've asked sourceforge if they can install it, but I'm not holding my breath. -- Øyvind Harboe - Can Zylin Consulting help on your project? US toll free 1-866-980-3434 http://www.zylin.com/ ___ Openocd-development mailing list Openocd-development@lists.berlios.de https://lists.berlios.de/mailman/listinfo/openocd-development
[Openocd-development] gerrit hosting
sourceforge does not offer gerrit. Is there a hosting service that does? -- Øyvind Harboe - Can Zylin Consulting help on your project? US toll free 1-866-980-3434 http://www.zylin.com/ ___ Openocd-development mailing list Openocd-development@lists.berlios.de https://lists.berlios.de/mailman/listinfo/openocd-development
Re: [Openocd-development] Compile errors....
On Fri, Oct 7, 2011 at 4:34 PM, jim norris u17...@att.net wrote: I'm getting compile errors from a fresh clone of the tree in the files: src/target/armv7a.c src/target/cortex_a.c having to do with unused but set variables. Did I miss something? OpenOCD compiles with -Werror which causes all warnings to produce errors. This is to force us to fix all errors as we go along. Please submit a patch to fix the warnings. Thanks! -- Øyvind Harboe - Can Zylin Consulting help on your project? US toll free 1-866-980-3434 http://www.zylin.com/ ___ Openocd-development mailing list Openocd-development@lists.berlios.de https://lists.berlios.de/mailman/listinfo/openocd-development
[Openocd-development] Show of hands for/against gerrit
I find gerrit intriguing as a way of managing patches. Can I have a show of hands of contributors for/against/don't care/don't know? -- Øyvind Harboe - Can Zylin Consulting help on your project? US toll free 1-866-980-3434 http://www.zylin.com/ ___ Openocd-development mailing list Openocd-development@lists.berlios.de https://lists.berlios.de/mailman/listinfo/openocd-development
Re: [Openocd-development] Show of hands for/against gerrit
http://code.google.com/p/gerrit/ I have no idea what it does, but I'm very excited! :-) -- Øyvind Harboe - Can Zylin Consulting help on your project? US toll free 1-866-980-3434 http://www.zylin.com/ ___ Openocd-development mailing list Openocd-development@lists.berlios.de https://lists.berlios.de/mailman/listinfo/openocd-development
Re: [Openocd-development] Fwd: BerliOS will be closed on 31.12.2011
No mailing list??? -- Øyvind Harboe - Can Zylin Consulting help on your project? US toll free 1-866-980-3434 http://www.zylin.com/ ___ Openocd-development mailing list Openocd-development@lists.berlios.de https://lists.berlios.de/mailman/listinfo/openocd-development
Re: [Openocd-development] [PATCH] updated Fujitsu FM3 Flash driver
Hi, some comments: 1. please fix warning: fm3.c: In function ‘fm3_chip_erase’: fm3.c:785:25: error: declaration of ‘fm3_info’ shadows a global declaration fm3.c:774:12: error: shadowed declaration is here 2. Remove this history, git keeps it: +// History: +// 2011-07-13 MWi First version +// 2011-09-27 MWi Flash type 2 added, algorithm start address now relocateable -- Øyvind Harboe - Can Zylin Consulting help on your project? US toll free 1-866-980-3434 http://www.zylin.com/ ___ Openocd-development mailing list Openocd-development@lists.berlios.de https://lists.berlios.de/mailman/listinfo/openocd-development
Re: [Openocd-development] software breakpoint with multicore systems
Can someone review these patches and comment? Thanks! -- Øyvind Harboe - Can Zylin Consulting help on your project? US toll free 1-866-980-3434 http://www.zylin.com/ ___ Openocd-development mailing list Openocd-development@lists.berlios.de https://lists.berlios.de/mailman/listinfo/openocd-development
Re: [Openocd-development] [PATCH] AM/DM37x: add ES1.2 silicon type into account
Merged. Thanks! -- Øyvind Harboe - Can Zylin Consulting help on your project? US toll free 1-866-980-3434 http://www.zylin.com/ ___ Openocd-development mailing list Openocd-development@lists.berlios.de https://lists.berlios.de/mailman/listinfo/openocd-development
Re: [Openocd-development] [PATCH] Move jim-nvp to openocd
Merged. Thanks! -- Øyvind Harboe - Can Zylin Consulting help on your project? US toll free 1-866-980-3434 http://www.zylin.com/ ___ Openocd-development mailing list Openocd-development@lists.berlios.de https://lists.berlios.de/mailman/listinfo/openocd-development
Re: [Openocd-development] Cache L1, L2 on armv7a.
Merged. Thanks! -- Øyvind Harboe - Can Zylin Consulting help on your project? US toll free 1-866-980-3434 http://www.zylin.com/ ___ Openocd-development mailing list Openocd-development@lists.berlios.de https://lists.berlios.de/mailman/listinfo/openocd-development
[Openocd-development] Fwd: BerliOS will be closed on 31.12.2011
source software components and between open source and closed source software. Example of our OSS activities including our management of the German Competence Center QualiPSo. We thank all who have used BerliOS over the years. Fraunhofer FOKUS www.fokus.fraunhofer.de - This email was sent from developer.berlios.de. To change your email receipt preferences, please visit the site and edit your account via the Account Maintenance link. Direct any questions to ad...@berlios.de, or reply to this email. -- Øyvind Harboe - Can Zylin Consulting help on your project? US toll free 1-866-980-3434 http://www.zylin.com/ ___ Openocd-development mailing list Openocd-development@lists.berlios.de https://lists.berlios.de/mailman/listinfo/openocd-development
Re: [Openocd-development] Fwd: BerliOS will be closed on 31.12.2011
On Sat, Oct 1, 2011 at 12:45 AM, Jim Larson jlar...@pacifier.com wrote: Any consideration of using github (github.com)? I've been pretty happy with them and they have a huge user base. I haven't used them. Would you mind explaining the major features of github to the list? -- Øyvind Harboe - Can Zylin Consulting help on your project? US toll free 1-866-980-3434 http://www.zylin.com/ ___ Openocd-development mailing list Openocd-development@lists.berlios.de https://lists.berlios.de/mailman/listinfo/openocd-development
Re: [Openocd-development] [PATCH] Move jim-nvp to openocd
So what happens in the transitional period? -- Øyvind Harboe - Can Zylin Consulting help on your project? US toll free 1-866-980-3434 http://www.zylin.com/ ___ Openocd-development mailing list Openocd-development@lists.berlios.de https://lists.berlios.de/mailman/listinfo/openocd-development
Re: [Openocd-development] [PATCH] Move jim-nvp to openocd
On Thu, Sep 29, 2011 at 8:42 AM, Steve Bennett ste...@workware.net.au wrote: It lives in both openocd and jimtcl, but openocd uses it's own version. Because --disable-nvp is used when building OpenOCD? -- Øyvind Harboe - Can Zylin Consulting help on your project? US toll free 1-866-980-3434 http://www.zylin.com/ ___ Openocd-development mailing list Openocd-development@lists.berlios.de https://lists.berlios.de/mailman/listinfo/openocd-development
Re: [Openocd-development] STM32L microcontroller support
2011/9/27 Clément Burin des Roziers clement.burin-des-rozi...@hikob.com:
Hello Øyvind,
I've prepared a new patch, fixing the memory issues.
Some more comments. I was ready to commit, but got warnings...
1. Warning:
cc1: warnings being treated as errors
stm32lx.c: In function ‘stm32lx_write_half_pages’:
stm32lx.c:286: error: format ‘%lu’ expects type ‘long unsigned int’,
but argument 6 has type ‘unsigned int’
+ LOG_DEBUG(writing flash code (%lu bytes),
sizeof(stm32lx_flash_write_code));
= switch to the PRI macros, such as:
LOG_ERROR(chip address %08 PRIx32 not NAND-enabled?, info-data);
return ERROR_NAND_OPERATION_FAILED;
2. Use goto instead of this construct, or better, split out in a
separate fn so it's easier
to handle cleanup of resources.
+static int stm32lx_write_half_pages(struct flash_bank *bank, uint8_t *buffer,
+ uint32_t offset, uint32_t count)
+{
...
+ if (retval == ERROR_OK)
+ {
+ reg32 |= FLASH_PECR__PROG;
+ retval = target_write_u32(target, FLASH_PECR, reg32);
+ }
+
+ // Loop while there are bytes to write
+ while ((retval == ERROR_OK) (count 0))
+ {
--
Øyvind Harboe - Can Zylin Consulting help on your project?
US toll free 1-866-980-3434
http://www.zylin.com/
___
Openocd-development mailing list
Openocd-development@lists.berlios.de
https://lists.berlios.de/mailman/listinfo/openocd-development
Re: [Openocd-development] [PATCH] kinetis cpu flash driver
Merged. Thanks! -- Øyvind Harboe - Can Zylin Consulting help on your project? US toll free 1-866-980-3434 http://www.zylin.com/ ___ Openocd-development mailing list Openocd-development@lists.berlios.de https://lists.berlios.de/mailman/listinfo/openocd-development
Re: [Openocd-development] [PATCH] dsp563xx: add target events, run algorithm and default r/w buffer api
Merged. Thanks! -- Øyvind Harboe - Can Zylin Consulting help on your project? US toll free 1-866-980-3434 http://www.zylin.com/ ___ Openocd-development mailing list Openocd-development@lists.berlios.de https://lists.berlios.de/mailman/listinfo/openocd-development
Re: [Openocd-development] STM32L microcontroller support
It is looking much better. Some more comments: 1. I'd remove comments such as the below though. + // Create the bank structure + stm32lx_info = malloc(sizeof(struct stm32lx_flash_bank)); + + // Check allocation + if (stm32lx_info == NULL) 2. Missing error check: target_read_u32 3. missing error check: stm32lx_wait_until_bsy_clear 4. Resource leakage: + // Lock back program memory + retval = stm32lx_lock_program_memory(bank); + if (retval != ERROR_OK) + return retval; + + // Free the working areas + target_free_working_area(target, source); + target_free_working_area(target, stm32lx_info-write_algorithm); + + // Destroy the registers + destroy_reg_param(reg_params[0]); + destroy_reg_param(reg_params[1]); + destroy_reg_param(reg_params[2]); + destroy_reg_param(reg_params[3]); + + return retval; +} 5. Bug: + // Wait for busy clear + retval = stm32lx_wait_until_bsy_clear(bank); + return retval; -- Øyvind Harboe - Can Zylin Consulting help on your project? US toll free 1-866-980-3434 http://www.zylin.com/ ___ Openocd-development mailing list Openocd-development@lists.berlios.de https://lists.berlios.de/mailman/listinfo/openocd-development
Re: [Openocd-development] STM32L microcontroller support
Please merge the two patches into one: git rebase -i origin/master = squash your patches together read HACKING for further tips. -- Øyvind Harboe - Can Zylin Consulting help on your project? US toll free 1-866-980-3434 http://www.zylin.com/ ___ Openocd-development mailing list Openocd-development@lists.berlios.de https://lists.berlios.de/mailman/listinfo/openocd-development
Re: [Openocd-development] STM32L microcontroller support
Some more nit-picking:
1. Switch more LOG_INFO() to LOG_DEBUG(). LOG_INFO() is intended for
'users'
+ LOG_INFO(allocating working area for algo (%u bytes), reg32);
2. Purge unused prototypes and reorder fn's to avoid unecessary ones:
+/* Private prototypes */
+static int stm32lx_unlock_pecr(struct flash_bank *bank);
+static int stm32lx_lock_pecr(struct flash_bank *bank);
+static int stm32lx_unlock_program_memory(struct flash_bank *bank);
+static int stm32lx_lock_program_memory(struct flash_bank *bank);
+static int stm32lx_unlock_option_byte(struct flash_bank *bank);
+static int stm32lx_erase_sector(struct flash_bank *bank, int sector);
+static int stm32lx_wait_until_bsy_clear(struct flash_bank *bank);
3. Remove warning or change to LOG_DEBUG()
+ if (target_alloc_working_area(target, reg32,
stm32lx_info-write_algorithm)
+ != ERROR_OK)
+ {
+ LOG_WARNING(no working area available, can't do block memory
writes);
+ return ERROR_TARGET_RESOURCE_NOT_AVAILABLE;
+ };
4. Add missing error propagation:
+ // Lock back program memory
+ stm32lx_lock_program_memory(bank);
+
5. Change to LOG_DEBUG() or remove.
+ retval = stm32lx_write_rdp(bank, 0xAA);
+ if (retval != ERROR_OK)
+ {
+ LOG_ERROR(failed to write RDP byte);
+ return retval;
+ }
+ }
6.
--
Øyvind Harboe - Can Zylin Consulting help on your project?
US toll free 1-866-980-3434
http://www.zylin.com/
___
Openocd-development mailing list
Openocd-development@lists.berlios.de
https://lists.berlios.de/mailman/listinfo/openocd-development
Re: [Openocd-development] [PATCH] kinetis cpu flash driver
I'll let it cool off for a few days. Please give word if further work is required and we should submit an updated patch. -- Øyvind Harboe - Can Zylin Consulting help on your project? US toll free 1-866-980-3434 http://www.zylin.com/ ___ Openocd-development mailing list Openocd-development@lists.berlios.de https://lists.berlios.de/mailman/listinfo/openocd-development
Re: [Openocd-development] [PATCH] kinetis cpu flash driver
Merged. Thanks! -- Øyvind Harboe - Can Zylin Consulting help on your project? US toll free 1-866-980-3434 http://www.zylin.com/ ___ Openocd-development mailing list Openocd-development@lists.berlios.de https://lists.berlios.de/mailman/listinfo/openocd-development
Re: [Openocd-development] [PATCH] kinetis auto mass erase on secured devices
Merged. Thanks! -- Øyvind Harboe - Can Zylin Consulting help on your project? US toll free 1-866-980-3434 http://www.zylin.com/ ___ Openocd-development mailing list Openocd-development@lists.berlios.de https://lists.berlios.de/mailman/listinfo/openocd-development
Re: [Openocd-development] [PATCH] kinetis cpu flash driver
First of all, overall I think the code looks good!
Some nit-picking below.
The OpenOCD error handling is modeled upon exception handling, report error
in place and then just propagate errors (exceptions) without changing the return
value.
1. Switch to LOG_ERROR.
+FLASH_BANK_COMMAND_HANDLER(kinetis_flash_bank_command)
+{
+ if (CMD_ARGC 6) {
+ LOG_WARNING(incomplete flash_bank kinetis configuration %d,
+ CMD_ARGC);
+ return ERROR_FLASH_OPERATION_FAILED;
+ }
2. Just return LOG_ERROR()
+static int kinetis_protect(struct flash_bank *bank, int set, int first,
+ int last)
+{
+ struct flash_bank *master_bank = kinetis_get_master_bank(bank);
+
+ LOG_WARNING(kinetis_protect not supported yet);
+
+ if (bank-target-state != TARGET_HALTED) {
+ LOG_ERROR(Target not halted);
+ return ERROR_TARGET_NOT_HALTED;
+ }
+
+ if (master_bank == NULL) {
+ return ERROR_FLASH_OPERATION_FAILED;
+ }
+
+ return ERROR_OK;
+}
3. Modify to return error as primary return value and pointer in
secondary return
value, then just propagate the return value unchanged upon error.
+static struct flash_bank *kinetis_get_master_bank(struct flash_bank *bank)
4. This fn does not propagate failure:
+static void kinetis_update_bank_info(struct flash_bank *bank)
+{
+ struct flash_bank *master_bank = kinetis_get_master_bank(bank);
+
+ if (master_bank == NULL) {
+ return;
+ }
+
5. propagate (just return) the error code, do not change it:
+ if (kinetis_ftfl_command(bank, w0, w1, w2) != ERROR_OK) {
+ return ERROR_FLASH_OPERATION_FAILED;
+ }
+
+
--
Øyvind Harboe - Can Zylin Consulting help on your project?
US toll free 1-866-980-3434
http://www.zylin.com/
___
Openocd-development mailing list
Openocd-development@lists.berlios.de
https://lists.berlios.de/mailman/listinfo/openocd-development
Re: [Openocd-development] [PATCH] contrib: fix udev rules for tty based adaptors
Merged. Thanks! -- Øyvind Harboe - Can Zylin Consulting help on your project? US toll free 1-866-980-3434 http://www.zylin.com/ ___ Openocd-development mailing list Openocd-development@lists.berlios.de https://lists.berlios.de/mailman/listinfo/openocd-development
Re: [Openocd-development] STM32L microcontroller support
Hi,
the code looks very good! Nit-picking below.
Please address the comments below and add a commit comment.
1. Make changes.
2. Create commit patch
git add .
git commit
# write comment
git format-patch HEAD^
= email patch w/commit comments.
Read openocd/HACKING for more info.
Thanks!
1. Switch to LOG_ERROR
+struct stm32lx_flash_bank *stm32lx_info;
+if (CMD_ARGC 6)
+{
+LOG_WARNING(incomplete flash_bank stm32lx configuration);
+return ERROR_FLASH_BANK_INVALID;
+}
2. Delete unimplemented code, leave only a comment. Mass erase is
notoriously hard
to test based upon feedback on the list so we want this seriously
tested before we want
to introduce extra code-paths.
+// Mass erase does not work yet
+if (0)
+{
+if ((first == 0) (last == bank-num_sectors - 1))
+{
+// Erase all if required
+return stm32lx_mass_erase(bank);
+}
+}
+
3. Return error message or at least add comment that this is a
successful no-op always.
+static int stm32lx_protect(struct flash_bank *bank, int set, int first,
+int last)
+{
+return ERROR_OK;
+}
+
4. Remove err:
+LOG_ERROR(err: failed to unlock program memory);
+return retval;
+}
5. add timeout
stm32lx_wait_until_bsy_clear
6. add memory allocation check.
+// allocate a buffer to read memory
+uint8_t *buffer = malloc(buffer_size);
7. reformat to use multiple lines as is done elsewhere in the code.
+static const struct command_registration stm32lx_command_handlers[] =
+{
+{ .name = stm32lx, .mode = COMMAND_ANY, .help =
+stm32lx flash command group, .chain =
+stm32lx_exec_command_handlers, },
+COMMAND_REGISTRATION_DONE };
8. Remove these comments, they add no information:
+// auto probe command
+.auto_probe = stm32lx_auto_probe,
9. Remove or elaborate on these comments. Perhaps better write a short
paragraph instead of these inline comments. The comments say nothing
that the code doesn't already.
+// prototypes
+static int stm32lx_unlock_pecr(struct flash_bank *bank)
+{
+// Write key2
+retval = target_write_u32(target, FLASH_PEKEYR, PEKEY2);
+// Then unlock the program memory, write key1
+retval = target_write_u32(target, FLASH_PRGKEYR, PRGKEY1);
9. Just for information. You are here adding two errors, first
target_write_memory()
reports an error, then you amend that information with a bit of
context, which is
OK if that's what you intended.
+retval = target_read_u32(target, FLASH_OBR, reg32);
+if (retval != ERROR_OK)
+{
+LOG_ERROR(stm32lx_read_rdp: failed to read FLASH_OBR);
10. Remove this error message? Change to LOG_DEBUG()? Certainly remove
stm32lx_write_rdp: because LOG_ERROR() adds that info already.
+retval = stm32lx_unlock_option_byte(bank);
+if (retval != ERROR_OK)
+{
+LOG_ERROR(stm32lx_write_rdp: failed to unlock option byte);
+return retval;
--
Øyvind Harboe - Can Zylin Consulting help on your project?
US toll free 1-866-980-3434
http://www.zylin.com/
___
Openocd-development mailing list
Openocd-development@lists.berlios.de
https://lists.berlios.de/mailman/listinfo/openocd-development
