D19306: send a signal over dbus when the wrong password is provided

2019-02-25 Thread Marco Martin 
mart added a comment.


  F6634894: Screenshot_20190225_170638.png 


REPOSITORY
  R116 Plasma Network Management Applet

REVISION DETAIL
  https://phabricator.kde.org/D19306

To: mart, #plasma, jgrulich
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19306: send a signal over dbus when the wrong password is provided

2019-02-25 Thread Marco Martin 
mart created this revision.
mart added reviewers: Plasma, jgrulich.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
Herald added 1 blocking reviewer(s): jgrulich.
mart requested review of this revision.

REVISION SUMMARY
  On Plasma Mobile we can't actually show a qwidgets based dialog
  when the password is wrong, and preferably not any additional window over the 
$
  this adds a signal to the kded when it fails to authenticate,
  the handler will forget such password so that the password field will appear 
again and the kcm shows an error message when this happens

TEST PLAN
  tried to connect with wrong password

REPOSITORY
  R116 Plasma Network Management Applet

BRANCH
  phab/errorSignal

REVISION DETAIL
  https://phabricator.kde.org/D19306

AFFECTED FILES
  kded/secretagent.cpp
  kded/secretagent.h
  kded/service.cpp
  kded/service.h
  libs/handler.cpp
  libs/handler.h
  mobile/wifi/package/contents/ui/NetworkListView.qml

To: mart, #plasma, jgrulich
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

Monday meeting notes for 25/2/2019

2019-02-25 Thread Marco Martin 
Bhushan:
* prograss with Plasma Mobile on librem5
* https://bshah.in/plasma-librem5.mp4 here is video of Plasma Mobile running 
on Librem 5

Kai Uwe:
- PowerDevil now sets KAboutData (got lost in kde4→kf5 port) so it shows up 
properly in DrKonqi
-- sitter found a race when using KCrash AutoRestart with KDBusService Unique:
-- basically app restarts, finds the DBus service still held by the now 
defunct crashed instance, quits
- Fixed Colors KCM color scheme editor modality

David:
* Mostly been helping other people on so many reviews. Not finished a lot :/
* some own diffs: D19029, D18922
* In terms of plans for the week. I have to finish: libkworkspace2, 
kwindowsystem shadows and fixing XDG configure events on kwin

Vlad:
* I'd been busy in code reviews and Bugzilla.
*  Currently I learn libdrm and libgbm

Roman:
---
What I did:
---
* Pushed the XWayland DND patch set. Please test the functionality on master 
and tell me if you encounter problems. 
 Diff 15627 "[xwl] Drag and drop between Xwayland and Wayland native clients" 
[Closed] https://phabricator.kde.org/D15627
* Pushed a fix for Shm textures. 
 Diff 18453 "Reload Shm texture when buffer size changes" [Closed] https://
phabricator.kde.org/D18453
* Updated my wayland backend rework with multi-output support: 
 Diff 18465 "[platforms/wayland] Multi output support" [Needs Review] https://
phabricator.kde.org/D18465
* AbstractOutput taking over the world such that we can remove Screens class 
later on: D19199 D19207 D19208 (note that with these patches and the wayland 
backend rework all backends now use AbstractOutput)
 Diff 19199 "[platforms/fbdev] Port to AbstractOutput" [Needs Review] https://
phabricator.kde.org/D19199
 Diff 19207 "[platforms/x11/windowed] Port to AbstractOutput" [Needs Review] 
https://phabricator.kde.org/D19207
 Diff 19208 "[platforms/x11/standalone] Port to AbstractOutput" [Needs Review] 
https://phabricator.kde.org/D19208
* Created tasks to define input-output usage patterns (IOUP). Basically an 
high-level concept to describe the device setup KWin and Plasma is run by 
(smartphone vs desktop vs tv setup).
* Inspected a focus issue on multi-output setups in XWayland: D19253 David has 
a better patch for that though I want to see merged in the next few days.
 Diff 19253 "[WIP] Send xdg_output done event only when wl_output does too" 
[Needs Review] https://phabricator.kde.org/D19253
* SDL2 patch for fixing semi-windowed BPM on game exit: https://github.com/
ValveSoftware/steam-for-linux/issues/4313#issuecomment-466677145 (see also 
https://bugs.kde.org/show_bug.cgi?id=359327)
* Fix for Steam BPM and potentially other XWayland clients not regaining 
focus: D19262
 KDE bug 359327 in kwin (general) "Exiting game a in Steam Big Picture Mode 
gets semi-windowed BPM" [normal,UPSTREAM] https://bugs.kde.org/show_bug.cgi?
id=359327
 Diff 19262 "Delayed focus updates for Toplevels without surface" [Needs 
Review] https://phabricator.kde.org/D19262
--
What I want to do now:
--
* Continue work on the IOUPs and add some class structure for it in KWin + a 
minimal Wayland protocol.
* Look into how to remove Screens class.
---
Questions/Problems:
---
* The AbstractOutput/waylad backend multi-output reviews need to move forward 
so I can work on the Screens removal task.


Eike:
* I did write two patches for the Task Manager and libtaskmanager respectively
* Fixing regression two different bugs for regressions from the new VD code
* One of them still needs some revision going by tester feedback


Marco:
Kirigami:
* Finishing up the pagerow c++ rewrite, ready to land
* some bug fixing
KWin:
* Another go at the virtual keyboard positioning: D18818 (really need help on 
that, for a first even just a review, is kinda stuck there, this week i'll 
probably kidnap someone to figure out things)

-- 
Marco Martin

D18644: GlobalDrawerActionItem: properly reference icon by using group property.

2019-02-21 Thread Marco Martin 
mart added a comment.


  ping?

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D18644

To: pwegner, #kirigami, mart
Cc: plasma-devel, dkardarakos, apol, davidedmundson, mart, hein

D18716: Add an ActionTextField component

2019-02-21 Thread Marco Martin 
mart added a comment.


  it''s lmost perfect,
  just a little point on the icon loading, then is good to go

INLINE COMMENTS

> MultipleColumnsGallery.qml:61
>  Controls.Label {
> -anchors.horizontalCenter: parent.horizontalCenter
> +Layout.alignment: Qt.AlignHCenter
>  text: "Page implicitWidth: " + page.implicitWidth

unrelated change, separate commit?

> ActionTextField.qml:103
> +width: this.implicitHeight - 2 * Kirigami.Units.smallSpacing
> +source: modelData.iconName
> +visible: modelData.visible

icon.name, so will work also with qqc2 actions

or better:
source: modelData.icon.name.length > 0 ? modelData.icon.name : 
modelData.icon.source

> ActionTextField.qml:124
> +width: this.implicitHeight - 2 * Kirigami.Units.smallSpacing
> +source: modelData.iconName
> +visible: modelData.visible

icon.name

or better:
source: modelData.icon.name.length > 0 ? modelData.icon.name : 
modelData.icon.source

> ognarb wrote in kirigamiplugin.cpp:181
> @mart Should I use 2.6 or 2.7? I didn't find any information about that 
> version I should use.

2.7

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D18716

To: ognarb, apol, #kirigami, ngraham, mart
Cc: broulik, mart, apol, ngraham, plasma-devel, dkardarakos, davidedmundson, 
hein

D19203: ColumnView and partial C++ refactor of PageRow

2019-02-21 Thread Marco Martin 
mart created this revision.
mart added a reviewer: Kirigami.
Herald added a project: Kirigami.
Herald added a subscriber: plasma-devel.
mart requested review of this revision.

REVISION SUMMARY
  ColumnView is a container component which encapsulates most of the logic from 
PageRow
  (minus the instantiation of components from paths which stays in PageRow)
  with that, new features are possible, such as having expanded pages which 
aren't the last one 
  or inserting/removing arbitrary pages, to make it behave not like a stack.
  This solves also some glitches as ListView is quite buggy.

TEST PLAN
  tested with Kirigmai Gallery and some other apps such as the new PureMaps 
which needs some of 
  the new features.
  By normal usage, no visual change should occur.

REPOSITORY
  R169 Kirigami

BRANCH
  mart/columnsView

REVISION DETAIL
  https://phabricator.kde.org/D19203

AFFECTED FILES
  src/CMakeLists.txt
  src/columnview.cpp
  src/columnview.h
  src/columnview_p.h
  src/controls/Page.qml
  src/controls/PageRow.qml
  src/controls/private/ActionButton.qml
  src/kirigamiplugin.cpp

To: mart, #kirigami
Cc: plasma-devel, dkardarakos, apol, davidedmundson, mart, hein

D19044: [InlineMessage] Do not draw shadows around the message

2019-02-21 Thread Marco Martin 
mart added a comment.


  - whole InlineMessage should be moved into templates
  - background: item should be deleted such that it doesn't have any background 
at all (lines from 123 to 173)
  - in controls, an InlineMessage.qml is still present, and will be
  
  import "templates" as T
  T.InlineMessage {
  
background: the original background item
  
  }
  
  that one won't have a shadow, in styles/Material another similar one, but 
with the original shadow

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D19044

To: filipf, #vdg, #kirigami, ngraham, mart
Cc: rooty, ndavis, mart, abetts, plasma-devel, dkardarakos, apol, 
davidedmundson, hein

D19179: Use PointingHand when hovering links in Label

2019-02-21 Thread Marco Martin 
mart accepted this revision.
mart added a comment.
This revision is now accepted and ready to land.


  actually the hoverhandler seems not to be adapt for the job, so go for it

REPOSITORY
  R858 Qt Quick Controls 2: Desktop Style

REVISION DETAIL
  https://phabricator.kde.org/D19179

To: leinir, ngraham, apol, mart, #kirigami
Cc: filipf, plasma-devel, jraleigh, GB_2, ragreen, Pitel, dkardarakos, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, davidedmundson, 
mart, hein

D19179: Use PointingHand when hovering links in Label

2019-02-20 Thread Marco Martin 
mart added a comment.


  that's the thing in question
  https://doc.qt.io/qt-5/qml-qtquick-hoverhandler.html

REPOSITORY
  R858 Qt Quick Controls 2: Desktop Style

REVISION DETAIL
  https://phabricator.kde.org/D19179

To: leinir, ngraham, apol, mart, #kirigami
Cc: filipf, plasma-devel, jraleigh, GB_2, ragreen, Pitel, dkardarakos, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, davidedmundson, 
mart, hein

D19179: Use PointingHand when hovering links in Label

2019-02-20 Thread Marco Martin 
mart added a comment.


  ideally, this should use pointer handlers (which sadly they are 5.12 only) it 
may use preprocessing how we sometimes did for menus for instance

REPOSITORY
  R858 Qt Quick Controls 2: Desktop Style

REVISION DETAIL
  https://phabricator.kde.org/D19179

To: leinir, ngraham, apol, mart, #kirigami
Cc: filipf, plasma-devel, jraleigh, GB_2, ragreen, Pitel, dkardarakos, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, davidedmundson, 
mart, hein

D19179: Use PointingHand when hovering links in Label

2019-02-20 Thread Marco Martin 
mart added a comment.


  I'm very hesitant to add a MouseArea in evert single Label

REPOSITORY
  R858 Qt Quick Controls 2: Desktop Style

REVISION DETAIL
  https://phabricator.kde.org/D19179

To: leinir, ngraham, apol, mart, #kirigami
Cc: filipf, plasma-devel, jraleigh, GB_2, ragreen, Pitel, dkardarakos, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, davidedmundson, 
mart, hein

D19044: [InlineMessage] Do not draw shadows around the message

2019-02-19 Thread Marco Martin 
mart added a comment.


  In D19044#414530 , @ngraham wrote:
  
  > In D19044#414479 , @mart wrote:
  >
  > > -1
  > >  this has to be done at most for the desktop style and the desktop style 
only
  >
  >
  > Can you explain a bit more? I don't understand the technical reason for why 
you think we should do this in the QQC2 style only. If anything, wouldn't it 
make sense to not have the shadow here and only add it in the QQC2 style if we 
did want it there (which we don't)?
  
  
  nope, not in the qqc2 style, but in the kirigami style (yes, kirigami has 
styles, which must have the same name as the corresponding qqc2 styles)
  
  I would like to maintain the shadow at least with material.
  this means splitting inlinemessage in a copy in templates/ and a copy in 
controls/ which just instantiates the one in templates and implements its 
background item.
  
  then in styles/ the desktop one will have a different background with no 
shadow (or the base version may have a shadow then there would be a copy in 
material which it would, don't care)

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D19044

To: filipf, #vdg, #kirigami, ngraham, mart
Cc: ndavis, mart, abetts, plasma-devel, dkardarakos, apol, davidedmundson, hein

D18938: Show assigned shortcut in drawer action delegates

2019-02-18 Thread Marco Martin 
mart requested changes to this revision.
mart added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> GlobalDrawerActionItem.qml:102
> +Layout.alignment: Qt.AlignVCenter | Qt.AlignRight
> +visible: modelData.__shortcut.enabled && !Settings.tabletMode
> +color: Theme.disabledTextColor

adding also && root.modal should fix the discover and other 
always-showing-sidebar apps use case.

Pretty sure the label will break on collapsed mode.
did you try on kirigami gallery to set the sidebar to collapsible with this 
patch on?

should probably be

visible: modelData.__shortcut.enabled && !Settings.tabletMode && root.modal && 
!root.collapsible

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D18938

To: hein, mart, apol
Cc: ngraham, plasma-devel, #plasma, dkardarakos, apol, davidedmundson, mart, 
hein

D19044: [InlineMessage] Do not draw shadows around the message

2019-02-18 Thread Marco Martin 
mart requested changes to this revision.
mart added a comment.
This revision now requires changes to proceed.


  -1
  this has to be done at most for the desktop style and the desktop style only

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D19044

To: filipf, #vdg, #kirigami, ngraham, mart
Cc: mart, abetts, plasma-devel, dkardarakos, apol, davidedmundson, hein

Re: Breeze Dark theme question ?

2019-02-18 Thread Marco Martin 
On lunedì 18 febbraio 2019 08:57:55 CET Kai Uwe Broulik wrote:
> Hi,
> 
> I assume you're refering to the blue line when expanding an applet. That
> one is only shown if it comes from the current theme to avoid issues
> when using older Plasma 4 themes that don't expect this item to be used
> in said context. It seems Breeze Dark just inherits the SVG from Breeze
> and as such it is not "fromCurrentTheme" and not displayed.

right, so since breeze dark/light is just a color scheme, fromCurrentTheme 
will always be false.. maybe they should have a copy of that image


-- 
Marco Martin

Notes for 18/2/2019 monday meeting

2019-02-18 Thread Marco Martin 
David:
* working on replacing libkworkspace
* There's a branch davidedmundson/kworkspace2 which I'll update in a bit, 
everything is sooo much tidier. 
* documented my plans on phabricator under that ksmserver splitting task 
https://phabricator.kde.org/T9779
* fixed a regression in ksmserver

Kai Uwe:
* Diff 18646 "[Colors KCM] Add search and filter" [Needs Review] https://
phabricator.kde.org/D18646

Marco:
Kirigami:
* support for alternating stripey listitem backgrounds, useful for multi 
column lists
* continue to work on the pagerow partial c++ rewrite
* experimenting with some new heuristics to determine which icons are 
monochrome since is a big sore point atm especially when the desktop style is 
not used (eg Android), I fear it will be necessary to iterate over pixel 
colors in software
* fixed some qml warnings on stderr

qqc2-desktop-style
* ScrollBar now behaves like qwidgets on mouse click: left button click does 
pgup/pgdown, middle button does absolute positioning

KWin:
* experiments to modify D18818 approach to how martin said, seems super tricky
-- 
Marco Martin

D18716: Add a TextField component

2019-02-14 Thread Marco Martin 
mart added inline comments.

INLINE COMMENTS

> mart wrote in TextField.qml:106
> text will go under both buttons, in order to avoid that, probably anchors 
> should be added to the TextField's contentItem to make space for the buttons.

err, TextField is not a Control, right.

so, it should set leftPadding and rightPadding to the space of the buttons

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D18716

To: ognarb, apol, #kirigami, ngraham, mart
Cc: broulik, mart, apol, ngraham, plasma-devel, dkardarakos, davidedmundson, 
hein

D18716: Add a TextField component

2019-02-14 Thread Marco Martin 
mart added a comment.


  also, the name should possibily not conflict with QQC2 TextField, like 
ActionTextField or something like that.

INLINE COMMENTS

> TextField.qml:21
> +import QtQuick 2.5
> +import QtQuick.Controls 2.1
> +import org.kde.kirigami 2.4 as Kirigami

always namespace the controls import as
import QtQuick.Controls 2.1 as Controls

> TextField.qml:89
> +ToolTip {
> +delay: Kirigami.Units.longDuration
> +visible: root.focusSequence != null && root.focusSequence.hovered

the style already sets the correct values for duration and timeout, this line 
should be removed

> TextField.qml:106
> +
> +ToolButton {
> +anchors {

text will go under both buttons, in order to avoid that, probably anchors 
should be added to the TextField's contentItem to make space for the buttons.

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D18716

To: ognarb, apol, #kirigami, ngraham, mart
Cc: broulik, mart, apol, ngraham, plasma-devel, dkardarakos, davidedmundson, 
hein

D18645: BasicListItem: use specified tint color when transparency is 0

2019-02-14 Thread Marco Martin 
mart added a comment.


  I think i'll introduce an heuristic to analyze the image and decide if it's  
monochrome and drop all this transparent nonsense (would make it a bit 
inefficient as it wuld need to read pixels colors in software but may be 
justified).
  locally i was trying with Shannon entropy of the distribution of either 
colors or gray values, which seems to yeld satisfying results

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D18645

To: pwegner, #kirigami, mart
Cc: plasma-devel, dkardarakos, apol, davidedmundson, mart, hein

Moday meeting notes for 11/2/2019

2019-02-11 Thread Marco Martin 
Eike:
* I've been consumed by eV stuff and to be honest a side project (new app to 
control UAVs)
started three things still to be finished:
* adding Folder-based places widget to Add Widgets, needs some work in the 
framework and a few .desktop files
* making the screenlocker prompt immediately when waking up from suspend
* toying with showing action shortcuts in action delegates in kirigami drawers 
when a keyboard is around
* finding Kirigami bugs while hacking on my app and sending them to Marco or 
patching things I guess

Roman:
* Pushed my Xwl Dnd patches to KWayland. KWin patches hopefully follow this 
week.
 Was at Plasma Mobile sprint last week. Many highly motivated and skilled 
people attanded. Also it was nice to see Dorota and Tobias from Purism attand. 
I think we should foster these relations to get more people working on design 
and technology of Plasma Mobile in the future. There would definitely be some 
momentum ready to push forward Plasma Mobile.
* To enable this I think we need to work a bit more on the basics. We 
currently don't have a well-defined mechanism for convergence in KWin (we use 
static config files and scripts on Plasma Mobile to force KWin into a mobile-
like interface). For that I propose a more integrated solution in KWin. 
Dorota, Marco and I discussed this at the sprint and we thought about a 
protocol to inform clients about the current preferred usage mode: 
* https://phabricator.kde.org/T10462 Please feel free to state your opinion on 
that.

Kai Uwe:
- Fixed bugs in ffmpegthumbnailer
- Added thumbnailer for eBooks
-- Please review D18883 for a new PDF thumbnailer using libpoppler
Diff 18883 "Add PDF thumbnailer" [Needs Review] https://phabricator.kde.org/
D18883
- Minor improvements here and there
Work todo:
- Found an optimization I could to do Icon plasmoid
- Try out how Chrome 73's built-in media keys affect or break p-b-i
- Can we go with D18646 now?
  Diff 18646 "[Colors KCM] Add search and filter" [Needs Review] https://
phabricator.kde.org/D18646

Marco:
Plasma Mobile:
* plamo sprint
* actually very awesome and vibrant: it was full of young newcomers
* cleaned out plasma mobile top panel code
* new applet popup code taken from minishell
KWin:
* resizing the focused window when keyboard is open D18818
Kirigami
* talked with people doing Kirigami apps (itinerari, kaidan, kdeconnect 
kirigami version) and fixed many issues they had
* merged the big titledelegate branch
* hide swipelistitem handles when all actions are invisible
* fixed some icon coloring issues
* always show the back button on layers, also on mobile
* navigation buttons don't disappear anymore when the window is too large

-- 
Marco Martin

D18571: Add "apply on double-click" feature to most other recent ported KCMs

2019-02-11 Thread Marco Martin 
mart added a comment.


  also, as the principle of the feature i agree with Pino
  I don't recall any non instant apply dialog anywhere which becomes magically 
instant apply on doubleclick

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D18571

To: ngraham, #vdg, #plasma, broulik, ndavis, mart
Cc: mart, pino, davidedmundson, ndavis, plasma-devel, jraleigh, GB_2, ragreen, 
Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D18571: Add "apply on double-click" feature to most other recent ported KCMs

2019-02-11 Thread Marco Martin 
mart requested changes to this revision.
mart added a comment.
This revision now requires changes to proceed.


  if this is going to be used, it should be in the base component (where you 
can safely assume that kcm.save will exist) and have it as mandatory for every 
kcm

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D18571

To: ngraham, #vdg, #plasma, broulik, ndavis, mart
Cc: mart, pino, davidedmundson, ndavis, plasma-devel, jraleigh, GB_2, ragreen, 
Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D18645: BasicListItem: use specified tint color when transparency is 0

2019-02-09 Thread Marco Martin 
mart added a comment.


  can you try on kirigami master? i did a similar thing the other day with 
commit 015e1d0ac19e4 


REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D18645

To: pwegner, #kirigami, mart
Cc: plasma-devel, dkardarakos, apol, davidedmundson, mart, hein

D18716: Add a TextField component

2019-02-09 Thread Marco Martin 
mart requested changes to this revision.
mart added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> TextField.qml:74
> + */
> +property QtObject rightAction
> +

I would like those to actually be lists as we do have use cases for more than 
one icon
F6603228: Screenshot_20190209_110517.png 

> TextField.qml:94
> +
> +ToolButton {
> +anchors {

this should be a repeater with the toolbutton as aproperty (maybe shouldn't 
even be a toolbotton, as usually they're just icons without any button graphics)

> ognarb wrote in TextField.qml:101
> @mart I'm not sure if it's the right way to convert the icon from the action 
> to the one needed by the toolButton (don't support icon.source)

you can try to use a private class.
PrivateActionToolButton {
 kirigamiAction: the action
 background: null
}
that should already manage everything about the action (and with 
background:null to disable any kind of button background

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D18716

To: ognarb, apol, #kirigami, ngraham, mart
Cc: broulik, mart, apol, ngraham, plasma-devel, dkardarakos, davidedmundson, 
hein

D18796: [PassiveNotification] Don't start timer until window has focus

2019-02-09 Thread Marco Martin 
mart requested changes to this revision.
mart added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> PassiveNotification.qml:65
> +//be working with multiple windows at once
> +timer.running = Qt.binding(function() {
> +return root.Window.active;

this will probably mke the timer always running when the window has focus 
whether or not there is a notificationshown or not?
something like:

Connections {
target:root.Window
onActiveChanged: {
if(root.opacity == 1) {
timer.restart();
}
}
}

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D18796

To: ngraham, #kirigami, mart, broulik, apol
Cc: plasma-devel, broulik, dkardarakos, apol, davidedmundson, mart, hein

D18640: Reset tooltip delegate label height to defaults

2019-02-09 Thread Marco Martin 
mart added a comment.


  In D18640#403147 , @broulik wrote:
  
  > Supposedly fixed in Qt 5.12.1? https://bugreports.qt.io/browse/QTBUG-71684
  
  
  with 5.12.1 the patch woudn't be necessary anymore?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D18640

To: broulik, #plasma, #vdg
Cc: mart, ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D18640: Reset tooltip delegate label height to defaults

2019-02-09 Thread Marco Martin 
mart added inline comments.

INLINE COMMENTS

> ngraham wrote in main.qml:227
> If we do end up going with this patch, I'd like to see comments explaining 
> why these are set to `undefined`.

look at https://doc.qt.io/qt-5/properties.html
at the RESET function (basically, properties that provide it, setting to 
undefined will reset to a default)

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D18640

To: broulik, #plasma, #vdg
Cc: mart, ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D18801: CMakeLists: Fix bfd.h include path on windows

2019-02-09 Thread Marco Martin 
mart added a comment.


  needs longer commit message

REPOSITORY
  R871 DrKonqi

REVISION DETAIL
  https://phabricator.kde.org/D18801

To: patrickelectric, davidedmundson, tcanabrava, ngraham
Cc: mart, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol

D18802: Fix pragma once problem with process class

2019-02-09 Thread Marco Martin 
mart added a comment.


  needs better commit message

REPOSITORY
  R871 DrKonqi

REVISION DETAIL
  https://phabricator.kde.org/D18802

To: patrickelectric, davidedmundson, tcanabrava, ngraham
Cc: mart, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol

D18716: Add a SearchField component

2019-02-06 Thread Marco Martin 
mart added a comment.


  In D18716#404852 , @ognarb wrote:
  
  > Interesting, but I have some question before I start implementing.
  >
  > - Do you have an example for a left action?
  
  
  right now only web browsers url bars come to mind, so perhaps not important 
yet to add, (just to be tought of so can be added in the future should the need 
arise)
  
  > - Should the buttons only be visible when the text is not empty? Or can 
this behavior also be configurable with a property?
  
  should be configurable i think: a clear action should only be visible when 
there is text, instead a filter icons, or the show password action should 
probably be always there.

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D18716

To: ognarb, apol, #kirigami, ngraham, mart
Cc: broulik, mart, apol, ngraham, plasma-devel, dkardarakos, davidedmundson, 
hein

Re: Monday meeting minutes for 2019-02-04 (week 6)

2019-02-06 Thread Marco Martin 
On Mon, Feb 4, 2019 at 2:25 PM Eike Hein  wrote:
>
>
> Of special note: We decided on doing another 5.14.x release to round up
> Folder View and Discover fixes, to aid Debian Stable which will ship
> 5.14.x. This will happen pending th completion of some Discover work for
> the branch.
on my side:
* continued the custom toolbar work, turns out very not trivial D18619
* continued work on c++ pagerow partial rewrite
* this week at the plasma mobile sprint

--
Marco Martin

Re: Plasma and Qt5.12

2019-02-06 Thread Marco Martin 
On Tue, Feb 5, 2019 at 12:47 PM David Edmundson
 wrote:
>
> We've agreed that we want Plasma5.16 to depend on Qt5.12.
>
> Are there any objections to switching master to depend on this?

none on my side, go go go :)
--
Marco Martin

D18779: Better window title display

2019-02-06 Thread Marco Martin 
mart added a comment.


  +1

REPOSITORY
  R111 KSysguard Library

REVISION DETAIL
  https://phabricator.kde.org/D18779

To: broulik, #plasma, #vdg
Cc: mart, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol

D18716: Add a SearchField component

2019-02-03 Thread Marco Martin 
mart requested changes to this revision.
mart added a comment.
This revision now requires changes to proceed.


  If we are going to have a specialized line edit, I think it shouldn't be 
specific for search, but be a common component of things that we have to 
boilerplate too often as they are missing from qqc2.
  Namely, the clear button.
  What I would like is a lineedit with two list properties leftactions and 
rightactions, which the clear button can be one of them (we have some fields 
around in plasma which have more than one action)
  
  And then after that, maybe doing the specialization which is purely a search 
field

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D18716

To: ognarb, apol, #kirigami, ngraham, mart
Cc: mart, apol, ngraham, plasma-devel, dkardarakos, davidedmundson, hein

D18619: property to override the globaltoolbar style of a single page

2019-01-30 Thread Marco Martin 
mart added a comment.


  F6576894: Screenshot_20190130_171634.png 


REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D18619

To: mart, #kirigami, #vdg
Cc: plasma-devel, dkardarakos, apol, davidedmundson, mart, hein

D18619: property to override the globaltoolbar style of a single page

2019-01-30 Thread Marco Martin 
mart added a comment.


  F6576892: Screenshot_20190130_171551.png 


REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D18619

To: mart, #kirigami, #vdg
Cc: plasma-devel, dkardarakos, apol, davidedmundson, mart, hein

D18619: property to override the globaltoolbar style of a single page

2019-01-30 Thread Marco Martin 
mart added a comment.


  F6576890: vokoscreen-2019-01-30_17-08-42.mp4 


REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D18619

To: mart, #kirigami, #vdg
Cc: plasma-devel, dkardarakos, apol, davidedmundson, mart, hein

D18619: property to override the globaltoolbar style of a single page

2019-01-30 Thread Marco Martin 
mart created this revision.
mart added reviewers: Kirigami, VDG.
Herald added a project: Kirigami.
Herald added a subscriber: plasma-devel.
mart requested review of this revision.

REVISION SUMMARY
  add a property in page to override the globaltoolbar style, to either force a 
top
  toolbar on a single page on mobile, or have one single page without any 
toolbar, while keeping 
  it on the others
  
  Also add an optional component proeprty to customize page titles in toolbar 
and titles
  mode
  
  the two features are completely intertwined, so they must come together

TEST PLAN
  added a combobox to try that on kirigami gallery

REPOSITORY
  R169 Kirigami

BRANCH
  mart/titleDelegate

REVISION DETAIL
  https://phabricator.kde.org/D18619

AFFECTED FILES
  src/controls/ContextDrawer.qml
  src/controls/Heading.qml
  src/controls/OverlayDrawer.qml
  src/controls/Page.qml
  src/controls/PageRow.qml
  src/controls/private/globaltoolbar/PageRowGlobalToolBarUI.qml
  src/controls/private/globaltoolbar/TitlesPageHeader.qml
  src/controls/private/globaltoolbar/ToolBarPageHeader.qml
  src/controls/templates/OverlayDrawer.qml

To: mart, #kirigami, #vdg
Cc: plasma-devel, dkardarakos, apol, davidedmundson, mart, hein

D18588: Configuration to never show the passwors dialog

2019-01-29 Thread Marco Martin 
This revision was automatically updated to reflect the committed changes.
Closed by commit R116:1d7841399924: Configuration to never show the passwors 
dialog (authored by mart).

REPOSITORY
  R116 Plasma Network Management Applet

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18588?vs=50468=50469

REVISION DETAIL
  https://phabricator.kde.org/D18588

AFFECTED FILES
  kded/secretagent.cpp
  libs/configuration.cpp
  libs/configuration.h

To: mart, #plasma, jgrulich
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18588: Configuration to never show the passwors dialog

2019-01-29 Thread Marco Martin 
mart updated this revision to Diff 50468.
mart added a comment.


  - return true

REPOSITORY
  R116 Plasma Network Management Applet

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18588?vs=50466=50468

BRANCH
  arcpatch-D18588

REVISION DETAIL
  https://phabricator.kde.org/D18588

AFFECTED FILES
  kded/secretagent.cpp
  libs/configuration.cpp
  libs/configuration.h

To: mart, #plasma, jgrulich
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18588: Configuration to never show the passwors dialog

2019-01-29 Thread Marco Martin 
mart created this revision.
mart added reviewers: Plasma, jgrulich.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
mart requested review of this revision.

REVISION SUMMARY
  on Plasma mobile, not qwidget dialogs should be ever shown at any time.
  the networkmanager KCM includes its own password field, so the password 
dialog can be safely
  be never shown

TEST PLAN
  fails silently

REPOSITORY
  R116 Plasma Network Management Applet

BRANCH
  phab/passwordDialog

REVISION DETAIL
  https://phabricator.kde.org/D18588

AFFECTED FILES
  kded/secretagent.cpp
  libs/configuration.cpp
  libs/configuration.h

To: mart, #plasma, jgrulich
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

Re: freedesktop.notifications daemon - crossplatform alternatives?

2019-01-22 Thread Marco Martin 
On giovedì 17 gennaio 2019 16:58:21 CET René J.V. Bertin wrote:
> Why the cross-platform interest? Much KF5 software uses freedestop

That's why KNotify has backends.

-- 
Marco Martin

D18321: support for the concept of expandible items

2019-01-21 Thread Marco Martin 
This revision was not accepted when it landed; it landed in state "Needs 
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit R169:2e7602f3fa5f: support for the concept of expandible items 
(authored by mart).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D18321?vs=49721=49998#toc

REPOSITORY
  R169 Kirigami

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18321?vs=49721=49998

REVISION DETAIL
  https://phabricator.kde.org/D18321

AFFECTED FILES
  kirigami.qrc
  kirigami.qrc.in
  src/controls/Action.qml
  src/controls/BasicListItem.qml
  src/controls/ContextDrawer.qml
  src/controls/GlobalDrawer.qml
  src/controls/private/ContextDrawerActionItem.qml
  src/controls/private/GlobalDrawerActionItem.qml
  src/controls/templates/OverlayDrawer.qml

To: mart, #kirigami
Cc: alex-l, plasma-devel, dkardarakos, apol, davidedmundson, mart, hein

D18321: support for the concept of expandible items

2019-01-17 Thread Marco Martin 
mart added a comment.


  the Global Drawer Mode section is expanded
  F6553308: Screenshot_20190117_150513.png 


REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D18321

To: mart, #kirigami
Cc: plasma-devel, dkardarakos, apol, davidedmundson, mart, hein

D18321: support for the concept of expandible items

2019-01-17 Thread Marco Martin 
mart created this revision.
mart added a reviewer: Kirigami.
Herald added a project: Kirigami.
Herald added a subscriber: plasma-devel.
mart requested review of this revision.

REVISION SUMMARY
  if an Action has the property expandible, its subactions are shown under it 
in globalDrawer 
  and ContextDrawer
  those actions will disappear when the globaldrawer is collapsed.
  useful to have a more hyerarchical looking sidebars

TEST PLAN
  using it in the gallery and in Koko

REPOSITORY
  R169 Kirigami

BRANCH
  mart/expandibleItems

REVISION DETAIL
  https://phabricator.kde.org/D18321

AFFECTED FILES
  kirigami.qrc
  kirigami.qrc.in
  src/controls/Action.qml
  src/controls/BasicListItem.qml
  src/controls/ContextDrawer.qml
  src/controls/GlobalDrawer.qml
  src/controls/private/ContextDrawerActionItem.qml
  src/controls/private/GlobalDrawerActionItem.qml
  src/controls/templates/OverlayDrawer.qml

To: mart, #kirigami
Cc: plasma-devel, dkardarakos, apol, davidedmundson, mart, hein

D18260: fix logic of lnf loading

2019-01-15 Thread Marco Martin 
This revision was automatically updated to reflect the committed changes.
Closed by commit R135:2682db8af734: fix logic of lnf loading (authored by mart).

REPOSITORY
  R135 Integration for Qt applications in Plasma

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18260?vs=49515=49521

REVISION DETAIL
  https://phabricator.kde.org/D18260

AFFECTED FILES
  src/platformtheme/khintssettings.cpp

To: mart, #plasma, davidedmundson
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18260: fix logic of lnf loading

2019-01-15 Thread Marco Martin 
mart created this revision.
mart added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
mart requested review of this revision.

REVISION SUMMARY
  mDefaultLnfConfig must be breeze, and mLnfConfig should be the
  configured one, rather the other way around

TEST PLAN
  plasma seems to start with proper icons now

REPOSITORY
  R135 Integration for Qt applications in Plasma

BRANCH
  phab/fixlogic

REVISION DETAIL
  https://phabricator.kde.org/D18260

AFFECTED FILES
  src/platformtheme/khintssettings.cpp

To: mart, #plasma
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18239: login screen with same behavior as lockscreen

2019-01-14 Thread Marco Martin 
mart created this revision.
mart added reviewers: Plasma, VDG.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
mart requested review of this revision.

REVISION SUMMARY
  start with wallpaper only mode by default, blur background at first
  input

TEST PLAN
  works as before, just starts in wallaper mode which before was triggered 
after waiting for 60 
  seconds

REPOSITORY
  R120 Plasma Workspace

BRANCH
  phab/invertlogin

REVISION DETAIL
  https://phabricator.kde.org/D18239

AFFECTED FILES
  sddm-theme/Main.qml
  sddm-theme/dummydata/config.qml

To: mart, #plasma, #vdg
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18186: set skipTaskbar on SurfaceEvent::SurfaceCreated

2019-01-11 Thread Marco Martin 
This revision was automatically updated to reflect the committed changes.
Closed by commit R120:cc8d3e775185: set skipTaskbar on 
SurfaceEvent::SurfaceCreated (authored by mart).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18186?vs=49249=49250

REVISION DETAIL
  https://phabricator.kde.org/D18186

AFFECTED FILES
  shell/panelconfigview.cpp
  shell/panelview.cpp

To: mart, #plasma, hein, broulik
Cc: plasma-devel, kvanton, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18186: set skipTaskbar on SurfaceEvent::SurfaceCreated

2019-01-11 Thread Marco Martin 
mart updated this revision to Diff 49249.
mart added a comment.


  - don't set in the caller

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18186?vs=49248=49249

BRANCH
  phab/skip

REVISION DETAIL
  https://phabricator.kde.org/D18186

AFFECTED FILES
  shell/panelconfigview.cpp
  shell/panelview.cpp

To: mart, #plasma, hein
Cc: plasma-devel, kvanton, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18186: set skipTaskbar on SurfaceEvent::SurfaceCreated

2019-01-11 Thread Marco Martin 
mart created this revision.
mart added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
mart requested review of this revision.

REVISION SUMMARY
  makes sure the flag is set on time

TEST PLAN
  can't get the panelcontroller in the taskbar anymore

REPOSITORY
  R120 Plasma Workspace

BRANCH
  phab/skip

REVISION DETAIL
  https://phabricator.kde.org/D18186

AFFECTED FILES
  shell/panelconfigview.cpp

To: mart, #plasma
Cc: plasma-devel, kvanton, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18180: Fix layout issues in the AboutPage personDelegate component

2019-01-11 Thread Marco Martin 
mart requested changes to this revision.
mart added a comment.
This revision now requires changes to proceed.


  the bug is legit..
  however i think it should be tried harder to avoid manual layouting, there 
must be a legit problem somewhere that this is triggering, i would like more 
investigation on it

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D18180

To: leinir, #kirigami, mart
Cc: mart, plasma-devel, dkardarakos, apol, davidedmundson, hein

D17906: [kirigami] Do not use light font styles for headings (2/3)

2019-01-10 Thread Marco Martin 
mart added a comment.


  so, if this is pushed, the same thing should happen at the same time to the 
corresponding plasma components

REPOSITORY
  R169 Kirigami

BRANCH
  no-light-headings (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D17906

To: filipf, ngraham, #plasma, #vdg, #frameworks, mart
Cc: fabianr, rooty, #frameworks, ngraham, #plasma, #vdg, abetts, mart, 
plasma-devel, dkardarakos, apol, davidedmundson, hein

D18006: Include only the largest size for the "Next" wallpaper

2019-01-09 Thread Marco Martin 
mart requested changes to this revision.
mart added a comment.
This revision now requires changes to proceed.


  has runtime memory been taken into account? (better with massif than with the 
unreliable top/ksysguard)
  runtime memory usage should be taken into account as well, loading a big 
image just to use a little, is still very expensive never the less

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D18006

To: ngraham, #vdg, #breeze, mart
Cc: mart, filipf, kvermette, plasma-devel, kvanton, jraleigh, GB_2, ragreen, 
Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D17906: [kirigami] Do not use light font styles for headings (2/3)

2019-01-09 Thread Marco Martin 
mart accepted this revision.
mart added a comment.


  bah, seems very tricky to make it work properly across distributions.
  
  to me, it speaks mostly as a failure for us to control the look of our 
product, due to broken fonts in distros and qt font rendering still buggy, 
issue that unfortunately the vertical platforms like Windows don't have.
  the intention was to have heading with the same stroke width as the rest of 
the text, or slightly more still (which works on noto at least for level 1, 
apparently not on other styles)
  
  so i'm ok to remove the light font here, but clearly as a failure to make it 
work properly due to the state of the lower stack
  
  to me, it *is* still a clear visual regression, but is ok to go as "the least 
broken" option for now to not touch weigth.
  with a clear intent to monitor the situation.
  
  I wonder if it shouldn't be something in the future eventually part of the 
theme, I see things like menu font and toolbar font in fonts kcm as something 
completely obsolete, while those settings should be more about conventional 
typography (like normal font, heading font etc)

REPOSITORY
  R169 Kirigami

BRANCH
  no-light-headings (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D17906

To: filipf, ngraham, #plasma, #vdg, #frameworks, mart
Cc: fabianr, rooty, #frameworks, ngraham, #plasma, #vdg, abetts, mart, 
plasma-devel, dkardarakos, apol, davidedmundson, hein

D17906: [kirigami] Do not use light font styles for headings (2/3)

2019-01-09 Thread Marco Martin 
mart added a comment.


  In D17906#388803 , @ngraham wrote:
  
  > F6531451: Screenshot_20190107_145258.png 

  >  In this one, the fact that it's a header is connoted by its much larger 
font size and wider character width and spacing. It feels "bigger" in every way 
than the text beneath it. It looks good.
  >
  > F6531453: Screenshot_20190107_145312.png 

  >
  > This photo is quite different. Here the header text is no larger or barely 
larger than the text beneath it, and its line weight is lighter. Also, it's 
very visually disconnected from the thing it's a header for, since it's stuck 
up in the top-right corner of a visually superfluous stock photo. Nothing about 
the header text tells my eye "I'm a header!"
  
  
  it's exactly 180% the notmal font. It was bigger, I was told to shrink it

REPOSITORY
  R169 Kirigami

BRANCH
  no-light-headings (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D17906

To: filipf, ngraham, #plasma, #vdg, #frameworks
Cc: rooty, #frameworks, ngraham, #plasma, #vdg, abetts, mart, plasma-devel, 
dkardarakos, apol, davidedmundson, hein

D17906: [kirigami] Do not use light font styles for headings (2/3)

2019-01-09 Thread Marco Martin 
mart added a comment.


  In D17906#388294 , @filipf wrote:
  
  > Updating an another computer to Frameworks 5.53 and Qt 5.12 I get the same 
problem.
  >
  > F6531867: image.png 
  >
  > F6531893: image.png 
  >
  > For me this represented a massive regression, and there's bound to be more 
people in a similar situation. We can't have this happening.
  
  
  uuh, that's the wrong color.. that's seriously weird?
  that's on same version how i get notifications on a dark color scheme
  
  F6537172: Screenshot_20190109_104727.png 


REPOSITORY
  R169 Kirigami

BRANCH
  no-light-headings (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D17906

To: filipf, ngraham, #plasma, #vdg, #frameworks
Cc: rooty, #frameworks, ngraham, #plasma, #vdg, abetts, mart, plasma-devel, 
dkardarakos, apol, davidedmundson, hein

D18018: [Digital Clock] Add ability to change first day of week

2019-01-08 Thread Marco Martin 
mart added a comment.


  -1 on this in particular
  +1 for having it system wide

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D18018

To: Zren, #plasma
Cc: mart, abetts, pino, davidedmundson, ngraham, plasma-devel, kvanton, 
jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, sebas, apol

D18019: [Digital Clock] Add ability to set a custom date format string

2019-01-08 Thread Marco Martin 
mart added a comment.


  is this the right place for it? (a text field to enter the "magic" date 
format letters is a very geeky ui, and i would prefer to not go there) 
shouldn't be a generic localization/date format setting? (and with also a 
graphical ui to generate this)

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D18019

To: Zren, #plasma, #vdg
Cc: mart, ndavis, rooty, plasma-devel, kvanton, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D18078: [plasma-workspace-wallpapers] Improve wallpaper selection

2019-01-08 Thread Marco Martin 
mart added a comment.


  +100
  (and we should push more on distros to have this installed by default, they 
often don't to save space on the iso :/

REPOSITORY
  R131 Plasma Wallpapers

REVISION DETAIL
  https://phabricator.kde.org/D18078

To: filipf, #plasma, #vdg, ngraham
Cc: mart, rooty, plasma-devel, kvanton, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

Re: Minutes meeting , week 2

2019-01-08 Thread Marco Martin 
On lunedì 7 gennaio 2019 13:46:56 CET Bhushan Shah wrote:
> Hello everyone!
> 
> This is first meeting of year 2019, happy new year!
> 

couldn't make to the meeting, so here's my part:
Kirigami
* better transitions between ApplicationWindow showgui and not
* don't show the drawer handle when it shouldn't
* GlobalDrawer can expand the first level of actions for a better "collapsed 
mode" experience, still wip
* worked a bit on Koko image viewer as a testbench for the features i've been 
working on in kirigami

KWin
* rows number in the kwayland virtual dekstoip protocol D17691
* new iteration of D17265

-- 
Marco Martin

D17751: Add shadow to Hour's hand

2019-01-07 Thread Marco Martin 
mart added a comment.


  In D17751#381215 , @davidedmundson 
wrote:
  
  > From the linked bug report (and your screenshot)
  >
  > > You're right about the typo, but it doesn't seem that trivial. The shadow 
shadow appears all offset (on the default breeze theme at least)
  >
  > The hour hand shadow starts several px below the hour hand
  
  
  so, the svg is fine, if one removes all anchors.margins the shadows graphics 
are all beneath the hands exactly.
  so can it be tried to just adjust those anchors margins to a small enough 
value?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D17751

To: shubham, mart, hein, #vdg, ngraham
Cc: ndavis, abetts, ngraham, davidedmundson, plasma-devel, kvanton, jraleigh, 
GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, 
apol, mart

D17752: Remove full representation of analog clock

2019-01-07 Thread Marco Martin 
mart added a comment.


  In D17752#388166 , @abetts wrote:
  
  > I think part of the reason why this seems too big also if because it 
doesn't do much more than tell you what day it is. If it was able to integrate 
with a calendar application, it could show appointments. Something like this:
  >
  > https://goo.gl/images/rwgUw9
  
  
  the popup of the digital clock does that, what's the actual problem is that 
the analog and digital clocks aren't on par with features

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D17752

To: shubham, hein, mart, #vdg
Cc: abetts, davidedmundson, plasma-devel, kvanton, jraleigh, GB_2, ragreen, 
Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D17752: Remove full representation of analog clock

2019-01-07 Thread Marco Martin 
mart added a comment.


  -1, digital and analog clocks have the same scope, and they should have the 
same behavior (if anything it should have the same features of the digital 
clock popup)

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D17752

To: shubham, hein, mart, #vdg
Cc: davidedmundson, plasma-devel, kvanton, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D17906: [kirigami] Do not use light font styles for headings (2/3)

2019-01-07 Thread Marco Martin 
mart added a comment.


  can we still keep as light the first level of heading, which is huge (and use 
that sparsingly) and go to levels from 2 onwards where needed smaller and 
bigger?

REPOSITORY
  R169 Kirigami

BRANCH
  no-light-headings (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D17906

To: filipf, ngraham, #plasma, #vdg, #frameworks
Cc: rooty, #frameworks, ngraham, #plasma, #vdg, abetts, mart, plasma-devel, 
dkardarakos, apol, davidedmundson, hein

D17906: [kirigami] Do not use light font styles for headings (2/3)

2019-01-07 Thread Marco Martin 
mart added a comment.


  in the end i *may* accept non light titles, even tough i still very much 
don't like the idea, but what i don't want to never, ever see in any 
circumstance is bold titles, anything of that will just be reverted.

REPOSITORY
  R169 Kirigami

BRANCH
  no-light-headings (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D17906

To: filipf, ngraham, #plasma, #vdg, #frameworks
Cc: rooty, #frameworks, ngraham, #plasma, #vdg, abetts, mart, plasma-devel, 
dkardarakos, apol, davidedmundson, hein

D17906: [kirigami] Do not use light font styles for headings (2/3)

2019-01-07 Thread Marco Martin 
mart added a comment.


  In D17906#385968 , @ngraham wrote:
  
  > - **Implementation inconsistency:** Many  fonts don't have a dedicated 
light style, many distros don't ship them if they do, and Qt < 5.12 doesn't use 
them even if
  
  
  nope, with the workaround used it works even with old versions

REPOSITORY
  R169 Kirigami

BRANCH
  no-light-headings (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D17906

To: filipf, ngraham, #plasma, #vdg, #frameworks
Cc: rooty, #frameworks, ngraham, #plasma, #vdg, abetts, mart, plasma-devel, 
dkardarakos, apol, davidedmundson, hein

D17906: [kirigami] Do not use light font styles for headings (2/3)

2019-01-07 Thread Marco Martin 
mart added a comment.


  In D17906#385857 , @filipf wrote:
  
  > With the exception of the case of the Windows Store (which does nonetheless 
manage to achieve some visual hierarchy with different font sizes and colors), 
others mostly actually have an opposite approach and go the bold/semi-bold 
route for the more prominent titles, which makes sense - you want to highlight 
the information contained in them. But the point of this patch is to just make 
sure the most important information is not made less important or even 
illegible, which is guaranteed if the labels are "regular" style.
  
  
  of all of those the one i prefer by a long shot is indeed windows store which 
actually looks exactly like our graphics,
  F6531451: Screenshot_20190107_145258.png 
 is not conceptually different from 
F6531453: Screenshot_20190107_145312.png  
in any way really.
  
  the reason that in many places the visual hierarchy has been broken, like in 
plasma tooltips or calendar, is because the title text has been changed to be 
stupidly small, but the fact that it has been ruined, is not a good excuse to 
ruin it even more.

REPOSITORY
  R169 Kirigami

BRANCH
  no-light-headings (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D17906

To: filipf, ngraham, #plasma, #vdg, #frameworks
Cc: rooty, #frameworks, ngraham, #plasma, #vdg, abetts, mart, plasma-devel, 
dkardarakos, apol, davidedmundson, hein

D17906: [kirigami] Do not use light font styles for headings (2/3)

2019-01-03 Thread Marco Martin 
mart added a comment.


  I'm very much against this, I think it looks very bad :/

REPOSITORY
  R169 Kirigami

BRANCH
  no-light-headings (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D17906

To: filipf, ngraham, #plasma, #vdg, #frameworks
Cc: mart, plasma-devel, dkardarakos, apol, davidedmundson, hein

D17592: Introduce a DelegateRecycler attached object

2018-12-17 Thread Marco Martin 
mart requested changes to this revision.
mart added a comment.
This revision now requires changes to proceed.


  recycler should have a notify signal, because it's going to change all the 
time.
  the delegaterecycler instances are created/destroyed all the time like normal 
listview delegates, and the delegates instances, those that are actually 
recycled, will be assigned a new recycler when actually recycled.
  since is saved anyways as a context property, perhaps is better to just base 
off that one and taking care that's always kept up to date to the new recycler.

INLINE COMMENTS

> delegaterecycler.cpp:256
> +ctx->setContextProperty(QStringLiteral("index"), 
> m_propertiesTracker->property("trackedIndex"));
> +ctx->setContextProperty(QStringLiteral("delegateRecycler"), this);
>  }

tracking this property directly from qml will woirk as is the correct recycler, 
on the other hand the attached property won't, so is probably better to just 
have this one

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D17592

To: apol, #kirigami, mart
Cc: plasma-devel, dkardarakos, apol, davidedmundson, mart, hein

D17393: [Folder View] make file context menu consistent with Dolphin's

2018-12-14 Thread Marco Martin 
mart added a comment.


  important is that "open with $default" and "open with..." are grouped 
together.
  apart from that i don't have much preferences for one or the other

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D17393

To: ngraham, #plasma, hein
Cc: mart, janpr, anthonyfieroni, plasma-devel, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D17556: Make Status and Notification popup consistent with others.

2018-12-13 Thread Marco Martin 
mart added a comment.


  for it to be perfect looking, i think it should either be aligned to the left 
of the icons, or to the left of the text items

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D17556

To: shubham, #vdg, broulik, #plasma, mart, hein
Cc: plasma-devel, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D17467: digital-clock: Show events on initial expansion for all time zones

2018-12-13 Thread Marco Martin 
mart added inline comments.

INLINE COMMENTS

> mbehrendt wrote in CalendarView.qml:60
> No, the model initially seems to be an empty list.

another way you can try is to do it on Component.onCompleted: {  }

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D17467

To: mbehrendt, #plasma, plasma-devel
Cc: mart, broulik, plasma-devel, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol

D17467: digital-clock: Show events on expanding applet

2018-12-11 Thread Marco Martin 
mart added inline comments.

INLINE COMMENTS

> CalendarView.qml:60
> +// would always be empty.
> +holidaysList.model = 
> monthView.daysModel.eventsForDate(monthView.currentDate);
> +hasExpanded = true;

instead of storing a local hasExpanded, could you just check for 
holidaysList.model not being null?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D17467

To: mbehrendt, #plasma, plasma-devel
Cc: mart, broulik, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol

D14542: [kcmkwin/desktop] KCM using new virtual desktops DBus interface

2018-12-06 Thread Marco Martin 
mart accepted this revision.
mart added a comment.


  I've just done a round of testing of the latest revision together my last 
kwin patch, including:
  
  - adding and/or removinf desktops
  - changing the number of rows
  - renaming some desktops
  - restarting kwin randomly after any of the above to see settings are kept, 
without restarting the kcm which keeps showing coherent data
  
  so, definitely lgtm (adding ship it as my personal one, still needs David's)

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D14542

To: hein, mart, davidedmundson, ltoscano, zzag
Cc: davidedmundson, broulik, plasma-devel, kwin, mkulinski, ragreen, 
jackyalcine, Pitel, iodelay, bwowk, ZrenBot, lesliezhai, ali-mohamed, 
hardening, jensreuterberg, abetts, sebas, apol, mart

D17333: Port digital clock settings to QQc2 and Kirigami

2018-12-03 Thread Marco Martin 
This revision was automatically updated to reflect the committed changes.
Closed by commit R120:39e812d57fd6: Port digital clock settings to QQc2 and 
Kirigami (authored by mart).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D17333?vs=46799=46803#toc

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17333?vs=46799=46803

REVISION DETAIL
  https://phabricator.kde.org/D17333

AFFECTED FILES
  applets/digital-clock/package/contents/ui/configAppearance.qml

To: mart, #plasma, #vdg, ngraham
Cc: ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D17333: Port digital clock settings to QQc2 and Kirigami

2018-12-03 Thread Marco Martin 
mart added a comment.


  F6453133: Screenshot_20181203_172322.png 


REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D17333

To: mart, #plasma, #vdg
Cc: ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D17333: Port digital clock settings to QQc2 and Kirigami

2018-12-03 Thread Marco Martin 
mart updated this revision to Diff 46799.
mart added a comment.


  restore Information: label

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17333?vs=46794=46799

BRANCH
  phab/qqc2time

REVISION DETAIL
  https://phabricator.kde.org/D17333

AFFECTED FILES
  applets/digital-clock/package/contents/ui/configAppearance.qml

To: mart, #plasma, #vdg
Cc: ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D17333: Port digital clock settings to QQc2 and Kirigami

2018-12-03 Thread Marco Martin 
mart added a comment.


  i can put information again in front of showdate, tough it conveys misleading 
and wrong info... i really, really hate this abuse of labels as 
not-really-sections as the label describes the control standing besides it, not 
any other
  
  (btw, chiming in as the historyc memory of the usability project, and how the 
formlayout initially came to be, in the beginning labels of all checkboxes were 
supposed to be flipped, so all of them on the left (and on the right only the 
checkbox, without any label)
  this was dropped because caused too many flame wars between developers (users 
were perfectly ok with it)

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D17333

To: mart, #plasma, #vdg
Cc: ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D17333: Port digital clock settings to QQc2 and Kirigami

2018-12-03 Thread Marco Martin 
mart added a comment.


  In D17333#370764 , @ngraham wrote:
  
  > Here are some examples (in production, from Dolphin's settings window) of 
how we integrate diverse controls into a form layout and preserve good 
alignment:
  
  
  well, in those the comboboxes are aligned with the checkbox and not the 
checkbox label, as it should be (and as i did)
  
  wrt the excessive spacing between checkbox and checkbox label is a qqc2 issue 
which i fixed

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D17333

To: mart, #plasma, #vdg
Cc: ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D17333: Port digital clock settings to QQc2 and Kirigami

2018-12-03 Thread Marco Martin 
mart added a comment.


  ah, like
  F6453054: Screenshot_20181203_165012.png 

  
  that can be done only with hacks that will spontaneously break i'm afraid

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D17333

To: mart, #plasma, #vdg
Cc: ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D17333: Port digital clock settings to QQc2 and Kirigami

2018-12-03 Thread Marco Martin 
mart added a comment.


  In D17333#370759 , @ngraham wrote:
  
  > The new one doesn't follow the HIG and has poor alignment. Combobox labels 
are supposed to be to the left of the comboboxes. And having a huge list of 
checkboxes not aligned to the rest of the controls doesn't look great. This is 
why we typically add a left label to the top checkbox to serve as a pseudo 
header for all of them. It's the only way to make the alignment work when you 
have both checkboxes and other controls in a form layout.
  
  
  hmm, that's as aligned as a formlayout (qml or qwidget) can do.
  where are supposed to be the combobox labels? can you mock up?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D17333

To: mart, #plasma, #vdg
Cc: ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D17333: Port digital clock settings to QQc2 and Kirigami

2018-12-03 Thread Marco Martin 
mart added a comment.


  left old, right new
  F6453040: Screenshot_20181203_164128.png 


REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D17333

To: mart, #plasma, #vdg
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D17333: Port digital clock settings to QQc2 and Kirigami

2018-12-03 Thread Marco Martin 
mart created this revision.
mart added reviewers: Plasma, VDG.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
mart requested review of this revision.

REVISION SUMMARY
  use QQC2 and FormLayout for alignment
  
  also, qqc2 combobox doesn't suffer from 390801 anymore
  
  BUG: 390801

TEST PLAN
  tried to set all the options

REPOSITORY
  R120 Plasma Workspace

BRANCH
  phab/qqc2time

REVISION DETAIL
  https://phabricator.kde.org/D17333

AFFECTED FILES
  applets/digital-clock/package/contents/ui/configAppearance.qml

To: mart, #plasma, #vdg
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

Monday meeting notes for 3/12/2018

2018-12-03 Thread Marco Martin 
Kai Uwe:
 Work done:
 - plasma-browser-integration fixes
 -- Now also exposes actual video URL in metadata
 -- Fixed Breeze scrollbar CSS causing cross domain access issue
 -- Fixed cancelling download causing "unknown error" notification in Firefox
 -- Media sessions are more resilient against unexpected input
 - KIO performance improvements and profiling
 -- Removed timezone conversion stuff during file copy, saves some cycles
 - kdialog --icon now also sets dialog icon
 Work todo:
 - Various Plasma bits
 - Will be at Qt World Summit in Berlin on Thursday

Eike:
* hotfixed the regression that broke the TM group dialog in 5.14.4
* fixed a bug in the Language KCM that broke removing the first language in 
the list and fixed the behavior around how action states change with a single 
list item, still on review
* fixed up the sync code in the new virtual desktops KCM and threw some bug 
reports for the KWin side at Marco
* added a service watcher to handle KWin restarts
* I want to improve the KWin restart handling a bit more today, then it might 
be done
* I also stubbed out the new Accessibility KCM, which was my other 5.15 task

Vlad:
Done:
 * KWin/Wayland no longer crashes when changing compositor settings;
 * Fixed flickering of the splash screen on startup;
 * Check presence of the inhibitor object when a client is registered in 
IdleInhibition.
 Under review/Waiting for review:
 * Try to invalidate quad cache when shadow is changed (fixes blank decoration 
tooltips);
 * Don't use hardcoded move-resize cursor;
 * Expose Wayland clients to the scripting API;
 * "Fix" lowerClient/raiseClient for group transients.
 Todo:
 * Don't inhibit the idle behavior if the surface is not visible;
 * Cover Fade/Glide/Scale/Fading Popups effect by tests.
 ---
 On a personal note, I got sick.

Roman:
 * Pushed the input device handler and touch input patch series yesterday. If 
you find any bugs / strange behavior pls tell me.
  (15519 still has a failing unit test)
 * Will be at QtWS this week

David:
* finally merged my kwin patchset that replaces libkwineffect window calling 
QObject::property() with virtual methods (a bit more efficient, a lot of 
boilerplate had to be ported)
* (ongoing) ported hwcomposer's backend to the new AbstractOutput that Roman 
did, mostly to make the changes bshah wants a bit simpler

Marco:
* was a week mostly hunting visual glitches and papercuts

Kirigami:
* Scrollable pages default their contents to pixel-aligned

QQC2:
* All scrollviews default their contents to pixel-aligned
* finally corners of textfields and bigger views properly rounded in desktop 
QQC2, white corner pixels gone (were noticeable expecially with bigger scale 
factors)
* fixed sizing of the Menu item, Plasma style menu on feature parity
* Comboboxes work as the qwidget ones: open on press, hovering the pressed 
mouse and releasing on an item triggers it.
* touchscreen text selection controls in editable comboboxes as well.
* sizing of text fields in desktop qqc2

Plasma:
* KWin and virtualdesktops: some fixes in the dbus protocol and loading names 
from config: D17265
* hardmonized look of all config dialogs (qml and qwidgets) and systemsettings 
kcm titles (qml and qwidgets) and ported some pieces of plasma to qqc2 and 
kirigami: 
** KTitleWidget now has the font looking like Kirigami.Heading and gained the 
"level" API
** QML and QWidget kcms have now the title perfectly aligned
** Applets config view and containment config views ported to QQC2 and 
Kirigami, using Kirigami headers consisten with the rest
** ported systray general settings page to QQC2 and FormLayout
* D17192 but vdg doesn't likey
Plasma mobile:
* fixed https://phabricator.kde.org/T10009 crash on activity creation
This week/Todo:
refining multilevel kcm to make the NM kcm work under the new api



-- 
Marco Martin

D17192: use a Kirigami Heading for perfect consistency

2018-12-03 Thread Marco Martin 
mart added a comment.


  In D17192#368233 , @ngraham wrote:
  
  > It isn't a title, though. At best, the text in question is a list item, not 
a title.
  
  
  It surely is, it's the title of that column and says, this column is stuff 
about "Fonts", "Workspace theme" etc

REPOSITORY
  R124 System Settings

REVISION DETAIL
  https://phabricator.kde.org/D17192

To: mart, #plasma, #vdg
Cc: fabianr, abetts, ngraham, plasma-devel, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D17212: Port to QQC2 and FormLayout

2018-12-03 Thread Marco Martin 
This revision was automatically updated to reflect the committed changes.
Closed by commit R120:76eba93be27f: Port to QQC2 and FormLayout (authored by 
mart).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17212?vs=46465=46770

REVISION DETAIL
  https://phabricator.kde.org/D17212

AFFECTED FILES
  applets/systemtray/package/contents/ui/ConfigGeneral.qml
  wallpapers/image/imagepackage/contents/ui/config.qml

To: mart, #plasma, #vdg, ngraham
Cc: ngraham, abetts, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, sebas, apol, mart

D11410: [RFC] Add option to make applet fixed width

2018-12-03 Thread Marco Martin 
mart added a comment.


  any updates on this?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D11410

To: Pitel, #plasma
Cc: mart, hein, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol

D17212: Port to QQC2 and FormLayout

2018-11-29 Thread Marco Martin 
mart added a comment.


  In D17212#368135 , @abetts wrote:
  
  > In D17212#368048 , @mart wrote:
  >
  > > F6446445: Screenshot_20181129_143041.png 

  >
  >
  > Wait! Isn't the header labels supposed to be on the right? They are also 
supposed to be aligned to the first item in the series of checkboxes.
  
  
  no
  
  > Current:
  > 
  > LABEL
  > 
  > [X] ITEM
  > 
  >   Proper:
  > 
  >   LABEL [x] ITEM
  
  no, formalyout titles are titles on top of the section.
  They used to always be left aligned, but after a long discussion they were 
moved towards the center as well.
  This is the reference implementation of a correct form layout in the kirigami 
gallery:
  
  F6447089: Screenshot_20181129_170219.png 


REPOSITORY
  R120 Plasma Workspace

BRANCH
  phab/qqc2

REVISION DETAIL
  https://phabricator.kde.org/D17212

To: mart, #plasma, #vdg, ngraham
Cc: ngraham, abetts, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, sebas, apol, mart

D17211: Port applet/containment configs to qqc2

2018-11-29 Thread Marco Martin 
This revision was automatically updated to reflect the committed changes.
Closed by commit R119:c2640f83f107: Port applet/containment configs to qqc2 
(authored by mart).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17211?vs=46481=46483

REVISION DETAIL
  https://phabricator.kde.org/D17211

AFFECTED FILES
  desktoppackage/contents/configuration/AppletConfiguration.qml
  desktoppackage/contents/configuration/ConfigCategoryDelegate.qml
  desktoppackage/contents/configuration/ConfigurationContainmentActions.qml
  desktoppackage/contents/configuration/ConfigurationContainmentAppearance.qml
  desktoppackage/contents/configuration/ConfigurationKcmPage.qml
  desktoppackage/contents/configuration/ConfigurationShortcuts.qml
  desktoppackage/contents/configuration/MouseEventInputButton.qml

To: mart, #plasma, #vdg, broulik, ngraham
Cc: abetts, ngraham, apol, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, sebas, mart

D17192: use a Kirigami Heading for perfect consistency

2018-11-29 Thread Marco Martin 
mart added a comment.


  well, to me part of the problem is that a title became a back button... even 
tough smaller target to hit, i would have preferred to have a toolbutton 
followed by a proper title that is just a title

REPOSITORY
  R124 System Settings

REVISION DETAIL
  https://phabricator.kde.org/D17192

To: mart, #plasma, #vdg
Cc: fabianr, abetts, ngraham, plasma-devel, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D17211: Port applet/containment configs to qqc2

2018-11-29 Thread Marco Martin 
mart updated this revision to Diff 46481.
mart added a comment.


  - show the label again, but shorter

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17211?vs=46398=46481

BRANCH
  phab/qqc2

REVISION DETAIL
  https://phabricator.kde.org/D17211

AFFECTED FILES
  desktoppackage/contents/configuration/AppletConfiguration.qml
  desktoppackage/contents/configuration/ConfigCategoryDelegate.qml
  desktoppackage/contents/configuration/ConfigurationContainmentActions.qml
  desktoppackage/contents/configuration/ConfigurationContainmentAppearance.qml
  desktoppackage/contents/configuration/ConfigurationKcmPage.qml
  desktoppackage/contents/configuration/ConfigurationShortcuts.qml
  desktoppackage/contents/configuration/MouseEventInputButton.qml

To: mart, #plasma, #vdg, broulik, ngraham
Cc: abetts, ngraham, apol, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, sebas, mart

D17212: Port to QQC2 and FormLayout

2018-11-29 Thread Marco Martin 
mart updated this revision to Diff 46465.
mart added a comment.


  - center the layout

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17212?vs=46396=46465

BRANCH
  phab/qqc2

REVISION DETAIL
  https://phabricator.kde.org/D17212

AFFECTED FILES
  applets/systemtray/package/contents/ui/ConfigGeneral.qml
  wallpapers/image/imagepackage/contents/ui/config.qml

To: mart, #plasma, #vdg
Cc: ngraham, abetts, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, sebas, apol, mart

D17212: Port to QQC2 and FormLayout

2018-11-29 Thread Marco Martin 
mart added a comment.


  F6446445: Screenshot_20181129_143041.png 


REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D17212

To: mart, #plasma, #vdg
Cc: ngraham, abetts, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, sebas, apol, mart

D17211: Port applet/containment configs to qqc2

2018-11-29 Thread Marco Martin 
mart added a comment.


  the shrinking of the wallpaper combobox will be done in a separate commit

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D17211

To: mart, #plasma, #vdg, broulik, ngraham
Cc: ngraham, apol, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, mart

D17211: Port applet/containment configs to qqc2

2018-11-29 Thread Marco Martin 
mart added a comment.


  In D17211#367974 , @mart wrote:
  
  > ah, that needs a fix in qqc2-desktop-style.. i can hack the open on down, 
tough for combox and menus in particular, is not possible at all the pattern 
press, open the subpopup, move the mouse to select, release and trigger the 
menu item. It's a long time that i think how to solve that, but it's a very 
complicated problem :/
  >  tough the open on press is done now
  
  
  scratch that, i found an hack that makes it work, it's in master now :p

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D17211

To: mart, #plasma, #vdg, broulik, ngraham
Cc: ngraham, apol, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, mart

D17211: Port applet/containment configs to qqc2

2018-11-29 Thread Marco Martin 
mart added a comment.


  In D17211#367573 , @ngraham wrote:
  
  > The Layout and Wallpaper Type comboboxes should open on press, not on 
click-and-release.
  
  
  ah, that needs a fix in qqc2-desktop-style.. i can hack the open on down, 
tough for combox and menus in particular, is not possible at all the pattern 
press, open the subpopup, move the mouse to select, release and trigger the 
menu item. It's a long time that i think how to solve that, but it's a very 
complicated problem :/
  tough the open on press is done now
  
  > The Positioning combobox shouldn't be so much much wider than the other 
comboboxes; the text of the longest item doesn't seem long enough to cause such 
a long width.
  
  yeha, is a bit difficult as
  
  > Is changing the wallpaper plugins button even necessary for this patch? If 
you think it is, instead of making the wallpaper plugin button icons-only, can 
we move it to the bottom row with the other GHNS button?
  
  the button was already there and was quite messy with long texts (very long 
in english, doesn't fit to the whole window width in german) in that case for 
now i find it cleared near the combobox
  
  > Either way, this patch now fixes 
https://bugs.kde.org/show_bug.cgi?id=401472 so please add:
  > 
  >   BUG: 401472
  >   FIXED-IN: 5.15.0

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D17211

To: mart, #plasma, #vdg, broulik, ngraham
Cc: ngraham, apol, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, mart

D17192: use a Kirigami Heading for perfect consistency

2018-11-28 Thread Marco Martin 
mart added a comment.


  @abetts , @ngraham discuss :)

REPOSITORY
  R124 System Settings

REVISION DETAIL
  https://phabricator.kde.org/D17192

To: mart, #plasma, #vdg
Cc: abetts, ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, sebas, apol, mart

D17211: Port applet/containment configs to qqc2

2018-11-28 Thread Marco Martin 
mart updated this revision to Diff 46398.
mart added a comment.


  - initialize a proper size

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17211?vs=46397=46398

BRANCH
  phab/qqc2

REVISION DETAIL
  https://phabricator.kde.org/D17211

AFFECTED FILES
  desktoppackage/contents/configuration/AppletConfiguration.qml
  desktoppackage/contents/configuration/ConfigCategoryDelegate.qml
  desktoppackage/contents/configuration/ConfigurationContainmentActions.qml
  desktoppackage/contents/configuration/ConfigurationContainmentAppearance.qml
  desktoppackage/contents/configuration/ConfigurationKcmPage.qml
  desktoppackage/contents/configuration/ConfigurationShortcuts.qml
  desktoppackage/contents/configuration/MouseEventInputButton.qml

To: mart, #plasma, #vdg, broulik
Cc: apol, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, mart

D17211: Port applet/containment configs to qqc2

2018-11-28 Thread Marco Martin 
mart added a comment.


  oddly seems not all the pages to not animate... i fear they are trying to set 
anchors?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D17211

To: mart, #plasma, #vdg, broulik
Cc: apol, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, mart

<    4   5   6   7   8   9   10   11   12   13   >