[X2Go-Dev] Bug#1194: Bug#1194: TERM variable not set

[Mihai Moldovan]

Control: reassign -1 x2goclient 4.1.0.0
Control: tag -1 invalid
Control: close -1

* On 7/15/17 10:16 AM, Patryk P wrote:
> Package: X2Go Client v. 4.1.0.0 (Qt - 4.8.6.) for windows 7 32bit
>
> Console output:
> 2017-07-15 10_15_28-X2Go Client (Debug).png

Not a bug within X2Go Client.

Your shell startup scripts (likely something like ~/.bashrc, ~/.bash_profile,
~/.profile or the like) use commands that expect TERM to be set correctly, which
is only the case for interactive sessions.

X2Go Client does not use interactive sessions.

Wrap code that might need an interactive session or terminal in if tty -s; then
...; fi or something like this in your startup scripts.



Mihai



OpenPGP_signature
Description: OpenPGP digital signature
___
x2go-dev mailing list
x2go-dev@lists.x2go.org
https://lists.x2go.org/listinfo/x2go-dev

Re: [X2Go-Dev] Nightly builds stopped?

[Mihai Moldovan]

* On 1/29/22 8:19 PM, 4dac...@gmail.com wrote:
> Was giving x2go a try and noticed that the last nightly build for windows was
> back in November 2021.
> Checking if that's expected or if there was an issue with builds being 
> resolved.

That's totally expected.

The last change to X2Go Client was on Nov 28 2021, which nicely fits the
observation. Not just for Windows, but everything else, too. I may have rebuilt
packages for Linux since then due to internal dependencies, but those updates
didn't include any changes, if at all.


Our package builder instance is public at https://jenkins.x2go.org .



Mihai



OpenPGP_signature
Description: OpenPGP digital signature
___
x2go-dev mailing list
x2go-dev@lists.x2go.org
https://lists.x2go.org/listinfo/x2go-dev

[X2Go-Dev] Bug#1568: Add tooltips to X server modes

[Mihai Moldovan]

Package: x2goclient
Version: 4.1.2.3

The X server modes are non-intuitive and under-explained.

Add tooltips explaining modes, such as: Fullscreen -> spans all screens, Whole
Display -> spans one screen only etc.



Mihai



OpenPGP_signature
Description: OpenPGP digital signature
___
x2go-dev mailing list
x2go-dev@lists.x2go.org
https://lists.x2go.org/listinfo/x2go-dev

Re: [X2Go-Dev] Failing resuming session with latest X2Go Server from nightly builds

[Mihai Moldovan]

* On 8/3/21 4:32 PM, Oleksandr Shneyder wrote:
> Ok, check it please. I can confirm that it doesn't work on both debian
> buster and bullseye

The newest builds should work again.

I've introduced a stupid error while redirecting messages from stderr and messed
up the clipboard argument handling.



Mihai



OpenPGP_signature
Description: OpenPGP digital signature
___
x2go-dev mailing list
x2go-dev@lists.x2go.org
https://lists.x2go.org/listinfo/x2go-dev

Re: [X2Go-Dev] Failing resuming session with latest X2Go Server from nightly builds

[Mihai Moldovan]

* On 8/3/21 4:00 PM, Oleksandr Shneyder wrote:
> one of my customers reported that after update x2go server from
> 4.1.0.4-0x2go1.2~git20210627.1936+10.heuler.1 amd64 to
> 4.1.0.4-0x2go1.2~git20201228.1914+10.heuler.1 amd64
> he not able to resume sessions anymore. I checked it on my system and I
> can confirm it. I figured out, that somehow x2goresume-session makes
> session option file empty (size = 0).

> @Mihai: I saw that you commited some changes in x2goresume-sessions
> between this two versions. Do you have idea what could go wrong here,
> before I'll start to debug it by myself?

Not yet, I'll look into it.

I definitely changed the session options file handling to use the new perl tool,
but that should have been transparent.



Mihai



OpenPGP_signature
Description: OpenPGP digital signature
___
x2go-dev mailing list
x2go-dev@lists.x2go.org
https://lists.x2go.org/listinfo/x2go-dev

Re: [X2Go-Dev] X2Go Client Nightly builds for debian bullseye

[Mihai Moldovan]

* On 5/13/21 12:37 AM, Mihai Moldovan wrote:
> Now that the .deb-based systems are done, I'll continue with the RPM-based 
> ones,
> probably tomorrow. That should be a lot easier, since spec files are much more
> powerful compared to the static Debian files. Also a bit of polishing, but
> that's non-critical.

That took a lot longer than expected.

I had to update mock configuration files for newer Fedora versions (mostly to
update the Rawhide ones) and then it turned out that the RPM version on the
stretch-based package builder was too old.

That meant that I had to backport the rpm version from unstable and rebuild all
dependent packages like dnf, libsolv etc.

With that, newer Fedora versions started building again, but older releases,
like EPEL 6 and 7, which are yum-based, started failing on downloading build
dependencies.

I then started looking into replacing yum-builddep with the dnf-provided
yum-builddep wrapper, but soon found out that this didn't work either.
dnf-utils, even when invoked as yum-builddep with an installroot parameter, only
searches for dnf.conf - first within the installroot, then within the main
system, if the installroot does not contain this file. Thus, I went ahead and
patched dnf to add a --yumcompat flag which is automatically passed for
yum-compat wrappers like yum-builddep and which prefers yum.conf over dnf.conf,
with a fallback to the latter.

This initially seemed to work for downloading the build dependencies, but failed
later while installing them through yum, which is not easily replaceable.

In the end, it turned out that I forgot to backport a Python 2 compatibility
patch to the rpm package (since upstream RPM dropped Python 2 support for good),
after which yum started working again.


With a few more spec file changes, we're now building against Qt 5 on RPM-based
platforms which do not support Qt 4 any longer.


I'll still have to work on the Windows and OS X/macOS builds, but probably more
importantly, will have to port the changes to other packages as well, like
PinEntry-X2Go (which needs proper rebasing against a newer upstream version, I
figure), X2GoAdminCenter (which is... actually quite dead anyway) and
X2GoDesktopSharing.



Mihai



OpenPGP_signature
Description: OpenPGP digital signature
___
x2go-dev mailing list
x2go-dev@lists.x2go.org
https://lists.x2go.org/listinfo/x2go-dev

Re: [X2Go-Dev] X2Go Client Nightly builds for debian bullseye

[Mihai Moldovan]

* On 5/2/21 2:27 PM, Mihai Moldovan wrote:
> I'll want to write up a small preprocessor utility to handle this in a nicer 
> way.
> 
> Will hopefully get that done in the next few days.

Finally got it all ready and, as far as I can tell, working right now.

I've created a preprocessing script (replacing @@MARKERS@@) and a simple
condition-based preprocessor written in Perl for handling this.

Debian Bullseye and higher will use Qt 5, older releases stay on Qt 4.

Ubuntu 20.04 and higher will use Qt 5, older release stay on Qt 4.


I can easily extend this solution to Qt 6 once it hits distributions, so that's
good.

The debian/control will now be autogenerated by our build system, but also must
be manually synced to the build-master-qt{4,5} branches for Launchpad (only). A
README file with instructions is provided. That's a bit inconvenient, but
Launchpad doesn't allow "run"-type hooks in their recipes (yet) and they require
a working control file in the main build branch, so that was the only generic
solution I could come up with.

Due to this, I had to split the nightly builds into two recipes on Launchpad.
The old one is set to manual mode - please don't trigger builds there by 
accident.


Now that the .deb-based systems are done, I'll continue with the RPM-based ones,
probably tomorrow. That should be a lot easier, since spec files are much more
powerful compared to the static Debian files. Also a bit of polishing, but
that's non-critical.



Mihai



OpenPGP_signature
Description: OpenPGP digital signature
___
x2go-dev mailing list
x2go-dev@lists.x2go.org
https://lists.x2go.org/listinfo/x2go-dev

[X2Go-Dev] Bug#1469: Bug#1469: X2Go issue (in src:x2goclient) has been marked as pending for release

[Mihai Moldovan]

* On 5/12/21 7:28 PM, Mihai Moldovan wrote:
> tag #1469 pending
> fixed #1469 4.1.2.3
> thanks

This shouldn't have fired again, but it did. Not sure why, but feel free to
ignore it.



Mihai



OpenPGP_signature
Description: OpenPGP digital signature
___
x2go-dev mailing list
x2go-dev@lists.x2go.org
https://lists.x2go.org/listinfo/x2go-dev

[X2Go-Dev] Bug#1543: Bug#1543: report spam - link is broken

[Mihai Moldovan]

Control: close -1

* On 5/2/21 11:03 PM, René Genz wrote:
> Package: wiki.x2go.org
> 
> On the website:
> https://bugs.x2go.org/cgi-bin/bugreport.cgi?bug=937
> at the bottom you can read "Send a report that this bug log contains spam." 
> The part "this bug log contains spam" links to:
> https://bugs.x2go.org/cgi-bin/bugs.x2go.org/cgi-bin/bugspam.cgi?bug=937
> which results in a 404 error. The correct URL is:
> https://bugs.x2go.org/cgi-bin/bugspam.cgi?bug=937

Remind me to never try to update to the 3.0.0 alpha version of debbugs again.
I've wasted 10 hours on that only to realize that the packaging and code are
currently broken beyond (easy) repair.

I've upgraded to the currently unreleased 2.6.1 version and backported a few
fixes that went missing from our version.

I also modified the configuration to always include the https:// protocol
specifier, which should fix the issue you've been seeing (and, hopefully, not
cause other links to have double protocol specifiers).


Mihai



OpenPGP_signature
Description: OpenPGP digital signature
___
x2go-dev mailing list
x2go-dev@lists.x2go.org
https://lists.x2go.org/listinfo/x2go-dev

Re: [X2Go-Dev] X2Go Client Nightly builds for debian bullseye

[Mihai Moldovan]

* On 4/28/21 1:58 AM, Mihai Moldovan wrote:
> I'll switch the deb builds over to Qt5 for bullseye+ within the next few days.
> Too tired to do that today.

Started working on it.

I'll want to write up a small preprocessor utility to handle this in a nicer 
way.

Will hopefully get that done in the next few days.



Mihai



OpenPGP_signature
Description: OpenPGP digital signature
___
x2go-dev mailing list
x2go-dev@lists.x2go.org
https://lists.x2go.org/listinfo/x2go-dev

Re: [X2Go-Dev] X2Go Client Nightly builds for debian bullseye

[Mihai Moldovan]

* On 4/27/21 7:58 PM, Mike Gabriel wrote:
> I think that the DEB based package builds should switch to Qt5 builds.  
> I'll check, if that also works for Debian 9 builds. If so, I'll do the  
> switch over.
> 
> @Mihai: unless you have an outstandingly better idea.

I'll switch the deb builds over to Qt5 for bullseye+ within the next few days.
Too tired to do that today.



Mihai



OpenPGP_signature
Description: OpenPGP digital signature
___
x2go-dev mailing list
x2go-dev@lists.x2go.org
https://lists.x2go.org/listinfo/x2go-dev

[X2Go-Dev] Bug#1228: Bug#1228: X2Go issue (in src:x2goserver) has been marked as pending for release

[Mihai Moldovan]

Control: notfixed -1 4.1.0.4

* On 4/19/21 8:28 PM, Mihai Moldovan wrote:
> tag #1228 pending
> fixed #1228 4.1.0.4
> thanks

Sorry for the noise, this should have not made it to the master branch yet.

It requires nx-libs to be updated first and a round of cleanup in the commits.


It'll eventually be pushed correctly, but not just now.



Mihai



OpenPGP_signature
Description: OpenPGP digital signature
___
x2go-dev mailing list
x2go-dev@lists.x2go.org
https://lists.x2go.org/listinfo/x2go-dev

[X2Go-Dev] Bug#1228: X2Go issue (in src:x2goserver) has been marked as pending for release

[Mihai Moldovan]

tag #1228 pending
fixed #1228 4.1.0.4
thanks

Hi!

X2Go issue #1228 (src:x2goserver) reported by you has been
fixed in X2Go Git. You can see the changelog below, and you can
check the diff of the fix at:


https://code.x2go.org/gitweb?p=x2goserver.git;a=commitdiff;h=51e1da1312245accbfcb6f2fa360c5bef3d99588

The issue will most likely be fixed in src:x2goserver (4.1.0.4).

light+love
X2Go Git Admin (on behalf of the sender of this mail)

---
commit 51e1da1312245accbfcb6f2fa360c5bef3d99588
Author: Ulrich Sibiller 
Date:   Fri Mar 12 11:48:19 2021 +0100

x2gostartsession: let x2godialog handle events via NX_CLIENT.

Previously, any action that should have displayed a dialog did instead
suspend x2goagent, since NX_CLIENT was set to x2gosuspend-session.

Fixes: #1228.
Fixes: #1540.

diff --git a/debian/changelog b/debian/changelog
index 5fde4817..102e58c8 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -458,6 +458,10 @@ x2goserver (4.1.0.4-0x2go1.2) UNRELEASED; urgency=medium
   Previous version was incomplete. Note that this will only work correctly
   once we actually update to 3.5.99.26 within X2Go, but it doesn't hurt to
   have the new definitions until then. Fixes: #1538.
+- x2gostartsession: let x2godialog handle events via NX_CLIENT.
+  Previously, any action that should have displayed a dialog did instead
+  suspend x2goagent, since NX_CLIENT was set to x2gosuspend-session.
+  Fixes: #1228. Fixes: #1540.
 
  -- Mike Gabriel   Fri, 19 Jul 2019 20:55:11 
+0200
 
___
x2go-dev mailing list
x2go-dev@lists.x2go.org
https://lists.x2go.org/listinfo/x2go-dev

[X2Go-Dev] Bug#1538: X2Go issue (in src:x2goserver) has been marked as pending for release

[Mihai Moldovan]

tag #1538 pending
fixed #1538 4.1.0.4
thanks

Hi!

X2Go issue #1538 (src:x2goserver) reported by you has been
fixed in X2Go Git. You can see the changelog below, and you can
check the diff of the fix at:


https://code.x2go.org/gitweb?p=x2goserver.git;a=commitdiff;h=4768edb3cd698a8d673f8aaa880d4f4a9a3e9832

The issue will most likely be fixed in src:x2goserver (4.1.0.4).

light+love
X2Go Git Admin (on behalf of the sender of this mail)

---
commit 4768edb3cd698a8d673f8aaa880d4f4a9a3e9832
Author: Ulrich Sibiller 
Date:   Fri Mar 12 11:24:02 2021 +0100

x2goserver-x2goagent/etc/keystrokes.cfg: sync with nx-libs 3.5.99.26.

Previous version was incomplete.

Note that this will only work correctly once we actually update to
3.5.99.26 within X2Go, but it doesn't hurt to have the new definitions
until then.

Fixes: #1538.

diff --git a/debian/changelog b/debian/changelog
index f8c6dde8..e0556d9c 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -451,6 +451,10 @@ x2goserver (4.1.0.4-0x2go1.2) UNRELEASED; urgency=medium
 - x2goserver/bin/x2gostartagent: prevent logfile corruption. Both stderr
   redirection and errors= in the options file wrote to the same file which
   lead to corruption with lots of debug output. Fixes: #1537.
+- x2goserver-x2goagent/etc/keystrokes.cfg: sync with nx-libs 3.5.99.26.
+  Previous version was incomplete. Note that this will only work correctly
+  once we actually update to 3.5.99.26 within X2Go, but it doesn't hurt to
+  have the new definitions until then. Fixes: #1538.
 
  -- Mike Gabriel   Fri, 19 Jul 2019 20:55:11 
+0200
 
___
x2go-dev mailing list
x2go-dev@lists.x2go.org
https://lists.x2go.org/listinfo/x2go-dev

[X2Go-Dev] Bug#1537: X2Go issue (in src:x2goserver) has been marked as pending for release

[Mihai Moldovan]

tag #1537 pending
fixed #1537 4.1.0.4
thanks

Hi!

X2Go issue #1537 (src:x2goserver) reported by you has been
fixed in X2Go Git. You can see the changelog below, and you can
check the diff of the fix at:


https://code.x2go.org/gitweb?p=x2goserver.git;a=commitdiff;h=16fad4232117be46a15b5b92c7cea80f6c7358bf

The issue will most likely be fixed in src:x2goserver (4.1.0.4).

light+love
X2Go Git Admin (on behalf of the sender of this mail)

---
commit 16fad4232117be46a15b5b92c7cea80f6c7358bf
Author: Ulrich Sibiller 
Date:   Fri Mar 12 11:17:32 2021 +0100

x2goserver/bin/x2gostartagent: prevent logfile corruption.

Both stderr redirection and errors= in the options file wrote to the
same file which lead to corruption with lots of debug output.

Fixes: #1537.

diff --git a/debian/changelog b/debian/changelog
index 7b79abcb..f8c6dde8 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -448,6 +448,9 @@ x2goserver (4.1.0.4-0x2go1.2) UNRELEASED; urgency=medium
   * New upstream version (4.1.0.4):
 - x2goserver-x2goagent/etc/keystrokes.cfg: sync with nx-libs 3.5.99.20.
   Previous version was broken and incomplete. Fixes: #1388.
+- x2goserver/bin/x2gostartagent: prevent logfile corruption. Both stderr
+  redirection and errors= in the options file wrote to the same file which
+  lead to corruption with lots of debug output. Fixes: #1537.
 
  -- Mike Gabriel   Fri, 19 Jul 2019 20:55:11 
+0200
 
___
x2go-dev mailing list
x2go-dev@lists.x2go.org
https://lists.x2go.org/listinfo/x2go-dev

[X2Go-Dev] Bug#1530: TLS intermediate certificate seems to be "wrong"

[Mihai Moldovan]

Control: close -1

* On 3/5/21 1:43 AM, Tim Landscheidt wrote:
> Staring at "openssl s_client -connect wiki.x2go.org:443",
> https://www.ssllabs.com/ssltest/analyze.html?d=wiki.x2go.org
> and https://letsencrypt.org/certificates/ suggests to a
> layman that the server certificate is signed by the R3
> certificate, but the X3 certificate is sent along?

Thanks for reporting and "debugging" this.

Yeah, we were concatenating the old X3 cross-signed cert.

Switched to R3 and regenerated the affected certificates. Should be fixed now.



Mihai




OpenPGP_signature
Description: OpenPGP digital signature
___
x2go-dev mailing list
x2go-dev@lists.x2go.org
https://lists.x2go.org/listinfo/x2go-dev

[X2Go-Dev] Bug#1469: Bug#1469: But wait; there is more... patches!

[Mihai Moldovan]

* On 5/20/20 5:04 PM, Melroy van den Berg wrote:
>> Using (std::)endl is actually a bug
> 
> Ah, thanks for the heads-up! I think in that case we should in fact remove 
> all the endl instead of adding it :).

Yeah, probably. It creates additional newlines in the debug output which isn't
really intended. It might be a nice way to group messages to some degree, but I
figure I added most of the endls myself when I didn't know better, which was a
mistake in the past.


>> Strictly speaking, though, this should not cause any issues
> 
> Why was I getting socket error then? I really hope everything got merged 
> correctly now. Including my changes in the separate function.
> Since all the changes together made my socket error from libssh disappear now.

Of course, I merged in most functional changes unless explicitly noted. The
issues were probably caused by the other locations, not this one specifically.
I pulled it anyway, because that's probably the more correct behavior in any 
case.


> I got deprecation warnings on this function/line while compiling. Why not 
> merge it and remove build warnings?
> The change in within the #else, maybe if you think it should be in the #if 
> you can apply the change in that section (but I think in my case the else 
> part got compiled).
> Nevertheless, it's a deprecation that needs to be solved anyway.

It doesn't need to be solved because it *is* already solved when compiling
against newer libssh versions. The actual bug is that it seems to have used the
#else branch in your compile runs and I'm curious why. What OS have you been
using to build it and, specifically, what version of libssh-{4,dev} was 
installed?

Case in point, I certainly don't get a warning when building against libssh
0.9.3, which indicates that the the correct branch without the non-deprecated
function is used.

If your system has libssh >= 0.8.0 and it's taking the wrong branch, I'd like to
know what's wrong.


>> Not changing return (...) vs. return ..., the actual change
>> looks good though.
> 
> Why not changing the return(). This is wrong code, it's just a boolean! Bad 
> practice, please don't it. Don't be afraid to change it.

That's just not true.

Up until C++14, "return (foo)" and "return foo" were functionally absolutely
equivalent and just a matter of taste/style. I like the former way better,
because it encapsulates the return value optically.

Since C++14, you're half right that it's wrong, because both statements MIGHT
behave differently. This, however, is only the case for return values that
explicitly use decltype (auto).

We're not using any C++14 (or even C++11) features anyway and probably won't do
so for a longer time, because we also target legacy systems without such
support. In the end, it is personal preference here.


> A generic remark: I think X2Go is missing a good pipeline with testcases and
> other quality checks.

Yes, it does, and that's arguably bad. We've been discussing this every single
year, but that's a mammoth task.


> Which also hopefully increases your *trust in the code*
> and enables refactoring as well.
> I'm not afraid to refactor the code and clean-up the formatting, splitting
> functions and even into multiple files. If this all improve readability,
> debuggability and test-ability long-term.

I always avoid changing stuff for no good reason. While proper version control
systems like git take out some of the complexity that is involved by, e.g.,
formatting updates, it still comes at a price that cannot be automatically
handled by the tools.

I like to git blame a lot to see how portions of code changed, but each
non-functional change adds another layer of indirection to the process, which
can make it very frustrating.

Most software projects I came across handle it the same way and will tell you to
please split out non-functional changes or to just remove them completely.


> That is why I raise a request to create a decent pipeline to allow the 
> necessary
> changes in further improve code maturity and the needed changes to do so.
> And maybe even a better diff tool to perform refactoring changes during 
> review.
> 
> Any ideas or suggestions? I'm running a GitLab instance myself for example;
> which enables DevOps and CI/CD within all my projects.
> Thanks once more!

We do have a public Jenkins instance for CI at https://jenkins.x2go.org .

Testing is really a badly missing thing, but we try to test things in a manual
manner especially before a release if time permits, but naturally that's not a
substitute for, e.g., unit tests.

Completely automatic testing of GUI stuff is extremely difficult, though.

Maybe someday, but I won't and cannot promise it. I'm already stumped with so
much other stuff that regularly breaks or needs to be updated/improved and is
arguably more important (because the best testing infrastructure won't help you
if all the other things don't work).



Mihai



signature.asc
Description: OpenPGP digital signature

[X2Go-Dev] Bug#1458: X2Go issue (in src:x2gobroker) has been marked as pending for release

[Mihai Moldovan]

tag #1458 pending
fixed #1458 0.0.4.2
thanks

Hi!

X2Go issue #1458 (src:x2gobroker) reported by you has been
fixed in X2Go Git. You can see the changelog below, and you can
check the diff of the fix at:


https://code.x2go.org/gitweb?p=x2gobroker.git;a=commitdiff;h=52a8aeef7311e384889d07537183e6b4c8b695a7

The issue will most likely be fixed in src:x2gobroker (0.0.4.2).

light+love
X2Go Git Admin (on behalf of the sender of this mail)

---
commit 52a8aeef7311e384889d07537183e6b4c8b695a7
Author: Mihai Moldovan 
Date:   Tue Apr 21 14:44:23 2020 +0200

debian/x2gobroker-ssh.postinst: only reload nscd configuration if daemon is 
installed and actually running. Fixes: #1458.

Based on a patch by Stefan Baur.

diff --git a/debian/changelog b/debian/changelog
index 85985e9..1d07af6 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -13,6 +13,9 @@ x2gobroker (0.0.4.2-0x2go1) UNRELEASED; urgency=medium
   * New upstream version (0.0.4.2):
   * debian/control:
 + Add psproc dependency to x2gobroker-ssh. We'll need it later on.
+  * debian/x2gobroker-ssh.postinst:
++ Only reload nscd configuration if daemon is installed and actually
+  running. Fixes: #1458. Based on a patch by Stefan Baur.
 
  -- X2Go Release Manager   Mon, 22 Apr 2019 12:31:49 +0200
 
___
x2go-dev mailing list
x2go-dev@lists.x2go.org
https://lists.x2go.org/listinfo/x2go-dev

[X2Go-Dev] Bug#1230: X2Go issue (in src:x2goserver) has been marked as pending for release

[Mihai Moldovan]

tag #1230 pending
fixed #1230 4.0.1.23
thanks

Hi!

X2Go issue #1230 (src:x2goserver) reported by you has been
fixed in X2Go Git. You can see the changelog below, and you can
check the diff of the fix at:

http://code.x2go.org/gitweb?p=x2goserver.git;a=commitdiff;h=7a76b291

The issue will most likely be fixed in src:x2goserver (4.0.1.23).

light+love
X2Go Git Admin (on behalf of the sender of this mail)

---
commit 7a76b291ed589775ee5d84c34b677fd621ce6d11
Author: Mihai Moldovan 
Date:   Thu Jan 4 06:16:51 2018 +0100

x2goserver/bin/x2go{startagent,resume-session}: use x2gogetfreeport instead 
of duplicating the same code everywhere. Fixes: #1230.

Also, rely on it returning a valid value and try at most 10 times to
fetch a usable port value, then error out and make the session startup
or resumption fail.

diff --git a/debian/changelog b/debian/changelog
index 818e823e..f8582d47 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -51,6 +51,11 @@ x2goserver (4.0.1.23-0x2go1) UNRELEASED; urgency=medium
   quotes on the lib path line.
 - x2goserver/bin/x2goresume-session: properly randomize first port, just
   like in x2gostartagent.
+- x2goserver/bin/x2go{startagent,resume-session}: use x2gogetfreeport
+  instead of duplicating the same code everywhere. Fixes: #1230. Also,
+  rely on it returning a valid value and try at most 10 times to fetch a
+  usable port value, then error out and make the session startup or
+  resumption fail.
   * x2goserver.spec:
 - RPMify x2goserver-xsession description.
 - Remove qt4 stuff, we're not using the framework here.
___
x2go-dev mailing list
x2go-dev@lists.x2go.org
https://lists.x2go.org/listinfo/x2go-dev

[X2Go-Dev] Bug#1230: X2Go issue (in src:x2goserver) has been marked as pending for release

[Mihai Moldovan]

tag #1230 pending
fixed #1230 4.0.1.23
thanks

Hi!

X2Go issue #1230 (src:x2goserver) reported by you has been
fixed in X2Go Git. You can see the changelog below, and you can
check the diff of the fix at:

http://code.x2go.org/gitweb?p=x2goserver.git;a=commitdiff;h=7a76b291

The issue will most likely be fixed in src:x2goserver (4.0.1.23).

light+love
X2Go Git Admin (on behalf of the sender of this mail)

---
commit 7a76b291ed589775ee5d84c34b677fd621ce6d11
Author: Mihai Moldovan 
Date:   Thu Jan 4 06:16:51 2018 +0100

x2goserver/bin/x2go{startagent,resume-session}: use x2gogetfreeport instead 
of duplicating the same code everywhere. Fixes: #1230.

Also, rely on it returning a valid value and try at most 10 times to
fetch a usable port value, then error out and make the session startup
or resumption fail.

diff --git a/debian/changelog b/debian/changelog
index 818e823e..f8582d47 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -51,6 +51,11 @@ x2goserver (4.0.1.23-0x2go1) UNRELEASED; urgency=medium
   quotes on the lib path line.
 - x2goserver/bin/x2goresume-session: properly randomize first port, just
   like in x2gostartagent.
+- x2goserver/bin/x2go{startagent,resume-session}: use x2gogetfreeport
+  instead of duplicating the same code everywhere. Fixes: #1230. Also,
+  rely on it returning a valid value and try at most 10 times to fetch a
+  usable port value, then error out and make the session startup or
+  resumption fail.
   * x2goserver.spec:
 - RPMify x2goserver-xsession description.
 - Remove qt4 stuff, we're not using the framework here.
___
x2go-dev mailing list
x2go-dev@lists.x2go.org
https://lists.x2go.org/listinfo/x2go-dev

[X2Go-Dev] Bug#1439: Bug#1439: latest release of x2goclient for Ubuntu has dependency on hello

[Mihai Moldovan]

* On 2/15/20 4:23 PM, Ulrich Sibiller wrote:
> 1. why choose hello and not something that's on the system anyway,
> like the kernel or bin-utils or some X package?

I'm not a DD, so my answer isn't authoritative and Mike#1 can probably explain
this better, but optionaldep | hello seems to be a very common pattern in Debian
packaging. If a DD sees such a dependency, he'll recognize it and its meaning
immediately.

Depending on a package in the base system set (i.e., those marked "essential")
MIGHT be easier, but this is seems to be generally frowned upon because it makes
degrading essential-set packages to optional ones more difficult, if I recall
correctly. I've also read that normal (i.e., optional, non-core/essential)
packages should generally NOT depend upon packages in the essential-set but just
assume them to available unconditionally.


> 2. why do you want to mak x2gokdriveclient (or is it x2gokdrive?)  a
> hard dependency? Nobody needs it unless he's wants to use it. People
> can use x2go without it. So I see it as optional either way...

Hm, Mike#1 wanted it to be a hard dependency, but moving it to Recommends might
make sense after all, since other software that X2Go Client *can* make use of,
like FreeRDP2, is also not strictly necessary and merely a recommended package.

Note that Debian installs recommended packages by default (unless users
explicitly configure or tell the package manager not to do this), so user
experience wouldn't be affected by that change anyway.



Mihai



signature.asc
Description: OpenPGP digital signature
___
x2go-dev mailing list
x2go-dev@lists.x2go.org
https://lists.x2go.org/listinfo/x2go-dev

[X2Go-Dev] Bug#1439: Bug#1439: latest release of x2goclient for Ubuntu has dependency on hello

[Mihai Moldovan]

Control: tag -1 invalid
Control: close -1

* On 2/14/20 11:38 PM, Seth Galitzer wrote:
> When installing the latest update for x2goclient on Ubuntu 18.04 from 
> the x2go PPA, it has a dependency on the hello package, specifically 
> hello-traditional. The full package version is 
> 4.1.2.2-0~1913~ubuntu18.04.1. I suspect this is unintentional, but 
> filing a bug to check. Output from apt below confirms dependency.

It's fully intentional! "hello" is a very important package that ANY system
should have, however minimal!


No, seriously, it's intentional. Optional dependencies, like for
x2gokdriveclient, are most often resolved via an OR'd dependency with hello in
Debian packaging, since Debian doesn't truly have support for optional
dependencies and hello is small enough to not cause trouble. We could have made
x2gokdriveclient a Recommends: instead, but eventually it shall really be a hard
dependency, like the nxproxy one.

x2gokdriveclient needs further love (esp. regarding packaging) and is currently
only available for Debian in our upstream repositories - like I mentioned in the
release announcement. Not for Ubuntu, not for RPM-based distros, nothing else
yet. We'll eventually naturally package it, and once it's available
cross-distribution, it'll be a hard dependency. For now, I'd ask you to live
with hello as a nop-replacement. :)



Mihai



signature.asc
Description: OpenPGP digital signature
___
x2go-dev mailing list
x2go-dev@lists.x2go.org
https://lists.x2go.org/listinfo/x2go-dev

[X2Go-Dev] Bug#1425: X2Go issue (in src:x2goclient) has been marked as pending for release

[Mihai Moldovan]

tag #1425 pending
fixed #1425 4.1.2.2
thanks

Hi!

X2Go issue #1425 (src:x2goclient) reported by you has been
fixed in X2Go Git. You can see the changelog below, and you can
check the diff of the fix at:

http://code.x2go.org/gitweb?p=x2goclient.git;a=commitdiff;h=e22827f

The issue will most likely be fixed in src:x2goclient (4.1.2.2).

light+love
X2Go Git Admin (on behalf of the sender of this mail)

---
commit e22827f7afff3d85853b2d61961f773424d5e022
Author: Mihai Moldovan 
Date:   Sat Jan 25 18:15:05 2020 +0100

src/onmainwindow.cpp: stop PulseAudio from spamming logs after a client 
disconnects. Fixes: #1425.

Patch based on one submitted by Ville Salmela.

diff --git a/debian/changelog b/debian/changelog
index 78fa666..577285a 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -151,6 +151,9 @@ x2goclient (4.1.2.2-0x2go1) UNRELEASED; urgency=medium
 - Windows: Update PuTTY from 0.71 to 0.73. Fixes another round of issues
   discovered through the EU-funded bug bounty programme and other security
   problems.
+- src/onmainwindow.cpp: stop PulseAudio from spamming logs after a client
+  disconnects. Fixes: #1425. Patch based on one submitted by Ville
+  Salmela.
   * debian/control:
 + Add build-depend on pkg-config.
   * x2goclient.spec:
___
x2go-dev mailing list
x2go-dev@lists.x2go.org
https://lists.x2go.org/listinfo/x2go-dev

Re: [X2Go-Dev] question about X2Go Client + pulseaudio on Windows 10

[Mihai Moldovan]

* On 1/26/20 8:56 PM, Mihai Moldovan wrote:
> Okay, will do so later and update the contrib repository. Luckily I won't have
> to also update the dependencies.

Done.

Daniel, if you care to test, please replace the files in your Windows 10
client's pulse subdirectory with these files:
https://code.x2go.org/gitweb?p=x2goclient-contrib.git;a=tree;f=pulse/13.0-lp151.19.1_bin/pulse;h=565f0e0fcd20c45e15e9c5fea3645671607507c8;hb=HEAD


Does the issue persist with the updated version?


Providing a full new nightly build will be difficult unless I downgrade Jenkins,
which I'd prefer not to. Still waiting on the Jenkins project to provide a new,
working weekly release.



Mihai



signature.asc
Description: OpenPGP digital signature
___
x2go-dev mailing list
x2go-dev@lists.x2go.org
https://lists.x2go.org/listinfo/x2go-dev

Re: [X2Go-Dev] question about X2Go Client + pulseaudio on Windows 10

[Mihai Moldovan]

* On 1/26/20 5:15 PM, Mike DePaulo wrote:
> OBS may provide pulseaudio with newer dependencies (DLLs from
> dependent packages). I don't think it rebuilds it IIRC, just the
> download script downloads newer deps.

The pulseaudio-dependencies aggregate is unneeded and actually harmful nowadays.
Instead of copying the dependencies into your own repository via an aggregate,
you can build directly against the additional repositories. AFAIK, OBS will make
sure that it's up-to-date, including rebuilds if dependencies change.

The download script looks weird... it just fetches the git repository and
repackages it. Probably useful for testing manual builds, but it isn't used
automatically anywhere.


> Pulseaudio will never get a newer version build on OBS unless I myself
> work on it (or someone else does on their fork.)
> (If OBS supports collaborative development now on repos, I'd very much
> like to do that.)

I keep wondering about that... is X2Go really the only user of PulseAudio on
Windows? Or do the other users just stay on the old 1.0 version (whatever it
was) from 10 years ago?

But yeah, that's why I forked and updated it. OBS supports collaborative
development in general though, so we could just use one repo. I didn't mean to
do this privately. :)


> I recommend backporting the patch.

Okay, will do so later and update the contrib repository. Luckily I won't have
to also update the dependencies.



Mihai



signature.asc
Description: OpenPGP digital signature
___
x2go-dev mailing list
x2go-dev@lists.x2go.org
https://lists.x2go.org/listinfo/x2go-dev

Re: [X2Go-Dev] question about X2Go Client + pulseaudio on Windows 10

[Mihai Moldovan]

* On 1/26/20 4:15 PM, Mike DePaulo wrote:
> I'm assuming this is about the email thread "Pulseaudio issue latest Win 10."
> 
> I see that Ionic just added PulseAudio 13.0 to x2goclient-contrib.git (but not
> x2goclient.git itself yet).
> https://code.x2go.org/gitweb?p=x2goclient-contrib.git;a=commit;h=83848f5b86b5cb71598dbe0b3e56db7f753a6bd8

Yep, I haven't seen any new builds yet so decided to fork and work on it. I
build 13.0 within Leap 15.1 and got rid of the aggregate stuff that now breaks
due to the repository using multibuilds... or something like that.

The change for X2Go Client is stashed in my repo, but not pushed yet, because
Jenkins is currently broken/down. Upstream bug that I ran into without knowing
beforehand: https://issues.jenkins-ci.org/browse/JENKINS-60857

I hope that the new weekly build released today will fix that. We won't have new
builds until that's fixed. Thought about making a list post announcing that, but
given that they expect a new build today it didn't sound reasonable.


> And I see that he used the OBS to build it like I did:
> https://build.opensuse.org/project/show/home:Ionic:branches:home:mikedep333:branches:home:mkbosmans:mingw32:pulseaudio
> 
> I also found this commit that was added to the pulseaudio master branch (after
> 13.0) on 2020-01-20. It might be a fix:
> https://gitlab.freedesktop.org/pulseaudio/pulseaudio/commit/97d0eda2562af07b7514de075ddf62f9dd678e51

Oh, thanks. Backporting that shouldn't be difficult, so I guess I should do 
that?



Mihai



signature.asc
Description: OpenPGP digital signature
___
x2go-dev mailing list
x2go-dev@lists.x2go.org
https://lists.x2go.org/listinfo/x2go-dev

[X2Go-Dev] Bug#1417: Unable to find the sftp-server binary

[Mihai Moldovan]

Control: reassign -1 x2goclient 4.1.1.1-2
Control: tags -1 moreinfo


Please mention your client OS the next time around! I'm pretty sure that it's
Ubuntu 18.04/bionic based on the openssh-sftp-server package's version number,
but such information is often helpful.


> My path is as follows
> PATH=/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/snap/bin

Looks fine in general, but let's look for sftp-server...


> which sftp
> /usr/bin/sftp

Nope, sorry, useless. sftp is the sftp client binary, but X2Go Client is looking
for the sftp server binary (as part of the folder sharing/printing support).

Can you please re-run "which sftp-server"?


> i currently have sftp installed
> ii  openssh-sftp-server1:7.6p1-4ubuntu0.3

Weird.

dpkg -L openssh-sftp-server

should include both

/usr/lib/openssh/sftp-server
/usr/lib/sftp-server

Right?

/usr/lib/sftp-server should be a symlink to /usr/lib/openssh/sftp-server, which
should be a real binary.

If the files exist, run
ls -ldh /usr/lib/openssh/sftp-server /usr/lib/sftp-server


Incidentally, there *is* a bug in X2Go Client, which... looks for the wrong
binary name when using Qt 5. I managed to look for "sftp-binary" instead of
"sftp-server", which is just braindead. However, funnily, this only caused
trouble if the sftp-server binary was bundled or contained in a system path,
which shouldn't be the case. This bug should now be fixed in our nightly
packages, but it doesn't explain the problem you're experiencing.



Mihai



signature.asc
Description: OpenPGP digital signature
___
x2go-dev mailing list
x2go-dev@lists.x2go.org
https://lists.x2go.org/listinfo/x2go-dev

[X2Go-Dev] Bug#1431: Haltbt is useless...

[Mihai Moldovan]

Control: retitle -1 Extend haltbt functionality to work standalone
Control: severity -1 wishlist

> I'm using raspberry pi 4 with fresh installation of raspbian buster.
> 
> When I start x2goclient with --haltbt the shutdown button is doing nothing 
> when I clicked 100 times? Please let me know how many times should I click 
> for the button to works?

The button works like expected. You're just hold it wrong.

No, seriously, the halt button does exactly what it's supposed to do, you just
misinterpreted what it does. What the button really does is creating a single
file. This file is then interpreted and acted upon by the other scripts within a
thinclient environment.


However, I believe you're not using a thinclient environment. In that case, yes,
the halt button will do nothing useful to you.


I'm changing this issue report into a wishlist bug, because it might make sense
to extend the scope of this button to work in non-TCE modes.

This said, the amount of work required for this is huge, so I probably won't
implement it. Essentially, we'd have to figure out whether we're running inside
of a TCE or not (which is very difficult on its own, since we now have TCEs with
full desktop environment like the MATE Minidesktop variant that are not easily
distinguished from non-TCE environments) and actually initiating a system
shutdown is crazy difficult. Since a normal user can't do that (for obvious
reasons), each desktop environment pretty much has its own way of talking to a
daemon running with higher privileges (usually via dbus) that checks whether the
user is allowed to cause a system shutdown or not and executes the action if
needed. I'm not even sure if there is a standard way of doing so.



Mihai



signature.asc
Description: OpenPGP digital signature
___
x2go-dev mailing list
x2go-dev@lists.x2go.org
https://lists.x2go.org/listinfo/x2go-dev

[X2Go-Dev] Bug#1429: Bug#1429: Tilde expansion no longer performed by libssh after CVE-2019-14889

[Mihai Moldovan]

* On 12/20/19 9:44 PM, Sylvain Cuaz wrote:
> Le 20/12/2019 à 19:06, Mihai Moldovan a écrit :
>> I'll let you know when fixed nightly versions are available, though.
> 
> OK thanks

Nightly builds should incorporate the fix now.



Mihai




signature.asc
Description: OpenPGP digital signature
___
x2go-dev mailing list
x2go-dev@lists.x2go.org
https://lists.x2go.org/listinfo/x2go-dev

[X2Go-Dev] Bug#1428: X2Go issue (in src:x2goclient) has been marked as pending for release

[Mihai Moldovan]

tag #1428 pending
fixed #1428 4.1.2.2
thanks

Hello,

X2Go issue #1428 (src:x2goclient) reported by you has been
fixed in X2Go Git. You can see the changelog below, and you can
check the diff of the fix at:

http://code.x2go.org/gitweb?p=x2goclient.git;a=commitdiff;h=ce559d1

The issue will most likely be fixed in src:x2goclient (4.1.2.2).

light+love
X2Go Git Admin (on behalf of the sender of this mail)

---
commit ce559d163a943737fe4160f7233925df2eee1f9a
Author: Mihai Moldovan 
Date:   Fri Dec 20 20:27:31 2019 +0100

src/sshprocess.cpp: strip ~/, ~user{,/}, ${HOME}{,/} and $HOME{,/} from 
destination paths in scp mode. Fixes: #1428.

This was already necessary for pascp (PuTTY-based Windows solution for
Kerberos support), but newer libssh versions with the CVE-2019-14889
also interpret paths as literal strings.

diff --git a/debian/changelog b/debian/changelog
index 504d6ae..9f84281 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -135,6 +135,11 @@ x2goclient (4.1.2.2-0x2go1) UNRELEASED; urgency=medium
   sound weird first, but this behavior is consistent between all
   applications - tray icons can be clicked via either button and will
   always trigger a context menu. Let X2Go Client behave the same way.
+- src/sshprocess.cpp: strip ~/, ~user{,/}, ${HOME}{,/} and $HOME{,/} from
+  destination paths in scp mode. Fixes: #1428. This was already necessary
+  for pascp (PuTTY-based Windows solution for Kerberos support), but newer
+  libssh versions with the CVE-2019-14889 also interpret paths as literal
+  strings.
   * debian/control:
 + Add build-depend on pkg-config.
   * x2goclient.spec:
___
x2go-dev mailing list
x2go-dev@lists.x2go.org
https://lists.x2go.org/listinfo/x2go-dev

[X2Go-Dev] Bug#1429: Bug#1429: Tilde expansion no longer performed by libssh after CVE-2019-14889

[Mihai Moldovan]

Control: reassign -1 x2goclient 4.1.2.1
Control: forcemerge -1 1428

* On 12/20/19 6:21 PM, Sylvain Cuaz wrote:
> SSH key fails to be copied to the remote side because the path use a tilde, 
> so neither file sharing nor client-side printing works.
> [...]
> After using gdb I saw that ONMainWindow::exportDirs() calls 
> SshMasterConnection::copyFile() with dst="~"+uname +"/.x2go/ssh/"+dst;
> which is ultimately passed to libssh. But following CVE-2019-14889 the path 
> is now literal (quoted), see
> https://git.libssh.org/projects/libssh.git/log/src/scp.c for the libssh logs 
> and
> https://usn.ubuntu.com/4219-1/ for the ubuntu packages

Yes, I think that this change has been intentional. I'll have to fix that in
X2Go Client and I know how to do this easily to retain support for pre-patched
and patched versions.

I will, however, probably not be able to provide new release versions with that
fix (and others) for about a months.

I'll let you know when fixed nightly versions are available, though.


> As a workaround I reinstalled an old version of the libssh-4 package and the 
> bug went away.

Please don't do that OR recommend that. You're essentially now running without
the CVE fix, which is probably worse than a broken client.



Mihai



signature.asc
Description: OpenPGP digital signature
___
x2go-dev mailing list
x2go-dev@lists.x2go.org
https://lists.x2go.org/listinfo/x2go-dev

Re: [X2Go-Dev] Bug#1428: Connection failed. Cannot create remote file

[Mihai Moldovan]

* On 12/18/19 10:33 AM, Alexanderstr Miete wrote:
> Interesting. Thanks for the update. I also notice that no sound via standard
> PulseAudio (which previously worked) is transmitted to the client anymore from
> any remote machine (default port 4713, SSH port forwarding).  Is that related 
> to
> this bug here too? 
> https://bugs.launchpad.net/ubuntu/+source/libssh/+bug/1856795
> or something else that requires looking into?


Very likely, yes. We use scp to transfer some files (including the cookie file),
so if scp is broken within libssh that'll fail to work as well.



Mihai



signature.asc
Description: OpenPGP digital signature
___
x2go-dev mailing list
x2go-dev@lists.x2go.org
https://lists.x2go.org/listinfo/x2go-dev

Re: [X2Go-Dev] Bug#1428: Connection failed. Cannot create remote file

[Mihai Moldovan]

Control: forwarded -1 
https://bugs.launchpad.net/ubuntu/+source/libssh/+bug/1856795
Control: reassign -1 x2goclient 4.1.2.1
Control: close -1


* On 12/16/19 7:42 PM, Alexanderstr Miete wrote:
> Is this similar issue probably related?
> Can we narrow down the reason for this bug?
> I can reproduce it on at least 2 different remote instances of Ubuntu, 
> however I
> have only one client machine to test from at present.
> https://bugzilla.redhat.com/show_bug.cgi?id=1057871#c19

Ubuntu applied a series of patches to fix a CVE in their libssh package and
broke scp support as part of that.


Please check the attached bug report.


Nothing to do for us here, unfortunately.



Mihai



signature.asc
Description: OpenPGP digital signature
___
x2go-dev mailing list
x2go-dev@lists.x2go.org
https://lists.x2go.org/listinfo/x2go-dev

[X2Go-Dev] Bug#1418: X2Go issue (in src:x2goclient) has been marked as pending for release

[Mihai Moldovan]

tag #1418 pending
fixed #1418 4.1.2.2
thanks

Hello,

X2Go issue #1418 (src:x2goclient) reported by you has been
fixed in X2Go Git. You can see the changelog below, and you can
check the diff of the fix at:

http://code.x2go.org/gitweb?p=x2goclient.git;a=commitdiff;h=50cb6c6

The issue will most likely be fixed in src:x2goclient (4.1.2.2).

light+love
X2Go Git Admin (on behalf of the sender of this mail)

---
commit 50cb6c6fe1456c06b76ab4083f0c2784b38f5157
Author: Mihai Moldovan 
Date:   Sun Dec 1 09:54:55 2019 +0100

src/onmainwindow.cpp: also remove proxy "host:port" parsing at connect 
time. Fixes: #1418.

diff --git a/debian/changelog b/debian/changelog
index 2a51b0c..0ee9918 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -126,6 +126,8 @@ x2goclient (4.1.2.2-0x2go1) UNRELEASED; urgency=medium
   "normal" host address and this behavior clashes with IPv6 addresses. We
   COULD, theoretically, keep it, but that would require writing an
   arbitrary address parser. Too much effort for little gain.
+- src/onmainwindow.cpp: also remove proxy "host:port" parsing at connect
+  time. Fixes: #1418.
   * debian/control:
 + Add build-depend on pkg-config.
   * x2goclient.spec:
___
x2go-dev mailing list
x2go-dev@lists.x2go.org
https://lists.x2go.org/listinfo/x2go-dev

[X2Go-Dev] Bug#1401: PGP-Key is not available on keyservers for debian buster

[Mihai Moldovan]

Control: reassign wiki.x2go.org
Control: retitle -1 Update GPG key bootstrapping instructions for Debian
Control: close -1


* On 8/24/19 7:06 PM, Mihai Moldovan wrote:
> Control: reassign -1 packages.x2go.org
> 
> 
>> N: An update from such a repository cannot be done in a secure way, so
>> it is disabled by default.
> 
> The x2go-keyring package is available for Debian buster, includes the required
> key file and should work just fine.
> 
> However, newer apt versions will disallow downloading from an untrusted 
> repository.
> 
> In order to actually install the keyring package, try running something like:
> sudo apt-get --allow-unauthenticated install x2go-keyring
> 
> Afterwards, sudo apt update should not return an error again. Do not use the
> --allow-unauthenticated flag without understanding its implications.

That wasn't correct - at least not completely. --allow-unauthenticated should
work for package installations, but not for downloading repository metadata.

To allow apt to work with unauthenticated repository metadata, users would need
to use something like:
apt-get update --allow-insecure-repositories

This said: this is totally risky, now and later. Installing packages from an
unauthenticated repository doesn't give apt any chance to check the origin. A
successful Man-in-the-Middle attack is very likely in such a scenario. Worse,
even after the initial bootstrap, all subsequent operations and packages from
such a repository could still be malicious.


I've updated https://wiki.x2go.org/doku.php/wiki:repositories:debian et al with
this information, big fat warning signs and explanations.

**Users should always bootstrap with the currently valid GPG key and then
install the x2go-keyring package from the validated X2Go repository location!**


Closing up here.



Mihai



signature.asc
Description: OpenPGP digital signature
___
x2go-dev mailing list
x2go-dev@lists.x2go.org
https://lists.x2go.org/listinfo/x2go-dev

[X2Go-Dev] Bug#1401: PGP-Key is not available on keyservers for debian buster

[Mihai Moldovan]

Control: reassign -1 packages.x2go.org


> N: An update from such a repository cannot be done in a secure way, so
> it is disabled by default.

The x2go-keyring package is available for Debian buster, includes the required
key file and should work just fine.

However, newer apt versions will disallow downloading from an untrusted 
repository.

In order to actually install the keyring package, try running something like:
sudo apt-get --allow-unauthenticated install x2go-keyring

Afterwards, sudo apt update should not return an error again. Do not use the
--allow-unauthenticated flag without understanding its implications.


> sudo apt-key adv --recv-keys --keyserver keys.gnupg.net E1F958385BFE2B6E
> Executing: /tmp/apt-key-gpghome.4WhtJFIi3f/gpg.1.sh --recv-keys
> --keyserver keys.gnupg.net E1F958385BFE2B6E
> gpg: Received from key server failed: The waiting time for the
> connection has expired.

The public key is also available on keyservers. Most keyservers are still
stoned, however, from the attacks that have been carried out a few months ago
and a year ago. For more information, and why this problem is unlike to be fixed
in the first place, refer to
https://gist.github.com/rjhansen/67ab921ffb4084c865b3618d6955275f for instance.
I cannot fix public keyservers for you.

Like the message said: there was a timeout while fetching the key. It did not
say that such a key does not exist.



Mihai



signature.asc
Description: OpenPGP digital signature
___
x2go-dev mailing list
x2go-dev@lists.x2go.org
https://lists.x2go.org/listinfo/x2go-dev

[X2Go-Dev] Bug#1393: sftp-server binary not found gentoo (profile 17.1)

[Mihai Moldovan]

* On 6/18/19 3:27 PM, Lars Wendler wrote:
> IMHO you should NAK such a patch as this is definitely an issue coming
> from our 17.1 profile's new lib directory structure.
> If you commit the suggested patch, all 32bit 17.1 profile installations
> will suffer from the bug our 64bit 17.1 profile installations currently
> suffer from.

Can you elaborate on that, please? I understand that there's potential for
breakage with a compat symlink. One example would be software that is not
correctly trimmed to using lib32 instead of lib and hence trying to use the
wrong, 64-bit, directory at compile time, unless additional patching is done.

I fail to see a lot of breakage potential with the current patch I applied that
favors lib64. Let's create a matrix:

 System | 32-bit OpenSSH installed | 64-bit OpenSSH installed | [G]ood/[B]ad
+--+--+---
{32}|   X  | -|   G
{32}|   -  | X| B (nonsense)
{32}|   X  | X| B (nonsense?)
{64}|   X  | -| B (nonsense)
{64}|   -  | X|   G
{64}|   X  | X| G (nonsense?)
{32,64} |   X  | -|   G
{32,64} |   -  | X|   B
{64,32} |   X  | -|   B
{64,32} |   -  | X|   G
{64,32} |   X  | X| G (nonsense?)

The failure cases are pretty rare and mostly boil down to users messing up their
system - for instance, why would anyone install a 64-bit version of OpenSSH on a
32-bit non-multilib system? The only cases that would be bad is having a 32-bit
OpenSSH version installed on a {64,32} multilib system or a 64-bit OpenSSH
version on a {32,64} multilib system - i.e., when the installed OpenSSH version
does *not* match the primary arch. These cases should be very rare and indicate
a hosed system to begin with.

Additionally, none of these failure cases are actually fatal. A 32-bit OpenSSH
sftp-server binary should work fine on a 64-bit system. As long as we actually
find a binary, we should be mostly good to go.


> We changed the following directories on 64bit arches with the 17.1
> profile:
> 
> 17.0:
> 
> # ls -ld /lib*
> lrwxrwxrwx 1 root root5 May 17 10:24 /lib -> lib64
> drwxr-xr-x 1 root root 1174 May 17 10:26 /lib32
> drwxr-xr-x 1 root root 5078 Jun 13 18:50 /lib64
> 
> 
> 17.1:
> 
> # ls -ld /lib*
> drwxr-xr-x 1 root root 1382 May 13 22:54 /lib
> drwxr-xr-x 1 root root 5340 Jun 18 10:23 /lib64
> 
> 
> As you can see, "lib32" became "lib" and "lib" is no longer a symlink
> pointing to "lib64".

Hmm, that's just nitpicking maybe and too late for any change now that the
profile went on to be stable, but I don't get why lib32 was renamed to lib.
Wouldn't it have been better to just keep lib32 and lib64 around (which
describes both directories's purpose vividly) and just remove the compat
symlink? Just using "lib" is ambiguous and can be confusing.


> My suggestion is to let the Gentoo package maintainers handle this in
> the affected x2go package's ebuild files. We have a function called
> "get_libdir" that can be used with sed to set the correct lib dir
> name in the affected code.

I could implement a Makefile variable that is being passed down via CFLAGS (no
sed hackery) and add it as the first option. I'd like to keep the fallback list,
though. Not sure if that would actually be really useful to anyone, though.



Mihai

[0] {primary arch,secondary arch}



signature.asc
Description: OpenPGP digital signature
___
x2go-dev mailing list
x2go-dev@lists.x2go.org
https://lists.x2go.org/listinfo/x2go-dev

[X2Go-Dev] Bug#1320: X2Go issue (in src:x2goclient) has been marked as pending for release

[Mihai Moldovan]

tag #1320 pending
fixed #1320 4.1.2.2
thanks

Hello,

X2Go issue #1320 (src:x2goclient) reported by you has been
fixed in X2Go Git. You can see the changelog below, and you can
check the diff of the fix at:

http://code.x2go.org/gitweb?p=x2goclient.git;a=commitdiff;h=08d33b3

The issue will most likely be fixed in src:x2goclient (4.1.2.2).

light+love
X2Go Git Admin (on behalf of the sender of this mail)

---
commit 08d33b30a625710cdd019ea6868dd11fb787f964
Author: Mihai Moldovan 
Date:   Tue Jun 18 12:10:55 2019 +0200

debian/changelog: bug #1320 should be fixed for good, so marking as 
resolved.

diff --git a/debian/changelog b/debian/changelog
index ed1b3ab..dd113a6 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -70,7 +70,7 @@ x2goclient (4.1.2.2-0x2go1) UNRELEASED; urgency=medium
 - x2goclient.pro: fix libssh_threads logic again. Ubuntu Bionic/18.04
   ships a pre-release version of 0.8.0, which is tagged as that version,
   but really based upon 0.7.x and still has/needs a libssh_threads
-  library. Big "Wat?" to you, Canonical.
+  library. Big "Wat?" to you, Canonical. Fixes: #1320.
 - src/x2goclient.cpp: fix array length calculation.
 - Windows: Update PuTTY from 0.70 to 0.71. Fixes quite a list of issues
   discovered through the EU-funded bug bounty programme. Not all are
___
x2go-dev mailing list
x2go-dev@lists.x2go.org
https://lists.x2go.org/listinfo/x2go-dev

[X2Go-Dev] Bug#1347: X2go ERROR 31 on NixOS

[Mihai Moldovan]

We expect to find the sftp-server binary in a specific set of directories
(additionally to $PATH).

For NixOS, I added /run/current-system/sw/bin at some point. If you setup a
special environment, i.e., creating something like /run/nixos.x2goclient/
instead of the default current-system name, I'm afraid you'll have to patch X2Go
Client yourself.

Alternatively, is there any way to detect what directory SHALL be used? We can't
and shouldn't scan for all directories under /run, since even if one contains
the binary we're searching for, we won't know if it is the "system snapshot"
that the user INTENDED to use. However, maybe NixOS sets up a special
environment variable we could use for that - and replace the hardcoded
current-system string with the content of the env variable.



Mihai



signature.asc
Description: OpenPGP digital signature
___
x2go-dev mailing list
x2go-dev@lists.x2go.org
https://lists.x2go.org/listinfo/x2go-dev

[X2Go-Dev] Bug#1356: Unable to find the sftp-server binary

[Mihai Moldovan]

Something's very odd here.

/usr/lib/openssh is Debian's and Ubuntu's default directory for sftp-server and
already included in our client code.


Are you really positive, that the binary is *there*? If yes, what does ls -ldh
/usr/lib/openssh/sftp-server say?



Mihai



signature.asc
Description: OpenPGP digital signature
___
x2go-dev mailing list
x2go-dev@lists.x2go.org
https://lists.x2go.org/listinfo/x2go-dev

[X2Go-Dev] Bug#340: x2go fails under Ubuntu 13.10

[Mihai Moldovan]

Control: close -1


Very old issue, no follow-ups, distribution long unsupported. Closing.

If the problem still persists, please re-open.



Mihai



signature.asc
Description: OpenPGP digital signature
___
x2go-dev mailing list
x2go-dev@lists.x2go.org
https://lists.x2go.org/listinfo/x2go-dev

[X2Go-Dev] Bug#1393: X2Go issue (in src:x2goclient) has been marked as pending for release

[Mihai Moldovan]

tag #1393 pending
fixed #1393 4.1.2.2
thanks

Hello,

X2Go issue #1393 (src:x2goclient) reported by you has been
fixed in X2Go Git. You can see the changelog below, and you can
check the diff of the fix at:

http://code.x2go.org/gitweb?p=x2goclient.git;a=commitdiff;h=567223f

The issue will most likely be fixed in src:x2goclient (4.1.2.2).

light+love
X2Go Git Admin (on behalf of the sender of this mail)

---
commit 567223f5b55fb0398322f01cb0f158da6eb2a524
Author: Mihai Moldovan 
Date:   Tue Jun 18 11:38:29 2019 +0200

src/onmainwindow.cpp: add (and prefer) non-compat-symlink scp server 
location for 64-bit-based Gentoo distros (17.1+ profiles).

Fixes: #1393.

diff --git a/debian/changelog b/debian/changelog
index 284692b..ed1b3ab 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -102,6 +102,9 @@ x2goclient (4.1.2.2-0x2go1) UNRELEASED; urgency=medium
   version available in EPEL 6.
 - src/onmainwindow.cpp: unbreak builds by fixing syntax error.
 - src/onmainwindow.cpp: also unbreak old EPEL 6 builds.
+- src/onmainwindow.cpp: add (and prefer) non-compat-symlink scp server
+  location for 64-bit-based Gentoo distros (17.1+ profiles). Fixes:
+  #1393.
   * debian/control:
 + Add build-depend on pkg-config.
   * x2goclient.spec:
___
x2go-dev mailing list
x2go-dev@lists.x2go.org
https://lists.x2go.org/listinfo/x2go-dev

[X2Go-Dev] Bug#1393: Bug#1393: sftp-server binary not found gentoo (profile 17.1)

[Mihai Moldovan]

Control: reassign -1 x2goclient

* On 6/18/19 9:12 AM, Tobias Ehrig wrote:
> Package: net-misc/x2goclient
> Version: 4.1.2.1
> 
> On Gentoo (eselect profile 17.1) the x2goclient can't find the binary
> sftp-server which is located at
> 
> /usr/lib64/misc/sftp-server
> 
> 
> Here is a patch

I was inclined to NAK this at first.

/usr/lib on a multilib Gentoo system is typically a symlink to /usr/lib64, while
on non-multilib systems, as far as I remember, it's just a normal directory
containing all library files.

The entry containing /usr/lib/misc should hence cover your use case as well. Did
the 17.1 profile remove the /usr/lib symlink? I'm currently still on 17.0, but
it looks like the whole point of 17.1 is to remove the compat symlink, so you
seem to be on the right track.


I think I'll apply a slightly modified patch that favors /usr/lib64/misc instead
(mostly because that's the more common arch now, we want to avoid calling 32-bit
binaries on 64-bit systems even if they are installed and it's highly unlikely
to have a 32-64-bit multilib system [i.e., main system 32-bit, with 64-bit as an
additional architecture]).



Mihai



signature.asc
Description: OpenPGP digital signature
___
x2go-dev mailing list
x2go-dev@lists.x2go.org
https://lists.x2go.org/listinfo/x2go-dev

[X2Go-Dev] Bug#1388: X2Go issue (in src:x2goserver) has been marked as pending for release

[Mihai Moldovan]

tag #1388 pending
fixed #1388 4.1.0.4
thanks

Hello,

X2Go issue #1388 (src:x2goserver) reported by you has been
fixed in X2Go Git. You can see the changelog below, and you can
check the diff of the fix at:

http://code.x2go.org/gitweb?p=x2goserver.git;a=commitdiff;h=56bc3bf

The issue will most likely be fixed in src:x2goserver (4.1.0.4).

light+love
X2Go Git Admin (on behalf of the sender of this mail)

---
commit 56bc3bf6626d193891a68085fbdf9c82f59e0986
Author: Ulrich Sibiller 
Date:   Sun Jun 16 21:44:24 2019 +0200

x2goserver-x2goagent/etc/keystrokes.cfg: sync with nx-libs 3.5.99.20.

Previous version was broken and incomplete. Fixes: #1388.

diff --git a/debian/changelog b/debian/changelog
index 243998d..6ee1067 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -105,6 +105,11 @@ x2goserver (4.1.0.4-0x2go1.1) UNRELEASED; urgency=medium
   [ Tom Ruzicka ]
   * debian/po: Add Czech debconf translation.
 
+  [ Ulrich Sibiller ]
+  * New upstream version (4.1.0.4):
+- x2goserver-x2goagent/etc/keystrokes.cfg: sync with nx-libs 3.5.99.20.
+  Previous version was broken and incomplete. Fixes: #1388.
+
  -- Mike Gabriel   Mon, 14 Jan 2019 16:33:04 
+0100
 
 x2goserver (4.1.0.3-0x2go1) unstable; urgency=medium
___
x2go-dev mailing list
x2go-dev@lists.x2go.org
https://lists.x2go.org/listinfo/x2go-dev

Re: [X2Go-Dev] Bug in sshproxy handling

[Mihai Moldovan]

* On 5/17/19 10:51 PM, Ulrich Sibiller wrote:
> On Fri, May 17, 2019 at 9:31 PM Ulrich Sibiller
>  wrote:
>> Alternatively we could add a hack: if the proxy hostname has some
>> special form, e.g. "!hostname", that very check will be skipped. As
>> proxy and normal hosts are both controlled via the same code in
>> SshmasterConnection this way the user could configure that for both
>> connections independently.
> 
> I have just implemented that, see attached patch 0001. It makes my
> setup work.  What do you think of this approach?

Originally, I thought that this would conflict with ssh_config support (because
such host names need not be valid DNS names), but I guess it's fine, since the
characters *, ?, "," and ! are special in this context and used for pattern
matching, so they cannot be used in such host names directly. Since ! is part of
that set, I guess we're free to use it for such a purpose.

Applied.


> While doing that I also noticed that checkLogin() is missing some
> cleanup code, see attached patch 0002.

Applied that one, too.



Mihai



signature.asc
Description: OpenPGP digital signature
___
x2go-dev mailing list
x2go-dev@lists.x2go.org
https://lists.x2go.org/listinfo/x2go-dev

Re: [X2Go-Dev] Fedora X2Go repos down?

[Mihai Moldovan]

* On 6/6/19 7:52 PM, Robert Kudyba wrote:
> We're still seeing:
> 
> Failed to synchronize cache for repo 'x2go-nightly-fedora'
> Failed to synchronize cache for repo 'x2go-extras-fedora'
> Ignoring repositories: x2go-nightly-fedora, x2go-extras-fedora
> 
> Does that mean we have to import the new certificate?

Likely not. What Fedora version are you referring to? If it's 30, we don't have
packages for that yet.



Mihai




signature.asc
Description: OpenPGP digital signature
___
x2go-dev mailing list
x2go-dev@lists.x2go.org
https://lists.x2go.org/listinfo/x2go-dev

Re: [X2Go-Dev] Fedora X2Go repos down?

[Mihai Moldovan]

* On 5/31/19 4:15 AM, Robert Kudyba wrote:
> Been seeing these errors from def update for the past few nights:
> 
> Failed to synchronize cache for repo 'x2go-nightly-fedora'
> Failed to synchronize cache for repo 'x2go-extras-fedora'
> Ignoring repositories: x2go-nightly-fedora, x2go-extras-fedora

Turns out it was a bash issue. Older versions (for instance 4.3 as used on
Ubunto 16.04 LTS) of bash don't support quotes in arithmetic expressions (or at
least not very well), while newer versions (4.4 on Debian Stretch) don't seem to
have any problem with that.

The newest, working certificate should valid from 06/02/2019 and have the
SHA256/SHA1 fingerprints
E4:48:B2:AD:8A:D1:D4:B7:35:D3:93:88:DE:93:C2:A1:0B:D2:24:93:3C:03:2F:6D:BA:23:9A:AC:14:89:21:A6
/ 64:D4:B9:8F:04:0A:51:D8:DD:F6:15:2D:09:F0:ED:2F:9B:68:4F:4E.

That *doesn't* apply to wiki.x2go.org (and friends), which does have a different
certificate.



Mihai





signature.asc
Description: OpenPGP digital signature
___
x2go-dev mailing list
x2go-dev@lists.x2go.org
https://lists.x2go.org/listinfo/x2go-dev

Re: [X2Go-Dev] Fedora X2Go repos down?

[Mihai Moldovan]

* On 5/31/19 4:15 AM, Robert Kudyba wrote:
> Been seeing these errors from def update for the past few nights:
> 
> Failed to synchronize cache for repo 'x2go-nightly-fedora'
> Failed to synchronize cache for repo 'x2go-extras-fedora'
> Ignoring repositories: x2go-nightly-fedora, x2go-extras-fedora

All repos seem to be down. SSL/TLS issue. I'll post more information later.


Mihai




signature.asc
Description: OpenPGP digital signature
___
x2go-dev mailing list
x2go-dev@lists.x2go.org
https://lists.x2go.org/listinfo/x2go-dev

Re: [X2Go-Dev] Pull-Request?

[Mihai Moldovan]

* On 4/30/19 7:40 PM, Ulrich Sibiller wrote:
> I can access the git repos on code.x2go.org. But I have not found
> anything that describes the pull request/review process. So where
> should I send pull-requests for x2go-server?

The usual process is to create new bug reports for the respective component and
include/attach the patches in your report. If possible, please also use the
"Tags: +patch" pseudo-header.



Mihai



signature.asc
Description: OpenPGP digital signature
___
x2go-dev mailing list
x2go-dev@lists.x2go.org
https://lists.x2go.org/listinfo/x2go-dev

Re: [X2Go-Dev] Arithmetic exception error reading variable: Division by zero git20190114.1758

[Mihai Moldovan]

* On 3/25/19 2:10 PM, Ulrich Sibiller wrote:
> For testing you could try without ssh-agent or with the one of the current 
> openssh.

Sure, that's the quickest workaround... I just switched to no-agent auth for
testing.

Naturally, though, I wasn't able to reproduce the problem with the current
master version. Everything was working fine as far as the keyboard was 
concerned.

It might be related to that commit, but I don't know. ctrl->num_groups is
obviously zero in XkbAdjustGroup()/xkbUtils.c, but I have no idea what that
actually means. The code in question does look a bit shady (for instance, it
checks for group >= ctrls->num_groups and later might set group %=
ctrls->num_groups, which obviously is a bad idea if both group and
ctrls->num_groups is zero, but I have the suspicion that that should never have
been the case in the first place.

I don't know what "groups" are in this context neither.


I somehow doubt that commit caused the problem, though. If the clone mechanism
works fine, that change shouldn't cause any problems. There's probably no harm
in cloning the config, even though we later sync up using xmodmap (other than a
race condition, i.e., there MIGHT be a problem if we first sync up using xmodmap
and then nxagent changes the whole keyboard settings again).


Seems to be yet another weird problem that can only be reproduced with user
accounts from NIS, but I have no idea why that might be. As far as I remember,
Roberts home directories are not even coming via NFS so the home dir should be
available at the time nxagent/x2goagent starts and - in that case - tries to
block keyboard file creation by making a directory. However,
nx-libs-3.5.99.18-0.0build1.0.git20190208.3237.heuler.fc29.x86_64 is quite old
and I recently synced the master branch up with Arctica Project's master branch
again, which means that it has 3.5.99.19 + the last two commits on top of it.
Maybe it's worthwhile to retest with that.


I'm wary of releasing 3.5.99.19 to X2Go land, though, since I did notice a
different problem in my test of an XFCE session on a Devuan Unstable machine:
for some reason I didn't have xfce4-terminal installed and the default terminal
application was set to qterminal. That started up, but only worked for a few
seconds, after which it froze up. x2goagent/nxagent used 100 % of one CPU thread
at that point and even after killing qterminal it continued to do so for a few
minutes, after which it settled down with occasional 100 % CPU spikes (but it
does that without having ever started qterminal, too, so I won't worry about it.
My machine's test CPU is a pretty bad one - Intel Atom 1.8 GHs).

Hopefully that's not a general problem with Qt5 applications?



Mihai



signature.asc
Description: OpenPGP digital signature
___
x2go-dev mailing list
x2go-dev@lists.x2go.org
https://lists.x2go.org/listinfo/x2go-dev

Re: [X2Go-Dev] Arithmetic exception error reading variable: Division by zero git20190114.1758

[Mihai Moldovan]

* On 3/14/19 3:56 PM, Ulrich Sibiller wrote:
> So chances are I introduced a problem here with this nxagent patch
> 522106e207e7230da5e62fb88f2e47742fdf1b21. What do you think, Mihai?
> Can you reproduce the crash?

Turns out that I cannot test this right now.

libssh doesn't let me connect to my test server in question because the
ssh-agent is too old and doesn't support the newer signature algorithms libssh
and the remote OpenSSH server agree on. Looks like I have to fix libssh first...



Mihai



signature.asc
Description: OpenPGP digital signature
___
x2go-dev mailing list
x2go-dev@lists.x2go.org
https://lists.x2go.org/listinfo/x2go-dev

Re: [X2Go-Dev] Bug#1376: Arithmetic exception error reading variable: Division by zero git20190114.1758

[Mihai Moldovan]

* On 3/14/19 2:20 PM, Robert Kudyba wrote:
> I'm not seeing the Keyboard/Configure keyboard settings in a Mac like I do on
> Windows. Is it hidden in some sub-menu?

It's not available on macOS at all, since macOS is very special. The keyboard
settings are synchronized using an xmodmap timer, the X.Org rules are not
touched at all. Were they, stuff would just blow up.

This is not a limitation of X2Go, but the way the X11/Quartz keyboard
synchronization works with XQuartz for some reason. It's always set to
pc104/us/null/null (or some variant of this), even if the actual layout is
something entirely different.



Mihai




signature.asc
Description: OpenPGP digital signature
___
x2go-dev mailing list
x2go-dev@lists.x2go.org
https://lists.x2go.org/listinfo/x2go-dev

Re: [X2Go-Dev] Update for libssh-4

[Mihai Moldovan]

* On 11/20/18 8:01 PM, Ulrich Sibiller wrote:
> So I am really astounded that there are
> problems with Debian packages.

There aren't any problems with released packages. So far, only nightly packages
for newer/unstable distro versions were affected.


The problem is that stretch-backports has a newer version of libssh which is
incompatible to the old one (well, more or less, definitely shipping one library
less), so X2Go Client needs to be rebuilt.


We're not building with backports enabled, so even a new version of X2Go Client
won't fix this issue for those users that pull in libssh through
stable-backports. Since this is a build-time check and feature, the only way to
make this work correctly is to rebuild X2Go Client from source (after the next
release, anyway).



Mihai



signature.asc
Description: OpenPGP digital signature
___
x2go-dev mailing list
x2go-dev@lists.x2go.org
https://lists.x2go.org/listinfo/x2go-dev

[X2Go-Dev] Bug#1325: X2Go issue (in src:x2goserver) has been marked as pending for release

[Mihai Moldovan]

tag #1325 pending
fixed #1325 4.1.0.3
thanks

Hello,

X2Go issue #1325 (src:x2goserver) reported by you has been
fixed in X2Go Git. You can see the changelog below, and you can
check the diff of the fix at:

http://code.x2go.org/gitweb?p=x2goserver.git;a=commitdiff;h=a8b6e14

The issue will most likely be fixed in src:x2goserver (4.1.0.3).

light+love
X2Go Git Admin (on behalf of the sender of this mail)

---
commit a8b6e149c34d7de43aa5d50299851d7749548b3b
Author: Mihai Moldovan 
Date:   Thu Nov 22 09:43:47 2018 +0100

x2goserver-x2goagent/etc/x2goagent.options: re-enable BIG-REQUESTS; newer 
nx-libs versions (3.5.99.17+) should handle this much better. Fixes: #1325. 
Fixes: #1321.

diff --git a/debian/changelog b/debian/changelog
index bc9e1d6..c1c3fa4 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -72,6 +72,9 @@ x2goserver (4.1.0.3-0x2go1) UNRELEASED; urgency=medium
 - x2goserver/bin/x2goversion: more curly braces, quotes etc.
 - x2goserver/bin/x2gostartagent: use single quotes instead of double
   quotes for literal strings.
+- x2goserver-x2goagent/etc/x2goagent.options: re-enable BIG-REQUESTS;
+  newer nx-libs versions (3.5.99.17+) should handle this much better.
+  Fixes: #1325. Fixes: #1321.
   * x2goserver.spec:
 + Pull in openSUSE-release manually on OpenSuSE Tumbleweed to work around
   a bug.
___
x2go-dev mailing list
x2go-dev@lists.x2go.org
https://lists.x2go.org/listinfo/x2go-dev

[X2Go-Dev] Upcoming Deprecation of EOL Distributions

[Mihai Moldovan]

Hi

In order to lower resource stress when building packages, I plan to deprecate
support for distributions that have reached End Of Life on December 31th 2018.


This includes the following distro versions:

- Fedora
  o 26
  o 27
- OpenSuSE
  o 42.1
  o 42.2
- SLES
  o 12.0

Ubuntu builds are ceased automatically after upstream deprecation (minus special
exceptions).


SLES 12.0 builds will be replaced by SLES 12.3 (12 SP3) builds, since SLE 12.0
has long been deprecated and newer versions include proper Qt5 support, which
the initial version lacked.


After deprecation, no new builds will be published and existing builds will be
moved to the archive repositories to discourage users from installing
unmaintained software.



Mihai



signature.asc
Description: OpenPGP digital signature
___
x2go-dev mailing list
x2go-dev@lists.x2go.org
https://lists.x2go.org/listinfo/x2go-dev

[X2Go-Dev] Bug#1307: X2Go issue (in src:x2goclient) has been marked as pending for release

[Mihai Moldovan]

tag #1307 pending
fixed #1307 4.1.2.2
thanks

Hello,

X2Go issue #1307 (src:x2goclient) reported by you has been
fixed in X2Go Git. You can see the changelog below, and you can
check the diff of the fix at:

http://code.x2go.org/gitweb?p=x2goclient.git;a=commitdiff;h=2579c87

The issue will most likely be fixed in src:x2goclient (4.1.2.2).

light+love
X2Go Git Admin (on behalf of the sender of this mail)

---
commit 2579c8758dede265b9473d2afe0984348fbcedb8
Author: Mihai Moldovan 
Date:   Thu Jul 5 08:53:48 2018 +0200

debian/changelog: add bug closure for #1307.

diff --git a/debian/changelog b/debian/changelog
index 1311d0a..3cd2915 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -7,7 +7,7 @@ x2goclient (4.1.2.2-0x2go1) UNRELEASED; urgency=medium
   [ Mihai Moldovan ]
   * New upstream version (4.1.2.2):
 - src/printwidget.cpp: add QButtonGroup include, fixes compile errors with
-  Qt 5.11+.
+  Qt 5.11+. Fixes: #1307.
 
  -- X2Go Release Manager   Tue, 26 Jun 2018 00:39:28 +0200
 
___
x2go-dev mailing list
x2go-dev@lists.x2go.org
https://lists.x2go.org/listinfo/x2go-dev

[X2Go-Dev] Bug#1156: X2Go issue (in src:x2goclient) has been marked as pending for release

[Mihai Moldovan]

tag #1156 pending
fixed #1156 4.1.2.0
thanks

Hello,

X2Go issue #1156 (src:x2goclient) reported by you has been
fixed in X2Go Git. You can see the changelog below, and you can
check the diff of the fix at:

http://code.x2go.org/gitweb?p=x2goclient.git;a=commitdiff;h=9c1ca41

The issue will most likely be fixed in src:x2goclient (4.1.2.0).

light+love
X2Go Git Admin (on behalf of the sender of this mail)

---
commit 9c1ca414da2698d51213382475b29e6a1d1e9b6a
Author: Mihai Moldovan 
Date:   Fri Jun 15 11:59:05 2018 +0200

src/onmainwindow.cpp: disable private host key permissions check in OpenSSH 
Server on Windows. Fixes: #1156.

diff --git a/debian/changelog b/debian/changelog
index e70ea70..078b072 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -98,6 +98,8 @@ x2goclient (4.1.2.0-0x2go1) UNRELEASED; urgency=medium
 - copy-deps-win32.bat: update to 20180615-1 Cygwin bundle, shipping with
   a further modified OpenSSH Server version at 7.7p1-1-x2go1 and without
   chgrp.
+- src/onmainwindow.cpp: disable private host key permissions check in
+  OpenSSH Server on Windows. Fixes: #1156.
   * x2goclient.spec:
 - Remove plugin references.
   * debian/rules:
___
x2go-dev mailing list
x2go-dev@lists.x2go.org
https://lists.x2go.org/listinfo/x2go-dev

[X2Go-Dev] Bug#1156: X2Go issue (in src:x2goclient) has been marked as pending for release

[Mihai Moldovan]

tag #1156 pending
fixed #1156 4.1.2.0
thanks

Hello,

X2Go issue #1156 (src:x2goclient) reported by you has been
fixed in X2Go Git. You can see the changelog below, and you can
check the diff of the fix at:

http://code.x2go.org/gitweb?p=x2goclient.git;a=commitdiff;h=f22fd19

The issue will most likely be fixed in src:x2goclient (4.1.2.0).

light+love
X2Go Git Admin (on behalf of the sender of this mail)

---
commit f22fd1957a8b16a80588451cc3e0dab26c2d5c8b
Author: Mihai Moldovan 
Date:   Thu Jun 14 04:11:15 2018 +0200

src/onmainwindow.cpp: hook-in chgrp for ~/.x2go/etc on Windows platforms to 
work around a Cygwin permissions bug. Fixes: #1156.

diff --git a/debian/changelog b/debian/changelog
index da8f2c1..fe06805 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -86,6 +86,8 @@ x2goclient (4.1.2.0-0x2go1) UNRELEASED; urgency=medium
   Server startup functions.
 - src/pulsemanager.cpp: use QByteArray's constData () instead of data (),
   since we'll never modify the data anyway.
+- src/onmainwindow.cpp: hook-in chgrp for ~/.x2go/etc on Windows platforms
+  to work around a Cygwin permissions bug. Fixes: #1156.
   * x2goclient.spec:
 - Remove plugin references.
   * debian/rules:
___
x2go-dev mailing list
x2go-dev@lists.x2go.org
https://lists.x2go.org/listinfo/x2go-dev

[X2Go-Dev] Bug#1226: x2goclient for Mac OS immediately throws error regarding "PulseAudio verison number" then crashes

[Mihai Moldovan]

* On 10/26/2017 07:48 PM, Stefan Baur wrote:
> Am 26.10.2017 um 19:43 schrieb Sean Hooten:
>> First output I got from that command was:
>> ls: /Users/shooten/.config/pulse//daemon.conf: Permission denied
>>
>> So I opened a new shell as root and attempted the same command, but
>> apparently the directory
>> /Users/shooten/.config/pulse
> 
> And what does
> 
> ls -ldh /Users/shooten/.config
> 
> say?
> 
> Maybe you accidentally removed write or directory entry permissions to
> ".config"?

Ping?


Mihai




signature.asc
Description: OpenPGP digital signature
___
x2go-dev mailing list
x2go-dev@lists.x2go.org
https://lists.x2go.org/listinfo/x2go-dev

[X2Go-Dev] Bug#1301: ubuntu ppa x2goserver broken

[Mihai Moldovan]

Control: reassign -1 nx-libs 3.5.99.14
Control: tag -1 wontfix
Control: close -1

Closing, since this was caused by the user exporting LD_LIBRARY_PATH with a
system path containing the "real" libX11 file.



Mihai



signature.asc
Description: OpenPGP digital signature
___
x2go-dev mailing list
x2go-dev@lists.x2go.org
https://lists.x2go.org/listinfo/x2go-dev

Re: [X2Go-Dev] Different behavior of X2Go Client from Desktop and TCE

[Mihai Moldovan]

* On 05/16/2018 10:22 PM, Stefan Baur wrote:
> Does that mean it would also work with older NX-Lib versions, like 3.5.0.33?

No. That's a new feature that has been introduced in the 3.5.99.x line only.



Mihai



signature.asc
Description: OpenPGP digital signature
___
x2go-dev mailing list
x2go-dev@lists.x2go.org
https://lists.x2go.org/listinfo/x2go-dev

Re: [X2Go-Dev] Effective username not correct in Session ID because of plus sign in user names (Windows AD / Samba4)

[Mihai Moldovan]

* On 03/20/2018 10:29 AM, j.ro...@nederlandlive.nl wrote:
> Hi All,
> 
> I've encountered a problem with the latest ppa packages (stable:
> 4.1.0.0-0~1517~ubuntu14.04.1).
> My system runs a samba4 server and my users are named:
> 
> "DOMAIN+user" (the plus sign is a literal plus / AD style).
> 
> When the session ID for x2go is formed/created the plus sign is stripped
> from the user name apparently.
> This gives (at least) a problem when changing the state in de DB:
> 
> In /usr/share/perl5/X2Go/Server/DB/SQLite3.pm line 403 an attempt is
> made to get the 'effective' user name, but that will never happen
> because of the stripped out plus sign. As a consequence sessions are not
> terminated/suspended/etc..
> For now i've made it so my $effective_user == $realuser, but this breaks
> desktop sharing functionality.
> 
> Sort of the same bug was present in earlier versions, but was fixed
> later on.
> I've tried to find the script/code where the session id is formed, but
> could not find it yet.
> I guess that's where this should be fixed though.
> 
> Is it possible to get support for these style of user names?!

There are also problems with backslashes and other characters in user names.

They originate from a new sanitization feature in X2Go Server that drops
characters not deemed suitable for a username.

A plus sign might not be part of the allowed character set, which would explain
this behavior.

We've had such an discussion before and I'm still not completely sure what to do
with it. It sounded like sanitization was a good idea at first, but seeing it
causes problems often (well, for AD and NIS users only most of the time), maybe
I should rework this and just accept any input.


Not sure if that is a smart idea, though.



Mihai




signature.asc
Description: OpenPGP digital signature
___
x2go-dev mailing list
x2go-dev@lists.x2go.org
https://lists.x2go.org/listinfo/x2go-dev

Re: [X2Go-Dev] x2goclient-4.1.1.0 compile fails at link stage with undefined references

[Mihai Moldovan]

* On 02/19/2018 07:12 AM, John Frankish wrote:
>>> On linux
>>> Which lib provides the directRDP function?
>>>
>> There is no library. That's all Linux-#ifdef'd code. But given that the
>> implementation section is referencing for instance the
>> SessionWidget::directRDP(bool, bool) signal, it should work.
>>
>> From the excerpt you've shown, I have no idea what you invoked and how so. I
>> also have no idea if the moc binary has been executed on relevant source 
>> files
>> and generated metaobjects code. If possible, please always paste 
>> *everything*,
>> not just the part that you may deem interesting.
>>
> Build log from "make V=1" attached.

There was a bug in the source code in the sense that it did connect two
unavailable signals on non-Linux platforms.

In your case, I observe that:

  - You seem to be using a self-compiled version staged into /usr/local/.
  - You have ANOTHER self-compiled version in /tmp/cloop/qt-4.x-dev which is
used as the mkspec location.
  - Qt does not detect that you're using the linux-g++ mkspec which would make
x2goclient.pro add -D__linux__ to the compile flags. I am not sure why we
even have this, given that the compiler should set such a macro. From the
commit log, it looks like this is needed so that moc expands macros such as
Q_OS_LINUX, which is a known bug in Qt, c.f.,
https://bugreports.qt.io/browse/QTBUG-34593 and will probably never be fixed
for Qt 4.8 since it's EOL.

*Why* are you not using the Qt version as provided by your package manager? Why
are you rolling your own solution, if you are incapable of debugging and
handling such issues yourself?

The path /tmp/tcloop/qt-4.x-dev/usr/local/share/qt4/mkspecs/linux-g++ might not
even exist any longer. Who knows what compiler spec qmake falls back to.

I fixed the issue I found in x2goclient via
https://code.x2go.org/gitweb?p=x2goclient.git;a=commitdiff;h=1f383a9029ba1d1323c370c0deaaba379097c960

This likely won't help you, though, since the definitions as seen by your meta
object compiler (moc) and C++ compiler (g++) still won't match up.


Package maintainers normally go a great length to make sure that the packages
they build work correctly and handle bug reports. Subverting this by rolling
your own version is not as smart an idea as you might think it is.


Looking around, you seem to be using tinycorelinux, which stages non-core
software to /usr/local. That hints that it was installed there by a package
manager, but doesn't explain why qmake is trying to read spec files from
/tmp/tcloop/qt-4.x-dev. There's definitely something odd with your system or the
way these packages have been built.


Sorry, this is not a problem X2Go Client, but rather with your Qt libraries.



Mihai



signature.asc
Description: OpenPGP digital signature
___
x2go-dev mailing list
x2go-dev@lists.x2go.org
https://lists.x2go.org/listinfo/x2go-dev

Re: [X2Go-Dev] repository: broken dependencies since today

[Mihai Moldovan]

* On 03/02/2018 05:48 PM, ITM Administrators wrote:
> since this is a packaging bug and not a bug in the code, I wasn't sure if a 
> bug
> report should be filled. Instead, I use this mailing list.
> 
> We are using
> 
> deb http://packages.x2go.org/debian stretch main
> 
> as source to get updates for x2go under Debian 9.0 "Stretch". Since today, the
> dependencies are not correct in this repository:
> 
> The package nxagent was updated today to version
> 2:3.5.99.14-0+git20180302.2954+9.main.1 but this is incompatible with the
> package x2goagent (as of version 2:3.5.0.33-0x2go1+git20180204.776+9.main.1):
> 
> The following packages have unmet dependencies:
>  x2goagent : Depends: nxagent (< 2:3.5.0.33-0x2go1+git20180204.776+9.main.1.1)
> E: Broken packages
> 
> In order to rule out a temporary dependency issue during upload of new 
> packages,
> we waited for 6 hours. The problem still persists.

You should have likely waited a bit longer.

If I remember correctly the new X2Go Server packages hit the repository a few
hours later.


You cannot reproduce that now, is that correct?



Mihai




signature.asc
Description: OpenPGP digital signature
___
x2go-dev mailing list
x2go-dev@lists.x2go.org
https://lists.x2go.org/listinfo/x2go-dev

[X2Go-Dev] Bug#1267: Can't connect after jessie update

[Mihai Moldovan]

Control: reassign -1 packages.x2go.org
Control: close -1

* On 03/02/2018 10:13 PM, Christophe Massez wrote:
> Package: x2goserver
> Version: 4.0.1.22-0x2go1+git20180204.1197+8.main.1
> 
> Hi all,
> 
> After upgrade of debian jessie, I can't connect with x2go.

You have been trying to upgrade at a time when new X2Go Server packages were not
available yet or otherwise upgraded only partly.

Please run apt-get update; apt-get dist-upgrade.

Does the problem persist?


Closing, since this should not be an issue any longer. If it is, we can re-open
the report.



Mihau



signature.asc
Description: OpenPGP digital signature
___
x2go-dev mailing list
x2go-dev@lists.x2go.org
https://lists.x2go.org/listinfo/x2go-dev

Re: [X2Go-Dev] x2go wiki : self-debugging instructions ?

[Mihai Moldovan]

* On 03/15/2018 03:07 PM, Manfred Amoureux wrote:
> I recorded a screen capture while trying to start a connection from another
> computer. See the link below.
> As you can see, it seems the connection gets opened but the window crashes
> immediately. I have tried from several computers (including one with Windows) 
> so
> I don't think it's a problem on the client side.

Classic pattern of https://github.com/ArcticaProject/nx-libs/issues/677

Will be fixed with the next nx-libs release, but I cannot tell when that will
be. Ideally I'd like to see more xinerama changes/fixes to make it worthwhile.


> I have attached an extract of the /var/log/syslog file these last minutes. I 
> see
> nothing that looks like an error to me. Obviously, you should be able to
> interpret it better than me.
> I have also restarted x2go (/sudo systemctl stop x2goserver.service/ and then
> /sudo systemctl start x2goserver.service/ ) after changing the
> /etc/x2go/x2goserver.conf file with logging to /debug/. That is the second 
> text
> file attached.
> 
> In it, I can see :
> Mar 15 14:51:15 ServeurITeN /usr/bin/x2gostartagent: successfully started X2Go
> Agent session with ID manfred-50-1521121872_stDXFCE_dp24
> Which means, I guess, the session was properly started.

Well, that message is an euphemism. We launched the binary, but everything that
happens after that is unknown since we immediately put the process into
background. But yeah, having it spawned nxagent is good.


> However, further on, I can also see :
> Mar 15 14:51:22 ServeurITeN x2gogetstatus: db_getstatus called, session ID:
> manfred-50-1521121872_stDXFCE_dp24, return value:
> Mar 15 14:51:22 ServeurITeN x2gocleansessions:
> manfred-50-1521121872_stDXFCE_dp24: removed from database, not updating 
> status.
> Mar 15 14:51:22 ServeurITeN x2gocleansessions:
> manfred-50-1521121872_stDXFCE_dp24: in failed state, but agent is gone, 
> forgetting.
> Is that some kind of failure ?

That indicates that x2goagent/nxagent died after starting up.


> It is also interesting to see that when I issue a /who/ command with the Linux
> Terminal , there is one extra session under my login.

Yup, X2Go uses SSH connections for everything.


> So I tried opening a x2go session with another login, which also failed but 
> with
> a different error message : "/Failed to start X2Go Agent session with ID
> formation-50-1521122343_stDXFCE_dp24. X2Go Agent terminated unexpectedly.
> Aborting session startup./" I then restarted the x2goserver.service again and
> tried again with the other user account and got the same error as for the 
> first
> user ("The connection with the remote server was shut down. Please check the
> state of your network connection.").

The first error message is weird, but explainable by the fact that the proxy was
not quick enough to connect in the first place (or something like this).

Right now, you have two options: wait for a new nx-libs release (as said,
unspecified time) or switch to the nightly/heuler repository that contains a fix
for this issue... and switch back to the stable version once the new version has
been properly released.



Mihai



signature.asc
Description: OpenPGP digital signature
___
x2go-dev mailing list
x2go-dev@lists.x2go.org
https://lists.x2go.org/listinfo/x2go-dev

Re: [X2Go-Dev] x2go wiki : self-debugging instructions ?

[Mihai Moldovan]

* On 03/15/2018 12:59 PM, Manfred Amoureux wrote:
> $ dpkg -l | grep -Ei '(x2go|nx)'
> 
> [...]

Okay, up to date and no partially installed packages or version mismatched for
that matter.

That still leaves the "crash on connect" bug if the window was started a window
different from the first one in a multi-head setup.


> Now, when I have a look at /var/log/syslog, I see this :
> Mar 15 12:55:02 ServeurITeN x2golistsessions_sql: executing external command
> ,,x2gopath'' with args: libexec
> [...]
> 
> /ServeurITeN/ is the name of the machine. I have not been trying to connect 
> with
> x2go to this machine since the last reboot. Does it look like it's trying to
> execute something that fails constantly ?

Nope, it's just the cleanup process that loops through all session data and
syncs up or terminates stale session as necessary.

It's spammy (hence why I said "a lot of data"), but perfectly normal.

You'll have to make an actual connection attempt to see more interesting stuff.



Mihai



signature.asc
Description: OpenPGP digital signature
___
x2go-dev mailing list
x2go-dev@lists.x2go.org
https://lists.x2go.org/listinfo/x2go-dev

Re: [X2Go-Dev] x2go wiki : self-debugging instructions ?

[Mihai Moldovan]

* On 03/15/2018 12:36 PM, Mihai Moldovan wrote:
> The general syslog, after enabling server debug output, and client debug 
> output
> (x2goclient --debug) is more important, but this issue looks a lot like
> https://github.com/ArcticaProject/nx-libs/issues/679
> 
> I've only fixed the screen positioning issue today - nightly builds should
> already have that fix.
> 
> A workaround is to start x2goclient on your first (normally also primary)
> display. Are you starting it on a secondary (non-first) display? If yes, then
> it's likely that this is causing the trouble.

After skimming your original post again, I also wonder if you have partly
upgraded packages on that machine.

dpkg -l | grep -Ei '(x2go|nx)'



Mihai



signature.asc
Description: OpenPGP digital signature
___
x2go-dev mailing list
x2go-dev@lists.x2go.org
https://lists.x2go.org/listinfo/x2go-dev

Re: [X2Go-Dev] x2go wiki : self-debugging instructions ?

[Mihai Moldovan]

* On 03/13/2018 09:13 PM, Manfred Amoureux wrote:
> Now the purpose of this email:
> After tinkering around my x2go server install, it seems I have broken it
> . I am not here to ask for
> help me fixing it (although, I wouldn't mind) but I have been looking for
> instructions in the x2go wiki
>  about where to look for 
> the
> origin of errors (logs, etc ...) and I have not found such page.

Debugging is complicated. We do have a page at
https://wiki.x2go.org/doku.php/wiki:development:debugging

But most of the time there are special circumstances that lead to failure, which
cannot easily be ticked off using a checklist.

Even when it would be, the output is huge and usually needs proper
interpretation. Difficult to do so without knowing or at least looking at the 
code.


> Indeed, I already searched the /var/log/auth.log , but haven't found a clue of
> what's wrong.
> So, I thought there must be some basic steps that one may undertake looking 
> for
> what's wrong (logs to search, command lines to execute and check the result 
> ...)
> but I cannot figure out which ones.

The general syslog, after enabling server debug output, and client debug output
(x2goclient --debug) is more important, but this issue looks a lot like
https://github.com/ArcticaProject/nx-libs/issues/679

I've only fixed the screen positioning issue today - nightly builds should
already have that fix.

A workaround is to start x2goclient on your first (normally also primary)
display. Are you starting it on a secondary (non-first) display? If yes, then
it's likely that this is causing the trouble.


> I am willing to help the community by filling some pages in the wiki (so 
> nobody
> will have to bother the mailing list again asking what I am currently asking) 
> -
> I just need to find out how one create an account for the wiki.

You can't. User registration has been disabled due to spam bots creating
accounts and vandalizing pages. Wiki administrators (Heinz, me) can create new
accounts for users.

I typically need an email address (mandatory), a nickname (optional but
preferred, otherwise I'll guess it) and a real name (optional) for registration
and I will create an account accordingly.



Mihai



signature.asc
Description: OpenPGP digital signature
___
x2go-dev mailing list
x2go-dev@lists.x2go.org
https://lists.x2go.org/listinfo/x2go-dev

[X2Go-Dev] Deprecation and removal of X2Go Plugin

[Mihai Moldovan]

Hi


Since most browsers either stopped supporting NPAPI (or will be dropping support
with the next ESR version) and Qt 5 does not feature a browser plugin
architecture any longer, I will be ripping out code related to the X2Go Plugin
in the development version of X2Go Client soonish.

Expect the next version to not supply X2Go Plugin binaries.



Mihai



signature.asc
Description: OpenPGP digital signature
___
x2go-dev mailing list
x2go-dev@lists.x2go.org
https://lists.x2go.org/listinfo/x2go-dev

[X2Go-Dev] Bug#1260: high CPU usage with Fedora 27 and users that disconnect, Caja and Mate crash/coredump

[Mihai Moldovan]

Control: forwarded -1 https://github.com/ArcticaProject/nx-libs/issues/671
Control: severity -1 grave

* On 02/20/2018 04:46 PM, Robert Kudyba wrote:
> Package: x2goserver-4.1.0.1-0.0x2go1.0.git20180218.1532.heuler.fc27.x86_64
> Version: 4.1.0.1-0
> 
> We experience a high load after users disconnect. The logs the follow below
> indicate that Caja and Mate crash.

Can reproduce on Debian Unstable with current X2Go Stable packages.

Forwarded to https://github.com/ArcticaProject/nx-libs/issues/671



Mihai





signature.asc
Description: OpenPGP digital signature
___
x2go-dev mailing list
x2go-dev@lists.x2go.org
https://lists.x2go.org/listinfo/x2go-dev

[X2Go-Dev] Bug#1263: X2Go issue (in src:x2goclient) has been marked as pending for release

[Mihai Moldovan]

tag #1263 pending
fixed #1263 4.1.2.0
thanks

Hello,

X2Go issue #1263 (src:x2goclient) reported by you has been
fixed in X2Go Git. You can see the changelog below, and you can
check the diff of the fix at:

http://code.x2go.org/gitweb?p=x2goclient.git;a=commitdiff;h=cb365f8

The issue will most likely be fixed in src:x2goclient (4.1.2.0).

light+love
X2Go Git Admin (on behalf of the sender of this mail)

---
commit cb365f8f5254373ec1bddb86222c12a9d325e721
Author: Mihai Moldovan <io...@ionic.de>
Date:   Sat Mar 3 03:09:06 2018 +0100

src/{onmainwindow.cpp,session{button,widget}.{cpp,h}}: add support for 
LXQt. Fixes: #1263.

diff --git a/debian/changelog b/debian/changelog
index 88e8de8..e42b685 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -23,6 +23,8 @@ x2goclient (4.1.2.0-0x2go1) UNRELEASED; urgency=medium
 - res/img/svg: add new lxqt.svg icon file (really helix.svg).
 - res/img/icons/*x*: add new rasterized lxqt.png files in different sizes.
 - res/qresources.qrc: add new lxqt files.
+- src/{onmainwindow.cpp,session{button,widget}.{cpp,h}}: add support for
+  LXQt. Fixes: #1263.
 
  -- X2Go Release Manager <git-ad...@x2go.org>  Thu, 15 Feb 2018 22:01:32 +0100
 
___
x2go-dev mailing list
x2go-dev@lists.x2go.org
https://lists.x2go.org/listinfo/x2go-dev

[X2Go-Dev] Bug#1266: X2Go issue (in src:x2goserver) has been marked as pending for release

[Mihai Moldovan]

tag #1266 pending
fixed #1266 4.1.0.1
thanks

Hello,

X2Go issue #1266 (src:x2goserver) reported by you has been
fixed in X2Go Git. You can see the changelog below, and you can
check the diff of the fix at:

http://code.x2go.org/gitweb?p=x2goserver.git;a=commitdiff;h=dedc6aa

The issue will most likely be fixed in src:x2goserver (4.1.0.1).

light+love
X2Go Git Admin (on behalf of the sender of this mail)

---
commit dedc6aa4baeb7035079d14c9eae790d9dca6809e
Author: Mihai Moldovan <io...@ionic.de>
Date:   Fri Mar 2 23:45:30 2018 +0100

x2goserver-x2goagent/etc/x2goagent.options: disable BIG-REQUESTS; leads to 
a lot of weird crashes and is currently not implemented correctly in nxagent. 
Fixes: #1266.

diff --git a/debian/changelog b/debian/changelog
index a8deb76..419601a 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -111,6 +111,9 @@ x2goserver (4.1.0.1-0x2go1) UNRELEASED; urgency=medium
 - X2Go/Server/DB.pm: don't use X2Go::Server::DB::MySQL for now.
 - X2Go/Server/DB.pm: comment out calls to X2Go::Server::DB::MySQL::*.
 - x2goserver-x2goagent/etc/x2goagent.options: typo fix in comment only.
+- x2goserver-x2goagent/etc/x2goagent.options: disable BIG-REQUESTS; leads
+  to a lot of weird crashes and is currently not implemented correctly in
+  nxagent. Fixes: #1266.
   * debian/{control,compat}:
 + Bump DH compat level to 9.
   * debian/:
___
x2go-dev mailing list
x2go-dev@lists.x2go.org
https://lists.x2go.org/listinfo/x2go-dev

Re: [X2Go-Dev] session files in /tmp

[Mihai Moldovan]

* On 02/19/2018 03:09 PM, yk+bug+x...@64.re wrote:
> On Linux, the X2Go server stores the session files in /tmp/.x2go-* . Now, 
> whenever a coworker leaves for vacation, those files are not getting updated 
> and thus get deleted by tmpwatch on CentOS 6 or systemd-tmpfiles on CentOS 7;
> when the coworker comes back and tries to resume the session, it goes into 
> failed mode since those files are gone, with no possibility of recovery. The 
> current workaround that I set up is to exclude /tmp/.x2go-* from clean-up 
> (e.g.[1]), but to prevent having to do it on every machine to which we want 
> to connect, it would be nice to move the folder to a place that is not 
> cleaned (at least as often).

This is why nightly and upcoming release builds already contain such a
systemd-tmpfiles config file to counter this deletion.


> Although the Linux Filesystem Hierarchy Standard (FHS) has been widely 
> disputed, it seems to be an admitted convention to put PID/lock/socket files 
> and the like in /run (or /var/run). Is there a specific reason why those 
> files are in /tmp and not in /var?

These files used to be put in the users' home directory, but this turned out to
be a bad idea (of some sort at least), since they are really local to one
machine, i.e., the one running the corresponding X2Go session. Since the home
directory might be on an NFS share, it would have been synced over the network,
which is useless, produces unnecessary load and has higher latency than a local
on-disk location.

Subsequently they were moved to /tmp instead, which should be machine-local.

Nowadays, /run or /var/run should also be machine-local and hence more or less
appropriate, but I do not know if that is also true for older operating systems
(CentOS 6, SLE 11)? The next problem could be that these directories might be
polyinstantiated into private directories somewhere else, which would make it
way more difficult (if possible at all) to access files and directories in there
via another user (think the client-side printing spool/client-side file sharing
mount directories).



Mihai



signature.asc
Description: OpenPGP digital signature
___
x2go-dev mailing list
x2go-dev@lists.x2go.org
https://lists.x2go.org/listinfo/x2go-dev

Re: [X2Go-Dev] x2goclient-4.1.1.0 compile fails at link stage with undefined references

[Mihai Moldovan]

* On 02/16/2018 06:33 AM, John Frankish wrote:
> On linux
> Which lib provides the directRDP function?

There is no library. That's all Linux-#ifdef'd code. But given that the
implementation section is referencing for instance the
SessionWidget::directRDP(bool, bool) signal, it should work.

From the excerpt you've shown, I have no idea what you invoked and how so. I
also have no idea if the moc binary has been executed on relevant source files
and generated metaobjects code. If possible, please always paste *everything*,
not just the part that you may deem interesting.



Mihai



signature.asc
Description: OpenPGP digital signature
___
x2go-dev mailing list
x2go-dev@lists.x2go.org
https://lists.x2go.org/listinfo/x2go-dev

[X2Go-Dev] Bug#1156: SSH daemon could not be started

[Mihai Moldovan]

* On 01/29/2018 01:55 PM, Gromit wrote:
> Had this same problem under Windows 10.
> 
> Started x2goclient.debug --debug and it showed me that the
> permissions for the ssh_host_rsa_key are too open (0770).
> 
> Installed cygwin to check these permissions under windows and the user- 
> and groupname where the same username. The rights where 700. Somehow the 
> rights for the group where inherited from the user when they have the 
> same owner/group-name.
> 
> Fixed it by changing the group for ssh_host_rsa_key from the username to 
> 'Users' under cygwin.

Yes, that's very unfortunate. As far as I could find out, that's a known bug (or
feature, or whatever) in Cygwin.

Sadly, I have no idea how to fix that without telling users to install chmod,
cygwin bash and fixing permissions manually. That's certainly not the best way
to deal with that wide-spread issue.



Mihai



signature.asc
Description: OpenPGP digital signature
___
x2go-dev mailing list
x2go-dev@lists.x2go.org
https://lists.x2go.org/listinfo/x2go-dev

Re: [X2Go-Dev] x2goclient-4.1.1.0 compile fails at link stage with undefined references

[Mihai Moldovan]

* On 02/13/2018 08:56 AM, John Frankish wrote:
> Using gcc-7.2.0 and qt-4.8.6
> 
> Is something missing?
> 
> make
> ...
> g++ -lldap -lcups -lX11 -lXpm -Wl,-O1 -Wl,-rpath,/usr/local/lib -o x2goclient 
> sharewidget.o settingswidget.o mediawidget.o configwidget.o sessionwidget.o 
> connectionwidget.o configdialog.o editconnectiondialog.o exportdialog.o 
> imgframe.o LDAPSession.o onmainwindow.o sessionbutton.o sessionmanagedialog.o 
> sshmasterconnection.o sshprocess.o SVGFrame.o InteractionDialog.o 
> userbutton.o x2gologdebug.o printprocess.o cupsprint.o cupsprintwidget.o 
> cupsprintersettingsdialog.o printwidget.o printercmddialog.o printdialog.o 
> wapi.o clicklineedit.o httpbrokerclient.o ongetpass.o x2gosettings.o 
> brokerpassdlg.o contest.o xsettingswidget.o appdialog.o x2goutils.o 
> helpdialog.o sessionexplorer.o folderbutton.o folderexplorer.o 
> non_modal_messagebox.o help.o unixhelper.o compat.o pulsemanager.o 
> x2goclient.o moc_configdialog.o moc_editconnectiondialog.o moc_exportdialog.o 
> moc_imgframe.o moc_onmainwindow.o moc_sessionbutton.o 
> moc_sessionmanagedialog.o moc_sshmasterconnection.o moc_sshprocess.o 
> moc_SVGFrame.o moc_InteractionDialog.o moc_userbutton.o moc_printprocess.o 
> moc_cupsprintwidget.o moc_cupsprintersettingsdialog.o moc_printwidget.o 
> moc_printercmddialog.o moc_printdialog.o moc_sessionwidget.o 
> moc_connectionwidget.o moc_settingswidget.o moc_mediawidget.o 
> moc_sharewidget.o moc_clicklineedit.o moc_httpbrokerclient.o 
> moc_brokerpassdlg.o moc_contest.o moc_xsettingswidget.o moc_appdialog.o 
> moc_sessionexplorer.o moc_folderbutton.o moc_folderexplorer.o 
> moc_pulsemanager.o qrc_resources.o-L/usr/local/lib -lssh -lssh_threads 
> -lQtSvg -lQtGui -lQtNetwork -lQtCore -lpthread 
> sessionwidget.o: In function `SessionWidget::slot_emitSettings()':
> sessionwidget.cpp:(.text+0xd70): undefined reference to 
> `SessionWidget::settingsChanged(QString const&, QString const&, QString 
> const&)'
> sessionwidget.o: In function `SessionWidget::slot_rdpDirectClicked()':
> sessionwidget.cpp:(.text+0x1154): undefined reference to 
> `SessionWidget::directRDP(bool, bool)'
> collect2: error: ld returned 1 exit status
> make[2]: *** [Makefile:262: x2goclient] Error 1
> make[2]: Leaving directory '/usr/src/x2goclient-4.1.1.0/client_build'
> make[1]: *** [Makefile:76: build_client] Error 2
> make[1]: Leaving directory '/usr/src/x2goclient-4.1.1.0'
> make: *** [Makefile:70: build] Error 2
> Command exited with non-zero status 2

... on what platform? Linux should at least have the directRDP function, though
Linux/kFreeBSD or the like might be different.



Mihai




signature.asc
Description: OpenPGP digital signature
___
x2go-dev mailing list
x2go-dev@lists.x2go.org
https://lists.x2go.org/listinfo/x2go-dev

[X2Go-Dev] Bug#1209: X2Go issue (in src:x2goclient) has been marked as pending for release

[Mihai Moldovan]

tag #1209 pending
fixed #1209 4.1.1.1
thanks

Hello,

X2Go issue #1209 (src:x2goclient) reported by you has been
fixed in X2Go Git. You can see the changelog below, and you can
check the diff of the fix at:

http://code.x2go.org/gitweb?p=x2goclient.git;a=commitdiff;h=c57ad5d

The issue will most likely be fixed in src:x2goclient (4.1.1.1).

light+love
X2Go Git Admin (on behalf of the sender of this mail)

---
commit c57ad5d8cd641f789a26278e3d3f112e9db5874e
Author: Mihai Moldovan <io...@ionic.de>
Date:   Wed Feb 14 22:25:09 2018 +0100

src/onmainwindow.cpp: always enable close button, let it log out from a 
broker if already authenticated or close the client on click. Fixes: #1209.

diff --git a/debian/changelog b/debian/changelog
index 606b075..09e563e 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -72,6 +72,9 @@ x2goclient (4.1.1.1-0x2go1) UNRELEASED; urgency=medium
   unnecessary, since in thinclient mode, for which this feature is
   useful, users will not be able to see the client window while a session
   is executing, due to it running in full screen mode.
+- src/onmainwindow.cpp: always enable close button, let it log out from a
+  broker if already authenticated or close the client on click. Fixes:
+  #1209.
 
   [ Oleksandr Shneyder ]
   * New upstream version (4.1.1.1):
___
x2go-dev mailing list
x2go-dev@lists.x2go.org
https://lists.x2go.org/listinfo/x2go-dev

Re: [X2Go-Dev] Upcoming Deprecation of (Almost) EOL Distributions

[Mihai Moldovan]

The deprecation has been fully finished.



Mihai



signature.asc
Description: OpenPGP digital signature
___
x2go-dev mailing list
x2go-dev@lists.x2go.org
https://lists.x2go.org/listinfo/x2go-dev

[X2Go-Dev] Bug#1227: X2Go issue (in src:x2goclient) has been marked as pending for release

[Mihai Moldovan]

tag #1227 pending
fixed #1227 4.1.1.1
thanks

Hello,

X2Go issue #1227 (src:x2goclient) reported by you has been
fixed in X2Go Git. You can see the changelog below, and you can
check the diff of the fix at:

http://code.x2go.org/gitweb?p=x2goclient.git;a=commitdiff;h=e5ae6b9

The issue will most likely be fixed in src:x2goclient (4.1.1.1).

light+love
X2Go Git Admin (on behalf of the sender of this mail)

---
commit e5ae6b9c174cb10bbdadc27b5b4c1154d7f0aee1
Author: Walid Moghrabi 
Date:   Thu Jan 25 12:24:30 2018 +0100

{src/{help.cpp,onmainwindow.{cpp,h}},man/man1/x2goclient.1}: add new option 
--closebt. Fixes: #1227.

Adds a close button in the top-left client corner (maybe next to the
halt button) that currently just terminates the client.

diff --git a/debian/changelog b/debian/changelog
index 534233b..30e2e0a 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -64,6 +64,10 @@ x2goclient (4.1.1.1-0x2go1) UNRELEASED; urgency=medium
   [ Walid Moghrabi ]
   * New upstream version (4.1.1.1):
 - {res/img/png/,res/resources.qrc}: add close-button.png file.
+- {src/{help.cpp,onmainwindow.{cpp,h}},man/man1/x2goclient.1}: add new
+  option --closebt. Fixes: #1227. Adds a close button in the top-left
+  client corner (maybe next to the halt button) that currently just
+  terminates the client.
 
  -- X2Go Release Manager   Sun, 29 Oct 2017 11:44:44 +0100
 
___
x2go-dev mailing list
x2go-dev@lists.x2go.org
https://lists.x2go.org/listinfo/x2go-dev

[X2Go-Dev] Bug#1214: X2Go issue (in src:x2goclient) has been marked as pending for release

[Mihai Moldovan]

tag #1214 pending
fixed #1214 4.1.1.1
thanks

Hello,

X2Go issue #1214 (src:x2goclient) reported by you has been
fixed in X2Go Git. You can see the changelog below, and you can
check the diff of the fix at:

http://code.x2go.org/gitweb?p=x2goclient.git;a=commitdiff;h=0da3f0a

The issue will most likely be fixed in src:x2goclient (4.1.1.1).

light+love
X2Go Git Admin (on behalf of the sender of this mail)

---
commit 0da3f0a0d2d1f9331c92f5bd68418852cf826761
Author: Mihai Moldovan <io...@ionic.de>
Date:   Thu Jan 25 11:30:19 2018 +0100

src/sessionbutton.cpp: make button non-sensitive in bottom right part if 
it's editable. Fixes: #1214.

diff --git a/debian/changelog b/debian/changelog
index aaf1979..9a04dbb 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -54,6 +54,8 @@ x2goclient (4.1.1.1-0x2go1) UNRELEASED; urgency=medium
   X2GO_XINERAMA in accordance with server changes.
 - src/onmainwindow.cpp: supply xinerama option as another parameter to
   x2goresume-session on session resume.
+- src/sessionbutton.cpp: make button non-sensitive in bottom right part if
+  it's editable. Fixes: #1214.
 
   [ Oleksandr Shneyder ]
   * New upstream version (4.1.1.1):
___
x2go-dev mailing list
x2go-dev@lists.x2go.org
https://lists.x2go.org/listinfo/x2go-dev

[X2Go-Dev] Bug#1246: Bug#1246: Can't start X Server, please check your installation

[Mihai Moldovan]

* On 01/21/2018 11:20 PM, LANNES Pierre-Yves wrote:
> Package: x2goclient
> Version: 4.1.0.0
> 
> Platform: Windows 7
> 
> This message appears when I'm trying to connect to my server, and kills
> x2go:
> "Can't start X Server, please check your installation"
> 
> Never had this issue before, everything was working fine.
> 
> Went to the bugs site and only found bug #503.
> 
> I uninstalled X2goclient and manually removed the registry leftovers (by
> the way, a "clean" uninstall should ALWAYS be available)

Might be useful feature for the NSIS package, if that's possible, agree'd, but
not for this report.


> Re-downloaded the installer, fresh install, problem still there.
> 
> I saw the #109 bug, and checked: useintx is true

Might also be caused by something in your user home directory.

What happens if you try to connect in a new user context?



Mihai



signature.asc
Description: OpenPGP digital signature
___
x2go-dev mailing list
x2go-dev@lists.x2go.org
https://lists.x2go.org/listinfo/x2go-dev

[X2Go-Dev] Bug#1243: Nightly PPA packages depend on nxagent>=2:3.5.99.3, unavailable in Ubuntu or PPA

[Mihai Moldovan]

Control: reassign -1 launchpad.net
Control: close -1


* On 12/20/2017 02:49 PM, Jonathon Fernyhough wrote:
> Package: x2goserver-x2goagent
> Version: 4.1.0.0-0~1453~ubuntu16.04.1
> 
> Two recent changes to the debian/control file corrected the epoch for
> nxagent dependency [1]
> 
> Unfortunately, nxagent>=2:3.5.99.3~ isn't available in Ubuntu [3] or
> ppa:x2go/ppa [4] which leads to an unsatisfiable dependency

These packages should have been built almost a week ago.

We hit this bug, though, and the new code was never synced up within launchpad:
https://bugs.launchpad.net/ubuntu/+source/bzr-git/+bug/1084403


I haven't checked this, assuming that everything would work fine, since Arctica
already had packages for Ubuntu that completed the build process successfully.

A mistake, as it turns out.


I've switched the recipe to build off a native git clone which doesn't have that
problem.


The packages should finally be available soonish™.



Mihai




signature.asc
Description: OpenPGP digital signature
___
x2go-dev mailing list
x2go-dev@lists.x2go.org
https://lists.x2go.org/listinfo/x2go-dev

Re: [X2Go-Dev] Error: Wrong version or invalid session authentication cookie/I/O error: ssh_channel_open_session failed. - Socket error: Unknown error: 316 in .git20171218.1453

[Mihai Moldovan]

* On 12/20/2017 02:52 AM, Robert Kudyba wrote:
> Just started happening today. Something in the new build that could've caused
> this? I see an old thread at
> http://lists.x2go.org/pipermail/x2go-user/2013-July/001515.html not sure if 
> it's
> really the same issue though.

All RPM packages have been broken for the past few days due to the switch to
Arctica's version of nx-libs in the heuler repository.

I have been able to fix the issue a few hours ago.


Make sure to:

  - dnf clean metadata
  - dnf makecache
  - dnf up --best --allowerasing



Mihai



signature.asc
Description: OpenPGP digital signature
___
x2go-dev mailing list
x2go-dev@lists.x2go.org
https://lists.x2go.org/listinfo/x2go-dev

Re: [X2Go-Dev] [X2Go-Commits] [nx-libs] 01/01: debian/x2goagent.options: reenable XFIXES extension.

[Mihai Moldovan]

* On 12/13/2017 10:19 AM, Mike Gabriel wrote:
> On  Mi 13 Dez 2017 04:39:21 CET, git-admin wrote:
> 
>> +  * debian/:
>> +- x2goagent.options: reenable XFIXES extension. The initial problem that
>> +  required this workaround has been fixed a long time ago.
>>
> 
> What exactly was the fix in XFIXES?

No idea, but as far as I remember it was a workaround for a bug in Xrandr, which
has since been fixed (at least in Ubuntu and probably also upstream) - c.f.,
https://bugs.launchpad.net/ubuntu/+source/libxfixes/+bug/985202

You seem to also have mentioned another bug report that makes resizing of
sessions impossible, but that didn't look specific to the XFIXES extension. I
have no idea if that's still happening or if that problem was isolated to some
older Ubuntu versions.



Mihai





signature.asc
Description: OpenPGP digital signature
___
x2go-dev mailing list
x2go-dev@lists.x2go.org
https://lists.x2go.org/listinfo/x2go-dev

[X2Go-Dev] Bug#1031: x2goserver stops accepting new sessions after some years of working

[Mihai Moldovan]

control: close -1


* On 04/29/2016 03:46 PM, Arne Wichmann wrote:
> After some years of working x2goserver stopped accepting sessions - after
> some debugging it turned out that the list of used ports in the database
> was never cleaned up.

It looks like this bug was fixed in X2Go Server 3.1.0.0 (shortly after the
version you are/have been using.)

Closing up.



Mihai



signature.asc
Description: OpenPGP digital signature
___
x2go-dev mailing list
x2go-dev@lists.x2go.org
https://lists.x2go.org/listinfo/x2go-dev

[X2Go-Dev] Bug#1122: X2Go issue (in src:x2goclient) has been marked as pending for release

[Mihai Moldovan]

tag #1122 pending
fixed #1122 4.1.1.1
thanks

Hello,

X2Go issue #1122 (src:x2goclient) reported by you has been
fixed in X2Go Git. You can see the changelog below, and you can
check the diff of the fix at:

http://code.x2go.org/gitweb?p=x2goclient.git;a=commitdiff;h=248d227

The issue will most likely be fixed in src:x2goclient (4.1.1.1).

light+love
X2Go Git Admin (on behalf of the sender of this mail)

---
commit 248d22794db8f63d26187fe21045b64e12088427
Author: Mihai Moldovan <io...@ionic.de>
Date:   Sun Dec 10 06:03:29 2017 +0100

debian/changelog: add bug closure for #1122.

diff --git a/debian/changelog b/debian/changelog
index 5cdc048..e3a4322 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -8,6 +8,7 @@ x2goclient (4.1.1.1-0x2go1) UNRELEASED; urgency=medium
   in MacPorts.
 - src/sshmasterconnection.cpp: don't ask for private key passphrase if
   auto-login merely failed due to the server denying the public key.
+  Fixes: #1122.
 - src/{httpbrokerclient,onmainwindow,sshmasterconnection}.{cpp,h}:
   introduce new passphrase_type enum and replace the old verificationCode
   boolean value with that. Allows using more messages, including a new one
@@ -18,11 +19,12 @@ x2goclient (4.1.1.1-0x2go1) UNRELEASED; urgency=medium
   include onmainwindow.h to avoid a circular dependency, it has to be
   part of SshMasterConnection for now.
 - src/sshmasterconnection.cpp: query for password if it wasn't already
-  provided. This usually happens if auto-login is enabled, which bypasses
-  the password prompt. If auto-login fails, authentication normally
-  continues via challenge auth or plain passwords, but since users had no
-  chance to input a password, such authentication will always fail. Give
-  users a way to enter passwords, in case the auto-login failed.
+  provided. Fixes: #1122. This usually happens if auto-login is enabled,
+  which bypasses the password prompt. If auto-login fails, authentication
+  normally continues via challenge auth or plain passwords, but since
+  users had no chance to input a password, such authentication will always
+  fail. Give users a way to enter passwords, in case the auto-login
+  failed.
 - src/onmainwindow.cpp: finally include version information in debug
   output.
 - res/i18n/x2goclient_*.ts: apply last change to translation files
___
x2go-dev mailing list
x2go-dev@lists.x2go.org
https://lists.x2go.org/listinfo/x2go-dev

[X2Go-Dev] Bug#1234: acl-users-allow=ALL superceeds acl-users-deny

[Mihai Moldovan]

* On 11/21/2017 06:23 PM, Walid MOGHRABI wrote:
> When using ACLs with the session broker, I wanted to give access to a session 
> setting to ALL users EXCEPT some (namely "formation{1..9}").
> I tried this but it didn't work :
> [...]

I really have no idea what the rules are supposed to be.

For users, the current rules are (simplified, the actual rules are longer but
also redundant):
  [allow-deny]: allow && !deny
  [deny-allow]: allow

(allow stands for "user explicitly listed in allow list", deny stands for "user
explicitly listed in deny list".)


This doesn't make sense to me.
For instance, a user not explicitly listed in the allowed list will be denied
access in deny-allow mode, while in allow-deny mode; a user that is explicitly
granted access will still be denied if it is listed in the denied list.


What was the original inspiration for this?


It's not Apache httpd, since that has different rules...


My naïve understanding of this would be that:
  [allow-deny]: allow user if explicitly mentioned in allowed list, otherwise
allow if not explicitly denied
  [deny-allow]: deny user if explicitly mentioned in denied list, otherwise 
allow

Examples for [allow-deny] ("..." denotes a list *not* containing user):
  allow = { user, ... }; deny = { user, ... } => ALLOW
  allow = { user, ... }; deny = { ... }   => ALLOW
  allow = { ... };   deny = { ... }   => ALLOW
  allow = { ... };   deny = { user, ...}  => DENY

Examples for [deny-allow] ("..." denotes a list *not* containing user):
  allow = { user, ... }; deny = { user, ... } => DENY
  allow = { user, ... }; deny = { ... }   => ALLOW
  allow = { ... };   deny = { ... }   => ALLOW
  allow = { ... };   deny = { user, ... } => DENY


This is useful because it allows access in the case a user is not a member of
any list (emulating the behavior of not using any ACL for a specific user) and
otherwise giving correct precedence to a specific list.


The current behavior is not explicitly documented either, but only "implicitly"
by code and tests, which makes it difficult to understand what is intended and
what isn't.

For instance, one test case explicitly mentions:

  [deny-allow] allow = { user }; deny = { ALL }; => ALLOW

which just doesn't make sense to me. If  all users are denied and the order is
deny-allow, why would the user be allowed, even if it's in the allow list? The
order isn't allow-deny, so if all users are denied with the deny-allow order,
the allow list shouldn't even come into play.



Mihai



signature.asc
Description: OpenPGP digital signature
___
x2go-dev mailing list
x2go-dev@lists.x2go.org
https://lists.x2go.org/listinfo/x2go-dev

Re: [X2Go-Dev] new version 4.1.1.0 from Mac still crashes to Fedora 26

[Mihai Moldovan]

* On 11/17/2017 12:12 AM, Ulrich Sibiller wrote:
> Thanks for clarification. But why not simply using all combinations in 
> parallel?

Could do, but that doesn't really make sense if the plain hostname is working 
fine.

I actually wonder if there's a subtle bug in general - what happens with
successfully started sessions if the hostname changes at a later time? In
theory, nxagent should have opened its internal display by then, but if it
disconnects again after a proxy disconnected and tries to re-open the internal
display on subsequent proxy connections, this may fail. I doubt anyone has ever
tested such a scenario (at least not willingly). I probably should.

And even if that's a real problem, I'm not sure how to fix it. At least xauth
does seem to do duplicate checking, so simply adding more entries on each
x2goresume-session call would work.

The next arguable bug is that we never delete any of these entries. Given that
we use the "global" user Xauthority file by default, it's not very nice to
clutter their file with random "crap" (at least after a session has ended).


> Maybe we should provide a script that checks common problems ans
> collects required data to avoid pinging back and forth so often.

Most issues users have are not based upon "common problems", but mostly very
specific site configurations. :/



Mihai




signature.asc
Description: OpenPGP digital signature
___
x2go-dev mailing list
x2go-dev@lists.x2go.org
https://lists.x2go.org/listinfo/x2go-dev

Re: [X2Go-Dev] new version 4.1.1.0 from Mac still crashes to Fedora 26

[Mihai Moldovan]

* On 11/16/2017 07:41 AM, Ulrich Sibiller wrote:
> Fine! Now that we debugged this with ~60 mails we finally have a working 
> system.
> But to me it is still unclear what was causing the NIS problems!?

There wasn't a NIS issue to begin with.

What we learned is that X authorization is a fragile construct and easy to get
wrong.

Within x2gostartagent, we create an X authorization cookie and add it to the
newly spawned nxagent instance - once with the hostname (for TCP connections)
and another time with the hostname and a /unix postfix (for UNIX socket
connections).

Historically, we've been doing that by relying on bash's HOSTNAME variable,
which is (normally) automatically set to the system's hostname. It turned out
that relying on that is not a good idea, though, since it can easily be 
overridden.

Example:
bash -c 'echo $HOSTNAME'; env HOSTNAME=outofluck bash -c 'echo $HOSTNAME'
japsand
outofluck

And of course, there's no way to get the original value back, since it's only
set once at process startup IFF such a variable does not exist in the
environment yet:

env HOSTNAME=outofluck bash -c 'echo $HOSTNAME; unset HOSTNAME; echo $HOSTNAME'
outofluck


Thus, I looked for a more reliable way to get the hostname, and of course there
is: the hostname program.

In a previous bug report, a user with tcsh as its default logging shell reported
problems starting sessions. This was tracked down to a system startup script
exporting HOSTNAME to the environment with a FQDN (because tcsh and csh do not
define HOSTNAME as a standard variable that is set by the shell by default, but
a lot of scripts nevertheless seem to use it, so the distro decided to be smart
and provide it globally using this way), overriding bash's autodetected value of
HOSTNAME. Since using a FQDN failed in his case, I (wrongly) inferred, that X
authorization always needs a short host name to work, not a FQDN.


This proved be to be wrong, but to be working *sometimes*, which made the matter
worse.

Hostname: F.Q.D.N
DNS/hosts file: shortname mapping to 127.0.0.1
xauth: cookie added via using shortname

=> works!


Hostname: F.Q.D.N
DNS/hosts file: shortname mapping to a public IPv4 address (non-loopback!)
xauth: cookie added via shortname

=> fails


Hostname: F.Q.D.N
DNS/hosts file: doesn't matter
xauth: cookie added via F.Q.D.N

=> works!


Hostname: shortname
DNS/hosts file: doesn't matter
xauth: cookie added via shortname

=> works


The gist is that we should always add the X authorization cookie with the actual
system host name, instead of using a shortname or the FQDN explicitly.
Otherwise, X authorization might or might not work depending on other factors,
but in most cases it will fail.



The second issue was due mixing old nx-libs packages with the newer Arctica
version. Using x2goserver-x2goagent is very important with nx-libs 3.5.99.x+,
since this package also implicitly disables the ld preloading hack we've been
using for Xinerama support in the past. Using the ld preloading hack with
nx-libs 3.5.99.x+ leads to such odd errors when applications try to utilize 
libX11.



Mihai



signature.asc
Description: OpenPGP digital signature
___
x2go-dev mailing list
x2go-dev@lists.x2go.org
https://lists.x2go.org/listinfo/x2go-dev

Re: [X2Go-Dev] new version 4.1.1.0 from Mac still crashes to Fedora 26

[Mihai Moldovan]

* On 11/15/2017 10:36 PM, Robert Kudyba wrote:
> Ahh success! Even with the NIS user. So should I remove
> the _copr_mikedep333-nx-libs-3.6.repo?

Uhm... that depends. If you want to keep staying on the Arctica testing version
of nx-libs, then no.

If you want switch back the older nx-libs version as shipped by X2Go, then
you'll need to uninstall all X2Go and nx-libs packages first, then remove this
repository and reinstall x2goserver and x2goserver-xsession again. Be careful
with that - X2Go's older version needs x2goagent explicitly, while Arctica's
version requires x2goserver-x2goagent. Both packages are conflicting and the
different versions require either one or the other.

X2Go will switch to Arctica's version in a short time (few weeks?) anyway. I'd
suggest staying on what the workstation is on currently.



Mihai



signature.asc
Description: OpenPGP digital signature
___
x2go-dev mailing list
x2go-dev@lists.x2go.org
https://lists.x2go.org/listinfo/x2go-dev

Re: [X2Go-Dev] new version 4.1.1.0 from Mac still crashes to Fedora 26

[Mihai Moldovan]

* On 11/15/2017 10:30 PM, Robert Kudyba wrote:
>> Hopefully it didn't remove any other needed package. Probably not, though.
>>
>> rpm -q '*x2go*’
> 
> Seems it did:
> rpm -q '*x2go*'
> package *x2go* is not installed

Yep, it did. No big deal, just yum install x2goserver x2goserver-xsession.



Mihai




signature.asc
Description: OpenPGP digital signature
___
x2go-dev mailing list
x2go-dev@lists.x2go.org
https://lists.x2go.org/listinfo/x2go-dev

Re: [X2Go-Dev] new version 4.1.1.0 from Mac still crashes to Fedora 26

[Mihai Moldovan]

* On 11/15/2017 10:23 PM, Robert Kudyba wrote:
> OK I had to remove and then installed successfully. Now how do I start?
> [root@sobolev yum.repos.d]# systemctl start x2goagent
> Failed to start x2goagent.service: Unit x2goagent.service not found.
> [root@sobolev yum.repos.d]# systemctl start x2server
> Failed to start x2server.service: Unit x2server.service not found.
> [root@sobolev yum.repos.d]# systemctl start x2gocleansessions.service
> Failed to start x2gocleansessions.service: Unit x2gocleansessions.service not 
> found.

There's nothing to start, just go ahead.

You misspelled x2goserver above - that's the only systemd service we provide.
EPEL and Fedora call it x2gocleansessions, but it's just a different name for
the same thing. For our upstream packages, it's x2goserver.service.

You don't have to restart it, though. It should already be running.


Just go ahead and retest the session startup.

Hopefully it didn't remove any other needed package. Probably not, though.

rpm -q '*x2go*'



Mihai




signature.asc
Description: OpenPGP digital signature
___
x2go-dev mailing list
x2go-dev@lists.x2go.org
https://lists.x2go.org/listinfo/x2go-dev

Re: [X2Go-Dev] new version 4.1.1.0 from Mac still crashes to Fedora 26

[Mihai Moldovan]

* On 11/15/2017 10:14 PM, Robert Kudyba wrote:
> rpm -qa '*x2goagent*'
> x2goagent-3.5.0.34-0.0x2go1.0.git2017.778.heuler.fc26.x86_64

Ah, now that explains a great deal! You shouldn't be using that package with
Arctica's nx-libs version.


What does yum install x2goserver-x2goagent do? If it fails, try running yum
remove x2goagent first, then yum install x2goserver-x2goagent.



Mihai




signature.asc
Description: OpenPGP digital signature
___
x2go-dev mailing list
x2go-dev@lists.x2go.org
https://lists.x2go.org/listinfo/x2go-dev

Re: [X2Go-Dev] new version 4.1.1.0 from Mac still crashes to Fedora 26

[Mihai Moldovan]

* On 11/15/2017 10:05 PM, Robert Kudyba wrote:
> I’m taking another shot with providing logs as there appears to be more than
> last time. Here are debug logs from the client and then server. I take it the
> core dumps from MATE, GLXINFO or XFCE won’t help?
> 
> Seems to crash in a similar place, from the gdb of the MATE core dump:
> Program terminated with signal SIGSEGV, Segmentation fault.
> #0  0x7f95cdc26627 in XGetXCBConnection (dpy=dpy@entry=0x5570c096b000) at
> x11_xcb.c:9
> 9return dpy->xcb->connection;

It's really the same information, your applications crash because they can't
establish a connection via XCB.

This lead me to something else, though.

Server-side: rpm -qa '*x2goagent*' please.



Mihai



signature.asc
Description: OpenPGP digital signature
___
x2go-dev mailing list
x2go-dev@lists.x2go.org
https://lists.x2go.org/listinfo/x2go-dev

[X2Go-Dev] Bug#651: x2goclient segfault on update to 4.0.3 on ubuntu 14.04

[Mihai Moldovan]

* On 11/15/2017 09:29 AM, Rob Izzard wrote:
> wow, this was a long time ago :)

Yeah, I went through some old bug reports. Sometimes they are still valid but
require more input, other times they either look like duplicates or like reports
that were fixed meanwhile - but never marked as such.

And of course people stop using the software or using special-purpose mail
addresses that won't be checked again, so getting a response is difficult at 
times.


> I haven't had a crash, freeze or lost a desktop for a while (6
> months?). That's not to say it won't happen again :) but it's been
> going well lately, thanks to the great effort by you guys.

Yeah, but that's probably a side effect of connecting to another machine, or
updating it, or plainly reinstalling it.

As far as I can tell, this bug report is still valid. X2Go Client doesn't handle
server-side errors as well as it could.

A way to reproduce this would be great, but I guess I could just make it fail
and test manually.


What probably happened in your case is that you updated a release version of
x2goserver to the nightly version - but the database schema upgrade didn't work
correctly for some reason.



Mihai



signature.asc
Description: OpenPGP digital signature
___
x2go-dev mailing list
x2go-dev@lists.x2go.org
https://lists.x2go.org/listinfo/x2go-dev

Re: [X2Go-Dev] x2goclient 4.0.5.0 (and 4.0.5.1 preview) frequent ssh commands don't free resources

[Mihai Moldovan]

On 03/14/2016 05:47 PM, Mat Martineau wrote:
> Given that the Mac client is leaking 6 SshProcess objects per minute, is 
> there a chance bug 759 will get a look before 4.0.5.1?

Obviously not, but something definitely sounds fishy there.

In general, running xmodmap every 10 seconds is fine. That's how we synchronize
the keyboard map on OS X. I understand this may seem weird, but keyboard
handling on OS X is difficult. The keyboard settings that is reported by the
local X server on OS X is just "bogus" and the mapping is done differently. I
don't know how exactly, but I figure it's going through the OS X system at some
point.

A problem arises if these values are taken at face value - they keyboard mapping
would completely messed up. This also holds, for example, if the keyboard
parameters is changed in x2goagent/nxagent (e.g., via the desktop environment)
itself.


The second issue - ssh processes stacking up, is NOT intentional and must be 
fixed.


Can you reproduce this with current versions?



Mihai




signature.asc
Description: OpenPGP digital signature
___
x2go-dev mailing list
x2go-dev@lists.x2go.org
https://lists.x2go.org/listinfo/x2go-dev

[X2Go-Dev] Bug#703: x2goclient crash upon connection establishment

[Mihai Moldovan]

Control: tag -1 moreinfo

On 12/16/2014 07:05 PM, Lianqi Wang wrote:
> Package: x2go client on Mac (10.10.1)
> Version 4.0.3.0
> 
> When the connection is established to my server, the x2go client immediately
> crash. It has happened many times and times to be more often recently after I
> updated the version of x2go client. The server is running x2goserver 4.0.1.18 
> on
> centos 7.
> 
> Here is the backtrace:
> 
> Process:               x2goclient [41285]
> Path:                  /Applications/x2goclient.app/Contents/MacOS/x2goclient
> Identifier:            x2goclient
> Version:               0
> Code Type:             X86-64 (Native)
> Parent Process:        ??? [1]
> Responsible:           x2goclient [41285]
> User ID:               501
> 
> Date/Time:             2014-12-16 09:45:10.840 -0800
> OS Version:            Mac OS X 10.10.1 (14B25)
> Report Version:        11
> Anonymous UUID:        D15E59D5-49FE-C920-0E6B-5B30CB94D859
> 
> Sleep/Wake UUID:       5A3B16A1-F98C-43FD-9F09-53C53032735E
> 
> Time Awake Since Boot: 43000 seconds
> Time Since Wake:       840 seconds
> 
> Crashed Thread:        0  Dispatch queue: com.apple.main-thread
> 
> Exception Type:        EXC_BAD_ACCESS (SIGSEGV)
> Exception Codes:       EXC_I386_GPFLT
> 
> Thread 0 Crashed:: Dispatch queue: com.apple.main-thread
> 0   QtCore                        0x00010e10732f 
> QObject::disconnect(QObject
> const*, char const*, QObject const*, char const*) + 511
> 1   x2goclient                    0x00010d083602
> ONMainWindow::slotProxyFinished(int, QProcess::ExitStatus) + 50
> 2   x2goclient                    0x00010d1259f2
> ONMainWindow::qt_static_metacall(QObject*, QMetaObject::Call, int, void**) + 
> 1682
> 3   QtCore                        0x00010e10918b
> QMetaObject::activate(QObject*, QMetaObject const*, int, void**) + 2363
> 4   QtCore                        0x00010e07f1c1 0x10dfba000 + 807361
> 5   QtCore                        0x00010e0813d3 0x10dfba000 + 816083
> 6   QtCore                        0x00010e10918b
> QMetaObject::activate(QObject*, QMetaObject const*, int, void**) + 2363
> 7   QtCore                        0x00010e15653c
> QSocketNotifier::activated(int) + 60

Is this still a problem with current versions?

Given that the code in question has not seen a lot of changes lately, I assume
that that's still the case, but please re-test and report back.



Mihai



signature.asc
Description: OpenPGP digital signature
___
x2go-dev mailing list
x2go-dev@lists.x2go.org
https://lists.x2go.org/listinfo/x2go-dev

[X2Go-Dev] Bug#682: X2Go client on Ubuntu 14.04 always connect with session type unix-kde

[Mihai Moldovan]

Control: tag -1 moreinfo

On 11/29/2014 09:34 PM, Biocyberman wrote:
> Package: x2goclient
> 
> The problem:
> When using x2goclient to connect to the server, I can't get the session to
> finish starting up. I can access the remote MATE desktop (Ubuntu 14.04) menus
> (i.e. "Applications", "Places", "System") but now icons appear on the desktop.
> Starting of applications take much longer time than expected.
> 
> My work around:
> Switch to connecting using KDE session, or using PyHoca-GUI to connect. If I 
> use
> PyHoca-GUI, I can connect to the server with MATE session type successfully.
> This work around suggests clearly that X2Goclient has some problems to form
> proper connect to the server. And I think the fixed "session type" information
> below at "Information from 'Show Details'" is causing the problem.
> 
> 
> Thanks for the work of X2Go
> 
> Kind regards
> Adam
> 
> My Client Inforamtion
> --
> Linux x2goclient 3.13.0-24-generic #47-Ubuntu SMP Fri May 2 23:30:00 UTC 2014
> x86_64 x86_64 x86_64 GNU/Linux
> 
> X2Go Client V. 4.0.3.1 (Qt - 4.8.6)
> (C. 2005-2014 obviously nice: Oleksandr Shneyder, Heinz-Markus Graesing)
> 
> 
> 
> --- --My Server
> Inforamtion---
> 
> xuser@xgserver:~$ uname -a
> Linux xgserver 3.13.0-40-generic #69-Ubuntu SMP Thu Nov 13 17:53:56 UTC 2014
> x86_64 x86_64 x86_64 GNU/Linux
> 
> xuser@xgserver:~$ /usr/bin/x2goversion
> x2goagent: 3.5.0.28
> x2golxdebindings: 1.0.2.2
> x2goserver: 4.0.1.18
> x2goserver-extensions: 4.0.1.16
> x2goserver-xsession: 4.0.1.16
> [...]
> ===>Warning: Unrecognized session type 'unix-kde-depth_24'. Assuming agent
> session.<===
> [...]

This message might be misleading. All full desktop sessions feature it.

That's not a real problem.

One problem, I do see, though, is that some components lag behind the x2goserver
(package) version.


Can you reproduce this problem on a still-supported platform using the currently
available versions?



Mihai



signature.asc
Description: OpenPGP digital signature
___
x2go-dev mailing list
x2go-dev@lists.x2go.org
https://lists.x2go.org/listinfo/x2go-dev

[X2Go-Dev] Bug#677: X2goclient assumes all public keys to be encrypted.

[Mihai Moldovan]

Control: tag -1 moreinfo

On 11/27/2014 05:10 AM, Mike Gabriel wrote:
> Hi dE,
> 
> On  Di 18 Nov 2014 10:03:31 CET, dE wrote:
> 
>> Package: x2goclient
>> Version: 4.0.3.0
>>
>> I'm using public key authentication to get authenticated. I can ssh  
>> fine to the server using the generated public key (generated using  
>> ssh-keygen), but with x2goclient, it asks for it's passphrase, where  
>> as it's not encrypted.
>>
>> As a result, no password is correct.
> 
> Can you share with us what algorithm your pub/priv key pair is of?

More importantly: how did you setup the session? Are you using ssh-agent to
unlock the keys? Did you enable auto-login? Did you specify a custom file path
to a private key without enabling auto-login?



Mihai



signature.asc
Description: OpenPGP digital signature
___
x2go-dev mailing list
x2go-dev@lists.x2go.org
https://lists.x2go.org/listinfo/x2go-dev