Re: Proposal unify back our release schedules

2024-04-22 Thread Kevin Ottens
Hello, On Monday 22 April 2024 18:08:04 CEST Carl Schwan wrote: > On Friday, April 19, 2024 6:39:01 PM GMT+2 Kevin Ottens wrote: > > Unsurprisingly I'll be pretty much aligned with Luigi, Sune and Volker > > here I think. I'll try to add a couple of extra aspects to feed t

Re: Proposal unify back our release schedules

2024-04-22 Thread Kevin Ottens
Hello, On Monday 22 April 2024 18:08:04 CEST Carl Schwan wrote: > On Friday, April 19, 2024 6:39:01 PM GMT+2 Kevin Ottens wrote: > > Unsurprisingly I'll be pretty much aligned with Luigi, Sune and Volker > > here I think. I'll try to add a couple of extra aspects to feed t

Re: Proposal unify back our release schedules

2024-04-20 Thread Kevin Ottens
Hello, On Saturday 20 April 2024 15:12:48 CEST Ingo Klöcker wrote: > On Freitag, 19. April 2024 22:40:38 CEST Ben Cooksley wrote: > > On Sat, Apr 20, 2024 at 4:39 AM Kevin Ottens wrote: > > > The example you give shows Plasma depending on Gear, this shouldn't > > >

Re: Proposal unify back our release schedules

2024-04-19 Thread Kevin Ottens
ange" loop). > > * "KDE Framework" will still exists as an entity and its ABI and API > > > > compatibility requirement. Only change is the release frequency and the > > > > introduction of a stable branch in sync with the other components. > > That part I'm against for the above mentioned reasons, KF's release > frequency is a major feature of it. Regards. -- Kevin Ottens, http://ervin.ipsquad.net enioka Haute Couture - proud supporting member of KDE https://hc.enioka.com/en signature.asc Description: This is a digitally signed message part.

Re: Proposal unify back our release schedules

2024-04-19 Thread Kevin Ottens
ange" loop). > > * "KDE Framework" will still exists as an entity and its ABI and API > > > > compatibility requirement. Only change is the release frequency and the > > > > introduction of a stable branch in sync with the other components. > > That part I'm against for the above mentioned reasons, KF's release > frequency is a major feature of it. Regards. -- Kevin Ottens, http://ervin.ipsquad.net enioka Haute Couture - proud supporting member of KDE https://hc.enioka.com/en signature.asc Description: This is a digitally signed message part.

Re: Proposal unify back our release schedules

2024-04-19 Thread Kevin Ottens
someone who didn't reply to this thread and have no strong opinion about the topic: keep monitoring that thread and maybe evaluate volunteering to facilitate if we start throwing mud at each other. ;-) Regards. -- Kevin Ottens, http://ervin.ipsquad.net enioka Haute Couture - proud supporting memb

Re: Proposal unify back our release schedules

2024-04-19 Thread Kevin Ottens
someone who didn't reply to this thread and have no strong opinion about the topic: keep monitoring that thread and maybe evaluate volunteering to facilitate if we start throwing mud at each other. ;-) Regards. -- Kevin Ottens, http://ervin.ipsquad.net enioka Haute Couture - proud supporting memb

Re: Proposal unify back our release schedules

2024-04-19 Thread Kevin Ottens
econd because these was already used in the past. Sure, why not. This is not engineering I'm less opinionated about it. Apart from decoupling more between engineering effort and marketing announcements that is. Maybe reconsider the "Megarelease" term though... I've literally been laughed

Re: Proposal unify back our release schedules

2024-04-19 Thread Kevin Ottens
econd because these was already used in the past. Sure, why not. This is not engineering I'm less opinionated about it. Apart from decoupling more between engineering effort and marketing announcements that is. Maybe reconsider the "Megarelease" term though... I've literally been laughed

[Discover] [Bug 476654] Allow Discover to manually update updateable Snaps

2024-04-05 Thread Kevin Ottens
https://bugs.kde.org/show_bug.cgi?id=476654 Kevin Ottens changed: What|Removed |Added Resolution|--- |FIXED Status|CONFIRMED

Re: 32 bit build failure (smb, narrowing)

2024-03-11 Thread Kevin Ottens
l/unx/file.cxx:796:14: note: in expansion of > macro ‘SMB2_SUPER_MAGIC’ > >796 | case SMB2_SUPER_MAGIC: >| ^~~~ > > make[2]: *** [/<>/solenv/gbuild/LinkTarget.mk:340: > /<>/workdir/CxxObject/sal/osl/unx/file.o] Error 1 > > This is due to > &

core.git: Branch 'libreoffice-24-2' - sal/osl

2024-02-19 Thread Kevin Ottens (via logerrit)
sal/osl/unx/file.cxx | 54 --- 1 file changed, 47 insertions(+), 7 deletions(-) New commits: commit a8814b5921676b1c01a19b0af243712c55fb0307 Author: Kevin Ottens AuthorDate: Fri Feb 2 15:39:36 2024 +0100 Commit: Stephan Bergmann

Kevin Ottens license statement

2024-02-19 Thread Kevin Ottens
Hello, Since I've submitted my first patch, I've been requested to send such a statement, so here it is: All of my past & future contributions to LibreOffice may be licensed under the MPLv2/LGPLv3+ dual license. Regards. -- Kévin Ottens kevin.ott...@enioka.com +33 7 57 08 95 13

core.git: sal/osl

2024-02-18 Thread Kevin Ottens (via logerrit)
sal/osl/unx/file.cxx | 54 --- 1 file changed, 47 insertions(+), 7 deletions(-) New commits: commit 63efbc8ad8aae12b54e649c1495d1233c1a9b33f Author: Kevin Ottens AuthorDate: Fri Feb 2 15:39:36 2024 +0100 Commit: Stephan Bergmann

[okular] [Bug 478276] Wrong paper color until zoom when overprint preview enabled

2024-01-31 Thread Kevin Ottens
https://bugs.kde.org/show_bug.cgi?id=478276 --- Comment #9 from Kevin Ottens --- I can indeed confirm it. Now I don't have much bandwidth at the moment, so don't hold your breath... in any case, at first glance, it looks like it might be something in Poppler/Qt rather than Okular itself

[okular] [Bug 478276] Wrong paper color until zoom when overprint preview enabled

2024-01-31 Thread Kevin Ottens
https://bugs.kde.org/show_bug.cgi?id=478276 --- Comment #9 from Kevin Ottens --- I can indeed confirm it. Now I don't have much bandwidth at the moment, so don't hold your breath... in any case, at first glance, it looks like it might be something in Poppler/Qt rather than Okular itself

[lokalize] [Bug 477039] lokalize does not open project file using --project

2024-01-23 Thread Kevin Ottens
https://bugs.kde.org/show_bug.cgi?id=477039 Kevin Ottens changed: What|Removed |Added Resolution|--- |FIXED Latest Commit

[lokalize] [Bug 477039] lokalize does not open project file using --project

2024-01-22 Thread Kevin Ottens
https://bugs.kde.org/show_bug.cgi?id=477039 --- Comment #7 from Kevin Ottens --- To be expected, nobody reviewed the patch, feels like it fell through the cracks. I'll poke. -- You are receiving this mail because: You are watching all bug changes.

[lokalize] [Bug 477039] lokalize does not open project file using --project

2023-12-10 Thread Kevin Ottens
https://bugs.kde.org/show_bug.cgi?id=477039 Kevin Ottens changed: What|Removed |Added CC||er...@kde.org --- Comment #5 from Kevin Ottens

Re: plasma-framework, kactivities and kactivities-stats: please consider proper de-KF-ication now

2023-11-05 Thread Kevin Ottens
k without Baloo? It even seems to do the right thing if I trust its CMakeLists.txt. It has Baloo as a recommended but optional dependency, and disable it altogether for Win32 builds. Regards. -- Kevin Ottens, http://ervin.ipsquad.net enioka Haute Couture - proud supporting member of KDE https://hc.enio

Re: plasma-framework, kactivities and kactivities-stats: please consider proper de-KF-ication now

2023-11-05 Thread Kevin Ottens
k without Baloo? It even seems to do the right thing if I trust its CMakeLists.txt. It has Baloo as a recommended but optional dependency, and disable it altogether for Win32 builds. Regards. -- Kevin Ottens, http://ervin.ipsquad.net enioka Haute Couture - proud supporting member of KDE https://hc.enio

[frameworks-kio] [Bug 474451] Okular cannot save

2023-09-15 Thread Kevin Ottens
https://bugs.kde.org/show_bug.cgi?id=474451 Kevin Ottens changed: What|Removed |Added Latest Commit|https://invent.kde.org/fram |https://invent.kde.org/fram

[frameworks-kio] [Bug 474451] Okular cannot save

2023-09-15 Thread Kevin Ottens
https://bugs.kde.org/show_bug.cgi?id=474451 Kevin Ottens changed: What|Removed |Added Latest Commit||https://invent.kde.org/fram

[okular] [Bug 454693] Okular throws error when saving to mounted Samba share

2023-08-24 Thread Kevin Ottens
https://bugs.kde.org/show_bug.cgi?id=454693 Kevin Ottens changed: What|Removed |Added Latest Commit|https://invent.kde.org/fram |https://invent.kde.org/fram

[okular] [Bug 454693] Okular throws error when saving to mounted Samba share

2023-08-24 Thread Kevin Ottens
https://bugs.kde.org/show_bug.cgi?id=454693 Kevin Ottens changed: What|Removed |Added Latest Commit|https://invent.kde.org/fram |https://invent.kde.org/fram

[okular] [Bug 454693] Okular throws error when saving to mounted Samba share

2023-08-24 Thread Kevin Ottens
https://bugs.kde.org/show_bug.cgi?id=454693 Kevin Ottens changed: What|Removed |Added Latest Commit||https://invent.kde.org/fram

[okular] [Bug 454693] Okular throws error when saving to mounted Samba share

2023-08-24 Thread Kevin Ottens
https://bugs.kde.org/show_bug.cgi?id=454693 Kevin Ottens changed: What|Removed |Added Latest Commit||https://invent.kde.org/fram

Re: Splitting KGlobalAccel interface and runtime

2023-02-14 Thread Kevin Ottens
parts > will have different release schedules, we will have to be careful about > protocol changes. Perhaps we could borrow a thing or two from activities? Or... move both runtime and API on the Plasma side? This way no problem of different release schedules and it makes it clear that using

[Planet KDE] [Bug 458350] Remove Kevin Otten's "Web review" from Planet feed

2022-08-31 Thread Kevin Ottens
https://bugs.kde.org/show_bug.cgi?id=458350 --- Comment #7 from Kevin Ottens --- Ah also, for the record: I also got at least a yearly Akademy post and one KDE PIM Summary (should be later this year for both). Granted it's not much. -- You are receiving this mail because: You are watching all

[Planet KDE] [Bug 458350] Remove Kevin Otten's "Web review" from Planet feed

2022-08-30 Thread Kevin Ottens
https://bugs.kde.org/show_bug.cgi?id=458350 --- Comment #6 from Kevin Ottens --- Yeah well, I wish I could post more KDE content but lately... well... life. I started this web review for two reasons: 1. it's actually my coping strategy for the guilt of not finding the time to write more

[yakuake] [Bug 377955] yakuake does no longer accept input

2022-08-30 Thread Kevin Ottens
https://bugs.kde.org/show_bug.cgi?id=377955 --- Comment #6 from Kevin Ottens --- Seems to be related to ibus not starting anymore somehow: systemctl --user status 'app-ibus\x2dautostart@autostart.service' Shows the service as failed. If I force the start: systemctl --user start 'app-ibus

[yakuake] [Bug 377955] yakuake does no longer accept input

2022-08-30 Thread Kevin Ottens
https://bugs.kde.org/show_bug.cgi?id=377955 Kevin Ottens changed: What|Removed |Added CC||er...@kde.org --- Comment #5 from Kevin Ottens

[frameworks-kwallet] [Bug 458085] Wallet system takes about 1 minute to start

2022-08-22 Thread Kevin Ottens
https://bugs.kde.org/show_bug.cgi?id=458085 Kevin Ottens changed: What|Removed |Added CC||er...@kde.org --- Comment #1 from Kevin Ottens

Re: request to move Zanshin to KDE Gear

2021-10-27 Thread Kevin Ottens
mental load, there's been a couple of times in the past where I was pondering between "should I spend time on a release" and "should I spend time on that cleanup/feature". Less options fighting for my attention. > If no one disagrees I'll add it to the release-tools/module

Re: request to move Zanshin to KDE Gear

2021-10-27 Thread Kevin Ottens
er even contains a couple of things the latest release doesn't have... I just couldn't get around to make a proper release. Cheers. -- Kevin Ottens, http://ervin.ipsquad.net enioka Haute Couture - proud patron of KDE, https://hc.enioka.com/en signature.asc Description: This is a digitally signed message part.

Re: Croutons in kdereview

2021-10-27 Thread Kevin Ottens
sed into QML as a JavaScript Thennable (similarly to Qt IVI's > > PendingReply) and headers for C++20 coroutine integration for the > > Croutons Future types + some Qt types that make sense to co_await. > > > > The library is largely headers-only, sans the FutureBase, which has

[sdk/kdesrc-build/make_it_mojo] doc: Add documentation for use-inactive-modules

2021-09-11 Thread Kevin Ottens
Git commit 81df57281f23f4d5a513ca3e48ca42e1f6e0ccca by Kevin Ottens. Committed on 07/05/2021 at 17:16. Pushed by mpyne into branch 'make_it_mojo'. Add documentation for use-inactive-modules M +9-0doc/index.docbook https://invent.kde.org/sdk/kdesrc-build/commit

T13927: Pop!_os style window tiling

2021-09-07 Thread Kevin Ottens
ervin added a comment. As far as tiling is concerned, there's a KWin script available: https://github.com/kwin-scripts/kwin-tiling I've been using it productively for a while now, it's really nice. My 0.02€ hoping it might help the conversation. If not ignore me. :-) TASK DETAIL

Re: KF6 meeting notes 2021-06-12

2021-06-19 Thread Kevin Ottens
Hello, On Friday, 18 June 2021 22:36:34 CEST Volker Krause wrote: > On Freitag, 18. Juni 2021 22:27:40 CEST Kevin Ottens wrote: > > On Friday, 18 June 2021 15:21:07 CEST Volker Krause wrote: > > > Added now, Monday 09:00 UTC. > > > > OK, I will show up only at 10

Re: KF6 meeting notes 2021-06-12

2021-06-18 Thread Kevin Ottens
On Friday, 18 June 2021 15:21:07 CEST Volker Krause wrote: > Added now, Monday 09:00 UTC. OK, I will show up only at 10 though. I can't do 9. Cheers. -- Kevin Ottens, http://ervin.ipsquad.net enioka Haute Couture - proud patron of KDE, https://hc.enioka.com/en signature.asc Descript

Re: KF6 meeting notes 2021-06-12

2021-06-18 Thread Kevin Ottens
; > https://community.kde.org/Akademy/2021/Monday > > > > What do you (plural you) think? > > I'd vote for the Monday morning slots as well, we can then still schedule > subsequent session later that week if needed, QtCS and Akadmey BoF slots are > not overlapping all day AF

Re: KF6 meeting notes 2021-06-12

2021-06-15 Thread Kevin Ottens
e with overlapping with the "KDE goal" > slots at 17:00 UTC and 18:00 UTC (there is Kirigami at 16:00 UTC, so maybe > not that one): > > https://community.kde.org/Akademy/2021/Monday > > What do you (plural you) think? FWIW, best for me would be Monday at 10:00 UTC

Re: Re KIO workers

2021-06-05 Thread Kevin Ottens
Hello, On Saturday, 5 June 2021 22:01:54 CEST David Faure wrote: > On samedi 5 juin 2021 21:07:39 CEST Kevin Ottens wrote: > > On Saturday, 5 June 2021 17:51:18 CEST David Faure wrote: > > > On samedi 5 juin 2021 16:29:10 CEST Volker Krause wrote: > > > > Do KIO s

Re: Re KIO workers

2021-06-05 Thread Kevin Ottens
that apps fork kio worker processes directly, without > going via klauncher/kinit. BTW it seems to work fine. I wonder if we should > toggle that in 5.84, as part of the incremental move to the KF6 world. Actually it works so well that I almost forgot I turned KIO_FORK_SLAVES on... Regards

Re: Koko in KDEReview

2021-05-05 Thread Kevin Ottens
with you if you pop by in the chatroom (#kde-vdg). A long time ago in a gal... well... a long time ago, we had something called KBugBuster. Was probably a bit too much bugzilla and triaging focused. Looks like it completely disappeared though, didn't find trace of its code. Cheers. PS: I warne

Re: KF6 online sprint: March 27-28

2021-03-24 Thread Kevin Ottens
illing the other slots. ;-) Regards. -- Kevin Ottens, http://ervin.ipsquad.net enioka Haute Couture - proud patron of KDE, https://hc.enioka.com/en signature.asc Description: This is a digitally signed message part.

Re: KF6 online sprint: March 27-28

2021-03-24 Thread Kevin Ottens
illing the other slots. ;-) Regards. -- Kevin Ottens, http://ervin.ipsquad.net enioka Haute Couture - proud patron of KDE, https://hc.enioka.com/en signature.asc Description: This is a digitally signed message part.

Re: KCGroups in KDEreview

2021-03-02 Thread Kevin Ottens
ser > user.slice/user-1000.slice/user@1000.service/app.slice -> UserApps > user.slice/user-1000.slice/user@1000.service/session.slice -> UserSession > user.slice/user-1000.slice/user@1000.service/background.slice -> > UserBackground Sounds good to me. Let's go for this. Re

Re: KCGroups in KDEreview

2021-03-02 Thread Kevin Ottens
ser > user.slice/user-1000.slice/user@1000.service/app.slice -> UserApps > user.slice/user-1000.slice/user@1000.service/session.slice -> UserSession > user.slice/user-1000.slice/user@1000.service/background.slice -> > UserBackground Sounds good to me. Let's go for this. Re

Re: KDE Frameworks 6 - Virtual Sprint setup

2021-01-30 Thread Kevin Ottens
Hello, On Saturday, 30 January 2021 12:14:27 CET Volker Krause wrote: > Thanks for driving this, I'm in! European hours preferred, any weekend > starting from w6 should be possible. Same here, not before week 10 or even better not before week 13. Cheers. -- Kevin Ottens

Re: KDE Frameworks 6 - Virtual Sprint setup

2021-01-30 Thread Kevin Ottens
Hello, On Saturday, 30 January 2021 12:14:27 CET Volker Krause wrote: > Thanks for driving this, I'm in! European hours preferred, any weekend > starting from w6 should be possible. Same here, not before week 10 or even better not before week 13. Cheers. -- Kevin Ottens

Re: KCGroups in KDEreview

2020-12-14 Thread Kevin Ottens
On Sunday, 13 December 2020 22:41:24 CET David Edmundson wrote: > On Thu, Dec 3, 2020 at 11:48 AM Kevin Ottens wrote: > > Hello, > > > > On Thursday, 3 December 2020 12:15:52 CET David Edmundson wrote: > > > Ultimately this isn't really dealing with cgroups direc

Re: KCGroups in KDEreview

2020-12-14 Thread Kevin Ottens
On Sunday, 13 December 2020 22:41:24 CET David Edmundson wrote: > On Thu, Dec 3, 2020 at 11:48 AM Kevin Ottens wrote: > > Hello, > > > > On Thursday, 3 December 2020 12:15:52 CET David Edmundson wrote: > > > Ultimately this isn't really dealing with cgroups direc

Re: KCGroups in KDEreview

2020-12-03 Thread Kevin Ottens
nt. Got a similar question though, which other unit types would be useful to control? Reason being that API wise I'd smell an enum for something like this. Regards. -- Kevin Ottens, http://ervin.ipsquad.net signature.asc Description: This is a digitally signed message part.

Re: KCGroups in KDEreview

2020-12-03 Thread Kevin Ottens
nt. Got a similar question though, which other unit types would be useful to control? Reason being that API wise I'd smell an enum for something like this. Regards. -- Kevin Ottens, http://ervin.ipsquad.net signature.asc Description: This is a digitally signed message part.

Re: KCGroups in KDEreview

2020-11-29 Thread Kevin Ottens
ts IMHO, often those manual tests end up used as examples by people and having better readability helps (also avoids having people copying and pasting shameful things). ;-) That's not much but I'm obviously biased by the fact that we discussed this API together already. :-) Regards. -- Kevin Ot

Re: KCGroups in KDEreview

2020-11-29 Thread Kevin Ottens
ts IMHO, often those manual tests end up used as examples by people and having better readability helps (also avoids having people copying and pasting shameful things). ;-) That's not much but I'm obviously biased by the fact that we discussed this API together already. :-) Regards. -- Kevin Ot

Re: Add loop device interface to Solid framework

2020-06-26 Thread Kevin Ottens
t it's more something you'd want in the file manager and solid reacting to it) then maybe just this time we could have a static method in the future "LoopDevice" (or whatever name ends up picked) interface for creating those. Just my 0.02€. Regards. -- Kevin Ottens, http://ervin.ip

Re: Showing respect (was: Re: The KDEPIM / Akonadi situation)

2020-06-13 Thread Kevin Ottens
Hello, On Friday, 12 June 2020 20:47:55 CEST Carl Schwan wrote: > Le vendredi, juin 12, 2020 1:45 PM, Kevin Ottens a écrit : > > Incidentally it's been the top discussion topics for the past few KDEPIM > > sprints. And also during BoFs at Akademy. I even think there's been > &

Re: Showing respect (was: Re: The KDEPIM / Akonadi situation)

2020-06-12 Thread Kevin Ottens
cussion topics for the past few KDEPIM sprints. And also during BoFs at Akademy. I even think there's been discussions about that on the pim list and IRC channels. Regards. -- Kevin Ottens, http://ervin.ipsquad.net signature.asc Description: This is a digitally signed message part.

D28590: Add a QString Solid::Device::displayName, used in Fstab Device for network mounts

2020-05-25 Thread Kevin Ottens
ervin added inline comments. INLINE COMMENTS > meven wrote in device.h:99 > Well I have to make this virtual it seems so this call is dynamically > dispatched by `return_SOLID_CALL(Ifaces::Device *, d->backendObject(), > QString(), displayName());` > I assumed this would work based on my

D28590: Add a QString Solid::Device::displayName, used in Fstab Device for network mounts

2020-05-23 Thread Kevin Ottens
ervin added a comment. LGTM now, I'll let the other reviewers weight in though. REPOSITORY R245 Solid REVISION DETAIL https://phabricator.kde.org/D28590 To: meven, #frameworks, bruns, sitter, dfaure Cc: dfaure, broulik, ervin, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham,

D28590: Add a QString Solid::Device::displayName, used in Fstab Device for network mounts

2020-05-23 Thread Kevin Ottens
ervin added inline comments. INLINE COMMENTS > device.h:99 > + */ > +virtual QString displayName() const = 0; > + Why not have a default implementation which returns descriptions()? This would make for a less intrusive patch (I think it's in part what @bruns suggested earlier).

[elisa] [Bug 406467] Option to sort artists' albums by year

2020-05-12 Thread Kevin Ottens
https://bugs.kde.org/show_bug.cgi?id=406467 Kevin Ottens changed: What|Removed |Added CC||er...@kde.org --- Comment #3 from Kevin Ottens

D28194: Fix loading button icons from qrc

2020-05-06 Thread Kevin Ottens
ervin added a comment. In D28194#632629 , @apol wrote: > Fixing QIcon would make sense but I'd say getting this in is not the worst thing either. I don't think it's QIcon's fault to be honest. The pattern used in several places of

D29120: KCM Fonts disable AA items if they are immutable

2020-04-23 Thread Kevin Ottens
ervin added a comment. LGTM but I'll let others weight in. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D29120 To: crossi, #plasma, ervin, bport, meven Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen,

D27188: KCM Notifications : Manage app-specific notifications with KCconfigXT's magic

2020-04-22 Thread Kevin Ottens
ervin requested changes to this revision. ervin added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > kcm.cpp:315 > ManagedConfigModule::defaults(); > -m_settings->defaults(); > +for (auto *behaviorSettings : m_behaviorSettingsList) { > +

D28461: In sidebar mode show if a module is in default state or not

2020-04-21 Thread Kevin Ottens
ervin accepted this revision. ervin added a comment. LGTM REPOSITORY R124 System Settings REVISION DETAIL https://phabricator.kde.org/D28461 To: bport, #plasma, ervin, meven, crossi, hchain, #vdg, mart Cc: GB_2, mart, ngraham, abetts, filipf, The-Feren-OS-Dev, ndavis, broulik,

D28460: Add KCModuleDada as base class for plugin

2020-04-21 Thread Kevin Ottens
ervin accepted this revision. ervin added a comment. This revision is now accepted and ready to land. Please fix the typo in the commit title before pushing, otherwise looks fine to me. REPOSITORY R295 KCMUtils REVISION DETAIL https://phabricator.kde.org/D28460 To: bport, #plasma,

D28462: [KCM][WIP] Add KCModuleData

2020-04-21 Thread Kevin Ottens
ervin requested changes to this revision. ervin added a comment. This revision now requires changes to proceed. Only a small thing left I think INLINE COMMENTS > cursorthemedata.h:33 > +Q_OBJECT > +//Q_PROPERTY(CursorThemeSettings *cursorThemeSettings READ > cursorThemeSettings

[frameworks-kconfig] [Bug 420379] Checkbox and its label move themselves to upper left corner when unchecked

2020-04-21 Thread Kevin Ottens
https://bugs.kde.org/show_bug.cgi?id=420379 Kevin Ottens changed: What|Removed |Added CC|er...@kde.org | --- Comment #2 from Kevin Ottens

D27540: KCModule: Indicate when a setting has been changed from the default or previous value

2020-04-20 Thread Kevin Ottens
ervin added a comment. You know it started as a proper painted indicator within the widget area, right? As such it couldn't have any of the issues you're pointing out now... Who pushed me to have them at distance I wonder? Right, was people from the VDG. So I find grand that then it goes

D29014: Fix the exclusive group box case for default indicators

2020-04-20 Thread Kevin Ottens
This revision was automatically updated to reflect the committed changes. Closed by commit R265:14ecec53296a: Fix the exclusive group box case for default indicators (authored by ervin). REPOSITORY R265 KConfigWidgets CHANGES SINCE LAST UPDATE

D29014: Fix the exclusive group box case for default indicators

2020-04-20 Thread Kevin Ottens
ervin updated this revision to Diff 80664. ervin added a comment. Fix misplaced * REPOSITORY R265 KConfigWidgets CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29014?vs=80661=80664 REVISION DETAIL https://phabricator.kde.org/D29014 AFFECTED FILES

D27540: KCModule: Indicate when a setting has been changed from the default or previous value

2020-04-20 Thread Kevin Ottens
ervin added a comment. In D27540#652669 , @ngraham wrote: > Finally clicking on the revert button in Spectacle's settings page causes a segfault for me: P590 Spectacle crash backtrace Couldn't quite

D29014: Fix the exclusive group box case for default indicators

2020-04-20 Thread Kevin Ottens
ervin created this revision. ervin added reviewers: ngraham, davidedmundson, bport, crossi. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. ervin requested review of this revision. REVISION SUMMARY Turns out there was an oversight here, in case of an

D27540: KCModule: Indicate when a setting has been changed from the default or previous value

2020-04-20 Thread Kevin Ottens
ervin added a comment. In D27540#652664 , @ngraham wrote: > David asked for VDG to approve before this landed, which wasn't done. Dude, I jumped through all the hoops for the past weeks. Also it got no further reply after I updated the

D27841: Port desktoptheme, icons and workspace KCMs to SettingStateBinding

2020-04-20 Thread Kevin Ottens
This revision was automatically updated to reflect the committed changes. Closed by commit R119:dfc144bf3f45: Port desktoptheme, icons and workspace KCMs to SettingStateBinding (authored by ervin). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE

D27840: Introduce SettingState* elements to ease KCM writing

2020-04-20 Thread Kevin Ottens
This revision was automatically updated to reflect the committed changes. Closed by commit R296:24211925f835: Introduce SettingState* elements to ease KCM writing (authored by ervin). REPOSITORY R296 KDeclarative CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27840?vs=80305=80654

D27841: Port desktoptheme, icons and workspace KCMs to SettingStateBinding

2020-04-20 Thread Kevin Ottens
This revision was automatically updated to reflect the committed changes. Closed by commit R119:dfc144bf3f45: Port desktoptheme, icons and workspace KCMs to SettingStateBinding (authored by ervin). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE

D27839: Properly name the content of the kcmcontrols project

2020-04-20 Thread Kevin Ottens
This revision was automatically updated to reflect the committed changes. Closed by commit R296:3501bcbe8da6: Properly name the content of the kcmcontrols project (authored by ervin). REPOSITORY R296 KDeclarative CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27839?vs=76951=80653

D27540: KCModule: Indicate when a setting has been changed from the default or previous value

2020-04-20 Thread Kevin Ottens
This revision was automatically updated to reflect the committed changes. Closed by commit R265:11186c056198: KCModule: Indicate when a setting has been changed from the default or previous… (authored by ervin). REPOSITORY R265 KConfigWidgets CHANGES SINCE LAST UPDATE

Re: Problems in KWayland causes by API and ABI compatibility promises

2020-04-16 Thread Kevin Ottens
Hello, On Thursday, 16 April 2020 23:38:23 CEST David Edmundson wrote: > On Wed, Apr 8, 2020 at 5:10 PM Kevin Ottens wrote: > > On Wednesday, 1 April 2020 14:04:10 CEST David Edmundson wrote: > > > Here is a list of active uses of the KWayland::Client API. >

D27840: Introduce SettingState* elements to ease KCM writing

2020-04-16 Thread Kevin Ottens
ervin updated this revision to Diff 80305. ervin added a comment. Fix issues found with Cyril's patches on various KCMs. REPOSITORY R296 KDeclarative CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27840?vs=78698=80305 REVISION DETAIL https://phabricator.kde.org/D27840

Re: Kup in KDE Review

2020-04-14 Thread Kevin Ottens
plans as > they want and each will have some settings. By the sound of it you might want to look into parameterized groups: https://api.kde.org/frameworks/kconfig/html/kconfig_compiler.html This feature has been there forever but is often overlooked. Regards. -- Kevin Ottens, http://ervin.ipsquad

D28742: Add KDialogJobUiDelegate(KJobUiDelegate::Flags) constructor

2020-04-11 Thread Kevin Ottens
ervin added a comment. Agreed, nullptr is going to be the boolean flag of our time, before it was 0 though, so still an improvement. ;-) More seriously, here I'm not sure how to avoid it, at least it's a case of "if you feel like passing nullptr here you might be doing something wrong".

D28742: Add KDialogJobUiDelegate(KJobUiDelegate::Flags) constructor

2020-04-11 Thread Kevin Ottens
ervin accepted this revision. REPOSITORY R288 KJobWidgets BRANCH master REVISION DETAIL https://phabricator.kde.org/D28742 To: dfaure, broulik, davidedmundson, ervin Cc: kossebau, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D28742: Add KDialogJobUiDelegate(KJobUiDelegate::Flags) constructor

2020-04-11 Thread Kevin Ottens
ervin added a comment. In D28742#646050 , @dfaure wrote: > In D28742#646009 , @kossebau wrote: > > > And perhaps could be defaulted to nullptr, for use-cases which do not have a window at hand and

D28742: Add KDialogJobUiDelegate(KJobUiDelegate::Flags) constructor

2020-04-11 Thread Kevin Ottens
ervin accepted this revision. ervin added a comment. Indeed, good point. REPOSITORY R288 KJobWidgets BRANCH master REVISION DETAIL https://phabricator.kde.org/D28742 To: dfaure, broulik, davidedmundson, ervin Cc: kossebau, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh,

D28753: Add KNotificationJobUiDelegate(KJobUiDelegate::Flags) constructor

2020-04-11 Thread Kevin Ottens
ervin accepted this revision. This revision is now accepted and ready to land. REPOSITORY R289 KNotifications BRANCH master REVISION DETAIL https://phabricator.kde.org/D28753 To: dfaure, broulik, davidedmundson, ervin Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham,

D28742: Add KDialogJobUiDelegate(KJobUiDelegate::Flags) constructor

2020-04-11 Thread Kevin Ottens
ervin accepted this revision. REPOSITORY R288 KJobWidgets BRANCH master REVISION DETAIL https://phabricator.kde.org/D28742 To: dfaure, broulik, davidedmundson, ervin Cc: kossebau, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28743: Port kruntest to ApplicationLauncherJob

2020-04-11 Thread Kevin Ottens
ervin accepted this revision. This revision is now accepted and ready to land. REPOSITORY R241 KIO BRANCH master REVISION DETAIL https://phabricator.kde.org/D28743 To: dfaure, broulik, davidedmundson, ervin Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28742: Add KDialogJobUiDelegate(KJobUiDelegate::Flags) constructor

2020-04-11 Thread Kevin Ottens
ervin accepted this revision. This revision is now accepted and ready to land. REPOSITORY R288 KJobWidgets BRANCH master REVISION DETAIL https://phabricator.kde.org/D28742 To: dfaure, broulik, davidedmundson, ervin Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham,

D28741: [KJobUiDelegate] Add AutoHandlingEnabled flag

2020-04-11 Thread Kevin Ottens
ervin accepted this revision. This revision is now accepted and ready to land. REPOSITORY R244 KCoreAddons BRANCH master REVISION DETAIL https://phabricator.kde.org/D28741 To: dfaure, broulik, davidedmundson, ervin Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham,

D27540: KCModule: Indicate when a setting has been changed from the default or previous value

2020-04-08 Thread Kevin Ottens
ervin updated this revision to Diff 79656. ervin marked 6 inline comments as done. ervin added a comment. Addresses David's comments REPOSITORY R265 KConfigWidgets CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27540?vs=78703=79656 REVISION DETAIL

D27540: KCModule: Indicate when a setting has been changed from the default or previous value

2020-04-08 Thread Kevin Ottens
ervin marked 6 inline comments as done. ervin added inline comments. INLINE COMMENTS > davidedmundson wrote in kconfigdialogmanager.cpp:609 > Why not item->readDefault()? Wouldn't do the same thing at all. readDefault() takes a KConfig object and updates the default value stored in the item

D27540: KCModule: Indicate when a setting has been changed from the default or previous value

2020-04-08 Thread Kevin Ottens
ervin added a comment. In D27540#638985 , @ndavis wrote: > Somehow I missed the notification that this was updated. > > Thanks for the horizontal alignment. Could you also add a left margin to the column of reset buttons? It should be the

D27540: KCModule: Indicate when a setting has been changed from the default or previous value

2020-04-08 Thread Kevin Ottens
ervin edited the test plan for this revision. REPOSITORY R265 KConfigWidgets REVISION DETAIL https://phabricator.kde.org/D27540 To: ervin, ngraham, davidedmundson, meven, crossi, bport, #vdg, ndavis, broulik Cc: alexde, ndavis, iasensio, davidre, kde-frameworks-devel, LeGast00n, cblack,

Re: Problems in KWayland causes by API and ABI compatibility promises

2020-04-08 Thread Kevin Ottens
no > kscreenlocker > powerdevil > kwayland-integration (the backend for kwindowsystem) > plasma-phone-components > plasma-integration I think the above is less of an issue, right? Because workspace would have a copy of KWayland which could be shared with whateve

D26934: KCM/Autostart Add a model to separate logic from UI

2020-04-08 Thread Kevin Ottens
ervin requested changes to this revision. ervin added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > autostart.cpp:167 > { > -KOpenWithDialog owdlg( this ); > -if (owdlg.exec() != QDialog::Accepted) > -return; > +KOpenWithDialog* owdlg =

  1   2   3   4   5   6   7   8   9   10   >