To follow up on this thread, for people who didn't see the related
gyp-developer discussion, I submitted the last make fix for the gyp
tests today. This was my minimum sanity check before switching any
buildbots over to make. I might start with some FYI bots this weekend,
then do the main bots
Have you tried starring http://crbug.com/22044 ?
On Wed, Oct 28, 2009 at 3:28 PM, Albert J. Wong (王重傑)
ajw...@chromium.org wrote:
If I'm not mistaken, I think like most everyone running on linux is using
the make build nowadays, and the make build seems to work well enough for
most people.
Not that it is effective :)
On Wed, Oct 28, 2009 at 3:34 PM, Marc-Antoine Ruel mar...@chromium.org wrote:
Have you tried starring http://crbug.com/22044 ?
On Wed, Oct 28, 2009 at 3:28 PM, Albert J. Wong (王重傑)
ajw...@chromium.org wrote:
If I'm not mistaken, I think like most everyone running
On Wed, Oct 28, 2009 at 12:34 PM, Marc-Antoine Ruel mar...@chromium.orgwrote:
Not that it is effective :)
Starred. :)
Now what?
On Wed, Oct 28, 2009 at 3:34 PM, Marc-Antoine Ruel mar...@chromium.org
wrote:
Have you tried starring http://crbug.com/22044 ?
On Wed, Oct 28, 2009 at
Step 2: ???
Step 3: Profit!
-Ben
On Wed, Oct 28, 2009 at 12:35 PM, Albert J. Wong (王重傑)
ajw...@chromium.orgwrote:
On Wed, Oct 28, 2009 at 12:34 PM, Marc-Antoine Ruel
mar...@chromium.orgwrote:
Not that it is effective :)
Starred. :)
Now what?
On Wed, Oct 28, 2009 at 3:34 PM,
FWIW, I build with scons. I only build Linux once a month or so, and
the default build instructions told me to use scons. I'd imagine lots
of people who are just playing with chrome on the side use scons too.
On Wed, Oct 28, 2009 at 12:28 PM, Albert J. Wong (王重傑)
ajw...@chromium.org wrote:
If
mmoss has been working on the make gyp generator, maybe he has a
better feel for what's keeping us from switching.
On Wed, Oct 28, 2009 at 12:35 PM, Albert J. Wong (王重傑)
ajw...@chromium.org wrote:
On Wed, Oct 28, 2009 at 12:34 PM, Marc-Antoine Ruel mar...@chromium.org
wrote:
Not that it is
So we have set of tests for gyp which are green for all the generators other
than make.
I believe mmoss has been whittling away on them, and I think its down to
just 2 failures.
go/gypbot
After that its just a matter of the will to switch over the buildbots and
fix any unforeseen issues.
-BradN
Looks like the failures are part of the same test case.
It's the case where the same source file is built as part of two different
targets using different defines.
The make generator appears to build it only one way and use it in both
targets.
-BradN
2009/10/28 Bradley Nelson
I ran into that yesterday as well trying to make a make generator fix. I
think I'll hang on until mmoss gets back since I heard he's in the middle of
trying to fix that. But assuming the unittest can all be made green, then
it's update the public instructions, and finally buildbot work?
I can
Updating the public instructions would be helpful! Please proceed.
I'd be willing do the buildbot switchover, unless someone is more eager.
I'm a little surprised that the failing test doesn't hork something in the
chromium build.
I known that there are some shared files like that (though it may
I actually got some weird warnings on the make build a while back when I
specified the same file in two sources entries...something about circular
dependencies and make ignore one. But don't remember the exact scenario.
I betcha it isn't a problem in chrome cause it'd only trigger a bug if the
Yeah, that's about it. It's definitely time to make this switch. After the
gyp tests for make are green, it just needs someone with the right buidlbot
knowledge + time to work out the details.
(Last time I did a comparison of the make vs. scons build output there were
still some differences in
On Wed, Oct 28, 2009 at 1:23 PM, Albert J. Wong (王重傑)
ajw...@chromium.org wrote:
I actually got some weird warnings on the make build a while back when I
specified the same file in two sources entries...something about circular
dependencies and make ignore one. But don't remember the exact
On Wed, Oct 28, 2009 at 1:23 PM, Albert J. Wong (王重傑)
ajw...@chromium.orgwrote:
I actually got some weird warnings on the make build a while back when I
specified the same file in two sources entries...something about circular
dependencies and make ignore one. But don't remember the exact
On Wed, Oct 28, 2009 at 1:37 PM, Evan Martin e...@chromium.org wrote:
On Wed, Oct 28, 2009 at 1:23 PM, Albert J. Wong (王重傑)
ajw...@chromium.org wrote:
I actually got some weird warnings on the make build a while back when I
specified the same file in two sources entries...something about
16 matches
Mail list logo
