Re: RFS: scuttle
On Thu, 2006-11-02 at 22:58 -0200, metal wrote:
the package with the corrections, is here:
http://xemele.cultura.gov.br/metal/debian/scuttle/
Thanks for your work. I'm sorry, it's still not fully ok, I discovered
another problem:
* You install the files into /usr/share/scuttle. However, according to
the webapps policy (still draft, but doesn't hurt to start following
it now), you should install the web accessible files
into /usr/share/scuttle/www. This is useful if there might be files
later that don't need to be web accessible.
* In debian/scuttle.{control,postrm}, you unconditionally include files
like the dbconfig-common sources. This gives trouble when purging
scuttle and dbconfig has already been removed (this was wrong in the
dbconfig-common manual). Please check the most recent dbconfig-common
manual for examples on how to handle this correctly (and also apply
the same thing to e.g. wwwconfig and even debconf).
* In debian/control, you need to explicitly depend on the mysql
commandline client, since this is used by dbconfig-common.
* In debian/patches/servicefactory.php.diff, you patch a variable name
from dbhost to dbserver. Isn't it better to ask dbc-generate-include
to write out the variable name as 'dbhost'?
Otherwise, it looks ok. Good luck with packaging!
Thijs
signature.asc
Description: This is a digitally signed message part
Re: RFS: scuttle
hi Thijs,
On 11/1/06, Thijs Kinkhorst [EMAIL PROTECTED] wrote:
Hello Marcelo,
On Tue, 2006-10-31 at 17:39 -0300, metal wrote:
hi all,
the package with the corrections indicated for Sandro Tosi, is here [0].
I would be glad if someone uploaded this package for me.
Could you take a look at what I said about debian/copyright? You don't
need to list each individual file, but if you have multiple copyright
statements you should make it clear enough to what parts of the package
this applies.
I already made
for each module, its license and copyright holder.
Regarding the Debconf templates:
Template: scuttle/locale
Type: select
Choices: ${choices}
Default: en_GB
_Description: Prefered locale:
Select the locale that you desire to used with scuttle.
This needs s/used/use/
fixed!
And this one:
Template: scuttle/adminemail
Type: string
_Description: Administrator email:
Contact address for the site administrator. Used
as the FROM address in password retrieval e-mails.
Debian is all about sensible defaults and not presenting the
administrator with too many questions. I suggest you do either of these:
compose the address out of webmaster@ + the content of /etc/mailname,
or you set it to $_SERVER['SERVER_ADMIN'] (the site admin as defined in
Apache). The user can always change this of course, but it gives a
sensible default and leaves out a debconf question.
replaced debconf message by $_SERVER['SERVER_ADMIN']
the package with the corrections, is here:
http://xemele.cultura.gov.br/metal/debian/scuttle/
cheers,
--
Marcelo Jorge Vieira (metal)
alma alucinada - http://metal.alucinados.com
orkut - http://orkut.com/Profile.aspx?uid=5437960137818787471
flickr - http://flickr.com/photos/marcelometal/
jabber - [EMAIL PROTECTED]
--
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]
Re: RFS: scuttle
Hello Marcelo,
On Tue, 2006-10-31 at 17:39 -0300, metal wrote:
hi all,
the package with the corrections indicated for Sandro Tosi, is here [0].
I would be glad if someone uploaded this package for me.
Could you take a look at what I said about debian/copyright? You don't
need to list each individual file, but if you have multiple copyright
statements you should make it clear enough to what parts of the package
this applies.
Regarding the Debconf templates:
Template: scuttle/locale
Type: select
Choices: ${choices}
Default: en_GB
_Description: Prefered locale:
Select the locale that you desire to used with scuttle.
This needs s/used/use/
And this one:
Template: scuttle/adminemail
Type: string
_Description: Administrator email:
Contact address for the site administrator. Used
as the FROM address in password retrieval e-mails.
Debian is all about sensible defaults and not presenting the
administrator with too many questions. I suggest you do either of these:
compose the address out of webmaster@ + the content of /etc/mailname,
or you set it to $_SERVER['SERVER_ADMIN'] (the site admin as defined in
Apache). The user can always change this of course, but it gives a
sensible default and leaves out a debconf question.
Thijs
signature.asc
Description: This is a digitally signed message part
Re: RFS: scuttle
hi all, the package with the corrections indicated for Sandro Tosi, is here [0]. I would be glad if someone uploaded this package for me. []'s [0] http://xemele.cultura.gov.br/metal/debian/scuttle/ On 10/30/06, Thijs Kinkhorst [EMAIL PROTECTED] wrote: Hello Marcello, On Sun, 2006-10-08 at 01:40 -0300, metal wrote: On 9/28/06, Sandro Tosi [EMAIL PROTECTED] wrote: I am looking for a sponsor for my package scuttle. - many upstream files miss copyright notice: I think you should ask upsteam to add that note (but I'd like to hear a DD comments on this) any DD comments on this?! Although it's ideal if every file where possible would have some statement of copyright, in principle it's safe to assume that any file in the distribution is covered by the licence.txt that has been included. Unless there's significant indications otherwise, i.e. a totally different coding style. - I don't know it it's enough to add here the other projects included in upstream package (phpBB2, UTF8 Helper Functions and XSPF Web Music Player) as is needed to include copyright notice on a per-file basis: someone else would comment on this? any DD comments on this?! It would not have to be per-file if you ask me, but it must be made more clear what's meant with the statements in debian/copyright. For example, which subdir all these files are in could be ok, but which individual files if there's no more compact way to tell. * debian/watch - could you please add it, if you think could worth having it (I think so... :)? the original file is .zip could I use http://sf.net/scuttle/scuttle\.(.*)\.zip ? Yes. Thijs -- Marcelo Jorge Vieira (metal) alma alucinada - http://metal.alucinados.com orkut - http://orkut.com/Profile.aspx?uid=5437960137818787471 flickr - http://flickr.com/photos/marcelometal/ jabber - [EMAIL PROTECTED] -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]
Re: RFS: scuttle
Hello Marcello, On Sun, 2006-10-08 at 01:40 -0300, metal wrote: On 9/28/06, Sandro Tosi [EMAIL PROTECTED] wrote: I am looking for a sponsor for my package scuttle. - many upstream files miss copyright notice: I think you should ask upsteam to add that note (but I'd like to hear a DD comments on this) any DD comments on this?! Although it's ideal if every file where possible would have some statement of copyright, in principle it's safe to assume that any file in the distribution is covered by the licence.txt that has been included. Unless there's significant indications otherwise, i.e. a totally different coding style. - I don't know it it's enough to add here the other projects included in upstream package (phpBB2, UTF8 Helper Functions and XSPF Web Music Player) as is needed to include copyright notice on a per-file basis: someone else would comment on this? any DD comments on this?! It would not have to be per-file if you ask me, but it must be made more clear what's meant with the statements in debian/copyright. For example, which subdir all these files are in could be ok, but which individual files if there's no more compact way to tell. * debian/watch - could you please add it, if you think could worth having it (I think so... :)? the original file is .zip could I use http://sf.net/scuttle/scuttle\.(.*)\.zip ? Yes. Thijs signature.asc Description: This is a digitally signed message part
Re: RFS: scuttle
I am looking for a sponsor for my package scuttle.
Hi Marcelo,
I cannot sponsor you package, since IANADD, but I've given it a review:
* first of all, here we like to talk with a guy with a name and a
surname, not a nick :) Please write email here with you full name (and
maybe with the email you're using in the package)
* debian/changelog
- I'd like to be Initial release (Closes: #362114), but this is
just a personal feeling, nothing is wrong in what you've written
* debian/compat
- could you bump it to 5?
* debian/control
- if you choose Yes in the previous question, bump versione
depends on debhelper to (=5)
- add Homepage meta-tag
* debian/apache.conf
- what is this file for and how would you like to interact with apache?
* debian/config.inc.php.diff
- what is this file? I got it now, but I dont like this way to
create config file too much, but if you thought about it and find no
prettier way, could be ok
* debian/scuttle.post{inst, rm}
- you restart some services, but is user aware of it? maybe he/she
would not like those service to be restarted at install/remove time...
* teste.sh
- you've added this file that is not in the upstream pkg in the
root dir: the right way is to create it in debian/ and install it
where is neede
* debian/copyright
- you missed almost everywhere copyright years; give a look at [1]
[2] [3] for some guidelines to write this file
- many upstream files miss copyright notice: I think you should
ask upsteam to add that note (but I'd like to hear a DD comments on
this)
- I don't know it it's enough to add here the other projects
included in upstream package (phpBB2, UTF8 Helper Functions and XSPF
Web Music Player) as is needed to include copyright notice on a
per-file basis: someone else would comment on this?
* debian/rules
- remove template header
* ./cache/.cvsignore other
- you should ask upstream to remove unneded file from package
* debian/watch
- could you please add it, if you think could worth having it (I
think so... :)?
Kind Regards,
Sandro
[1] http://lists.debian.org/debian-devel-announce/2003/12/msg7.html
[2] http://lists.debian.org/debian-devel-announce/2006/03/msg00023.html
[3] http://lists.debian.org/debian-legal/2003/12/msg00194.html
--
Sandro Tosi (aka Morpheus, matrixhasu)
My (little) site: http://matrixhasu.altervista.org/
--
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]
RFS: scuttle
Dear mentors, I am looking for a sponsor for my package scuttle. * Package name: scuttle Version : 0.7.2-1 Upstream Author : Marcus Campbell [EMAIL PROTECTED] * URL : http://sourceforge.net/projects/scuttle * License : GNU General Public License (GPL) Section : web It builds these binary packages: scuttle- Web-based social bookmarking system The package is lintian clean. The upload would fix these bugs: 362114 The package can be found on mentors.debian.net: - URL: http://mentors.debian.net/debian/pool/main/s/scuttle - Source repository: deb-src http://mentors.debian.net/debian unstable main contrib non-free - dget http://mentors.debian.net/debian/pool/main/s/scuttle/scuttle_0.7.2-1.dsc I would be glad if someone uploaded this package for me. Kind regards, -- Marcelo Jorge Vieira (metal) alma alucinada - http://metal.alucinados.com orkut - http://orkut.com/Profile.aspx?uid=5437960137818787471 flickr - http://flickr.com/photos/marcelometal/ jabber - [EMAIL PROTECTED] -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]
