[jira] [Commented] (SLING-4153) Cleanup Sling Content Distribution APIs
[ https://issues.apache.org/jira/browse/SLING-4153?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14235258#comment-14235258 ] Tommaso Teofili commented on SLING-4153: transport API refactoring implemented in r1643180 Cleanup Sling Content Distribution APIs --- Key: SLING-4153 URL: https://issues.apache.org/jira/browse/SLING-4153 Project: Sling Issue Type: Bug Components: Distribution Reporter: Tommaso Teofili Assignee: Tommaso Teofili Fix For: Content Distribution 0.1.0 After renaming (Replication - Distribution) and splitting of core and api modules it'd be good to revisit and review current API to make it cleaner. Main issues: remove unused / unneded APIs, refactor transport / authentication API as they mix the authentication algorithm implementation with providing the authentication secret to the transport algorithm. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
Jenkins build is back to stable : sling-trunk-1.8 » Apache Sling Event Support #502
See https://builds.apache.org/job/sling-trunk-1.8/org.apache.sling$org.apache.sling.event/502/
Jenkins build is back to stable : sling-trunk-1.8 #502
See https://builds.apache.org/job/sling-trunk-1.8/502/changes
Jenkins build is still unstable: sling-trunk-1.7 » Apache Sling Launchpad Testing #1212
See https://builds.apache.org/job/sling-trunk-1.7/org.apache.sling$org.apache.sling.launchpad.testing/1212/
Jenkins build is still unstable: sling-trunk-1.7 #1212
See https://builds.apache.org/job/sling-trunk-1.7/changes
[jira] [Resolved] (SLING-4214) Support children without root properties on the validation model resource
[
https://issues.apache.org/jira/browse/SLING-4214?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Konrad Windszus resolved SLING-4214.
Resolution: Fixed
Fixed in rev. 1643198.
Now at least the properties or the children resource must be set on each
validation model to be valid.
Support children without root properties on the validation model resource
-
Key: SLING-4214
URL: https://issues.apache.org/jira/browse/SLING-4214
Project: Sling
Issue Type: Improvement
Components: Validation
Reporter: Konrad Windszus
Assignee: Konrad Windszus
Fix For: Validation 1.0.0
Currently the validation model cannot be found in case there is no
{{properties}} resource on the root level.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Created] (SLING-4218) Throw exception for ValidationService.getValidationModel(...) if invalid validation model is found
Konrad Windszus created SLING-4218:
--
Summary: Throw exception for
ValidationService.getValidationModel(...) if invalid validation model is found
Key: SLING-4218
URL: https://issues.apache.org/jira/browse/SLING-4218
Project: Sling
Issue Type: Bug
Components: Validation
Affects Versions: Validation 1.0.0
Reporter: Konrad Windszus
Assignee: Konrad Windszus
Currently {{ValidationService.getValidationModel(...)}} always returns null
either if there is no validation model found for the given resource type or the
one being found is invalid.
To be able to distinguish those cases and also to ease fixing of invalid
validation models I propose that this method is allowed to throw
IllegalStateException's in case the matching validation model is invalid (i.e.
if it contains an invalid Validator or does not have at least properties
subnode or children subnode being set).
That should of course be explicitly stated in the Javadoc.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (SLING-4212) Sling Models: Allow multiple values from ValueMap in the resource-path injector
[
https://issues.apache.org/jira/browse/SLING-4212?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14235286#comment-14235286
]
Konrad Windszus commented on SLING-4212:
For me changing the annotations {{@Path}} and {{@ResourcePath}} to accept a
String array instead of a simple string is still backwards compatible
(instantiation works in the same way). I don't know what the baseline plugin is
thinking of that, though...
[~sseif...@pro-vision.de] Do you agree?
Sling Models: Allow multiple values from ValueMap in the resource-path
injector
---
Key: SLING-4212
URL: https://issues.apache.org/jira/browse/SLING-4212
Project: Sling
Issue Type: Improvement
Components: Extensions
Reporter: santiago garcía pimentel
Attachments: resourcePath.patch
The current implementation of the resource-path injector does not support
multiple values. I think it could be useful to inject a list of paths from
the valuemap.
I have created a small patch to allow this. Right now it only allows them
from the value map since I didn't want to change the API without consulting
you first. I you agree I can do this change as well. I also added a test case
for it.
You can see a pull request in https://github.com/apache/sling/pull/51
If there anything I can do to improve this patch, please let me know.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (SLING-4212) Sling Models: Allow multiple values from ValueMap in the resource-path injector
[ https://issues.apache.org/jira/browse/SLING-4212?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14235290#comment-14235290 ] Stefan Seifert commented on SLING-4212: --- it has to be _binary_ backwards compatible, which is i assume not the case if we change the annotation field from string to array. if you compile your code against sling models 1.1 you expect it will run with sling models 1.2 without recompilation as well. Sling Models: Allow multiple values from ValueMap in the resource-path injector --- Key: SLING-4212 URL: https://issues.apache.org/jira/browse/SLING-4212 Project: Sling Issue Type: Improvement Components: Extensions Reporter: santiago garcía pimentel Attachments: resourcePath.patch The current implementation of the resource-path injector does not support multiple values. I think it could be useful to inject a list of paths from the valuemap. I have created a small patch to allow this. Right now it only allows them from the value map since I didn't want to change the API without consulting you first. I you agree I can do this change as well. I also added a test case for it. You can see a pull request in https://github.com/apache/sling/pull/51 If there anything I can do to improve this patch, please let me know. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
Build failed in Jenkins: sling-contrib-1.6 #1388
See https://builds.apache.org/job/sling-contrib-1.6/1388/changes Changes: [kwin] SLING-4214, either children or properties must be set on each Validation model [tommaso] SLING-4153 - fixed transport API to just expose the secret -- [...truncated 9962 lines...] [INFO] Scala for Sling Demo Application - Hello World SKIPPED [INFO] Scala for Sling Demo Application - Forum .. SKIPPED [INFO] Apache Sling Contrib (Builder) SKIPPED [INFO] [INFO] BUILD FAILURE [INFO] [INFO] Total time: 9:38.596s [INFO] Finished at: Fri Dec 05 09:10:56 UTC 2014 [INFO] Final Memory: 68M/154M [INFO] [JENKINS] Archiving disabled [JENKINS] Archiving disabled [JENKINS] Archiving disabled [JENKINS] Archiving disabled [JENKINS] Archiving disabled [JENKINS] Archiving disabled [JENKINS] Archiving disabled [JENKINS] Archiving disabled [JENKINS] Archiving disabled [JENKINS] Archiving disabled [JENKINS] Archiving disabled [JENKINS] Archiving disabled [JENKINS] Archiving disabled [JENKINS] Archiving disabled [JENKINS] Archiving disabled [JENKINS] Archiving disabled [JENKINS] Archiving disabled [JENKINS] Archiving disabled [JENKINS] Archiving disabled [JENKINS] Archiving disabled [JENKINS] Archiving disabled [JENKINS] Archiving disabled [JENKINS] Archiving disabled [JENKINS] Archiving disabled [JENKINS] Archiving disabled [JENKINS] Archiving disabled [JENKINS] Archiving disabled [JENKINS] Archiving disabled [JENKINS] Archiving disabled [JENKINS] Archiving disabled [JENKINS] Archiving disabled [JENKINS] Archiving disabled [JENKINS] Archiving disabled [JENKINS] Archiving disabled [JENKINS] Archiving disabled [JENKINS] Archiving disabled [JENKINS] Archiving disabled [JENKINS] Archiving disabled [JENKINS] Archiving disabled [JENKINS] Archiving disabled [JENKINS] Archiving disabled [JENKINS] Archiving disabled [JENKINS] Archiving disabled [JENKINS] Archiving disabled [JENKINS] Archiving disabled [JENKINS] Archiving disabled [JENKINS] Archiving disabled [JENKINS] Archiving disabled [JENKINS] Archiving disabled [JENKINS] Archiving disabled [JENKINS] Archiving disabled [JENKINS] Archiving disabled [JENKINS] Archiving disabled [JENKINS] Archiving disabled [JENKINS] Archiving disabled [JENKINS] Archiving disabled [JENKINS] Archiving disabled [JENKINS] Archiving disabled [JENKINS] Archiving disabled [JENKINS] Archiving disabled [JENKINS] Archiving disabled [JENKINS] Archiving disabled [JENKINS] Archiving disabled [JENKINS] Archiving disabled [JENKINS] Archiving disabled [JENKINS] Archiving disabled [JENKINS] Archiving disabled [WARNING] The requested profile jcrinstall-tests could not be activated because it does not exist. Waiting for Jenkins to finish collecting data [ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.1:compile (default-compile) on project org.apache.sling.distribution.core: Compilation failure: Compilation failure: [ERROR] https://builds.apache.org/job/sling-contrib-1.6/ws/contrib-1.6/extensions/distribution/core/src/main/java/org/apache/sling/distribution/component/impl/DistributionComponentUtils.java:[41,47] cannot find symbol [ERROR] symbol : class DistributionTransportSecretProvider [ERROR] location: package org.apache.sling.distribution.transport [ERROR] https://builds.apache.org/job/sling-contrib-1.6/ws/contrib-1.6/extensions/distribution/core/src/main/java/org/apache/sling/distribution/component/impl/DistributionComponentUtils.java:[42,52] cannot find symbol [ERROR] symbol : class UserCredentialsDistributionTransportSecretProvider [ERROR] location: package org.apache.sling.distribution.transport.impl [ERROR] https://builds.apache.org/job/sling-contrib-1.6/ws/contrib-1.6/extensions/distribution/core/src/main/java/org/apache/sling/distribution/packaging/impl/importer/RepositoryDistributionPackageImporter.java:[38,47] cannot find symbol [ERROR] symbol : class DistributionTransportSecretProvider [ERROR] location: package org.apache.sling.distribution.transport [ERROR] https://builds.apache.org/job/sling-contrib-1.6/ws/contrib-1.6/extensions/distribution/core/src/main/java/org/apache/sling/distribution/packaging/impl/importer/RepositoryDistributionPackageImporter.java:[60,13] cannot find symbol [ERROR] symbol : class DistributionTransportSecretProvider [ERROR] location: class org.apache.sling.distribution.packaging.impl.importer.RepositoryDistributionPackageImporter [ERROR] https://builds.apache.org/job/sling-contrib-1.6/ws/contrib-1.6/extensions/distribution/core/src/main/java/org/apache/sling/distribution/packaging/impl/importer/AdvancedRemoteDistributionPackageImporter.java:[37,47] cannot find symbol [ERROR] symbol : class DistributionTransport [ERROR] location: package
Build failed in Jenkins: sling-contrib-1.6 » Apache Sling Distribution Core #1388
See https://builds.apache.org/job/sling-contrib-1.6/org.apache.sling$org.apache.sling.distribution.core/1388/changes Changes: [tommaso] SLING-4153 - fixed transport API to just expose the secret -- [...truncated 71 lines...] Downloaded: http://repo.maven.apache.org/maven2/org/apache/jackrabbit/jackrabbit-parent/2.6.2/jackrabbit-parent-2.6.2.pom (30 KB at 898.1 KB/sec) Downloading: http://repo.maven.apache.org/maven2/org/apache/jackrabbit/jackrabbit-api/2.6.2/jackrabbit-api-2.6.2.pom Downloaded: http://repo.maven.apache.org/maven2/org/apache/jackrabbit/jackrabbit-api/2.6.2/jackrabbit-api-2.6.2.pom (4 KB at 171.8 KB/sec) Downloading: http://repo.maven.apache.org/maven2/org/apache/jackrabbit/jackrabbit-spi-commons/2.6.4/jackrabbit-spi-commons-2.6.4.jar Downloading: http://repo.maven.apache.org/maven2/org/apache/jackrabbit/jackrabbit-spi/2.6.4/jackrabbit-spi-2.6.4.jar Downloading: http://repo.maven.apache.org/maven2/org/apache/sling/org.apache.sling.commons.scheduler/2.4.0/org.apache.sling.commons.scheduler-2.4.0.jar Downloading: http://repo.maven.apache.org/maven2/org/quartz-scheduler/quartz/2.2.0/quartz-2.2.0.jar Downloading: http://repo.maven.apache.org/maven2/org/apache/sling/org.apache.sling.event/3.3.0/org.apache.sling.event-3.3.0.jar Downloaded: http://repo.maven.apache.org/maven2/org/apache/jackrabbit/jackrabbit-spi/2.6.4/jackrabbit-spi-2.6.4.jar (28 KB at 541.9 KB/sec) Downloading: http://repo.maven.apache.org/maven2/org/apache/sling/org.apache.sling.hc.core/1.0.6/org.apache.sling.hc.core-1.0.6.jar Downloaded: http://repo.maven.apache.org/maven2/org/apache/sling/org.apache.sling.hc.core/1.0.6/org.apache.sling.hc.core-1.0.6.jar (36 KB at 910.6 KB/sec) Downloading: http://repo.maven.apache.org/maven2/org/apache/sling/org.apache.sling.settings/1.3.0/org.apache.sling.settings-1.3.0.jar Downloaded: http://repo.maven.apache.org/maven2/org/apache/sling/org.apache.sling.settings/1.3.0/org.apache.sling.settings-1.3.0.jar (28 KB at 1110.7 KB/sec) Downloading: http://repo.maven.apache.org/maven2/org/slf4j/slf4j-api/1.6.2/slf4j-api-1.6.2.jar Downloaded: http://repo.maven.apache.org/maven2/org/slf4j/slf4j-api/1.6.2/slf4j-api-1.6.2.jar (26 KB at 1045.3 KB/sec) Downloading: http://repo.maven.apache.org/maven2/org/slf4j/slf4j-simple/1.6.2/slf4j-simple-1.6.2.jar Downloaded: http://repo.maven.apache.org/maven2/org/apache/jackrabbit/jackrabbit-spi-commons/2.6.4/jackrabbit-spi-commons-2.6.4.jar (767 KB at 5359.1 KB/sec) Downloaded: http://repo.maven.apache.org/maven2/org/apache/sling/org.apache.sling.event/3.3.0/org.apache.sling.event-3.3.0.jar (311 KB at 2524.3 KB/sec) Downloading: http://repo.maven.apache.org/maven2/org/apache/jackrabbit/vault/org.apache.jackrabbit.vault/3.0.0/org.apache.jackrabbit.vault-3.0.0.jar Downloading: http://repo.maven.apache.org/maven2/org/apache/httpcomponents/httpasyncclient/4.0.2/httpasyncclient-4.0.2.jar Downloaded: http://repo.maven.apache.org/maven2/org/slf4j/slf4j-simple/1.6.2/slf4j-simple-1.6.2.jar (8 KB at 394.1 KB/sec) Downloading: http://repo.maven.apache.org/maven2/org/apache/httpcomponents/httpcore/4.3.2/httpcore-4.3.2.jar Downloaded: http://repo.maven.apache.org/maven2/org/apache/httpcomponents/httpasyncclient/4.0.2/httpasyncclient-4.0.2.jar (155 KB at 4056.6 KB/sec) Downloading: http://repo.maven.apache.org/maven2/org/apache/httpcomponents/httpcore-nio/4.3.2/httpcore-nio-4.3.2.jar Downloaded: http://repo.maven.apache.org/maven2/org/apache/sling/org.apache.sling.commons.scheduler/2.4.0/org.apache.sling.commons.scheduler-2.4.0.jar (629 KB at 3630.9 KB/sec) Downloading: http://repo.maven.apache.org/maven2/org/apache/httpcomponents/httpclient/4.3.5/httpclient-4.3.5.jar Downloaded: http://repo.maven.apache.org/maven2/org/apache/httpcomponents/httpcore/4.3.2/httpcore-4.3.2.jar (276 KB at 4446.0 KB/sec) Downloading: http://repo.maven.apache.org/maven2/commons-logging/commons-logging/1.1.3/commons-logging-1.1.3.jar Downloaded: http://repo.maven.apache.org/maven2/org/apache/httpcomponents/httpcore-nio/4.3.2/httpcore-nio-4.3.2.jar (310 KB at 4985.6 KB/sec) Downloading: http://repo.maven.apache.org/maven2/org/apache/httpcomponents/httpcore-osgi/4.3.2/httpcore-osgi-4.3.2.jar Downloaded: http://repo.maven.apache.org/maven2/commons-logging/commons-logging/1.1.3/commons-logging-1.1.3.jar (61 KB at 2524.8 KB/sec) Downloading: http://repo.maven.apache.org/maven2/org/apache/httpcomponents/httpclient-osgi/4.3.4/httpclient-osgi-4.3.4.jar Downloaded: http://repo.maven.apache.org/maven2/org/apache/httpcomponents/httpclient/4.3.5/httpclient-4.3.5.jar (577 KB at 7793.1 KB/sec) Downloading: http://repo.maven.apache.org/maven2/org/apache/httpcomponents/httpmime/4.3.4/httpmime-4.3.4.jar Downloaded: http://repo.maven.apache.org/maven2/org/apache/httpcomponents/httpmime/4.3.4/httpmime-4.3.4.jar (37 KB at 1915.9 KB/sec) Downloading:
[jira] [Comment Edited] (SLING-4153) Cleanup Sling Content Distribution APIs
[ https://issues.apache.org/jira/browse/SLING-4153?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14235258#comment-14235258 ] Tommaso Teofili edited comment on SLING-4153 at 12/5/14 9:19 AM: - transport API refactoring implemented in r1643180,1643201 was (Author: teofili): transport API refactoring implemented in r1643180 Cleanup Sling Content Distribution APIs --- Key: SLING-4153 URL: https://issues.apache.org/jira/browse/SLING-4153 Project: Sling Issue Type: Bug Components: Distribution Reporter: Tommaso Teofili Assignee: Tommaso Teofili Fix For: Content Distribution 0.1.0 After renaming (Replication - Distribution) and splitting of core and api modules it'd be good to revisit and review current API to make it cleaner. Main issues: remove unused / unneded APIs, refactor transport / authentication API as they mix the authentication algorithm implementation with providing the authentication secret to the transport algorithm. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
Jenkins build became unstable: sling-trunk-1.8 » Apache Sling Event Support #503
See https://builds.apache.org/job/sling-trunk-1.8/org.apache.sling$org.apache.sling.event/503/
Jenkins build became unstable: sling-trunk-1.8 » Apache Sling Launchpad Testing #503
See https://builds.apache.org/job/sling-trunk-1.8/org.apache.sling$org.apache.sling.launchpad.testing/503/
Jenkins build became unstable: sling-trunk-1.8 #503
See https://builds.apache.org/job/sling-trunk-1.8/503/changes
Re: Servlet Filter Support adding sling.filter.pattern support
Hi Antonio I agree with Justin that we should start with support for resource-types. Using path-based restrictions strongly couples configuration to content, which IMO is not a good practice. Regards Julian On Thu, Dec 4, 2014 at 3:54 PM, Antonio Sanso asa...@adobe.com wrote: thanks Justin for your feedback, if you would not mind I would try to do the opposite :) The only reason is that I have already a Pocs for this that it actually requires really few modifications.. (Felix gave me some good hints on how to implement it :)) It would probably be the same for resource type though :) regards antonio On Dec 4, 2014, at 2:29 PM, Justin Edelson jus...@justinedelson.com wrote: Hi Antonio, I'd suggest starting with support for resource type and *then* add path support. Justin On Thu, Dec 4, 2014 at 5:46 AM, Antonio Sanso asa...@adobe.com wrote: hi *, the current Sling Servlet Filter Support [0] allows to have scope dependent filter (e.g. REQUEST, INCLUDE, FORWARD, ERROR, COMPONENT). It would be nice to extend this support to have a specific filter being taken in consideration only for specific path (adding sling.filter.pattern) a bit like what currently can be done for Apache Felix filters. WDYT? regards antonio [0] http://sling.apache.org/documentation/the-sling-engine/filters.html
Build failed in Jenkins: sling-trunk-1.7 » Apache Sling Sample Integration Tests #1213
See https://builds.apache.org/job/sling-trunk-1.7/org.apache.sling$org.apache.sling.testing.samples.integrationtests/1213/ -- [INFO] [INFO] [INFO] Building Apache Sling Sample Integration Tests 1.0.7-SNAPSHOT [INFO] Downloading: http://repo.maven.apache.org/maven2/org/apache/sling/org.apache.sling.junit.scriptable/1.0.8/org.apache.sling.junit.scriptable-1.0.8.pom Downloaded: http://repo.maven.apache.org/maven2/org/apache/sling/org.apache.sling.junit.scriptable/1.0.8/org.apache.sling.junit.scriptable-1.0.8.pom (5 KB at 261.6 KB/sec) Downloading: http://repo.maven.apache.org/maven2/org/apache/sling/org.apache.sling.servlets.post/2.3.4/org.apache.sling.servlets.post-2.3.4.pom Downloaded: http://repo.maven.apache.org/maven2/org/apache/sling/org.apache.sling.servlets.post/2.3.4/org.apache.sling.servlets.post-2.3.4.pom (7 KB at 345.3 KB/sec) Downloading: http://repository.apache.org/snapshots/org/apache/sling/org.apache.sling.launchpad/7-SNAPSHOT/maven-metadata.xml Downloading: http://repository.apache.org/snapshots/org/apache/sling/org.apache.sling.launchpad/7-SNAPSHOT/org.apache.sling.launchpad-7-SNAPSHOT.pom [WARNING] The POM for org.apache.sling:org.apache.sling.launchpad:jar:standalone:7-SNAPSHOT is missing, no dependency information available Downloading: http://repo.maven.apache.org/maven2/org/apache/sling/org.apache.sling.servlets.post/2.3.4/org.apache.sling.servlets.post-2.3.4.jar Downloaded: http://repo.maven.apache.org/maven2/org/apache/sling/org.apache.sling.servlets.post/2.3.4/org.apache.sling.servlets.post-2.3.4.jar (139 KB at 2315.7 KB/sec) Downloading: http://repository.apache.org/snapshots/org/apache/sling/org.apache.sling.launchpad/7-SNAPSHOT/org.apache.sling.launchpad-7-SNAPSHOT-standalone.jar [JENKINS] Archiving disabled
Build failed in Jenkins: sling-trunk-1.7 #1213
See https://builds.apache.org/job/sling-trunk-1.7/1213/changes Changes: [tommaso] SLING-4153 - fixed transport API to just expose the secret -- [...truncated 60903 lines...] [INFO] Apache Sling Commons Java Compiler SUCCESS [11.852s] [INFO] Apache Sling JSON Library . SUCCESS [12.234s] [INFO] Apache Sling SLF4J Implementation (Logback) ... SUCCESS [43.163s] [INFO] Apache Sling OSGi LogService Implementation ... SUCCESS [7.858s] [INFO] Apache Sling MIME type mapping support SUCCESS [11.676s] [INFO] Apache Sling Commons OSGi support . SUCCESS [10.539s] [INFO] Apache Sling Scheduler Support SUCCESS [12.323s] [INFO] Apache Sling Testing Utilities SUCCESS [24.424s] [INFO] Apache Sling Thread Dumper SUCCESS [6.759s] [INFO] Apache Sling Thread Support ... SUCCESS [7.985s] [INFO] Apache Sling Authentication Service ... SUCCESS [10.688s] [INFO] Apache Sling Form Based Authentication Handler SUCCESS [10.637s] [INFO] Apache Sling Engine Implementation SUCCESS [24.518s] [INFO] Apache Sling Repository API Bundle SUCCESS [9.640s] [INFO] Apache Sling JCR Base Bundle .. SUCCESS [11.545s] [INFO] Apache Sling JCR ClassLoader .. SUCCESS [7.974s] [INFO] Apache Sling Initial Content Loader ... SUCCESS [11.348s] [INFO] Apache Sling Jackrabbit Embedded Repository ... SUCCESS [22.278s] [INFO] Apache Sling Jackrabbit UserManager Support ... SUCCESS [8.745s] [INFO] Apache Sling Jackrabbit JSR-283 Access Control Manager Support SUCCESS [8.846s] [INFO] Apache Sling Wrapper Bundle for the JCR API ... SUCCESS [6.890s] [INFO] Apache Sling JCR Resource Resolver SUCCESS [48.468s] [INFO] Apache Sling JCR Repository Registration .. SUCCESS [12.808s] [INFO] Apache Sling Simple WebDAV Access to repositories . SUCCESS [10.922s] [INFO] Apache Sling DavEx Access to repositories . SUCCESS [10.767s] [INFO] Apache Sling JCR WebConsole Bundle SUCCESS [7.381s] [INFO] Apache Sling Oak Repository Server SUCCESS [11.161s] [INFO] Apache Sling SlingRepository Integration Tests SUCCESS [1:04.283s] [INFO] Apache Sling Servlet Resolver . SUCCESS [12.424s] [INFO] Apache Sling Default GET Servlets . SUCCESS [11.135s] [INFO] Apache Sling Default POST Servlets SUCCESS [12.692s] [INFO] Apache Sling Compat Servlets .. SUCCESS [10.215s] [INFO] Apache Sling Scripting Implementation API . SUCCESS [9.293s] [INFO] Apache Sling Scripting Core implementation SUCCESS [22.221s] [INFO] Apache Sling Scripting JavaScript Support . SUCCESS [23.287s] [INFO] Apache Sling Scripting JSP Support SUCCESS [15.764s] [INFO] Apache Sling JSP Tag Library .. SUCCESS [14.008s] [INFO] Apache Sling JSP Standard Tag Library . SUCCESS [6.789s] [INFO] Apache Sling Adapter Manager Implementation ... SUCCESS [7.895s] [INFO] Apache Sling Bundle Resource Provider . SUCCESS [7.130s] [INFO] Apache Sling Distributed Event Admin .. SUCCESS [9.690s] [INFO] Apache Sling Discovery API SUCCESS [6.273s] [INFO] Apache Sling Resource-Based Discovery Service . SUCCESS [3:01.983s] [INFO] Apache Sling Discovery Support Bundle . SUCCESS [6.706s] [INFO] Apache Sling Discovery Standalone Implementation .. SUCCESS [8.077s] [INFO] Apache Sling Event Support SUCCESS [12:56.547s] [INFO] Apache Sling Feature Flags SUCCESS [7.136s] [INFO] Apache Sling Filesystem Resource Provider . SUCCESS [7.511s] [INFO] Apache Sling javax.activation bundle .. SUCCESS [7.966s] [INFO] Apache Sling Service User Mapper .. SUCCESS [11.064s] [INFO] Apache Sling Settings . SUCCESS [8.905s] [INFO] Apache Sling Web Console Branding . SUCCESS [6.579s] [INFO] Apache Sling Web Console Security Provider SUCCESS [6.568s] [INFO] Apache Sling Explorer . SUCCESS [9.944s] [INFO] Apache Sling Health Check Core SUCCESS [14.505s] [INFO] Apache Sling Health Check Annotations . SUCCESS [6.584s] [INFO] Apache Sling Health Check Samples . SUCCESS [9.109s] [INFO] Apache Sling Health Check Support Components .. SUCCESS [12.294s] [INFO] Apache Sling Health Check Webconsole Plugin ... SUCCESS [9.598s] [INFO] Apache Sling Health Check JUnit Bridge SUCCESS [9.744s] [INFO] Apache Sling Health Check Integration Tests ... SUCCESS [27.665s] [INFO] Apache Sling Health Check Reactor POM . SUCCESS [4.734s] [INFO] Apache
[jira] [Commented] (SLING-4218) Throw exception for ValidationService.getValidationModel(...) if invalid validation model is found
[
https://issues.apache.org/jira/browse/SLING-4218?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14235315#comment-14235315
]
Konrad Windszus commented on SLING-4218:
Fixed in rev. 1643214.
Throw exception for ValidationService.getValidationModel(...) if invalid
validation model is found
--
Key: SLING-4218
URL: https://issues.apache.org/jira/browse/SLING-4218
Project: Sling
Issue Type: Bug
Components: Validation
Affects Versions: Validation 1.0.0
Reporter: Konrad Windszus
Assignee: Konrad Windszus
Currently {{ValidationService.getValidationModel(...)}} always returns null
either if there is no validation model found for the given resource type or
the one being found is invalid.
To be able to distinguish those cases and also to ease fixing of invalid
validation models I propose that this method is allowed to throw
IllegalStateException's in case the matching validation model is invalid
(i.e. if it contains an invalid Validator or does not have at least
properties subnode or children subnode being set).
That should of course be explicitly stated in the Javadoc.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Resolved] (SLING-4218) Throw exception for ValidationService.getValidationModel(...) if invalid validation model is found
[
https://issues.apache.org/jira/browse/SLING-4218?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Konrad Windszus resolved SLING-4218.
Resolution: Fixed
Fix Version/s: Validation 1.0.0
Throw exception for ValidationService.getValidationModel(...) if invalid
validation model is found
--
Key: SLING-4218
URL: https://issues.apache.org/jira/browse/SLING-4218
Project: Sling
Issue Type: Bug
Components: Validation
Affects Versions: Validation 1.0.0
Reporter: Konrad Windszus
Assignee: Konrad Windszus
Fix For: Validation 1.0.0
Currently {{ValidationService.getValidationModel(...)}} always returns null
either if there is no validation model found for the given resource type or
the one being found is invalid.
To be able to distinguish those cases and also to ease fixing of invalid
validation models I propose that this method is allowed to throw
IllegalStateException's in case the matching validation model is invalid
(i.e. if it contains an invalid Validator or does not have at least
properties subnode or children subnode being set).
That should of course be explicitly stated in the Javadoc.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (SLING-3836) Allow deep vs shallow replication options
[ https://issues.apache.org/jira/browse/SLING-3836?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14235321#comment-14235321 ] Marius Petria commented on SLING-3836: -- Committed revision 1643219. Added isDeep option to DistributionRequests to control if all aths should be deep or shallow. Allow deep vs shallow replication options - Key: SLING-3836 URL: https://issues.apache.org/jira/browse/SLING-3836 Project: Sling Issue Type: Improvement Components: Distribution Reporter: Marius Petria Assignee: Tommaso Teofili Labels: replication Users of replication should have a way to choose whether to replicate a node - deep: including all its subtree - shallow: including just he node properties Typically an user editing content visually will trigger a replication of only the edited content (shallow). However an user importing a lot of content will trigger a deep replication after all content is imported. Shallow replication is more targeted and produces the least changes in the system and it is probably best fitted to be the default replication option. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Assigned] (SLING-3836) Allow deep vs shallow replication options
[ https://issues.apache.org/jira/browse/SLING-3836?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Marius Petria reassigned SLING-3836: Assignee: Marius Petria (was: Tommaso Teofili) Allow deep vs shallow replication options - Key: SLING-3836 URL: https://issues.apache.org/jira/browse/SLING-3836 Project: Sling Issue Type: Improvement Components: Distribution Reporter: Marius Petria Assignee: Marius Petria Labels: replication Users of replication should have a way to choose whether to replicate a node - deep: including all its subtree - shallow: including just he node properties Typically an user editing content visually will trigger a replication of only the edited content (shallow). However an user importing a lot of content will trigger a deep replication after all content is imported. Shallow replication is more targeted and produces the least changes in the system and it is probably best fitted to be the default replication option. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Resolved] (SLING-3836) Allow deep vs shallow replication options
[ https://issues.apache.org/jira/browse/SLING-3836?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Marius Petria resolved SLING-3836. -- Resolution: Fixed Allow deep vs shallow replication options - Key: SLING-3836 URL: https://issues.apache.org/jira/browse/SLING-3836 Project: Sling Issue Type: Improvement Components: Distribution Reporter: Marius Petria Assignee: Tommaso Teofili Labels: replication Users of replication should have a way to choose whether to replicate a node - deep: including all its subtree - shallow: including just he node properties Typically an user editing content visually will trigger a replication of only the edited content (shallow). However an user importing a lot of content will trigger a deep replication after all content is imported. Shallow replication is more targeted and produces the least changes in the system and it is probably best fitted to be the default replication option. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Assigned] (SLING-3829) Add support for Content-Disposition attachment
[ https://issues.apache.org/jira/browse/SLING-3829?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Antonio Sanso reassigned SLING-3829: Assignee: Antonio Sanso Add support for Content-Disposition attachment --- Key: SLING-3829 URL: https://issues.apache.org/jira/browse/SLING-3829 Project: Sling Issue Type: Improvement Components: Extensions Reporter: Antonio Sanso Assignee: Antonio Sanso Priority: Minor In some situation will be useful (and safer) to force Content-Disposition attachment for some Content-Type (configurable ) under some specific (and sensitive) path (configurable) -- This message was sent by Atlassian JIRA (v6.3.4#6332)
Re: Servlet Filter Support adding sling.filter.pattern support
hi Julian On Dec 5, 2014, at 10:31 AM, Julian Sedding jsedd...@gmail.com wrote: Hi Antonio I agree with Justin that we should start with support for resource-types. as said I agree we should have support for both. E.g. sling.filter.pattern, sling.filter.resourceType Using path-based restrictions strongly couples configuration to content, which IMO is not a good practice. At the end of the day is the developer choice to choose the one she needs. In my case for example I cannot use the resource type approach. See also https://issues.apache.org/jira/browse/SLING-3829 regards antonio Regards Julian On Thu, Dec 4, 2014 at 3:54 PM, Antonio Sanso asa...@adobe.com wrote: thanks Justin for your feedback, if you would not mind I would try to do the opposite :) The only reason is that I have already a Pocs for this that it actually requires really few modifications.. (Felix gave me some good hints on how to implement it :)) It would probably be the same for resource type though :) regards antonio On Dec 4, 2014, at 2:29 PM, Justin Edelson jus...@justinedelson.com wrote: Hi Antonio, I'd suggest starting with support for resource type and *then* add path support. Justin On Thu, Dec 4, 2014 at 5:46 AM, Antonio Sanso asa...@adobe.com wrote: hi *, the current Sling Servlet Filter Support [0] allows to have scope dependent filter (e.g. REQUEST, INCLUDE, FORWARD, ERROR, COMPONENT). It would be nice to extend this support to have a specific filter being taken in consideration only for specific path (adding sling.filter.pattern) a bit like what currently can be done for Apache Felix filters. WDYT? regards antonio [0] http://sling.apache.org/documentation/the-sling-engine/filters.html
[jira] [Commented] (SLING-3829) Add support for Content-Disposition attachment
[ https://issues.apache.org/jira/browse/SLING-3829?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14235326#comment-14235326 ] Antonio Sanso commented on SLING-3829: -- adding mailing list thread http://sling.markmail.org/thread/2cvh26uo35nk2u73 Add support for Content-Disposition attachment --- Key: SLING-3829 URL: https://issues.apache.org/jira/browse/SLING-3829 Project: Sling Issue Type: Improvement Components: Extensions Reporter: Antonio Sanso Assignee: Antonio Sanso Priority: Minor In some situation will be useful (and safer) to force Content-Disposition attachment for some Content-Type (configurable ) under some specific (and sensitive) path (configurable) -- This message was sent by Atlassian JIRA (v6.3.4#6332)
Jenkins build is back to normal : sling-contrib-1.6 » Apache Sling Distribution Core #1389
See https://builds.apache.org/job/sling-contrib-1.6/org.apache.sling$org.apache.sling.distribution.core/1389/changes
Build failed in Jenkins: sling-contrib-1.6 #1389
See https://builds.apache.org/job/sling-contrib-1.6/1389/changes Changes: [kwin] SLING-4218 throw exception in case validation model is not valid clarify in JavaDoc which exceptions are thrown and where to expect null [tommaso] SLING-4153 - fixed transport API to just expose the secret -- [...truncated 10018 lines...] Downloaded: http://repo.maven.apache.org/maven2/org/apache/maven/plugins/maven-dependency-plugin/2.8/maven-dependency-plugin-2.8.jar (150 KB at 9349.7 KB/sec) Downloading: http://repo.maven.apache.org/maven2/org/apache/sling/org.apache.sling.testing.tools/1.0.8/org.apache.sling.testing.tools-1.0.8.pom Downloaded: http://repo.maven.apache.org/maven2/org/apache/sling/org.apache.sling.testing.tools/1.0.8/org.apache.sling.testing.tools-1.0.8.pom (5 KB at 526.9 KB/sec) Downloading: http://repo.maven.apache.org/maven2/org/apache/sling/sling/19/sling-19.pom Downloaded: http://repo.maven.apache.org/maven2/org/apache/sling/sling/19/sling-19.pom (45 KB at 2622.9 KB/sec) Downloading: http://repo.maven.apache.org/maven2/org/apache/commons/commons-exec/1.1/commons-exec-1.1.pom Downloaded: http://repo.maven.apache.org/maven2/org/apache/commons/commons-exec/1.1/commons-exec-1.1.pom (11 KB at 1368.7 KB/sec) Downloading: http://repo.maven.apache.org/maven2/org/apache/httpcomponents/httpcore/4.1/httpcore-4.1.pom Downloaded: http://repo.maven.apache.org/maven2/org/apache/httpcomponents/httpcore/4.1/httpcore-4.1.pom (9 KB at 1020.3 KB/sec) Downloading: http://repo.maven.apache.org/maven2/org/apache/httpcomponents/httpcomponents-core/4.1/httpcomponents-core-4.1.pom Downloaded: http://repo.maven.apache.org/maven2/org/apache/httpcomponents/httpcomponents-core/4.1/httpcomponents-core-4.1.pom (9 KB at 981.1 KB/sec) Downloading: http://repo.maven.apache.org/maven2/org/apache/httpcomponents/httpclient/4.1/httpclient-4.1.pom Downloaded: http://repo.maven.apache.org/maven2/org/apache/httpcomponents/httpclient/4.1/httpclient-4.1.pom (6 KB at 654.8 KB/sec) Downloading: http://repo.maven.apache.org/maven2/org/apache/httpcomponents/httpcomponents-client/4.1/httpcomponents-client-4.1.pom Downloaded: http://repo.maven.apache.org/maven2/org/apache/httpcomponents/httpcomponents-client/4.1/httpcomponents-client-4.1.pom (12 KB at 1377.4 KB/sec) Downloading: http://repo.maven.apache.org/maven2/org/apache/httpcomponents/httpmime/4.1/httpmime-4.1.pom Downloaded: http://repo.maven.apache.org/maven2/org/apache/httpcomponents/httpmime/4.1/httpmime-4.1.pom (6 KB at 566.1 KB/sec) Downloading: http://repo.maven.apache.org/maven2/org/apache/sling/org.apache.sling.commons.json/2.0.6/org.apache.sling.commons.json-2.0.6.pom Downloaded: http://repo.maven.apache.org/maven2/org/apache/sling/org.apache.sling.commons.json/2.0.6/org.apache.sling.commons.json-2.0.6.pom (4 KB at 351.6 KB/sec) Downloading: http://repo.maven.apache.org/maven2/org/apache/sling/org.apache.sling.discovery.impl/1.0.12/org.apache.sling.discovery.impl-1.0.12.pom Downloaded: http://repo.maven.apache.org/maven2/org/apache/sling/org.apache.sling.discovery.impl/1.0.12/org.apache.sling.discovery.impl-1.0.12.pom (10 KB at 1057.2 KB/sec) Downloading: http://repo.maven.apache.org/maven2/org/apache/httpcomponents/httpcore-osgi/4.3.1/httpcore-osgi-4.3.1.pom Downloaded: http://repo.maven.apache.org/maven2/org/apache/httpcomponents/httpcore-osgi/4.3.1/httpcore-osgi-4.3.1.pom (4 KB at 484.3 KB/sec) Downloading: http://repo.maven.apache.org/maven2/org/apache/httpcomponents/httpcomponents-core/4.3.1/httpcomponents-core-4.3.1.pom Downloaded: http://repo.maven.apache.org/maven2/org/apache/httpcomponents/httpcomponents-core/4.3.1/httpcomponents-core-4.3.1.pom (12 KB at 1483.6 KB/sec) Downloading: http://repo.maven.apache.org/maven2/org/apache/httpcomponents/httpcore/4.3.1/httpcore-4.3.1.pom Downloaded: http://repo.maven.apache.org/maven2/org/apache/httpcomponents/httpcore/4.3.1/httpcore-4.3.1.pom (5 KB at 561.2 KB/sec) Downloading: http://repo.maven.apache.org/maven2/org/apache/httpcomponents/httpcore-nio/4.3.1/httpcore-nio-4.3.1.pom Downloaded: http://repo.maven.apache.org/maven2/org/apache/httpcomponents/httpcore-nio/4.3.1/httpcore-nio-4.3.1.pom (5 KB at 685.4 KB/sec) Downloading: http://repo.maven.apache.org/maven2/org/apache/httpcomponents/httpclient-osgi/4.3.2/httpclient-osgi-4.3.2.pom Downloaded: http://repo.maven.apache.org/maven2/org/apache/httpcomponents/httpclient-osgi/4.3.2/httpclient-osgi-4.3.2.pom (8 KB at 612.6 KB/sec) Downloading: http://repo.maven.apache.org/maven2/org/apache/httpcomponents/httpcomponents-client/4.3.2/httpcomponents-client-4.3.2.pom Downloaded: http://repo.maven.apache.org/maven2/org/apache/httpcomponents/httpcomponents-client/4.3.2/httpcomponents-client-4.3.2.pom (16 KB at 1939.8 KB/sec) Downloading: http://repo.maven.apache.org/maven2/org/apache/httpcomponents/httpclient/4.3.2/httpclient-4.3.2.pom Downloaded:
Build failed in Jenkins: sling-contrib-1.6 » Apache Sling Distribution Integration Tests #1389
See https://builds.apache.org/job/sling-contrib-1.6/org.apache.sling$org.apache.sling.distribution.it/1389/ -- [INFO] [INFO] [INFO] Building Apache Sling Distribution Integration Tests 0.0.1-SNAPSHOT [INFO] Downloading: http://repo.maven.apache.org/maven2/org/apache/maven/plugins/maven-dependency-plugin/2.8/maven-dependency-plugin-2.8.pom Downloaded: http://repo.maven.apache.org/maven2/org/apache/maven/plugins/maven-dependency-plugin/2.8/maven-dependency-plugin-2.8.pom (12 KB at 1242.8 KB/sec) Downloading: http://repo.maven.apache.org/maven2/org/apache/maven/plugins/maven-dependency-plugin/2.8/maven-dependency-plugin-2.8.jar Downloaded: http://repo.maven.apache.org/maven2/org/apache/maven/plugins/maven-dependency-plugin/2.8/maven-dependency-plugin-2.8.jar (150 KB at 9349.7 KB/sec) Downloading: http://repo.maven.apache.org/maven2/org/apache/sling/org.apache.sling.testing.tools/1.0.8/org.apache.sling.testing.tools-1.0.8.pom Downloaded: http://repo.maven.apache.org/maven2/org/apache/sling/org.apache.sling.testing.tools/1.0.8/org.apache.sling.testing.tools-1.0.8.pom (5 KB at 526.9 KB/sec) Downloading: http://repo.maven.apache.org/maven2/org/apache/sling/sling/19/sling-19.pom Downloaded: http://repo.maven.apache.org/maven2/org/apache/sling/sling/19/sling-19.pom (45 KB at 2622.9 KB/sec) Downloading: http://repo.maven.apache.org/maven2/org/apache/commons/commons-exec/1.1/commons-exec-1.1.pom Downloaded: http://repo.maven.apache.org/maven2/org/apache/commons/commons-exec/1.1/commons-exec-1.1.pom (11 KB at 1368.7 KB/sec) Downloading: http://repo.maven.apache.org/maven2/org/apache/httpcomponents/httpcore/4.1/httpcore-4.1.pom Downloaded: http://repo.maven.apache.org/maven2/org/apache/httpcomponents/httpcore/4.1/httpcore-4.1.pom (9 KB at 1020.3 KB/sec) Downloading: http://repo.maven.apache.org/maven2/org/apache/httpcomponents/httpcomponents-core/4.1/httpcomponents-core-4.1.pom Downloaded: http://repo.maven.apache.org/maven2/org/apache/httpcomponents/httpcomponents-core/4.1/httpcomponents-core-4.1.pom (9 KB at 981.1 KB/sec) Downloading: http://repo.maven.apache.org/maven2/org/apache/httpcomponents/httpclient/4.1/httpclient-4.1.pom Downloaded: http://repo.maven.apache.org/maven2/org/apache/httpcomponents/httpclient/4.1/httpclient-4.1.pom (6 KB at 654.8 KB/sec) Downloading: http://repo.maven.apache.org/maven2/org/apache/httpcomponents/httpcomponents-client/4.1/httpcomponents-client-4.1.pom Downloaded: http://repo.maven.apache.org/maven2/org/apache/httpcomponents/httpcomponents-client/4.1/httpcomponents-client-4.1.pom (12 KB at 1377.4 KB/sec) Downloading: http://repo.maven.apache.org/maven2/org/apache/httpcomponents/httpmime/4.1/httpmime-4.1.pom Downloaded: http://repo.maven.apache.org/maven2/org/apache/httpcomponents/httpmime/4.1/httpmime-4.1.pom (6 KB at 566.1 KB/sec) Downloading: http://repo.maven.apache.org/maven2/org/apache/sling/org.apache.sling.commons.json/2.0.6/org.apache.sling.commons.json-2.0.6.pom Downloaded: http://repo.maven.apache.org/maven2/org/apache/sling/org.apache.sling.commons.json/2.0.6/org.apache.sling.commons.json-2.0.6.pom (4 KB at 351.6 KB/sec) Downloading: http://repo.maven.apache.org/maven2/org/apache/sling/org.apache.sling.discovery.impl/1.0.12/org.apache.sling.discovery.impl-1.0.12.pom Downloaded: http://repo.maven.apache.org/maven2/org/apache/sling/org.apache.sling.discovery.impl/1.0.12/org.apache.sling.discovery.impl-1.0.12.pom (10 KB at 1057.2 KB/sec) Downloading: http://repo.maven.apache.org/maven2/org/apache/httpcomponents/httpcore-osgi/4.3.1/httpcore-osgi-4.3.1.pom Downloaded: http://repo.maven.apache.org/maven2/org/apache/httpcomponents/httpcore-osgi/4.3.1/httpcore-osgi-4.3.1.pom (4 KB at 484.3 KB/sec) Downloading: http://repo.maven.apache.org/maven2/org/apache/httpcomponents/httpcomponents-core/4.3.1/httpcomponents-core-4.3.1.pom Downloaded: http://repo.maven.apache.org/maven2/org/apache/httpcomponents/httpcomponents-core/4.3.1/httpcomponents-core-4.3.1.pom (12 KB at 1483.6 KB/sec) Downloading: http://repo.maven.apache.org/maven2/org/apache/httpcomponents/httpcore/4.3.1/httpcore-4.3.1.pom Downloaded: http://repo.maven.apache.org/maven2/org/apache/httpcomponents/httpcore/4.3.1/httpcore-4.3.1.pom (5 KB at 561.2 KB/sec) Downloading: http://repo.maven.apache.org/maven2/org/apache/httpcomponents/httpcore-nio/4.3.1/httpcore-nio-4.3.1.pom Downloaded: http://repo.maven.apache.org/maven2/org/apache/httpcomponents/httpcore-nio/4.3.1/httpcore-nio-4.3.1.pom (5 KB at 685.4 KB/sec) Downloading: http://repo.maven.apache.org/maven2/org/apache/httpcomponents/httpclient-osgi/4.3.2/httpclient-osgi-4.3.2.pom Downloaded:
Jenkins build is back to stable : sling-trunk-1.8 » Apache Sling Launchpad Testing #504
See https://builds.apache.org/job/sling-trunk-1.8/org.apache.sling$org.apache.sling.launchpad.testing/504/
Jenkins build is back to stable : sling-trunk-1.8 » Apache Sling Event Support #504
See https://builds.apache.org/job/sling-trunk-1.8/org.apache.sling$org.apache.sling.event/504/
Jenkins build is back to stable : sling-trunk-1.8 #504
See https://builds.apache.org/job/sling-trunk-1.8/504/changes
[jira] [Created] (SLING-4219) [Sightly] Unrecognised operators in exceptions are not properly handled
Radu Cotescu created SLING-4219:
---
Summary: [Sightly] Unrecognised operators in exceptions are not
properly handled
Key: SLING-4219
URL: https://issues.apache.org/jira/browse/SLING-4219
Project: Sling
Issue Type: Bug
Components: Scripting
Reporter: Radu Cotescu
Priority: Minor
Fix For: Scripting Sightly Engine 1.0.0
The
{{org.apache.sling.scripting.sightly.impl.compiler.frontend.SightlyParserErrorListener}}
handles ANTLR parsing errors, in order to provide more detailed and easier to
understand error reporting for Sightly scripts.
For the cases when ANTLR doesn't provide a {{RecognitionException}}, although
the listener still throws an error, the error is because the
{{SightlyParsingException}} is instantiated with a {{null}} cause.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
Jenkins build is unstable: sling-trunk-1.7 » Apache Sling Launchpad Testing #1214
See https://builds.apache.org/job/sling-trunk-1.7/org.apache.sling$org.apache.sling.launchpad.testing/1214/
Jenkins build is back to normal : sling-trunk-1.7 » Apache Sling Sample Integration Tests #1214
See https://builds.apache.org/job/sling-trunk-1.7/org.apache.sling$org.apache.sling.testing.samples.integrationtests/1214/
Jenkins build is unstable: sling-trunk-1.7 #1214
See https://builds.apache.org/job/sling-trunk-1.7/1214/changes
Jenkins build became unstable: sling-trunk-1.6 » Apache Sling Resource-Based Discovery Service #2831
See https://builds.apache.org/job/sling-trunk-1.6/org.apache.sling$org.apache.sling.discovery.impl/2831/
Jenkins build is still unstable: sling-trunk-1.6 » Apache Sling Launchpad Testing #2831
See https://builds.apache.org/job/sling-trunk-1.6/org.apache.sling$org.apache.sling.launchpad.testing/2831/
Jenkins build is still unstable: sling-trunk-1.6 #2831
See https://builds.apache.org/job/sling-trunk-1.6/changes
Build failed in Jenkins: sling-trunk-1.6 #2832
See https://builds.apache.org/job/sling-trunk-1.6/2832/ -- [...truncated 121 lines...] AU bundles/engine/src/main/java/org/apache/sling/engine/impl/DefaultErrorHandler.java A bundles/engine/src/main/java/org/apache/sling/engine/impl/helper AU bundles/engine/src/main/java/org/apache/sling/engine/impl/helper/SlingFilterConfig.java AU bundles/engine/src/main/java/org/apache/sling/engine/impl/helper/RequestListenerManager.java A bundles/engine/src/main/java/org/apache/sling/engine/impl/helper/SlingServletContext3.java AU bundles/engine/src/main/java/org/apache/sling/engine/impl/helper/NullResourceBundle.java A bundles/engine/src/main/java/org/apache/sling/engine/impl/helper/ExternalServletContextWrapper.java AU bundles/engine/src/main/java/org/apache/sling/engine/impl/helper/SlingServletContext.java A bundles/engine/src/main/java/org/apache/sling/engine/impl/SlingHttpServletRequestImpl3.java AU bundles/engine/src/main/java/org/apache/sling/engine/impl/SlingSettingsServiceImpl.java A bundles/engine/src/main/java/org/apache/sling/engine/impl/adapter AU bundles/engine/src/main/java/org/apache/sling/engine/impl/adapter/SlingServletResponseAdapter.java AU bundles/engine/src/main/java/org/apache/sling/engine/impl/adapter/SlingServletRequestAdapter.java A bundles/engine/src/main/java/org/apache/sling/engine/impl/log A bundles/engine/src/main/java/org/apache/sling/engine/impl/log/RequestLoggerRequest.java AU bundles/engine/src/main/java/org/apache/sling/engine/impl/log/CustomLogFormat.java A bundles/engine/src/main/java/org/apache/sling/engine/impl/log/RequestLoggerResponse.java AU bundles/engine/src/main/java/org/apache/sling/engine/impl/log/RequestLogger.java AU bundles/engine/src/main/java/org/apache/sling/engine/impl/log/RequestLoggerService.java AU bundles/engine/src/main/java/org/apache/sling/engine/impl/log/FileRequestLog.java AU bundles/engine/src/main/java/org/apache/sling/engine/impl/log/LoggerRequestLog.java A bundles/engine/src/main/java/org/apache/sling/engine/impl/log/RequestLoggerFilter.java AU bundles/engine/src/main/java/org/apache/sling/engine/impl/log/RequestLogServiceFacade.java A bundles/engine/src/main/java/org/apache/sling/engine/impl/filter AU bundles/engine/src/main/java/org/apache/sling/engine/impl/filter/RequestSlingFilterChain.java AU bundles/engine/src/main/java/org/apache/sling/engine/impl/filter/FilterHandle.java AU bundles/engine/src/main/java/org/apache/sling/engine/impl/filter/ServletFilterManager.java AU bundles/engine/src/main/java/org/apache/sling/engine/impl/filter/SlingFilterChainHelper.java AU bundles/engine/src/main/java/org/apache/sling/engine/impl/filter/SlingComponentFilterChain.java AU bundles/engine/src/main/java/org/apache/sling/engine/impl/filter/AbstractSlingFilterChain.java A bundles/engine/src/main/java/org/apache/sling/engine/impl/debug AU bundles/engine/src/main/java/org/apache/sling/engine/impl/debug/RequestProgressTrackerLogFilter.java AU bundles/engine/src/main/java/org/apache/sling/engine/impl/SlingRequestProcessorImpl.java A bundles/engine/src/main/java/org/apache/sling/engine/impl/request AU bundles/engine/src/main/java/org/apache/sling/engine/impl/request/RequestData.java AU bundles/engine/src/main/java/org/apache/sling/engine/impl/request/ContentData.java AU bundles/engine/src/main/java/org/apache/sling/engine/impl/request/SlingRequestProgressTracker.java AU bundles/engine/src/main/java/org/apache/sling/engine/impl/request/RequestHistoryConsolePlugin.java AU bundles/engine/src/main/java/org/apache/sling/engine/impl/request/SlingRequestDispatcher.java AU bundles/engine/src/main/java/org/apache/sling/engine/impl/request/SlingRequestPathInfo.java AU bundles/engine/src/main/java/org/apache/sling/engine/impl/SlingHttpServletRequestImpl.java A bundles/engine/src/main/java/org/apache/sling/engine/impl/RequestProcessorMBeanImpl.java A bundles/engine/src/main/java/org/apache/sling/engine/impl/StaticResponseHeader.java AU bundles/engine/src/main/java/org/apache/sling/engine/impl/SlingHttpContext.java AU bundles/engine/src/main/java/org/apache/sling/engine/impl/SlingHttpServletResponseImpl.java A bundles/engine/src/main/java/org/apache/sling/engine/impl/parameters AU bundles/engine/src/main/java/org/apache/sling/engine/impl/parameters/RequestParameterSupportConfigurer.java AU bundles/engine/src/main/java/org/apache/sling/engine/impl/parameters/MultipartRequestParameter.java AU bundles/engine/src/main/java/org/apache/sling/engine/impl/parameters/SlingUnsupportedEncodingException.java AU
Re: Servlet Filter Support adding sling.filter.pattern support
Hi The point is that we should implement what we need and ignore what we don’t need. For some use cases it would indeed be good to be simply able to filter on the URL path (or resource path) like in the Servlet API itself. Consider for example a content management system where you want to apply a filter to all requests to user generated content which might live at /content/public. For other cases, being able to filter on a resource type is more appropriate. Again, consider a content management system and you want to apply the filter to all requests for web page resources of resource type cms/webpage. Then there is a combination even, where you might have resources spread all over but you want to apply the filter only to, say, web pages in user generated content, so you filter on the /content/public location further finer graining it to cms/webpage. These could be use cases. Do we need it ? I don’t know. For SLING-3829 it would be use full to have it. Regards Felix Am 05.12.2014 um 11:07 schrieb Antonio Sanso asa...@adobe.com: hi Julian On Dec 5, 2014, at 10:31 AM, Julian Sedding jsedd...@gmail.com wrote: Hi Antonio I agree with Justin that we should start with support for resource-types. as said I agree we should have support for both. E.g. sling.filter.pattern, sling.filter.resourceType Using path-based restrictions strongly couples configuration to content, which IMO is not a good practice. At the end of the day is the developer choice to choose the one she needs. In my case for example I cannot use the resource type approach. See also https://issues.apache.org/jira/browse/SLING-3829 regards antonio Regards Julian On Thu, Dec 4, 2014 at 3:54 PM, Antonio Sanso asa...@adobe.com wrote: thanks Justin for your feedback, if you would not mind I would try to do the opposite :) The only reason is that I have already a Pocs for this that it actually requires really few modifications.. (Felix gave me some good hints on how to implement it :)) It would probably be the same for resource type though :) regards antonio On Dec 4, 2014, at 2:29 PM, Justin Edelson jus...@justinedelson.com wrote: Hi Antonio, I'd suggest starting with support for resource type and *then* add path support. Justin On Thu, Dec 4, 2014 at 5:46 AM, Antonio Sanso asa...@adobe.com wrote: hi *, the current Sling Servlet Filter Support [0] allows to have scope dependent filter (e.g. REQUEST, INCLUDE, FORWARD, ERROR, COMPONENT). It would be nice to extend this support to have a specific filter being taken in consideration only for specific path (adding sling.filter.pattern) a bit like what currently can be done for Apache Felix filters. WDYT? regards antonio [0] http://sling.apache.org/documentation/the-sling-engine/filters.html
[jira] [Commented] (SLING-4217) Register OSGi services corresponding to available adapter factories
[ https://issues.apache.org/jira/browse/SLING-4217?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14235373#comment-14235373 ] Robert Munteanu commented on SLING-4217: I also posted a review at https://reviews.apache.org/r/28751/ since I find it much easier to look at diffs this way Register OSGi services corresponding to available adapter factories --- Key: SLING-4217 URL: https://issues.apache.org/jira/browse/SLING-4217 Project: Sling Issue Type: Improvement Components: Extensions Affects Versions: Adapter 2.1.2 Reporter: Robert Munteanu Assignee: Robert Munteanu Fix For: Adapter 2.1.4 Attachments: SLING-4217-1.diff As discussed on [dev@:Using adapters on Sling startup|http://markmail.org/message/e4m26rpt3lqe2o2b], we need a more stable way of knowing when an adapter is available. The AdapterManager already publishes OSGi Events, but those are can't be easily mixed with SCR Components. [~justinedelson] suggested that we register services for each adapter factory and add them as references to the services which require the adapters to be registered. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (SLING-4219) [Sightly] Unrecognised operators in expressions are not properly reported as syntax errors
[
https://issues.apache.org/jira/browse/SLING-4219?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Radu Cotescu updated SLING-4219:
Summary: [Sightly] Unrecognised operators in expressions are not properly
reported as syntax errors (was: [Sightly] Unrecognised operators in exceptions
are not properly handled)
[Sightly] Unrecognised operators in expressions are not properly reported as
syntax errors
--
Key: SLING-4219
URL: https://issues.apache.org/jira/browse/SLING-4219
Project: Sling
Issue Type: Bug
Components: Scripting
Reporter: Radu Cotescu
Priority: Minor
Fix For: Scripting Sightly Engine 1.0.0
The
{{org.apache.sling.scripting.sightly.impl.compiler.frontend.SightlyParserErrorListener}}
handles ANTLR parsing errors, in order to provide more detailed and easier
to understand error reporting for Sightly scripts.
For the cases when ANTLR doesn't provide a {{RecognitionException}}, although
the listener still throws an error, the error is because the
{{SightlyParsingException}} is instantiated with a {{null}} cause.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Comment Edited] (SLING-4219) [Sightly] Unrecognised operators in expressions are not properly reported as syntax errors
[
https://issues.apache.org/jira/browse/SLING-4219?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14235380#comment-14235380
]
Radu Cotescu edited comment on SLING-4219 at 12/5/14 11:14 AM:
---
The attached patch (!SLING-4219.patch!) does the following:
* improves error reporting by not setting a null cause for the
SightlyParsingException in SightlyParserErrorListener
* adds more details to the parsing error's message
was (Author: radu.cotescu):
The attached patch does the following:
* improves error reporting by not setting a null cause for the
SightlyParsingException in SightlyParserErrorListener
* adds more details to the parsing error's message
[Sightly] Unrecognised operators in expressions are not properly reported as
syntax errors
--
Key: SLING-4219
URL: https://issues.apache.org/jira/browse/SLING-4219
Project: Sling
Issue Type: Bug
Components: Scripting
Reporter: Radu Cotescu
Priority: Minor
Fix For: Scripting Sightly Engine 1.0.0
Attachments: SLING-4219.patch
The
{{org.apache.sling.scripting.sightly.impl.compiler.frontend.SightlyParserErrorListener}}
handles ANTLR parsing errors, in order to provide more detailed and easier
to understand error reporting for Sightly scripts.
For the cases when ANTLR doesn't provide a {{RecognitionException}}, although
the listener still throws an error, the error is because the
{{SightlyParsingException}} is instantiated with a {{null}} cause.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (SLING-4219) [Sightly] Unrecognised operators in expressions are not properly reported as syntax errors
[
https://issues.apache.org/jira/browse/SLING-4219?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Radu Cotescu updated SLING-4219:
Attachment: SLING-4219.patch
The attached patch does the following:
* improves error reporting by not setting a null cause for the
SightlyParsingException in SightlyParserErrorListener
* adds more details to the parsing error's message
[Sightly] Unrecognised operators in expressions are not properly reported as
syntax errors
--
Key: SLING-4219
URL: https://issues.apache.org/jira/browse/SLING-4219
Project: Sling
Issue Type: Bug
Components: Scripting
Reporter: Radu Cotescu
Priority: Minor
Fix For: Scripting Sightly Engine 1.0.0
Attachments: SLING-4219.patch
The
{{org.apache.sling.scripting.sightly.impl.compiler.frontend.SightlyParserErrorListener}}
handles ANTLR parsing errors, in order to provide more detailed and easier
to understand error reporting for Sightly scripts.
For the cases when ANTLR doesn't provide a {{RecognitionException}}, although
the listener still throws an error, the error is because the
{{SightlyParsingException}} is instantiated with a {{null}} cause.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Comment Edited] (SLING-4219) [Sightly] Unrecognised operators in expressions are not properly reported as syntax errors
[
https://issues.apache.org/jira/browse/SLING-4219?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14235380#comment-14235380
]
Radu Cotescu edited comment on SLING-4219 at 12/5/14 11:14 AM:
---
The attached patch ([^SLING-4219.patch]) does the following:
* improves error reporting by not setting a null cause for the
SightlyParsingException in SightlyParserErrorListener
* adds more details to the parsing error's message
was (Author: radu.cotescu):
The attached patch (!SLING-4219.patch!) does the following:
* improves error reporting by not setting a null cause for the
SightlyParsingException in SightlyParserErrorListener
* adds more details to the parsing error's message
[Sightly] Unrecognised operators in expressions are not properly reported as
syntax errors
--
Key: SLING-4219
URL: https://issues.apache.org/jira/browse/SLING-4219
Project: Sling
Issue Type: Bug
Components: Scripting
Reporter: Radu Cotescu
Priority: Minor
Fix For: Scripting Sightly Engine 1.0.0
Attachments: SLING-4219.patch
The
{{org.apache.sling.scripting.sightly.impl.compiler.frontend.SightlyParserErrorListener}}
handles ANTLR parsing errors, in order to provide more detailed and easier
to understand error reporting for Sightly scripts.
For the cases when ANTLR doesn't provide a {{RecognitionException}}, although
the listener still throws an error, the error is because the
{{SightlyParsingException}} is instantiated with a {{null}} cause.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
Jenkins build is still unstable: sling-trunk-1.7 » Apache Sling Launchpad Testing #1215
See https://builds.apache.org/job/sling-trunk-1.7/org.apache.sling$org.apache.sling.launchpad.testing/1215/
Jenkins build is still unstable: sling-trunk-1.7 #1215
See https://builds.apache.org/job/sling-trunk-1.7/changes
[jira] [Assigned] (SLING-4177) Sightly: StyleString context doesn't properly escape
[
https://issues.apache.org/jira/browse/SLING-4177?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Felix Meschberger reassigned SLING-4177:
Assignee: Felix Meschberger
Sightly: StyleString context doesn't properly escape
Key: SLING-4177
URL: https://issues.apache.org/jira/browse/SLING-4177
Project: Sling
Issue Type: Bug
Components: Scripting
Reporter: Vlad Bailescu
Assignee: Felix Meschberger
Priority: Minor
Labels: Sightly
Fix For: XSS Protection API 1.0.0, Scripting Sightly Engine 1.0.0
The {{context='styleString'}} expression option seems to escape strings the
same way as {{context='scriptString'}}, but this breaks the string, making
that context unusable. CSS strings are to be escaped {{\HH}} and not {{\xHH}}
like in JS:
https://developer.mozilla.org/en-US/docs/Web/CSS/string
Consider following example:
{code:html}
style
.ft:after { content: ${'\'' @ context='styleString'}; }
.in:after { content: ${'\' @ context='styleString'}; }
/style
{code}
Which currently gets incorrectly rendered as follows:
{code:html}
style
.ft:after { content: \x27; }
.in:after { content: \x22; }
/style
{code}
Following output would have been expected:
{code:html}
style
.ft:after { content: \27; }
.in:after { content: \22; }
/style
{code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Resolved] (SLING-4177) Sightly: StyleString context doesn't properly escape
[
https://issues.apache.org/jira/browse/SLING-4177?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Felix Meschberger resolved SLING-4177.
--
Resolution: Fixed
Fix Version/s: XSS Protection API 1.0.0
Thanks for providing the patch. I have applied it in Rev. 1643241
Sightly: StyleString context doesn't properly escape
Key: SLING-4177
URL: https://issues.apache.org/jira/browse/SLING-4177
Project: Sling
Issue Type: Bug
Components: Scripting
Reporter: Vlad Bailescu
Assignee: Felix Meschberger
Priority: Minor
Labels: Sightly
Fix For: XSS Protection API 1.0.0, Scripting Sightly Engine 1.0.0
The {{context='styleString'}} expression option seems to escape strings the
same way as {{context='scriptString'}}, but this breaks the string, making
that context unusable. CSS strings are to be escaped {{\HH}} and not {{\xHH}}
like in JS:
https://developer.mozilla.org/en-US/docs/Web/CSS/string
Consider following example:
{code:html}
style
.ft:after { content: ${'\'' @ context='styleString'}; }
.in:after { content: ${'\' @ context='styleString'}; }
/style
{code}
Which currently gets incorrectly rendered as follows:
{code:html}
style
.ft:after { content: \x27; }
.in:after { content: \x22; }
/style
{code}
Following output would have been expected:
{code:html}
style
.ft:after { content: \27; }
.in:after { content: \22; }
/style
{code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (SLING-4177) Sightly: StyleString context doesn't properly escape
[
https://issues.apache.org/jira/browse/SLING-4177?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Felix Meschberger updated SLING-4177:
-
Component/s: Extensions
Sightly: StyleString context doesn't properly escape
Key: SLING-4177
URL: https://issues.apache.org/jira/browse/SLING-4177
Project: Sling
Issue Type: Bug
Components: Extensions, Scripting
Reporter: Vlad Bailescu
Assignee: Felix Meschberger
Priority: Minor
Labels: Sightly
Fix For: XSS Protection API 1.0.0, Scripting Sightly Engine 1.0.0
The {{context='styleString'}} expression option seems to escape strings the
same way as {{context='scriptString'}}, but this breaks the string, making
that context unusable. CSS strings are to be escaped {{\HH}} and not {{\xHH}}
like in JS:
https://developer.mozilla.org/en-US/docs/Web/CSS/string
Consider following example:
{code:html}
style
.ft:after { content: ${'\'' @ context='styleString'}; }
.in:after { content: ${'\' @ context='styleString'}; }
/style
{code}
Which currently gets incorrectly rendered as follows:
{code:html}
style
.ft:after { content: \x27; }
.in:after { content: \x22; }
/style
{code}
Following output would have been expected:
{code:html}
style
.ft:after { content: \27; }
.in:after { content: \22; }
/style
{code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Assigned] (SLING-4219) [Sightly] Unrecognised operators in expressions are not properly reported as syntax errors
[
https://issues.apache.org/jira/browse/SLING-4219?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Felix Meschberger reassigned SLING-4219:
Assignee: Felix Meschberger
[Sightly] Unrecognised operators in expressions are not properly reported as
syntax errors
--
Key: SLING-4219
URL: https://issues.apache.org/jira/browse/SLING-4219
Project: Sling
Issue Type: Bug
Components: Scripting
Reporter: Radu Cotescu
Assignee: Felix Meschberger
Priority: Minor
Fix For: Scripting Sightly Engine 1.0.0
Attachments: SLING-4219.patch
The
{{org.apache.sling.scripting.sightly.impl.compiler.frontend.SightlyParserErrorListener}}
handles ANTLR parsing errors, in order to provide more detailed and easier
to understand error reporting for Sightly scripts.
For the cases when ANTLR doesn't provide a {{RecognitionException}}, although
the listener still throws an error, the error is because the
{{SightlyParsingException}} is instantiated with a {{null}} cause.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
Build failed in Jenkins: sling-trunk-1.6 #2833
See https://builds.apache.org/job/sling-trunk-1.6/2833/ -- [...truncated 977 lines...] A bundles/commons/log/src/main/java/ch/qos/logback A bundles/commons/log/src/main/java/ch/qos/logback/classic A bundles/commons/log/src/main/java/ch/qos/logback/classic/spi A bundles/commons/log/src/main/java/ch/qos/logback/classic/util A bundles/commons/log/src/test A bundles/commons/log/src/test/resources AU bundles/commons/log/src/test/resources/test-osg-appender-ref-config.xml AUbundles/commons/log/src/test/resources/logback-test.xml A bundles/commons/log/src/test/resources/test-reset-config-1.xml A bundles/commons/log/src/test/resources/test-reset-config-2.xml AUbundles/commons/log/src/test/resources/test1-external-config.xml A bundles/commons/log/src/test/resources/exam.properties AUbundles/commons/log/src/test/resources/test-webconsole-remote.xml A bundles/commons/log/src/test/resources/test-config-provider.xml AUbundles/commons/log/src/test/resources/test-jul-config.xml A bundles/commons/log/src/test/java A bundles/commons/log/src/test/java/org A bundles/commons/log/src/test/java/org/apache A bundles/commons/log/src/test/java/org/apache/sling A bundles/commons/log/src/test/java/org/apache/sling/commons A bundles/commons/log/src/test/java/org/apache/sling/commons/log A bundles/commons/log/src/test/java/org/apache/sling/commons/log/logback A bundles/commons/log/src/test/java/org/apache/sling/commons/log/logback/integration A bundles/commons/log/src/test/java/org/apache/sling/commons/log/logback/integration/ITConfigAdminSupport.java A bundles/commons/log/src/test/java/org/apache/sling/commons/log/logback/integration/ITConfigFragments.java A bundles/commons/log/src/test/java/org/apache/sling/commons/log/logback/integration/ITWebConsoleRemote.java A bundles/commons/log/src/test/java/org/apache/sling/commons/log/logback/integration/ITJULIntegration.java A bundles/commons/log/src/test/java/org/apache/sling/commons/log/logback/integration/remote AU bundles/commons/log/src/test/java/org/apache/sling/commons/log/logback/integration/remote/WebConsoleTestActivator.java A bundles/commons/log/src/test/java/org/apache/sling/commons/log/logback/integration/LogTestBase.java A bundles/commons/log/src/test/java/org/apache/sling/commons/log/logback/integration/ITLogWebConsolePlugin.java A bundles/commons/log/src/test/java/org/apache/sling/commons/log/logback/integration/ITAppenderServices.java AU bundles/commons/log/src/test/java/org/apache/sling/commons/log/logback/integration/ITFilterSupport.java A bundles/commons/log/src/test/java/org/apache/sling/commons/log/logback/integration/ITDefaultConfig.java A bundles/commons/log/src/test/java/org/apache/sling/commons/log/logback/internal A bundles/commons/log/src/test/java/org/apache/sling/commons/log/logback/internal/TestLogConfig.java A bundles/commons/log/src/test/java/org/apache/sling/commons/log/logback/internal/TestLogWriter.java AUbundles/commons/log/pom.xml A bundles/commons/log/README.md A bundles/commons/osgi A bundles/commons/osgi/src A bundles/commons/osgi/src/test A bundles/commons/osgi/src/test/java A bundles/commons/osgi/src/test/java/org A bundles/commons/osgi/src/test/java/org/apache A bundles/commons/osgi/src/test/java/org/apache/sling A bundles/commons/osgi/src/test/java/org/apache/sling/commons A bundles/commons/osgi/src/test/java/org/apache/sling/commons/osgi AU bundles/commons/osgi/src/test/java/org/apache/sling/commons/osgi/PropertiesUtilTest.java AU bundles/commons/osgi/src/test/java/org/apache/sling/commons/osgi/ManifestHeaderTest.java AU bundles/commons/osgi/src/test/java/org/apache/sling/commons/osgi/OsgiUtilTest.java A bundles/commons/osgi/src/test/java/org/apache/sling/commons/osgi/bundleversion AU bundles/commons/osgi/src/test/java/org/apache/sling/commons/osgi/bundleversion/BundleBundleVersionInfoTest.java AU bundles/commons/osgi/src/test/java/org/apache/sling/commons/osgi/bundleversion/MockBundleVersionInfo.java A bundles/commons/osgi/src/test/java/org/apache/sling/commons/osgi/bundleversion/BundleVersionComparisonTest.java AU bundles/commons/osgi/src/test/java/org/apache/sling/commons/osgi/bundleversion/FileBundleVersionInfoTest.java A bundles/commons/osgi/src/main A bundles/commons/osgi/src/main/java A bundles/commons/osgi/src/main/java/org A bundles/commons/osgi/src/main/java/org/apache A bundles/commons/osgi/src/main/java/org/apache/sling A bundles/commons/osgi/src/main/java/org/apache/sling/commons A
[jira] [Created] (SLING-4220) SlingException constructor must not call initCause
Felix Meschberger created SLING-4220:
Summary: SlingException constructor must not call initCause
Key: SLING-4220
URL: https://issues.apache.org/jira/browse/SLING-4220
Project: Sling
Issue Type: Bug
Components: API
Affects Versions: API 2.8.0
Reporter: Felix Meschberger
Assignee: Felix Meschberger
Fix For: API 2.8.2
The SlingException constructors taking Throwable arguments both call
{{Throwable.initCause(Throwable)}} after calling the actual super-constructor.
This dates back to Rev. 609649 (Jan. 7th, 2008!) where I added this to make
sure the Throwable class is initialized with the given cause. At that time
SlingException extended from ServletException which does not do proper Java 1.4
exception chaining but implements its own chaining.
Later with SLING-186 (Rev. 614480, Jan. 23rd, 2008) SlingException was modified
to extend from RuntimeException which would do proper chaining. But the call to
{{Throwable.initCause(Throwable)}} was not removed back then. So this method is
still called when a SlingException is instantiated with a Throwable.
The problem comes from the implementation of the Throwable though, which throws
{{IllegalStateException}} if {{initCause(Throwable)}} is called after the cause
has already been set.
Throwable sets the cause field to {{this}} to indicate the cause has not been
set yet. But {{getCause()}} returns {{null}} both for no cause having been set
or the cause being {{null}}.
If the SlingException is instantiated with a {{null}} cause, this sets the
{{Throwable.cause}} field to {{nul}} thus returning {{null}} on {{getCause()}}
thus causing the SlingException to call {{initCause}}. This in turn causes
{{initCause(Throwable)}} to throw {{IllegalStateException}} because the cause
has already been set.
Long story short: SlingException must not call {{initCause}} because that is
not needed anymore since SLING-186/Rev. 614480
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Resolved] (SLING-4219) [Sightly] Unrecognised operators in expressions are not properly reported as syntax errors
[
https://issues.apache.org/jira/browse/SLING-4219?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Felix Meschberger resolved SLING-4219.
--
Resolution: Fixed
Thanks for providing the patch. I have applied it in Rev. 1643248
For the core problem of the SlingException I have created SLING-4220
[Sightly] Unrecognised operators in expressions are not properly reported as
syntax errors
--
Key: SLING-4219
URL: https://issues.apache.org/jira/browse/SLING-4219
Project: Sling
Issue Type: Bug
Components: Scripting
Reporter: Radu Cotescu
Assignee: Felix Meschberger
Priority: Minor
Fix For: Scripting Sightly Engine 1.0.0
Attachments: SLING-4219.patch
The
{{org.apache.sling.scripting.sightly.impl.compiler.frontend.SightlyParserErrorListener}}
handles ANTLR parsing errors, in order to provide more detailed and easier
to understand error reporting for Sightly scripts.
For the cases when ANTLR doesn't provide a {{RecognitionException}}, although
the listener still throws an error, the error is because the
{{SightlyParsingException}} is instantiated with a {{null}} cause.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Resolved] (SLING-4220) SlingException constructor must not call initCause
[
https://issues.apache.org/jira/browse/SLING-4220?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Felix Meschberger resolved SLING-4220.
--
Resolution: Fixed
Fixed in Rev. 1643255
Also added a unit test to make sure, this now works as expected.
SlingException constructor must not call initCause
--
Key: SLING-4220
URL: https://issues.apache.org/jira/browse/SLING-4220
Project: Sling
Issue Type: Bug
Components: API
Affects Versions: API 2.8.0
Reporter: Felix Meschberger
Assignee: Felix Meschberger
Fix For: API 2.8.2
The SlingException constructors taking Throwable arguments both call
{{Throwable.initCause(Throwable)}} after calling the actual super-constructor.
This dates back to Rev. 609649 (Jan. 7th, 2008!) where I added this to make
sure the Throwable class is initialized with the given cause. At that time
SlingException extended from ServletException which does not do proper Java
1.4 exception chaining but implements its own chaining.
Later with SLING-186 (Rev. 614480, Jan. 23rd, 2008) SlingException was
modified to extend from RuntimeException which would do proper chaining. But
the call to {{Throwable.initCause(Throwable)}} was not removed back then. So
this method is still called when a SlingException is instantiated with a
Throwable.
The problem comes from the implementation of the Throwable though, which
throws {{IllegalStateException}} if {{initCause(Throwable)}} is called after
the cause has already been set.
Throwable sets the cause field to {{this}} to indicate the cause has not been
set yet. But {{getCause()}} returns {{null}} both for no cause having been
set or the cause being {{null}}.
If the SlingException is instantiated with a {{null}} cause, this sets the
{{Throwable.cause}} field to {{nul}} thus returning {{null}} on
{{getCause()}} thus causing the SlingException to call {{initCause}}. This in
turn causes {{initCause(Throwable)}} to throw {{IllegalStateException}}
because the cause has already been set.
Long story short: SlingException must not call {{initCause}} because that is
not needed anymore since SLING-186/Rev. 614480
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
Jenkins build is still unstable: sling-trunk-1.7 » Apache Sling Launchpad Testing #1216
See https://builds.apache.org/job/sling-trunk-1.7/org.apache.sling$org.apache.sling.launchpad.testing/1216/
Jenkins build is still unstable: sling-trunk-1.7 #1216
See https://builds.apache.org/job/sling-trunk-1.7/changes
Review Request 28751: SLING-4217 - Register OSGi services corresponding to available adapter factories
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28751/ --- Review request for sling. Repository: sling Description --- SLING-4217 - Register OSGi services corresponding to available adapter factories Diffs - bundles/extensions/adapter/pom.xml 1641498 bundles/extensions/adapter/src/main/java/org/apache/sling/adapter/internal/AdapterFactoryDescriptor.java 1641498 bundles/extensions/adapter/src/main/java/org/apache/sling/adapter/internal/AdapterManagerImpl.java 1641498 bundles/extensions/adapter/src/test/java/org/apache/sling/adapter/internal/AdapterManagerTest.java 1641498 Diff: https://reviews.apache.org/r/28751/diff/ Testing --- Thanks, Robert Munteanu
Re: Review Request 28751: SLING-4217 - Register OSGi services corresponding to available adapter factories
Hi Robert Thanks for starting the review. Looks like the Adaption interface is missing from the review ? Regards Felix Am 05.12.2014 um 12:02 schrieb Robert Munteanu romb...@apache.org: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28751/ --- Review request for sling. Repository: sling Description --- SLING-4217 - Register OSGi services corresponding to available adapter factories Diffs - bundles/extensions/adapter/pom.xml 1641498 bundles/extensions/adapter/src/main/java/org/apache/sling/adapter/internal/AdapterFactoryDescriptor.java 1641498 bundles/extensions/adapter/src/main/java/org/apache/sling/adapter/internal/AdapterManagerImpl.java 1641498 bundles/extensions/adapter/src/test/java/org/apache/sling/adapter/internal/AdapterManagerTest.java 1641498 Diff: https://reviews.apache.org/r/28751/diff/ Testing --- Thanks, Robert Munteanu
Re: Review Request 28751: SLING-4217 - Register OSGi services corresponding to available adapter factories
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28751/ --- (Updated Dec. 5, 2014, 1:11 p.m.) Review request for sling. Changes --- Added missing Adaption and AdaptionImpl classes Repository: sling Description --- SLING-4217 - Register OSGi services corresponding to available adapter factories Diffs (updated) - bundles/extensions/adapter/pom.xml 1641498 bundles/extensions/adapter/src/main/java/org/apache/sling/adapter/Adaption.java PRE-CREATION bundles/extensions/adapter/src/main/java/org/apache/sling/adapter/internal/AdapterFactoryDescriptor.java 1641498 bundles/extensions/adapter/src/main/java/org/apache/sling/adapter/internal/AdapterManagerImpl.java 1641498 bundles/extensions/adapter/src/main/java/org/apache/sling/adapter/internal/AdaptionImpl.java PRE-CREATION bundles/extensions/adapter/src/test/java/org/apache/sling/adapter/internal/AdapterManagerTest.java 1641498 Diff: https://reviews.apache.org/r/28751/diff/ Testing --- Thanks, Robert Munteanu
Build failed in Jenkins: sling-trunk-1.7 » Apache Sling Resource-Based Discovery Service #1217
See https://builds.apache.org/job/sling-trunk-1.7/org.apache.sling$org.apache.sling.discovery.impl/1217/ -- [INFO] [INFO] [INFO] Building Apache Sling Resource-Based Discovery Service 1.0.13-SNAPSHOT [INFO] [INFO] [INFO] --- maven-clean-plugin:2.5:clean (default-clean) @ org.apache.sling.discovery.impl --- [INFO] Deleting https://builds.apache.org/job/sling-trunk-1.7/org.apache.sling$org.apache.sling.discovery.impl/ws/target [INFO] [INFO] --- maven-enforcer-plugin:1.3.1:enforce (enforce-java) @ org.apache.sling.discovery.impl --- [INFO] [INFO] --- maven-antrun-plugin:1.7:run (set-bundle-required-execution-environment) @ org.apache.sling.discovery.impl --- [INFO] Executing tasks main: [INFO] Executed tasks [INFO] [INFO] --- maven-remote-resources-plugin:1.5:process (default) @ org.apache.sling.discovery.impl --- [INFO] [INFO] --- maven-resources-plugin:2.6:resources (default-resources) @ org.apache.sling.discovery.impl --- [INFO] Using 'UTF-8' encoding to copy filtered resources. [INFO] Copying 1 resource [INFO] Copying 3 resources [INFO] [INFO] --- maven-antrun-plugin:1.7:run (check-memory-task) @ org.apache.sling.discovery.impl --- [INFO] Executing tasks main: [echo] WARNING (SLING-443/SLING-1782) ** [echo] On most platforms, you'll get OutOfMemoryErrors when building unless you set [echo] on 32bit platforms: MAVEN_OPTS=-Xmx256M -XX:MaxPermSize=256M, see SLING-443 [echo] on 64bit platforms: MAVEN_OPTS=-Xmx512M -XX:MaxPermSize=512M, see SLING-1782 [echo] ** [INFO] Executed tasks [INFO] [INFO] --- maven-compiler-plugin:3.1:compile (default-compile) @ org.apache.sling.discovery.impl --- [INFO] Changes detected - recompiling the module! [INFO] Compiling 35 source files to https://builds.apache.org/job/sling-trunk-1.7/org.apache.sling$org.apache.sling.discovery.impl/ws/target/classes [INFO] [INFO] --- maven-scr-plugin:1.20.0:scr (generate-scr-scrdescriptor) @ org.apache.sling.discovery.impl --- [INFO] Generating 1 MetaType Descriptors in https://builds.apache.org/job/sling-trunk-1.7/org.apache.sling$org.apache.sling.discovery.impl/ws/target/classes/OSGI-INF/metatype/org.apache.sling.discovery.impl.Config.xml [INFO] Writing 1 Service Component Descriptors to https://builds.apache.org/job/sling-trunk-1.7/org.apache.sling$org.apache.sling.discovery.impl/ws/target/classes/OSGI-INF/org.apache.sling.discovery.impl.TopologyWebConsolePlugin.xml [INFO] Writing 1 Service Component Descriptors to https://builds.apache.org/job/sling-trunk-1.7/org.apache.sling$org.apache.sling.discovery.impl/ws/target/classes/OSGI-INF/org.apache.sling.discovery.impl.DiscoveryServiceImpl.xml [INFO] Writing 1 Service Component Descriptors to https://builds.apache.org/job/sling-trunk-1.7/org.apache.sling$org.apache.sling.discovery.impl/ws/target/classes/OSGI-INF/org.apache.sling.discovery.impl.Config.xml [INFO] Writing 1 Service Component Descriptors to https://builds.apache.org/job/sling-trunk-1.7/org.apache.sling$org.apache.sling.discovery.impl/ws/target/classes/OSGI-INF/org.apache.sling.discovery.impl.cluster.voting.VotingHandler.xml [INFO] Writing 1 Service Component Descriptors to https://builds.apache.org/job/sling-trunk-1.7/org.apache.sling$org.apache.sling.discovery.impl/ws/target/classes/OSGI-INF/org.apache.sling.discovery.impl.cluster.ClusterViewServiceImpl.xml [INFO] Writing 1 Service Component Descriptors to https://builds.apache.org/job/sling-trunk-1.7/org.apache.sling$org.apache.sling.discovery.impl/ws/target/classes/OSGI-INF/org.apache.sling.discovery.impl.topology.announcement.AnnouncementRegistryImpl.xml [INFO] Writing 1 Service Component Descriptors to https://builds.apache.org/job/sling-trunk-1.7/org.apache.sling$org.apache.sling.discovery.impl/ws/target/classes/OSGI-INF/org.apache.sling.discovery.impl.topology.connector.TopologyConnectorServlet.xml [INFO] Writing 1 Service Component Descriptors to https://builds.apache.org/job/sling-trunk-1.7/org.apache.sling$org.apache.sling.discovery.impl/ws/target/classes/OSGI-INF/org.apache.sling.discovery.impl.topology.connector.ConnectorRegistryImpl.xml [INFO] Writing 1 Service Component Descriptors to https://builds.apache.org/job/sling-trunk-1.7/org.apache.sling$org.apache.sling.discovery.impl/ws/target/classes/OSGI-INF/org.apache.sling.discovery.impl.topology.TopologyChangeHandler.xml [INFO] Writing 1 Service Component Descriptors to https://builds.apache.org/job/sling-trunk-1.7/org.apache.sling$org.apache.sling.discovery.impl/ws/target/classes/OSGI-INF/org.apache.sling.discovery.impl.common.heartbeat.HeartbeatHandler.xml [INFO] [INFO] ---
Build failed in Jenkins: sling-trunk-1.7 #1217
See https://builds.apache.org/job/sling-trunk-1.7/1217/changes Changes: [fmeschbe] SLING-4220 Don't call initCause Calling initCause is not needed since SlingException does not extend from ServletException any more and exception chaining properly works. [fmeschbe] SLING-4219 Prevent IllegalStateException if SlightlyParserErrorListener is called with null RecognitionException Note: The actual problem is the SlingException(String, Throwable) constructor which calls initCause if the Throwable is null. This should be fixed as well. (Applying patch by Radu Cotescu, thanks for providing the patch!) -- [...truncated 15256 lines...] [INFO] Apache Sling SLF4J Implementation (Logback) ... SUCCESS [34.233s] [INFO] Apache Sling OSGi LogService Implementation ... SUCCESS [3.879s] [INFO] Apache Sling MIME type mapping support SUCCESS [5.025s] [INFO] Apache Sling Commons OSGi support . SUCCESS [22.599s] [INFO] Apache Sling Scheduler Support SUCCESS [7.664s] [INFO] Apache Sling Testing Utilities SUCCESS [1:01.581s] [INFO] Apache Sling Thread Dumper SUCCESS [4.132s] [INFO] Apache Sling Thread Support ... SUCCESS [6.419s] [INFO] Apache Sling Authentication Service ... SUCCESS [6.279s] [INFO] Apache Sling Form Based Authentication Handler SUCCESS [12.538s] [INFO] Apache Sling Engine Implementation SUCCESS [19.625s] [INFO] Apache Sling Repository API Bundle SUCCESS [2.211s] [INFO] Apache Sling JCR Base Bundle .. SUCCESS [5.916s] [INFO] Apache Sling JCR ClassLoader .. SUCCESS [3.499s] [INFO] Apache Sling Initial Content Loader ... SUCCESS [12.011s] [INFO] Apache Sling Jackrabbit Embedded Repository ... SUCCESS [17.656s] [INFO] Apache Sling Jackrabbit UserManager Support ... SUCCESS [5.257s] [INFO] Apache Sling Jackrabbit JSR-283 Access Control Manager Support SUCCESS [6.246s] [INFO] Apache Sling Wrapper Bundle for the JCR API ... SUCCESS [2.016s] [INFO] Apache Sling JCR Resource Resolver SUCCESS [2:59.502s] [INFO] Apache Sling JCR Repository Registration .. SUCCESS [10.397s] [INFO] Apache Sling Simple WebDAV Access to repositories . SUCCESS [4.719s] [INFO] Apache Sling DavEx Access to repositories . SUCCESS [4.604s] [INFO] Apache Sling JCR WebConsole Bundle SUCCESS [3.918s] [INFO] Apache Sling Oak Repository Server SUCCESS [4.444s] [INFO] Apache Sling SlingRepository Integration Tests SUCCESS [1:30.541s] [INFO] Apache Sling Servlet Resolver . SUCCESS [7.635s] [INFO] Apache Sling Default GET Servlets . SUCCESS [8.203s] [INFO] Apache Sling Default POST Servlets SUCCESS [11.520s] [INFO] Apache Sling Compat Servlets .. SUCCESS [4.023s] [INFO] Apache Sling Scripting Implementation API . SUCCESS [6.314s] [INFO] Apache Sling Scripting Core implementation SUCCESS [17.250s] [INFO] Apache Sling Scripting JavaScript Support . SUCCESS [40.232s] [INFO] Apache Sling Scripting JSP Support SUCCESS [14.350s] [INFO] Apache Sling JSP Tag Library .. SUCCESS [8.855s] [INFO] Apache Sling JSP Standard Tag Library . SUCCESS [2.006s] [INFO] Apache Sling Adapter Manager Implementation ... SUCCESS [10.758s] [INFO] Apache Sling Bundle Resource Provider . SUCCESS [4.327s] [INFO] Apache Sling Distributed Event Admin .. SUCCESS [12.912s] [INFO] Apache Sling Discovery API SUCCESS [6.953s] [INFO] Apache Sling Resource-Based Discovery Service . FAILURE [5:57.496s] [INFO] Apache Sling Discovery Support Bundle . SKIPPED [INFO] Apache Sling Discovery Standalone Implementation .. SKIPPED [INFO] Apache Sling Event Support SKIPPED [INFO] Apache Sling Feature Flags SKIPPED [INFO] Apache Sling Filesystem Resource Provider . SKIPPED [INFO] Apache Sling javax.activation bundle .. SKIPPED [INFO] Apache Sling Service User Mapper .. SKIPPED [INFO] Apache Sling Settings . SKIPPED [INFO] Apache Sling Web Console Branding . SKIPPED [INFO] Apache Sling Web Console Security Provider SKIPPED [INFO] Apache Sling Explorer . SKIPPED [INFO] Apache Sling Health Check Core SKIPPED [INFO] Apache Sling Health Check Annotations . SKIPPED [INFO] Apache Sling Health Check Samples . SKIPPED [INFO] Apache Sling Health Check Support Components .. SKIPPED [INFO] Apache Sling Health Check Webconsole Plugin ... SKIPPED [INFO] Apache Sling Health Check JUnit Bridge SKIPPED [INFO] Apache
Jenkins build became unstable: sling-trunk-1.8 » Apache Sling Event Support #507
See https://builds.apache.org/job/sling-trunk-1.8/org.apache.sling$org.apache.sling.event/507/
Jenkins build became unstable: sling-trunk-1.8 #507
See https://builds.apache.org/job/sling-trunk-1.8/507/changes
[jira] [Created] (SLING-4221) ArrayIndexOutOfBoundException in case of empty multivalue property
Konrad Windszus created SLING-4221:
--
Summary: ArrayIndexOutOfBoundException in case of empty multivalue
property
Key: SLING-4221
URL: https://issues.apache.org/jira/browse/SLING-4221
Project: Sling
Issue Type: Bug
Components: Validation
Reporter: Konrad Windszus
Assignee: Konrad Windszus
The following exception is thrown whenever an empty multivalue property is
validated
{code}
java.lang.ArrayIndexOutOfBoundsException: 0
at
org.apache.sling.validation.impl.ValidationServiceImpl.validatePropertyValue(ValidationServiceImpl.java:420)
at
org.apache.sling.validation.impl.ValidationServiceImpl.validateValueMap(ValidationServiceImpl.java:277)
at
org.apache.sling.validation.impl.ValidationServiceImpl.validateValueMap(ValidationServiceImpl.java:256)
at
org.apache.sling.validation.impl.ValidationServiceImpl.validate(ValidationServiceImpl.java:175)
{code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
Build failed in Jenkins: sling-trunk-1.6 #2835
See https://builds.apache.org/job/sling-trunk-1.6/2835/ -- [...truncated 1092 lines...] A bundles/commons/testing/src/main/java/org/apache/sling/commons/testing/junit A bundles/commons/testing/src/main/java/org/apache/sling/commons/testing/junit/Retry.java A bundles/commons/testing/src/main/java/org/apache/sling/commons/testing/junit/categories A bundles/commons/testing/src/main/java/org/apache/sling/commons/testing/junit/categories/JackrabbitOnly.java A bundles/commons/testing/src/main/java/org/apache/sling/commons/testing/junit/categories/OakOnly.java A bundles/commons/testing/src/main/java/org/apache/sling/commons/testing/junit/RetryRule.java A bundles/commons/testing/src/test A bundles/commons/testing/src/test/java A bundles/commons/testing/src/test/java/org A bundles/commons/testing/src/test/java/org/apache A bundles/commons/testing/src/test/java/org/apache/sling A bundles/commons/testing/src/test/java/org/apache/sling/commons A bundles/commons/testing/src/test/java/org/apache/sling/commons/testing A bundles/commons/testing/src/test/java/org/apache/sling/commons/testing/junit A bundles/commons/testing/src/test/java/org/apache/sling/commons/testing/junit/RetryRuleTest.java A bundles/commons/testing/src/test/java/org/apache/sling/commons/testing/sling A bundles/commons/testing/src/test/java/org/apache/sling/commons/testing/sling/MockResourceTest.java A bundles/commons/testing/src/test/java/org/apache/sling/commons/testing/util AU bundles/commons/testing/src/test/java/org/apache/sling/commons/testing/util/JavascriptEngineTest.java A bundles/commons/testing/src/test/java/org/apache/sling/commons/testing/jcr AU bundles/commons/testing/src/test/java/org/apache/sling/commons/testing/jcr/RepositoryProviderTest.java AU bundles/commons/testing/src/test/java/org/apache/sling/commons/testing/jcr/RepositoryTestBaseTest.java AU bundles/commons/testing/src/test/java/org/apache/sling/commons/testing/jcr/RepositoryUtilTest.java AUbundles/commons/testing/pom.xml AUbundles/commons/testing/README.txt A bundles/commons/threaddump A bundles/commons/threaddump/src A bundles/commons/threaddump/src/main A bundles/commons/threaddump/src/main/java A bundles/commons/threaddump/src/main/java/org A bundles/commons/threaddump/src/main/java/org/apache A bundles/commons/threaddump/src/main/java/org/apache/sling A bundles/commons/threaddump/src/main/java/org/apache/sling/commons A bundles/commons/threaddump/src/main/java/org/apache/sling/commons/threaddump A bundles/commons/threaddump/src/main/java/org/apache/sling/commons/threaddump/internal A bundles/commons/threaddump/src/main/java/org/apache/sling/commons/threaddump/internal/ThreadDumperPanel.java A bundles/commons/threaddump/src/main/java/org/apache/sling/commons/threaddump/internal/Activator.java A bundles/commons/threaddump/src/main/java/org/apache/sling/commons/threaddump/internal/ThreadDumpCommand.java A bundles/commons/threaddump/src/main/java/org/apache/sling/commons/threaddump/internal/BaseThreadDumper.java AUbundles/commons/threaddump/pom.xml AUbundles/commons/threaddump/README.txt A bundles/commons/scheduler AUbundles/commons/scheduler/README.txt A bundles/commons/scheduler/src A bundles/commons/scheduler/src/main A bundles/commons/scheduler/src/main/resources A bundles/commons/scheduler/src/main/java A bundles/commons/scheduler/src/main/java/org A bundles/commons/scheduler/src/main/java/org/apache A bundles/commons/scheduler/src/main/java/org/apache/sling A bundles/commons/scheduler/src/main/java/org/apache/sling/commons A bundles/commons/scheduler/src/main/java/org/apache/sling/commons/scheduler AU bundles/commons/scheduler/src/main/java/org/apache/sling/commons/scheduler/Scheduler.java AU bundles/commons/scheduler/src/main/java/org/apache/sling/commons/scheduler/JobContext.java A bundles/commons/scheduler/src/main/java/org/apache/sling/commons/scheduler/impl AU bundles/commons/scheduler/src/main/java/org/apache/sling/commons/scheduler/impl/InternalScheduleOptions.java AU bundles/commons/scheduler/src/main/java/org/apache/sling/commons/scheduler/impl/QuartzScheduler.java AU bundles/commons/scheduler/src/main/java/org/apache/sling/commons/scheduler/impl/WhiteboardHandler.java AU bundles/commons/scheduler/src/main/java/org/apache/sling/commons/scheduler/impl/SchedulerServiceFactory.java AU bundles/commons/scheduler/src/main/java/org/apache/sling/commons/scheduler/impl/NonParallelQuartzJobExecutor.java AU
[jira] [Commented] (SLING-4221) ArrayIndexOutOfBoundException in case of empty multivalue property
[
https://issues.apache.org/jira/browse/SLING-4221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14235506#comment-14235506
]
Konrad Windszus commented on SLING-4221:
Fixed in rev. 1643291 (also included a test case for that).
ArrayIndexOutOfBoundException in case of empty multivalue property
--
Key: SLING-4221
URL: https://issues.apache.org/jira/browse/SLING-4221
Project: Sling
Issue Type: Bug
Components: Validation
Reporter: Konrad Windszus
Assignee: Konrad Windszus
Fix For: Validation 1.0.0
The following exception is thrown whenever an empty multivalue property is
validated
{code}
java.lang.ArrayIndexOutOfBoundsException: 0
at
org.apache.sling.validation.impl.ValidationServiceImpl.validatePropertyValue(ValidationServiceImpl.java:420)
at
org.apache.sling.validation.impl.ValidationServiceImpl.validateValueMap(ValidationServiceImpl.java:277)
at
org.apache.sling.validation.impl.ValidationServiceImpl.validateValueMap(ValidationServiceImpl.java:256)
at
org.apache.sling.validation.impl.ValidationServiceImpl.validate(ValidationServiceImpl.java:175)
{code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Resolved] (SLING-4221) ArrayIndexOutOfBoundException in case of empty multivalue property
[
https://issues.apache.org/jira/browse/SLING-4221?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Konrad Windszus resolved SLING-4221.
Resolution: Fixed
Fix Version/s: Validation 1.0.0
ArrayIndexOutOfBoundException in case of empty multivalue property
--
Key: SLING-4221
URL: https://issues.apache.org/jira/browse/SLING-4221
Project: Sling
Issue Type: Bug
Components: Validation
Reporter: Konrad Windszus
Assignee: Konrad Windszus
Fix For: Validation 1.0.0
The following exception is thrown whenever an empty multivalue property is
validated
{code}
java.lang.ArrayIndexOutOfBoundsException: 0
at
org.apache.sling.validation.impl.ValidationServiceImpl.validatePropertyValue(ValidationServiceImpl.java:420)
at
org.apache.sling.validation.impl.ValidationServiceImpl.validateValueMap(ValidationServiceImpl.java:277)
at
org.apache.sling.validation.impl.ValidationServiceImpl.validateValueMap(ValidationServiceImpl.java:256)
at
org.apache.sling.validation.impl.ValidationServiceImpl.validate(ValidationServiceImpl.java:175)
{code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
Jenkins build is back to stable : sling-trunk-1.8 » Apache Sling Event Support #508
See https://builds.apache.org/job/sling-trunk-1.8/org.apache.sling$org.apache.sling.event/508/
Jenkins build is back to stable : sling-trunk-1.8 #508
See https://builds.apache.org/job/sling-trunk-1.8/508/changes
[jira] [Assigned] (SLING-4054) Have a package builder based on JcrPackages
[ https://issues.apache.org/jira/browse/SLING-4054?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Marius Petria reassigned SLING-4054: Assignee: Marius Petria Have a package builder based on JcrPackages --- Key: SLING-4054 URL: https://issues.apache.org/jira/browse/SLING-4054 Project: Sling Issue Type: Bug Components: Distribution Reporter: Marius Petria Assignee: Marius Petria Fix For: Content Distribution 0.1.0 Currently we have a FileVaultPackage implementation based on files but we need a package implementation based on JcrPackage -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (SLING-4054) Have a package builder based on JcrPackages
[ https://issues.apache.org/jira/browse/SLING-4054?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14235549#comment-14235549 ] Marius Petria commented on SLING-4054: -- Committed revision 1643296. The type of packages in jcrvlt and the type of file based packages is filevlt. Have a package builder based on JcrPackages --- Key: SLING-4054 URL: https://issues.apache.org/jira/browse/SLING-4054 Project: Sling Issue Type: Bug Components: Distribution Reporter: Marius Petria Fix For: Content Distribution 0.1.0 Currently we have a FileVaultPackage implementation based on files but we need a package implementation based on JcrPackage -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Resolved] (SLING-4054) Have a package builder based on JcrPackages
[ https://issues.apache.org/jira/browse/SLING-4054?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Marius Petria resolved SLING-4054. -- Resolution: Fixed Fix Version/s: Content Distribution 0.1.0 Have a package builder based on JcrPackages --- Key: SLING-4054 URL: https://issues.apache.org/jira/browse/SLING-4054 Project: Sling Issue Type: Bug Components: Distribution Reporter: Marius Petria Assignee: Marius Petria Fix For: Content Distribution 0.1.0 Currently we have a FileVaultPackage implementation based on files but we need a package implementation based on JcrPackage -- This message was sent by Atlassian JIRA (v6.3.4#6332)
Jenkins build is unstable: sling-trunk-1.7 » Apache Sling Launchpad Testing #1218
See https://builds.apache.org/job/sling-trunk-1.7/org.apache.sling$org.apache.sling.launchpad.testing/1218/
Jenkins build is back to normal : sling-trunk-1.7 » Apache Sling Resource-Based Discovery Service #1218
See https://builds.apache.org/job/sling-trunk-1.7/org.apache.sling$org.apache.sling.discovery.impl/1218/
Jenkins build is unstable: sling-trunk-1.7 #1218
See https://builds.apache.org/job/sling-trunk-1.7/1218/changes
Build failed in Jenkins: sling-trunk-1.6 #2836
See https://builds.apache.org/job/sling-trunk-1.6/2836/ -- [...truncated 1340 lines...] A testing/mocks/sling-mock/src/test/java/org/apache/sling/testing/mock/sling/jcrmock A testing/mocks/sling-mock/src/test/java/org/apache/sling/testing/mock/sling/jcrmock/loader AU testing/mocks/sling-mock/src/test/java/org/apache/sling/testing/mock/sling/jcrmock/loader/ContentLoaderBinaryTest.java AU testing/mocks/sling-mock/src/test/java/org/apache/sling/testing/mock/sling/jcrmock/loader/ContentLoaderJsonTest.java AU testing/mocks/sling-mock/src/test/java/org/apache/sling/testing/mock/sling/jcrmock/loader/ContentLoaderJsonDamTest.java A testing/mocks/sling-mock/src/test/java/org/apache/sling/testing/mock/sling/jcrmock/resource AU testing/mocks/sling-mock/src/test/java/org/apache/sling/testing/mock/sling/jcrmock/resource/SlingCrudResourceResolverTest.java AU testing/mocks/sling-mock/src/test/java/org/apache/sling/testing/mock/sling/jcrmock/resource/MultipleResourceResolverTest.java AU testing/mocks/sling-mock/src/test/java/org/apache/sling/testing/mock/sling/jcrmock/resource/JcrResourceResolverTest.java A testing/mocks/sling-mock/src/test/java/org/apache/sling/testing/mock/sling/junit AU testing/mocks/sling-mock/src/test/java/org/apache/sling/testing/mock/sling/junit/SlingContextTest.java AU testing/mocks/sling-mock/src/test/java/org/apache/sling/testing/mock/sling/junit/SlingContextDefaultRRTypeTest.java AU testing/mocks/sling-mock/src/test/java/org/apache/sling/testing/mock/sling/MockSlingScriptHelperTest.java A testing/mocks/sling-mock/src/test/java/org/apache/sling/testing/mock/sling/rrmock A testing/mocks/sling-mock/src/test/java/org/apache/sling/testing/mock/sling/rrmock/loader AU testing/mocks/sling-mock/src/test/java/org/apache/sling/testing/mock/sling/rrmock/loader/ContentLoaderBinaryTest.java AU testing/mocks/sling-mock/src/test/java/org/apache/sling/testing/mock/sling/rrmock/loader/ContentLoaderJsonTest.java AU testing/mocks/sling-mock/src/test/java/org/apache/sling/testing/mock/sling/rrmock/loader/ContentLoaderJsonDamTest.java A testing/mocks/sling-mock/src/test/java/org/apache/sling/testing/mock/sling/rrmock/resource AU testing/mocks/sling-mock/src/test/java/org/apache/sling/testing/mock/sling/rrmock/resource/SlingCrudResourceResolverTest.java AU testing/mocks/sling-mock/src/test/java/org/apache/sling/testing/mock/sling/rrmock/resource/MultipleResourceResolverTest.java A testing/mocks/sling-mock/src/test/resources A testing/mocks/sling-mock/src/test/resources/json-import-samples AU testing/mocks/sling-mock/src/test/resources/json-import-samples/content.json AU testing/mocks/sling-mock/src/test/resources/json-import-samples/dam.json AUtesting/mocks/sling-mock/src/test/resources/sample-image.gif AUtesting/mocks/sling-mock/pom.xml AUtesting/mocks/sling-mock/README.txt A testing/mocks/jcr-mock A testing/mocks/jcr-mock/src A testing/mocks/jcr-mock/src/test A testing/mocks/jcr-mock/src/test/java A testing/mocks/jcr-mock/src/test/java/org A testing/mocks/jcr-mock/src/test/java/org/apache A testing/mocks/jcr-mock/src/test/java/org/apache/sling A testing/mocks/jcr-mock/src/test/java/org/apache/sling/testing A testing/mocks/jcr-mock/src/test/java/org/apache/sling/testing/mock A testing/mocks/jcr-mock/src/test/java/org/apache/sling/testing/mock/jcr AU testing/mocks/jcr-mock/src/test/java/org/apache/sling/testing/mock/jcr/MockPropertyTest.java AU testing/mocks/jcr-mock/src/test/java/org/apache/sling/testing/mock/jcr/MockNodeTest.java AU testing/mocks/jcr-mock/src/test/java/org/apache/sling/testing/mock/jcr/AbstractItemTest.java AU testing/mocks/jcr-mock/src/test/java/org/apache/sling/testing/mock/jcr/ResourceUtilTest.java AU testing/mocks/jcr-mock/src/test/java/org/apache/sling/testing/mock/jcr/MockWorkspaceTest.java AU testing/mocks/jcr-mock/src/test/java/org/apache/sling/testing/mock/jcr/MockRepositoryTest.java AU testing/mocks/jcr-mock/src/test/java/org/apache/sling/testing/mock/jcr/MockSessionTest.java A testing/mocks/jcr-mock/src/main A testing/mocks/jcr-mock/src/main/java A testing/mocks/jcr-mock/src/main/java/org A testing/mocks/jcr-mock/src/main/java/org/apache A testing/mocks/jcr-mock/src/main/java/org/apache/sling A testing/mocks/jcr-mock/src/main/java/org/apache/sling/testing A testing/mocks/jcr-mock/src/main/java/org/apache/sling/testing/mock A testing/mocks/jcr-mock/src/main/java/org/apache/sling/testing/mock/jcr AU testing/mocks/jcr-mock/src/main/java/org/apache/sling/testing/mock/jcr/MockSession.java AU
Limit the number of vanityPath MapEntry
hi *, I have been working on [0], namely Limit the number of vanityPath MapEntry. In a nutshell at the moment we keep a cache of vanityPaths. So far so good. The problem is that this cache is unbounded. Namely if the Sling instance has 100 vanityPaths all the vanityPaths are kept in memory. Of course the memory is limited and is not hard to imagine an OutOfMemory… For this reason I am willing to propose a limit the number of vanity path Osgi configuration. That’s said we need now to adapt the map/resolve algorithm to this new situation. So far I so two possible solutions ( but IMHO one is really not a way to go). Let’s take in consideration the resolve case (the map case can be then solved in a similar way). The two possible solution are when the cache is bound: - do a search for a vanityPath if the /requestPath is not in the cache (as anticipated above I think this is not a great solution since it can be expensive, indeed I assume the majorities of requests are not even “vanityPath requests” so both the cache and the search will return empty result) - the second solution is a bit more convoluted but way more efficient. Let me try to explain: * the cache is now bounded to the number of vanityPath entries as per config * the algorithm stays as is for now for resolve(). So it before looks for vanityPath in the cache and then continues to look in the repository for a path that matches a resource * if a requestedPath ends to be evaluated as NonExistingResource a last resort vanityPath search is executed and tries to find for a vanityPath entry There is only on problem here. This indeed can lead to a non compatible change and can work only if we also introduce a new configuration where a vanityPath cannot be set to a value that is equal to an existing resource. E.g. if I have some content /foo and in /bar I try to set a vanityPath /foo this is not taken in consideration as valid vanityPath Sorry for the rather complicated mail but WDYT? regards antonio [0] https://issues.apache.org/jira/browse/SLING-4216
Jenkins build became unstable: sling-trunk-1.8 » Apache Sling Event Support #509
See https://builds.apache.org/job/sling-trunk-1.8/org.apache.sling$org.apache.sling.event/509/
Jenkins build became unstable: sling-trunk-1.8 #509
See https://builds.apache.org/job/sling-trunk-1.8/509/changes
Re: Limit the number of vanityPath MapEntry
- do a search for a vanityPath if the /requestPath is not in the cache (as anticipated above I think this is not a great solution since it can be expensive, indeed I assume the majorities of requests are not even “vanityPath requests” so both the cache and the search will return empty result) I think the major concern here is that (a lot of) non-vanity path resources would still have to go to repo for lookup. Would a bloom filter[1] implementation be possible to help taking that decision? Thanks, Vikas [1]: http://en.wikipedia.org/wiki/Bloom_filter
Re: Limit the number of vanityPath MapEntry
Thanks Vikas, we already took in consideration Bloom Filter for a related issue [2]. We decided that is still not too optimal since it leads toward content duplication and I would like to avoid that for now regards antonio [2] https://issues.apache.org/jira/browse/SLING-3290 On Dec 5, 2014, at 4:26 PM, Vikas Saurabh vikas.saur...@gmail.com wrote: - do a search for a vanityPath if the /requestPath is not in the cache (as anticipated above I think this is not a great solution since it can be expensive, indeed I assume the majorities of requests are not even “vanityPath requests” so both the cache and the search will return empty result) I think the major concern here is that (a lot of) non-vanity path resources would still have to go to repo for lookup. Would a bloom filter[1] implementation be possible to help taking that decision? Thanks, Vikas [1]: http://en.wikipedia.org/wiki/Bloom_filter
Debugging Sling Models IT
HI, I need some help with resolving failures in the models.integration-tests module (don’t worry, those only fail for me due to some local changes). I tried to run the integration-tests with mvn install with the option keepJarRunningtrue/keepJarRunning (set inside the pom.xml) and to start the launchpad with the remote debugging options set. Now I get the following exception when executing the integration test 32492 [main] ERROR org.apache.sling.models.it.RemoteIT - Exception in maybeStartServer() java.lang.IllegalMonitorStateException at java.lang.Object.wait(Native Method) at java.lang.Object.wait(Object.java:503) at org.apache.sling.testing.tools.sling.SlingTestBase.blockIfRequested(SlingTestBase.java:234) at org.apache.sling.testing.tools.sling.SlingTestBase.startServerIfNeeded(SlingTestBase.java:152) at org.apache.sling.testing.tools.sling.SlingTestBase.getServerBaseUrl(SlingTestBase.java:211) at org.apache.sling.models.it.RemoteIT.getJunitServletUrl(RemoteIT.java:28) at org.apache.sling.junit.remote.testrunner.SlingRemoteTestRunner.maybeExecuteTests(SlingRemoteTestRunner.java:95) at org.apache.sling.junit.remote.testrunner.SlingRemoteTestRunner.getChildren(SlingRemoteTestRunner.java:138) at org.junit.runners.ParentRunner.getFilteredChildren(ParentRunner.java:363) at org.junit.runners.ParentRunner.getDescription(ParentRunner.java:297) at org.junit.runners.ParentRunner.run(ParentRunner.java:305) at org.apache.maven.surefire.junit4.JUnit4Provider.execute(JUnit4Provider.java:264) at org.apache.maven.surefire.junit4.JUnit4Provider.executeTestSet(JUnit4Provider.java:153) at org.apache.maven.surefire.junit4.JUnit4Provider.invoke(JUnit4Provider.java:124) at org.apache.maven.surefire.booter.ForkedBooter.invokeProviderInSameClassLoader(ForkedBooter.java:200) at org.apache.maven.surefire.booter.ForkedBooter.runSuitesInProcess(ForkedBooter.java:153) at org.apache.maven.surefire.booter.ForkedBooter.main(ForkedBooter.java:103) I don’t know why the IllegalMonitorStateException is triggered there. Any idea? Thanks in advance, Konrad
Jenkins build is still unstable: sling-trunk-1.7 » Apache Sling Launchpad Testing #1219
See https://builds.apache.org/job/sling-trunk-1.7/org.apache.sling$org.apache.sling.launchpad.testing/1219/
Jenkins build is still unstable: sling-trunk-1.7 #1219
See https://builds.apache.org/job/sling-trunk-1.7/changes
RE: Debugging Sling Models IT
what i did was adding the JVM debugging parameters the IT sling instance startup (jar.executor.vm.options, commented out), and then attached to the IT JVM while it was starting up (it takes some seconds while bundles are deploying before the tests really gets executed, so it's no problem to attach to it before they start). then the IT's stopped at my breakpoints as expected. i never used the keepJarRunning flag. stefan -Original Message- From: Konrad Windszus [mailto:konra...@gmx.de] Sent: Friday, December 05, 2014 4:42 PM To: dev@sling.apache.org Subject: Debugging Sling Models IT HI, I need some help with resolving failures in the models.integration- tests module (don’t worry, those only fail for me due to some local changes). I tried to run the integration-tests with mvn install with the option keepJarRunningtrue/keepJarRunning (set inside the pom.xml) and to start the launchpad with the remote debugging options set. Now I get the following exception when executing the integration test 32492 [main] ERROR org.apache.sling.models.it.RemoteIT - Exception in maybeStartServer() java.lang.IllegalMonitorStateException at java.lang.Object.wait(Native Method) at java.lang.Object.wait(Object.java:503) at org.apache.sling.testing.tools.sling.SlingTestBase.blockIfRequested(Sl ingTestBase.java:234) at org.apache.sling.testing.tools.sling.SlingTestBase.startServerIfNeeded (SlingTestBase.java:152) at org.apache.sling.testing.tools.sling.SlingTestBase.getServerBaseUrl(Sl ingTestBase.java:211) at org.apache.sling.models.it.RemoteIT.getJunitServletUrl(RemoteIT.java:2 8) at org.apache.sling.junit.remote.testrunner.SlingRemoteTestRunner.maybeEx ecuteTests(SlingRemoteTestRunner.java:95) at org.apache.sling.junit.remote.testrunner.SlingRemoteTestRunner.getChil dren(SlingRemoteTestRunner.java:138) at org.junit.runners.ParentRunner.getFilteredChildren(ParentRunner.java:3 63) at org.junit.runners.ParentRunner.getDescription(ParentRunner.java:297) at org.junit.runners.ParentRunner.run(ParentRunner.java:305) at org.apache.maven.surefire.junit4.JUnit4Provider.execute(JUnit4Provider .java:264) at org.apache.maven.surefire.junit4.JUnit4Provider.executeTestSet(JUnit4P rovider.java:153) at org.apache.maven.surefire.junit4.JUnit4Provider.invoke(JUnit4Provider. java:124) at org.apache.maven.surefire.booter.ForkedBooter.invokeProviderInSameClas sLoader(ForkedBooter.java:200) at org.apache.maven.surefire.booter.ForkedBooter.runSuitesInProcess(Forke dBooter.java:153) at org.apache.maven.surefire.booter.ForkedBooter.main(ForkedBooter.java:1 03) I don’t know why the IllegalMonitorStateException is triggered there. Any idea? Thanks in advance, Konrad
Re: Debugging Sling Models IT
Hi Konrad, On Dec 5, 2014 5:42 PM, Konrad Windszus konra...@gmx.de wrote: HI, I need some help with resolving failures in the models.integration-tests module (don’t worry, those only fail for me due to some local changes). I tried to run the integration-tests with mvn install with the option keepJarRunningtrue/keepJarRunning (set inside the pom.xml) and to start the launchpad with the remote debugging options set. Now I get the following exception when executing the integration test 32492 [main] ERROR org.apache.sling.models.it.RemoteIT - Exception in maybeStartServer() java.lang.IllegalMonitorStateException at java.lang.Object.wait(Native Method) at java.lang.Object.wait(Object.java:503) at org.apache.sling.testing.tools.sling.SlingTestBase.blockIfRequested(SlingTestBase.java:234) at org.apache.sling.testing.tools.sling.SlingTestBase.startServerIfNeeded(SlingTestBase.java:152) at org.apache.sling.testing.tools.sling.SlingTestBase.getServerBaseUrl(SlingTestBase.java:211) at org.apache.sling.models.it.RemoteIT.getJunitServletUrl(RemoteIT.java:28) at org.apache.sling.junit.remote.testrunner.SlingRemoteTestRunner.maybeExecuteTests(SlingRemoteTestRunner.java:95) at org.apache.sling.junit.remote.testrunner.SlingRemoteTestRunner.getChildren(SlingRemoteTestRunner.java:138) at org.junit.runners.ParentRunner.getFilteredChildren(ParentRunner.java:363) at org.junit.runners.ParentRunner.getDescription(ParentRunner.java:297) at org.junit.runners.ParentRunner.run(ParentRunner.java:305) at org.apache.maven.surefire.junit4.JUnit4Provider.execute(JUnit4Provider.java:264) at org.apache.maven.surefire.junit4.JUnit4Provider.executeTestSet(JUnit4Provider.java:153) at org.apache.maven.surefire.junit4.JUnit4Provider.invoke(JUnit4Provider.java:124) at org.apache.maven.surefire.booter.ForkedBooter.invokeProviderInSameClassLoader(ForkedBooter.java:200) at org.apache.maven.surefire.booter.ForkedBooter.runSuitesInProcess(ForkedBooter.java:153) at org.apache.maven.surefire.booter.ForkedBooter.main(ForkedBooter.java:103) I don’t know why the IllegalMonitorStateException is triggered there. Any idea? Thanks in advance, Konrad Looks familiar. Can you try depending on a more recent version of the Sling testing tools? Can't dig up the issue right now since I'm on mobile... Robert
[jira] [Reopened] (SLING-4219) [Sightly] Unrecognised operators in expressions are not properly reported as syntax errors
[
https://issues.apache.org/jira/browse/SLING-4219?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Radu Cotescu reopened SLING-4219:
-
[Sightly] Unrecognised operators in expressions are not properly reported as
syntax errors
--
Key: SLING-4219
URL: https://issues.apache.org/jira/browse/SLING-4219
Project: Sling
Issue Type: Bug
Components: Scripting
Reporter: Radu Cotescu
Assignee: Felix Meschberger
Priority: Minor
Fix For: Scripting Sightly Engine 1.0.0
Attachments: SLING-4219.patch
The
{{org.apache.sling.scripting.sightly.impl.compiler.frontend.SightlyParserErrorListener}}
handles ANTLR parsing errors, in order to provide more detailed and easier
to understand error reporting for Sightly scripts.
For the cases when ANTLR doesn't provide a {{RecognitionException}}, although
the listener still throws an error, the error is because the
{{SightlyParsingException}} is instantiated with a {{null}} cause.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (SLING-4219) [Sightly] Unrecognised operators in expressions are not properly reported as syntax errors
[
https://issues.apache.org/jira/browse/SLING-4219?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Radu Cotescu updated SLING-4219:
Attachment: SLING-4219-2.patch
The second patch ([^SLING-4219-2.patch]) increases the verbosity of the
reported parsing errors in {{UnitLoader}}.
[Sightly] Unrecognised operators in expressions are not properly reported as
syntax errors
--
Key: SLING-4219
URL: https://issues.apache.org/jira/browse/SLING-4219
Project: Sling
Issue Type: Bug
Components: Scripting
Reporter: Radu Cotescu
Assignee: Felix Meschberger
Priority: Minor
Fix For: Scripting Sightly Engine 1.0.0
Attachments: SLING-4219-2.patch, SLING-4219.patch
The
{{org.apache.sling.scripting.sightly.impl.compiler.frontend.SightlyParserErrorListener}}
handles ANTLR parsing errors, in order to provide more detailed and easier
to understand error reporting for Sightly scripts.
For the cases when ANTLR doesn't provide a {{RecognitionException}}, although
the listener still throws an error, the error is because the
{{SightlyParsingException}} is instantiated with a {{null}} cause.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
Re: Limit the number of vanityPath MapEntry
we already took in consideration Bloom Filter for a related issue [2]. We decided that is still not too optimal since it leads toward content duplication and I would like to avoid that for now [2] https://issues.apache.org/jira/browse/SLING-3290 Well, imho, bloom filters won't duplicate content -- they'd just have bit-masks to tentatively mark existence of a value. Moreover, if we use guava's implementation (which I think sling doesn't want to do... if I am reading SLING-3290 correctly), then we can serialize them on clean shutdown to have practically no work done during startup. For crashes, we can probably live with re-creating the filter again. About, BloomFilterUtils attached in SLING-3290, I think it's just using 1 hash function to create mask. In general, bloom filter implementation would have more number of hashes to configure less false-positives. About caching actual data in RAM (and assuming sling would sit on top of Oak??) -- should caching of most used nodes be a responsibility of repository implementation?.. but, that's probably a different discussion. Thanks, Vikas
Re: Debugging Sling Models IT
Hi Robert, I found the according issue: https://issues.apache.org/jira/browse/SLING-3819 https://issues.apache.org/jira/browse/SLING-3819. Thanks for the hint. What about a new release of the sling testing tools? Thanks again, Konrad On 05 Dec 2014, at 17:16, Robert Munteanu robert.munte...@gmail.com wrote: Hi Konrad, On Dec 5, 2014 5:42 PM, Konrad Windszus konra...@gmx.de wrote: HI, I need some help with resolving failures in the models.integration-tests module (don’t worry, those only fail for me due to some local changes). I tried to run the integration-tests with mvn install with the option keepJarRunningtrue/keepJarRunning (set inside the pom.xml) and to start the launchpad with the remote debugging options set. Now I get the following exception when executing the integration test 32492 [main] ERROR org.apache.sling.models.it.RemoteIT - Exception in maybeStartServer() java.lang.IllegalMonitorStateException at java.lang.Object.wait(Native Method) at java.lang.Object.wait(Object.java:503) at org.apache.sling.testing.tools.sling.SlingTestBase.blockIfRequested(SlingTestBase.java:234) at org.apache.sling.testing.tools.sling.SlingTestBase.startServerIfNeeded(SlingTestBase.java:152) at org.apache.sling.testing.tools.sling.SlingTestBase.getServerBaseUrl(SlingTestBase.java:211) at org.apache.sling.models.it.RemoteIT.getJunitServletUrl(RemoteIT.java:28) at org.apache.sling.junit.remote.testrunner.SlingRemoteTestRunner.maybeExecuteTests(SlingRemoteTestRunner.java:95) at org.apache.sling.junit.remote.testrunner.SlingRemoteTestRunner.getChildren(SlingRemoteTestRunner.java:138) at org.junit.runners.ParentRunner.getFilteredChildren(ParentRunner.java:363) at org.junit.runners.ParentRunner.getDescription(ParentRunner.java:297) at org.junit.runners.ParentRunner.run(ParentRunner.java:305) at org.apache.maven.surefire.junit4.JUnit4Provider.execute(JUnit4Provider.java:264) at org.apache.maven.surefire.junit4.JUnit4Provider.executeTestSet(JUnit4Provider.java:153) at org.apache.maven.surefire.junit4.JUnit4Provider.invoke(JUnit4Provider.java:124) at org.apache.maven.surefire.booter.ForkedBooter.invokeProviderInSameClassLoader(ForkedBooter.java:200) at org.apache.maven.surefire.booter.ForkedBooter.runSuitesInProcess(ForkedBooter.java:153) at org.apache.maven.surefire.booter.ForkedBooter.main(ForkedBooter.java:103) I don’t know why the IllegalMonitorStateException is triggered there. Any idea? Thanks in advance, Konrad Looks familiar. Can you try depending on a more recent version of the Sling testing tools? Can't dig up the issue right now since I'm on mobile... Robert
[jira] [Resolved] (SLING-4219) [Sightly] Unrecognised operators in expressions are not properly reported as syntax errors
[
https://issues.apache.org/jira/browse/SLING-4219?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Bertrand Delacretaz resolved SLING-4219.
Resolution: Invalid
Assignee: Bertrand Delacretaz (was: Felix Meschberger)
I have applied your second patch in revision 1643357, thanks!
[Sightly] Unrecognised operators in expressions are not properly reported as
syntax errors
--
Key: SLING-4219
URL: https://issues.apache.org/jira/browse/SLING-4219
Project: Sling
Issue Type: Bug
Components: Scripting
Reporter: Radu Cotescu
Assignee: Bertrand Delacretaz
Priority: Minor
Fix For: Scripting Sightly Engine 1.0.0
Attachments: SLING-4219-2.patch, SLING-4219.patch
The
{{org.apache.sling.scripting.sightly.impl.compiler.frontend.SightlyParserErrorListener}}
handles ANTLR parsing errors, in order to provide more detailed and easier
to understand error reporting for Sightly scripts.
For the cases when ANTLR doesn't provide a {{RecognitionException}}, although
the listener still throws an error, the error is because the
{{SightlyParsingException}} is instantiated with a {{null}} cause.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
Re: Debugging Sling Models IT
On Fri, Dec 5, 2014 at 6:13 PM, Konrad Windszus konra...@gmx.de wrote: ...What about a new release of the sling testing tools?... That's on my list but if someone beats me to it I won't complain ;-) -Bertrand
Jenkins build is back to normal : sling-healthcheck-1.6 #565
See https://builds.apache.org/job/sling-healthcheck-1.6/565/
Jenkins build is back to stable : sling-trunk-1.8 » Apache Sling Event Support #510
See https://builds.apache.org/job/sling-trunk-1.8/org.apache.sling$org.apache.sling.event/510/
Jenkins build is back to stable : sling-trunk-1.8 #510
See https://builds.apache.org/job/sling-trunk-1.8/510/changes
Jenkins build is still unstable: sling-trunk-1.7 » Apache Sling Launchpad Testing #1220
See https://builds.apache.org/job/sling-trunk-1.7/org.apache.sling$org.apache.sling.launchpad.testing/1220/
Jenkins build is still unstable: sling-trunk-1.7 #1220
See https://builds.apache.org/job/sling-trunk-1.7/changes
Jenkins build is still unstable: sling-trunk-1.6 » Apache Sling Launchpad Testing #2837
See https://builds.apache.org/job/sling-trunk-1.6/org.apache.sling$org.apache.sling.launchpad.testing/2837/
