Re: maven-3.x-jenkinsfile/embedded-ITs - build #3 - UNSTABLE

2017-03-24 Thread Hervé Boutemy
as you can see, in embedded mode, core ITs can run in 17 minutes, when in classic mode they run in 1h30 any objection to merge this embedded mode into master? Regards, Hervé Le vendredi 24 mars 2017 04:17:49 CET, vous avez écrit : > See

Re: [VOTE] Release Apache Maven 3.5.0-beta-1

2017-03-24 Thread Robert Scholte
+1 On Mon, 20 Mar 2017 19:18:06 +0100, Stephen Connolly wrote: Hi, We solved 15 issues: https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12316922=12339665=Text There are still 10 issues left in JIRA for 3.5.0, but I do not think any of

Re: maven-3.x-jenkinsfile/embedded-ITs - build #3 - UNSTABLE

2017-03-24 Thread Stephen Connolly
Have we some of the tests running in both modes? Specifically at least 4625 as it caught some interesting CLI parsing issues, but there may be a couple more On Fri 24 Mar 2017 at 07:15, Hervé Boutemy wrote: > as you can see, in embedded mode, core ITs can run in 17

Re: MSHADE-209: 'too expensive test'

2017-03-24 Thread Robert Scholte
I see no reason why this is done, maybe Karl Heinz remembers it. I see that a different constructor is used for the filter, must have to do with that, although I see mocks too, which I consider cheap. In general, if tests are too expensive, then the code is probably too complex and should be

Re: Thoughts on MR-Jar support in Maven

2017-03-24 Thread Robert Scholte
Hi Ceki, the compilation-part isn't the real issue (it is acutally the easy part), but e.g. the testing-part is. You must ensure that surefire is also executed at least twice: once for pre-java9 and for java9. And what to do with other plugins which are part of the lifecycle up until the

What to do with the 6 issues left as 3.5.0-candidates?

2017-03-24 Thread Stephen Connolly
https://issues.apache.org/jira/issues/?jql=project%20%3D%20MNG%20AND%20fixVersion%20%3D%203.5.0-candidate%20AND%20resolution%20%3D%20Unresolved%20ORDER%20BY%20due%20ASC%2C%20priority%20DESC%2C%20created%20ASC Here is my opinions: https://issues.apache.org/jira/browse/MNG-6167 - it's too late

Re: What to do with the 6 issues left as 3.5.0-candidates?

2017-03-24 Thread Robert Scholte
On Fri, 24 Mar 2017 11:45:14 +0100, Stephen Connolly wrote:

[RESULT] [VOTE] Release Apache Maven 3.5.0-beta-1

2017-03-24 Thread Stephen Connolly
On 20 March 2017 at 18:18, Stephen Connolly wrote: > Hi, > > We solved 15 issues: > https://issues.apache.org/jira/secure/ReleaseNote.jspa? > projectId=12316922=12339665=Text > > There are still 10 issues left in JIRA for 3.5.0, but I do not think any > of

Re: maven-3.x-jenkinsfile/embedded-ITs - build #3 - UNSTABLE

2017-03-24 Thread Olivier Lamy
sure tempting :-) But is is the same classloader mechanism as a "normal" Maven run? (should be really close but not sure exactly so maybe we can miss some cases) On Fri, 24 Mar 2017 at 6:47 pm, Stephen Connolly < stephen.alan.conno...@gmail.com> wrote: > Have we some of the tests running in both

Re: Thoughts on MR-Jar support in Maven

2017-03-24 Thread Ceki Gülcü
Hi Robert, I would have thought that it was not Maven's responsibility to ascertain that test passed in various JDKs, old and new. Nevertheless, there is no doubt that once you pay attention to the details, things can get messy awfully quick. BTW, thank you for your previous response.

JDK 9 EA Build 162 is available on java.net

2017-03-24 Thread Rory O'Donnell
Hi Robert , *JDK 9 Early Access* b162 is available on java.net, summary of changes are listed here . There is one fix for a bug reported by Open Source projects since the last availability email

Thoughts on MR-Jar support in Maven

2017-03-24 Thread Ceki Gülcü
Hi All, Currently in the process modularizing the SLF4J project in preperation for Java 9/Jigsaw, I ran into many wrinkles most of which are due to my own ignorance about Java 9 modules. Now that the initial phase of modularization is done, I am looking into creating mutlti-release jars

Re: [VOTE] Release Apache Maven 3.5.0-beta-1

2017-03-24 Thread Chas Honton
Not testing maven core ITs. Using multi-module project with 562 goal invocations (50 unique goals) including three integration test suites run with invoker plugin. +1 tested on OS X 10.12.3, Java 1.8.0_074 ++1: 3.5.0 warned about a dependent Pom problem which was not found with 3.3.9 Chas

Re: [VOTE] Release Apache Maven 3.5.0-beta-1

2017-03-24 Thread Christian Schulte
Am 03/24/17 um 16:54 schrieb Karl Heinz Marbaise: > Hi, > > On 24/03/17 02:17, Hervé BOUTEMY wrote: >> we have absolutely no OSX user building Maven core ITs on his personal >> computer? >> seriously? >> Or is there no core IT that shows the issue? then it has to be discovered by >> hand? > > I

Re: Thoughts on MR-Jar support in Maven

2017-03-24 Thread Aldrin Leal
Wouldn't preprocessing help? https://blog.jooq.org/2016/03/01/how-to-support-java-6-8-9-in-a-single-api/ -- -- Aldrin Leal, / http://about.me/aldrinleal On Fri, Mar 24, 2017 at 11:01 AM, Andreas Sewe < s...@st.informatik.tu-darmstadt.de> wrote: > Hi, > > > I would have

Re: What to do with the 6 issues left as 3.5.0-candidates?

2017-03-24 Thread Christian Schulte
Am 03/24/17 um 11:45 schrieb Stephen Connolly: > https://issues.apache.org/jira/issues/?jql=project%20%3D%20MNG%20AND%20fixVersion%20%3D%203.5.0-candidate%20AND%20resolution%20%3D%20Unresolved%20ORDER%20BY%20due%20ASC%2C%20priority%20DESC%2C%20created%20ASC > > Here is my opinions: > >

Re: Thoughts on MR-Jar support in Maven

2017-03-24 Thread Hervé BOUTEMY
not really IMHO the question here is to create one multi-release jar, not how to maintain many (one-)release jars from one sourcecode: MR jars are done to avoid the release- specific jar approach (that preprocessing makes viable) Regards, Hervé Le vendredi 24 mars 2017, 11:08:49 CET Aldrin

Re: maven-3.x-jenkinsfile/embedded-ITs - build #3 - UNSTABLE

2017-03-24 Thread Hervé BOUTEMY
ok, let's share what I know from embedded ITs (sorry, long email, but IMHO useful to share some details): - by default, Verifier forks for every IT and launches Maven with the shell script through ForkedLauncher [1] - in embedded mode, there is no fork but use of MavenCli.doMain(String[] args,

Re: What to do with the 6 issues left as 3.5.0-candidates?

2017-03-24 Thread Christian Schulte
Am 03/24/17 um 23:28 schrieb Stephen Connolly: > Keep in mind that AIUI we aim to be BourneShell compatible in which case $( > ) is not available Thanks for pointing this out. Our launchers have this in the first line: #!/bin/sh /bin/sh should be a POSIX compatible shell. On the BSDs, OSX and

Re: What to do with the 6 issues left as 3.5.0-candidates?

2017-03-24 Thread Christian Schulte
Am 03/25/17 um 01:30 schrieb Christian Schulte: > Am 03/24/17 um 23:28 schrieb Stephen Connolly: >> Keep in mind that AIUI we aim to be BourneShell compatible in which case $( >> ) is not available > > Thanks for pointing this out. Our launchers have this in the first line: > > #!/bin/sh > >

Re: What to do with the 6 issues left as 3.5.0-candidates?

2017-03-24 Thread Christian Schulte
We really need Solaris and OSX Jenkins build nodes :-) - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org

Re: What to do with the 6 issues left as 3.5.0-candidates?

2017-03-24 Thread Christian Schulte
Am 03/24/17 um 22:51 schrieb Stephen Connolly: > I am concerned that there are some quoting issues in mvn. > > In some cases we use var=`command` and in others we use var="`command`" > > Additionally we have a mixture of backtick and $(...) style. My > understanding is that the backticks are for

Re: What to do with the 6 issues left as 3.5.0-candidates?

2017-03-24 Thread Stephen Connolly
I am concerned that there are some quoting issues in mvn. In some cases we use var=`command` and in others we use var="`command`" Additionally we have a mixture of backtick and $(...) style. My understanding is that the backticks are for older shells... but if that is the case we should use

Re: What to do with the 6 issues left as 3.5.0-candidates?

2017-03-24 Thread Stephen Connolly
Keep in mind that AIUI we aim to be BourneShell compatible in which case $( ) is not available On Fri 24 Mar 2017 at 22:15, Christian Schulte wrote: > Am 03/24/17 um 22:51 schrieb Stephen Connolly: > > I am concerned that there are some quoting issues in mvn. > > > > In some

Re: Thoughts on MR-Jar support in Maven

2017-03-24 Thread Robert Scholte
On Fri, 24 Mar 2017 12:20:16 +0100, Ceki Gülcü wrote: I would have thought that it was not Maven's responsibility to ascertain that test passed in various JDKs, old and new. With the classic setup there's only one JDK and all tests are at least executed with that JDK, all

Re: [VOTE] Release Apache Maven 3.5.0-beta-1

2017-03-24 Thread Karl Heinz Marbaise
Hi, On 24/03/17 02:17, Hervé BOUTEMY wrote: we have absolutely no OSX user building Maven core ITs on his personal computer? seriously? Or is there no core IT that shows the issue? then it has to be discovered by hand? I can test today evening or tomorrow...on my Mac.. If this helps? Kind

Re: Thoughts on MR-Jar support in Maven

2017-03-24 Thread Andreas Sewe
Hi, > I would have thought that it was not Maven's responsibility to ascertain > that test passed in various JDKs, old and new. I agree that is is not Maven's responsibility to (out of the box) execute the tests against multiple JREs. If you think it is, one can just as well argue that it should

Re: What to do with the 6 issues left as 3.5.0-candidates?

2017-03-24 Thread Robert Scholte
On Fri, 24 Mar 2017 14:51:22 +0100, Stephen Connolly wrote: On 24 March 2017 at 10:51, Robert Scholte wrote: On Fri, 24 Mar 2017 11:45:14 +0100, Stephen Connolly < stephen.alan.conno...@gmail.com> wrote:

Re: What to do with the 6 issues left as 3.5.0-candidates?

2017-03-24 Thread Stephen Connolly
On 24 March 2017 at 10:51, Robert Scholte wrote: > On Fri, 24 Mar 2017 11:45:14 +0100, Stephen Connolly < > stephen.alan.conno...@gmail.com> wrote: > > https://issues.apache.org/jira/issues/?jql=project%20%3D% >> 20MNG%20AND%20fixVersion%20%3D%203.5.0-candidate%20AND%20r >>