fvwm 2.5.x (bug|spell)fixing patch

2006-03-21 Thread Serge (gentoosiast) Koksharov
Hi, dear FVWM developers, I created this patch which should apply cleanly against FVWM CVS sources of the 2.5 development branch. It mostly fixes documentation typos, mispellings, formatting errors, etc... Also it fixes delay in one of the FvwmAnimate animations. Please keep in mind, that I'm

Re: fvwm 2.5.x (bug|spell)fixing patch

2006-03-27 Thread Serge (gentoosiast) Koksharov
On Sat, Mar 25, 2006 at 10:47:08AM -0500, Dan Espen wrote: The amount of errors you found in the documentation was impressive. No only did you find spelling errors, and grammatical errors, but also just plain wrong things, and misplaced things. I wonder, how did you do that? Hi again, Dan.

yet another documentation fixes

2006-03-28 Thread Serge (gentoosiast) Koksharov
Greetings everyone, As promised, I found and corrected another bunch of typos and other inconsistencies in the docs. Apply against the latest CVS sources of the 2.5 branch. But that's not all, more will follow when I find time to check remaining part of the docs. See you later. -- Serge

Re: yet another documentation fixes

2006-03-29 Thread Serge (gentoosiast) Koksharov
On Tue, Mar 28, 2006 at 11:39:00PM +0100, Thomas Adam wrote: I need to review some of your other fixes --- whilst you've made a fantastic effort in doing so, I can already see one or two technical mistakes that need changing. I'll have to apply this patch and somehow reverse engineer your

mkstemp bug in the FVWM 2.5 branch with possible security consequences

2006-04-03 Thread Serge (gentoosiast) Koksharov
Good (day|morning|night) everyone, During examination of FvwmM4 '--debug' option I decided to examine FVWM's temporary file creation mechanism. Can you believe what I dig out: In libs/System.c there is a pragma '#ifdef HAVE_SAFTY_MKSTEMP'. This construction decides based on configure script

FvwmTaskBar fixes, `Pad' documentation fvwm-bug fixes

2006-04-07 Thread Serge (gentoosiast) Koksharov
Changes. Serge (gentoosiast) Koksharov: -Documentation fixes, bug fix. +Documentation fixes, bug fixes. Arwed von Merkatz: UnderMousePlacement style. diff -Naur fvwmCVS-orig/ChangeLog fvwmCVS-fixed/ChangeLog --- fvwmCVS-orig/ChangeLog 2006-04-07 19:07:10.0 +0400 +++ fvwmCVS-fixed

Re: FvwmTaskBar fixes, `Pad' documentation fvwm-bug fixes

2006-04-08 Thread Serge (gentoosiast) Koksharov
On Sat, Apr 08, 2006 at 11:35:56PM +0100, seventh guardian wrote: On 4/7/06, Serge (gentoosiast) Koksharov [EMAIL PROTECTED] wrote: this and provided a patch. Golden rule to all: test before commit. That's probably my fault. Sorry.. Nothing to bother about. I like one proverb: he

Re: On my recent commits.

2006-04-13 Thread Serge (gentoosiast) Koksharov
On Thu, Apr 13, 2006 at 05:56:52PM +0200, Viktor Griph wrote: The two options I added to the Add command... s/Add/All/ In `fvwm' manual page: If the option Reverse is given the exection order is reversed `exection' should be `execution' Bye. -- Serge Koksharov, Free Software user supporter

Inconsistency during resizing shaded windows

2006-04-14 Thread Serge (gentoosiast) Koksharov
Hi, Yesterday I've noticed little inconsistency during resizing shaded windows under fvwm 2.5.16 and current CVS version: I have in my ~/.fvwm/config `Style * ResizeOpaque'. But during resizing of any shaded window this style ignored and window resized as rubberband outline. I propose two

Re: On my recent commits.

2006-04-14 Thread Serge (gentoosiast) Koksharov
On Thu, Apr 13, 2006 at 05:56:52PM +0200, Viktor Griph wrote: * should the options be allowed in any order. Now Reverse has to precede UseStack. If I understood your changes correctly, UseStack and Reverse options are not directly related to each other. In this case I think they should be

Trivial typos fixes

2006-05-09 Thread Serge (gentoosiast) Koksharov
Greetings, Here is a patch which fixes several trivial typos in fvwm 2.5.x CVS tree which I recently discovered: silde - slide somthing - something unkown - unknown unknow - unknown PGraphicsCreateTransprency - PGraphicsCreateTransparency (renamed function everywhere in the source tree) Also,

Incomplete 'Test' command description

2006-05-21 Thread Serge (gentoosiast) Koksharov
Hello, List, I found out that 'Test' command description in fvwm manpage is incomplete. Let me cite an excerpt: Test [(test-conditions)] command snipThey include Version operator x.y.zsnip The Version operator x.y.z test-condition is fulfilled if the logical condition of the

Re: Incomplete 'Test' command description

2006-05-21 Thread Serge (gentoosiast) Koksharov
On Sun, May 21, 2006 at 09:54:32PM +0100, Thomas Adam wrote: Depends how you read it. It makes sense to me -- the fulfilment being you can use either of the logical operators or not. YMMV on this. :) Really? 1) It not looks like Version's operator can be optional, please look at manpage

Re: Incomplete 'Test' command description

2006-05-23 Thread Serge (gentoosiast) Koksharov
Hi! I attached my patch which complements 'Test' command description in the manpage. Feel free to change/improve it if you want. Adios. -- Serge Koksharov, Free Software user supporter GPG public key ID: 0x3D330896 (pgp.mit.edu) Key fingerprint: 5BC4 0475 CB03 6A31 0076 82C2 C240

Re: Cannot launch FvwmConsole

2006-05-31 Thread Serge (gentoosiast) Koksharov
Hello, Scott Are you using modular XOrg installation without XTerm? If so, you must launch FvwmConsole as 'Module FvwmConsole -terminal your_favorite_term'. Also, is your PATH env variable properly set? Hope that helps. BTW, I think your question really belongs to FVWM Users mailing list, since

Re: bug in the 'Scroll' command

2006-06-01 Thread Serge (gentoosiast) Koksharov
On Fri, Jun 02, 2006 at 01:02:27AM +0200, Dominik Vogt wrote: Actually, any value smaller than 10 can not wrap anyway because it does not go far enough across the screen edge. I wished using these keybindings: Key DownA 4 Scroll 05000 Key Up A 4 Scroll 0

Re: Title font color broken

2006-06-06 Thread Serge (gentoosiast) Koksharov
On Sun, Jun 04, 2006 at 11:15:29AM +0200, Dominik Vogt wrote: Unfortunately I never got any feedback on this from the person who reported it first. The problem was that in some cases the GC used to draw the title was not set before drawing, but it seems the old code relied on this not being

Re: Possible patches

2006-06-06 Thread Serge (gentoosiast) Koksharov
Hello, David, I like 'Conditionals' which can be useful in function which toggles window fullscreen. Also I would use 'RoundedCorners' in my theme and I think many users want and miss this shaped title-bar functionality. And 'Hover' looks appealing. But I think other users will like

'KillModule' broken

2006-07-11 Thread Serge (gentoosiast) Koksharov
Hello, It seems to me that in current fvwm 2.5.17 CVS branch 'KillModule' command is entirely broken. I built current CVS tree on two different computers with two different GNU/Linux distributions and it don't work. You can easily reproduce this with no config at all: launch any module from

FvwmPager: Compilation fix when --enable-debug-msgs is set

2006-07-11 Thread Serge (gentoosiast) Koksharov
Hello, With current state of things it's impossible to compile 2.5.17 CVS branch with --debug-msgs configure option. I investigated created a patch which fixes this problem. Best wishes -- Serge Koksharov, Free Software user supporter GPG public key ID: 0x3D330896 (pgp.mit.edu) Key

Re: FvwmPager: Compilation fix when --enable-debug-msgs is set

2006-07-12 Thread Serge (gentoosiast) Koksharov
On Tue, Jul 11, 2006 at 11:44:22PM +0100, seventh guardian wrote: BTW, is it my impression or you don't have an @ on your ChangeLog email? I have. It is mostly antispam measure. Here in Russia we call this @ symbol in email addresses - dog. Best wishes -- Serge Koksharov, Free Software user

FAQ Q7.17 error?

2006-07-12 Thread Serge (gentoosiast) Koksharov
Hello, In question 7.17 of the FVWM FAQ Autohiding FvwmButtons or other windows module FvwmAuto launched like this: + I Module FvwmAuto FvwmAutohide -menter enter_handler But from reading manpage source code of this module I figured out that it doesn't accept aliases, right? So, I think

bugfix with clearing 'NoIcon' style

2006-07-13 Thread Serge (gentoosiast) Koksharov
Hello, Let me cite an excerpt of manpage: If the NoIcon attribute is set then the specified window simply disappears when it is iconified. The window can be recovered through the window-list. If Icon is set without an argument then the NoIcon attribute is cleared but no icon is

Re: bugfix with clearing 'NoIcon' style

2006-07-14 Thread Serge (gentoosiast) Koksharov
On Fri, Jul 14, 2006 at 12:28:45AM +0200, Dominik Vogt wrote: Um, if the manpage is not clear enough, it should be reworded. The NoIcon style is *of course* overridden by specifying an icon, Oh, I missed this nuance. But I still think that my change is useful. Author which implemented current

Re: bugfix with clearing 'NoIcon' style

2006-07-16 Thread Serge (gentoosiast) Koksharov
On Sun, Jul 16, 2006 at 12:51:55PM +0200, Dominik Vogt wrote: On Sat, Jul 15, 2006 at 03:55:17AM +0400, Serge (gentoosiast) Koksharov wrote: On Fri, Jul 14, 2006 at 12:28:45AM +0200, Dominik Vogt wrote: Um, if the manpage is not clear enough, it should be reworded. The NoIcon style

bug: 'CopyMenuStyle' command don't copies 'TitleColorset'

2006-07-17 Thread Serge (gentoosiast) Koksharov
Hello, I hope I'm not too late and 2.5.17 still not released. Today I found a bug in menu code: 'CopyMenuStyle' don't copies recently introduced 'TitleColorset'. Attached patch fixes this. Happy release have a good time everyone -- Serge Koksharov, Free Software user supporter GPG public

FvwmIconMan: 'SortWeight' parsing

2006-07-22 Thread Serge (gentoosiast) Koksharov
Hello, In 'FvwmIconMan' module 'SortWeight' option couldn't parse window title with spaces. The only way now is wildcards. Could we change this? Two possible variants come into mind: 1. Escaping spaces: *FvwmIconMan: SortWeight 1 class=XTerm title=A\ title\ with\ spaces 2. Quoting entire

Documentation for module developers

2006-07-30 Thread Serge (gentoosiast) Koksharov
Hi, Are http://www.fvwm.org/documentation/dev_modules.php is the only module related documentation available? BTW, I found an error on this page: in section 'Colorset support' InitPictureCMap() should be PictureInitCMap() instead (this function was renamed on 2002-04-22 according to main

Re: Documentation for module developers

2006-07-30 Thread Serge (gentoosiast) Koksharov
On Sun, Jul 30, 2006 at 06:02:51PM +0100, Thomas Adam wrote: On Sun, 30 Jul 2006 14:40:50 +0400 Serge (gentoosiast) Koksharov [EMAIL PROTECTED] wrote: Hi, Are http://www.fvwm.org/documentation/dev_modules.php is the only module related documentation available? BTW, I found an error

FvwmWinList: string truncation in DoButton function

2006-08-01 Thread Serge (gentoosiast) Koksharov
Hello, While studying code of the FvwmWinList module I found that truncation code isn't very well written: 1) Truncated string saved only if 'TruncateLeft' option is set. If not, string recalculated each time. 2) If 'TruncateLeft' isn't set, during truncation only length of the string is

Re: Patching FvwmButtons to use Balloons (tooltips).

2006-08-01 Thread Serge (gentoosiast) Koksharov
Hello, Thomas, On Mon, Jul 31, 2006 at 03:10:08PM +0100, Thomas Adam wrote: Dear all, Before I attempt to do this, I just wanted to make sure that this is something worthwhile doing. Currently, FvwmPager is about the only module that implements balloons to easily tell which window is

Re: FvwmWinList: string truncation in DoButton function

2006-08-03 Thread Serge (gentoosiast) Koksharov
Oops, paths to changed files in modules/ChangeLog were incorrect. I corrected them. diff -Naur fvwmCVS-orig/modules/ChangeLog fvwmCVS-fixed/modules/ChangeLog --- fvwmCVS-orig/modules/ChangeLog 2006-08-01 12:38:42.0 +0400 +++ fvwmCVS-fixed/modules/ChangeLog 2006-08-03

FvwmForm: WM_DELETE_WINDOW support

2006-08-03 Thread Serge (gentoosiast) Koksharov
Hello, Attached patch adds WM_DELETE_WINDOW support to the 'FvwmForm' module. Note, that if 'GrabServer' command is set, for obvious reasons it is impossible to close window by clicking close button on window's title. Bye -- Serge Koksharov, Free Software user supporter GPG public key ID:

New MenuStyle which forbids tear off

2006-08-04 Thread Serge (gentoosiast) Koksharov
Hello, I want new MenuStyle which disables ability to tear off menu. Reason: because I have some dynamic menues like this: Mouse 3 IST A Menu winmenu +0m +0 DestroyMenu winmenu AddToMenu winmenu Window menu: Title + DynamicPopupAction Function MakeWinMenu DestroyFunc MakeWinMenu AddToFunc

FvwmIconMan: a few trivial fixes

2006-08-05 Thread Serge (gentoosiast) Koksharov
Hi, From attached patch's ChangeLog: * FvwmIconMan/FvwmIconMan.1.in: documented ShowOnlyFocused option. fixed typo. * FvwmIconMan/readconfig.c (read_in_resources): corrected warning message when an argument to Shape option is omitted. Bye -- Serge Koksharov, Free Software user

FvwmIconMan: debug code cleanup

2006-08-07 Thread Serge (gentoosiast) Koksharov
Hello, Here some documentation fixes and debug code cleanups in FvwmIconMan. Please see attached patch's ChangeLog section for more information. Bye. -- Serge Koksharov, Free Software user supporter GPG public key ID: 0x3D330896 (pgp.mit.edu) Key fingerprint: 5BC4 0475 CB03 6A31 0076 82C2

Re: FVWM: DjView fullscreen issue

2006-08-11 Thread Serge (gentoosiast) Koksharov
On Thu, Aug 10, 2006 at 01:56:48PM +0100, seventh guardian wrote: After some messing around with qmake and the generated makefile I managed to compile the program (having both qt3 and qt4 installed gets messy..). There's one catch with it, which makes it impossible to test for the problem with

Re: Hello, where did fw-frame_g go?

2007-01-03 Thread Serge (gentoosiast) Koksharov
On Wed, Jan 03, 2007 at 09:45:59PM +0100, Jesús Guerrero wrote: Hello, I am new to the list and my first question is this. I am not new to C but I am new to the fvwm sources, so I am a bit loss. In the rounded corners patch someone used fw-frame_g.width and fw-frame_g.height to access