Re: [PHP-DEV] [RESULT] Re: [PHP-DEV] [VOTE] Round two, PHP 8.0 RM

2020-05-06 Thread Gabriel Caruso
Hello Kalle, Sara On Wed, 6 May 2020 at 17:52, Kalle Sommer Nielsen wrote: > Den tir. 5. maj 2020 kl. 21.05 skrev Sara Golemon : > > I assume you're already familiar with > > https://github.com/php/php-src/blob/master/docs/release-process.md as > our > > official process documentation. > > > >

[PHP-DEV] Re: [RFC] Constructor Property Promotion

2020-05-06 Thread Andrea Faulds
Hi Nikita, Nikita Popov wrote: On Thu, Mar 26, 2020 at 2:30 PM Nikita Popov wrote: > I think the best answer to this question may be to forbid the use of attributes on promoted properties entirely, because there is no unambiguous interpretation for them. I also think that using attributes

Re: [PHP-DEV] [RFC] Parameter Blocks (vs. Constructor Property Promotion and Named Parameters)

2020-05-06 Thread Mike Schinkel
> On May 6, 2020, at 4:14 PM, Rowan Tommins wrote: > > Hi Mike, > > On 06/05/2020 20:48, Mike Schinkel wrote: >> Consider simply what we might call "Parameter Blocks." Since PHP always >> expects a parentheses to follow the function or method name it should be >> possible to opt-in replace

Re: [PHP-DEV] [RFC] Parameter Blocks (vs. Constructor Property Promotion and Named Parameters)

2020-05-06 Thread Rowan Tommins
Hi Mike, On 06/05/2020 20:48, Mike Schinkel wrote: Consider simply what we might call "Parameter Blocks." Since PHP always expects a parentheses to follow the function or method name it should be possible to opt-in replace it with a brace-enclosed block of parameters instead since it would

Re: [PHP-DEV] [RFC] Named arguments

2020-05-06 Thread Rowan Tommins
Hi John, On 6 May 2020 19:18:41 BST, John Bafford wrote: You're not wrong here, but, I think that's an (critical) implementation detail of Objective-C and Smalltalk that is not relevant here. Also, Swift does not use selectors or message passing, unless either interoperating with ObjC classes,

Re: [PHP-DEV] [RFC] Parameter Blocks (vs. Constructor Property Promotion and Named Parameters)

2020-05-06 Thread Mike Schinkel
> On Mar 26, 2020, at 9:30 AM, Nikita Popov wrote: > > Hi internals, > > I would like to submit the following RFC for your consideration: > https://wiki.php.net/rfc/constructor_promotion > > This is based on one off the suggestions made in > https://externals.io/message/109220, and some

Re: [PHP-DEV] [RFC] Named arguments

2020-05-06 Thread John Bafford
Hi Rowan, > On May 5, 2020, at 16:47, Rowan Tommins wrote: > > Hi John, > > On 05/05/2020 18:27, John Bafford wrote: >> I very much do like the idea of named parameters, but I do not like the >> specific proposal in the linked RFC at all. I think that treating named >> parameters simply as

Re: [PHP-DEV] [RESULT] Re: [PHP-DEV] [VOTE] Round two, PHP 8.0 RM

2020-05-06 Thread Kalle Sommer Nielsen
Den tir. 5. maj 2020 kl. 21.05 skrev Sara Golemon : > I assume you're already familiar with > https://github.com/php/php-src/blob/master/docs/release-process.md as our > official process documentation. > > I'd also like to point you at https://github.com/sgolemon/php-release > (prebuilt > on

[PHP-DEV] Making IPC_PRIVATE available to userland

2020-05-06 Thread Christoph M. Becker
Hi all, the POSIX standard doesn't mandate that IPC_PRIVATE has any particular value; in practise it is often (maybe always) zero, but I think the constant is important enough to deserve its own PHP userland constant. It would be useful for shmop_open(), shm_attach() and sem_get(), but these

Re: [PHP-DEV] Re: [RFC] Constructor Property Promotion

2020-05-06 Thread Larry Garfield
On Wed, May 6, 2020, at 3:31 AM, Nikita Popov wrote: > On Tue, May 5, 2020 at 10:27 PM Larry Garfield > wrote: > > > On Tue, May 5, 2020, at 7:35 AM, Nikita Popov wrote: > > > > > > > Performing validation when the getAttributes() call is performed does > > sound > > > reasonable to me. We can

Re: [PHP-DEV] Deprecating uniqid()

2020-05-06 Thread Aleksander Machniak
On 06.05.2020 14:44, Nikita Popov wrote: > A possible candidate for this would be ULID (https://github.com/ulid/spec), > which is basically timestamp + random + base32 encoding. The timestamp part > makes ULIDs approximately lexicographically orderable, the random part > makes sure things are

Re: [PHP-DEV] Deprecating uniqid()

2020-05-06 Thread Nikita Popov
On Wed, May 6, 2020 at 2:34 PM Rowan Tommins wrote: > On 5 May 2020 09:42:19 BST, Arvids Godjuks > wrote: > >So in my opinion, a better replacement for uniqid is needed - have it > >generate a bigger string with more entropy and better underline algorithm, > >but it being time-based should be a

Re: [PHP-DEV] [RFC] Named arguments

2020-05-06 Thread Nikita Popov
On Tue, May 5, 2020 at 8:38 PM Lynn wrote: > > > On Tue, May 5, 2020 at 8:22 PM Nikita Popov wrote: > >> Anyway. Your point that named arguments expand the API surface has been >> acknowledged. I don't think this issue is really avoidable, it's a rather >> fundamental trade-off of named

Re: [PHP-DEV] Deprecating uniqid()

2020-05-06 Thread Dan Ackroyd
On Wed, 6 May 2020 at 13:34, Rowan Tommins wrote: > > On 5 May 2020 09:42:19 BST, Arvids Godjuks wrote: > >So in my opinion, a better replacement for uniqid is needed - > > You're right that the requirements for "random" and "unique" are distinct. > Perhaps what we need is a unique_string

Re: [PHP-DEV] Deprecating uniqid()

2020-05-06 Thread Rowan Tommins
On 5 May 2020 09:42:19 BST, Arvids Godjuks wrote: >So in my opinion, a better replacement for uniqid is needed - have it >generate a bigger string with more entropy and better underline algorithm, >but it being time-based should be a thing stiff. And do not call it a >"random_string" or

Re: [PHP-DEV] Update coding standards wrt. C99?

2020-05-06 Thread Christoph M. Becker
On 06.05.2020 at 12:52, G. P. B. wrote: > On Wed, 6 May 2020 at 12:20, Xinchen Hui wrote: > >> mixing declarations and codes sometimes brings unexpected >> varaibles overriden and hard to debugging. > > In a perfect world we would be able to enable the -Wshadow GCC > compiler warning which would

Re: [PHP-DEV] [RFC] Mixed type

2020-05-06 Thread Dan Ackroyd
Benas IML wrote: > Is there any update on the RFC? Given that there isn't much discussion and 2 > weeks have passed, ... The "two weeks" thing is a minimum. I personally would prefer if most discussions were longer than that whenever possible. It's entirely possible for someone to not have

Re: [PHP-DEV] Update coding standards wrt. C99?

2020-05-06 Thread G. P. B.
On Wed, 6 May 2020 at 12:20, Xinchen Hui wrote: > mixing declarations and codes sometimes brings unexpected > varaibles overriden and hard to debugging. > > thanks > > -- > Xinchen Hui > @Laruence > http://www.laruence.com/ In a perfect world we would be able to enable the -Wshadow GCC

Re: [PHP-DEV] Update coding standards wrt. C99?

2020-05-06 Thread Xinchen Hui
On Wed, May 6, 2020 at 6:20 PM Xinchen Hui wrote: > > Hey: > > On Wed, May 6, 2020 at 3:32 PM Christoph M. Becker > wrote: > >> Hi all, >> >> since master requires (mostly) C99 compliant compilers anyway, I wonder >> if we like to update our coding standards[1], to reflect: >> >> * that we

Re: [PHP-DEV] Update coding standards wrt. C99?

2020-05-06 Thread Xinchen Hui
Hey: On Wed, May 6, 2020 at 3:32 PM Christoph M. Becker wrote: > Hi all, > > since master requires (mostly) C99 compliant compilers anyway, I wonder > if we like to update our coding standards[1], to reflect: > > * that we require (mostly) C99 compliant compilers (instead of ANSI-C > compliant

Re: [PHP-DEV] Re: [RFC] Constructor Property Promotion

2020-05-06 Thread Nikita Popov
On Tue, May 5, 2020 at 10:27 PM Larry Garfield wrote: > On Tue, May 5, 2020, at 7:35 AM, Nikita Popov wrote: > > > > Performing validation when the getAttributes() call is performed does > sound > > reasonable to me. We can also add a class flag to perform this validation > > only once (if it is

Re: [PHP-DEV] Update coding standards wrt. C99?

2020-05-06 Thread Nikita Popov
On Wed, May 6, 2020 at 9:32 AM Christoph M. Becker wrote: > Hi all, > > since master requires (mostly) C99 compliant compilers anyway, I wonder > if we like to update our coding standards[1], to reflect: > > * that we require (mostly) C99 compliant compilers (instead of ANSI-C > compliant

[PHP-DEV] Re: [RFC] Named arguments Nikita Popov

2020-05-06 Thread Maciej Sobaczewski
W dniu 06.05.2020 o 09:43, Christoph M. Becker pisze: On 06.05.2020 at 08:25, Maciej Sobaczewski wrote: I'm on the fence when it comes to the feature itself so I will skip that part entirerly but I'd like to draw attention to one more problem. Many PHP Manual translations translate the

Re: [PHP-DEV] Re: [RFC] Named arguments

2020-05-06 Thread Benjamin Eberlei
On Wed, May 6, 2020 at 8:25 AM Maciej Sobaczewski wrote: > Hi Nikita! > > W dniu 05.05.2020 o 15:51, Nikita Popov pisze: > > Hi internals, > > > > I've recently started a thread on resurrecting the named arguments > proposal > > (https://externals.io/message/109549), as this has come up

[PHP-DEV] Re: [RFC] Named arguments

2020-05-06 Thread Christoph M. Becker
On 06.05.2020 at 08:25, Maciej Sobaczewski wrote: > I'm on the fence when it comes to the feature itself so I will skip that > part entirerly but I'd like to draw attention to one more problem. Many > PHP Manual translations translate the parameter names, too - both in > text, as well as in the

[PHP-DEV] Update coding standards wrt. C99?

2020-05-06 Thread Christoph M. Becker
Hi all, since master requires (mostly) C99 compliant compilers anyway, I wonder if we like to update our coding standards[1], to reflect: * that we require (mostly) C99 compliant compilers (instead of ANSI-C compliant compilers) * that mixing of declarations and statements is fine * that

[PHP-DEV] Re: [RFC] Named arguments

2020-05-06 Thread Maciej Sobaczewski
Hi Nikita! W dniu 05.05.2020 o 15:51, Nikita Popov pisze: Hi internals, I've recently started a thread on resurrecting the named arguments proposal (https://externals.io/message/109549), as this has come up tangentially in some recent discussions around attributes and around object ergonomics.