Re: [lazarus] win32extra merged into FPC
On Feb 11, 2008 9:36 AM, Vincent Snijders [EMAIL PROTECTED] wrote: I think we should add IFDEF's for fpc 2.2.0 to keep the current code. That's even better =) -- Felipe Monteiro de Carvalho _ To unsubscribe: mail [EMAIL PROTECTED] with unsubscribe as the Subject archives at http://www.lazarus.freepascal.org/mailarchives
Re: [lazarus] win32extra merged into FPC
On Mon, Feb 11, 2008 at 09:50:40AM +0100, Felipe Monteiro de Carvalho wrote: On Feb 11, 2008 9:36 AM, Vincent Snijders [EMAIL PROTECTED] wrote: I think we should add IFDEF's for fpc 2.2.0 to keep the current code. That's even better =) Moreover it only affects win32/64 in the first place. So people grabbing binaries from outdated package systems is less of a problem. Windows users generally go for all-in-one installers. _ To unsubscribe: mail [EMAIL PROTECTED] with unsubscribe as the Subject archives at http://www.lazarus.freepascal.org/mailarchives
Re: [lazarus] win32extra merged into FPC
On Mon, Feb 11, 2008 at 09:16:16AM +0700, Paul Ishenin wrote:
since 2.2.0. (the shell* units are mostly post 2.2.0 though). Most no
There are some issues that must be still resolved:
- TNMLVCustomDraw win32extra definition doesn't match commctrl one.
I will fix this in lazarus. If we look at winapi definition then
typedef struct tagNMLVCUSTOMDRAW {
NMCUSTOMDRAW nmcd;
COLORREF clrText;
COLORREF clrTextBk;
...
}
In lazarus definition NMCUSTOMDRAW fields are moved from nested record
field into TNMLVCUSTOMDRAW itself.
Ah, now I see. Note that the winapi version is already in commctrls. It
doesn't need redefinition
- comctrlversion* constants are not known in the SDK. What are these?
- DSC_ constants are unknown in SDK (DSC_MODAL, DSC_MODELESS)
(so these will stay)
notes:
- cdrf_NOTIFYITEMERASE not available in SDK 6.0!?!?! - added for now
anyway, since some other constants (swp_*) have comments that defines
from wine were added.
open msdn for NM_CUSTOMDRAW (list view) and you'll see CDRF_NOTIFYITEMERASE
(I grepped the headers of a SDK (6.0) dled last week. No match. Note that I
copied it anyway)
My full notes of the conversion is here:
- http://www.stack.nl/~marcov/win32extranotes.txt
I found this:
swp_* new items added, one not in sdk, but comments says it is from wine.
Comment actually says that this one value is not documented, but windows
itself uses it. IIRC name of this const has been taken from wine since
there is no official name for undocumented const :)
Yes, but it was good enough, it is copied.
I'll merge these changes to 2.2.1 today, since they mostly are nearly only
constants, and then the symbols can be removed/ifdefed from win32extra.
Big thanks.
They were merged to 2.2.1 yesterdayevening, and since your comments don't
need more changes FPC side, I guess Lazarus can start changing when they
want.
_
To unsubscribe: mail [EMAIL PROTECTED] with
unsubscribe as the Subject
archives at http://www.lazarus.freepascal.org/mailarchives
Re: [lazarus] win32extra merged into FPC
On Feb 11, 2008 8:58 AM, Marco van de Voort [EMAIL PROTECTED] wrote: They were merged to 2.2.1 yesterdayevening, and since your comments don't need more changes FPC side, I guess Lazarus can start changing when they want. Althougth we already require 2.2.1 for wince I'd rather not also require for win32 now. The time to download subversion fpc and build it is considerable, not to mention many people won't know how to do that (lazarus svn is popular). I'd rather wait for 2.2.2 before changing that. -- Felipe Monteiro de Carvalho _ To unsubscribe: mail [EMAIL PROTECTED] with unsubscribe as the Subject archives at http://www.lazarus.freepascal.org/mailarchives
Re: [lazarus] win32extra merged into FPC
Felipe Monteiro de Carvalho schreef: On Feb 11, 2008 8:58 AM, Marco van de Voort [EMAIL PROTECTED] wrote: They were merged to 2.2.1 yesterdayevening, and since your comments don't need more changes FPC side, I guess Lazarus can start changing when they want. Althougth we already require 2.2.1 for wince I'd rather not also require for win32 now. The time to download subversion fpc and build it is considerable, not to mention many people won't know how to do that (lazarus svn is popular). I'd rather wait for 2.2.2 before changing that. I think we should add IFDEF's for fpc 2.2.0 to keep the current code. Vincent _ To unsubscribe: mail [EMAIL PROTECTED] with unsubscribe as the Subject archives at http://www.lazarus.freepascal.org/mailarchives
[lazarus] win32extra merged into FPC
I merged the few remaining symbols into FPC units. Note that most of the symbols that win32extra provides are already in commctrl, and thus in FPC since 2.2.0. (the shell* units are mostly post 2.2.0 though). Most no There are some issues that must be still resolved: - TNMLVCustomDraw win32extra definition doesn't match commctrl one. - comctrlversion* constants are not known in the SDK. What are these? - DSC_ constants are unknown in SDK (DSC_MODAL, DSC_MODELESS) notes: - BIF_* are in shlobj AND shellapi, probably due to conversion error. One set might disappear as soon as I find out which one Delphi uses. - cdrf_NOTIFYITEMERASE not available in SDK 6.0!?!?! - added for now anyway, since some other constants (swp_*) have comments that defines from wine were added. - openfilename struct: windows unit has been strongly updated with comdlg structs a while ago. Note that openfilename_nt4 refers to the old struct and openfilename to the new (w2k) struct, which is slightly different from the win32extra version where the _nt4 symbols are simply an alias for the w2k one. My full notes of the conversion is here: - http://www.stack.nl/~marcov/win32extranotes.txt I'll merge these changes to 2.2.1 today, since they mostly are nearly only constants, and then the symbols can be removed/ifdefed from win32extra. Lazarus will need some mods, mostly importing of winunits-base units (commctrl,activex,shlobj,shellapi) _ To unsubscribe: mail [EMAIL PROTECTED] with unsubscribe as the Subject archives at http://www.lazarus.freepascal.org/mailarchives
Re: [lazarus] win32extra merged into FPC
Marco van de Voort wrote:
I merged the few remaining symbols into FPC units. Note that most of the
symbols that win32extra provides are already in commctrl, and thus in FPC
since 2.2.0. (the shell* units are mostly post 2.2.0 though). Most no
There are some issues that must be still resolved:
- TNMLVCustomDraw win32extra definition doesn't match commctrl one.
I will fix this in lazarus. If we look at winapi definition then
typedef struct tagNMLVCUSTOMDRAW {
NMCUSTOMDRAW nmcd;
COLORREF clrText;
COLORREF clrTextBk;
...
}
In lazarus definition NMCUSTOMDRAW fields are moved from nested record
field into TNMLVCUSTOMDRAW itself.
- comctrlversion* constants are not known in the SDK. What are these?
no need to move them to fpc
- DSC_ constants are unknown in SDK (DSC_MODAL, DSC_MODELESS)
just for internal use = no need to move to fpc
notes:
- cdrf_NOTIFYITEMERASE not available in SDK 6.0!?!?! - added for now
anyway, since some other constants (swp_*) have comments that defines
from wine were added.
open msdn for NM_CUSTOMDRAW (list view) and you'll see CDRF_NOTIFYITEMERASE
- openfilename struct: windows unit has been strongly updated with comdlg
structs a while ago. Note that openfilename_nt4 refers to the old struct
and
openfilename to the new (w2k) struct, which is slightly different from the
win32extra version where the _nt4 symbols are simply an alias for the w2k
one.
hope Vincent will comment
My full notes of the conversion is here:
- http://www.stack.nl/~marcov/win32extranotes.txt
I found this:
swp_* new items added, one not in sdk, but comments says it is from wine.
Comment actually says that this one value is not documented, but windows
itself uses it. IIRC name of this const has been taken from wine since
there is no official name for undocumented const :)
I'll merge these changes to 2.2.1 today, since they mostly are nearly only
constants, and then the symbols can be removed/ifdefed from win32extra.
Big thanks.
Best regards,
Paul Ishenin.
_
To unsubscribe: mail [EMAIL PROTECTED] with
unsubscribe as the Subject
archives at http://www.lazarus.freepascal.org/mailarchives
