doc fix for lily/stem-engraver.cc (issue 198820043 by david.nales...@gmail.com)

Reviewers: , Message: Please review. Description: doc fix for lily/stem-engraver.cc This engraver also creates Flag and StemStub grobs. Please review this at https://codereview.appspot.com/198820043/ Affected files (+3, -1 lines): M lily/stem-engraver.cc Index: lily/stem-engraver.cc diff

Re: making measure-counter-stencil public (issue 203130043 by thomasmorle...@gmail.com)

LGTM. Thanks! https://codereview.appspot.com/203130043/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: 'measure-counter-stencil' not public?

Hi Harm, On Tue, Feb 17, 2015 at 5:09 PM, Thomas Morley thomasmorle...@gmail.com wrote: 2015-02-17 21:35 GMT+01:00 David Nalesnik david.nales...@gmail.com: Hi Harm, On Tue, Feb 17, 2015 at 2:21 PM, Thomas Morley thomasmorle...@gmail.com wrote: Hi, is there any reason

Re: Make Grob::name accessible to Scheme (issue 203090043 by david.nales...@gmail.com)

On Mon, Feb 16, 2015 at 1:30 PM, David Kastrup d...@gnu.org wrote: David Nalesnik david.nales...@gmail.com writes: I suppose even better would be to come up with a way to automatically document public Scheme functions, but I wouldn't know how to do that at this point. Shouldn't actually

Re: Make Grob::name accessible to Scheme (issue 203090043 by david.nales...@gmail.com)

On Mon, Feb 16, 2015 at 10:04 AM, Paul Morris p...@paulwmorris.com wrote: P.S. FWIW, here's one marginal use case. I've been using grob names to differentiate key signature grobs from key cancellation grobs, within a custom engraver that acknowledges the key-signature-interface. I could add

Re: Make Grob::name accessible to Scheme (issue 203090043 by david.nales...@gmail.com)

On Mon, Feb 16, 2015 at 12:20 PM, David Kastrup d...@gnu.org wrote: Paul Morris p...@paulwmorris.com writes: dak wrote Paul Morris lt; paul@ gt; writes: Hmmm... would it be a good idea to also have a ly:grob-has-interface scheme function? How would it differ from the

Re: Function to display the rhythmic location of a grob (issue 197690044 by david.nales...@gmail.com)

On 2015/02/18 18:08:32, david.nalesnik wrote: Putting it into Scheme will need to wait for Issue 4289 to make it to master, since I'll be able to use ly:item-get-column here. https://codereview.appspot.com/197690044/ ___ lilypond-devel mailing list

Re: Function to display the rhythmic location of a grob (issue 197690044 by david.nales...@gmail.com)

On 2015/02/18 18:02:38, dak wrote: On 2015/02/18 17:53:44, david.nalesnik wrote: Please review. Thanks! Can't this be done just as easily in Scheme? Sure--that crossed my mind. The reason I went with C++ is so that it would be documented prominently, but I could change it if that's not a

Re: Function to display the rhythmic location of a grob (issue 197690044 by david.nales...@gmail.com)

On 2015/02/18 18:07:19, dak wrote: On 2015/02/18 18:05:17, david.nalesnik wrote: On 2015/02/18 18:02:38, dak wrote: On 2015/02/18 17:53:44, david.nalesnik wrote: Please review. Thanks! Can't this be done just as easily in Scheme? Sure--that crossed my mind. The reason I went with

Function to display the rhythmic location of a grob (issue 197690044 by david.nales...@gmail.com)

Reviewers: , Message: Please review. Thanks! Description: Function to display the rhythmic location of a grob A convenient way to return the musical position of a grob within a score will be very helpful in debugging, among other uses. This patch creates a function ly:grob-rhythmic-location

Re: Make Grob::name accessible to Scheme (issue 203090043 by david.nales...@gmail.com)

Hmmm. Since this is no longer just a wrapper for Grob::name, I suppose I should rewrite it in Scheme. https://codereview.appspot.com/203090043/ ___ lilypond-devel mailing list lilypond-devel@gnu.org

Re: Function to display the rhythmic location of a grob (issue 197690044 by david.nales...@gmail.com)

On 2015/02/18 18:12:58, david.nalesnik wrote: On 2015/02/18 18:08:32, david.nalesnik wrote: Putting it into Scheme will need to wait for Issue 4289 to make it to master, since I'll be able to use ly:item-get-column here. However, we lose the nice error reporting which happens when you do

Re: Function to display the rhythmic location of a grob (issue 197690044 by david.nales...@gmail.com)

On 2015/02/18 20:39:19, david.nalesnik wrote: On 2015/02/18 18:12:58, david.nalesnik wrote: On 2015/02/18 18:08:32, david.nalesnik wrote: Putting it into Scheme will need to wait for Issue 4289 to make it to master, since I'll be able to use ly:item-get-column here. However, we lose the

Re: Make Grob::name accessible to Scheme (issue 203090043 by david.nales...@gmail.com)

On 2015/02/18 19:32:57, david.nalesnik wrote: Hmmm. Since this is no longer just a wrapper for Grob::name, I suppose I should rewrite it in Scheme. Not so sure now. Error reporting options in Scheme aren't as good. https://codereview.appspot.com/203090043/

Re: 'measure-counter-stencil' not public?

Hi Harm, On Tue, Feb 17, 2015 at 2:21 PM, Thomas Morley thomasmorle...@gmail.com wrote: Hi, is there any reason the stencil-procedure for 'measure-counter-stencil' isn't public? It doesn't works with 'make-stencil-boxer' etc Apparently, for no good reason! Do you want to change it?

Re: Make Grob::name accessible to Scheme (issue 203090043 by david.nales...@gmail.com)

On Mon, Feb 16, 2015 at 4:01 PM, Paul Morris p...@paulwmorris.com wrote: On Feb 16, 2015, at 2:06 PM, David Nalesnik david.nales...@gmail.com wrote: In this case, KeySignature has both key-signature-interface and key-cancellation-interface, but KeyCancellation only has key-cancellation

Re: Function to display the rhythmic location of a grob (issue 197690044 by david.nales...@gmail.com)

On 2015/02/18 20:43:51, david.nalesnik wrote: it seems that a drawback of using Scheme is losing the nice error messages that result from doing LY_ASSERT_SMOB. False alarm. https://codereview.appspot.com/197690044/ ___ lilypond-devel mailing

Add Scheme function to return column associated with Item. (issue 203910043 by david.nales...@gmail.com)

Reviewers: , Message: Please review. Description: Add Scheme function to return column associated with Item. The C++ function PaperColumn::get_column is used frequently, and it makes sense to have a Scheme function which performs the same task. An example of a practical application is the

Re: Make Grob::name accessible to Scheme (issue 203090043 by david.nales...@gmail.com)

On 2015/02/16 07:56:10, dak wrote: On 2015/02/15 19:54:19, david.nalesnik wrote: Please review. Thanks! Needing to determine the name of a grob should actually rarely be necessary: the pervasive information connected to the functionality of a grob is rather its interfaces. That's the

Re: Make Grob::name accessible to Scheme (issue 203090043 by david.nales...@gmail.com)

On 2015/02/18 20:46:03, david.nalesnik wrote: On 2015/02/18 19:32:57, david.nalesnik wrote: Hmmm. Since this is no longer just a wrapper for Grob::name, I suppose I should rewrite it in Scheme. Not so sure now. Error reporting options in Scheme aren't as good. I take that back. If I

Re: Make Grob::name accessible to Scheme (issue 203090043 by david.nales...@gmail.com)

And in a few moments a version where I didn't strip the docstring... https://codereview.appspot.com/203090043/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Issue 2535: Staccato on stem side alignment when other articulations are present (issue 196260043 by david.nales...@gmail.com)

Reviewers: , Message: Please review. Description: Issue 2535: Staccato on stem side alignment when other articulations are present The default positioning of staccato dots in combination with other articulations is poor, because the dot is positioned midway between the center of the note head

Re: Issue 2535: Staccato on stem side alignment when other articulations are present (issue 196260043 by david.nales...@gmail.com)

https://codereview.appspot.com/196260043/diff/20001/input/regression/script-shift.ly File input/regression/script-shift.ly (right): https://codereview.appspot.com/196260043/diff/20001/input/regression/script-shift.ly#newcode6 input/regression/script-shift.ly:6: means centered on the stem.) On

Re: Issue 2535: Staccato on stem side alignment when other articulations are present (issue 196260043 by david.nales...@gmail.com)

Eek. Sorry for overquoting. https://codereview.appspot.com/196260043/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Issue 2535: Staccato on stem side alignment when other articulations are present (issue 196260043 by david.nales...@gmail.com)

On 2015/01/27 07:32:24, dak wrote: Aaaand another thought: wouldn't it make more sense instead of having independent shifts for with other articulations and without other articulations when the articulation closest to the notehead is responsible for aligning the whole stack of articulations?

Re: Issue 2535: Staccato on stem side alignment when other articulations are present (issue 196260043 by david.nales...@gmail.com)

On 2015/01/27 08:50:36, dak wrote: On 2015/01/27 07:52:05, lemzwerg wrote: On 2015/01/27 07:26:53, dak wrote: It seems to me like this number-pair consists of two settings that would almost always be adjusted independently. Wouldn't it make more sense to make a separate property

Re: Issue 2535: Staccato on stem side alignment when other articulations are present (issue 196260043 by david.nales...@gmail.com)

On 2015/01/27 22:00:49, lemzwerg wrote: https://codereview.appspot.com/196260043/diff/20001/input/regression/script-shift.ly File input/regression/script-shift.ly (right): https://codereview.appspot.com/196260043/diff/20001/input/regression/script-shift.ly#newcode6

Re: Issue 2535: Staccato on stem side alignment when other articulations are present (issue 196260043 by david.nales...@gmail.com)

https://codereview.appspot.com/196260043/diff/20001/input/regression/script-shift.ly File input/regression/script-shift.ly (right): https://codereview.appspot.com/196260043/diff/20001/input/regression/script-shift.ly#newcode6 input/regression/script-shift.ly:6: means centered on the stem.) On

Re: Issue 2535: Staccato on stem side alignment when other articulations are present (issue 196260043 by david.nales...@gmail.com)

On 2015/01/27 15:07:24, dak wrote: On 2015/01/27 14:37:27, david.nalesnik wrote: What would this property be named? snap-to-column? shift-in-column? I suggest picking a name that starts in the same way as the existing property. toward-stem-shift-in-column would be unambiguous. Long,

Issue 4238: Glissando overlaps dot (issue 194920043 by david.nales...@gmail.com)

Reviewers: , Message: Please review. Description: Issue 4238: Glissando overlaps dot Glissandi will now begin after augmentation dots by default. This behavior may be changed by overriding a new subproperty named 'start-at-dot, set by default to #t. Please review this at

Re: Add Scheme function to return column associated with Item. (issue 203910043 by david.nales...@gmail.com)

On Sun, Feb 15, 2015 at 7:58 AM, Urs Liska u...@openlilylib.org wrote: Can't judge the code but the idea looks great :-) Thanks--I'm noticing that bits of code get reused on the lists, so there's a need. This will help tuck away some of the code gobbledygook that is so off-putting.. It

Re: Add Scheme function to return column associated with Item. (issue 203910043 by david.nales...@gmail.com)

On Sun, Feb 15, 2015 at 12:34 PM, Thomas Morley thomasmorle...@gmail.com wrote: 2015-02-15 19:28 GMT+01:00 Thomas Morley thomasmorle...@gmail.com: Oops, definition for 'grob-name' is missing: #(define grob-name (lambda (x) (if (ly:grob? x) (assq-ref (ly:grob-property x

Make Grob::name accessible to Scheme (issue 203090043 by david.nales...@gmail.com)

Reviewers: , Message: Please review. Thanks! Description: Make Grob::name accessible to Scheme Needing to determine the name of a grob is extremely common to users of Scheme. Please review this at https://codereview.appspot.com/203090043/ Affected files (+11, -0 lines): M

Re: Add Scheme function to return column associated with Item. (issue 203910043 by david.nales...@gmail.com)

Hi Harm, On Sun, Feb 15, 2015 at 12:28 PM, Thomas Morley thomasmorle...@gmail.com wrote: Some time ago I wrote a more generic code: #(define (look-up-for-parent name-symbol axis grob) Return the parent of @var{grob}, specified by it's @var{name-symbol} in axis @var{axis}. If not

Re: Add Scheme function to return column associated with Item. (issue 203910043 by david.nales...@gmail.com)

On Sun, Feb 15, 2015 at 1:14 PM, David Nalesnik david.nales...@gmail.com wrote: Now, a function to get a grob's name would certainly be useful. I'm sick to death of constantly recreating it or looking it up (as I bet you are)! If there's a question of usefulness, I think we've established

Re: Add Scheme function to return column associated with Item. (issue 203910043 by david.nales...@gmail.com)

Harm, On Sun, Feb 15, 2015 at 2:42 PM, Thomas Morley thomasmorle...@gmail.com wrote: Can't review C++, so I'll not post there. There IS something you can help with, though. In the patch as it stands, I'm simply making Grob::name available through Scheme. It thus returns a string.

Re: git fetch returns fatal error

On Sat, Jan 3, 2015 at 4:13 PM, Thomas Morley thomasmorle...@gmail.com wrote: Hi, after some months without own computer I've a new one and lilydevel working. Good to hear it! -David ___ lilypond-devel mailing list lilypond-devel@gnu.org

Re: ly:line-interface::print should read ly:line-spanner::print in NR (issue 186650043 by thomasmorle...@gmail.com)

LGTM. https://codereview.appspot.com/186650043/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Update docstring in lily/note-head-line-engraver.cc (issue 194900043 by david.nales...@gmail.com)

Reviewers: , Message: Please review. Description: Update docstring in lily/note-head-line-engraver.cc As of commit 06dbc712c654888708b9feabbd0affe9ff2e4902 (May 27, 2003), this file is not involved in the creation of Glissando grobs. Please review this at

toward-stem-shift-in-column should only consider 'script-interface (issue 207620043 by david.nales...@gmail.com)

Reviewers: , Message: Please review. Thanks. Description: toward-stem-shift-in-column should only consider 'script-interface Previously, toward-stem-shift-in-column did not discriminate between different types of grobs in the 'scripts grob-array. This meant that TextScript, StringNumber, and

Re: toward-stem-shift-in-column should only consider 'script-interface (issue 207620043 by david.nales...@gmail.com)

https://codereview.appspot.com/207620043/diff/20001/scm/output-lib.scm File scm/output-lib.scm (right): https://codereview.appspot.com/207620043/diff/20001/scm/output-lib.scm#newcode1195 scm/output-lib.scm:1195: (and (not (eq? s grob)) I am recognizing Script grobs in the orthodox way--i.e.,

Re: toward-stem-shift-in-column should only consider 'script-interface (issue 207620043 by david.nales...@gmail.com)

https://codereview.appspot.com/207620043/diff/20001/scm/output-lib.scm File scm/output-lib.scm (right): https://codereview.appspot.com/207620043/diff/20001/scm/output-lib.scm#newcode1195 scm/output-lib.scm:1195: (and (not (eq? s grob)) On 2015/03/09 17:09:23, david.nalesnik wrote: I am

Re: toward-stem-shift-in-column should only consider 'script-interface (issue 207620043 by david.nales...@gmail.com)

Thanks for the review! https://codereview.appspot.com/207620043/diff/20001/scm/output-lib.scm File scm/output-lib.scm (right): https://codereview.appspot.com/207620043/diff/20001/scm/output-lib.scm#newcode1190 scm/output-lib.scm:1190: (shift (if (and (ly:grob? script-column) On 2015/03/11

Re: Add means to display objects accessible from a grob (issue 217260043 by david.nales...@gmail.com)

https://codereview.appspot.com/217260043/diff/1/scm/output-lib.scm File scm/output-lib.scm (right): https://codereview.appspot.com/217260043/diff/1/scm/output-lib.scm#newcode165 scm/output-lib.scm:165: (use-modules (ice-9 pretty-print)) On 2015/03/24 21:58:28, thomasmorley651 wrote: I always

Re: Add means to display objects accessible from a grob (issue 217260043 by david.nales...@gmail.com)

https://codereview.appspot.com/217260043/diff/1/scm/output-lib.scm File scm/output-lib.scm (right): https://codereview.appspot.com/217260043/diff/1/scm/output-lib.scm#newcode165 scm/output-lib.scm:165: (use-modules (ice-9 pretty-print)) On 2015/03/25 00:15:45, david.nalesnik wrote: On

Add means to display objects accessible from a grob (issue 217260043 by david.nales...@gmail.com)

Reviewers: , Message: Please review. Thanks! Description: Add means to display objects accessible from a grob A convenient means of displaying the grobs and grob-arrays pointed to by various internal properties of a given grob would be very helpful for debugging and development purposes. For

Re: Add means to display objects accessible from a grob (issue 217260043 by david.nales...@gmail.com)

https://codereview.appspot.com/217260043/diff/1/scm/output-lib.scm File scm/output-lib.scm (right): https://codereview.appspot.com/217260043/diff/1/scm/output-lib.scm#newcode165 scm/output-lib.scm:165: (use-modules (ice-9 pretty-print)) On 2015/03/24 21:58:28, thomasmorley651 wrote: I always

Re: Add means to display objects accessible from a grob (issue 217260043 by david.nales...@gmail.com)

On 2015/03/25 05:35:28, ul_openlilylib.org wrote: Well, it's not much code of course. Would it even be reloaded? Anyway, I wonder if redundant use-modules invocations should be removed, or at least reduced to comments. Scheme modules are loaded only once so thee is no overhead involved.

Re: Issue 3615: more consistency with key sig grobs (issue 219460043 by paulwmor...@gmail.com)

On 2015/03/30 16:36:20, david.nalesnik wrote: On 2015/03/29 20:33:33, pwm wrote: Please review, thanks. Could you provide an example where this would be useful? Thanks, David OK, drat. Ignore that!! See Issue 3615, of course :) https://codereview.appspot.com/219460043/

Re: Issue 3615: more consistency with key sig grobs (issue 219460043 by paulwmor...@gmail.com)

On 2015/03/29 20:33:33, pwm wrote: Please review, thanks. Could you provide an example where this would be useful? Thanks, David https://codereview.appspot.com/219460043/ ___ lilypond-devel mailing list lilypond-devel@gnu.org

Remove unused event-type general-music (issue 222090043 by david.nales...@gmail.com)

Reviewers: , Message: Please review. Thanks! Description: Remove unused event-type general-music Please review this at https://codereview.appspot.com/222090043/ Affected files (+105, -109 lines): M input/regression/scheme-text-spanner.ly M scm/define-music-types.scm

Re: Fix issue 4040: Dots ignoring shifted ledger lines (issue 220090043 by paulwmor...@gmail.com)

Aside from whitespace issue, LGTM. I assume this could be fixed when pushing, and there's no need to put this back on review? https://codereview.appspot.com/220090043/diff/1/input/regression/staff-ledger-positions-dotted-notes.ly File input/regression/staff-ledger-positions-dotted-notes.ly

Re: Language selection code

Hi Simon, On Thu, Mar 26, 2015 at 6:43 PM, Simon Albrecht simon.albre...@mail.de wrote: [...] So the roadmap would include – discussing design and coding (?) I haven't gone through this thoroughly, but I did notice that an invalid statement like this \language general.deutsch.foo isn't

Re: Language selection code

On Fri, Mar 27, 2015 at 8:38 AM, David Nalesnik david.nales...@gmail.com wrote: I haven't gone through this thoroughly, but I did notice that an invalid statement like this \language general.deutsch.foo isn't gracefully dealt with. [...] If correct-input is #f, language

make pretty-print available in ly files (issue 222810043 by david.nales...@gmail.com)

Reviewers: , Message: Please review. Thanks! Description: make pretty-print available in ly files Please review this at https://codereview.appspot.com/222810043/ Affected files (+1, -0 lines): M ly/init.ly Index: ly/init.ly diff --git a/ly/init.ly b/ly/init.ly index

Re: Remove unused event-type general-music (issue 222090043 by david.nales...@gmail.com)

https://codereview.appspot.com/222090043/diff/1/scm/define-music-types.scm File scm/define-music-types.scm (right): https://codereview.appspot.com/222090043/diff/1/scm/define-music-types.scm#newcode343 scm/define-music-types.scm:343: (types . ()) Should Music be given a type? According to

Re: [PATCH] support for flagged crotchets in mensural notation

On Sat, Feb 28, 2015 at 10:14 AM, Lukas Pietsch lukas.piet...@freenet.de wrote: Werner LEMBERG wl at gnu.org writes: hollow=1 would then be the default for modern notation. minHollowDurationLog would be more descriptive. What an ugly name, but I agree that it is more descriptive

Re: [PATCH] Add scheme engraver for StaffTab notation

Hi Ricardo, On Sun, Mar 1, 2015 at 8:31 AM, Ricardo Wurmus rek...@elephly.net wrote: I already implemented the following changes: - added context definitions for \midi in addition to \layout - restricted maximum line length to 80 chars Attached is a new patch. This patch fails to apply

Re: [PATCH] Add scheme engraver for StaffTab notation

On Sun, Mar 1, 2015 at 10:32 AM, David Nalesnik david.nales...@gmail.com wrote: Hi Ricardo, On Sun, Mar 1, 2015 at 8:31 AM, Ricardo Wurmus rek...@elephly.net wrote: I already implemented the following changes: - added context definitions for \midi in addition to \layout - restricted

Re: Function to display the rhythmic location of a grob (issue 197690044 by david.nales...@gmail.com)

https://codereview.appspot.com/197690044/diff/20001/scm/output-lib.scm File scm/output-lib.scm (right): https://codereview.appspot.com/197690044/diff/20001/scm/output-lib.scm#newcode29 scm/output-lib.scm:29: (define-public (grob::rhythmic-location grob) On 2015/02/22 07:59:40, dak wrote: The

Re: [PATCH] Add scheme engraver for StaffTab notation

Hi Ricardo, On Mon, Feb 23, 2015 at 4:42 PM, Ricardo Wurmus rek...@elephly.net wrote: Here's the patch: When I apply your patch and try to compile the example file I get: warning: cannot find or create new `StaffTab' warning: cannot find or create new `StaffTab' warning: cannot find or

Re: [PATCH] Add scheme engraver for StaffTab notation

On Mon, Feb 23, 2015 at 5:15 PM, David Nalesnik david.nales...@gmail.com wrote: Hi Ricardo, On Mon, Feb 23, 2015 at 4:42 PM, Ricardo Wurmus rek...@elephly.net wrote: Here's the patch: When I apply your patch and try to compile the example file I get: warning: cannot find or create new

Re: [PATCH] Add scheme engraver for StaffTab notation

On Mon, Feb 23, 2015 at 5:24 PM, David Nalesnik david.nales...@gmail.com wrote: On Mon, Feb 23, 2015 at 5:15 PM, David Nalesnik david.nales...@gmail.com wrote: Hi Ricardo, On Mon, Feb 23, 2015 at 4:42 PM, Ricardo Wurmus rek...@elephly.net wrote: Here's the patch: When I apply your

Re: make pretty-print available in ly files (issue 222810043 by david.nales...@gmail.com)

https://codereview.appspot.com/222810043/diff/1/ly/init.ly File ly/init.ly (right): https://codereview.appspot.com/222810043/diff/1/ly/init.ly#newcode38 ly/init.ly:38: #(use-modules (ice-9 pretty-print)) On 2015/04/07 16:13:44, dak wrote: Uh, where is the point? Why wouldn't a user include a

Re: PATCHES: Countdown for April 6th 2015

On Sat, Apr 4, 2015 at 3:42 AM, Trevor Daniels t.dani...@treda.co.uk wrote: James Lowe wrote Saturday, April 04, 2015 9:27 AM On 04/04/15 08:49, David Kastrup wrote: If we freeze patches only on countdown state and nothing else I hope not to curb the holiday rush of activity too much.

Re: Remove unused event-type general-music (issue 222090043 by david.nales...@gmail.com)

https://codereview.appspot.com/222090043/diff/1/scm/define-music-types.scm File scm/define-music-types.scm (right): https://codereview.appspot.com/222090043/diff/1/scm/define-music-types.scm#newcode343 scm/define-music-types.scm:343: (types . ()) On 2015/04/04 15:25:27, Trevor Daniels wrote:

Re: Remove unused event-type general-music (issue 222090043 by david.nales...@gmail.com)

https://codereview.appspot.com/222090043/diff/1/scm/define-music-types.scm File scm/define-music-types.scm (right): https://codereview.appspot.com/222090043/diff/1/scm/define-music-types.scm#newcode343 scm/define-music-types.scm:343: (types . ()) On 2015/04/04 16:17:20, david.nalesnik wrote:

Re: make pretty-print available in ly files (issue 222810043 by david.nales...@gmail.com)

On 2015/04/08 11:14:54, dak wrote: On 2015/04/08 10:43:09, thomasmorley651 wrote: On 2015/04/08 10:21:55, dak wrote: value-lily-string is probably the most useful reasonably generic printing facility right now. But nobody really knows it. At least, I wasn't aware of it, because of (in

Re: make pretty-print available in ly files (issue 222810043 by david.nales...@gmail.com)

On 2015/04/08 16:06:47, david.nalesnik wrote: On 2015/04/08 11:14:54, dak wrote: commit 8d8e8aec6388fbb08ed2219884b82ecf53a9dbcd Author: David Kastrup mailto:d...@gnu.org Date: Wed Jan 1 20:54:15 2014 +0100 Provide value-lily-string function because I really needed that facility

Re: Remove unused event-type general-music (issue 222090043 by david.nales...@gmail.com)

On 2015/04/04 20:20:33, dak wrote: On 2015/04/04 16:17:20, david.nalesnik wrote: Music is used. For example, looking at what sort of object must be produced by \shape: #(display (car (ly:music-function-signature shape))) == (#primitive-procedure ly:music? . #Prob: Music C++:

Re: interactive sheet music experiment

Hi Urs, On Wed, Jul 1, 2015 at 2:24 AM, Urs Liska u...@openlilylib.org wrote: What I see after choosing a song is that seemingly arbitrary letters in a Courier-like font are placed above the noteheads. If these letters should be the note names then it seems to be not working properly. If

Re: Shared Rests

Dan, Am 22. August 2015 05:19:43 MESZ, schrieb Dan Eble d...@faithful.be: Can anyone offer general architectural advice for adding the option for parts on the same staff to share rests when possible? I mean without using \partcombine. I’d like to focus on multi-measure rests first.

Re: Issue 4516: Make \offset handle unpure/pure containers (issue 250590043 by d...@gnu.org)

Yet compare the output of { \offset Y-offset #-5 DynamicLineSpanner \repeat unfold 200 { c'2\f\ c'2\! } } with { \override DynamicLineSpanner.Y-offset = #-15 \repeat unfold 200 { c'2\f\ c'2\! } } Shouldn't the offset to the result of calling the pure function result in

Issue 4516: Make \offset handle unpure/pure containers (issue 250590043 by d...@gnu.org)

Thanks for doing this. The restructuring is a big improvement. https://codereview.appspot.com/250590043/diff/1/scm/music-functions.scm File scm/music-functions.scm (right): https://codereview.appspot.com/250590043/diff/1/scm/music-functions.scm#newcode2331 scm/music-functions.scm:2331:

Re: Issue 4516: Make \offset handle unpure/pure containers (issue 250590043 by d...@gnu.org)

Here's two snippets that show \offset working with unpure-pure containers, one with the override form, the second using the tweak form. { c'4\f\ c'4\! \offset Y-offset -2 DynamicLineSpanner c'4\f\ c'4\! c'2 \offset length 2 Stem c'2 } { c'4\f\ c'4\! c'4\f-\offset

Re: Issue 4516: Make \offset handle unpure/pure containers (issue 250590043 by d...@gnu.org)

LGTM. Thanks again! https://codereview.appspot.com/250590043/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: multiple TextSpanners per voice

On Tue, Oct 20, 2015 at 11:50 AM, David Kastrup wrote: > Trevor Bača writes: > > > Hi, > > > > I'd like to add that I'm *incredibly* excited by this work. The ability > to > > have multiple text spanners in a voice -- and to tweak each independently > > -- is

Rietveld diff annoyance

Hi all, I just posted a patch on Rietveld, It adds a new file, which I partially constructed by cutting and pasting from lily/pointer-group-interface-scheme.cc into Leafpad (just the initial comment). Unfortunately, Rietveld now shows the diff with that file, though the patch doesn't touch it.

Re: Rietveld diff annoyance

On Wed, Aug 26, 2015 at 12:18 PM, David Nalesnik david.nales...@gmail.com wrote: Hi all, I just posted a patch on Rietveld, It adds a new file, which I partially constructed by cutting and pasting from lily/pointer-group-interface-scheme.cc into Leafpad (just the initial comment

Re: Fix regtest "dynamics-broken-hairpin.ly" (issue 258470044 by simon.albre...@mail.de)

https://codereview.appspot.com/258470044/diff/1/input/regression/dynamics-broken-hairpin.ly File input/regression/dynamics-broken-hairpin.ly (right): https://codereview.appspot.com/258470044/diff/1/input/regression/dynamics-broken-hairpin.ly#newcode1

Re: Doc: Usage - Updated 'Running LilyPond' intros (issue 261240043 by pkx1...@gmail.com)

https://codereview.appspot.com/261240043/diff/1/Documentation/usage/running.itely File Documentation/usage/running.itely (right): https://codereview.appspot.com/261240043/diff/1/Documentation/usage/running.itely#newcode36 Documentation/usage/running.itely:36: information on where to download or

Re: multiple TextSpanners per voice

On Fri, Oct 2, 2015 at 5:59 PM, David Nalesnik <david.nales...@gmail.com> wrote: > > > On Fri, Oct 2, 2015 at 5:49 PM, David Nalesnik <david.nales...@gmail.com> > wrote: > >> >> Horizontal_bracket_engraver achieves correct ordering of nested brackets >&

Re: multiple TextSpanners per voice

On Sat, Oct 3, 2015 at 12:02 PM, David Nalesnik <david.nales...@gmail.com> wrote: > > > So here is a revised version of the TextSpanner code. > > Oh *drat* Attached the wrong file. Apologies... DN \version "2.19" %% Based on the rewrite of Text_spanner_engrave

Re: multiple TextSpanners per voice

On Fri, Oct 2, 2015 at 10:00 AM, David Nalesnik <david.nales...@gmail.com> wrote: > Hi all, > > I'm experimenting with a way to support multiple text spanners in a single > voice, using the 'spanner-id property which already enables multiple slurs > and phrasing slurs. > &

multiple TextSpanners per voice

Hi all, I'm experimenting with a way to support multiple text spanners in a single voice, using the 'spanner-id property which already enables multiple slurs and phrasing slurs. The attached code works--until the spanners cross a line break. Then the order of the spanners is reversed. I've

Re: multiple TextSpanners per voice

David, On Fri, Oct 2, 2015 at 11:26 AM, David Kastrup <d...@gnu.org> wrote: > David Nalesnik <david.nales...@gmail.com> writes: > > > Hi all, > > > > I'm experimenting with a way to support multiple text spanners in a > single > > voice, using t

Re: multiple TextSpanners per voice

Michael, On Fri, Oct 2, 2015 at 11:33 AM, Michael Gerdau wrote: > > > The second example shows that tweaks can mess up this reversed ordering > > > even further. > > > > > > Does anyone know what is happening here? I really have no idea :( > > > > Here's an image. > > > > (I'm

Re: multiple TextSpanners per voice

On Fri, Oct 2, 2015 at 12:09 PM, David Nalesnik <david.nales...@gmail.com> wrote: > David, > > On Fri, Oct 2, 2015 at 11:26 AM, David Kastrup <d...@gnu.org> wrote: > >> David Nalesnik <david.nales...@gmail.com> writes: >> >> > Hi all, >>

Re: multiple TextSpanners per voice

On Fri, Oct 2, 2015 at 5:49 PM, David Nalesnik <david.nales...@gmail.com> wrote: > > Horizontal_bracket_engraver achieves correct ordering of nested brackets > through the side-position-interface array 'side-position-elements. > Brackets closer to the staff are added to the s

Re: multiple TextSpanners per voice

Ok, this should do it. The intention is to provide extra functionality to text spanners. By using this code, you have all the functionality of normal text spanners, but you are able to have multiple spanners per voice. You simply need to swap the regular engraver for this one in a layout block,

Re: ly:moment<=? ??

On Sun, Dec 20, 2015 at 7:08 PM, Simon Albrecht wrote: > Hello, > > while getting to terms with the accidentalStyle code I found that it would > be useful (currently only for dodecaphonic-no-repeat-rule, > scm/music-functions.scm:line 1682f.) to have a ly:moment<=? Scheme

Re: make pretty-print available in ly files (issue 222810043 by david.nales...@gmail.com)

On 2016/01/23 22:11:03, david.nalesnik wrote: The patch was pushed after much of the discussion above. Shall I make another patch removing the functionality> Ugh--I mean pushed *before* much of the discussion. https://codereview.appspot.com/222810043/

Re: make pretty-print available in ly files (issue 222810043 by david.nales...@gmail.com)

The patch was pushed after much of the discussion above. Shall I make another patch removing the functionality> https://codereview.appspot.com/222810043/ ___ lilypond-devel mailing list lilypond-devel@gnu.org

Re: scriptDefinitions context property

On Tue, May 24, 2016 at 7:12 PM, Carl Sorensen wrote: > According to the Internals Reference, scriptDefinitions is an internal > context property, meaning that the user should not change it. > > Why is this so? As far as I can see, scriptDefinitions is not defined > during

trouble uploading a patch

Hi, I'm trying to upload a patch for review, and I'm running into difficulties. Using git-cl, I get this output: Issue created. URL: http://codereview.appspot.com/320140043 Uploading base file for Documentation/changes.tely Uploading base file for scm/define-grob-properties.scm Uploading base

Re: trouble uploading a patch

On Fri, Feb 3, 2017 at 7:27 PM, David Nalesnik <david.nales...@gmail.com> wrote: > Hi, > > I'm trying to upload a patch for review, and I'm running into difficulties. > > Using git-cl, I get this output: > > Issue created. URL: http://codereview.appspot.com/3201

Re: trouble uploading a patch

On Sat, Feb 4, 2017 at 6:28 PM, David Kastrup <d...@gnu.org> wrote: > David Nalesnik <david.nales...@gmail.com> writes: > >> On Fri, Feb 3, 2017 at 7:35 PM, David Nalesnik <david.nales...@gmail.com> >> wrote: >>> On Fri, Feb 3, 2017 at 7:27 PM, David

Re: trouble uploading a patch

On Sat, Feb 4, 2017 at 7:02 PM, David Nalesnik <david.nales...@gmail.com> wrote: > On Sat, Feb 4, 2017 at 6:45 PM, David Kastrup <d...@gnu.org> wrote: >> David Nalesnik <david.nales...@gmail.com> writes: >> >>> On Sat, Feb 4, 2017 at 6:28 PM, David Kastrup

Re: trouble uploading a patch

On Fri, Feb 3, 2017 at 7:35 PM, David Nalesnik <david.nales...@gmail.com> wrote: > On Fri, Feb 3, 2017 at 7:27 PM, David Nalesnik <david.nales...@gmail.com> > wrote: >> Hi, >> >> I'm trying to upload a patch for review, and I'm running into difficulties. &

Re: trouble uploading a patch

Hi Harm, On Tue, Feb 7, 2017 at 7:46 PM, Thomas Morley <thomasmorle...@gmail.com> wrote: > 2017-02-08 0:08 GMT+00:00 David Nalesnik <david.nales...@gmail.com>: >> Harm, >> >> On Tue, Feb 7, 2017 at 5:57 PM, Thomas Morley <thomasmorle...@gmail.com> >&g

<    1   2   3   4   5   >