in, then it will
be able to happen any time a new user enters the mount. The code
needs to be written with that in mind.
Let me know if you have other questions...
Cheers,
--
Jeff Layton jlay...@samba.org
--
To unsubscribe from this list: send the line unsubscribe linux-cifs in
the body of a message
On Fri, 25 Jun 2010 22:46:38 +0100
David Howells dhowe...@redhat.com wrote:
Jeff Layton jlay...@samba.org wrote:
Looks like it mostly uses the ctime. IMO, the mtime would be a better
choice since it changes less frequently, but I don't guess that it
matters very much.
I'd've thought
On Mon, 28 Jun 2010 18:56:09 +0530
Suresh Jayaraman sjayara...@suse.de wrote:
On 06/28/2010 04:40 PM, Jeff Layton wrote:
Reduce false inode collisions by using the CreationTime like an
i_generation field. This way, even if the server ends up reusing
a uniqueid after a delete/create cycle
On Tue, 13 Jul 2010 08:21:51 -0400
Jeff Layton jlay...@samba.org wrote:
On Tue, 13 Jul 2010 12:48:10 +0200
Ladislav Michl ladislav.mi...@seznam.cz wrote:
Hello,
I'm using network storage for voicemail recording, which works pretty well
on responsive servers. However in case of server
sort of keepalive. A normal TCP keepalive
might be ok, or we could consider doing SMB pings for this. That
should make sure that we notice state changes in a timely fashion and
should also help prevent disconnection on low-traffic sockets.
Thoughts?
--
Jeff Layton jlay...@samba.org
On Thu, 15 Jul 2010 17:19:36 -0400
Jeff Layton jlay...@redhat.com wrote:
On Thu, 15 Jul 2010 15:24:46 -0500
Steve French smfre...@gmail.com wrote:
I merged the first 5 of this series, but wanted to understand what
behavior this changes first (it is probably ok). With current
userspace
;
+ break;
+ }
+
for (i = 0; (i num_to_fill) (rc == 0); i++) {
if (current_entry == NULL) {
/* evaluate whether this case is an error */
Looks good to me too.
Acked-by: Jeff Layton jlay...@redhat.com
On Fri, 23 Jul 2010 20:56:05 +0530
Suresh Jayaraman sjayara...@suse.de wrote:
On 07/23/2010 07:22 PM, Jeff Layton wrote:
I built a kernel based on Steve's tree, enabled the fscache option and
got the following panic at umount. I didn't mount with -o fsc or
anything. I have some other
you in a week or so on this. Any more progress on
merging these patches?
--
Jeff Layton jlay...@redhat.com
--
To unsubscribe from this list: send the line unsubscribe linux-cifs in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
On Sun, 18 Jul 2010 07:18:19 -0400
Jeff Layton jlay...@redhat.com wrote:
On Thu, 15 Jul 2010 17:19:36 -0400
Jeff Layton jlay...@redhat.com wrote:
On Thu, 15 Jul 2010 15:24:46 -0500
Steve French smfre...@gmail.com wrote:
I merged the first 5 of this series, but wanted to understand
These are all handled by the userspace mount programs, but older versions
of mount.cifs also handed them off to the kernel. Ignore them.
Signed-off-by: Jeff Layton jlay...@redhat.com
---
fs/cifs/connect.c |6 ++
1 files changed, 6 insertions(+), 0 deletions(-)
diff --git a/fs/cifs
-by: Jeff Layton jlay...@samba.org
---
mount.cifs.c |5 +
1 files changed, 5 insertions(+), 0 deletions(-)
diff --git a/mount.cifs.c b/mount.cifs.c
index 1ca9507..89b728c 100644
--- a/mount.cifs.c
+++ b/mount.cifs.c
@@ -133,6 +133,7 @@
* Values for parsing command line options.
*/
#define
Even though all known kernels send the uid= parm to userspace,
cifs.upcall doesn't technically require it. It should though. If one
wasn't sent for some reason, then the setuid wouldn't occur. Error out
if there is no uid= or creduid= parm.
Signed-off-by: Jeff Layton jlay...@samba.org
These are filesystem-independent mount options that get passed to
mount.cifs too. Handle them appropriately by enabling and disabling
MS_MANDLOCK and not handing them off to the kernel.
Signed-off-by: Jeff Layton jlay...@samba.org
---
mount.cifs.c | 12
1 files changed, 12
I'm not sure why this was merged with this flag hardcoded on, but it
seems quite dangerous. Turn it off.
Also, mount.cifs hands unrecognized options off to the kernel so there
should be no need for changes there in order to support this.
Signed-off-by: Jeff Layton jlay...@redhat.com
---
fs/cifs
by default. This also matches
up better with the way that mand is set in the mtab.
Signed-off-by: Jeff Layton jlay...@samba.org
---
mount.cifs.c | 14 --
1 files changed, 12 insertions(+), 2 deletions(-)
diff --git a/mount.cifs.c b/mount.cifs.c
index 27d267c..5a05caa 100644
for
the mount. Note that this parameter must be specified before the -o. For
example:/paraparamount -t cifs //server/share /mnt --verbose -o
user=username/para/listitem
--
Jeff Layton jlay...@redhat.com
--
To unsubscribe from this list: send the line unsubscribe linux-cifs in
the body
On Tue, 27 Jul 2010 10:13:14 -0500
Steve French smfre...@gmail.com wrote:
Yes - I agree with Jeff, need to add the mention of the config option
and perhaps how to tell if fsc feature is available in kernel.
How would one tell? :)
On Tue, Jul 27, 2010 at 9:33 AM, Jeff Layton jlay
a /proc/fs/cifs/features file that would display this
info? For instance:
$ cat /proc/fs/cifs/features
dfs spnego fsc
...or something like that?
--
Jeff Layton jlay...@redhat.com
--
To unsubscribe from this list: send the line unsubscribe linux-cifs in
the body of a message to majord
-cifs in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
merged
--
Jeff Layton jlay...@redhat.com
--
To unsubscribe from this list: send the line unsubscribe linux-cifs in
the body of a message to majord...@vger.kernel.org
More
On Mon, 26 Jul 2010 13:05:28 -0400
Jeff Layton jlay...@samba.org wrote:
Even though all known kernels send the uid= parm to userspace,
cifs.upcall doesn't technically require it. It should though. If one
wasn't sent for some reason, then the setuid wouldn't occur. Error out
if there is no uid
at http://vger.kernel.org/majordomo-info.html
merged
--
Jeff Layton jlay...@redhat.com
--
To unsubscribe from this list: send the line unsubscribe linux-cifs in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
On Mon, 26 Jul 2010 13:05:29 -0400
Jeff Layton jlay...@samba.org wrote:
These are filesystem-independent mount options that get passed to
mount.cifs too. Handle them appropriately by enabling and disabling
MS_MANDLOCK and not handing them off to the kernel.
Signed-off-by: Jeff Layton jlay
the original patch, so I've merged this one as a
delta on top of that.
Thanks,
--
Jeff Layton jlay...@redhat.com
--
To unsubscribe from this list: send the line unsubscribe linux-cifs in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo
This patchset adds the -Wextra flag to CFLAGS and fixes up some of the
warnings that that generates. There are still some others that I'm
not sure how best to fix yet.
Jeff Layton (4):
automake: add -Wextra to CFLAGS
mtab: add __attribute__((unused)) to unused variables
cifs.upcall: swap
...for extra warning goodness.
Signed-off-by: Jeff Layton jlay...@samba.org
---
Makefile.am |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/Makefile.am b/Makefile.am
index 1cf7d23..c53c9ec 100644
--- a/Makefile.am
+++ b/Makefile.am
@@ -1,4 +1,4 @@
-AM_CFLAGS = -Wall
...to silence -Wextra warnings.
Signed-off-by: Jeff Layton jlay...@samba.org
---
mtab.c |4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/mtab.c b/mtab.c
index 70789bc..de1aabd 100644
--- a/mtab.c
+++ b/mtab.c
@@ -51,12 +51,12 @@ static int lockfile_fd = -1;
static int
integer
expressions
Signed-off-by: Jeff Layton jlay...@samba.org
---
data_blob.c |4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/data_blob.c b/data_blob.c
index 2384661..16c78ce 100644
--- a/data_blob.c
+++ b/data_blob.c
@@ -141,7 +141,7 @@ print the data_blob as hex string
: (near initialization for ‘arg.ver’)
...this is probably just gcc being balky, but we can silence the
warning. It may also be a micro optimization in an error condition
if we delay zeroing out the struct until it's needed.
Signed-off-by: Jeff Layton jlay...@samba.org
---
cifs.upcall.c |8
are the uid and the gid not set to this value?
The real uid/gid of the user doing the mounting is 0. You can of
course override those values with whatever you wish if you're root.
--
Jeff Layton jlay...@samba.org
--
To unsubscribe from this list: send the line unsubscribe linux-cifs in
the body
line near the beginning
of /proc/fs/cifs/DebugData. Maybe:
Features: dfs spnego fsc
People often provide that info already when reporting bugs. We wouldn't
need to ask for anything new that way.
Thoughts?
--
Jeff Layton jlay...@redhat.com
--
To unsubscribe from this list: send the line unsubscribe
a definitive way to tell what features are currently
enabled in the running kernel. This could also help debugging.
Signed-off-by: Suresh Jayaraman sjayara...@suse.de
Cc: Jeff Layton jlay...@redhat.com
---
fs/cifs/cifs_debug.c | 26 ++
1 files changed, 26 insertions
over, I sent mail to marc.info too but they
never replied or picked up the list. I just resent them a mail, so
hopefully they'll fix their archive soon.
--
Jeff Layton jlay...@samba.org
--
To unsubscribe from this list: send the line unsubscribe linux-cifs in
the body of a message to majord
need to have the same data
accessible by multiple users using their own credentials then you need
multiple mounts.
--
Jeff Layton jlay...@redhat.com
--
To unsubscribe from this list: send the line unsubscribe linux-cifs in
the body of a message to majord...@vger.kernel.org
More majordomo info
to that as well.
Ditto for the other fields under discussion (i_generation and the like).
--
Jeff Layton jlay...@redhat.com
--
To unsubscribe from this list: send the line unsubscribe linux-cifs in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo
here?
We also have to consider that this may eventually be settable by via
networked filesystem interfaces. If the client and server don't have
synchronized clocks you may end up with the client getting an error
back in some cases if you don't allow it.
--
Jeff Layton jlay...@redhat.com
.
--
Jeff Layton jlay...@samba.org
--
To unsubscribe from this list: send the line unsubscribe linux-cifs in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
On Fri, 23 Jul 2010 17:19:29 -0500
Steve French smfre...@gmail.com wrote:
On Thu, Jul 1, 2010 at 6:52 PM, Jeff Layton jlay...@redhat.com wrote:
On Thu, 1 Jul 2010 16:55:58 -0500
Steve French smfre...@gmail.com wrote:
For cifs: use CreationTime like an i_generation field
Seems like
. What's going wrong with it? Once you
understand that, then we can look at what's happening in the kernel.
--
Jeff Layton jlay...@samba.org
--
To unsubscribe from this list: send the line unsubscribe linux-cifs in
the body of a message to majord...@vger.kernel.org
More majordomo info at http
on
key\n);
...would it be safer to attempt to remove the key if we can't set perms
on it?
That's all I've got time to review at the moment. Have you made any
progress with the kernel piece for this?
Nice work so far!
--
Jeff Layton jlay...@samba.org
--
To unsubscribe from this list: send
link container.
Signed-off-by: Jeff Layton jlay...@redhat.com
---
fs/cifs/dir.c | 14 +++---
fs/cifs/file.c |3 +--
2 files changed, 8 insertions(+), 9 deletions(-)
diff --git a/fs/cifs/dir.c b/fs/cifs/dir.c
index f8d02f0..90d1f53 100644
--- a/fs/cifs/dir.c
+++ b/fs/cifs/dir.c
:
http://git.kernel.org/?p=linux/kernel/git/jlayton/linux.git;a=shortlog;h=refs/heads/cifs-2.6.36
Jeff Layton (3):
cifs: clean up error handling in cifs_mknod
cifs: consolidate error handling in several functions
cifs: eliminate redundant xdev check in cifs_rename
fs/cifs/dir.c | 167
The VFS always checks that the source and target of a rename are on the
same vfsmount, and hence have the same superblock. So, this check is
redundant. Remove it and simplify the error handling.
Signed-off-by: Jeff Layton jlay...@redhat.com
---
fs/cifs/inode.c | 30
Get rid of some nesting and add a label we can goto on error.
Signed-off-by: Jeff Layton jlay...@redhat.com
---
fs/cifs/dir.c | 153 -
1 files changed, 76 insertions(+), 77 deletions(-)
diff --git a/fs/cifs/dir.c b/fs/cifs/dir.c
index
on a single character.
That memcmp is going to walk off the end of add. Depending on how the
memory is allocated, it could segfault.
Patched.
I pulled down your latest code and it doesn't appear to be patched. Am
I missing something?
--
Jeff Layton jlay...@samba.org
--
To unsubscribe from
understanding what's
happening on the wire.
--
Jeff Layton jlay...@redhat.com
--
To unsubscribe from this list: send the line unsubscribe linux-cifs in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
cifs_find_smb_ses assumes that the vol-password field is a valid
pointer, but that's only the case if a password was passed in via
the options string. It's possible that one won't be if there is
no mount helper on the box.
Reported-by: diabel gacek-2...@wp.pl
Signed-off-by: Jeff Layton jlay
On Fri, 20 Aug 2010 00:27:12 +0400
Igor Druzhinin jaxbr...@gmail.com wrote:
This patch corrects a problem of compilation errors at removal of
UNIUPR_NOLOWER definition and adds include guards to cifs_unicode.h.
Signed-off-by: Igor Druzhinin jaxbr...@gmail.com
Acked-by: Jeff Layton jlay
CIFS VFS (virtual filesystem)
client
+ * Copyright (C) 2010 Jeff Layton (jlay...@samba.org)
+ * Copyright (C) 2010 Igor Druzhinin (jaxbr...@gmail.com)
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License
start considering building it by
default (i.e. make the default enable instead of disable).
We also need to have a hard look at how to sync this work up with
the multiuser mount work. That's not something we need to worry about
until the multiuser mount code for krb5 goes in.
Cheers,
--
Jeff Layton
if there are no
objections. There will be merge conflicts between this and Metze's
mfsymlink work. We'll just need to determine which one goes in first to
know who needs to rebase to what.
Jeff Layton (15):
cifs: eliminate redundant xdev check in cifs_rename
cifs: add tcon field to cifsFileInfo
When we implement multiuser mounts, we'll need to filter filehandles
by fsuid. Add a flag for multiuser mounts and code to filter by
fsuid when it's set.
Signed-off-by: Jeff Layton jlay...@redhat.com
---
fs/cifs/cifs_fs_sb.h |3 ++-
fs/cifs/cifsacl.c|4 ++--
fs/cifs/cifsproto.h
Eventually, we'll have more than one tcon per superblock. At that point,
we'll need to know which one is associated with a particular fid. For
now, this is just set from the cifs_sb-tcon pointer, but eventually
the caller of cifs_new_fileinfo will pass a tcon pointer in.
Signed-off-by: Jeff
cifsFileInfo needs a pointer to a tcon, but it doesn't currently hold a
reference to it. Change it to keep a pointer to a tcon_link instead and
hold a reference to it.
That will keep the tcon from being freed until the file is closed.
Signed-off-by: Jeff Layton jlay...@redhat.com
---
fs/cifs
and go ahead and
switch the appropriate places to use it.
Signed-off-by: Jeff Layton jlay...@redhat.com
---
fs/cifs/cifsfs.c |6 +++---
fs/cifs/cifsglob.h |7 +++
fs/cifs/connect.c |4 ++--
fs/cifs/dir.c | 10 +-
fs/cifs/fscache.c | 12 ++--
fs/cifs
anyway, so maybe a NULL
open_file here ought to be a BUG()?
Signed-off-by: Jeff Layton jlay...@redhat.com
---
fs/cifs/file.c | 82 +++
1 files changed, 40 insertions(+), 42 deletions(-)
diff --git a/fs/cifs/file.c b/fs/cifs/file.c
index
Signed-off-by: Jeff Layton jlay...@redhat.com
---
fs/cifs/cifs_fs_sb.h |2 +-
fs/cifs/cifsglob.h |2 +-
fs/cifs/connect.c|4 ++--
3 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/fs/cifs/cifs_fs_sb.h b/fs/cifs/cifs_fs_sb.h
index 9e77145..6302a06 100644
--- a/fs
to allow per-user credential stashing in some
form.
Signed-off-by: Jeff Layton jlay...@redhat.com
---
fs/cifs/connect.c | 13 +
1 files changed, 13 insertions(+), 0 deletions(-)
diff --git a/fs/cifs/connect.c b/fs/cifs/connect.c
index da861c1..3ea93f9 100644
--- a/fs/cifs/connect.c
):
CLOCK_MONOTONIC
Clock that cannot be set and represents monotonic time since
some unspecified starting point.
...so by preferring CLOCK_MONOTONIC, the mtab locking code isn't
affected by clock jumps or skew. Bjorn, is this correct?
--
Jeff Layton jlay...@samba.org
On Tue, 24 Aug 2010 14:22:48 -0400
Jeff Layton jlay...@samba.org wrote:
On Tue, 24 Aug 2010 13:07:55 -0500
Steve French smfre...@gmail.com wrote:
Any pointers to background on gettimeofday vs
clock_gettime(CLOCK_MONOTONIC) and why the latter is better?
IIUC, the reason
On Tue, 24 Aug 2010 22:08:09 +0200
Björn JACKE b...@sernet.de wrote:
On 2010-08-24 at 14:34 -0400 Jeff Layton sent off:
Any pointers to background on gettimeofday vs
clock_gettime(CLOCK_MONOTONIC) and why the latter is better?
IIUC, the reason for this is that gettimeofday
On Wed, 25 Aug 2010 11:34:07 -0500
Steve French smfre...@gmail.com wrote:
On Fri, Aug 20, 2010 at 2:31 PM, Jeff Layton jlay...@redhat.com wrote:
The VFS always checks that the source and target of a rename are on the
same vfsmount, and hence have the same superblock. So, this check
allocation error when the inode is NULL
which is not the case if CIFSSMBQPathInfo() fails and returns an error.
Fix this by propagating the actual error code back.
Cc: Jeff Layton jlay...@redhat.com
Signed-off-by: Suresh Jayaraman sjayara...@suse.de
---
fs/cifs/inode.c |2 +-
1 files
to be modified to make sure
that the address families between the two match. What happens if
someone specifies and IPv4 bindaddr, and the host in the UNC resolves
to an IPv6 address?
--
Jeff Layton jlay...@samba.org
--
To unsubscribe from this list: send the line unsubscribe linux-cifs in
the body
:54 AM, Jeff Layton wrote:
Also, I think bindaddr might not be the best name for the option. How
about sourceaddr or srcaddr?
Sounds reasonable.
It doesn't matter to me. Please tell me which one you want me to use
and I'll work on re-spinning this patch with ipv6 support
, there's no reason to keep comparing it.
Cc: Shirish Pargaonkar shirishpargaon...@gmail.com
Signed-off-by: Jeff Layton jlay...@redhat.com
---
fs/cifs/asn1.c |6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/fs/cifs/asn1.c b/fs/cifs/asn1.c
index 21f0fbd..cfd1ce3 100644
[8112d4d1] deactivate_super+0x3a/0x3e
[81142050] mntput_no_expire+0xa7/0xd3
[81142b91] sys_umount+0x2cf/0x301
[81133787] ? path_put+0x22/0x27
[81009cb2] system_call_fastpath+0x16/0x1b
--
Jeff Layton jlay...@samba.org
--
To unsubscribe from this list: send the line
On Tue, 31 Aug 2010 09:44:39 -0700
Ben Greear gree...@candelatech.com wrote:
On 08/31/2010 07:06 AM, Jeff Layton wrote:
On Mon, 30 Aug 2010 22:40:22 -0700
Ben Greeargree...@candelatech.com wrote:
When using multi-homed machines, it's nice to be able to specify
the local IP to use
the password
in /etc/mtab though.
--
Jeff Layton jlay...@redhat.com
--
To unsubscribe from this list: send the line unsubscribe linux-cifs in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
fail the
ipv[4,6]_connect if the socket can't be bound?
/* user overrode default port */
if (server-addr.sockAddr6.sin6_port) {
rc = socket-ops-connect(socket,
--
Jeff Layton jlay...@samba.org
--
To unsubscribe from this list: send the line unsubscribe linux-cifs
This reverts commit 8ef1b8351d2dce758f24c8e0321f62cc36d90818.
---
fs/cifs/Kconfig |1 -
1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/fs/cifs/Kconfig b/fs/cifs/Kconfig
index 0ed2139..0da1deb 100644
--- a/fs/cifs/Kconfig
+++ b/fs/cifs/Kconfig
@@ -2,7 +2,6 @@ config CIFS
This reverts commit 3ec6bbcdb4e85403f2c5958876ca9492afdf4031.
---
fs/cifs/cifsencrypt.c |2 --
fs/cifs/sess.c| 13 +
2 files changed, 5 insertions(+), 10 deletions(-)
diff --git a/fs/cifs/cifsencrypt.c b/fs/cifs/cifsencrypt.c
index eef78c2..051d000 100644
---
This reverts commit 2d20ca835867d93ead6ce61780d883a4b128106d.
---
fs/cifs/cifsencrypt.c | 193 ++---
fs/cifs/cifsglob.h|7 --
2 files changed, 72 insertions(+), 128 deletions(-)
diff --git a/fs/cifs/cifsencrypt.c b/fs/cifs/cifsencrypt.c
index
On Wed, 01 Sep 2010 22:07:29 -0700
Ben Greear gree...@candelatech.com wrote:
On 09/01/2010 05:38 PM, Jeff Layton wrote:
No warning, it always returns something since the default case catches
all others. If I did put the return at the end, then the compiler wouldn't
catch a case where I
. With it, cifsd should only exit when the
last reference to it is put.
Exiting from the loop early is a serious error that's likely to cause an
oops. I think we ought to consider this patchset for 2.6.36 and maybe
for stable.
Thoughts?
Jeff Layton (3):
cifs: prevent cifsd from exiting
CIFSSMBNegotiate return -EAGAIN, and
then the caller can retry the whole thing on a newly reconnected socket.
If that fails again in the same way, the caller of cifs_get_smb_ses
should tear down the TCP_Server_Info struct.
Signed-off-by: Jeff Layton jlay...@redhat.com
---
fs/cifs/connect.c | 41
until they
can be reviewed.
--
Jeff Layton jlay...@samba.org
--
To unsubscribe from this list: send the line unsubscribe linux-cifs in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
*password, const char *cryptkey, bool
encrypt,
char *lnm_session_key)
What about the declaration in cifsproto.h?
Other than that...strong ACK here. We should get rid of as much unused
bloat as possible.
--
Jeff Layton jlay...@samba.org
--
To unsubscribe from this list: send
= ~CAP_EXTENDED_SECURITY;
Reviewed-by: Jeff Layton jlay...@samba.org
--
To unsubscribe from this list: send the line unsubscribe linux-cifs in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
;
}
/* thread spawned, put it on the list */
@@ -1644,6 +1651,9 @@ cifs_get_tcp_session(struct smb_vol *volume_info)
return tcp_ses;
+out_err2:
+ cifs_crypto_shash_release(tcp_ses);
+
out_err:
if (tcp_ses) {
if (!IS_ERR(tcp_ses-hostname))
--
Jeff
going
to happen if find_domain_name fails and the session setup call proceeds?
memcpy(bcc_ptr, (char *)v2_sess_key,
sizeof(struct ntlmv2_resp));
bcc_ptr += sizeof(struct ntlmv2_resp);
--
Jeff Layton jlay...@samba.org
--
To unsubscribe from
On Tue, 7 Sep 2010 07:12:48 -0500
Shirish Pargaonkar shirishpargaon...@gmail.com wrote:
This gets removed in one of the patches.
Why do it there and not here? What's the point of a function prototype
in a header with no function to back it up?
On Tue, Sep 7, 2010 at 6:17 AM, Jeff Layton
,
midQ-sequence_number+1);
if (rc) {
cERROR(1, Unexpected SMB signature);
--
Jeff Layton jlay...@samba.org
--
To unsubscribe from this list: send the line unsubscribe linux-cifs in
the body of a message to majord...@vger.kernel.org
More majordomo info
limited knowledge of the kernel crypto
routines.
--
Jeff Layton jlay...@samba.org
--
To unsubscribe from this list: send the line unsubscribe linux-cifs in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
On Tue, 7 Sep 2010 07:52:09 -0500
Shirish Pargaonkar shirishpargaon...@gmail.com wrote:
On Tue, Sep 7, 2010 at 6:56 AM, Jeff Layton jlay...@samba.org wrote:
On Mon, 6 Sep 2010 22:34:57 -0500
shirishpargaon...@gmail.com wrote:
From: Shirish Pargaonkar shirishpargaon...@gmail.com
in sending the patches however. Doing so
gives us a starting point for discussing the change. If you're not sure
about them, just declare them an RFC.
--
Jeff Layton jlay...@samba.org
--
To unsubscribe from this list: send the line unsubscribe linux-cifs in
the body of a message to majord
On Wed, 8 Sep 2010 06:32:24 -0400
Jeff Layton jlay...@samba.org wrote:
On Wed, 8 Sep 2010 10:49:13 +0400
Pavel Shilovsky piastr...@gmail.com wrote:
Hello!
I faced with a problem of the wrong cifs cache behavior while adapting
CIFS VFS client for working with the application which
{
+ sec_blob-SessionKey.BufferOffset = cpu_to_le32(tmp - pbuffer);
+ sec_blob-SessionKey.Length = 0;
+ sec_blob-SessionKey.MaximumLength = 0;
+ }
setup_ntlmv2_ret:
return tmp - pbuffer;
--
Jeff Layton jlay...@poochiereds.net
--
To unsubscribe
*);
For the record, I'd be ok with this patch going into 2.6.36.
Reviewed-by: Jeff Layton jlay...@samba.org
--
To unsubscribe from this list: send the line unsubscribe linux-cifs in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
.
Acked-by: Jeff Layton jlay...@samba.org
--
To unsubscribe from this list: send the line unsubscribe linux-cifs in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
On Sun, 12 Sep 2010 18:55:05 +0400
Pavel Shilovsky piastr...@gmail.com wrote:
2010/9/12 Jeff Layton jlay...@samba.org:
We can write a data in write_end call all the time when we don't have
an oplock for writing. If we get an error we simply returned it in
from write_end and an application
On Sun, 12 Sep 2010 20:16:21 +0400
Pavel Shilovsky piastr...@gmail.com wrote:
2010/9/12 Jeff Layton jlay...@samba.org:
This should probably be a set of patches that outlines each change.
There are 3, AFAICT:
Ok, no problem with this, I will post it soon.
1) it bypasses the cache
;
}
- iov[1].iov_base = pSMB-req.SecurityBlob[0];
/* unicode strings must be word aligned */
if ((iov[0].iov_len + iov[1].iov_len) % 2) {
*bcc_ptr = 0;
--
Jeff Layton jlay...@redhat.com
--
To unsubscribe
On Tue, 14 Sep 2010 15:18:32 +0530
Suresh Jayaraman sjayara...@suse.de wrote:
On 09/13/2010 11:32 PM, Jeff Layton wrote:
cifs_get_smb_ses must be called on a server pointer on which it holds an
active reference. It first does a search for an existing SMB session. If
it finds one, it'll put
though, that's really messy and unclear. I
think it would be best to free it in this function before you exit that
block.
--
Jeff Layton jlay...@redhat.com
--
To unsubscribe from this list: send the line unsubscribe linux-cifs in
the body of a message to majord...@vger.kernel.org
More majordomo
On Tue, 14 Sep 2010 10:19:56 -0500
Steve French smfre...@gmail.com wrote:
On Tue, Sep 14, 2010 at 6:39 AM, Jeff Layton jlay...@redhat.com wrote:
On Tue, 14 Sep 2010 15:18:32 +0530
Suresh Jayaraman sjayara...@suse.de wrote:
On 09/13/2010 11:32 PM, Jeff Layton wrote:
cifs_get_smb_ses
returning an
error.
Cc: sta...@kernel.org
Reviewed-by: Suresh Jayaraman sjayara...@suse.de
Signed-off-by: Jeff Layton jlay...@redhat.com
---
fs/cifs/connect.c |6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/fs/cifs/connect.c b/fs/cifs/connect.c
index 67dad54..88c84a3
get automatically freed. That does mean however that you
can't kfree it at the end of that block. One way to fix it would be to
move the ntlmsspblob declaration to the top of the function and kfree
it at function exit.
--
Jeff Layton jlay...@redhat.com
--
To unsubscribe from this list: send the line
:
key_put(spnego_key);
}
kfree(str_area);
+ kfree(ntlmsspblob);
if (resp_buf_type == CIFS_SMALL_BUFFER) {
cFYI(1, ssetup freeing small buf %p, iov[0].iov_base);
cifs_small_buf_release(iov[0].iov_base);
--
Jeff Layton jlay...@samba.org
*) blobptr;
+ }
+
+ return 0;
+}
+
--
Jeff Layton jlay...@samba.org
--
To unsubscribe from this list: send the line unsubscribe linux-cifs in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
1 - 100 of 2365 matches
Mail list logo
