4.4 SCSI queue status

again! I will never merge during the merge window again! I will never merge during the merge window again! -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kerne

Re: [RESEND PATCH] [SCSI] mvumi: 64bit value for seconds_since1970

d and whose value will overflow in Tina> year 2038. This patch uses ktime_get_real_seconds() instead since Tina> it provides a 64-bit seconds value, which is 2038 safe. Under normal circumstances I would like a driver owner signoff but it doesn't look like mvumi gets much attention. Applie

Re: [PATCH] sd: Clear PS bit before Mode Select.

>>>>> "Gabriel" == Gabriel Krisman Bertazi <kris...@linux.vnet.ibm.com> writes: Gabriel> This patch clears the PS bit in the buffer returned by Mode Gabriel> Select, right before it is used in the Mode Select command. Applied. -- Martin K. P

Re: [PATCH v3] scsi: pmcraid: replace struct timeval with ktime_get_real_seconds()

>>>>> "Alison" == Alison Schofield <amsfiel...@gmail.com> writes: Alison> Replace the use of struct timeval and do_gettimeofday() with 64 Alison> bit ktime_get_real_seconds. Prevents 32-bit type overflow in Alison> year 2038 on 32-bit systems. Applied.

[PATCH 2/3] block/sd: Fix device-imposed transfer length limits

S requests. Otherwise use BLK_DEF_MAX_SECTORS. - blk_limits_max_hw_sectors() is no longer used and can be removed. Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=93581 Signed-off-by: Martin K. Petersen <martin.peter...@oracle.com> --- block/blk-s

[PATCH 3/3] MAINTAINERS: Add myself as co-maintainer of the SCSI subsystem.

Signed-off-by: Martin K. Petersen <martin.peter...@oracle.com> --- MAINTAINERS | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/MAINTAINERS b/MAINTAINERS index 9de185da5f5b..978df6e36ddf 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -9205,8 +9205,10 @@ F: includ

[PATCH 1/3] sd: Make discard granularity match logical block size when LBPRZ=1

personality relies on the block layer's current behavior and is unable to deal with partial discard blocks we work around the problem by setting the granularity to match the logical block size when LBPRZ is enabled. Signed-off-by: Martin K. Petersen <martin.peter...@oracle.com> --- drivers/scsi/sd.

Re: [PATCH] mpt3sas: Fix use sas_is_tlr_enabled API before enabling MPI2_SCSIIO_CONTROL_TLR_ON flag

>>>>> "Sreekanth" == Sreekanth Reddy <sreekanth.re...@avagotech.com> writes: Sreekanth> Before enabling MPI2_SCSIIO_CONTROL_TLR_ON flag in MPI SCSI Sreekanth> IO request message, check whether TLR is enabled on the drive Sreekanth> using 'sas_is_tlr_enabled

Re: [patch] mvsas: don't allow negative timeouts

be a timeout in usec so this bug Dan> probably means we have a longer timeout than we should. Let's fix Dan> this by changing "val" to unsigned. Applied. -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line "unsubscribe linu

Re: [PATCHv4 1/1] SCSI: hosts: update to use ida_simple for host_no management

one incarnation >> throughout the system lifetime for any given value of X. That's a feature that I would absolutely hate to lose. I spend a huge amount of time looking at system logs. -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line &quo

Re: [PATCH 00/25] mpt3sas: Mergering mpt2sas & mpt3sas driver code

>>>>> "Yinghai" == Yinghai Lu <ying...@kernel.org> writes: Yinghai, Yinghai> error: inlining failed in call to always_inline James already queued the following fix from sfr: 0a5149ba02bd. But thanks for the heads-up! -- Martin K. Petersen Oracle Linux

Re: [patch] hpsa: logical vs bitwise AND typo

n't print a warning message Dan> which we wanted to print. Applied. -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 00/25] mpt3sas: Mergering mpt2sas & mpt3sas driver code

commit. Since it's mostly boilerplate stuff it should not matter too much from a bisection perspective. Thanks for doing this work! This will make things much easier going forward. -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line "unsubscrib

Re: [PATCH v4.3-rc7] be2iscsi : Fix bogus WARN_ON length check

Applied. -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH v2 1/5] ipr: Add delay to ensure coherent dumps.

t an explicit reset. This ensures we'll be Gabriel> collecting meaningful dump data, even when dumping right after Gabriel> an adapter reset. I have applied patches 1-5. -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line "unsubsc

Re: [PATCH 1/3] isci: remove SCSI host before detaching from SAS transport

>>>>> "Jack" == Jack Wang <jinpu.w...@profitbricks.com> writes: Applied patches 1-3. -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vge

Re: [PATCH] pm80xx: remove the SCSI host before detaching from SAS transport

ery loop and lockup the Benjamin> system, necessitating a reboot. Applied. -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH v9 0/8] Fix error message and present UFS variant

>>>>> "Yaniv" == Yaniv Gardi <yga...@codeaurora.org> writes: I have applied this series. -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majo

Re: [PATCH 1/3] ibmvsci: make parameters max_id and max_channel read-only

her not have to deal with mail archive-mangled versions. Please apply the relevant Reviewed-by tags and repost. Thank you! -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message t

Re: [PATCH] SCSI: Increase REPORT_LUNS timeout

>>>>> "Brian" == Brian King <brk...@linux.vnet.ibm.com> writes: Brian> This patch increases the timeout used on the REPORT_LUNS to 30 Brian> seconds. This patch solves the issue of 512 non existent LUNs Brian> showing up after this event. Applied.

Re: [PATCH 0/12] megaraid_sas : Updates for scsi for-next

>>>>> "sumit" == sumit saxena <sumit.sax...@avagotech.com> writes: sumit> This patch set is rebased on top of last patch set sent by me- sumit> http://marc.info/?l=linux-scsi=144102204225400=2 Please sumit> consider this patch set for next kernel re

Re: [PATCH 0/8] pm80xx: Add ATTO 12Gb HBA support and fix various issues

s chips. I have also addressed Benjamin> other various issues that were discovered during our testing Benjamin> and verification phase, mainly with resume-from-sleep, Benjamin> configuring PHY profiles, and using legacy interrupts. Applied. -- Martin K. Petersen Oracle Linux Engineerin

Re: [PATCH] sg: Fix double-free when drives detach during SG_IO

rash trace I saw is this: >> Signed-off-by: Calvin Owens <calvinow...@fb.com> Doug> Acked-by: Douglas Gilbert <dgilb...@interlog.com> Applied. -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 1 00/25] hpsa updates

>>>>> "Don" == Don Brace <don.br...@pmcs.com> writes: Don, There were several minor nits in the review comments. Please address these and repost with the relevant Reviewed-by tags added so we can get this series queued up. Thanks! -- Martin K. Peterse

Re: [PATCH v4 4/5] target: Use scsi helpers to build the sense data correctly

Sagi == Sagi Grimberg sa...@mellanox.com writes: Sagi Instead of open coding the sense buffer construction, use scsi Sagi scsi_build_sense_buffer() and scsi_set_sense_information() helpers Sagi which moved to scsi_common. Reviewed-by: Martin K. Petersen martin.peter...@oracle.com -- Martin K

Re: [PATCH v4 1/5] target: Inline transport_get_sense_codes()

Sagi == Sagi Grimberg sa...@mellanox.com writes: Sagi From: Bart Van Assche bart.vanass...@sandisk.com Inline this Sagi function in its call site since it performs a trivial task and Sagi since it is only called once. Reviewed-by: Martin K. Petersen martin.peter...@oracle.com -- Martin K

Re: [PATCH v4 2/5] target: Split transport_send_check_condition_and_sense()

translate_sense_reason(). Convert the switch Sagi statement that performs the translation into table-driven code. Reviewed-by: Martin K. Petersen martin.peter...@oracle.com -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line unsubscribe linux-scsi in the body

Re: [PATCH] scsi: Fix sense information setting in fixed sized format

Sagi == Sagi Grimberg sa...@mellanox.com writes: Sagi In fixed size sense format the information field is a four byte Sagi field. Correct. Reviewed-by: Martin K. Petersen martin.peter...@oracle.com -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send

Re: [PATCH v5 00/32] HiSilicon SAS driver

hould be made as an incremental patch. -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH] [SCSI] st: Remove obsolete scsi_tape.max_pfn

>>>>> "Geert" == Geert Uytterhoeven <ge...@linux-m68k.org> writes: Geert> Its last user was removed 10 years ago, in commit Geert> 8b05b773b6030de5 ("[SCSI] convert st to use scsi_execute_async"). Applied to the 4.5 queue. -- Martin K. Petersen

Re: [PATCH v2] qla2xxx: Remove unavailable firmware files

>>>>> "Himanshu" == Himanshu Madhani <himanshu.madh...@qlogic.com> writes: Himanshu> Remove firmware binary names for the ISPs, which are not Himanshu> submitted to linux-firmware Queued for 4.5. -- Martin K. Petersen Oracle Linux Engineering -

Re: [PATCH, resend] scsi: advansys: fix big-endian builds

>>>>> "Arnd" == Arnd Bergmann <a...@arndb.de> writes: Arnd> Building the advansys driver in a big-endian configuration such as Arnd> ARM allmodconfig shows a warning: Applied to 4.4. -- Martin K. Petersen Oracle Linux Engineering -- To unsu

Re: [PATCHv4 1/1] SCSI: hosts: update to use ida_simple for host_no management

ned about our support folks that rely on the incrementing host number when analyzing customer log files. Ewan: How do you folks feel about this change? -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body

Re: [PATCH, RESEND] qla2xxx: Fix rwlock recursion

>>>>> "Bart" == Bart Van Assche <bart.vanass...@sandisk.com> writes: Bart> This patch fixes the following kernel bug Applied (4.4). -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line "unsubscribe linux-s

Re: [PATCH 06/23] scsi_dh_alua: fixup description of stpg_endio()

>>>>> "Hannes" == Hannes Reinecke <h...@suse.de> writes: Hannes> Fixup copy-and-paste error in the description of stpg_endio(). Reviewed-by: Martin K. Petersen <martin.peter...@oracle.com> -- Martin K. Petersen Oracle Linux Engineering -- To u

Re: [PATCH 07/23] scsi: remove scsi_show_sense_hdr()

>>>>> "Hannes" == Hannes Reinecke <h...@suse.de> writes: Hannes> Last caller is gone, so remove it. Reviewed-by: Martin K. Petersen <martin.peter...@oracle.com> -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this lis

Re: [PATCH 08/23] scsi_dh_alua: use flag for RTPG extended header

>>>>> "Hannes" == Hannes Reinecke <h...@suse.de> writes: Hannes> We should be using a flag when RTPG extended header is not Hannes> supported, that saves us sending RTPG twice for older arrays. Reviewed-by: Martin K. Petersen <martin.peter...@oracle.com>

Re: [PATCH 09/23] scsi_dh_alua: use unaligned access macros

>>>>> "Hannes" == Hannes Reinecke <h...@suse.de> writes: Hannes> Use 'get_unaligned_XX' and 'put_unaligned_XX' instead of Hannes> open-coding it. Reviewed-by: Martin K. Petersen <martin.peter...@oracle.com> -- Martin K. Petersen Oracle Linux E

Re: [PATCH 10/23] scsi_dh_alua: Pass buffer as function argument

>>>>> "Hannes" == Hannes Reinecke <h...@suse.de> writes: Hannes> Pass in the buffer as a function argument for submit_rtpg(). Reviewed-by: Martin K. Petersen <martin.peter...@oracle.com> -- Martin K. Petersen Oracle Linux Engineering -- To u

Re: [PATCH v3 6/10] megaraid_sas : Chip reset if driver fail to bring ioc ready

ck. For fusion Sumit> adapter, that call back was void, so it will not do any chip Sumit> reset. Sumit> Now, using this patch megasas_adp_reset_fusion() will have chip Sumit> reset logic for Fusion adapter. Reviewed-by: Martin K. Petersen <martin.peter...@oracle.com

Re: [PATCH v3 9/10] megaraid_sas : Code refactor for use of requestorId

11 or new Sumit> restructured to support only for specific device id Reviewed-by: Martin K. Petersen <martin.peter...@oracle.com> -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a messag

Re: [PATCH 01/23] scsi_dh_alua: Disable ALUA handling for non-disk devices

ce Hannes> for now. Reviewed-by: Martin K. Petersen <martin.peter...@oracle.com> -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH v3 10/10] megaraid_sas : Version upgrade

>>>>> "Sumit" == sumit saxena <sumit.sax...@avagotech.com> writes: Reviewed-by: Martin K. Petersen <martin.peter...@oracle.com> -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line "unsubscribe linu

Re: [PATCH v3 8/10] megaraid_sas : Fix validHandles check in io path

Sumit> Without this patch, earlier driver code does not use dual path Sumit> functionality. Reviewed-by: Martin K. Petersen <martin.peter...@oracle.com> -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line "unsubscribe linux-scsi"

Re: [PATCH v3 7/10] megaraid_sas : Print critical fw event message

>>>>> "Sumit" == sumit saxena <sumit.sax...@avagotech.com> writes: Sumit> Print firmware event in readable format. This will help user to Sumit> track any critical firmware event without any application Sumit> support. Reviewed-by: Martin K. Petersen &l

Re: [PATCH 02/23] scsi_dh_alua: Use vpd_pg83 information

>>>>> "Hannes" == Hannes Reinecke <h...@suse.de> writes: Hannes> The SCSI device now has the VPD page 0x83 information attached, Hannes> so there is no need to query it again. Reviewed-by: Martin K. Petersen <martin.peter...@oracle.com> -- Marti

Re: [PATCH 03/23] scsi_dh_alua: improved logging

>>>>> "Hannes" == Hannes Reinecke <h...@suse.de> writes: Hannes> Issue different logging messages if ALUA is not supported or the Hannes> TPGS setting is invalid. Reviewed-by: Martin K. Petersen <martin.peter...@oracle.com> -- Martin K. Petersen

Re: [PATCHv2 00/18] ALUA device handler update, part 1

arsing functions Hannes> scsi_vpd_lun_id() and scsi_vpd_tpg_id(). This series has been Hannes> split off from the original 'Asynchronous ALUA' patchset, as Hannes> these bits are pretty uncontroversial and have a good chance of Hannes> being merged reasonably soon. Applied to 4.5/scsi-queue.

Re: [scsi:fixes 16/18] warning: (SCSI_MPT2SAS) selects SCSI_MPT3SAS which has unmet direct dependencies (SCSI_LOWLEVEL && ..)

od to me. I also asked Fengguang to add scsi.git to the kbuild test robot. It looks like it's only been testing the SCSI branches I kept in my regular git tree and they were a bit behind scsi.git. -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line &quo

Re: [PATCH v2 0/4] bfa: Patches for scsi "misc" branch

>>>>> "Anil" == <anil.gurumur...@qlogic.com> writes: Anil> Please apply the following patches to the scsi tree, misc branch Anil> at your earliest convenience. Series applied to 4.5/scsi-queue. -- Martin K. Petersen Oracle Linux Engineering -

Re: Linux kernels 4.3+ mess up MPT2SAS configs

because of what looks John> like a merge of the mpt2sas and mpt3sas drivers. http://git.kernel.org/cgit/linux/kernel/git/mkp/scsi.git/commit/?h=4.4/scsi-queue -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in th

Re: [PATCH] scsi_dh_alua: Remove stale variables

>>>>> "Hannes" == Hannes Reinecke <h...@suse.de> writes: Hannes> With commit 83ea0e5e3501 these variables became obsolete, but Hannes> weren't removed. Applied to 4.5/scsi-queue. -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from

Re: [PATCH v2] storvsc: add logging for error/warning messages

shooting Long> purposes. Applied to 4.5/scsi-queue. -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH] [SCSI] osd: fix signed char versus %02x issue

and send a bunch once again Re-sending to linux-scsi is fine. The trick is finding people willing to review them... -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.

Re: [PATCH RESEND] cxlflash: a couple off by one bugs

>>>>> "Matthew" == Matthew R Ochs <mro...@linux.vnet.ibm.com> writes: Matthew> The "> MAX_CONTEXT" should be ">= MAX_CONTEXT". Otherwise we Matthew> go one step beyond the end of the cfg->ctx_tbl[] array. Applied to 4.5

Re: [PATCH 0/15] copy offload patches

aid I didn't get a chance to dig very deep in your series since it coincided with me scrambling to sort out SCSI for 4.4. Do you think there's a chance we could get your patches in shape for 4.5? Is there an up-to-date tree I can look at? -- Martin K. Petersen Oracle Linux Engineering -

Re: kernel BUG at block/bio.c:1787! while initializing scsi_debug on ppc64 host

>>>>> "Eryu" == Eryu Guan <guane...@gmail.com> writes: Eryu, Does the patch below fix the issue? -- Martin K. Petersen Oracle Linux Engineering diff --git a/drivers/scsi/sd.c b/drivers/scsi/sd.c index 3d22fc3e3c1a..d1eb7aa78b8d 100644 --- a/drivers/sc

[PATCH 1/3] scsi_debug: Increase the reported optimal transfer length

The OPTIMAL TRANSFER LENGTH reported by scsi_debug is 64 blocks which translates to 32KB with the default logical block size. That's much lower than what real storage devices typically report (256KB to 1MB). Bump the optimal transfer length to 1024 blocks. Signed-off-by: Martin K. Petersen

[PATCH 3/3] block: Export max_dev_sectors_kb in sysfs

. Export the max_dev_sectors_kb queue limit in sysfs and update the documentation accordingly. Signed-off-by: Martin K. Petersen <martin.peter...@oracle.com> --- Documentation/ABI/testing/sysfs-block | 9 + Documentation/block/queue-sysfs.txt | 11 +-- block/blk-sett

[PATCH 2/3] sd: Reject optimal transfer length smaller than page size

if it is bigger than or equal to the page cache size. Reported-by: Eryu Guan <guane...@gmail.com> Reported-by: Ming Lei <tom.leim...@gmail.com> Signed-off-by: Martin K. Petersen <martin.peter...@oracle.com> --- drivers/scsi/sd.c | 9 ++--- 1 file changed, 6 insertions(+), 3

Re: [patch] qla2xxx: fix a timeout loop

>>>>> "Dan" == Dan Carpenter <dan.carpen...@oracle.com> writes: Dan> After the loop we test for "if (!retries) " as a failure, but Dan> actually the post-op here will end with retries set to -1. I have Dan> fixed this by using a pre-op instead.

Note to driver maintainers

. You have to review everybody else's. Thanks! -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH v2] hisi_sas: use platform_get_irq()

>>>>> "John" == John Garry <john.ga...@huawei.com> writes: John> It is preferred that drivers use platform_get_irq() instead of John> irq_of_parse_and_map(), so replace. Applied to 4.5/scsi-queue. -- Martin K. Petersen Oracle Linux Engineering -

Re: [PATCHv4 1/1] SCSI: hosts: update to use ida_simple for host_no management

he bullet. I don't see much value in the module parameter since it will require customers to tweak their configs and reproduce. Not worth the hassle. -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the b

Re: [patch] qla2xxx: fix a timeout loop

ay after a patch was Dan> "applied".) I dropped it for now. -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [patch] hisi_sas: fix error codes in hisi_sas_task_prep()

>>>>> "Dan" == Dan Carpenter <dan.carpen...@oracle.com> writes: Dan> There were a couple cases where the error codes weren't set and Dan> also I changed the success return to "return 0;" which is the same Dan> as "return rc;" but more e

Re: [PATCH RESEND] cxlflash: drop unlikely before IS_ERR_OR_NULL

>>>>> "Matthew" == Matthew R Ochs <mro...@linux.vnet.ibm.com> writes: Matthew> IS_ERR_OR_NULL already contain an unlikely compiler flag. Drop Matthew> it. Applied to 4.5/scsi-queue. -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from

Re: [PATCH v2] VMW_PVSCSI: Fix the issue of DMA-API related warnings.

en DMA_API_DEBUG Josh> option is enabled. This change fixes the issue and makes Josh> pvscsi_map_buffers() function more robust. Applied to 4.5/scsi-queue. -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line "unsubscribe linux-scsi&quo

Re: [PATCH] [SCSI] osd: fix signed char versus %02x issue

wed by the two hex chars that were actually Rasmus> intended. One way to fix it would be to change the casts to Rasmus> (u8*) aka (unsigned char*), but it is much simpler (and Rasmus> generates smaller code) to use the %ph extension which was Rasmus> created for such short hexdumps. Applie

Re: kernel BUG at block/bio.c:1787! while initializing scsi_debug on ppc64 host

entional. I agree that the value chosen by scsi_debug in this case is very low and we should fix that. -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More m

Re: [PATCH 0/15] copy offload patches

different branch from the xcopy stuff. I will have to reconcile those two branches and then layer your stuff on top. -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord.

Re: kernel BUG at block/bio.c:1787! while initializing scsi_debug on ppc64 host

d a sanity check for the page size. And fix up scsi_debug. -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: kernel BUG at block/bio.c:1787! while initializing scsi_debug on ppc64 host

equipment back online. However, I think I have found the smoking gun. More in a bit... -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH] mpt3sas: a correction in unmap_resources

>>>>> "Tomas" == Tomas Henzl <the...@redhat.com> writes: Tomas> It might happen that we try to free an already freed pointer. Tomas> Tomas Applied to 4.5/scsi-queue. -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list:

Re: [PATCH RFC 0/2] avoid crashing when reading /proc/scsi/scsi and simultaneously removing devices

the device from being Ewan> removed from the list. Thus, we get errors and eventually panic, Ewan> as shown in the traces below. Fix this by keeping a klist Ewan> iterator in the seq_file private data. Applied to 4.5/scsi-queue. -- Martin K. Petersen Oracle Linux Engineering -- To unsub

Re: [PATCH v3 0/3] hpsa update

ices - add Don> in enclosure information Applied to 4.5/scsi-queue. -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH V2 0/9] aacraid: Patchset for aacraid driver version 41052

t disables device ID wild card binding You dropped all the review/fix/stable tags you had received from Tomas and Johannes. Please apply the relevant tags and resubmit this series. -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line "unsubsc

Re: [PATCH 02/35] block: add REQ_OP definitions and bi_op/op fields

y the REQ_ prefix in bios since the flags were consolidated a while back. When I attempted to fix the READ/WRITE mess I used a BLK_ prefix as a result. Anyway. Just bikeshedding... -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line "unsubscribe

Re: [PATCH 00/35 v2] separate operations from flags in the bio/request structs

ces and everything looks sensible to me. I wonder what the best approach is to move a patch set with this many stakeholders forward? Set a "speak now or forever hold your peace" review deadline? -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list:

Re: [PATCH v2 0/6] cxlflash: Miscellaneous fixes and updates

below for details on Uma> what has been altered from previous versions of this patch set. Applied to 4.5/scsi-queue. -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to m

Re: [PATCH v4 00/78] More fixes, cleanup and modernization for NCR5380 drivers

uild complains. http://git.kernel.org/cgit/linux/kernel/git/mkp/scsi.git/log/?h=4.5/ncr5380 -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: kernel BUG at block/bio.c:1787! while initializing scsi_debug on ppc64 host

It just hasn't made it to Linus yet... -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCHv4 1/1] SCSI: hosts: update to use ida_simple for host_no management

>>>>> "Lee" == Lee Duncan <ldun...@suse.com> writes: Lee> Do you need me to resubmit this patch now that it's accepted? Please resend. Thanks! -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line "unsubscri

Re: [PATCH 1/1] mvsas: add SGPIO support to Marvell 94xx

>>>>> "Wilfried" == Wilfried Weissmann <wilfried.weissm...@gmx.at> writes: Wilfried> add SGPIO support to Marvell 94xx Applied to 4.5/scsi-queue. Thanks! -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line &q

Re: [PATCH] scsi: mvsas: fix indenting on return error code

(with missing { } Colin> braces) rather than a DEV_IS_GONE() failure. This problem has already been addressed: https://git.kernel.org/cgit/linux/kernel/git/mkp/scsi.git/commit/?h=4.5/scsi-queue=7789cd39274c -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this

Re: [PATCH v3 0/4] scsi: cleanup ioctl headers and provide UAPI versions

ons. The change from v2 to v3 is that >> defaults for sg.c are not exported in include/uapi/linux/sg.c. Paolo> What happened to these patches?... They predate me being patch monkey. Please repost with any review tags or acks you may have received. -- Martin K. Petersen Orac

Re: [PATCH V4 0/4] scsi: storvsc: Properly support FC hosts

>>>>> "KYS" == K Y Srinivasan <k...@microsoft.com> writes: The template discussion appears to have lost momentum and since the concerns were minor I have applied your latest series to 4.5/scsi-queue. -- Martin K. Petersen Oracle Linux Engineering -- To u

Re: [PATCH 1/1] mvsas: add SGPIO support to Marvell 94xx

>>>>> "Wilfried" == Wilfried Weissmann <wilfried.weissm...@gmx.at> writes: Wilfried, Wilfried> add SGPIO support to Marvell 94xx Does not apply to current tree. Please rebase on top of: http://git.kernel.org/cgit/linux/kernel/git/mkp/scsi.git/log/?h=4.5/sc

Re: [PATCH 00/17] lpfc: Update to revision 11.0.0.10

>>>>> "James" == James Smart <james.sm...@avagotech.com> writes: James> This patch set updates the lpfc driver to revision 11.0.0.10 James> The patches were cut against scsi-misc Applied to 4.5/scsi-queue except for 3/17. -- Martin K. Petersen Oracl

Reviews, please

that would be nice to get either acked or nacked: https://patchwork.kernel.org/project/linux-scsi/list/ Thank you! -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message

Re: [PATCH RESEND] scsi_debug: fix prevent_allow+verify regressions

>>>>> "Doug" == Douglas Gilbert <dgilb...@interlog.com> writes: Doug> Ruediger Meier observed a regression with the PREVENT ALLOW MEDIUM Doug> REMOVAL command in lk 3.19: Doug> http://www.spinics.net/lists/util-linux-ng/msg11448.html Applied to 4.4.

Re: [PATCH] scsi: rescan VPD attributes

was looking into merging the ALUA series but this prerequisite patch is lacking reviews... -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 0/2] Fix a scsi_host_dev_release() memory leak

i_host_{get,put}() calls. - A Bart> second patch that fixes the actual memory leak. I gave a bunch of reviews for v1 but no takers for v2 of the second patch. -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in

Re: [PATCH] scsi: use sector_div instead of do_div

>>>>> "Arnd" == Arnd Bergmann <a...@arndb.de> writes: Arnd> do_div is the wrong way to divide a sector_t, as it is less Arnd> efficient when sector_t is 32-bit wide. With the upcoming do_div Arnd> optimizations, the kernel starts warning about this: Appl

Re: [PATCH RESEND] scsi_debug: fix prevent_allow+verify regressions

>>>>> "Andy" == Andy Shevchenko <andy.shevche...@gmail.com> writes: Andy, Andy> but can you pay a little attention to Andy> http://www.spinics.net/lists/linux-scsi/msg81778.html ? It seems Andy> it wasn't applied. Please resubmit to linux-scsi. We

Re: [PATCH 01/18] scsi_dh: move 'dh_state' sysfs attribute to generic code

hen removing scsi device"). Looked simple enough and I started to fix it up but then decided to let you do since you'll have to check it anyway. Please rebase on top of latest 4.5/scsi-queue (which has your VPD rescan patch in place). -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH v1 1/1] scsi_debug: check for bigger value first

>>>>> "Andy" == Andy Shevchenko <andriy.shevche...@linux.intel.com> writes: Andy> Even for signed types we have to check for bigger positive value Andy> first. Otherwise it will be never happened. Applied to 4.5/scsi-queue. -- Martin K. Petersen Oracl

Re: [PATCH] scsi: rescan VPD attributes

>>>>> "Hannes" == Hannes Reinecke <h...@suse.de> writes: Hannes> The VPD page information might change, so we need to be able to Hannes> update it. This patch implements a VPD page rescan whenever the Hannes> 'rescan' sysfs attribute is triggered.

Re: [PATCH v2 0/4] bfa: Patches for scsi "misc" branch

ing review tags when you post an updated series. Patches 1, 3 and 4 got reviewed by Johannes. No need to resend, I'll try to remember this time (assuming patch 2 gets reviewed soon-ish). -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line "uns

Re: [PATCH 1/2] scsi_transport_fc: Introduce scsi_host_{get,put}()

>>>>> "Bart" == Bart Van Assche <bart.vanass...@sandisk.com> writes: Bart, Bart> Use scsi_host_{get,put}() instead of open-coding these functions. Bart> Compile-tested only. Do you want me to queue this as a general cleanup for 4.5 (independently of the

<    2   3   4   5   6   7   8   9   10   11   >