Re: [Mesa-dev] [PATCH 3/3] winsys/svga: use new pb_usage_flags enum type

2019-03-07 Thread Thomas Hellstrom
On Tue, 2019-03-05 at 20:48 -0700, Brian Paul wrote: > And add a comment that we're implicitly converting PIPE_TRANSFER_ > flags to PB_USAGE_ flags in one place. And statically assert that > the enum values match. LGTM. Thanks for fixing this! Reviewed-by: Thomas Hellstrom > --- >

Re: [Mesa-dev] [PATCH] gallium/u_transfer_helper: do not call resource_create(..) directly

2019-03-07 Thread Christian Gmeiner
Am Fr., 1. März 2019 um 16:54 Uhr schrieb Christian Gmeiner : > > Use u_transfer_helper_resource_create(..) instead which uses the > resource_create(..) function specified in u_transfer_vtbl. > > Signed-off-by: Christian Gmeiner > --- > src/gallium/auxiliary/util/u_transfer_helper.c | 2 +- > 1

[Mesa-dev] [Bug 41595] Hi10P videos produce improper output in gl unless yv12 is used.

2019-03-07 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=41595 Tapani Pälli changed: What|Removed |Added Resolution|--- |DUPLICATE Status|NEW

Re: [Mesa-dev] [PATCH] docs: try to improve the Meson documentation

2019-03-07 Thread Eric Engestrom
On 2019-03-08 at 03:42, Brian Paul wrote: > Add new Introduction and Advanced Usage sections. > Spell out a few more details, like "ninja install". > Improve the layout around example commands. > Fix grammatical errors and tighten up the text. > Explain the --prefix option. Thanks! I left a

Re: [Mesa-dev] [PATCH] svga: remove SVGA_RELOC_READ flag in SVGA3D_BindGBSurface()

2019-03-07 Thread Thomas Hellstrom
On Thu, 2019-03-07 at 19:45 -0700, Brian Paul wrote: > This fixes a rendering issue where UBO updates aren't always picked > up by drawing calls. This issue effected the Webots robotics > simulator. VMware bug 2175527. > > Testing Done: Webots replay, piglit, misc Linux games > --- >

Re: [Mesa-dev] [PATCH 1/5] st/nine: Disable depth write when nothing gets updated

2019-03-07 Thread Kenneth Graunke
On Thursday, March 7, 2019 2:23:53 PM PST Axel Davy wrote: > I do not see any perf impact on radeonsi, but it > seems iris needs this. > It seems something sensible to do. > > Signed-off-by: Axel Davy > Reviewed-by: Timur Kristóf > Tested-by: Andre Heider > --- > It may be argued this kind of

[Mesa-dev] [Bug 109401] [DXVK] Project Cars rendering problems

2019-03-07 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=109401 ammy...@gmail.com changed: What|Removed |Added CC||ammy...@gmail.com -- You are

Re: [Mesa-dev] [PATCH] gallium: Add PIPE_BARRIER_UPDATE_BUFFER and UPDATE_TEXTURE bits.

2019-03-07 Thread Kenneth Graunke
Forgot Marek is on vacation. Nicolai, do you have an opinion? It looks like you added the original comments that it isn't necessary to handle these cases, too... --Ken On Thursday, March 7, 2019 3:48:04 PM PST Kenneth Graunke wrote: > Hey Ilia, Marek, > > Do you have an opinion about this?

[Mesa-dev] [PATCH] docs: try to improve the Meson documentation

2019-03-07 Thread Brian Paul
Add new Introduction and Advanced Usage sections. Spell out a few more details, like "ninja install". Improve the layout around example commands. Fix grammatical errors and tighten up the text. Explain the --prefix option. --- docs/contents.html | 2 +- docs/meson.html| 138

[Mesa-dev] [Bug 109656] duplicate symbol _compute_shader_video_buffer

2019-03-07 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=109656 Vinson Lee changed: What|Removed |Added Resolution|--- |FIXED Status|NEW

[Mesa-dev] [PATCH] svga: remove SVGA_RELOC_READ flag in SVGA3D_BindGBSurface()

2019-03-07 Thread Brian Paul
This fixes a rendering issue where UBO updates aren't always picked up by drawing calls. This issue effected the Webots robotics simulator. VMware bug 2175527. Testing Done: Webots replay, piglit, misc Linux games --- src/gallium/drivers/svga/svga_cmd.c | 2 +- 1 file changed, 1 insertion(+),

Re: [Mesa-dev] [PATCH] svga: refactor draw_vgpu10() function

2019-03-07 Thread Neha Bhende
Looks good to me. Just one nit pick, In definition of validate_index_buffer, extra space is required in argument list. Reviewed-by: Neha Bhende Regards, Neha Regards, Neha From: Brian Paul Sent: Thursday, March 7, 2019 3:23 PM To:

Re: [Mesa-dev] [PATCH] gallium: Add PIPE_BARRIER_UPDATE_BUFFER and UPDATE_TEXTURE bits.

2019-03-07 Thread Kenneth Graunke
Hey Ilia, Marek, Do you have an opinion about this? I've got a R-b from Eric Anholt and what sounds like an Ack from Roland, but I wanted to make sure everyone was OK with this before landing it. --Ken On Wednesday, March 6, 2019 12:32:23 AM PST Kenneth Graunke wrote: > The glMemoryBarrier()

[Mesa-dev] [PATCH] svga: refactor draw_vgpu10() function

2019-03-07 Thread Brian Paul
The draw_vgpu10() function was huge. Move the code for preparing the vertex buffers and the index buffer into separate functions. --- src/gallium/drivers/svga/svga_draw.c | 246 --- 1 file changed, 141 insertions(+), 105 deletions(-) diff --git

[Mesa-dev] [Bug 109929] tgsi_to_nir.c:2111: undefined reference to `gl_nir_lower_samplers_as_deref'

2019-03-07 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=109929 Bug ID: 109929 Summary: tgsi_to_nir.c:2111: undefined reference to `gl_nir_lower_samplers_as_deref' Product: Mesa Version: git Hardware: x86-64 (AMD64)

[Mesa-dev] [PATCH 4/5] st/nine: Do not advertise CANMANAGERESOURCE

2019-03-07 Thread Axel Davy
It doesn't seem the main vendors advertise it. Signed-off-by: Axel Davy --- src/gallium/state_trackers/nine/adapter9.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium/state_trackers/nine/adapter9.c b/src/gallium/state_trackers/nine/adapter9.c index

[Mesa-dev] [PATCH 5/5] st/nine: Change a few advertised caps

2019-03-07 Thread Axel Davy
Most hw on the native platform advertise these caps this way. D3DCAPS_READ_SCANLINE: We don't really have hardware support for that, but many games don't even check the flag, and expect GetRasterStatus to work, which is why we emulated it with a timer (like wine). So we may as well advertise the

[Mesa-dev] [PATCH 2/5] d3dadapter9: Support software renderer on any DRI device

2019-03-07 Thread Axel Davy
From: Patrick Rudolph If D3D_ALWAYS_SOFTWARE is set for debugging purposes, run on any DRI enabled platform. Instead of probing for a compatible gallium driver (which might fail if there's none) always use the KMS DRI software renderer. Allows to run nine on i915 when D3D_ALWAYS_SOFTWARE=1.

[Mesa-dev] [PATCH 1/5] st/nine: Disable depth write when nothing gets updated

2019-03-07 Thread Axel Davy
I do not see any perf impact on radeonsi, but it seems iris needs this. It seems something sensible to do. Signed-off-by: Axel Davy Reviewed-by: Timur Kristóf Tested-by: Andre Heider --- It may be argued this kind of stuff should be done in the driver. I don't mind either way. The ogl state

[Mesa-dev] [PATCH 3/5] st/nine: Do not advertise support for D15S1 and D24X4S4

2019-03-07 Thread Axel Davy
The former is supported on Matrox cards but no other hw. The latter isn't supported anywhere. It is fine to not advertise them as supported, and it could prevent apps to trigger weird rendering paths. Signed-off-by: Axel Davy --- src/gallium/state_trackers/nine/nine_pipe.c | 4 ++-- 1 file

[Mesa-dev] [PATCH] nir/serialize: Make preserving names optional

2019-03-07 Thread Jason Ekstrand
--- src/compiler/nir/nir_serialize.c | 56 --- src/compiler/nir/nir_serialize.h | 3 +- .../drivers/radeonsi/si_state_shaders.c | 2 +- src/intel/vulkan/anv_pipeline_cache.c | 2 +- .../drivers/dri/i965/brw_program_binary.c | 2 +-

[Mesa-dev] [Bug 109927] Xorg segfault when a web browser is opened

2019-03-07 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=109927 --- Comment #4 from keiron.dav...@googlemail.com --- I found that the previously built .debs were available on launchpad, so I reverted packages to isolate. After rolling back xserver-xorg-video-amdgpu to the previously working version and

[Mesa-dev] [Bug 109927] Xorg segfault when a web browser is opened

2019-03-07 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=109927 --- Comment #3 from keiron.dav...@googlemail.com --- (In reply to Michel Dänzer from comment #2) > Can you isolate whether it was the Mesa or xserver-xorg-video-amdgpu update > that triggered it? I'm not sure how I'd roll back either one, the

Re: [Mesa-dev] [PATCH] st/mesa: move, clean-up shader variant key decls/inits

2019-03-07 Thread Neha Bhende
Reviewed-by: Neha Bhende Regards, Neha From: Brian Paul Sent: Thursday, March 7, 2019 8:20 AM To: mesa-dev@lists.freedesktop.org Cc: Neha Bhende Subject: [PATCH] st/mesa: move, clean-up shader variant key decls/inits Move the variant key declarations inside

Re: [Mesa-dev] [PATCH] nir/builder: Emit better code for iadd/imul_imm

2019-03-07 Thread Caio Marcelo de Oliveira Filho
On Thu, Mar 07, 2019 at 11:34:50AM -0600, Jason Ekstrand wrote: > Because we already know the immediate right-hand parameter, we can > potentially save the optimizer a bit of work. > --- > src/compiler/nir/nir_builder.h | 25 +++-- > 1 file changed, 23 insertions(+), 2

[Mesa-dev] [Bug 109927] Xorg segfault when a web browser is opened

2019-03-07 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=109927 --- Comment #2 from Michel Dänzer --- Can you isolate whether it was the Mesa or xserver-xorg-video-amdgpu update that triggered it? -- You are receiving this mail because: You are the assignee for the bug. You are the QA Contact for the

[Mesa-dev] [PATCH] nir/builder: Emit better code for iadd/imul_imm

2019-03-07 Thread Jason Ekstrand
Because we already know the immediate right-hand parameter, we can potentially save the optimizer a bit of work. --- src/compiler/nir/nir_builder.h | 25 +++-- 1 file changed, 23 insertions(+), 2 deletions(-) diff --git a/src/compiler/nir/nir_builder.h

[Mesa-dev] [Bug 109927] Xorg segfault when a web browser is opened

2019-03-07 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=109927 Michel Dänzer changed: What|Removed |Added Attachment #143574|text/x-log |text/plain mime type|

[Mesa-dev] [Bug 109927] Xorg segfault when a web browser is opened

2019-03-07 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=109927 --- Comment #1 from keiron.dav...@googlemail.com --- Created attachment 143575 --> https://bugs.freedesktop.org/attachment.cgi?id=143575=edit /home/usernaym/.local/share/xorg/Xorg.0.log.old & Xorg.0.log Here are the Xorg logs from the same

[Mesa-dev] [Bug 109927] Xorg segfault when a web browser is opened

2019-03-07 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=109927 Bug ID: 109927 Summary: Xorg segfault when a web browser is opened Product: Mesa Version: git Hardware: x86-64 (AMD64) OS: Linux (All) Status: NEW

[Mesa-dev] GraphicsFuzz 1.2 released

2019-03-07 Thread Hugues Evrard
Hi all, We’re pleased to announce the release 1.2 of GraphicsFuzz, a testing framework for shader compilers which we think might be of interest to the Mesa community: https://github.com/google/graphicsfuzz/releases/tag/v1.2 Our how-it-works doc is a short recap of our testing approach:

[Mesa-dev] [PATCH] st/mesa: move, clean-up shader variant key decls/inits

2019-03-07 Thread Brian Paul
Move the variant key declarations inside the scope they're used. Use designated initializers instead of memset() calls. --- src/mesa/state_tracker/st_atom_shader.c | 8 src/mesa/state_tracker/st_program.c | 9 +++-- 2 files changed, 7 insertions(+), 10 deletions(-) diff --git

[Mesa-dev] [Bug 108900] [KBL-G][Vulkan] Non-recoverable GPU hangs with GfxBench v5 Aztec Ruins Vulkan test

2019-03-07 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=108900 --- Comment #12 from Eero Tamminen --- (In reply to Samuel Pitoiset from comment #11) > First time I see a shader like that... > > Can you install spirv-dis and generate a new hang report, please? The SPIR-V > is probably useful too. Sorry,

[Mesa-dev] [Bug 108900] [KBL-G][Vulkan] Non-recoverable GPU hangs with GfxBench v5 Aztec Ruins Vulkan test

2019-03-07 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=108900 --- Comment #11 from Samuel Pitoiset --- First time I see a shader like that... Can you install spirv-dis and generate a new hang report, please? The SPIR-V is probably useful too. -- You are receiving this mail because: You are the assignee

[Mesa-dev] [Bug 108900] [KBL-G][Vulkan] Non-recoverable GPU hangs with GfxBench v5 Aztec Ruins Vulkan test

2019-03-07 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=108900 --- Comment #10 from Eero Tamminen --- Created attachment 143573 --> https://bugs.freedesktop.org/attachment.cgi?id=143573=edit 70MB output from the RADV debug options (compressed) -- You are receiving this mail because: You are the

[Mesa-dev] [Bug 108900] [KBL-G][Vulkan] Non-recoverable GPU hangs with GfxBench v5 Aztec Ruins Vulkan test

2019-03-07 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=108900 --- Comment #9 from Eero Tamminen --- Created attachment 143572 --> https://bugs.freedesktop.org/attachment.cgi?id=143572=edit Hang trace (In reply to Samuel Pitoiset from comment #8) > Again, without the demo is hard to fix. While GfxBench

[Mesa-dev] [Merge request #362]scons: Fix MSYS2 Mingw-w64 build (toolchain=mingw)

2019-03-07 Thread Liviu Prodea
This patch is based on https://github.com/msys2/MINGW-packages/blob/master/mingw-w64-mesa/link-ole32.patch but with tweaks to avoid MSVC build break when applied. There is a caveat to this patch though, it doesn't help swr driver. ___ mesa-dev

Re: [Mesa-dev] nir: Add ability for shaders to use window space coordinates - broken tessellation under NIR - bisected

2019-03-07 Thread Dieter Nützel
Hello Andre, @Tim: Tested-by: Dieter Nützel with UH on Polaris 20 Am 07.03.2019 15:35, schrieb Andre Heider: On 07/03/2019 15:08, Dieter Nützel wrote: can you please send a patch to the list (and then we will see it at Patchwork Mesa, too), please? It is much faster (for me) and I haven't

Re: [Mesa-dev] nir: Add ability for shaders to use window space coordinates - broken tessellation under NIR - bisected

2019-03-07 Thread Andre Heider
On 07/03/2019 15:08, Dieter Nützel wrote: can you please send a patch to the list (and then we will see it at Patchwork Mesa, too), please? It is much faster (for me) and I haven't the time to dig me into Gitlab MRs etc. stuff at the moment. OLD school man... It's just a single patch in that

Re: [Mesa-dev] nir: Add ability for shaders to use window space coordinates - broken tessellation under NIR - bisected

2019-03-07 Thread Dieter Nützel
Hello Tim, can you please send a patch to the list (and then we will see it at Patchwork Mesa, too), please? It is much faster (for me) and I haven't the time to dig me into Gitlab MRs etc. stuff at the moment. OLD school man... Thanks, Dieter Am 07.03.2019 11:16, schrieb Timur Kristóf:

[Mesa-dev] [Bug 109920] "NIR validation failed in internal shader" abort with all Vulkan test-cases

2019-03-07 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=109920 Eero Tamminen changed: What|Removed |Added Status|RESOLVED|VERIFIED --- Comment #4 from Eero

Re: [Mesa-dev] [PATCH] nir/spirv: short-circuit when conditional branch contains end block

2019-03-07 Thread Jason Ekstrand
Woah, is this legal SPIR-V? I think a second OpSelectionMerge is required. --Jason On March 6, 2019 05:25:26 "Juan A. Suarez Romero" wrote: This fixes the case when the SPIR-V code has two nested conditional branches, but only one selection merge: [...] %1 = OpLabel OpSelectionMerge

[Mesa-dev] [Bug 77449] Tracker bug for all bugs related to Steam titles

2019-03-07 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=77449 andrew.m.mcma...@gmail.com changed: What|Removed |Added Depends on||109925 Referenced Bugs:

Re: [Mesa-dev] [PATCH] radv: disable DCC for X4 Foundations to workaround a GPU hang

2019-03-07 Thread Samuel Pitoiset
Superseded by https://patchwork.freedesktop.org/patch/290846/?series=57689=1 On 3/6/19 7:39 PM, Samuel Pitoiset wrote: The game apparently hangs inside a copy image operation, but only when DCC is enabled. I haven't figured out the root cause yet, but this workaround fixes the problem and

[Mesa-dev] [Bug 109393] [vega10] hang with Mario Party 9 through Dolphin

2019-03-07 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=109393 --- Comment #15 from Samuel Pitoiset --- Does the attached patch help https://patchwork.freedesktop.org/patch/290846/?series=57689=1 ? -- You are receiving this mail because: You are the assignee for the bug. You are the QA Contact for the

[Mesa-dev] [Bug 109805] GPU hangs with error VM_CONTEXT1_PROTECTION_FAULT_STATUS

2019-03-07 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=109805 --- Comment #12 from Samuel Pitoiset --- Does the attached patch help https://patchwork.freedesktop.org/patch/290846/?series=57689=1 ? -- You are receiving this mail because: You are the QA Contact for the bug. You are the assignee for the

[Mesa-dev] [PATCH] radv: increase aligment when allocating descriptors for meta operations

2019-03-07 Thread Samuel Pitoiset
We usually align to 0x100 when allocating descriptors and resources in the upload BO. I assume some data were corrupted because the alignment was too small. Be consistent (and safe) and align internal descriptors to 0x100 as well. This fixes a GPU hang at startup with X4 Foundations. Cc: 18.3

Re: [Mesa-dev] nir: Add ability for shaders to use window space coordinates - broken tessellation under NIR - bisected

2019-03-07 Thread Timur Kristóf
Hi, I was able to reproduce the problem with heaven, and that the proposed patch fixes it, so I made a MR: https://gitlab.freedesktop.org/mesa/mesa/merge_requests/402 Best regards, Tim On Thu, 2019-03-07 at 08:27 +0100, Timur Kristóf wrote: > Hi Dieter, > > Thanks for noticing this. > I think

[Mesa-dev] [Bug 109919] radv is broken on SI

2019-03-07 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=109919 --- Comment #6 from Turo Lamminen --- Confirm fixed. -- You are receiving this mail because: You are the assignee for the bug. You are the QA Contact for the bug.___ mesa-dev mailing list

[Mesa-dev] [Bug 109540] gen_builder_meta.hpp:51:117: error: no matching function for call to ‘cast(llvm::FunctionCallee)’

2019-03-07 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=109540 --- Comment #1 from Philip Meulengracht --- I haven't really had a chance to make a patch. But I've fixed this in my own fork, just add .getCallee() like this: Function* pFunc =