Re: [PATCH 2/3] hdlc: handle wrapped buffers

2010-04-17 Thread Marcel Holtmann
Hi Kristen, --- gatchat/gathdlc.c | 75 1 files changed, 40 insertions(+), 35 deletions(-) diff --git a/gatchat/gathdlc.c b/gatchat/gathdlc.c index c5c02cf..13e15a1 100644 --- a/gatchat/gathdlc.c +++ b/gatchat/gathdlc.c @@ -59,11

Re: [PATCH] ppp: implement MRU option

2010-04-22 Thread Marcel Holtmann
Hi Kristen, If the peer requests a MRU option, set the mtu for the network phase. When we are in link establishment phase, we should continue to behave as if no option has been set and the peer should use the default MRU. This option is required for the Huawei E160G modem. can you also

Re: [PATCH 1/3] atmodem: add signal strength support for huawei

2010-04-23 Thread Marcel Holtmann
Hi Kalle, Huawei doesn't support CIND indications, so use CSQ instead. But naturally the response from modem is not according to standard: is this true for all Huawei modems? ofonod[6401]: \r\n^BOOT:38645652,0,0,0,87\r\n ofonod[6401]: \r\n^RSSI:23\r\n Support for this format is not yet

Re: [PATCH 2/3] atmodem: add a huawei hack to check attachment status

2010-04-23 Thread Marcel Holtmann
Hi Kalle, Huawei doesn't seem to send CGREG notifications (or I wasn't able to properly configure the modem to do it), so add an ugly to hack poll the state with CGATT. shouldn't be polling AT+CGREG? the better way to do this? Regards Marcel ___

Re: [PATCH 3/3] huawei: add gprs context

2010-04-23 Thread Marcel Holtmann
Hi Kalle, Tested with Huawei E1552 HSDPA USB stick using a finnish Saunalahti prepaid SIM. --- plugins/huawei.c | 10 ++ 1 files changed, 10 insertions(+), 0 deletions(-) diff --git a/plugins/huawei.c b/plugins/huawei.c index 90fdcf0..fd1528f 100644 --- a/plugins/huawei.c

Re: [PATCH] Fix: transaction id usage in gisi/server.c

2010-04-23 Thread Marcel Holtmann
Hi Remi, Casting to or from void is not necessary. Oh, it is. If a struct sockaddr_pn structure is casted directly to struct sockaddr, gcc will issue alignment warning on ARM. The cast-align warning is a can of false positives. First that warning should probably not be enabled. It

Re: DUN client for oFono and BlueZ

2010-04-26 Thread Marcel Holtmann
Hi Gustavo, I'm starting the DUN Client implementation for the Linux Stack. DUN is the Bluetooth dial-up network profile. It makes possible share internet connection between two Bluetooth devices. That is my Google Summer of Code project for this year. Here follows a simple, and possible

Re: [PATCH] Add send_method_call to g_dbus

2010-04-26 Thread Marcel Holtmann
Hi Gustavo, Puting send_method_call and send_method_call_with_reply on g_dbus will avoid some code duplication and will make things easier mainly for the Bluetooth plugins (HFP, DUN, SAP) inside oFono. --- gdbus/gdbus.h | 12 gdbus/object.c | 81 +

Re: [PATCH 2/3] hdlc: handle wrapped buffers

2010-04-26 Thread Marcel Holtmann
Hi Kristen, So I like to see the patch series this way: 1) Handle ringbuffer wrapping in HDLC 2) Add recording support for HDLC 3) Add ACCM support to HDLC 4) Port PPP to use HDLC so I have done 1) now in a way that it is efficient and doesn't become the bottle-neck for PPP. What is the

Re: [PATCH 3/4] gatchat: Emit notification when command is sent to modem.

2010-04-29 Thread Marcel Holtmann
Hi Denis, +/*! + * Same as g_at_chat_send but with an ability to return a notification the + * moment the command finally leaves the queue and is submitted to lower + * layer. + * + * This is useful for cases where the modem's response time needs to be + * measured, assuming that

Re: [PATCH v2 1/6] atmodem: create struct atmodem_gprs

2010-04-30 Thread Marcel Holtmann
Hi Kalle, This is need to to provide more chat channels to atmodem gprs module. --- drivers/atmodem/gprs.c |7 --- drivers/atmodem/gprs.h | 29 + plugins/hso.c |8 +++- plugins/mbm.c |7 ++- plugins/palmpre.c |

Re: [PATCH v2 5/6] atmodem: add signal strength support for huawei

2010-04-30 Thread Marcel Holtmann
Hi Kalle, Huawei doesn't support CIND indications, instead it uses some non-standard RSSI messages: ofonod[6401]: \r\n^RSSI:23\r\n Add support for this to atmodem. please use ofono_netreg_strength_notify for this. The Huawei specific details with this stupid extra channel need to be

Re: [PATCH 3/4] gatchat: Emit notification when command is sent to modem.

2010-04-30 Thread Marcel Holtmann
Hi Denis, +/*! + * Same as g_at_chat_send but with an ability to return a notification the + * moment the command finally leaves the queue and is submitted to lower + * layer. + * + * This is useful for cases where the modem's response time needs to be + * measured,

Re: [PATCH 3/4] gatchat: Emit notification when command is sent to modem.

2010-05-04 Thread Marcel Holtmann
Hi Andrew, So I'm fine with the implementation but the name needs work. Can we use g_at_chat_send_with_submit_notify? Or maybe g_at_chat_send_full, similar to how GLib does it. Perhaps enabling submit_notification for a given command after it has been submitted with g_at_chat_send?

Re: [PATCH] add vid/pid for Dell 5541 and 5542

2010-05-04 Thread Marcel Holtmann
Hi Torgny, --- plugins/ofono.rules |4 1 files changed, 4 insertions(+), 0 deletions(-) patch has been applied. Thanks. Regards Marcel ___ ofono mailing list ofono@ofono.org http://lists.ofono.org/listinfo/ofono

Re: New TODO process

2010-05-19 Thread Marcel Holtmann
Hi Kalle, oFono project has been getting frequent requests for project status and roadmap details recently. In an effort to add some visibility to these aspects we decided to implement a new process. The idea is quite simple: identify the gaps in oFono features and try to

Re: [PATCH 2/9] Remove hack around hfp agent interface

2010-05-25 Thread Marcel Holtmann
Hi Gustavo, In the past we did this dirty hack to quickly fix HFP for the release, now fixing it in a proper way. --- drivers/hfpmodem/hfpmodem.h |1 - plugins/hfp.c | 12 +++- 2 files changed, 3 insertions(+), 10 deletions(-) The first two were

Re: [PATCH] huawei: follow sim state change notifications

2010-05-25 Thread Marcel Holtmann
Hi Kalle, With Huawei E1552 I got sim busy errors when I plugged in the modem and ofono was already running: May 24 17:02:04 tukki ofonod[7619]: AT+CRC=1\r May 24 17:02:04 tukki ofonod[7619]: \r\n+CME ERROR: SIM busy\r\n May 24 17:02:04 tukki ofonod[7619]: AT+CLIP=1\r May 24 17:02:04

Re: [PATCH v2] atmodem: fix crash during context deactivation

2010-05-26 Thread Marcel Holtmann
Hi Kalle, Ofono either crashed or busy looped with my Huawei E1552 3G modem when I tried to deactivate GPRS context. The reason was that gcd-chat was unreferenced already in setup_ppp() but the chat was still accessed later in at_gprs_deactivate_primary(). To fix the problem, change the

Re: [PATCH v4 1/2] atmodem: remove CGACT command

2010-05-26 Thread Marcel Holtmann
Hi Kalle, It's enough that we shutdown PPP, no need to send CGACT after that. Recommended by Denis. --- drivers/atmodem/gprs-context.c | 51 +--- 1 files changed, 16 insertions(+), 35 deletions(-) diff --git a/drivers/atmodem/gprs-context.c

Re: [PATCH 06/11] Made it possible to ask for status report via SendMessage method parameters. True=status report on, false=off.

2010-05-27 Thread Marcel Holtmann
Hi Denis, - { SendMessage,ss, , sms_send_message, + { SendMessage,ssb, , sms_send_message, G_DBUS_METHOD_FLAG_ASYNC }, { } }; I don't like this being an argument to

Re: [PATCH]enable-modem.c

2010-05-27 Thread Marcel Holtmann
Hi Daniele, here is the first simple example in c for enabling modem. This is my first time using glib, dbus and git so I hope not to have done too many mistakes... If you find it useful I can continue submitting the others I have, test/enable-modem.c | 116

Re: [RFC patches 02/13] sms_send_message: add a short roadmap

2010-05-28 Thread Marcel Holtmann
Hi Inaky, From: Inaky Perez-Gonzalez inaky.perez-gonza...@intel.com --- src/sms.c | 13 + 1 files changed, 13 insertions(+), 0 deletions(-) diff --git a/src/sms.c b/src/sms.c index 3a1cff0..594481e 100644 --- a/src/sms.c +++ b/src/sms.c @@ -398,6 +398,19 @@ static

Re: [RFC patches 03/13] documentation: add note about referencing standards

2010-05-28 Thread Marcel Holtmann
Hi Inaky, From: Inaky Perez-Gonzalez inaky.perez-gonza...@intel.com --- doc/standards.txt |8 1 files changed, 8 insertions(+), 0 deletions(-) create mode 100644 doc/standards.txt diff --git a/doc/standards.txt b/doc/standards.txt new file mode 100644 index

Re: [RFC patches 05/13] util.h: Add BUILD_BUG_ON() and friends for compile-time assert checking

2010-05-28 Thread Marcel Holtmann
Hi Inaky, From: Inaky Perez-Gonzalez inaky.perez-gonza...@intel.com These have been stolen from the Linux kernel source; come pretty handy to make build-time consistency checks and thus avoid run-time surprises. --- src/util.h | 29 + 1 files changed, 29

Re: [RFC patches 06/13] smutil.h: add missing header file dependencies

2010-05-28 Thread Marcel Holtmann
Hi Inaky, diff --git a/src/smsutil.h b/src/smsutil.h index 469a49e..356ec5d 100644 --- a/src/smsutil.h +++ b/src/smsutil.h @@ -18,6 +18,14 @@ * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA * */ +#ifndef __smsutil_h__ +#define __smsutil_h__ please

Re: [RFC patches 10/13] doc: explain debugging options to -d, add a pointer in -h to manpage

2010-05-28 Thread Marcel Holtmann
Hi Inaky, From: Inaky Perez-Gonzalez inaky.perez-gonza...@intel.com Modified HACKING and man page to have more formation on what are the debugging options and how to enable them. --- HACKING | 10 ++ doc/ofonod.8 |5 - src/main.c |4 +++- 3 files changed,

Re: [RFC patches 11/13] automake: fix installation of udev rules in VPATH builds

2010-05-28 Thread Marcel Holtmann
Hi Inaky, When the build directory is different than the source directory, we need to specify the source prefix to the original file we are copying. --- Makefile.am |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/Makefile.am b/Makefile.am index ed13346..31c157c

Re: [RFC patches 12/13] SMS: introduce message ID API

2010-05-28 Thread Marcel Holtmann
Hi Inaky, +/** + * Create a random UUID + * + * \param msg_id Descriptor + * + * \internal + * + * Crams the msg_id ID buffer with random 32-bit numbers; because we + * use a byte based buffer, we play the cast to guint32 trick (as that + * is what g_random_int() returns). + */ can we

Re: [PATCH 1/1] Huawei E176: Mark primary and secondary device at ofono.rules TODO: Fix sim_add detection, add E1552 idProduct to ofono.rules

2010-05-31 Thread Marcel Holtmann
Hi Kalle, I personally would prefer a solution which would dynamically probe the ports and choose them based on results. I believe modemmanager does something like this, but I haven't looked in detail. we should do something like auto-detect at some point, but there are limits in it. Regards

RE: [PATCH] Introduction of HACKING file in phonesim

2010-06-01 Thread Marcel Holtmann
Hi Yang, +When using ./configure --enable-maintainer-mode the automake scripts will +use the plugins directly from within the repository. This removes the need +to use make install when testing phonesim. The bootstrap-configure +automatically includes this option. + + Run phonesim in

Re: Huawei E1552 broken

2010-06-08 Thread Marcel Holtmann
Hi Kalle, I mentioned this briefly on irc, but I'll inform it here as well. This patch broke ofono support for my Huawei E1552: commit 6ab0b6f29acc8f6b2a5f3b94c02c405ee7318244 Author: Marcel Holtmann mar...@holtmann.org Date: Sun Jun 6 15:51:36 2010 -0700 Fix detection

Re: [RFC patches 10/13] doc: explain debugging options to -d, add a pointer in -h to manpage

2010-06-08 Thread Marcel Holtmann
Hi Inaky, From: Inaky Perez-Gonzalez inaky.perez-gonza...@intel.com Modified HACKING and man page to have more formation on what are the debugging options and how to enable them. --- HACKING | 10 ++ doc/ofonod.8 |5 - src/main.c |4 +++-

Re: [RFC patches 12/13] SMS: introduce message ID API

2010-06-08 Thread Marcel Holtmann
Hi Inaky, +/** + * Create a random UUID + * + * \param msg_id Descriptor + * + * \internal + * + * Crams the msg_id ID buffer with random 32-bit numbers; because we + * use a byte based buffer, we play the cast to guint32 trick (as that + * is what g_random_int()

Re: [PATCH] TODO: CBS CMAS

2010-06-09 Thread Marcel Holtmann
Hi Waldo, +Cell Broadcast System += + +- Support for Commercial Mobile Alert System (CMAS) according to 3GPP + 23.041, 3GPP 22.268 and ATIS/TIA J-STD-100 in addition to Earthquake + and Tsunami Warning Service (ETWS). oFono already reports ETWS messages + with CBS

Re: [PATCH 06/11] Made it possible to ask for status report via SendMessage method parameters. True=status report on, false=off.

2010-06-09 Thread Marcel Holtmann
Hi Inaky, I don't like this being an argument to SendMessage(). I think it needs to be exposed, but as a property instead. Is there a use case for setting this per message? I think majority of current phones either provide a global setting for this, or set it on by

Re: [PATCH 17/20] stkutil: Add the Event Download envelope builder

2010-06-09 Thread Marcel Holtmann
Hi Denis, /* Network Byte Order */ - unsigned int ipv4; + guint32 ipv4; Why? actually unsigned int on 64-bit has a different size than on 32-bit. However I prefer we use uint32_t and not the guint32 types. Regards Marcel

Re: Connman operator name empty with Huawei E1552

2010-06-10 Thread Marcel Holtmann
Hi Kalle, But now connman doesn't show the operator name Saunalahti anymore, the name property in connman Service is just empty: ./cmcc show cellular_244053111242822_huawei0_primarycontext1 AutoConnect: true Name: Nameservers: { 193.229.0.40 193.229.0.42 } Proxy: { Method=direct

Re: [PATCH] stkutil: convert text attributes to html

2010-06-16 Thread Marcel Holtmann
Hi Kristen, --- src/stkutil.c | 195 + src/stkutil.h | 21 ++ 2 files changed, 216 insertions(+), 0 deletions(-) diff --git a/src/stkutil.c b/src/stkutil.c index 8ac1dba..6244d03 100644 --- a/src/stkutil.c +++

Re: commit a7690918 huawei: Import huawei rules broke Huawei E1552

2010-06-22 Thread Marcel Holtmann
Hi Kalle, after commit a7690918 huawei: Import huawei rules my Huawei E1552 modem doesn't work anymore. The commit has this change: -SUBSYSTEMS==usb, ATTRS{bInterfaceNumber}==?*, ENV{OFONO_IFACE_NUM}=$attr{bInterfaceNumber} +SUBSYSTEMS==usb, ATTRS{bInterfaceNumber}==ff,

Re: Ofono and PPP

2010-06-22 Thread Marcel Holtmann
Hi Arun, I have managed to put together ofono and conn man for an at modem interface. The atmodem is working and here is the detail of a pdp context i created.

Re: [PATCH 1/2] stkutil: display text attributes as html

2010-06-24 Thread Marcel Holtmann
Hi Kristen, src/stkutil.c | 167 + src/stkutil.h | 32 +++ 2 files changed, 199 insertions(+), 0 deletions(-) diff --git a/src/stkutil.c b/src/stkutil.c index 6f072e7..73449e2 100644 --- a/src/stkutil.c +++

Re: Required suggestion to use third part code in oFono

2010-06-25 Thread Marcel Holtmann
Hi Satya, I have a third part OEM layer. According to the oFono architecture and standards can any one suggest the good approach to use the third part OEM layer @ oFono. oFono is licensed under GPL v2 and as long as your OEM layer is compatible with GPL v2 you can use it. Regards Marcel

Re: [SMS D-Bus 03/23] smutil.h: add missing header file dependencies

2010-06-25 Thread Marcel Holtmann
Hi Inaky, src/smsutil.h |9 + 1 files changed, 9 insertions(+), 0 deletions(-) diff --git a/src/smsutil.h b/src/smsutil.h index 66ef6f8..baa3eca 100644 --- a/src/smsutil.h +++ b/src/smsutil.h @@ -18,6 +18,14 @@ * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA

Re: Required suggestion to use third part code in oFono

2010-06-28 Thread Marcel Holtmann
Hi Satya, a gently reminder that this mailing list doesn't like top posting. In this case is it required to make the third part OEM layer as OPEN-SOURCE. Yes, every plugin, driver or extension of oFono has to be released as open source under a GPL compatible license. As in general you have to

Re: How about offering a raw way for SMS

2010-07-01 Thread Marcel Holtmann
Hi Caiwen, please don't piggy-back on other threads. For new questions/discussion, please start a brand new thread. Ofono stack encodes SMS before send it. User may need send some special SMS. Such as send a v-card via SMS. It need to add user data header to indicate it is a v-card. Ofono

Re: [PATCH 3/3] huawei: Remove call meter support for EM770

2010-07-01 Thread Marcel Holtmann
Hi Zhenhua, EM770W returns COMMAND NOT SUPPORT when we send AT+CCWE=1 to initialize call meter atom. So disable it. when re-doing patch 2/3 then please fix this properly so that this extra patch is not needed anymore. Regards Marcel ___ ofono

Re: Atmodem PPP Link establishment issues

2010-07-06 Thread Marcel Holtmann
Hi Arun, please try to compose proper emails and not just forward or reply to your own message to send it again. We are using atmodem plugin and are trying to get the PPP up and running. I am able to create and activate context, but the PPP link establishment seems to have issues. The

Re: [PATCH 1/2] gatppp: Check ppp instance before unref it

2010-07-06 Thread Marcel Holtmann
Hi Zhenhua, --- gatchat/gatppp.c |3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/gatchat/gatppp.c b/gatchat/gatppp.c index 1d41ded..d9b1627 100644 --- a/gatchat/gatppp.c +++ b/gatchat/gatppp.c @@ -446,6 +446,9 @@ void g_at_ppp_unref(GAtPPP *ppp) {

Re: [PATCH] test-server: Use cfmakeraw to set TTY raw mode

2010-07-06 Thread Marcel Holtmann
Hi Zhenhua, Use cfmakeraw to disable echoing and special characters processing. If we don't turn off ICRNL, TTY layer translates \r\n to \n\n. --- gatchat/test-server.c |8 +++- 1 files changed, 3 insertions(+), 5 deletions(-) diff --git a/gatchat/test-server.c

Re: [PATCH 11/15] emulator: Register mandatory AT command handlers

2010-07-07 Thread Marcel Holtmann
Hi Remi, +static void cfun_cb(GAtServerRequestType type, GAtResult *cmd, + gpointer user_data) +{ + struct ofono_emulator *e = user_data; + char buf[50]; + + switch (type) { + case G_AT_SERVER_REQUEST_TYPE_SUPPORT: +

RE: [PATCH 11/15] emulator: Register mandatory AT command handlers

2010-07-08 Thread Marcel Holtmann
Hi Remi, Marcel is right. Here I fake most AT commands like +CFUN to make DUN client happy. We don't need to power on/off real modem at all. See gatchat/test-server.c for similar implementation. That depends much what you're trying to achieve. If you only care about Dial-Up Networking,

Re: [PATCH 1/1] ppp: Add MAX_IPCP_FAILURE to avoid timeout quickly

2010-07-09 Thread Marcel Holtmann
Hi Zhenhua, We use IPCP NAK response to stall the progress of acquiring the client IP address from DHCP server. So we need to increase the max failure of NAKs in IPCP handshaking. --- gatchat/ppp_cp.c |8 ++-- gatchat/ppp_cp.h |2 +- gatchat/ppp_ipcp.c | 10 +-

Re: [PATCH 1/1] ppp: Add MAX_IPCP_FAILURE to avoid timeout quickly

2010-07-09 Thread Marcel Holtmann
Hi Zhenhua, We use IPCP NAK response to stall the progress of acquiring the client IP address from DHCP server. So we need to increase the max failure of NAKs in IPCP handshaking. --- gatchat/ppp_cp.c |8 ++-- gatchat/ppp_cp.h |2 +- gatchat/ppp_ipcp.c | 10 +-

Re: [SMS D-Bus 11/23] struct tx_queue_entry: add fields and destructor

2010-07-10 Thread Marcel Holtmann
Hi Inaky, Maybe we're not talking about the same thing. My workflow is git commit / git am git fetch git rebase git push gee, didn't see this -- well, if the rebase is changing the commit IDs, which it probably does, then you are breaking the commit history. Would depend on the

Re: [PATCH 4/4] make bluetooth.{c,h} a static library

2010-07-18 Thread Marcel Holtmann
Hi Gustavo, Makefile.am |7 +++ plugins/bluetooth.c |3 --- 2 files changed, 3 insertions(+), 7 deletions(-) why are we doing this exactly? If I missed it, please explain it again since I am not sure that I agree. Regards Marcel

Re: [PATCH 4/4] make bluetooth.{c,h} a static library

2010-07-18 Thread Marcel Holtmann
Hi Gustavo, Makefile.am |7 +++ plugins/bluetooth.c |3 --- 2 files changed, 3 insertions(+), 7 deletions(-) why are we doing this exactly? If I missed it, please explain it again since I am not sure that I agree. We are doing this for the DUN daemon. As

Re: [PATCH 4/4] make bluetooth.{c,h} a static library

2010-07-18 Thread Marcel Holtmann
Hi Gustavo, Makefile.am |7 +++ plugins/bluetooth.c |3 --- 2 files changed, 3 insertions(+), 7 deletions(-) why are we doing this exactly? If I missed it, please explain it again since I am not sure that I agree. We are doing this for the

Re: Reg. MMS Support in oFono

2010-07-20 Thread Marcel Holtmann
Hi Satya, I have one doubt regarding MMS features. In previous mail list ofono team mention that MMS is not supported by oFono, these belong in a separate daemon. Related link is as follows : http://lists.ofono.org/pipermail/ofono/2010-June/002672.html I thought it is ConnMan.

Re: About the TDS-CDMA support of oFono

2010-07-21 Thread Marcel Holtmann
Hi Zheng, quick reminder that it is NOT okay to do top posting. Please use proper mailing list netiquette. Top posting emails will be otherwise ignored in the future. OK, Thank you. We are going to buy Huawei ET128 to use oFono in the TD-SCDMA environment n China. I will share some info to

Re: Howto about Qt QML and Ofono

2010-07-22 Thread Marcel Holtmann
Hi Joao, http://matgnt.wordpress.com/2010/07/19/qt-ofono-d-bus-and-qml-part-1/ http://matgnt.wordpress.com/2010/07/19/qt-ofono-d-bus-and-qml-part-2/ http://matgnt.wordpress.com/2010/07/19/qt-ofono-d-bus-and-qml-part-3/ I hope this helps people out there to create cool new phone

Re: [PATCH 1/2] stkutil: convert img to xpm

2010-07-22 Thread Marcel Holtmann
Hi Kristen, Also, XPM is pretty flexible here, there's no need to use 0-9 digits only. For instance, you can do two look up tables, one for images with LUTs up to 64 entries and another for LUTs with more. E.g. a-za-z...@$ and 'aa ab ac .. pp' or something like that. I realize

Re: [PATCH] watch: Free service data in service_reply

2010-07-23 Thread Marcel Holtmann
Hi Zhenhua, Avoid the memory leak of server_data. --- gdbus/watch.c |5 - 1 files changed, 4 insertions(+), 1 deletions(-) do me a favor and post this to linux-blueto...@vger.kernel.org as well for the Bluetooth guys to review. After that I can take of applying it to all trees.

Re: CDMA support in Ofono

2010-07-25 Thread Marcel Holtmann
Hi Steven, Currently, Ofono only support GSM/UTMS, is there any plan to support CDMA/EVDO and when will Ofono support CDMA? Any suggestions or ideas about supporting CDMA will be appreciated . so CDMA and also EVDO is on the long-term feature list of oFono. Right now the focus is clearly

Re: USSD support in ofono-0.25

2010-07-30 Thread Marcel Holtmann
Hi, Is USSD support is available and functional in ofono latest version? yes it is. I found the support in SupplementaryServices interface and I am able to read the properties from this interface, but I am getting error when try to call Initiate method, from the definition of Initiate

Re: USSD support in ofono-0.25

2010-07-30 Thread Marcel Holtmann
Hi, a gentle reminder that we are not allowing top-posting on this mailing list. Don't do it. supplementaryservices-api.txt is not available in doc folder in ofono-0.25.tar.gz ,is there any other location to find it? it is in the GIT repository, but was never included in the

Re: Add CDMA/EVDO into TODO

2010-08-02 Thread Marcel Holtmann
Hi Penghuo, I am not fully against submitting patches as attachments, but if you do expect reviews, then we do prefer inline patches. I would advise to start using git send-email for patch submission. From 9af61f4d2546ff28a8b1ed9546c41f5f3c945f5a Mon Sep 17 00:00:00 2001 From: Pengzhuo wang

Re: [SMS D-Bus v5 14/17] automake: fix generation of symlinks for headers

2010-08-05 Thread Marcel Holtmann
Hi Inaky, When running 'make distcheck' from a vpath build directory (ie: one that is not where the source lives), the target headers in include/ofono are not generated properly due to a typo in the Makefile.am, that is using _srcdir where _buildir should be being used. --- Makefile.am |

Re: [PATCH] add default property setter for modemconf

2010-08-09 Thread Marcel Holtmann
Hi Leaf, I was trying to run ofono for a huawei usb modem on my meego netbook, but the udev on netbook seems not work for ofono, so that I've to mannualy write settings in modem.conf. Huawei driver needs two device, pcui modem, and I can't specify them by either Interface Device in

Re: [PATCH v2 1/1] sim: Read EFust and EFest

2010-08-11 Thread Marcel Holtmann
Hi Yang, --- src/sim.c | 83 ++- src/simutil.h | 108 + 2 files changed, 189 insertions(+), 2 deletions(-) diff --git a/src/sim.c b/src/sim.c index d2ed780..9fc1bc6 100644 ---

Re: [PATCH 0/10] Unregister AT notifiers when removing drivers

2010-08-12 Thread Marcel Holtmann
Hi Zhenhua, This series unregister AT notifiers in removing various AT modem drivers when modem goes to offline mode. Please review them. just a heads up here that Denis and I talked about this. And we are going to fix this inside GAtChat in the background for you. Trying to fix this single

Re: [PATCH 04/16] emulator: Add APIs to send GAtServer result

2010-08-12 Thread Marcel Holtmann
Hi Zhenhua, Defines APIs to send final/intermediate/unsolicited result to DUN client. --- include/emulator.h |2 ++ src/emulator.c | 28 src/ofono.h| 11 +++ 3 files changed, 41 insertions(+), 0 deletions(-) diff --git

Removal of modemconf plugin

2010-08-12 Thread Marcel Holtmann
Hello, so the modemconf plugin seemed to be a good idea at the time I wrote it, but lately is causes more issues and confusion than it solves. So we will be removing this plugin shortly. For this to happen the following dependencies need to be solved first: 1) Move phonesim plugin over

Re: Startup sequence for Online / offline mode

2010-08-12 Thread Marcel Holtmann
Hi Waldo, Modem drivers that support Online / offline mode default to offline when oFono loads them. Which component is responsible for calling oFono and switch the modem to online mode? Will that component be part of MeeGo? This feature is still highly experimental and not all of the

RE: Startup sequence for Online / offline mode

2010-08-12 Thread Marcel Holtmann
Hi Waldo, Modem drivers that support Online / offline mode default to offline when oFono loads them. Which component is responsible for calling oFono and switch the modem to online mode? Will that component be part of MeeGo? This feature is still highly experimental and not all of the

Re: Startup sequence for Online / offline mode

2010-08-13 Thread Marcel Holtmann
Hi Pekka, My understanding was that the Online state would be initialized by a component like Telepathy-ring or some sort of system management daemon to ensure that the dialer is up and running and able to accept calls before the Online state is entered. If ConnMan initializes the

Re: Removal of modemconf plugin

2010-08-13 Thread Marcel Holtmann
Hi Kalle, Using special udev rules for special devices (in conjunction with the oFono auto-detection rule) make the process of setting up oFono for the system integrator a lot simpler. No manual configuration file patching anymore. Just installation of an additional udev rule. The

Re: Removal of modemconf plugin

2010-08-13 Thread Marcel Holtmann
Hi Pekka, The open here is the ISI modem detection, but this should be clearly done via a Phonet plugin. And also the N900 specific case inside modemconf is just wrong. This needs to be fixed and just auto-detected via Phonet or maybe just via RTNL directly. Once we get proper

Re: Enabling/disabling the GPS part of a Huawei EM770W

2010-08-13 Thread Marcel Holtmann
Hi Florian, is it possible to enable / disable the GPS part of a Huawei EM770W 3G modem through a DBUS command? It is done with the command AT^WPDGP and AT^WPEND on the modem (tested it on PCUI port). Or is it possible to send generic AT commands through DBUS? we know that we need some

Re: Query on Ofono Architecture for multiple RATs

2010-08-13 Thread Marcel Holtmann
Hi Naresh, Lets suppose that I have a modem which implements various radio access technologies like CDMA, WCDMA, GSM, LTE, etc. The questions I have are: - How should this modem look like inside Ofono and be exposed outside of Ofono? - Do you expect to have separate modem drivers for

RE: [PATCH 10/16] gprs: Add ofono_gprs_create_context method

2010-08-13 Thread Marcel Holtmann
Hi Zhenhua, DUN server may create one primary context if none of contexts existing on the GPRS atom. so Denis and I had a chat about this. And we agreed that oFono core should just create one Internet context if none exists. If the plugin driver registers a GPRS atom, we should just

RE: [PATCH 04/16] emulator: Add APIs to send GAtServer result

2010-08-13 Thread Marcel Holtmann
Hi Zhenhua, Defines APIs to send final/intermediate/unsolicited result to DUN client. --- include/emulator.h |2 ++ src/emulator.c | 28 src/ofono.h| 11 +++ 3 files changed, 41 insertions(+), 0 deletions(-) diff --git

Re: Add 3GPP2 relative specifications

2010-08-16 Thread Marcel Holtmann
Hi Caiwen, Add 3GPP2 relative specifications. --- diff --git a/doc/standards.txt b/doc/standards.txt index a7eaa5e..1b8c23f 100644 --- a/doc/standards.txt +++ b/doc/standards.txt @@ -81,3 +81,88 @@ technology specific features (e.g. UMTS/CDMA). -

Re: [PATCHv2 1/7] stemodem: Add support for STK by including MBM implementation.

2010-08-16 Thread Marcel Holtmann
Hi Sjur, Changes: o Use MBM stk driver implementation (avoid copying code). Note: stemodm.h has to declare the mbm_stk_init/exit functions because importing mbmdriver causes compile errors due to duplicated declarations. drivers/stemodem/stemodem.c |2 ++

Re: [PATCHv2 2/7] atmodem: Enable STE usage of AT*EPEV and AT*EPEE for PIN handling.

2010-08-16 Thread Marcel Holtmann
Hi Sjur, drivers/atmodem/sim.c |9 ++--- 1 files changed, 6 insertions(+), 3 deletions(-) diff --git a/drivers/atmodem/sim.c b/drivers/atmodem/sim.c index eb40ad7..8e7c403 100644 --- a/drivers/atmodem/sim.c +++ b/drivers/atmodem/sim.c @@ -567,10 +567,12 @@ static void

Re: [PATCHv2 4/7] stemodem: Add Radio Settings to STE Modem

2010-08-16 Thread Marcel Holtmann
Hi Sjur, Changes since last patch set: o Moved updates to plugins/ste to separate patch. o Updated error handling. o Style issues. Makefile.am |4 +- drivers/stemodem/radio-settings.c | 223 + drivers/stemodem/stemodem.c

Re: [PATCHv2 4/7] stemodem: Add Radio Settings to STE Modem

2010-08-16 Thread Marcel Holtmann
Hi Sjur, Changes since last patch set: o Moved updates to plugins/ste to separate patch. o Updated error handling. o Style issues. Makefile.am |4 +- drivers/stemodem/radio-settings.c | 223 +

Re: [PATCH v3 1/7] plugins/ste: Include STK support from MBM driver.

2010-08-16 Thread Marcel Holtmann
Hi Sjur, ... The build system builds the plugins properly and you can cross reference modem drivers from your modem plugin without any problems. Simply refering to MBM driver from ste.c plugins/ste.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git

Re: [PATCH v3 2/7] plugins/ste: SIM - STE registers as MBM to utilize mbm quirks.

2010-08-16 Thread Marcel Holtmann
Hi Sjur, do we really wanna create another vendor quirk here. If both modems behave identical then just pass OFONO_VENDOR_MBM in the SIM atom registration and be done with it. Re-use the MBM quirk rather than adding STE quirks in atmodem/sim.c --- plugins/ste.c |2 +- 1 files

Re: [PATCH v4 1/7] plugins/ste: Include STK support from MBM driver.

2010-08-16 Thread Marcel Holtmann
Hi Sjur, ... The build system builds the plugins properly and you can cross reference modem drivers from your modem plugin without any problems. Simply refering to MBM driver from ste.c one minor nitpick here. Can you please not squeeze this in between GPRS and GPRS Context atoms.

Re: [PATCH v4 4/7] stemodem: Add Radio Settings to STE Modem

2010-08-16 Thread Marcel Holtmann
Hi Sjur, Makefile.am |3 +- drivers/stemodem/radio-settings.c | 225 + drivers/stemodem/stemodem.c |2 + drivers/stemodem/stemodem.h |2 + 4 files changed, 231 insertions(+), 1 deletions(-) create mode

Re: [PATCH v4 2/7] plugins/ste: SIM - STE registers as MBM to utilize mbm quirks.

2010-08-16 Thread Marcel Holtmann
Hi Sjur, ... do we really wanna create another vendor quirk here. If both modems behave identical then just pass OFONO_VENDOR_MBM in the SIM atom registration and be done with it. Re-use the MBM quirk rather than adding STE quirks in atmodem/sim.c --- plugins/ste.c |2 +- 1 files

Re: [PATCH v4 3/7] stemodem: Add polling for SIM ready.

2010-08-16 Thread Marcel Holtmann
Hi Sjur, Interim solution until support for SIM 'ready' notification is supported. --- Changes: o Fixed style issues (tabs and newlines) plugins/ste.c | 55 --- 1 files changed, 52 insertions(+), 3 deletions(-) diff --git

Re: [PATCH v4 6/7] stemodem: Use RTNL for creating CAIF interface

2010-08-16 Thread Marcel Holtmann
Hi Sjur, CAIF in Linux kernel 2.6.35 must use RTNL for configuring CAIF interfaces. --- drivers/stemodem/gprs-context.c | 51 +-- drivers/stemodem/rtnl.c | 318 +++ drivers/stemodem/rtnl.h | 24 +++ 3 files changed, 380

Re: [PATCH v4 7/7] plugins/ste: Use SOCK_STREAM for CAIF and enable interface specification.

2010-08-16 Thread Marcel Holtmann
Hi Sjur, plugins/modem.conf |5 + plugins/modemconf.c |1 + plugins/ste.c | 20 +++- 3 files changed, 25 insertions(+), 1 deletions(-) please don't intermix modemconf and STE plugin changes. I need two separate patches for this. Regards Marcel

RE: Removal of modemconf plugin

2010-08-17 Thread Marcel Holtmann
Hi Yang, What about dual mode modems that with two different serial ports? e.g. a modem support both GSM and CDMA, there is a serial port For GSM, and there is a serial another for CDMA. Why not keep both udev and modemconf plug-in. It remains for the user To decide which way to

RE: Removal of modemconf plugin

2010-08-17 Thread Marcel Holtmann
Hi Pengzhuo, a gentle reminder that this mailing list doesn't allow top posting, please follow the netiquette for open source mailing lists. What about dual mode modems that with two different serial ports? e.g. a modem support both GSM and CDMA, there is a serial port For GSM,

Re: [PATCH v5 1/8] plugins/ste: SIM - STE registers as MBM to utilize mbm quirks.

2010-08-17 Thread Marcel Holtmann
Hi Sjur, --- Change: This time the right line is hopefully being edited. plugins/ste.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) patch has been applied. Thanks. Regards Marcel ___ ofono mailing list ofono@ofono.org

Re: [PATCH v5 5/8] plugins/ste: Add Radio-Settings

2010-08-17 Thread Marcel Holtmann
Hi Sjur, --- drivers/stemodem/radio-settings.c |5 + plugins/ste.c |2 ++ 2 files changed, 7 insertions(+), 0 deletions(-) your diffstat is wrong here. Please check the tools you use to create them. Patch has been applied. Regards Marcel

Re: [PATCH v5 4/7] stemodem: Add Radio Settings to STE Modem

2010-08-17 Thread Marcel Holtmann
Hi Sjur, --- Changes: o Changed order of files in Makefile o Fixed missing empty line in copyright o Formatted enum better o Removed default is switches o Removed ste in function names Makefile.am |2 + drivers/stemodem/radio-settings.c | 230

<    1   2   3   4   5   6   7   8   9   10   >