Re: New kwalitee test, has_changes

2005-09-26 Thread Michael Graham
Collecting any sort of coverage data is a complete bitch. Let me just say right now that doing it across _all_ of CPAN is flat out impossible. It's impossible. Is it possible to use PPI to count the number of tests in a module's test suite? More than 5 tests would probably mean the author

Re: New kwalitee test, has_changes

2005-09-25 Thread Adam Kennedy
It's impossible. Quite. I believe the only way is for the author to do the Devel::Cover dance and forward the results. It also distributes the workload out to where it should be done. Since it's an optional step that has no direct bearing on the functionality of the module, it's a sign

Re: New kwalitee test, has_changes

2005-09-25 Thread Adam Kennedy
Paul Johnson wrote: On Fri, Sep 23, 2005 at 12:06:43PM +0200, Thomas Klausner wrote: Hi! On Fri, Sep 23, 2005 at 12:54:42PM +1000, Adam Kennedy wrote: Collecting any sort of coverage data is a complete bitch. Let me just say right now that doing it across _all_ of CPAN is flat out

Re: New kwalitee test, has_changes

2005-09-23 Thread Adam Kennedy
Michael Graham wrote: As I was downloading the newest version of Devel::Cover this morning, I pondered on the concept of 1 Kwalitee point for coverage = 80%, and another for 100%, and how absolutely impossible it would be to set out to establish these points for all the modules on CPAN. But it

Re: New kwalitee test, has_changes

2005-09-23 Thread Thomas Klausner
Hi! On Fri, Sep 23, 2005 at 12:54:42PM +1000, Adam Kennedy wrote: Collecting any sort of coverage data is a complete bitch. Let me just say right now that doing it across _all_ of CPAN is flat out impossible. It's impossible. I completly agree. Now, if somebody sets up a system to

Re: New kwalitee test, has_changes

2005-09-23 Thread David Landgren
Adam Kennedy wrote: Michael Graham wrote: [...] But I think a more useful measure of kwalitee would be a 20%-30% coverage test. Something like that sounds much more reasonable than a high number. Of course, if you've seen the first third of the PPI talk you realise we still have all the

Re: New kwalitee test, has_changes

2005-09-22 Thread Paul Johnson
On Wed, Sep 21, 2005 at 10:28:33PM -0400, James E Keenan wrote: David Landgren wrote: demerphq wrote: You miss my point. Whether the code be cross-platform or cross-version, you need to aggregate the coverage results from all the environments your code is designed to run on. How is

Re: New kwalitee test, has_changes

2005-09-22 Thread demerphq
On 9/22/05, Paul Johnson [EMAIL PROTECTED] wrote: On Wed, Sep 21, 2005 at 04:26:27PM +0200, demerphq wrote: And, it doesnt help that something about DC breaks the defined operator when dealing with overloaded objects. (yeah, he did say the code was alpha quality :-) Bug reports,

Re: New kwalitee test, has_changes

2005-09-22 Thread Michael Graham
As I was downloading the newest version of Devel::Cover this morning, I pondered on the concept of 1 Kwalitee point for coverage = 80%, and another for 100%, and how absolutely impossible it would be to set out to establish these points for all the modules on CPAN. But it would be Good. I

Re: New kwalitee test, has_changes

2005-09-21 Thread David Cantrell
demerphq wrote: On 9/15/05, David Landgren [EMAIL PROTECTED] wrote: As I was downloading the newest version of Devel::Cover this morning, I pondered on the concept of 1 Kwalitee point for coverage = 80% ... I have to wonder about how you handle modules that have code that is Perl version

Re: New kwalitee test, has_changes

2005-09-21 Thread David Landgren
David Cantrell wrote: demerphq wrote: On 9/15/05, David Landgren [EMAIL PROTECTED] wrote: As I was downloading the newest version of Devel::Cover this morning, I pondered on the concept of 1 Kwalitee point for coverage = 80% ... I have to wonder about how you handle modules that have code

Re: New kwalitee test, has_changes

2005-09-21 Thread Thomas Klausner
Hi! On Wed, Sep 21, 2005 at 11:58:36AM +0200, David Landgren wrote: To me, this is a mark of Quality. It would be good to have it as a Kwalitee metric, but I see no easy way. The simplest way I can see would be to have a META.yml key that contains a URI to the HTML D::C report. I would

Re: New kwalitee test, has_changes

2005-09-21 Thread Sébastien Aperghis-Tramoni
Selon Thomas Klausner [EMAIL PROTECTED]: Hi! On Wed, Sep 21, 2005 at 11:58:36AM +0200, David Landgren wrote: To me, this is a mark of Quality. It would be good to have it as a Kwalitee metric, but I see no easy way. The simplest way I can see would be to have a META.yml key that

Re: New kwalitee test, has_changes

2005-09-21 Thread demerphq
On 9/21/05, David Landgren [EMAIL PROTECTED] wrote: I know I had my eyes opened by Devel::Cover. I thought I had pretty good coverage in Regexp::Assemble. In fact I had about 60%. I lifted it up to 100% statement coverage (some branching and conditional paths are never taken, but they are

Re: New kwalitee test, has_changes

2005-09-21 Thread David Landgren
demerphq wrote: On 9/21/05, David Landgren [EMAIL PROTECTED] wrote: I know I had my eyes opened by Devel::Cover. I thought I had pretty good coverage in Regexp::Assemble. In fact I had about 60%. I lifted it up to 100% statement coverage (some branching and conditional paths are never taken,

Re: New kwalitee test, has_changes

2005-09-21 Thread James E Keenan
David Landgren wrote: demerphq wrote: You miss my point. Whether the code be cross-platform or cross-version, you need to aggregate the coverage results from all the environments your code is designed to run on. How is this done?

Re: New kwalitee test, has_changes

2005-09-16 Thread Thomas Klausner
Hi! On Fri, Sep 16, 2005 at 09:23:10AM +1000, Adam Kennedy wrote: Yeah, something like that. Changes, for a suitably flexible value of Changes I implemented this in CPANTS. It will be in the next release (tomorrow), results should be available on Sunday morning. -- #!/usr/bin/perl

Re: New kwalitee test, has_changes

2005-09-16 Thread Smylers
Thomas Klausner writes: On Thu, Sep 15, 2005 at 11:52:00AM +1000, Adam Kennedy wrote: Rather than do any additional exploding, I'd like to propose the additional kwalitee test has_changes. I've noticed that a percentage (5-10%) of dists don't have a changes file, so it can be hard to

Re: New kwalitee test, has_changes

2005-09-15 Thread Christopher H. Laco
Adam Kennedy wrote: Rather than do any additional exploding, I'd like to propose the additional kwalitee test has_changes. I've noticed that a percentage (5-10%) of dists don't have a changes file, so it can be hard to know whether it's worth upgrading, or more importantly which version to add

Re: New kwalitee test, has_changes

2005-09-15 Thread Gábor Szabó
On 9/15/05, Christopher H. Laco [EMAIL PROTECTED] wrote: Would this look for Change OR ChangeLog? Both seem to be popular on CPAN. And some people put their changelog in the README. Gabor

Re: New kwalitee test, has_changes

2005-09-15 Thread David Golden
Ricardo SIGNES wrote: * Christopher H. Laco [EMAIL PROTECTED] [2005-09-15T08:23:57] Would this look for Change OR ChangeLog? Both seem to be popular on CPAN. ...and some modules have a HISTORY or CHANGES section of POD, and DBI has DBI::Changes. Though, as with pod and pod coverage

Re: New kwalitee test, has_changes

2005-09-15 Thread demerphq
On 9/15/05, David Landgren [EMAIL PROTECTED] wrote: As I was downloading the newest version of Devel::Cover this morning, I pondered on the concept of 1 Kwalitee point for coverage = 80%, and another for 100%, and how absolutely impossible it would be to set out to establish these points for

Re: New kwalitee test, has_changes

2005-09-15 Thread chromatic
On Thu, 2005-09-15 at 16:00 +0200, David Landgren wrote: As I was downloading the newest version of Devel::Cover this morning, I pondered on the concept of 1 Kwalitee point for coverage = 80%, and another for 100%, and how absolutely impossible it would be to set out to establish these

Re: New kwalitee test, has_changes

2005-09-15 Thread James E Keenan
Ricardo SIGNES wrote: * Christopher H. Laco [EMAIL PROTECTED] [2005-09-15T08:23:57] Would this look for Change OR ChangeLog? Both seem to be popular on CPAN. ...and some modules have a HISTORY or CHANGES section of POD, and DBI has DBI::Changes. Good point. Modules created with