D19306: send a signal over dbus when the wrong password is provided

mart created this revision. mart added reviewers: Plasma, jgrulich. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. Herald added 1 blocking reviewer(s): jgrulich. mart requested review of this revision. REVISION SUMMARY On Plasma Mobile we can't actually show a qwidgets

Monday meeting notes for 25/2/2019

ven just a review, is kinda stuck there, this week i'll probably kidnap someone to figure out things) -- Marco Martin

D18644: GlobalDrawerActionItem: properly reference icon by using group property.

mart added a comment. ping? REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D18644 To: pwegner, #kirigami, mart Cc: plasma-devel, dkardarakos, apol, davidedmundson, mart, hein

D18716: Add an ActionTextField component

mart added a comment. it''s lmost perfect, just a little point on the icon loading, then is good to go INLINE COMMENTS > MultipleColumnsGallery.qml:61 > Controls.Label { > -anchors.horizontalCenter: parent.horizontalCenter > +Layout.alignment:

D19203: ColumnView and partial C++ refactor of PageRow

mart created this revision. mart added a reviewer: Kirigami. Herald added a project: Kirigami. Herald added a subscriber: plasma-devel. mart requested review of this revision. REVISION SUMMARY ColumnView is a container component which encapsulates most of the logic from PageRow (minus the

D19044: [InlineMessage] Do not draw shadows around the message

mart added a comment. - whole InlineMessage should be moved into templates - background: item should be deleted such that it doesn't have any background at all (lines from 123 to 173) - in controls, an InlineMessage.qml is still present, and will be import "templates" as T

D19179: Use PointingHand when hovering links in Label

mart accepted this revision. mart added a comment. This revision is now accepted and ready to land. actually the hoverhandler seems not to be adapt for the job, so go for it REPOSITORY R858 Qt Quick Controls 2: Desktop Style REVISION DETAIL https://phabricator.kde.org/D19179 To: leinir,

D19179: Use PointingHand when hovering links in Label

mart added a comment. that's the thing in question https://doc.qt.io/qt-5/qml-qtquick-hoverhandler.html REPOSITORY R858 Qt Quick Controls 2: Desktop Style REVISION DETAIL https://phabricator.kde.org/D19179 To: leinir, ngraham, apol, mart, #kirigami Cc: filipf, plasma-devel, jraleigh,

D19179: Use PointingHand when hovering links in Label

mart added a comment. ideally, this should use pointer handlers (which sadly they are 5.12 only) it may use preprocessing how we sometimes did for menus for instance REPOSITORY R858 Qt Quick Controls 2: Desktop Style REVISION DETAIL https://phabricator.kde.org/D19179 To: leinir,

D19179: Use PointingHand when hovering links in Label

mart added a comment. I'm very hesitant to add a MouseArea in evert single Label REPOSITORY R858 Qt Quick Controls 2: Desktop Style REVISION DETAIL https://phabricator.kde.org/D19179 To: leinir, ngraham, apol, mart, #kirigami Cc: filipf, plasma-devel, jraleigh, GB_2, ragreen, Pitel,

D19044: [InlineMessage] Do not draw shadows around the message

mart added a comment. In D19044#414530 , @ngraham wrote: > In D19044#414479 , @mart wrote: > > > -1 > > this has to be done at most for the desktop style and the desktop style only > > >

D18938: Show assigned shortcut in drawer action delegates

mart requested changes to this revision. mart added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > GlobalDrawerActionItem.qml:102 > +Layout.alignment: Qt.AlignVCenter | Qt.AlignRight > +visible: modelData.__shortcut.enabled &&

D19044: [InlineMessage] Do not draw shadows around the message

mart requested changes to this revision. mart added a comment. This revision now requires changes to proceed. -1 this has to be done at most for the desktop style and the desktop style only REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D19044 To: filipf, #vdg,

Re: Breeze Dark theme question ?

item to be used > in said context. It seems Breeze Dark just inherits the SVG from Breeze > and as such it is not "fromCurrentTheme" and not displayed. right, so since breeze dark/light is just a color scheme, fromCurrentTheme will always be false.. maybe they should have a copy of that image -- Marco Martin

Notes for 18/2/2019 monday meeting

haves like qwidgets on mouse click: left button click does pgup/pgdown, middle button does absolute positioning KWin: * experiments to modify D18818 approach to how martin said, seems super tricky -- Marco Martin

D18716: Add a TextField component

mart added inline comments. INLINE COMMENTS > mart wrote in TextField.qml:106 > text will go under both buttons, in order to avoid that, probably anchors > should be added to the TextField's contentItem to make space for the buttons. err, TextField is not a Control, right. so, it should set

D18716: Add a TextField component

mart added a comment. also, the name should possibily not conflict with QQC2 TextField, like ActionTextField or something like that. INLINE COMMENTS > TextField.qml:21 > +import QtQuick 2.5 > +import QtQuick.Controls 2.1 > +import org.kde.kirigami 2.4 as Kirigami always namespace the

D18645: BasicListItem: use specified tint color when transparency is 0

mart added a comment. I think i'll introduce an heuristic to analyze the image and decide if it's monochrome and drop all this transparent nonsense (would make it a bit inefficient as it wuld need to read pixels colors in software but may be justified). locally i was trying with Shannon

Moday meeting notes for 11/2/2019

ct kirigami version) and fixed many issues they had * merged the big titledelegate branch * hide swipelistitem handles when all actions are invisible * fixed some icon coloring issues * always show the back button on layers, also on mobile * navigation buttons don't disappear anymore when the window is

D18571: Add "apply on double-click" feature to most other recent ported KCMs

mart added a comment. also, as the principle of the feature i agree with Pino I don't recall any non instant apply dialog anywhere which becomes magically instant apply on doubleclick REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D18571 To: ngraham, #vdg,

D18571: Add "apply on double-click" feature to most other recent ported KCMs

mart requested changes to this revision. mart added a comment. This revision now requires changes to proceed. if this is going to be used, it should be in the base component (where you can safely assume that kcm.save will exist) and have it as mandatory for every kcm REPOSITORY R119

D18645: BasicListItem: use specified tint color when transparency is 0

mart added a comment. can you try on kirigami master? i did a similar thing the other day with commit 015e1d0ac19e4 REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D18645 To: pwegner,

D18716: Add a TextField component

mart requested changes to this revision. mart added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > TextField.qml:74 > + */ > +property QtObject rightAction > + I would like those to actually be lists as we do have use cases for more than one icon

D18796: [PassiveNotification] Don't start timer until window has focus

mart requested changes to this revision. mart added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > PassiveNotification.qml:65 > +//be working with multiple windows at once > +timer.running = Qt.binding(function() { > +return

D18640: Reset tooltip delegate label height to defaults

mart added a comment. In D18640#403147 , @broulik wrote: > Supposedly fixed in Qt 5.12.1? https://bugreports.qt.io/browse/QTBUG-71684 with 5.12.1 the patch woudn't be necessary anymore? REPOSITORY R119 Plasma Desktop REVISION DETAIL

D18640: Reset tooltip delegate label height to defaults

mart added inline comments. INLINE COMMENTS > ngraham wrote in main.qml:227 > If we do end up going with this patch, I'd like to see comments explaining > why these are set to `undefined`. look at https://doc.qt.io/qt-5/properties.html at the RESET function (basically, properties that provide

D18801: CMakeLists: Fix bfd.h include path on windows

mart added a comment. needs longer commit message REPOSITORY R871 DrKonqi REVISION DETAIL https://phabricator.kde.org/D18801 To: patrickelectric, davidedmundson, tcanabrava, ngraham Cc: mart, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed,

D18802: Fix pragma once problem with process class

mart added a comment. needs better commit message REPOSITORY R871 DrKonqi REVISION DETAIL https://phabricator.kde.org/D18802 To: patrickelectric, davidedmundson, tcanabrava, ngraham Cc: mart, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed,

D18716: Add a SearchField component

mart added a comment. In D18716#404852 , @ognarb wrote: > Interesting, but I have some question before I start implementing. > > - Do you have an example for a left action? right now only web browsers url bars come to mind, so perhaps

Re: Monday meeting minutes for 2019-02-04 (week 6)

branch. on my side: * continued the custom toolbar work, turns out very not trivial D18619 * continued work on c++ pagerow partial rewrite * this week at the plasma mobile sprint -- Marco Martin

Re: Plasma and Qt5.12

On Tue, Feb 5, 2019 at 12:47 PM David Edmundson wrote: > > We've agreed that we want Plasma5.16 to depend on Qt5.12. > > Are there any objections to switching master to depend on this? none on my side, go go go :) -- Marco Martin

D18779: Better window title display

mart added a comment. +1 REPOSITORY R111 KSysguard Library REVISION DETAIL https://phabricator.kde.org/D18779 To: broulik, #plasma, #vdg Cc: mart, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D18716: Add a SearchField component

mart requested changes to this revision. mart added a comment. This revision now requires changes to proceed. If we are going to have a specialized line edit, I think it shouldn't be specific for search, but be a common component of things that we have to boilerplate too often as they are

D18619: property to override the globaltoolbar style of a single page

mart added a comment. F6576894: Screenshot_20190130_171634.png REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D18619 To: mart, #kirigami, #vdg Cc: plasma-devel, dkardarakos, apol, davidedmundson, mart, hein

D18619: property to override the globaltoolbar style of a single page

mart added a comment. F6576892: Screenshot_20190130_171551.png REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D18619 To: mart, #kirigami, #vdg Cc: plasma-devel, dkardarakos, apol, davidedmundson, mart, hein

D18619: property to override the globaltoolbar style of a single page

mart added a comment. F6576890: vokoscreen-2019-01-30_17-08-42.mp4 REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D18619 To: mart, #kirigami, #vdg Cc: plasma-devel, dkardarakos, apol, davidedmundson, mart, hein

D18619: property to override the globaltoolbar style of a single page

mart created this revision. mart added reviewers: Kirigami, VDG. Herald added a project: Kirigami. Herald added a subscriber: plasma-devel. mart requested review of this revision. REVISION SUMMARY add a property in page to override the globaltoolbar style, to either force a top toolbar on a

D18588: Configuration to never show the passwors dialog

This revision was automatically updated to reflect the committed changes. Closed by commit R116:1d7841399924: Configuration to never show the passwors dialog (authored by mart). REPOSITORY R116 Plasma Network Management Applet CHANGES SINCE LAST UPDATE

D18588: Configuration to never show the passwors dialog

mart updated this revision to Diff 50468. mart added a comment. - return true REPOSITORY R116 Plasma Network Management Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18588?vs=50466=50468 BRANCH arcpatch-D18588 REVISION DETAIL https://phabricator.kde.org/D18588

D18588: Configuration to never show the passwors dialog

mart created this revision. mart added reviewers: Plasma, jgrulich. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. mart requested review of this revision. REVISION SUMMARY on Plasma mobile, not qwidget dialogs should be ever shown at any time. the networkmanager KCM

Re: freedesktop.notifications daemon - crossplatform alternatives?

On giovedì 17 gennaio 2019 16:58:21 CET René J.V. Bertin wrote: > Why the cross-platform interest? Much KF5 software uses freedestop That's why KNotify has backends. -- Marco Martin

D18321: support for the concept of expandible items

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R169:2e7602f3fa5f: support for the concept of expandible items (authored by mart). CHANGED PRIOR TO COMMIT

D18321: support for the concept of expandible items

mart added a comment. the Global Drawer Mode section is expanded F6553308: Screenshot_20190117_150513.png REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D18321 To: mart, #kirigami Cc: plasma-devel, dkardarakos, apol,

D18321: support for the concept of expandible items

mart created this revision. mart added a reviewer: Kirigami. Herald added a project: Kirigami. Herald added a subscriber: plasma-devel. mart requested review of this revision. REVISION SUMMARY if an Action has the property expandible, its subactions are shown under it in globalDrawer and

D18260: fix logic of lnf loading

This revision was automatically updated to reflect the committed changes. Closed by commit R135:2682db8af734: fix logic of lnf loading (authored by mart). REPOSITORY R135 Integration for Qt applications in Plasma CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18260?vs=49515=49521

D18260: fix logic of lnf loading

mart created this revision. mart added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. mart requested review of this revision. REVISION SUMMARY mDefaultLnfConfig must be breeze, and mLnfConfig should be the configured one, rather the other way

D18239: login screen with same behavior as lockscreen

mart created this revision. mart added reviewers: Plasma, VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. mart requested review of this revision. REVISION SUMMARY start with wallpaper only mode by default, blur background at first input TEST PLAN works as

D18186: set skipTaskbar on SurfaceEvent::SurfaceCreated

This revision was automatically updated to reflect the committed changes. Closed by commit R120:cc8d3e775185: set skipTaskbar on SurfaceEvent::SurfaceCreated (authored by mart). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18186?vs=49249=49250

D18186: set skipTaskbar on SurfaceEvent::SurfaceCreated

mart updated this revision to Diff 49249. mart added a comment. - don't set in the caller REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18186?vs=49248=49249 BRANCH phab/skip REVISION DETAIL https://phabricator.kde.org/D18186 AFFECTED FILES

D18186: set skipTaskbar on SurfaceEvent::SurfaceCreated

mart created this revision. mart added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. mart requested review of this revision. REVISION SUMMARY makes sure the flag is set on time TEST PLAN can't get the panelcontroller in the taskbar anymore

D18180: Fix layout issues in the AboutPage personDelegate component

mart requested changes to this revision. mart added a comment. This revision now requires changes to proceed. the bug is legit.. however i think it should be tried harder to avoid manual layouting, there must be a legit problem somewhere that this is triggering, i would like more

D17906: [kirigami] Do not use light font styles for headings (2/3)

mart added a comment. so, if this is pushed, the same thing should happen at the same time to the corresponding plasma components REPOSITORY R169 Kirigami BRANCH no-light-headings (branched from master) REVISION DETAIL https://phabricator.kde.org/D17906 To: filipf, ngraham, #plasma,

D18006: Include only the largest size for the "Next" wallpaper

mart requested changes to this revision. mart added a comment. This revision now requires changes to proceed. has runtime memory been taken into account? (better with massif than with the unreliable top/ksysguard) runtime memory usage should be taken into account as well, loading a big

D17906: [kirigami] Do not use light font styles for headings (2/3)

mart accepted this revision. mart added a comment. bah, seems very tricky to make it work properly across distributions. to me, it speaks mostly as a failure for us to control the look of our product, due to broken fonts in distros and qt font rendering still buggy, issue that

D17906: [kirigami] Do not use light font styles for headings (2/3)

mart added a comment. In D17906#388803 , @ngraham wrote: > F6531451: Screenshot_20190107_145258.png > In this one, the fact that it's a header is connoted by its much larger font size and wider

D17906: [kirigami] Do not use light font styles for headings (2/3)

mart added a comment. In D17906#388294 , @filipf wrote: > Updating an another computer to Frameworks 5.53 and Qt 5.12 I get the same problem. > > F6531867: image.png > > F6531893: image.png

D18018: [Digital Clock] Add ability to change first day of week

mart added a comment. -1 on this in particular +1 for having it system wide REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D18018 To: Zren, #plasma Cc: mart, abetts, pino, davidedmundson, ngraham, plasma-devel, kvanton, jraleigh, GB_2, ragreen, Pitel,

D18019: [Digital Clock] Add ability to set a custom date format string

mart added a comment. is this the right place for it? (a text field to enter the "magic" date format letters is a very geeky ui, and i would prefer to not go there) shouldn't be a generic localization/date format setting? (and with also a graphical ui to generate this) REPOSITORY R120

D18078: [plasma-workspace-wallpapers] Improve wallpaper selection

mart added a comment. +100 (and we should push more on distros to have this installed by default, they often don't to save space on the iso :/ REPOSITORY R131 Plasma Wallpapers REVISION DETAIL https://phabricator.kde.org/D18078 To: filipf, #plasma, #vdg, ngraham Cc: mart, rooty,

Re: Minutes meeting , week 2

protocol D17691 * new iteration of D17265 -- Marco Martin

D17751: Add shadow to Hour's hand

mart added a comment. In D17751#381215 , @davidedmundson wrote: > From the linked bug report (and your screenshot) > > > You're right about the typo, but it doesn't seem that trivial. The shadow shadow appears all offset (on the default

D17752: Remove full representation of analog clock

mart added a comment. In D17752#388166 , @abetts wrote: > I think part of the reason why this seems too big also if because it doesn't do much more than tell you what day it is. If it was able to integrate with a calendar application, it could

D17752: Remove full representation of analog clock

mart added a comment. -1, digital and analog clocks have the same scope, and they should have the same behavior (if anything it should have the same features of the digital clock popup) REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D17752 To: shubham,

D17906: [kirigami] Do not use light font styles for headings (2/3)

mart added a comment. can we still keep as light the first level of heading, which is huge (and use that sparsingly) and go to levels from 2 onwards where needed smaller and bigger? REPOSITORY R169 Kirigami BRANCH no-light-headings (branched from master) REVISION DETAIL

D17906: [kirigami] Do not use light font styles for headings (2/3)

mart added a comment. in the end i *may* accept non light titles, even tough i still very much don't like the idea, but what i don't want to never, ever see in any circumstance is bold titles, anything of that will just be reverted. REPOSITORY R169 Kirigami BRANCH no-light-headings

D17906: [kirigami] Do not use light font styles for headings (2/3)

mart added a comment. In D17906#385968 , @ngraham wrote: > - **Implementation inconsistency:** Many fonts don't have a dedicated light style, many distros don't ship them if they do, and Qt < 5.12 doesn't use them even if nope, with

D17906: [kirigami] Do not use light font styles for headings (2/3)

mart added a comment. In D17906#385857 , @filipf wrote: > With the exception of the case of the Windows Store (which does nonetheless manage to achieve some visual hierarchy with different font sizes and colors), others mostly actually have an

D17906: [kirigami] Do not use light font styles for headings (2/3)

mart added a comment. I'm very much against this, I think it looks very bad :/ REPOSITORY R169 Kirigami BRANCH no-light-headings (branched from master) REVISION DETAIL https://phabricator.kde.org/D17906 To: filipf, ngraham, #plasma, #vdg, #frameworks Cc: mart, plasma-devel,

D17592: Introduce a DelegateRecycler attached object

mart requested changes to this revision. mart added a comment. This revision now requires changes to proceed. recycler should have a notify signal, because it's going to change all the time. the delegaterecycler instances are created/destroyed all the time like normal listview delegates,

D17393: [Folder View] make file context menu consistent with Dolphin's

mart added a comment. important is that "open with $default" and "open with..." are grouped together. apart from that i don't have much preferences for one or the other REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D17393 To: ngraham, #plasma, hein Cc:

D17556: Make Status and Notification popup consistent with others.

mart added a comment. for it to be perfect looking, i think it should either be aligned to the left of the icons, or to the left of the text items REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D17556 To: shubham, #vdg, broulik, #plasma, mart, hein Cc:

D17467: digital-clock: Show events on initial expansion for all time zones

mart added inline comments. INLINE COMMENTS > mbehrendt wrote in CalendarView.qml:60 > No, the model initially seems to be an empty list. another way you can try is to do it on Component.onCompleted: { } REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D17467

D17467: digital-clock: Show events on expanding applet

mart added inline comments. INLINE COMMENTS > CalendarView.qml:60 > +// would always be empty. > +holidaysList.model = > monthView.daysModel.eventsForDate(monthView.currentDate); > +hasExpanded = true; instead of storing a local hasExpanded,

D14542: [kcmkwin/desktop] KCM using new virtual desktops DBus interface

mart accepted this revision. mart added a comment. I've just done a round of testing of the latest revision together my last kwin patch, including: - adding and/or removinf desktops - changing the number of rows - renaming some desktops - restarting kwin randomly after any of the

D17333: Port digital clock settings to QQc2 and Kirigami

This revision was automatically updated to reflect the committed changes. Closed by commit R120:39e812d57fd6: Port digital clock settings to QQc2 and Kirigami (authored by mart). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D17333?vs=46799=46803#toc REPOSITORY R120 Plasma Workspace

D17333: Port digital clock settings to QQc2 and Kirigami

mart added a comment. F6453133: Screenshot_20181203_172322.png REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D17333 To: mart, #plasma, #vdg Cc: ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed,

D17333: Port digital clock settings to QQc2 and Kirigami

mart updated this revision to Diff 46799. mart added a comment. restore Information: label REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17333?vs=46794=46799 BRANCH phab/qqc2time REVISION DETAIL https://phabricator.kde.org/D17333 AFFECTED

D17333: Port digital clock settings to QQc2 and Kirigami

mart added a comment. i can put information again in front of showdate, tough it conveys misleading and wrong info... i really, really hate this abuse of labels as not-really-sections as the label describes the control standing besides it, not any other (btw, chiming in as the historyc

D17333: Port digital clock settings to QQc2 and Kirigami

mart added a comment. In D17333#370764 , @ngraham wrote: > Here are some examples (in production, from Dolphin's settings window) of how we integrate diverse controls into a form layout and preserve good alignment: well, in those the

D17333: Port digital clock settings to QQc2 and Kirigami

mart added a comment. ah, like F6453054: Screenshot_20181203_165012.png that can be done only with hacks that will spontaneously break i'm afraid REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D17333 To: mart,

D17333: Port digital clock settings to QQc2 and Kirigami

mart added a comment. In D17333#370759 , @ngraham wrote: > The new one doesn't follow the HIG and has poor alignment. Combobox labels are supposed to be to the left of the comboboxes. And having a huge list of checkboxes not aligned to the rest

D17333: Port digital clock settings to QQc2 and Kirigami

mart added a comment. left old, right new F6453040: Screenshot_20181203_164128.png REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D17333 To: mart, #plasma, #vdg Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai,

D17333: Port digital clock settings to QQc2 and Kirigami

mart created this revision. mart added reviewers: Plasma, VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. mart requested review of this revision. REVISION SUMMARY use QQC2 and FormLayout for alignment also, qqc2 combobox doesn't suffer from 390801 anymore

Monday meeting notes for 3/12/2018

orted systray general settings page to QQC2 and FormLayout * D17192 but vdg doesn't likey Plasma mobile: * fixed https://phabricator.kde.org/T10009 crash on activity creation This week/Todo: refining multilevel kcm to make the NM kcm work under the new api -- Marco Martin

D17192: use a Kirigami Heading for perfect consistency

mart added a comment. In D17192#368233 , @ngraham wrote: > It isn't a title, though. At best, the text in question is a list item, not a title. It surely is, it's the title of that column and says, this column is stuff about "Fonts",

D17212: Port to QQC2 and FormLayout

This revision was automatically updated to reflect the committed changes. Closed by commit R120:76eba93be27f: Port to QQC2 and FormLayout (authored by mart). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17212?vs=46465=46770 REVISION DETAIL

D11410: [RFC] Add option to make applet fixed width

mart added a comment. any updates on this? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D11410 To: Pitel, #plasma Cc: mart, hein, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D17212: Port to QQC2 and FormLayout

mart added a comment. In D17212#368135 , @abetts wrote: > In D17212#368048 , @mart wrote: > > > F6446445: Screenshot_20181129_143041.png > > > Wait!

D17211: Port applet/containment configs to qqc2

This revision was automatically updated to reflect the committed changes. Closed by commit R119:c2640f83f107: Port applet/containment configs to qqc2 (authored by mart). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17211?vs=46481=46483 REVISION

D17192: use a Kirigami Heading for perfect consistency

mart added a comment. well, to me part of the problem is that a title became a back button... even tough smaller target to hit, i would have preferred to have a toolbutton followed by a proper title that is just a title REPOSITORY R124 System Settings REVISION DETAIL

D17211: Port applet/containment configs to qqc2

mart updated this revision to Diff 46481. mart added a comment. - show the label again, but shorter REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17211?vs=46398=46481 BRANCH phab/qqc2 REVISION DETAIL https://phabricator.kde.org/D17211

D17212: Port to QQC2 and FormLayout

mart updated this revision to Diff 46465. mart added a comment. - center the layout REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17212?vs=46396=46465 BRANCH phab/qqc2 REVISION DETAIL https://phabricator.kde.org/D17212 AFFECTED FILES

D17212: Port to QQC2 and FormLayout

mart added a comment. F6446445: Screenshot_20181129_143041.png REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D17212 To: mart, #plasma, #vdg Cc: ngraham, abetts, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai,

D17211: Port applet/containment configs to qqc2

mart added a comment. the shrinking of the wallpaper combobox will be done in a separate commit REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D17211 To: mart, #plasma, #vdg, broulik, ngraham Cc: ngraham, apol, plasma-devel, ragreen, Pitel, ZrenBot,

D17211: Port applet/containment configs to qqc2

mart added a comment. In D17211#367974 , @mart wrote: > ah, that needs a fix in qqc2-desktop-style.. i can hack the open on down, tough for combox and menus in particular, is not possible at all the pattern press, open the subpopup, move the

D17211: Port applet/containment configs to qqc2

mart added a comment. In D17211#367573 , @ngraham wrote: > The Layout and Wallpaper Type comboboxes should open on press, not on click-and-release. ah, that needs a fix in qqc2-desktop-style.. i can hack the open on down, tough for

D17192: use a Kirigami Heading for perfect consistency

mart added a comment. @abetts , @ngraham discuss :) REPOSITORY R124 System Settings REVISION DETAIL https://phabricator.kde.org/D17192 To: mart, #plasma, #vdg Cc: abetts, ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D17211: Port applet/containment configs to qqc2

mart updated this revision to Diff 46398. mart added a comment. - initialize a proper size REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17211?vs=46397=46398 BRANCH phab/qqc2 REVISION DETAIL https://phabricator.kde.org/D17211 AFFECTED FILES

D17211: Port applet/containment configs to qqc2

mart added a comment. oddly seems not all the pages to not animate... i fear they are trying to set anchors? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D17211 To: mart, #plasma, #vdg, broulik Cc: apol, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai,

D17211: Port applet/containment configs to qqc2

mart added a comment. F6444604: Screenshot_20181128_130459.png REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D17211 To: mart, #plasma, #vdg, broulik Cc: apol, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai,

<    4   5   6   7   8   9   10   11   12   13   >