[PATCH 08/10] dell-laptop: Sync current block state to BIOS on hw switch change

2013-09-28 Thread Hans de Goede
-switch controlled radios will have their block bit cleared (potentially undoing a soft-block) on hw-switch toggle, this restores the sw-block in this case. Signed-off-by: Hans de Goede hdego...@redhat.com --- drivers/platform/x86/dell-laptop.c | 14 +++--- 1 file changed, 11

[PATCH 00/10] dell-laptop: Bring back (limited) rfkill support

2013-09-28 Thread Hans de Goede
Hi Matthew et al, As the subject already says this patch-set intends to bring back (and fixup) dell-laptop rfkill support. I know this was killed with a good reason, still I want to bring it back. I've 3 different Latitudes in use in my home, spanning 6 generations of Latitudes, and without

[PATCH 05/10] dell-laptop: Don't set sw_state from the query callback

2013-09-28 Thread Hans de Goede
The query callback should only update the hw_state, see the comment in net/rfkill/core.c in rfkill_set_block, which is its only caller. rfkill_set_block will modify the sw_state directly after calling query so calling set_sw_state is an expensive NOP. Signed-off-by: Hans de Goede hdego

[PATCH 06/10] dell-laptop: Don't read-back sw_state on machines with a hardware switch

2013-09-28 Thread Hans de Goede
will be cleared to all 0 after a wireless switch toggle, even for radios not controlled by the hw-switch (yeah firmware bugs). This causes magic changes to the sw_state. This is inconsistent with other rfkill drivers which preserve the sw_state over a hw kill on / off. Signed-off-by: Hans de Goede hdego

[PATCH 03/12] dell-laptop: If there is no hwswitch, then clear all hw-controlled bits

2013-11-17 Thread Hans de Goede
To ensure we don't enter any hw-switch related code paths on machines without a hw-switch. Signed-off-by: Hans de Goede hdego...@redhat.com --- drivers/platform/x86/dell-laptop.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/platform/x86/dell-laptop.c b/drivers/platform/x86

[PATCH 02/12] dell-laptop: Only enable rfkill on Latitudes

2013-11-17 Thread Hans de Goede
been no blacklist entries for Latitudes. Note that the blacklist contained no Vostros either, and most Vostros have a hardware switch too, so we could consider supporting Vostros with a hardware switch too. Signed-off-by: Hans de Goede hdego...@redhat.com --- drivers/platform/x86/dell-laptop.c

[PATCH 01/12] Revert dell-laptop: Remove rfkill code

2013-11-17 Thread Hans de Goede
a6c2390cd6d2083d27a2359658e08f2d3df375ac. Conflicts: drivers/platform/x86/dell-laptop.c Signed-off-by: Hans de Goede hdego...@redhat.com --- drivers/platform/x86/dell-laptop.c | 289 + 1 file changed, 289 insertions(+) diff --git a/drivers/platform/x86/dell-laptop.c b/drivers

[PATCH 06/12] dell-laptop: Don't read-back sw_state on machines with a hardware switch

2013-11-17 Thread Hans de Goede
will be cleared to all 0 after a wireless switch toggle, even for radios not controlled by the hw-switch (yeah firmware bugs). This causes magic changes to the sw_state. This is inconsistent with other rfkill drivers which preserve the sw_state over a hw kill on / off. Signed-off-by: Hans de Goede hdego

[PATCH 04/12] dell-laptop: Only get status from BIOS once when updating

2013-11-17 Thread Hans de Goede
Signed-off-by: Hans de Goede hdego...@redhat.com --- drivers/platform/x86/dell-laptop.c | 28 +++- 1 file changed, 19 insertions(+), 9 deletions(-) diff --git a/drivers/platform/x86/dell-laptop.c b/drivers/platform/x86/dell-laptop.c index 48fabf6..06f281b 100644

[PATCH 09/12] dell-laptop: Do not skip setting blocked bit rfkill_set while hw-blocked

2013-11-17 Thread Hans de Goede
Instead when hw-blocked always write 1 to the blocked bit for the radio in question. This is necessary to properly set all the blocked bits for hw-switch controlled radios to 1 after power-on and resume. Signed-off-by: Hans de Goede hdego...@redhat.com --- drivers/platform/x86/dell-laptop.c | 5

[PATCH 10/12] dell-laptop: Wait less long before updating rfkill after an rfkill keypress

2013-11-17 Thread Hans de Goede
Some time is needed for the BIOS to do its work, but 250ms should be plenty. Signed-off-by: Hans de Goede hdego...@redhat.com --- drivers/platform/x86/dell-laptop.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/platform/x86/dell-laptop.c b/drivers/platform/x86/dell

[PATCH 12/12] dell-laptop: Only enable rfkill functionality on laptops with a hw killswitch

2013-11-17 Thread Hans de Goede
All my testing has been on laptops with a hw killswitch, so to be on the safe side disable rfkill functionality on models without a hw killswitch for now. Once we gather some feedback on laptops without a hw killswitch this decision maybe reconsidered. Signed-off-by: Hans de Goede hdego

[PATCH 05/12] dell-laptop: Don't set sw_state from the query callback

2013-11-17 Thread Hans de Goede
The query callback should only update the hw_state, see the comment in net/rfkill/core.c in rfkill_set_block, which is its only caller. rfkill_set_block will modify the sw_state directly after calling query so calling set_sw_state is an expensive NOP. Signed-off-by: Hans de Goede hdego

[PATCH 11/12] dell-laptop: Add a force_rfkill module parameter

2013-11-17 Thread Hans de Goede
Setting force_rfkill will cause the dell-laptop rfkill code to skip its whitelist checks, this will allow individual users to override the whitelist, as well as to gather info from users to improve the checks. Signed-off-by: Hans de Goede hdego...@redhat.com --- drivers/platform/x86/dell

[PATCH 07/12] dell-laptop: Allow changing the sw_state while the radio is blocked by hw

2013-11-17 Thread Hans de Goede
This makes dell-laptop's rfkill code consistent with other drivers which allow sw_state changes while hw blocked. Signed-off-by: Hans de Goede hdego...@redhat.com --- drivers/platform/x86/dell-laptop.c | 7 ++- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/drivers/platform

[PATCH 08/12] dell-laptop: Sync current block state to BIOS on hw switch change

2013-11-17 Thread Hans de Goede
-switch controlled radios will have their block bit cleared (potentially undoing a soft-block) on hw-switch toggle, this restores the sw-block in this case. Signed-off-by: Hans de Goede hdego...@redhat.com --- drivers/platform/x86/dell-laptop.c | 14 +++--- 1 file changed, 11

Re: [PATCH] dell-laptop: Only install the i8042 filter when rfkill is active

2013-12-24 Thread Hans de Goede
Hi, On 12/24/2013 08:34 PM, Hans de Goede wrote: Installing the i8042 filter is not useful on machines where rfkill is not whitelisted, so move the filter installation into dell_setup_rfkill, after the whitelist check. p.s. Note the cleanup paths are not changed, I did not bother

[PATCH] thinkpad_acpi: Add mappings for F9 - F12 hotkeys on T440s

2014-02-18 Thread Hans de Goede
2 the icons are somewhat creative, which is why I ended up looking them up in the user manual. Signed-off-by: Hans de Goede hdego...@redhat.com --- drivers/platform/x86/thinkpad_acpi.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/platform/x86/thinkpad_acpi.c b

[PATCH 1/2] input/serio: Add a firmware_id sysfs attribute

2014-03-20 Thread Hans de Goede
interface may provide. Signed-off-by: Hans de Goede hdego...@redhat.com --- drivers/input/serio/serio.c | 12 include/linux/serio.h | 1 + 2 files changed, 13 insertions(+) diff --git a/drivers/input/serio/serio.c b/drivers/input/serio/serio.c index 8f4c4ab..1788a4d 100644

[PATCH 2/2] input/serio/8042: Add firmware_id support

2014-03-20 Thread Hans de Goede
Fill in the new serio firmware_id sysfs attribute for pnp instantiated 8042 serio ports. Signed-off-by: Hans de Goede hdego...@redhat.com --- drivers/input/serio/i8042-x86ia64io.h | 26 ++ drivers/input/serio/i8042.c | 6 ++ 2 files changed, 32 insertions

[PATCH 0/2] input/serio: Add a firmware_id sysfs attribute

2014-03-20 Thread Hans de Goede
Hi All, For firmware instantiated serio devices, such as devices instantiated through ACPI, it may be useful for userspace to know the firmware-id (pnp-id in case of ACPI) through which the device was instantiated. One concrete example of this is the new ps/2 touchpads found in Lenovo Thinkpad

Re: [PATCH 0/2] input/serio: Add a firmware_id sysfs attribute

2014-03-28 Thread Hans de Goede
Hi, On 03/28/2014 08:56 AM, Dmitry Torokhov wrote: On Thu, Mar 20, 2014 at 05:21:59PM +, Matthew Garrett wrote: On Thu, Mar 20, 2014 at 11:12:08AM +0100, Hans de Goede wrote: Which in the end turns out to be much nicer too, since it gets rid of needing a udev-helper too. After

Re: [PATCH 0/2] input/serio: Add a firmware_id sysfs attribute

2014-03-28 Thread Hans de Goede
Hi, On 03/28/2014 09:17 AM, Dmitry Torokhov wrote: On Fri, Mar 28, 2014 at 09:12:43AM +0100, Hans de Goede wrote: Hi, On 03/28/2014 08:56 AM, Dmitry Torokhov wrote: On Thu, Mar 20, 2014 at 05:21:59PM +, Matthew Garrett wrote: On Thu, Mar 20, 2014 at 11:12:08AM +0100, Hans de Goede wrote

Re: [PATCH 0/2] input/serio: Add a firmware_id sysfs attribute

2014-03-28 Thread Hans de Goede
Hi, On 03/28/2014 09:52 AM, Dmitry Torokhov wrote: On Fri, Mar 28, 2014 at 09:29:50AM +0100, Hans de Goede wrote: Hi, On 03/28/2014 09:17 AM, Dmitry Torokhov wrote: On Fri, Mar 28, 2014 at 09:12:43AM +0100, Hans de Goede wrote: Hi, On 03/28/2014 08:56 AM, Dmitry Torokhov wrote: On Thu

[PATCH v2] thinkpad_acpi: Add mappings for F9 - F12 hotkeys on X240 / T440 / T540

2014-04-09 Thread Hans de Goede
the icons are somewhat creative, which is why I ended up looking them up in the user manual. Signed-off-by: Hans de Goede hdego...@redhat.com --- drivers/platform/x86/thinkpad_acpi.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/platform/x86/thinkpad_acpi.c b

[PATCH v2 0/1] thinkpad_acpi: Add mappings for F9 - F12 hotkeys on X240 / T440 / T540

2014-04-09 Thread Hans de Goede
Hi, This patch seems to have fallen through the cracks, so here is a resend. While at it I've also updated the comment / commit msg to reflect that these new keys can not just be found on the T440 but also on the X240 and T540, hence the v2. Regards, Hans -- To unsubscribe from this list: send

[PATCH v2 2/2] input/serio/8042: Add firmware_id support

2014-04-09 Thread Hans de Goede
Fill in the new serio firmware_id sysfs attribute for pnp instantiated 8042 serio ports. Signed-off-by: Hans de Goede hdego...@redhat.com Acked-by: Peter Hutterer peter.hutte...@who-t.net --- drivers/input/serio/i8042-x86ia64io.h | 16 drivers/input/serio/i8042.c | 6

[PATCH v2 0/2] input/serio: Add a firmware_id sysfs attribute

2014-04-09 Thread Hans de Goede
Hi All, Sorry about doing a v2 so shortly after the resend, while reviewing the patches one last time I noticed that the code in the input/serio/8042: Add firmware_id support Suffered a bit from too much copy-paste, so in this v2 that patch has been refactored using a helper function to avoid

[PATCH v2 1/2] input/serio: Add a firmware_id sysfs attribute

2014-04-09 Thread Hans de Goede
interface may provide. Signed-off-by: Hans de Goede hdego...@redhat.com Acked-by: Peter Hutterer peter.hutte...@who-t.net --- drivers/input/serio/serio.c | 12 include/linux/serio.h | 1 + 2 files changed, 13 insertions(+) diff --git a/drivers/input/serio/serio.c b/drivers/input

Re: [PATCH v2 0/1] thinkpad_acpi: Add mappings for F9 - F12 hotkeys on X240 / T440 / T540

2014-04-10 Thread Hans de Goede
Hi, On 04/10/2014 02:12 AM, Henrique de Moraes Holschuh wrote: On Wed, 09 Apr 2014, Matthew Garrett wrote: On Wed, Apr 09, 2014 at 03:03:01PM -0300, Henrique de Moraes Holschuh wrote: On Wed, 09 Apr 2014, Hans de Goede wrote: This patch seems to have fallen through the cracks, so here

Re: [RFC PATCH] mba6x_bl: Backlight driver for mid 2013 MacBook Air

2014-04-29 Thread Hans de Goede
Hi, Why is this patch an RFC? If it is ready for upstreaming please drop the RFC prefix when you post the next version. On 04/27/2014 10:56 PM, Patrik Jakobsson wrote: This driver takes control over the LP8550 backlight driver chip found in the mid 2013 and newer MacBook Air (6,1 and 6,2). The

Re: [PATCH v2] mba6x_bl: Backlight driver for mid 2013 MacBook Air

2014-04-30 Thread Hans de Goede
- Constify the backlight_ops struct Signed-off-by: Patrik Jakobsson patrik.r.jakobs...@gmail.com Thanks for working on this, looks good: Reviewed-by: Hans de Goede hdego...@redhat.com Regards, Hans --- MAINTAINERS | 6 + drivers/platform/x86/Kconfig| 13

[RFC 0/3] Add acpi_video_unregister_backlight and use it in acer-wmi

2014-05-12 Thread Hans de Goede
Hi Aaron and Lee, While working on figuring out howto fix this Acer backlight bug properly: https://bugzilla.redhat.com/show_bug.cgi?id=1012674 TL;DR: needs acpi-video to not register the backlight device, but keep it processing hotkeys, like video.use_native_backlight=1 does, but this machine

[RFC 3/3] acer-wmi: Add Aspire 5741 to video_vendor_dmi_table

2014-05-12 Thread Hans de Goede
The Aspire 5741 has broken acpi-video backlight control, so add it to the quirk table. https://bugzilla.redhat.com/show_bug.cgi?id=1012674 Signed-off-by: Hans de Goede hdego...@redhat.com --- drivers/platform/x86/acer-wmi.c | 8 1 file changed, 8 insertions(+) diff --git a/drivers

[RFC 2/3] acer-wmi: Switch to acpi_video_unregister_backlight

2014-05-12 Thread Hans de Goede
AND the backlight device And we end up without any handler for the brightness hotkeys. This patch fixes this by switching over to acpi_video_unregister_backlight() which keeps the hotkey handler in place. https://bugzilla.kernel.org/show_bug.cgi?id=35622 Signed-off-by: Hans de Goede hdego...@redhat.com

[RFC 1/3] acpi-video: Add an acpi_video_unregister_backlight function

2014-05-12 Thread Hans de Goede
different behavior depending on module loading order! So as said I believe that quite a few existing acpi_vendor modules really always want the behavior of a), which calling acpi_video_unregister_backlight() instead of acpi_video_unregister() will give them. Signed-off-by: Hans de Goede hdego

[PATCH] ideapad-laptop: Blacklist rfkill control on the Lenovo Yoga 2 11

2014-05-13 Thread Hans de Goede
with kzalloc. Reported-and-tested-by: Vincent Gerris vger...@gmail.com Signed-off-by: Hans de Goede hdego...@redhat.com --- drivers/platform/x86/ideapad-laptop.c | 23 ++- 1 file changed, 18 insertions(+), 5 deletions(-) diff --git a/drivers/platform/x86/ideapad-laptop.c b

Re: [RFC 1/3] acpi-video: Add an acpi_video_unregister_backlight function

2014-05-14 Thread Hans de Goede
Hi, On 05/13/2014 05:11 PM, Aaron Lu wrote: On 05/13/2014 02:03 AM, Hans de Goede wrote: Add an acpi_video_unregister_backlight function, which only unregisters the backlight device, and leaves the acpi_notifier in place. Some acpi_vendor driver need this as they don't want the acpi_video

RFC: Cleanup firmware backlight control method selection

2014-05-15 Thread Hans de Goede
Hi All, There are various issues with how the linux kernel currently select which firmware backlight control (*) method to use: 1) There are various module loading ordering issues, leading to different behavior depending on module load ordering: *

[PATCH 1/2] asus-wmi: Add a no backlight quirk

2014-05-15 Thread Hans de Goede
=1097436 Signed-off-by: Hans de Goede hdego...@redhat.com --- drivers/platform/x86/asus-wmi.c | 8 ++-- drivers/platform/x86/asus-wmi.h | 1 + 2 files changed, 7 insertions(+), 2 deletions(-) diff --git a/drivers/platform/x86/asus-wmi.c b/drivers/platform/x86/asus-wmi.c index c5e082f..6f73dc5

[PATCH 2/2] eeepc-wmi: Add no backlight quirk for Asus H87I-PLUS Motherboard

2014-05-15 Thread Hans de Goede
https://bugzilla.redhat.com/show_bug.cgi?id=1097436 Signed-off-by: Hans de Goede hdego...@redhat.com --- drivers/platform/x86/eeepc-wmi.c | 13 + 1 file changed, 13 insertions(+) diff --git a/drivers/platform/x86/eeepc-wmi.c b/drivers/platform/x86/eeepc-wmi.c index 6112933..a7286bb

[PATCH 0/4] Add acpi_video_unregister_backlight(), use in acer-wmi

2014-05-15 Thread Hans de Goede
Hi All, Here is a non RFC version of my patch series to fix: https://bugzilla.kernel.org/show_bug.cgi?id=35622 https://bugzilla.redhat.com/show_bug.cgi?id=1012674 I think its best if the entire series goes upstream through the acpi tree since the platform/x86 patches depend on the acpi changes.

[PATCH 1/4] acpi-video: Don't register acpi_video_resume notifier without backlight devices

2014-05-15 Thread Hans de Goede
If we're not going to be registering any backlight devices then acpi_video_resume is always nop, so don't register it in that case. Signed-off-by: Hans de Goede hdego...@redhat.com -- Note to reviewers the changes to acpi_video_dev_register_backlight() only remove

[PATCH 2/4] acpi-video: Add an acpi_video_unregister_backlight function

2014-05-15 Thread Hans de Goede
-by: Hans de Goede hdego...@redhat.com --- drivers/acpi/video.c | 14 ++ include/acpi/video.h | 2 ++ 2 files changed, 16 insertions(+) diff --git a/drivers/acpi/video.c b/drivers/acpi/video.c index f767eba..898b084 100644 --- a/drivers/acpi/video.c +++ b/drivers/acpi/video.c

[PATCH 4/4] acer-wmi: Add Aspire 5741 to video_vendor_dmi_table

2014-05-15 Thread Hans de Goede
The Aspire 5741 has broken acpi-video backlight control, so add it to the quirk table. https://bugzilla.redhat.com/show_bug.cgi?id=1012674 Signed-off-by: Hans de Goede hdego...@redhat.com --- drivers/platform/x86/acer-wmi.c | 8 1 file changed, 8 insertions(+) diff --git a/drivers

[PATCH 3/4] acer-wmi: Switch to acpi_video_unregister_backlight

2014-05-15 Thread Hans de Goede
AND the backlight device And we end up without any handler for the brightness hotkeys. This patch fixes this by switching over to acpi_video_unregister_backlight() which keeps the hotkey handler in place. https://bugzilla.kernel.org/show_bug.cgi?id=35622 Signed-off-by: Hans de Goede hdego...@redhat.com

Re: RFC: Cleanup firmware backlight control method selection

2014-05-16 Thread Hans de Goede
Hi, On 05/16/2014 12:29 AM, Mattia Dongili wrote: On Thu, May 15, 2014 at 11:04:50AM +0200, Hans de Goede wrote: Hi All, There are various issues with how the linux kernel currently select which firmware backlight control (*) method to use: 1) There are various module loading ordering

[PATCH v2 3/3] acer-wmi: Add Aspire 5741 to video_vendor_dmi_table

2014-05-17 Thread Hans de Goede
The Aspire 5741 has broken acpi-video backlight control, so add it to the quirk table. https://bugzilla.redhat.com/show_bug.cgi?id=1012674 Signed-off-by: Hans de Goede hdego...@redhat.com --- drivers/platform/x86/acer-wmi.c | 8 1 file changed, 8 insertions(+) diff --git a/drivers

[PATCH v2 1/3] acpi-video: Add an acpi_video_unregister_backlight function

2014-05-17 Thread Hans de Goede
-by: Hans de Goede hdego...@redhat.com --- drivers/acpi/video.c | 14 ++ include/acpi/video.h | 2 ++ 2 files changed, 16 insertions(+) diff --git a/drivers/acpi/video.c b/drivers/acpi/video.c index 52176ad..ba6e4d7 100644 --- a/drivers/acpi/video.c +++ b/drivers/acpi/video.c

[PATCH v2 2/3] acer-wmi: Switch to acpi_video_unregister_backlight

2014-05-17 Thread Hans de Goede
AND the backlight device And we end up without any handler for the brightness hotkeys. This patch fixes this by switching over to acpi_video_unregister_backlight() which keeps the hotkey handler in place. https://bugzilla.kernel.org/show_bug.cgi?id=35622 Signed-off-by: Hans de Goede hdego...@redhat.com

[PATCH v2 0/3] Add acpi_video_unregister_backlight(), use in acer-wmi

2014-05-17 Thread Hans de Goede
Hi All, Here is a v2 of my patch series to fix: https://bugzilla.kernel.org/show_bug.cgi?id=35622 https://bugzilla.redhat.com/show_bug.cgi?id=1012674 I think its best if the entire series goes upstream through the acpi tree since the platform/x86 patches depend on the acpi changes. Changes

Re: RFC: Cleanup firmware backlight control method selection

2014-05-19 Thread Hans de Goede
Hi, On 05/19/2014 01:24 AM, Mattia Dongili wrote: On Fri, May 16, 2014 at 10:06:15AM +0200, Hans de Goede wrote: snip This is only a problem with crazy PC's which have multiple firmware API's (both standardized and custom ACPI) to control the backlight, which also are sometimes all broken

Re: [PATCH 2/2] eeepc-wmi: Add no backlight quirk for Asus H87I-PLUS Motherboard

2014-06-11 Thread Hans de Goede
Hi, On 06/10/2014 06:16 PM, Matthew Garrett wrote: On Thu, 2014-05-15 at 11:39 +0200, Hans de Goede wrote: https://bugzilla.redhat.com/show_bug.cgi?id=1097436 I'm not especially keen on this - if this seems like a general problem, adding boards piecemeal to a DMI table will never solve

Re: [PATCH 2/2] eeepc-wmi: Add no backlight quirk for Asus H87I-PLUS Motherboard

2014-06-11 Thread Hans de Goede
Hi, On 06/10/2014 06:17 PM, Matthew Garrett wrote: On Tue, 2014-06-10 at 16:16 +, Matthew Garrett wrote: On Thu, 2014-05-15 at 11:39 +0200, Hans de Goede wrote: https://bugzilla.redhat.com/show_bug.cgi?id=1097436 I'm not especially keen on this - if this seems like a general problem

Re: [PATCH 2/2] eeepc-wmi: Add no backlight quirk for Asus H87I-PLUS Motherboard

2014-06-12 Thread Hans de Goede
Hi, On 06/11/2014 06:03 PM, Matthew Garrett wrote: On Wed, 2014-06-11 at 15:57 +0200, Hans de Goede wrote: Hi, On 06/10/2014 06:16 PM, Matthew Garrett wrote: On Thu, 2014-05-15 at 11:39 +0200, Hans de Goede wrote: https://bugzilla.redhat.com/show_bug.cgi?id=1097436 I'm not especially keen

Mapping of F11 and F12 on new lenovo laptops and Lenovo Compact Keyboard

2014-06-19 Thread Hans de Goede
Hi Jamie, I saw your patch-set for the Lenovo Compact Keyboard on the lwn.net kernel page. This spiked my interest as I'm the author of this patch:

Re: Mapping of F11 and F12 on new lenovo laptops and Lenovo Compact Keyboard

2014-06-20 Thread Hans de Goede
Hi, On 06/20/2014 02:00 PM, Jamie Lentin wrote: On Thu, 19 Jun 2014, Hans de Goede wrote: Hi Jamie, I saw your patch-set for the Lenovo Compact Keyboard on the lwn.net kernel page. This spiked my interest as I'm the author of this patch: https://git.kernel.org/cgit/linux/kernel/git

[PATCH] thinkpad_acpi: Update mapping for F12 hotkey on *40 models to KEY_FILE

2014-06-23 Thread Hans de Goede
by the kernel. Change the mapping done of identical laptop key done by thinkpad_acpi to also send KEY_FILE for consistency. Cc: Jamie Lentin j...@lentin.co.uk Signed-off-by: Hans de Goede hdego...@redhat.com --- drivers/platform/x86/thinkpad_acpi.c | 2 +- 1 file changed, 1 insertion(+), 1

[PATCH v2 2/2] asus-wmi: backlight_init: Stop treating -ENODEV as if its not an error

2014-07-08 Thread Hans de Goede
. https://bugzilla.redhat.com/show_bug.cgi?id=1097436 Signed-off-by: Hans de Goede hdego...@redhat.com --- drivers/platform/x86/asus-wmi.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/platform/x86/asus-wmi.c b/drivers/platform/x86/asus-wmi.c index 70aec19..8a88416

[PATCH v2 1/2] asus-wmi: Disable acpi-video backlight on desktop machines

2014-07-08 Thread Hans de Goede
Some Asus motherboards for desktop PC-s export an acpi-video interface advertising backlight support. Test the dmi chassis-type and tell acpi-video to not register a backlight interface on desktops. https://bugzilla.redhat.com/show_bug.cgi?id=1097436 Signed-off-by: Hans de Goede hdego

[PATCH v2 0/2] asus-wmi: Disable acpi-video backlight on desktop machi

2014-07-08 Thread Hans de Goede
Hi All, Here is v2 of my patch series to stop certain asus desktop motherboards registering a backlight interface for a non-existent backlight. Changes since v1: -Simply stop acpi-video from registering a backlight interface on all boards with a dmi-chassis-type of desktop rather then using a

[PATCH 2/2] asus-nb-wmi: Add wapf4 quirk for the X550CL

2014-07-14 Thread Hans de Goede
As reported here: https://bugs.launchpad.net/bugs/1277959 the X550CL needs wapf=4 too. Signed-off-by: Hans de Goede hdego...@redhat.com --- drivers/platform/x86/asus-nb-wmi.c | 9 + 1 file changed, 9 insertions(+) diff --git a/drivers/platform/x86/asus-nb-wmi.c b/drivers/platform/x86

[PATCH 1/2] asus-nb-wmi.c: Rename x401u quirk to wapf4

2014-07-14 Thread Hans de Goede
The actual x401u does not use the so named x401u quirk but the x55u quirk. All that the x401u quirk does it setting wapf to 4, so rename it to wapf4 to stop the confusion. Signed-off-by: Hans de Goede hdego...@redhat.com --- drivers/platform/x86/asus-nb-wmi.c | 24 1

[PATCH] asus-nb-wmi: Add wapf4 quirk for the X550CC

2014-07-18 Thread Hans de Goede
As reported here: https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1173681 the X550CC needs wapf=4 too. Signed-off-by: Hans de Goede hdego...@redhat.com --- drivers/platform/x86/asus-nb-wmi.c | 9 + 1 file changed, 9 insertions(+) diff --git a/drivers/platform/x86/asus-nb-wmi.c b

[PATCH] asus-nb-wmi: Add wapf4 quirk for the U32U

2014-07-29 Thread Hans de Goede
As reported here: https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1173681 the U32U needs wapf=4 too. Signed-off-by: Hans de Goede hdego...@redhat.com --- drivers/platform/x86/asus-nb-wmi.c | 14 ++ 1 file changed, 14 insertions(+) diff --git a/drivers/platform/x86/asus-nb-wmi.c

[PATCH 2/2] acer-wmi: Add acpi_backlight=video quirk for the Acer KAV80

2014-10-16 Thread Hans de Goede
https://bugzilla.redhat.com/show_bug.cgi?id=1128309 Cc: sta...@vger.kernel.org Signed-off-by: Hans de Goede hdego...@redhat.com --- drivers/platform/x86/acer-wmi.c | 11 +++ 1 file changed, 11 insertions(+) diff --git a/drivers/platform/x86/acer-wmi.c b/drivers/platform/x86/acer-wmi.c

[PATCH 1/2] samsung-laptop: Add broken-acpi-video quirk for NC210/NC110

2014-10-16 Thread Hans de Goede
Reported (and tested) here: https://bugzilla.redhat.com/show_bug.cgi?id=861573 Cc: sta...@vger.kernel.org Signed-off-by: Hans de Goede hdego...@redhat.com --- drivers/platform/x86/samsung-laptop.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/drivers/platform/x86/samsung

[PATCH] asus-nb-wmi: Add another wapf=4 quirk

2014-11-21 Thread Hans de Goede
Reported through launchpad: https://bugs.launchpad.net/bugs/1173681 Signed-off-by: Hans de Goede hdego...@redhat.com --- drivers/platform/x86/asus-nb-wmi.c | 9 + 1 file changed, 9 insertions(+) diff --git a/drivers/platform/x86/asus-nb-wmi.c b/drivers/platform/x86/asus-nb-wmi.c index

[PATCH v2] asus-nb-wmi: Add another wapf=4 quirk

2014-11-24 Thread Hans de Goede
Wifi on this laptop does not work unless asus-nb-wmi.wapf=4 is specified on the kerne commandline, add a quirk for this. Cc: sta...@vger.kernel.org BugLink: https://bugs.launchpad.net/bugs/1173681 Signed-off-by: Hans de Goede hdego...@redhat.com --- drivers/platform/x86/asus-nb-wmi.c | 9

Re: [PATCH] samsung-laptop: Add use_native_backlight quirk, and enable it on some models

2015-01-12 Thread Hans de Goede
Hi, On 13-01-15 05:03, Darren Hart wrote: On Fri, Jan 09, 2015 at 03:10:01PM +0100, Hans de Goede wrote: Since kernel 3.14 the backlight control has been broken on various Samsung Atom based netbooks. This has been bisected and this problem happens since commit b35684b8fa94 (drm/i915: do full

[PATCH] samsung-laptop: Add use_native_backlight quirk, and enable it on some models

2015-01-09 Thread Hans de Goede
-by: Bertrik Sikken bert...@sikken.nl # N150P Cc: sta...@vger.kernel.org # 3.16 Signed-off-by: Hans de Goede hdego...@redhat.com --- drivers/platform/x86/samsung-laptop.c | 20 +--- 1 file changed, 17 insertions(+), 3 deletions(-) diff --git a/drivers/platform/x86/samsung-laptop.c b

[PATCH v2] toshiba_acpi: Do not register vendor backlight when acpi_video bl is available

2015-04-21 Thread Hans de Goede
, this is identical to how other drivers handle such systems. BugLink: https://bugzilla.redhat.com/show_bug.cgi?id=1206036 BugLink: https://bugzilla.kernel.org/show_bug.cgi?id=86521 Signed-off-by: Hans de Goede hdego...@redhat.com Reviewed-and-tested-by: Azael Avalos coproscef...@gmail.com --- Changes

[PATCH] toshiba_acpi: Do not register vendor backlight when acpi_video bl is available

2015-04-15 Thread Hans de Goede
, this is identical to how other drivers handle such systems. BugLink: https://bugzilla.redhat.com/show_bug.cgi?id=1206036 BugLink: https://bugzilla.kernel.org/show_bug.cgi?id=86521 Signed-off-by: Hans de Goede hdego...@redhat.com --- drivers/platform/x86/Kconfig| 1 + drivers/platform/x86

Re: [PATCH] toshiba_acpi: Do not register vendor backlight when acpi_video bl is available

2015-04-17 Thread Hans de Goede
Hi, On 17-04-15 18:58, Azael Avalos wrote: Hi there, Sorry for the late reply, I've been a bit overwhelmed with work related stuff, and to top it off I was having issues with one of my systems, but anyway, on to the patch :-) 2015-04-15 8:11 GMT-06:00 Hans de Goede hdego...@redhat.com

[PATCH] acpi-video: Add a parameter to not register the backlight sysfs interface

2015-06-09 Thread Hans de Goede
/show_bug.cgi?id=21012 Buglink: https://bugs.freedesktop.org/show_bug.cgi?id=82634 Reported-and-tested-by: Sylvain Pasche sylvain.pas...@gmail.com Signed-off-by: Hans de Goede hdego...@redhat.com --- drivers/acpi/video.c | 39 --- 1 file changed, 36 insertions(+), 3

[PATCH v2] acpi-video: Add a parameter to not register the backlight sysfs interface

2015-06-09 Thread Hans de Goede
/show_bug.cgi?id=21012 Buglink: https://bugs.freedesktop.org/show_bug.cgi?id=82634 Reported-and-tested-by: Sylvain Pasche sylvain.pas...@gmail.com Signed-off-by: Hans de Goede hdego...@redhat.com --- Changes in v2: -Simplify check in acpi_video_switch_brightness() -If backlight registration fails set

[PATCH 23/32] ideapad-laptop: Port to new backlight interface selection API

2015-06-10 Thread Hans de Goede
Port the backlight selection logic to the new backlight interface selection API. Signed-off-by: Hans de Goede hdego...@redhat.com --- drivers/platform/x86/ideapad-laptop.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/platform/x86/ideapad-laptop.c b/drivers

[PATCH 21/32] eeepc-laptop: Port to new backlight interface selection API

2015-06-10 Thread Hans de Goede
they are not necessary, if the user wants to know which backlight interfaces are registered a simple ls /sys/class/backlight suffices. Signed-off-by: Hans de Goede hdego...@redhat.com --- drivers/platform/x86/eeepc-laptop.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git

[PATCH 22/32] fujitsu-laptop: Port to new backlight interface selection API

2015-06-10 Thread Hans de Goede
Port the backlight selection logic to the new backlight interface selection API. Signed-off-by: Hans de Goede hdego...@redhat.com --- drivers/platform/x86/fujitsu-laptop.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/platform/x86/fujitsu-laptop.c b/drivers

[PATCH 20/32] dell-wmi: Port to new backlight interface selection API

2015-06-10 Thread Hans de Goede
Port the backlight selection logic to the new backlight interface selection API. Signed-off-by: Hans de Goede hdego...@redhat.com --- drivers/platform/x86/dell-wmi.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/platform/x86/dell-wmi.c b/drivers/platform/x86/dell

[PATCH 10/32] acpi-video: Port to new backlight interface selection API

2015-06-10 Thread Hans de Goede
Most of the patch is moving the dmi quirks for forcing use of the acpi-video / the native backlight interface to video_detect.c. What remains is a nice cleanup. Signed-off-by: Hans de Goede hdego...@redhat.com --- drivers/acpi/video.c| 178

[PATCH 09/32] drm: i915: Port to new backlight interface selection API

2015-06-10 Thread Hans de Goede
This results in a nice cleanup, as we can replace the complicated logic from should_ignore_backlight_request() with a simple check for the type being native. Signed-off-by: Hans de Goede hdego...@redhat.com --- drivers/gpu/drm/i915/intel_opregion.c | 12 +--- 1 file changed, 1 insertion

[PATCH 25/32] msi-laptop: Port to new backlight interface selection API

2015-06-10 Thread Hans de Goede
they are not necessary, if the user wants to know which backlight interfaces are registered a simple ls /sys/class/backlight suffices. Signed-off-by: Hans de Goede hdego...@redhat.com --- drivers/platform/x86/msi-laptop.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git

[PATCH 04/32] acpi-video-detect: Move acpi_is_video_device() to acpi/scan.c

2015-06-10 Thread Hans de Goede
on CONFIG_ACPI_VIDEO. Signed-off-by: Hans de Goede hdego...@redhat.com --- drivers/acpi/scan.c | 56 ++ drivers/acpi/video_detect.c | 60 - include/linux/acpi.h| 8 ++ 3 files changed, 58 insertions

[PATCH 03/32] acpi-video-detect: Make acpi_video_get_capabilities a private function

2015-06-10 Thread Hans de Goede
acpi_video_get_capabilities() is only used inside video_detect.c so make it static. While at it also remove the prototype for the non existent acpi_video_display_switch_support function from acpi.h Signed-off-by: Hans de Goede hdego...@redhat.com --- drivers/acpi/video_detect.c | 3 +-- include

[PATCH 02/32] acpi-video-detect: Remove the unused acpi_video_dmi_demote_vendor() function

2015-06-10 Thread Hans de Goede
Remove the now unused acpi_video_dmi_demote_vendor() function, this was never a proper counter part of acpi_video_dmi_promote_vendor() since the calls to acpi_video_dmi_promote_vendor() are not counted. Signed-off-by: Hans de Goede hdego...@redhat.com --- drivers/acpi/video_detect.c | 9

[PATCH 08/32] acpi-video-detect: Unregister acpi_video backlight when dmi quirks are added

2015-06-10 Thread Hans de Goede
to the new backlight interface selection API. Signed-off-by: Hans de Goede hdego...@redhat.com --- drivers/acpi/video_detect.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/acpi/video_detect.c b/drivers/acpi/video_detect.c index 01c8c46..98368cf 100644 --- a/drivers/acpi/video_detect.c

[PATCH 00/32] acpi-video: Rewrite backlight interface selection logic

2015-06-10 Thread Hans de Goede
Hi All, Here is the long promised rewrite / cleanup of the acpi-video (and platform/x86) backlight interface selection logic. Reviewers do not be alarmed by the large number of patches, the gist of the series is in patches 6-13, the earlier ones are a few simple prepararion patches, and the

[PATCH 01/32] apple-gmux: Stop using acpi_video_dmi_demote_vendor()

2015-06-10 Thread Hans de Goede
fix would be to dmi-blacklist the gmux driver on that system. Signed-off-by: Hans de Goede hdego...@redhat.com --- drivers/platform/x86/apple-gmux.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/platform/x86/apple-gmux.c b/drivers/platform/x86/apple-gmux.c index 45032ce..a7f6412

[PATCH 30/32] toshiba-acpi: Port to new backlight interface selection API

2015-06-10 Thread Hans de Goede
Port the backlight selection logic to the new backlight interface selection API. Also fix a compiler warning about bt_present not being initialized. Signed-off-by: Hans de Goede hdego...@redhat.com --- drivers/platform/x86/toshiba_acpi.c | 9 +++-- 1 file changed, 3 insertions(+), 6

[PATCH 29/32] thinkpad-acpi: Port to new backlight interface selection API

2015-06-10 Thread Hans de Goede
Port the backlight selection logic to the new backlight interface selection API. Signed-off-by: Hans de Goede hdego...@redhat.com --- drivers/platform/x86/thinkpad_acpi.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/platform/x86/thinkpad_acpi.c b/drivers

[PATCH 31/32] acpi-video-detect: Remove old API

2015-06-10 Thread Hans de Goede
Remove the old backlight interface selection API now that all drivers have been ported to the new API. Signed-off-by: Hans de Goede hdego...@redhat.com --- drivers/acpi/video_detect.c | 31 --- include/linux/acpi.h| 19 --- 2 files changed, 50

[PATCH 14/32] acer-wmi: Port to new backlight interface selection API

2015-06-10 Thread Hans de Goede
they are not necessary, if the user wants to know which backlight interfaces are registered a simple ls /sys/class/backlight suffices. Signed-off-by: Hans de Goede hdego...@redhat.com --- drivers/platform/x86/acer-wmi.c | 10 +++--- 1 file changed, 3 insertions(+), 7 deletions(-) diff --git

[PATCH 24/32] intel-oaktrail: Port to new backlight interface selection API

2015-06-10 Thread Hans de Goede
they are not necessary, if the user wants to know which backlight interfaces are registered a simple ls /sys/class/backlight suffices. Signed-off-by: Hans de Goede hdego...@redhat.com --- drivers/platform/x86/intel_oaktrail.c | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git

[PATCH 17/32] asus-wmi: Port to new backlight interface selection API

2015-06-10 Thread Hans de Goede
they are not necessary, if the user wants to know which backlight interfaces are registered a simple ls /sys/class/backlight suffices. Signed-off-by: Hans de Goede hdego...@redhat.com --- drivers/platform/x86/asus-wmi.c | 15 +++ 1 file changed, 7 insertions(+), 8 deletions(-) diff --git

[PATCH 19/32] dell-laptop: Port to new backlight interface selection API

2015-06-10 Thread Hans de Goede
Port the backlight selection logic to the new backlight interface selection API. Signed-off-by: Hans de Goede hdego...@redhat.com --- drivers/platform/x86/dell-laptop.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/platform/x86/dell-laptop.c b/drivers

[PATCH 16/32] asus-laptop: Port to new backlight interface selection API

2015-06-10 Thread Hans de Goede
they are not necessary, if the user wants to know which backlight interfaces are registered a simple ls /sys/class/backlight suffices. Signed-off-by: Hans de Goede hdego...@redhat.com --- drivers/platform/x86/asus-laptop.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git

[PATCH 11/32] acpi-video: Move backlight notifier to video_detect.c

2015-06-10 Thread Hans de Goede
and it needlessly complicates the code. Signed-off-by: Hans de Goede hdego...@redhat.com --- drivers/acpi/video.c| 59 ++--- drivers/acpi/video_detect.c | 27 + 2 files changed, 29 insertions(+), 57 deletions(-) diff --git a/drivers/acpi

[PATCH 18/32] compal-laptop: Port to new backlight interface selection API

2015-06-10 Thread Hans de Goede
Port the backlight selection logic to the new backlight interface selection API. Signed-off-by: Hans de Goede hdego...@redhat.com --- drivers/platform/x86/compal-laptop.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/platform/x86/compal-laptop.c b/drivers

[PATCH 13/32] acpi-video: Fix acpi_video _register vs _unregister_backlight race

2015-06-10 Thread Hans de Goede
safe manner, this commit adds locking to make this thread safe. Signed-off-by: Hans de Goede hdego...@redhat.com --- drivers/acpi/video.c | 43 +-- 1 file changed, 21 insertions(+), 22 deletions(-) diff --git a/drivers/acpi/video.c b/drivers/acpi/video.c

  1   2   >