Re: [qooxdoo-devel] QxCompiler - add ES6, faster compilation, and 100% Javascript API to building applications

evel@lists.sourceforge.net Subject: Re: [qooxdoo-devel] QxCompiler - add ES6, faster compilation, and 100% Javascript API to building applications Hi John, so i've been thinking how i would start creating the part loader which should be "easy" to create with how you set up the things

Re: [qooxdoo-devel] QxCompiler - add ES6, faster compilation, and 100% Javascript API to building applications

Hi Defero, You need to check the following for dynamic loading: 1. if the part has already been loaded (version, build, date etc) - different versions of the same part might be loadable at the same time - different language parts - etc 2. if there are cross referencing 3. circle referencing

Re: [qooxdoo-devel] QxCompiler - add ES6, faster compilation, and 100% Javascript API to building applications

Hi John, so i've been thinking how i would start creating the part loader which should be "easy" to create with how you set up the things. But for it to fit our purpose here, it asks that only a single part/library can be recompiled. I'm not sure if there is a nice way of achieving this. In case

Re: [qooxdoo-devel] QxCompiler - add ES6, faster compilation, and 100% Javascript API to building applications

On 23/02/2016, 11:33, "d...@cost-savers.net" wrote: >We can look at it and try to replace all python with grunt integration further >on the line the core team did before. >I can back on this asap. > >Stefan > Fantastic :) Cheers John

Re: [qooxdoo-devel] QxCompiler - add ES6, faster compilation, and 100% Javascript API to building applications

Stefan, Adrian, Quick googling shows that there are several grunt plugins around that allow to execute tasks simultaneously: grunt-parallel, grunt- parallelize, grunt-concurrent. The latter looks maintained and promising in all the ways. As a proof of concept, could someone try to run, say, two

Re: [qooxdoo-devel] QxCompiler - add ES6, faster compilation, and 100% Javascript API to building applications

Thomas, > I could see Grunt being a command-line frontend for the jobs, with > QxCompiler remaining a pure API-based library which is included as a > dependency and utilized from Grunt files. I agree completely with you in this! Don't invent the wheel again! > Even if you feel the code in

Re: [qooxdoo-devel] QxCompiler - add ES6, faster compilation, and 100% Javascript API to building applications

On Mon, Feb 22, 2016 at 6:38 PM, Adrian Haarbach wrote: > > > *Then to install all dependencies and run, just do:* > > npm install -g grunt-cli > npm install //installs dependencies listed in package.json into > node_modules folder > grunt //runs default http-server:dev job

Re: [qooxdoo-devel] QxCompiler - add ES6, faster compilation, and 100% Javascript API to building applications

Hi Stefan Thanks for the support, Im glad you like it :) I agree that QxCompiler needs to stay focused on compiling, IMHO generate.py became the swiss army knife of the Qooxdoo toolchain and being written in Python and not as an API made made it opaque (for my purposes, at least) Generate.py

Re: [qooxdoo-devel] QxCompiler - add ES6, faster compilation, and 100% Javascript API to building applications

t> Subject: Re: [qooxdoo-devel] QxCompiler - add ES6, faster compilation, and 100% Javascript API to building applications Feature request: background recompiler + web server + reloader In qooxdoo development, it's common practice to use a micro HTTP server to run applications, eg. python -

Re: [qooxdoo-devel] QxCompiler - add ES6, faster compilation, and 100% Javascript API to building applications

Adrian, Please make a doc pull request too... see the doc format etc to make it fit well into the manual...at the right place If not the doc will lag...never good for new users! Stefan > Hi Stefan, > > here is the pull request: https://github.com/qooxdoo/qooxdoo/pull/175: > > Added grunt task

Re: [qooxdoo-devel] QxCompiler - add ES6, faster compilation, and 100% Javascript API to building applications

John, We really like your approach of the qxcompiler. I think it is very important to keep it clean and clear-cut as a tool and not complicate it now. There might be many wishes to do this and that. It is good if not moved too fast before knowing what is best for the subproject. Your ideas

Re: [qooxdoo-devel] QxCompiler - add ES6, faster compilation, and 100% Javascript API to building applications

Dimitri, Independently, of course... Stefan > Adrian, > > Sounds pretty cool! Unfortunately there's one missing link here - > QxCompiler is not a Grunt task yet. > > BTW, is Grunt capable of running two or more background tasks > simultaneously? eg. QxCompiler job + web server > Or do we need

Re: [qooxdoo-devel] QxCompiler - add ES6, faster compilation, and 100% Javascript API to building applications

Adrian, Fantastic! This shows how strong and fast a community can be. Thanks! Stefan > Hi Stefan, > > here is the pull request: https://github.com/qooxdoo/qooxdoo/pull/175: > > Added grunt task source-server-nodejs to the grunt templates. > Now you have the choice between > grunt

Re: [qooxdoo-devel] QxCompiler - add ES6, faster compilation, and 100% Javascript API to building applications

Hi Adrian Then to install all dependencies and run, just do: npm install -g grunt-cli npm install //installs dependencies listed in package.json into node_modules folder grunt //runs default http-server:dev job Looking forward to ditch ./generate.py in favor of a simple and faster grunt

Re: [qooxdoo-devel] QxCompiler - add ES6, faster compilation, and 100% Javascript API to building applications

There’s a new release that went out just before the translation mod that does the shared cache - although the source-output directory is currently very similar to build-output, this is only temporary because build options can change the code which is output. This is primarily that calls to

Re: [qooxdoo-devel] QxCompiler - add ES6, faster compilation, and 100% Javascript API to building applications

Hi Stefan, here is the pull request: https://github.com/qooxdoo/qooxdoo/pull/175: Added grunt task source-server-nodejs to the grunt templates. Now you have the choice between grunt source-server -> python SimpleHttpServer grunt source-server-nodejs -> node grunt-http-server cheers, Adrian

Re: [qooxdoo-devel] QxCompiler - add ES6, faster compilation, and 100% Javascript API to building applications

Adrian, This is great. We have thought of using it instead of simple Now you have done the job. Is it possible to make it universal and into pull requestable files...? We will put it on our todo list to exchange the simple python server... Stefan > Concerning the webserver, I am using

Re: [qooxdoo-devel] QxCompiler - add ES6, faster compilation, and 100% Javascript API to building applications

Concerning the webserver, I am using Grunt and the grunt-http-server plugin, which is based on node.js and much faster than python's SimpleHttpServer in serving files. Also, it allows to specify a proxy where it redirects all requests it cannot

Re: [qooxdoo-devel] QxCompiler - add ES6, faster compilation, and 100% Javascript API to building applications

Feature request: background recompiler + web server + reloader In qooxdoo development, it's common practice to use a micro HTTP server to run applications, eg. python -m SimpleHTTPServer, generate.py source-server, editor/IDE embedded etc. This is because of limitations of file:/// addressing

Re: [qooxdoo-devel] QxCompiler - add ES6, faster compilation, and 100% Javascript API to building applications

John, Seems like our projects have slightly different scope, but at the same time they'll definitely have much in common. We currently focus on JavaEE for our backend development, and radical paradigm change is unlikely in foreseeable future. The key points of the forthcoming project will be: -

Re: [qooxdoo-devel] QxCompiler - add ES6, faster compilation, and 100% Javascript API to building applications

ucker" <zauc...@oetiker.ch> > Sent: Friday, February 19, 2016 8:42 AM > To: "qooxdoo Development" <qooxdoo-devel@lists.sourceforge.net> > Subject: Re: [qooxdoo-devel] QxCompiler - add ES6, faster > compilation, and 100% Javascript API to building applications >   >

Re: [qooxdoo-devel] QxCompiler - add ES6, faster compilation, and 100% Javascript API to building applications

From: "Fritz Zaucker" <zauc...@oetiker.ch> Sent: Friday, February 19, 2016 8:42 AM To: "qooxdoo Development" <qooxdoo-devel@lists.sourceforge.net> Subject: Re: [qooxdoo-devel] QxCompiler - add ES6, faster compilation, and 100% Javascript API to buil

Re: [qooxdoo-devel] QxCompiler - add ES6, faster compilation, and 100% Javascript API to building applications

> >Slightly offtopic: did you try Nashorn with your server-side? Should be >much faster and feature-rich. Besides, we are planning an opensource >project - JavaScript console for JavaEE with qooxdoo frontend a la >Playground. It would allow to author/run/manage server-side scripts, >with support

Re: [qooxdoo-devel] QxCompiler - add ES6, faster compilation, and 100% Javascript API to building applications

Hi John, I understood it as a means to profile QxCompiler. But even if Dimitri had something else in mind, it probably would be useful to know where QxCompiler spends most of it's time in order to focus on optimizing at the right place. BWT, I am looking forward to trying QxCompiler myself,

Re: [qooxdoo-devel] QxCompiler - add ES6, faster compilation, and 100% Javascript API to building applications

BTW I missed you comment on this earlier - by profiling, do you mean of the compilation process or injecting profiling statements into the generated code? On 18/02/2016, 17:51, "Dimitri" wrote: >I'm not a Node.js pro (I'm a JavaEE architect in fact :) so I'm not

Re: [qooxdoo-devel] QxCompiler - add ES6, faster compilation, and 100% Javascript API to building applications

│ ├─┬ babel-plugin-transform-es2015-literals@6.5.0 >> > │ ├─┬ babel-plugin-transform-es2015-modules-commonjs@6.5.2 >> > │ ├─┬ babel-plugin-transform-es2015-object-super@6.5.0 >> > │ ├─┬ babel-plugin-transform-es2015-parameters@6.5.0 >> > │ ├─┬ babel-plugin-transform-es2

Re: [qooxdoo-devel] QxCompiler - add ES6, faster compilation, and 100% Javascript API to building applications

Hi Dimitri You’ve done everything right but I’ve realised my mistake is that it’s not just the database any more, it’s the transpiled code is specific to each target and that it what’s taking the time. So the correct solution is that I must change QxCompiler to that several applications can

Re: [qooxdoo-devel] QxCompiler - add ES6, faster compilation, and 100% Javascript API to building applications

John, I gave it a shot, but not sure if I did it right. In create-app- demo.js, I adjusted dbFilename to point to absolute location in /tmp. First time compilation took ~30 seconds. Then I removed source-output, as if it were a clean checkout, tried to recompile and observed no speed-up at all.

Re: [qooxdoo-devel] QxCompiler - add ES6, faster compilation, and 100% Javascript API to building applications

ins that was in QxCompiler previously was the > > equivalent of the es2015 preset, albeit the list was slightly out > > of date so updating the code to use a preset instead of plugins > > should only improve support, but you had it working with the preset > > yeste

Re: [qooxdoo-devel] QxCompiler - add ES6, faster compilation, and 100% Javascript API to building applications

Centos 6 VM now runs without any complaints so it might be worth updating and trying again. Regards John From: Dimitri <mi...@cargosoft.ru> Reply-To: qooxdoo Development <qooxdoo-devel@lists.sourceforge.net> Date: Wednesday, 17 February 2016 at 23:02 To: <qooxdoo-devel@lists.sourceforge.n

Re: [qooxdoo-devel] QxCompiler - add ES6, faster compilation, and 100% Javascript API to building applications

No problem; the next release will have a dbFilename property on qxcompiler.makers.Maker, so compile-app-demo.js now has this: // Makers use an Analyser to figure out what the Target should write var maker = new qxcompiler.makers.SimpleApp("qxt.Application", "qxt.theme.Theme").set({ // Targets

Re: [qooxdoo-devel] QxCompiler - add ES6, faster compilation, and 100% Javascript API to building applications

Feature request: shared cache = It's common practise in continuous integration that CI server does a clean checkout per each build. Incremental builds are common practise too, but they can be unreliable and problematic, especially for complex builds. At the moment,

Re: [qooxdoo-devel] QxCompiler - add ES6, faster compilation, and 100% Javascript API to building applications

you have Babel installed globally and it’s > conflicting somehow?  I’ve updated the package.json at GitHub to > explicitly reference babel-types, and rechecking out etc on my Centos > 6 VM now runs without any complaints so it might be worth updating > and trying again. > > Regards > John

Re: [qooxdoo-devel] QxCompiler - add ES6, faster compilation, and 100% Javascript API to building applications

ary 2016 at 23:02 To: <qooxdoo-devel@lists.sourceforge.net> Subject: Re: [qooxdoo-devel] QxCompiler - add ES6, faster compilation, and 100% Javascript API to building applications [mitya@localhost qxcompiler]$ ./test/compile-app-demo.js Error: Error: ENOENT: no such file or directory,

Re: [qooxdoo-devel] QxCompiler - add ES6, faster compilation, and 100% Javascript API to building applications

Dimitri <mi...@cargosoft.ru> > Reply-To: qooxdoo Development <qooxdoo-devel@lists.sourceforge.net> > Date: Wednesday, 17 February 2016 at 22:31 > To: <qooxdoo-devel@lists.sourceforge.net> > Subject: Re: [qooxdoo-devel] QxCompiler - add ES6, faster > compilation, and 100% Javascri

Re: [qooxdoo-devel] QxCompiler - add ES6, faster compilation, and 100% Javascript API to building applications

t;qooxdoo-devel@lists.sourceforge.net> Subject: Re: [qooxdoo-devel] QxCompiler - add ES6, faster compilation, and 100% Javascript API to building applications No cigar this time :-\ [mitya@localhost test]$ ./compile-app-demo.js /home/mitya/qxcompiler/node_modules/babel-core/lib/transformation/file/options

Re: [qooxdoo-devel] QxCompiler - add ES6, faster compilation, and 100% Javascript API to building applications

then saw your email so switched > back. > > I’ve done the #! entries too > > I’ve pushed a new release, give it a go :) > > John > > From: Dimitri <mi...@cargosoft.ru> > Reply-To: qooxdoo Development <qooxdoo-devel@lists.sourceforge.net> > Date:

Re: [qooxdoo-devel] QxCompiler - add ES6, faster compilation, and 100% Javascript API to building applications

ooxdoo Development <qooxdoo-devel@lists.sourceforge.net> Date: Wednesday, 17 February 2016 at 20:56 To: qooxdoo Development <qooxdoo-devel@lists.sourceforge.net> Subject: Re: [qooxdoo-devel] QxCompiler - add ES6, faster compilation, and 100% Javascript API to building applications Got

Re: [qooxdoo-devel] QxCompiler - add ES6, faster compilation, and 100% Javascript API to building applications

ge.net> Subject: Re: [qooxdoo-devel] QxCompiler - add ES6, faster compilation, and 100% Javascript API to building applications Just a quick follow-up on Babel - I've rolled back to yesterday's version, edited lib/qxcompiler/ClassFile.js:218, replaced that plugins array with presets: [ "es

Re: [qooxdoo-devel] QxCompiler - add ES6, faster compilation, and 100% Javascript API to building applications

Just a quick follow-up on Babel - I've rolled back to yesterday's version, edited lib/qxcompiler/ClassFile.js:218, replaced that plugins array with presets: [ "es2015" ]. Suddenly, it worked :) I'm still wondering why it doesn't try to look for any .babelrc file. It's clearly stated in the docs

Re: [qooxdoo-devel] QxCompiler - add ES6, faster compilation, and 100% Javascript API to building applications

ranslations will be included. >  Hopefully todays release will include build target compression too. > > Regards > John > > From: Dimitri <mi...@cargosoft.ru> > Reply-To: qooxdoo Development <qooxdoo-devel@lists.sourceforge.net> > Date: Tuesday, 16 February 2016 at 21:34 &g

Re: [qooxdoo-devel] QxCompiler - add ES6, faster compilation, and 100% Javascript API to building applications

ebruary 2016 at 09:08 To: qooxdoo Development <qooxdoo-devel@lists.sourceforge.net> Subject: Re: [qooxdoo-devel] QxCompiler - add ES6, faster compilation, and 100% Javascript API to building applications Hi Dimitri No worries, those are the kind of bug reports I like to hear, ones where it’s

Re: [qooxdoo-devel] QxCompiler - add ES6, faster compilation, and 100% Javascript API to building applications

Re: [qooxdoo-devel] QxCompiler - add ES6, faster compilation, and 100% Javascript API to building applications Hi John, Sorry for all the stir I've raised around resource handling. The problem was in our code. It turned out that we were still using old-style compiler hints (#asset, #use, #require e

Re: [qooxdoo-devel] QxCompiler - add ES6, faster compilation, and 100% Javascript API to building applications

uire() is already present so my mods to the > > > > framework have been kept to a minimum. > > > > > > > > I quite like that the database (the equivalent of generator’s > > > > cache) is kept quite small too - around 1Mb, and tracking the &

Re: [qooxdoo-devel] QxCompiler - add ES6, faster compilation, and 100% Javascript API to building applications

day, 16 February 2016 at 07:26 > To: qooxdoo Development <qooxdoo-devel@lists.sourceforge.net> > Subject: Re: [qooxdoo-devel] QxCompiler - add ES6, faster > compilation, and 100% Javascript API to building applications > > Hi Dimitri > > So it sounds like resources

Re: [qooxdoo-devel] QxCompiler - add ES6, faster compilation, and 100% Javascript API to building applications

Hi John, Sorry for all the stir I've raised around resource handling. The problem was in our code. It turned out that we were still using old- style compiler hints (#asset, #use, #require etc.) ignored by QxCompiler. This in fact caused both issues (resources and unmarshalling). With #asset being

Re: [qooxdoo-devel] QxCompiler - add ES6, faster compilation, and 100% Javascript API to building applications

hat the database (the equivalent of generator’s cache) is >>> kept quite small too - around 1Mb, and tracking the dependencies of methods >>> would add a lot of data as well as code complexity so if I can keep it this >>> way then that would be ideal. >>&

Re: [qooxdoo-devel] QxCompiler - add ES6, faster compilation, and 100% Javascript API to building applications

s >> John >> >> From: thron7 <thr...@users.sourceforge.net> >> Reply-To: qooxdoo Development <qooxdoo-devel@lists.sourceforge.net> >> Date: Monday, 15 February 2016 at 22:34 >> To: qooxdoo Development <qooxdoo-devel@lists.sourceforge.net&g

Re: [qooxdoo-devel] QxCompiler - add ES6, faster compilation, and 100% Javascript API to building applications

doo-devel@lists.sourceforge.net> Date: Tuesday, 16 February 2016 at 07:26 To: qooxdoo Development <qooxdoo-devel@lists.sourceforge.net> Subject: Re: [qooxdoo-devel] QxCompiler - add ES6, faster compilation, and 100% Javascript API to building applications Hi Dimitri So it sounds like resourc

Re: [qooxdoo-devel] QxCompiler - add ES6, faster compilation, and 100% Javascript API to building applications

Hi Dietrich Yes, I see your point - I use Centos 6.x so I have the same issue. When the core functionality is settled, I’ll go back and look again at using Babel and see what version of Node we can support Regards John On 16/02/2016, 08:18, "Dietrich Streifert"

Re: [qooxdoo-devel] QxCompiler - add ES6, faster compilation, and 100% Javascript API to building applications

ly-To: qooxdoo Development <qooxdoo-devel@lists.sourceforge.net> > Date: Monday, 15 February 2016 at 22:34 > To: qooxdoo Development <qooxdoo-devel@lists.sourceforge.net> > Subject: Re: [qooxdoo-devel] QxCompiler - add ES6, faster compilation, and > 100% Javascript API

Re: [qooxdoo-devel] QxCompiler - add ES6, faster compilation, and 100% Javascript API to building applications

Hi, currently i'm still in the process of playing around with it, looking under the hood a bit in my free time But yeah, it will be on my priority todo list to create a part loader. Defero -- View this message in context:

Re: [qooxdoo-devel] QxCompiler - add ES6, faster compilation, and 100% Javascript API to building applications

Hi John, we are using Centos 7.2 aka RHEL 7.2 which delivers nodejs 0.10.36 through epel repository. Regards Dietrich Am 16.02.2016 um 08:26 schrieb John Spackman: > Re Node 0.12: I think there was another problem with early versions of > Node <= 0.12 other than just language – I can’t

Re: [qooxdoo-devel] QxCompiler - add ES6, faster compilation, and 100% Javascript API to building applications

Monday, 15 February 2016 at 18:16 To: <qooxdoo-devel@lists.sourceforge.net> Subject: Re: [qooxdoo-devel] QxCompiler - add ES6, faster compilation, and 100% Javascript API to building applications Hi! Tried again - things are much better now :) However, two issues still remain, one of them

Re: [qooxdoo-devel] QxCompiler - add ES6, faster compilation, and 100% Javascript API to building applications

Hi Defero Thanks :) I found a bug in util.mkpath yesterday that might have been the problem you found - mkpath would start to create the folders and then stop, but that’s fixed now. Are you thinking of having a look at part loading? John On 15/02/2016, 17:15, "Defero"

Re: [qooxdoo-devel] QxCompiler - add ES6, faster compilation, and 100% Javascript API to building applications

doo-devel@lists.sourceforge.net> Date: Monday, 15 February 2016 at 22:34 To: qooxdoo Development <qooxdoo-devel@lists.sourceforge.net> Subject: Re: [qooxdoo-devel] QxCompiler - add ES6, faster compilation, and 100% Javascript API to building applications John, this looks interesting! I like the

Re: [qooxdoo-devel] QxCompiler - add ES6, faster compilation, and 100% Javascript API to building applications

John, this looks interesting! I like the API-based approach (Reminds me of the Clojure "boot" build system's tag line, "Builds are programs"[1]). It seems you have been working on that for a while. [1] http://boot-clj.com/ On Mon, Feb 15, 2016 at 9:28 AM, John Spackman

Re: [qooxdoo-devel] QxCompiler - add ES6, faster compilation, and 100% Javascript API to building applications

h to get you going on the next step. Don’t forget to checkout > the qooxdoo repo as well as the main QxCompiler one. > > Cheers > John > > > From: Dimitri <mi...@cargosoft.ru> > Reply-To: qooxdoo Development <qooxdoo-devel@lists.sourceforge.net> > Date: Monday,

Re: [qooxdoo-devel] QxCompiler - add ES6, faster compilation, and 100% Javascript API to building applications

Hi, congratulations on the release I've already started to play around a bit and will send you a pull request for it. While trying to set it up, i've run into a little snag at the following: qxcompiler\lib\util.js line: 305 code : return fs.mkdir(made, function(err) { and because fs.mkdir (in

Re: [qooxdoo-devel] QxCompiler - add ES6, faster compilation, and 100% Javascript API to building applications

February 2016 at 03:28 To: qooxdoo Development <qooxdoo-devel@lists.sourceforge.net> Subject: Re: [qooxdoo-devel] QxCompiler - add ES6, faster compilation, and 100% Javascript API to building applications Hi John! Ready for another dozen of questions and bug reports? ;) 1. As for testdata

Re: [qooxdoo-devel] QxCompiler - add ES6, faster compilation, and 100% Javascript API to building applications

From: Dietrich Streifert <dietrich.streif...@googlemail.com> Reply-To: qooxdoo Development <qooxdoo-devel@lists.sourceforge.net> Date: Monday, 15 February 2016 at 08:04 To: qooxdoo Development <qooxdoo-devel@lists.sourceforge.net> Subject: Re: [qooxdoo-devel] QxCompiler

Re: [qooxdoo-devel] QxCompiler - add ES6, faster compilation, and 100% Javascript API to building applications

Hi John Congratulations! One question regarding this passage in the README.md: *NOTE*While QxCompiler is backward compatible with generate.py and does not require changes to your code, ES6 support requires that strict mode is enabled and this can introduce a few minor compatibility issues;

Re: [qooxdoo-devel] QxCompiler - add ES6, faster compilation, and 100% Javascript API to building applications

I say "should" because I realise now that I havn't > tested them for a few weeks now and I should give them the once over > ASAP :)  I've got to go out shortly so I'll take a look this evening. >   > John >   >   > From: "Dimitri" <mi...@cargosoft.ru>

Re: [qooxdoo-devel] QxCompiler - add ES6, faster compilation, and 100% Javascript API to building applications

I've got to go out shortly so I'll take a look this evening. John From: "Dimitri" <mi...@cargosoft.ru> Sent: Sunday, February 14, 2016 2:27 AM To: "qooxdoo Development" <qooxdoo-devel@lists.sourceforge.net> Subject: Re: [qoo

Re: [qooxdoo-devel] QxCompiler - add ES6, faster compilation, and 100% Javascript API to building applications

lt;john.spack...@zenesis.com> Sent: Sunday, February 14, 2016 9:50 AM To: "qooxdoo Development" <qooxdoo-devel@lists.sourceforge.net> Subject: Re: [qooxdoo-devel] QxCompiler - add ES6, faster compilation, and 100% Javascript API to building applications Hi Dimitri Thanks for checki

Re: [qooxdoo-devel] QxCompiler - add ES6, faster compilation, and 100% Javascript API to building applications

John, congratulations with the long awaited release! :) qooxdoo guys, do you think that project like this could at some moment land in qooxdoo and get official support? What about qooxdoo patches (mostly strict mode compatibility related, AFAIK) - could they be merged upstream? This would reduce