On 24/12/10 14:02, Julian Taylor wrote: > On Fri, 2010-12-24 at 02:04 +0000, Mateusz Loskot wrote: > ... >> Hmm, it looks we would need to change a bit the layout of repo and bury >> the headers in Git, >> inside to /include/soci but keep .cpp files in /src/ > > > I would propose a different approach: > keep using non buried headers for building soci itself, but the public > api headers use buried includes by default. > The .cpp files need no change. > > e.g soci-sqlite3.h: > #include <vector> > #ifdef SOCI_HEADERS_NOT_BURIED > #include "soci-backend.h" > #else > #include <soci/soci-backend.h> > #endif > > This way the repository does not need reorganizing, only > SOCI_HEADERS_NOT_BURIED needs to be defined in the build. > > The headers which are public now do not require additional include paths > provided by the user. > > If the user wants to use the non-buried variant he can still do so by > defining SOCI_HEADERS_NOT_BURIED and adding the include paths manually. > g++ sqlite3.cpp -DSOCI_HEADERS_NOT_BURIED -I/usr/include/soci (+linking) > the others can just use: > g++ sqlite3.cpp (+linking) > > This would also be very little work. We only need to change the public > headers installed in subfolders (= backends).
Julian, I like this idea. At this moment of development, I'd prefer to go for least intrusive change to achieve the buried headers support. Denis, I agree the folder structure change is not very big deal, but if it turns to be unnecessary, I'd like to keep the structure as it is now. Also, Maciej has gone for holiday and I'd like to discuss such changes with him. We could discuss any changes to improve the source tree structure after the release. Does Julian's idea work for you? Thank you both for your efforts! Best regards, -- Mateusz Loskot, http://mateusz.loskot.net Charter Member of OSGeo, http://osgeo.org Member of ACCU, http://accu.org ------------------------------------------------------------------------------ Learn how Oracle Real Application Clusters (RAC) One Node allows customers to consolidate database storage, standardize their database environment, and, should the need arise, upgrade to a full multi-node Oracle RAC database without downtime or disruption http://p.sf.net/sfu/oracle-sfdevnl _______________________________________________ Soci-users mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/soci-users
