On 13.04.2011, at 21:28, Jerome Renard wrote: > Hello, > > I started to test Pake in the context of AZC. > > You can get the Pakefile if you svn up website/ > > You may also browse the file here: > - > https://fisheye6.atlassian.com/browse/zetacomponents/website/Pakefile?r=1091818 > > As you will see it is quite simple et much more readable that its Ant > equivalent. > > Any feedback welcome :)
line 30: I'd use pake_echo_comment() instead. same for other similar lines lines 94-117: 1) I'd use pake_sh($command, true) 2) don't forget to use escapeshellarg() where appropriate lines 134-137: pake_mkdirs($targetDir, 0755); // no need for "if". pake take cares of that lines 139-149: pake_copy($tarball, $targetDir.'/'.$options['build.name'].'.tar.bz2'); lines 142-143: pake_remove_dir($options['build.dir'] . '/phpdoc/'); lines 243-245: pake_rename( $HTMLFile, dirname( $HTMLFile ) . '/' . $newHTMLFile ); pake's versions of basic filesystem-functions are good because: 1) they do nothing, if nothing has to be done (won't try to delete non-existant file, won't copy file if source is older than target) 2) they report what they do to console as the result, you have to type less code
