Hi Alexey, thanks for your feedback.
On Wed, Apr 13, 2011 at 10:40 PM, Alexey Zakhlestin <indey...@gmail.com> wrote: > [...] >> >> Any feedback welcome :) > > line 30: > I'd use pake_echo_comment() instead. same for other similar lines > Fixed. > lines 94-117: > 1) I'd use pake_sh($command, true) Fixed. > 2) don't forget to use escapeshellarg() where appropriate > Yep, I will take care of that later. > lines 134-137: > pake_mkdirs($targetDir, 0755); // no need for "if". pake take cares of that > Fixed > lines 139-149: > pake_copy($tarball, $targetDir.'/'.$options['build.name'].'.tar.bz2'); > Fixed > lines 142-143: > pake_remove_dir($options['build.dir'] . '/phpdoc/'); > Fixed > lines 243-245: > pake_rename( $HTMLFile, dirname( $HTMLFile ) . '/' . $newHTMLFile ); > Fixed > > pake's versions of basic filesystem-functions are good because: > 1) they do nothing, if nothing has to be done (won't try to delete > non-existant file, won't copy file if source is older than target) > 2) they report what they do to console > > as the result, you have to type less code Yep that is what I noticed, and that gave me a couple of ideas to enhance ezcBaseFile Thanks :)
