Philip Meyer;512890 Wrote: > I don't think it's a good idea to make special cases for particular > values within string tags. > > The logic becomes more complex.
does it? seems to me if bug 8324 was implemented: https://bugs.slimdevices.com/show_bug.cgi?id=8324 the logic becomes a lot LESS complex. at that point, once deactivated, only explicit comp=1 tags or user defined strings would mean "this is a comp." that then puts the user in control. they can decide if they want comp=1 tags, and/or they can decide if they want the scanner to recognize certain exact strings = comp. if they don't, blank out the fields, (like many do for guess tag formats). Philip Meyer;512890 Wrote: > "If there's an album artist tag that is the same on all songs on the > album, the album is not a compilation, unless compilation = 1 OR all > songs have album artist = Various Artists". > > i.e. if there is bad tagging such that album artist is not consistent > across all songs on an album, what would happen? what would happen now???? its borked either way. you always say that bag tagging is on the user, not SBS, but here you aren't going to say that? why? Philip Meyer;512890 Wrote: > "Various Artists" may not be the correct string to look for - some users > may use "VA" or "Various", etc, as their various artists name. thus why i say the user should be able to define the strings. Philip Meyer;512890 Wrote: > So such logic could lookup the library prefs string and compare against > that, but then if that string is changed, it would need to recalculate > compilation flag on all albums. so? no different than adjusting a comp tag from 0 or null to 1. Philip Meyer;512890 Wrote: > I think Andy said already that there are no "tidy-up" phases for the > in-proc scanner; it works everything out on the fly per-track. I guess > that means that when scanning an album with varying contributors that > isn't explicitly marked as a compilation, when the first song is > processed, it creates an album that is not a compilation, and then the > next song with a different artist would make it a compilation. After > that, it's already marked as a compilation, so it stops early when > processing further songs on the album. ok. so if it finds a comp tag its a comp, right? you could deactivate looking for artist mismatches, and save that complex comparison step, and instead simply look at the track for a pre-ordained user defined string. -- MrSinatra www.lion-radio.org using: sb2 & sbc (my home) / sbr (parent's home) - sbs 7.5b - win xp pro sp3 ie8 - p4(ht) 3.2ghz / 2gig ram - 1tb wd usb2 raid1 - d-link dir-655 - 35k mp3 ------------------------------------------------------------------------ MrSinatra's Profile: http://forums.slimdevices.com/member.php?userid=2336 View this thread: http://forums.slimdevices.com/showthread.php?t=74700 _______________________________________________ beta mailing list [email protected] http://lists.slimdevices.com/mailman/listinfo/beta
