[ 
https://issues.apache.org/jira/browse/BOOKKEEPER-310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13400641#comment-13400641
 ] 

Mridul Muralidharan commented on BOOKKEEPER-310:
------------------------------------------------



- I thought the standalone was commented out ? I think I had that in some 
earlier commit as part of testing since zookeeper (default) mode lead to a lot 
of server crashes (lost connection to zookeeper type errors).

- The changes to helper methods become relevant when properties get used in 
testcases. As of now, since they are not, it is not yet a problem.
But you are right, as soon as the new protocol changes get more widely used and 
tested, those two methods will need to be changed.


Are there any issues with the way seq-id is compared/returned for a publish ?
I was unsure of whether I was doing the right thing, and whether I was doing 
enough of the right thing (like in a multi-colo deployment, etc).


Thanks for the review Ivan !
                
> Changes in hedwig server to support JMS spec
> --------------------------------------------
>
>                 Key: BOOKKEEPER-310
>                 URL: https://issues.apache.org/jira/browse/BOOKKEEPER-310
>             Project: Bookkeeper
>          Issue Type: Sub-task
>            Reporter: Mridul Muralidharan
>         Attachments: hedwig-server.patch
>
>
> The primary changes are :
> a) Support modified protocol changes (optional body).
> b) Return the published message's seq-id in the response.
> c) Minor bugfix to Array indexing in bucket which was triggered in a testcase.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to