[
https://issues.apache.org/jira/browse/BOOKKEEPER-310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13402161#comment-13402161
]
Mridul Muralidharan commented on BOOKKEEPER-310:
------------------------------------------------
bq. could you provide more infos about this issue? I don't think it should over
bound.
This was observed as part of a test run - since the fix was obvious, i did not
try to debug it further.
Unfortunately, I do not have the test details now.
bq. seems you separated the protocol change and code change in different jiras.
it is not easy to review. so a better idea to create a jira like 'support
returning seq-id for publish requests' to include the protocol change, code
change and test cases together.
The jira's are split along the modules they impact (from the initial idea of
one mega-jira :-) ).
I did not want to create a lot of issues to handle all the individual changes;
since they are collectively required for the jms provider to function. In
addition, since the changes are interdependent at times, it is not possible to
always tease the changes apart - so left them as such.
If it is becoming a problem to review, I can consider splitting them further.
bq. It would be better to have a generic field called 'respBody' to adapt
different response body for different requests, otherwise we have to put lots
of optional fields in PubSubResponse for different requests. since
PubSubResponse is also used for Message delivery, it should not put too many
fields in future changes.
I agree, adding a new ResponseBody will minimize future changes; while allowing
us to extend to return other values in future.
> Changes in hedwig server to support JMS spec
> --------------------------------------------
>
> Key: BOOKKEEPER-310
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-310
> Project: Bookkeeper
> Issue Type: Sub-task
> Reporter: Mridul Muralidharan
> Attachments: hedwig-server.patch
>
>
> The primary changes are :
> a) Support modified protocol changes (optional body).
> b) Return the published message's seq-id in the response.
> c) Minor bugfix to Array indexing in bucket which was triggered in a testcase.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
