[
https://issues.apache.org/jira/browse/BOOKKEEPER-773?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14126576#comment-14126576
]
Sijie Guo commented on BOOKKEEPER-773:
--------------------------------------
I don't understand why it complex too.
still a few comments:
- you should put those two branches into two functions, rather than have too
much code.
- you could get all the options from command line first, and validate the
options and then execute different functions according to different options.
- it would be better to have test cases for renameBookieIdInLedger &
renameBookieIdInCookie
> Provide admin tool to rename bookie identifier in Cookies
> ---------------------------------------------------------
>
> Key: BOOKKEEPER-773
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-773
> Project: Bookkeeper
> Issue Type: Sub-task
> Components: bookkeeper-server
> Reporter: Rakesh R
> Assignee: Rakesh R
> Fix For: 4.3.0
>
> Attachments: 001-BOOKKEEPER-773-rename-bookieid-in-cookies.patch,
> 002-BOOKKEEPER-773-rename-bookieid-in-cookies.patch,
> 003-BOOKKEEPER-773-rename-bookieid-in-cookies.patch,
> 004-BOOKKEEPER-773-rename-bookieid.patch
>
>
> The idea of this JIRA to implement a mechanism to efficiently rename the
> bookie identifier present in the Cookies. Cookie information will be present
> in:
> - ledger & journal directories in each Bookie server
> - cookies znode in ZooKeeper
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
