[
https://issues.apache.org/jira/browse/BOOKKEEPER-773?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14129677#comment-14129677
]
Sijie Guo commented on BOOKKEEPER-773:
--------------------------------------
- it seems that the patch contains lots of unnecessary formats, it made hard to
review actually.
- still you didn't address my comments on renameBookieIdInLedger on
BOOKKEEPER-634. This tool should focus on real production use case, not just
print fancy information. The current implementation will definitely have huge
side effects on real production traffic, if you don't control the number of
requests issued to zookeeper. so -1 on renameBookieIdInLedger.
another suggestion, even you use same command 'bkrename', you don't actually
put all two tickets together.
you could do:
1) first implement the options for renaming bookie identifier, since I think we
are fine with your renaming bookie identifier part. (patch for BOOKKEEPER-773)
2) secondly add options to 'bkrename' to support renaming bookie in ledgers.
(another patch for BOOKKEEPER-634).
it is much clear and easier for reviewing and get things checked in faster.
> Provide admin tool to rename bookie identifier in Cookies
> ---------------------------------------------------------
>
> Key: BOOKKEEPER-773
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-773
> Project: Bookkeeper
> Issue Type: Sub-task
> Components: bookkeeper-server
> Reporter: Rakesh R
> Assignee: Rakesh R
> Fix For: 4.3.0
>
> Attachments: 001-BOOKKEEPER-773-rename-bookieid-in-cookies.patch,
> 002-BOOKKEEPER-773-rename-bookieid-in-cookies.patch,
> 003-BOOKKEEPER-773-rename-bookieid-in-cookies.patch,
> 004-BOOKKEEPER-773-rename-bookieid.patch,
> 005-BOOKKEEPER-773-rename-bookieid.patch
>
>
> The idea of this JIRA to implement a mechanism to efficiently rename the
> bookie identifier present in the Cookies. Cookie information will be present
> in:
> - ledger & journal directories in each Bookie server
> - cookies znode in ZooKeeper
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
