[
https://issues.apache.org/jira/browse/BOOKKEEPER-773?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14129701#comment-14129701
]
Sijie Guo commented on BOOKKEEPER-773:
--------------------------------------
{code}
I'd like to retain the progress information. How about adding a 'bandwidth'
parameter(by default 10 operations) - this will be maximum number of ledgers
which can be renamed concurrently. If 11th operation comes it will wait.
{code}
there are actually two concerns on your implementation: 1) you pulled all
ledgers into a list, which doesn't work if your cluster have a lot of ledgers.
you might not encounter this issue on hdfs namenode, but we have this issue on
a real production cluster. so don't pull all ledgers together into a list, use
ledger iterator. 2) you send all the requests immediately, which will overwhelm
the system.
'bandwidth' (it is actually 'concurrency') is good for 2). but it doesn't
resolve 1). if you do want retain the progress information, please provide two
different implementation, one is using your current solution, while the other
one is using ledger iterator. so people could choose what to use. although I
don't suggest to have two implementation on this, it would make code
maintenance become hard.
> Provide admin tool to rename bookie identifier in Cookies
> ---------------------------------------------------------
>
> Key: BOOKKEEPER-773
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-773
> Project: Bookkeeper
> Issue Type: Sub-task
> Components: bookkeeper-server
> Reporter: Rakesh R
> Assignee: Rakesh R
> Fix For: 4.3.0
>
> Attachments: 001-BOOKKEEPER-773-rename-bookieid-in-cookies.patch,
> 002-BOOKKEEPER-773-rename-bookieid-in-cookies.patch,
> 003-BOOKKEEPER-773-rename-bookieid-in-cookies.patch,
> 004-BOOKKEEPER-773-rename-bookieid.patch,
> 005-BOOKKEEPER-773-rename-bookieid.patch
>
>
> The idea of this JIRA to implement a mechanism to efficiently rename the
> bookie identifier present in the Cookies. Cookie information will be present
> in:
> - ledger & journal directories in each Bookie server
> - cookies znode in ZooKeeper
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
