[
https://issues.apache.org/jira/browse/BOOKKEEPER-773?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14129694#comment-14129694
]
Rakesh R commented on BOOKKEEPER-773:
-------------------------------------
bq. This tool should focus on real production use case, not just print fancy
information.
The idea of printing progress details is to help users if there are many
ledgers. Otw it would be hard to determine the completion time.
bq.This tool should focus on real production use case, not just print fancy
information. The current implementation will definitely have huge side effects
on real production traffic, if you don't control the number of requests issued
to zookeeper. so -1 on renameBookieIdInLedger
I agree with you. I'd like to retain the progress information. How about adding
a 'bandwidth' parameter(by default 10 operations) - this will be maximum number
of ledgers which can be renamed concurrently. If 11th operation comes it will
wait.
bq. it is much clear and easier for reviewing and get things checked in faster.
Yeah I will split the patches and do cleanup.
> Provide admin tool to rename bookie identifier in Cookies
> ---------------------------------------------------------
>
> Key: BOOKKEEPER-773
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-773
> Project: Bookkeeper
> Issue Type: Sub-task
> Components: bookkeeper-server
> Reporter: Rakesh R
> Assignee: Rakesh R
> Fix For: 4.3.0
>
> Attachments: 001-BOOKKEEPER-773-rename-bookieid-in-cookies.patch,
> 002-BOOKKEEPER-773-rename-bookieid-in-cookies.patch,
> 003-BOOKKEEPER-773-rename-bookieid-in-cookies.patch,
> 004-BOOKKEEPER-773-rename-bookieid.patch,
> 005-BOOKKEEPER-773-rename-bookieid.patch
>
>
> The idea of this JIRA to implement a mechanism to efficiently rename the
> bookie identifier present in the Cookies. Cookie information will be present
> in:
> - ledger & journal directories in each Bookie server
> - cookies znode in ZooKeeper
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
