On Thu, Oct 15, 2009 at 11:03 AM, Chase Phillips <[email protected]> wrote:
> Hi Andrew, > > On Wed, Oct 14, 2009 at 11:31 PM, Andrew Scherkus > <[email protected]>wrote: > >> Hrmm... it looks your script assumes depot_tools is in your PATH -- if it >> can't find it the script crashes. > > > Thanks for pointing this out. The hooks should fail gracefully in those > cases, so I'll make that happen. > > >> Trying to figure out a workaround. If all else fails I can always give in >> and add depot_tools to my PATH :) >> > > I am under the impression depot_tools in each of our PATHs was already a > hard requirement. Are tools like git-cl, git-try, trychange.py, etc in some > other directory in your PATH, or do you run them with absolute paths, or > ...? > For git-cl and git-try, they're symlinked from ~/bin to my depot_tools and everything seems to work. The difference here is that the git hook is executed from .git/hooks > > Giving in might be best. :) > Already did :) > > Chase > > >> >> On Wed, Oct 14, 2009 at 11:08 PM, Aaron Boodman <[email protected]> wrote: >> >>> >>> Hooray, this is awesome. >>> >>> On Wed, Oct 14, 2009 at 10:35 PM, Chase Phillips <[email protected]> >>> wrote: >>> > If you don't use git-cl, you can stop reading now. >>> > Attention git-cl users: git-cl now has presubmit support! New users >>> that >>> > set up their git checkout on or after Wednesday (2009/10/14) are >>> already >>> > configured with presubmit support. Feel free to skip >>> the setup instructions >>> > since you've already run them but read on to learn more about the >>> recent >>> > changes. >>> > Presubmit support for Existing Users (if you set up your git checkout >>> before >>> > 2009/10/14): >>> > Run these commands to install the required git hooks in your >>> repository: >>> > >>> > cd /work/chromium/src # where "/work/chromium/src" is the path to your >>> git >>> > repository >>> > gclient sync # to upgrade your copy of depot_tools and git-cl >>> > git cl config http://src.chromium.org/svn/ # to install the git-cl >>> presubmit >>> > hooks >>> > >>> > You must rerun the git cl config command in each of your local git >>> > repositories. >>> > New and updated git-cl commands: >>> > git-cl presubmit >>> > Runs upload and commit presubmit checks on the current changelist. >>> > git-cl upload >>> > Runs presubmit tests on upload, continues even if tests fail. >>> > git-cl dcommit >>> > Run presubmit tests on commit, halts if tests fail. >>> > To bypass the presubmit tests in upload or dcommit, use >>> > the --bypass-hooks flag. git-cl dcommit's -f now implies --bypass-hooks >>> > along with skipping the commit confirm prompt. >>> > Questions? >>> > Feel free to reply to me off-list with any questions you have. >>> > Thanks to Evan Martin, Marc-Antoine Ruel, and Nicolas Sylvain for their >>> help >>> > making git-cl presubmit support a reality. >>> > Chase >>> > > >>> > >>> >>> >>> >>> >> > --~--~---------~--~----~------------~-------~--~----~ Chromium Developers mailing list: [email protected] View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~----------~----~----~----~------~----~------~--~---
