On Thu, Oct 15, 2009 at 10:38 AM, Ojan Vafai <[email protected]> wrote:
> Replying off-list as requested... > Right! ;) > Firstly, this is awesome! > Thanks. > On Wed, Oct 14, 2009 at 10:35 PM, Chase Phillips <[email protected]>wrote: > >> git-cl upload >> Runs presubmit tests on upload, continues even if tests fail. >> > > This latter part is different than the gcl version. Is that intentional? I > don't have an opinion on which is the correct behavior, but it would be nice > to keep the scripts consistent. > I agree about keeping them as consistent as possible. However, my tests of gcl upload show they already have the same behavior here: gcl uploads the patch to codereview whether or not the presubmit step fails. I just tested this twice again to confirm it. You see gcl fail to upload if the presubmit step fails? > To bypass the presubmit tests in upload or dcommit, use >> the --bypass-hooks flag. git-cl dcommit's -f now implies --bypass-hooks >> along with skipping the commit confirm prompt. >> > > Ditto above. The gcl flag is --no-presubmit. > I considered both gcl and git's convention. I decided I would first wait to see if anyone cared enough to raise the issue and take it from there. :) git-cl is not Chromium-specific and using gcl's convention appeared to be a Chromium-specific solution. Based on that, I decided to go git's route where not running hooks is done using --bypass-hooks. This also seemed justified because git-cl's hooks could be used for more than just presubmit tests. It might be valid to add --no-presubmit to git-cl, or --bypass-hooks to gcl, or both. Thoughts? Chase --~--~---------~--~----~------------~-------~--~----~ Chromium Developers mailing list: [email protected] View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~----------~----~----~----~------~----~------~--~---
