On Thu, Oct 15, 2009 at 11:19 AM, Chase Phillips <[email protected]> wrote:
> On Thu, Oct 15, 2009 at 10:38 AM, Ojan Vafai <[email protected]> wrote: > >> Replying off-list as requested... >> > Right! ;) > Doh. > However, my tests of gcl upload show they already have the same behavior >> here: gcl uploads the patch to codereview whether or not the presubmit step >> fails. I just tested this twice again to confirm it. You see gcl fail to >> upload if the presubmit step fails? > > Huh. I just tested this and see the opposite (it did not upload). I made a change that breaks the test_expectations.txt presubmit check. Maybe that's just a bug? > git-cl is not Chromium-specific and using gcl's convention appeared to be a > Chromium-specific solution. Based on that, I decided to go git's route > where not running hooks is done using --bypass-hooks. This also seemed > justified because git-cl's hooks could be used for more than just presubmit > tests. > > It might be valid to add --no-presubmit to git-cl, or --bypass-hooks to > gcl, or both. Thoughts? > Ah. That makes more sense. Not sure it's worth bothering to put more work into this. As you said, if it becomes a problem we can always fix it later. --~--~---------~--~----~------------~-------~--~----~ Chromium Developers mailing list: [email protected] View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~----------~----~----~----~------~----~------~--~---
