On Thu, Oct 15, 2009 at 11:19 AM, Chase Phillips <[email protected]> wrote: >>> To bypass the presubmit tests in upload or dcommit, use >>> the --bypass-hooks flag. git-cl dcommit's -f now implies --bypass-hooks >>> along with skipping the commit confirm prompt. >> >> Ditto above. The gcl flag is --no-presubmit. > > I considered both gcl and git's convention. I decided I would first wait to > see if anyone cared enough to raise the issue and take it from there. :) > git-cl is not Chromium-specific and using gcl's convention appeared to be a > Chromium-specific solution. Based on that, I decided to go git's route > where not running hooks is done using --bypass-hooks. This also seemed > justified because git-cl's hooks could be used for more than just presubmit > tests. > It might be valid to add --no-presubmit to git-cl, or --bypass-hooks to gcl, > or both. Thoughts?
I agree with Chase's reasoning. Also, you shouldn't need to bypass hooks frequently enough for this to matter much, and nobody switches between these two tools (they either use one or the other). --~--~---------~--~----~------------~-------~--~----~ Chromium Developers mailing list: [email protected] View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~----------~----~----~----~------~----~------~--~---
