pankajastro commented on code in PR #39365:
URL: https://github.com/apache/airflow/pull/39365#discussion_r1587601385
##########
airflow/providers/pinecone/hooks/pinecone.py:
##########
@@ -216,7 +216,7 @@ def create_index(
index_name: str,
dimension: int,
spec: ServerlessSpec | PodSpec,
- metric: str | None = "cosine",
+ metric: str | None = None,
Review Comment:
changing the default value from `cosine` to `None` looks weird. can we keep
it to "cosine"?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
