rawwar commented on code in PR #39365:
URL: https://github.com/apache/airflow/pull/39365#discussion_r1587618803


##########
tests/system/providers/pinecone/example_pinecone_openai.py:
##########
@@ -75,15 +74,15 @@
     start_date=datetime(2023, 1, 1),
     catchup=False,
 ) as dag:
-
-    @setup
-    @task
-    def create_index():
-        from airflow.providers.pinecone.hooks.pinecone import PineconeHook
-
-        hook = PineconeHook()
-        hook.create_index(index_name=index_name, dimension=1536)

Review Comment:
   Trying to answer about why the hook's create_index no longer works without 
adding spec object:
   
   @pankajastro , we have now introduced a required argument which needs to be 
either a `ServerlessSpec` or a `PodSpec` object. Earlier, this is not the case. 
In the [migration 
guide](https://canyon-quilt-082.notion.site/Pinecone-Python-SDK-v3-0-0-Migration-Guide-056d3897d7634bf7be399676a4757c7b)
 , Please check the section with heading "Creating a pod index". I think this 
should give an example.  
   
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to