dstandish commented on code in PR #40468:
URL: https://github.com/apache/airflow/pull/40468#discussion_r1664448049
##########
airflow/executors/base_executor.py:
##########
@@ -122,6 +123,7 @@ class BaseExecutor(LoggingMixin):
job_id: None | int | str = None
name: None | ExecutorName = None
callback_sink: BaseCallbackSink | None = None
+ task_context_logger: TaskContextLogger
Review Comment:
> How? At the end, we'll have to use TaskContextLogger in providers. Unless
you want to copy TaskContextLogger in providers?
Well the first thing that occurred to me was to have an interface on
Executor (i.e. a method) that would be like, 'send_task_log` or something.
This could push to a queue that the scheduler could process periodically. It
would not be duplicating the task context log class because that has
substantially more going on; it would just be, providing an interface for
executors to dump messages to TI logs, without worrying about the underlying
mechanism.
But it's just an idea, if we want to explore keeping TaskContextLogger
private.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
