zabetak commented on a change in pull request #1157: [CALCITE-2969] Improve
design of join-like relational expressions
URL: https://github.com/apache/calcite/pull/1157#discussion_r285105435
##########
File path:
core/src/main/java/org/apache/calcite/rel/rules/SemiJoinProjectTransposeRule.java
##########
@@ -63,42 +63,35 @@
*/
private SemiJoinProjectTransposeRule(RelBuilderFactory relBuilderFactory) {
super(
- operand(SemiJoin.class,
+ operandJ(LogicalJoin.class, null, Join::isSemiJoin,
Review comment:
Correct me if I am wrong but people who will still use SemiJoin class or
subclasses may not realise that the existing rules have changed and do not
match anymore.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
