zabetak commented on a change in pull request #1157: [CALCITE-2969] Improve
design of join-like relational expressions
URL: https://github.com/apache/calcite/pull/1157#discussion_r281080746
##########
File path:
core/src/main/java/org/apache/calcite/rel/rules/JoinToCorrelateRule.java
##########
@@ -112,13 +112,13 @@ protected JoinToCorrelateRule(RelFactories.FilterFactory
filterFactory) {
* @param clazz Class of relational expression to match (must not be null)
* @param relBuilderFactory Builder for relational expressions
* @param description Description, or null to guess description
- * @param semiJoinTypeExtractor Function to get the {@link
org.apache.calcite.sql.SemiJoinType}
+ * @param semiJoinTypeExtractor Function to get the {@link JoinRelType}
* for the {@link
org.apache.calcite.rel.logical.LogicalCorrelate}
*/
private JoinToCorrelateRule(Class<? extends Join> clazz,
Review comment:
I think that the constructor is now redundant and can be removed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
