zabetak commented on a change in pull request #1157: [CALCITE-2969] Improve
design of join-like relational expressions
URL: https://github.com/apache/calcite/pull/1157#discussion_r279568694
##########
File path:
core/src/main/java/org/apache/calcite/rel/rules/SemiJoinProjectTransposeRule.java
##########
@@ -63,42 +63,35 @@
*/
private SemiJoinProjectTransposeRule(RelBuilderFactory relBuilderFactory) {
super(
- operand(SemiJoin.class,
+ operandJ(LogicalJoin.class, null, Join::isSemiJoin,
Review comment:
This change will make the rule behave differently. I am OK with the change
but I think we should mention the difference in history.md. This comment is
also worth considering in other rules where SemiJoin.class is replaced by
LogicalJoin.class.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
