zabetak commented on a change in pull request #1157: [CALCITE-2969] Improve
design of join-like relational expressions
URL: https://github.com/apache/calcite/pull/1157#discussion_r281081342
##########
File path:
core/src/main/java/org/apache/calcite/rel/rules/JoinToCorrelateRule.java
##########
@@ -77,18 +76,19 @@
*/
public static final JoinToCorrelateRule JOIN =
new JoinToCorrelateRule(LogicalJoin.class, RelFactories.LOGICAL_BUILDER,
- "JoinToCorrelateRule", join ->
SemiJoinType.of(join.getJoinType()));
+ "JoinToCorrelateRule", Join::getJoinType);
- @Deprecated // to be removed (should use JOIN instead), kept for backwards
compatibility
+ @Deprecated // To be removed (should use JOIN instead), kept for backwards
compatibility
Review comment:
After the current refactoring it seems that there is no need to have
multiple instances of the rule for different kind of joins. Maybe a single
instance of the rule can treat all kinds of joins. If that's the case we could
remove deprecation from `INSTANCE` and rather put it on `JOIN`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
