zabetak commented on a change in pull request #1157: [CALCITE-2969] Improve
design of join-like relational expressions
URL: https://github.com/apache/calcite/pull/1157#discussion_r285096984
##########
File path: core/src/main/java/org/apache/calcite/rel/core/RelFactories.java
##########
@@ -376,40 +371,12 @@ RelNode createCorrelate(RelNode left, RelNode right,
private static class CorrelateFactoryImpl implements CorrelateFactory {
public RelNode createCorrelate(RelNode left, RelNode right,
CorrelationId correlationId, ImmutableBitSet requiredColumns,
- SemiJoinType joinType) {
+ JoinRelType joinType) {
return LogicalCorrelate.create(left, right, correlationId,
requiredColumns, joinType);
}
}
- /**
- * Can create a semi-join of the appropriate type for a rule's calling
- * convention.
- */
- public interface SemiJoinFactory {
Review comment:
The SemiJoin class was not removed in this PR but it was deprecated. We
should be consistent, and don't remove the factory but deprecate it first!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
