NobiGo commented on code in PR #4214:
URL: https://github.com/apache/calcite/pull/4214#discussion_r2021975089
##########
core/src/main/java/org/apache/calcite/sql/dialect/StarRocksSqlDialect.java:
##########
@@ -128,6 +132,72 @@ public StarRocksSqlDialect(Context context) {
timeUnitNode.getParserPosition());
SqlFloorFunction.unparseDatetimeFunction(writer, newCall, "DATE_TRUNC",
false);
break;
+ case IS_TRUE:
+ if (this.supportMacroLikeUnparse()) {
Review Comment:
We already have RexUtil#isDeterministic for detecting whether a function is
deterministic. Currently, what I'm thinking is that only when there is a
transformation similar to "IS TRUE", where a reference becomes multiple times,
will it lead to inconsistent results. Functions like COALESCE and NULLIF fall
into this category.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
