suibianwanwank commented on code in PR #4214:
URL: https://github.com/apache/calcite/pull/4214#discussion_r2023002422


##########
core/src/main/java/org/apache/calcite/sql/dialect/StarRocksSqlDialect.java:
##########
@@ -128,6 +132,72 @@ public StarRocksSqlDialect(Context context) {
               timeUnitNode.getParserPosition());
       SqlFloorFunction.unparseDatetimeFunction(writer, newCall, "DATE_TRUNC", 
false);
       break;
+    case IS_TRUE:
+      if (this.supportMacroLikeUnparse()) {

Review Comment:
   I agree, any scenario requiring splitting a rexNode into multiple processing 
paths would encounter this problem. But it seems difficult to resolve at the 
root cause - the only solution I can think of is to specially handle it by 
adding an additional Project whenever this situation occurs.  



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to