NobiGo commented on code in PR #4214:
URL: https://github.com/apache/calcite/pull/4214#discussion_r2023877782
##########
core/src/main/java/org/apache/calcite/sql/dialect/StarRocksSqlDialect.java:
##########
@@ -93,6 +94,18 @@ public StarRocksSqlDialect(Context context) {
return true;
}
+ @Override public boolean supportsUnparseOnlyDeterministic(SqlOperator
sqlOperator) {
Review Comment:
If we do not support rewriting this function, we should throw exceptions at
the point of rewriting. We directly convert it because only Starrocks has been
identified to have this issue. If it is discovered later that operations like A
IS TRUE and A IS NOT NULL are also unsupported, exceptions must be thrown
during the conversion process. This conversion logic can be implemented as part
of the Dialect behavior.
If I remove this function, the A IS FALSE will remain unchanged and not be
converted.
What I'm thinking here is that not all dialects have undergone such
transformation. If the database supports A IS TRUE, then we won't make any
changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
